* Sketch: instances stepped in from an arc stop where the arc runs out, not turn round
Each instance after the first takes its side from a point one more step
past the last one. Stepping toward an arc's centre past an arc smaller
than the distance, that point lands beyond the centre, and the side was
read by comparing the point with the two offsets at the full distance:
the one toward the centre doesn't exist there, so the other won and the
next instance went back out onto an earlier one. The side is now read a
hair from the curve, where both offsets exist, and the point stops
halfway to the centre. The arc then runs out of room and the command is
refused there, as for a ring.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Offset side: read off the picked line or arc itself
A tiny step compared at large coordinates rounds away, and an arc left
smaller than that step by an earlier instance still has no offset toward
its centre: both turned the side round. A line's side is now its
half-plane and an arc's inside or outside its circle, as a circle's
already was; other curves compare both offsets' distance as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #9687
* Joints: Edit Joint and Unsuppress meet a conflicting loop joint as Joint does (#9687)
joint.create (#10371) turns an angle a half turn when a new loop-closing joint
comes out as a conflict, so a second planar joint whose faces point the same way
meets. joint.edit never did, so a design saved before that (the report's rail on
two planar joints) kept the conflict however the joint was edited, and a joint
unsuppressed after its part was turned away stayed one too, though Move's hint
says to edit the conflicting joint.
An edit that places the joint again (type, offset, angle, flip, a side, or
unsuppressing it) now tries the same half turns. A rename alone moves nothing.
* Joints: a loop group over the solver's values still moves the loops that need to (#9687)
A frame held by many planar joints (the report's printer: six planar joints
between two profiles, and more) ties its loops into one group through the
shared values. Past MAX_LOOP_VALUES (64) such a group was only checked, so a
new joint closing a loop in it (Joint35, the rail on the 450 mm profile, which
took the group from 63 to 69 values) stayed a conflict, and nothing in the
group could be driven or dragged any more.
Such a group now moves the values of the loops that need to move, those open
at the start or reading a held value that moves, when they are few enough,
while every loop of the group stays a residual, so the others stay closed.
Groups within the cap solve as before.
* Joints: closed loops through a moving value follow on their own closing joint (#9687)
In a loop group over the solver's values, a closed loop that runs through a
value the open or driven loops move (a part slid on one planar joint and held
by a second) kept its closing joint's values, so its gap opened and the solve
failed. Those closing joints' values move too: they are on no tree path, so
freeing them pulls in no further loop.
* Joints: loops a motion link ties to a following closing joint follow too (#9687)
A followed closing joint whose value a motion link sets moves the value its
link chain starts from; closed loops through that value now follow on their own
closing joints as well, until no more do or the values pass the solver's cap.
* Joints: say what the narrowed loop solve does not find (#9687)
* Joints test: measure the peg's 30 degree turn from where the loop left P0 (#9687)
---------
Co-authored-by: MateuszSychXpl <151755914+MateuszSychXpl@users.noreply.github.com>
* Arabic: one spelling of component in the Components from Bodies hint, history filters, delete prompt and appearance help
The catalog writes component as مكوّن (with shadda) in 68 places; five
messages used مكون. They now match.
* Arabic: included-settings label and computer term in the profile rows
* Arabic: tanween spelling in the components-start-open note
* Arabic: OK button name in the Find Limits hint
- Les motifs rectangulaire et circulaire prennent bodies et nomment leurs copies source (2), (3)…, en sautant les noms pris
- Motif de features : nouveau BodyN, comme le miroir ; noms lus dans created_bodies
- Miroir d'une copie : suffixe ajouté ; body.rename pour des noms stables ; renvoi à #8194
Co-authored-by: P'tite Tête <asso@ptitetete.com>
* Keys: a sketch and the model kept apart on Scope
`command_for` fell back to the first enabled command bound to a key, so a model key pressed in
a sketch (F, Fillet) still ran the model command. A key now runs only a command of the scope
the view is in, or one that works everywhere; otherwise nothing fires. Inspecting, views and
file commands (`inspect.*`, `view.*`, `file.*`) count as everywhere, so Measure's I still works
in a sketch. #4432's `sketch_and_model_keys_are_kept_apart` is ported to `Scope`.
Not ready: main's `the_extrude_key_in_a_sketch_finishes_the_sketch` (#2815) expects E in a
sketch to finish it and open Extrude, which this rule stops.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Keys: keep model keys out of sketches as an opt-in preference
The strict sketch/model split is now Preferences > Shortcuts > Keep model
keys out of sketches, off by default. Off, a key resolves exactly as on
main (a feature key such as E still finishes the sketch). On, a sketch
runs only sketch keys and keys that work everywhere (inspect, view, file).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* rustfmt
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Redesign Appearance preferences
* Reach the theme Import card by paging the carousel in the VFS import test
The redesigned Appearance page puts Import as the last theme carousel card,
so the test scrolled the page to a card that was not drawn. Page the carousel
until the card is on screen; both the in-scope and out-of-scope picks are
still checked.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
A hole in a design with sheet metal first tried to bore every sheet of its
component, building each panel and running a boolean on it, and then
checked every sheet again to see whether the drill met it at all. For a
sheet far from the hole both only found nothing: with 50 sheet parts that
was most of a hole's time. Now a sheet whose box lies clear of the
drill's box is left out of both, with the same grown boxes the other
sheet cuts use, so a drill into a sheet's rim still bores it. A drill a
sheet would refuse whatever it meets (an invalid one, or one more bore
than a sheet may hold) is still put to every sheet as before.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The countersink tool was a cone started at the run-on height above the
face, so above the face it was wider than the countersink and kept
widening: a wall or step just past the rim was notched. The tool is now
one revolved profile: the cone from just above the face down into the
hole, and above it a cylinder of the countersink's own diameter. The cone
is the profile's first segment, so its face keeps the name csink:side:0.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #7410
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Sketch Break: break at a shared point separates the curves that meet there (#7410)
Two lines drawn as one chain share their corner point. There was no way to pull them apart:
Break there said "nothing to break at there", and deleting the point deleted both lines.
sketch.break aimed at a point where the picked curve ends and another curve also meets now
gives the picked curve its own end there (`<curve>.start` or `.end` when that id is free), at
the same place: both curves stay where they are and are no longer joined. The Break tool
snaps a click on the corner to that point, so clicking it works the same way.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #7584
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019FAWPuFoh9qxn2uS2j53QZ
* macOS update: say to quit SolidCraft before replacing it (#7584)
After Download and open, the update window told people to drag SolidCraft
to Applications, replacing the old copy, then restart it. Finder refuses to
replace an app that is running ("the item “SolidCraft” is in use"), so the
message now says to quit SolidCraft first, then drag the new copy over and
open it again. "Quit" rather than "close": closing the window on macOS can
leave the app running.
The id update.dmg_opened is unchanged; every catalog that carries it is
updated, and the user guide's update tables get the same step.
Fixes#7584.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019FAWPuFoh9qxn2uS2j53QZ
---------
Co-authored-by: Claude <noreply@anthropic.com>
* claim: #10909
* Crash report commands: input and output schemas (#10909)
diagnostics.crash_reports, diagnostics.crash_report,
diagnostics.crash_reports.clear and diagnostics.crash_test get typed
contracts and reply types in schema/diagnostics.rs and leave
unconverted.txt. Strict now refuses an `id` that isn't text on clear,
which the handler reads as no id and so deletes every report.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* claim: #10898
* Standard views and Normal To: input and output schemas (#10898)
view.front, view.back, view.left, view.right, view.top, view.bottom,
view.isometric and view.normal_to get typed contracts (an optional
`camera`, read by the new shared CameraParam type with the commands' own
reader) and a CameraReply output, and leave unconverted.txt.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
edit.undo, edit.redo, edit.checkpoint and edit.restore_checkpoint get
input and output schemas in schema/edit.rs: the first three take no
keys, the last takes `checkpoint` (with the handler's message for a bad
id) and `forget`. The handlers build their replies from the reply
types. Their lines leave unconverted.txt.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #10938
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Library commands: input and output schemas (#10938)
library.inspect, library.export and library.apply get typed contracts
and reply types in schema/libraries.rs and leave unconverted.txt. The
handlers' own serde parameter types move there and become the
contracts, so the contract is exactly what each handler reads; the
catalog, provenance and apply result schemas are written by hand, since
solidcraft-io doesn't use schemars.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* claim: #10942
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* List Edges, List Faces and List Threads: input and output schemas (#10942)
model.edges and model.faces take a typed `body`; model.threads takes no
parameters. Their replies are built from ModelEdges, ModelFaces and
ModelThreads in schema/inspect.rs, with the same JSON as before, and the
three commands leave unconverted.txt.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* claim: #10949
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Curvature comb, minimum radius, isocurve, centre of mass: schemas (#10949)
The four analysis commands get typed contracts and reply types in
schema/sketch_inspect.rs and leave unconverted.txt. Each point list has
its own type with its handler's messages and reads only as many points
as the handler does; `count`, `density` and `scale` read numbers as
params::num does. The replies are built from the types, with the same
JSON as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* claim: #11059
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Configuration table, rules, activate and preview: schemas (#11059)
config.table, config.rules, config.activate and config.preview get typed
contracts and reply types in schema/config.rs and leave unconverted.txt.
A new `table` builds the table from ConfigTable; show and the activation
build their replies from it, so the unconverted config commands still
return the same JSON.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* claim: #11083
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Boundary Surface: input and output schemas (#11083)
surface.boundary gets a typed contract in schema/surface_boundary.rs and
the shared FeatureResult as its output, and leaves unconverted.txt. One
struct holds both forms; each key reads as the handler reads it, with
its messages, and `u` and `v` check their items where the handler does
without the design, index included.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* claim: #10959
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Loose Ends and Tie Loose Ends: input and output schemas (#10959)
sketch.loose_ends and sketch.loose_ends.tie get typed contracts and
reply types in schema/sketch_ends.rs and leave unconverted.txt.
SketchTarget reads `sketch` as sketch_store::target does and PointIds
reads `points` as the tie does, each with the handler's messages. The
replies are built from the types, with the same JSON as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* claim: #11075
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Bill of Materials: input and output schemas (#11075)
assembly.bom gets a typed contract and reply types in schema/bom.rs and
leaves unconverted.txt. Each key reads as the handler reads it, with its
message; the reply is built from Bom, BomRow and BomChild, in the old
field order, so the reply and the files it writes are unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* claim: #6843
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PsiqyXWBFGTCX9J51bhysc
* Sheet metal: material joined in the plane of a panel is kept (#6843)
An extrude join through sheet metal went through the generic boolean:
the body grew, but the sheet model didn't, so the flat pattern, DXF and
bend table were refused, and the next sheet feature (a refold) dropped
the material ("what ... changed is not kept").
An untapered extrude join one sheet thick in the plane of a panel (the
base or a flange's panel, unfolded or folded) now joins the sheet model:
each region of its sketch becomes part of the one panel it is one piece
with, apart from every bend zone and the other panels, so the flat
pattern, its DXF and a refold keep it, and it follows its sketch's
parameters as a cut made there does. Cut-outs it covers are filled. A
join of another depth, out of every panel's plane, touching a bend zone
or another panel, or over a pocket, label, bore or perforation keeps the
generic path and its warning.
The extrude records its sketch plane and depth for a join too (its
profile grows into the material it joins, so it never counted as
untrimmed). The test that refused a joined tab beside a plain base now
refuses a block standing on the sheet instead; the tab is kept.
Fixes#6843.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
On the Blacksmith CI runners two quick same-size writes can share a modification time, and a
stale review page once accepted changed art there
(test_changed_art_reopens_and_requires_deliberate_current_acceptance failed intermittently).
art_rev() now hashes every file by content on main (b622a466); this test keeps it that way by
giving an edited SVG its old timestamp back and checking that the stale page is refused.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #5968
* Joint dialog: Find Limits fills the limits from where parts collide (#5968)
joint.find_limits sweeps each value of a joint both ways from where it is,
on a copy and with its own limits left out, and answers where the parts it
moves first touch another part, where a closed loop stops closing, or that
nothing is met within a turn (angles) or the parts' reach (distances).
Edit Joint's Limits section gets a Find Limits button that runs it on the
joint as the dialog has it, off the window thread, and fills the rows.
joint.sweep now tells touching bodies apart from the other bodies of the
same two parts: on the Hinge Assembly sample the pins touch where it starts,
and the plates used to pass through each other unnoticed.
* find_limits: read the session only
* find_limits: a joint with nothing to meet, edits during a search, tiny ranges
* find_limits: keep touching at the start per pair of parts
Per body, the Hinge Assembly sample's plates, which only come flush in
the end plane the two leaves share, stopped the search. The leaves never
pass into each other: the sample's answer is a whole turn.
* find_limits: touching boxes cost no collision work; stale results and rounding
* find_limits: each pair of bodies of resting parts held to its own depth; loops without bodies
* find_limits: a 32-bit budget it can pass, a repaint with the result, a bad form says so first
* find_limits: each pair of resting bodies gets its own margin
* find_limits: Arabic, Hebrew and Vietnamese strings (complete catalogs on main)
* find_limits: search the joint with Edit Joint's side picks
Edit Joint now keeps the joint's sides as picks in its inputs, and its OK
commands compare them with what it opened on. Built without them, the
commands Find Limits applies first asked for the sides again, so every
search failed.
---------
Co-authored-by: MateuszSychXpl <151755914+MateuszSychXpl@users.noreply.github.com>
A tapped hole looked for the cylindrical wall its marking lies on in
every face of every body of the design, measuring each face over all of
its body's triangles. A body is now passed over when the drill line,
widened by the hole's radius and a margin, misses its box (from the
mesh it keeps, which the wall's triangles are part of): no face there
can be the wall, so the marking stays the same.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #8151
* Opening: a design saved by 0.24 keeps the body a Join To Object runs to (#8151)
Since 0.24.1 a Join extrude To Object also joins the body it runs to
(#6424). Designs saved by 0.24.0 and earlier were built without that,
so on 0.25 the reported box swallowed its lid: the lid's sketch, the
holes, the cut and the moves after it failed.
An extent may now save `to_body_apart: true`, which leaves that body
apart. One pending format change sets it on every Join extrude To
Object of a design of format 39 or older as it opens; designs of
format 40 and later keep the join. Editing the extrude keeps the field.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Markus Kaltenbrunner <kaltenbrunnermarkus@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
A pattern or mirror replays its source hole's definition, so a hole with
reference edges finds its centre again from them. That happens after the
hole is drilled: through the part, the centre is then in the opening, and
the check that the centre lies on the face refused every copy. The replay
now skips that check; placing the hole itself still makes it.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Before a cut ran, every sheet metal body of its component went through a
boolean with the tool, to make sure the cut would not take material the
flat pattern cannot keep. For a sheet the tool does not reach, that check
only found nothing: in a design of 50 sheet parts it was about an eighth
of a hole's time. Now a sheet whose box lies clear of every tool's box is
left out of the check, with the same grown boxes the cut itself uses
(#10225), so a tool that touches or grazes a sheet is still checked.
Sheets shown in another frame and Intersect are checked as before.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #9274
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Browser: placements start closed (#9274)
A large assembly opened with every placement unfolded, so the browser was a
long list to scroll through. Placements now start closed; opening one shows
its own placements still closed, and closing and reopening it leaves them as
they were. Find in Browser, a pick in the view, Expand All and Collapse All
open and close them as before.
Preferences > Interface > Components start open (browser_components_open)
keeps every placement open from the start, as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Browser: scenarios and the icon audit open placements, which now start closed
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Browser: tests that read rows inside placements set the open-placements preference
Three tests added on main since this branch started (joint folders, Features
folder marks, group rename) look at rows inside placements, which now start
closed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: bherbruck <tenbee91@gmail.com>
Co-authored-by: bherbruck <brennen.herbruck@gmail.com>