* claim: #11083
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Boundary Surface: input and output schemas (#11083)
surface.boundary gets a typed contract in schema/surface_boundary.rs and
the shared FeatureResult as its output, and leaves unconverted.txt. One
struct holds both forms; each key reads as the handler reads it, with
its messages, and `u` and `v` check their items where the handler does
without the design, index included.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* claim: #10959
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Loose Ends and Tie Loose Ends: input and output schemas (#10959)
sketch.loose_ends and sketch.loose_ends.tie get typed contracts and
reply types in schema/sketch_ends.rs and leave unconverted.txt.
SketchTarget reads `sketch` as sketch_store::target does and PointIds
reads `points` as the tie does, each with the handler's messages. The
replies are built from the types, with the same JSON as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* claim: #11075
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Bill of Materials: input and output schemas (#11075)
assembly.bom gets a typed contract and reply types in schema/bom.rs and
leaves unconverted.txt. Each key reads as the handler reads it, with its
message; the reply is built from Bom, BomRow and BomChild, in the old
field order, so the reply and the files it writes are unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* claim: #6843
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PsiqyXWBFGTCX9J51bhysc
* Sheet metal: material joined in the plane of a panel is kept (#6843)
An extrude join through sheet metal went through the generic boolean:
the body grew, but the sheet model didn't, so the flat pattern, DXF and
bend table were refused, and the next sheet feature (a refold) dropped
the material ("what ... changed is not kept").
An untapered extrude join one sheet thick in the plane of a panel (the
base or a flange's panel, unfolded or folded) now joins the sheet model:
each region of its sketch becomes part of the one panel it is one piece
with, apart from every bend zone and the other panels, so the flat
pattern, its DXF and a refold keep it, and it follows its sketch's
parameters as a cut made there does. Cut-outs it covers are filled. A
join of another depth, out of every panel's plane, touching a bend zone
or another panel, or over a pocket, label, bore or perforation keeps the
generic path and its warning.
The extrude records its sketch plane and depth for a join too (its
profile grows into the material it joins, so it never counted as
untrimmed). The test that refused a joined tab beside a plain base now
refuses a block standing on the sheet instead; the tab is kept.
Fixes#6843.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #5968
* Joint dialog: Find Limits fills the limits from where parts collide (#5968)
joint.find_limits sweeps each value of a joint both ways from where it is,
on a copy and with its own limits left out, and answers where the parts it
moves first touch another part, where a closed loop stops closing, or that
nothing is met within a turn (angles) or the parts' reach (distances).
Edit Joint's Limits section gets a Find Limits button that runs it on the
joint as the dialog has it, off the window thread, and fills the rows.
joint.sweep now tells touching bodies apart from the other bodies of the
same two parts: on the Hinge Assembly sample the pins touch where it starts,
and the plates used to pass through each other unnoticed.
* find_limits: read the session only
* find_limits: a joint with nothing to meet, edits during a search, tiny ranges
* find_limits: keep touching at the start per pair of parts
Per body, the Hinge Assembly sample's plates, which only come flush in
the end plane the two leaves share, stopped the search. The leaves never
pass into each other: the sample's answer is a whole turn.
* find_limits: touching boxes cost no collision work; stale results and rounding
* find_limits: each pair of bodies of resting parts held to its own depth; loops without bodies
* find_limits: a 32-bit budget it can pass, a repaint with the result, a bad form says so first
* find_limits: each pair of resting bodies gets its own margin
* find_limits: Arabic, Hebrew and Vietnamese strings (complete catalogs on main)
* find_limits: search the joint with Edit Joint's side picks
Edit Joint now keeps the joint's sides as picks in its inputs, and its OK
commands compare them with what it opened on. Built without them, the
commands Find Limits applies first asked for the sides again, so every
search failed.
---------
Co-authored-by: MateuszSychXpl <151755914+MateuszSychXpl@users.noreply.github.com>
* claim: #8151
* Opening: a design saved by 0.24 keeps the body a Join To Object runs to (#8151)
Since 0.24.1 a Join extrude To Object also joins the body it runs to
(#6424). Designs saved by 0.24.0 and earlier were built without that,
so on 0.25 the reported box swallowed its lid: the lid's sketch, the
holes, the cut and the moves after it failed.
An extent may now save `to_body_apart: true`, which leaves that body
apart. One pending format change sets it on every Join extrude To
Object of a design of format 39 or older as it opens; designs of
format 40 and later keep the join. Editing the extrude keeps the field.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Markus Kaltenbrunner <kaltenbrunnermarkus@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
A pattern or mirror replays its source hole's definition, so a hole with
reference edges finds its centre again from them. That happens after the
hole is drilled: through the part, the centre is then in the opening, and
the check that the centre lies on the face refused every copy. The replay
now skips that check; placing the hole itself still makes it.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
`sketch.rectangle.rounded` read `p0` and `p1` with `req_vec2`, so a corner typed as an
expression (`["W / 2", "H / 2"]`) was refused with "`p0` must be a point [x, y]", although the
2-point rectangle it hands the corners to already places expression corners and keeps them
following their parameters. The corners are now read with `corner_arg`, as the 2-point and
center rectangles read theirs; the worked-out values still check the radius against the sides.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Convert to Sheet Metal refused a tray made with SolidCraft's own sheet metal, exported and
imported again: its walls run on past each bend's end (notch, tear and round corner reliefs), so
the edges beside the bend cylinder's edge never reach the other face's plane and the face could
not be trimmed ("a face beside a chamfer picked as a bend does not reach the face across it").
Where that edge is round or runs on along the bend's line, the face now keeps its corner and
steps down square to the other plane, a step the bend's setback takes up again; the inset drops
an edge the setback leaves shorter than the tolerance.
Test: trays_of_its_own_sheet_metal_convert_back (notch, tear and round, the walls made in one
flange feature, and notch and round with the short walls in a second one): the volume, the flat's
size and outline area and every bend's length are the source's.
Fixes#7529.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #6452
* Engine: a pattern or mirror copy of a join keeps its ends as drawn (#6452)
The copy's tool is rebuilt against the current state, which already holds
the source feature's own material; the embedded-join-end trim (#2059)
read that material as the target already filling the copy's bottom band
and trimmed it away before the copy matrix was applied. Mirroring or
patterning a join on a hollow part silently lost the floor-level slice.
Copies now skip the trim: their ends are where the source drew them.
* chore: re-trigger duplicate PR check
---------
Co-authored-by: Dahak Builds <dahakbuilds@users.noreply.github.com>
Breaking a dimensioned line left the length on the first piece, which the solver stretched
back to the whole length, skewing the line. A cut on (or a hair from) an end, as where a tangent
arc meets a line, made a zero-length piece with its coincident and collinear ties every time
Break was clicked there.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The refusal of sketch.project ended in "face of " with nothing after the
"of" when the reference named no body: a picked face, edge or vertex is
found by its geometry, so the body it belongs to is not in the reference.
LinkSource::describe() now drops the "of <body>" when there is no body to
name and names the kind alone ("face", "edge", "vertex", "spun
profile", "isoparametric curve"). A source that names a body keeps its
name.
Only the text changes: the command refuses exactly what it refused before.
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
A hole placed on the side of a cone with no direction drilled along
the nearest display-mesh triangle's normal, up to 2.6° off the
surface's normal and sideways. Planes, cylinders and spheres already
gave their exact normal; cones and tori now do too, from the surface
the kernel reports for the face.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Move to Component: a sketch on a face inside the moved part goes along (#11063)
A face attachment stores the placement path it was found through. Moving
the placement into another component changes that path, the stored one
no longer starts at the design, and the move was refused as breaking
the sketch. Face attachments of sketches and construction planes, and
an emboss's face, now follow the move as the session's paths already do.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Move to Component: attachments made through any placement of the old parent follow
A parent placed more than once is one definition: a face attachment made
through another placement of it than the one named also ran through the
moved placement and broke. Every stored path through the moved placement
now runs through its new place. A path that would grow past the 64
placements a design keeps is refused instead of saved unreadable.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
A flange picked on one segment of a stepped base outline ran the base
face's whole length: trimming the picked edge back to the bend line
merged it with the outline's own edge on that line beyond the step, and
the flange took the merged edge. It now stays off the base's edges that
already lay on the bend line, so it spans the segment picked, with no
relief there: the base is already back at the bend line. The same
outline made by cutting notches into a rectangle gave the right flange
already.
Assisted-by: LLM
* Sketch: a dog bone's outline outside it meets outside both notches (#10984)
Where two tangent arcs touch at a cusp, the copies of the two arcs cross
twice, both crossings as far from the cusp, and rounding chose one: on
one side of a dog bone the outline ran both copies on and drew a loop
into the bone. Such a tie now takes the crossing that cuts both copies
short.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Dog bone test: the outline goes outside, away from the picked bottom line
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #9914
Co-Authored-By: Claude <noreply@anthropic.com>
* test: Move/Copy copy of a picked component (#9914)
Tests for a component picked in Move/Copy with Create Copy: it is copied as an
independent component placed with the move, the original stays, one undo removes
the copy; a body picked with Create Copy stays a body copy; a component picked
without Create Copy moves its bodies as before.
Co-Authored-By: Claude <noreply@anthropic.com>
* fix: Move/Copy copies a picked component as a component (#9914)
With Create Copy ticked and the component pick mode on (or a Browser component
row), a picked component is copied as an independent component (Paste New,
component.paste_new) and the copy moves by the move's transform (occurrence.move
in the world). Bodies picked still copy as bodies; without Create Copy a component
still moves its bodies. The copy and the bodies are one undo step.
Co-Authored-By: Claude <noreply@anthropic.com>
* fix: solid.move copies of components reply like a move and roll back (#9914)
A copying move with components replies as a solid.move does: the bodies' feature reply,
with the copies listed in occurrences. The bodies are mapped to their frame before any
copy is made. The solid.move help documents occurrences. A copy that fails part way
changes nothing and leaves no undo step.
Co-Authored-By: Claude <noreply@anthropic.com>
* fix: Move/Copy takes a picked component whether or not Create Copy is ticked (#9914)
A component picked in the component pick mode, or a Browser component row, goes into
the Move bodies input as a component, so Create Copy can be ticked after picking it.
Without Create Copy the component still moves its bodies. Not while editing an
existing move. The Browser model tests read the bodies the command would move.
Co-Authored-By: Claude <noreply@anthropic.com>
* fix: Move/Copy preview draws a copied component where the copy lands (#9914)
The fast preview took the component's bodies from the listed occurrences as well as the
bodies, drawn moved by the move, so a component copy previews at the moved place
instead of the scratch design's unplaced states. Test: a component-only copy and a
mixed copy preview where the copy lands.
Co-Authored-By: Claude <noreply@anthropic.com>
* fix: a copying move refuses bodies that are not a list (#9914)
With components, a bodies value that is not a list was ignored; without components it
is refused. It is refused now, before anything is copied.
Co-Authored-By: Claude <noreply@anthropic.com>
* test: an edited move never takes a component pick, through the click (#9914)
Clicks the component in component pick mode while an existing move is edited: the pick
stays a body. Fails when the editing condition is dropped.
Co-Authored-By: Claude <noreply@anthropic.com>
* fix: Move/Copy preview takes components only for a copy, and the mixed test can fail (#9914)
The engine refuses `occurrences` without `copy`, so the preview leaves
such params to the full preview too. The mixed-copy test now gives the
component a taller box, so its height shows the component was drawn.
Co-Authored-By: Claude <noreply@anthropic.com>
* docs: component_pick no longer needs Create Copy ticked (#9914)
Co-Authored-By: Claude <noreply@anthropic.com>
* test: a component picked with its parent is copied once (#9914)
Co-Authored-By: Claude <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* Hole: a hole moved off the material says it removes no material (#10701)
A hole whose position, parameter or sketch point moves it off the part
cut nothing and said nothing: the feature had no warning, and a
parameter sweep listed the value as fine. A hole whose tool is clear of
every body it cuts now warns "the hole removes no material" ("1 of 2
holes remove no material" for several), as a pattern does of its
copies. The check compares boxes only, from the meshes the hole already
found its face on, so a large hole pattern costs no extra booleans.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Hole: a hole wider than the part says it removes all of it (#10702)
A through hole wider than the part removed the whole body with no
message, also when a parameter widened it later. The hole now warns
"the hole removes all of Body1" when a body it cuts is gone after the
cut.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #10127
* Assemblies: a construction axis follows its component when the component rotates (#10127)
A construction axis or point built on a body now goes with that body when
Move/Copy moves or turns it. Each construction records the bodies its picks
lie on; the Move feature (not a copy) carries along every construction whose
bodies it all moved, with the same transform in the construction's component
frame. One that also reads something fixed stays where it is.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Markus Kaltenbrunner <kaltenbrunnermarkus@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
sheet.fold refused any fold whose bend zone wasn't a rectangle. It now
crosses the sheet's own outer edges, slanted or on any curve: the outline
is cut exactly across the zone, the panels keep their real outlines, and
flanges and other folds still go on them. The flat pattern's DXF keeps the
curve as drawn. A sharp corner in the zone stays refused.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
On Windows the token file is restricted with `icacls`, which may not finish in time (#6145). That
counted as success everywhere, and is safe in the default folder, the user's own local app data.
A folder picked with SOLIDCRAFT_CONTROL_DIR may be readable by others, so there a timeout now
removes the still empty file and returns an error. The default folder behaves as before. The
decision is a small function of its own, tested without running icacls.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
A Cut To Object on a curved face ran the tool through the target and kept
the tool less the body, the piece at the start. From outside a curved wall
to its inside face that piece is the air before the wall: the cut took
nothing, or the tool lay in the curved face and the boolean failed on the
coincident faces.
Where the target's material ends at the picked face under the whole
profile (rays over the profile cross it once, material before, none
after), the tool now ends flat halfway across the gap beyond the face. It
takes what lies before the face and meets no face of the body. Otherwise
the trim is as before.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Save As: refuse a name that opens as another kind of file (#9745)
file.save and file.save_as wrote a design container under any name, so a
design saved as part.step was refused when opened again and part.stl opened
as a broken mesh. A name doc.open reads as a STEP/CAD exchange file, a mesh,
a 2D drawing, a point cloud or a SolidCraft drawing is now refused, pointing
to .sc and, for export formats, to file.export. Names that open again as the
design (.sc, legacy extensions, .json, anything else) save as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Save As: check the folder scope before the design name (#9745)
A path outside an agent's folders is refused for that first, whatever its
extension, as before; the design-name check runs after it in `write`. Fixes
solidcraft-mcp tests::tool_calls_stay_inside_the_agents_folders, which saves
`x.step` outside the agent's folders and expects the scope refusal.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: 10331
* Assemblies: a second planar joint turns its part a half turn to meet (#10331)
A second planar joint between two boards that mates faces pointing the
same way needs the board turned a half turn on the first joint. The loop
solve starts exactly turned away, finds no way round, and left the new
joint as a conflict; Move then said the part has no movable joint axis.
A new loop-closing joint now tries its own angle, each angle on the
joint path between its two parts, or one of each, a half turn round, as
the first joint of a chain moves its part into place, and keeps the
first that closes the loop without a new conflict. Faces that can never
meet stay a conflict and nothing moves.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Move test: give the blocked part faces that can never meet (#10331)
The blocked-Move test from #10509 used two boards whose second planar
joint mates two faces pointing the same way. That joint now closes its
loop with the board turned a half turn, so the scenario no longer
conflicts. Mate the yellow front against the red top instead, which no
turn on the first joint can bring together.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Markus Kaltenbrunner <kaltenbrunnermarkus@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
A relation given no values already started from where its parts sit
(relation_values), so the part moves no further than it must. A typed joint
(planar, revolute, cylindrical ...) added between parts another joint
already relates started its values at 0 instead, so the loop solver began
far from the current placement and could report a conflict for a joint that
agrees with how the parts are placed.
Seed every loop-closing joint, typed or relation, from the current
placement when no values are given. Joints in an open chain and joints with
explicit values keep their initial values as before.
* claim: #10316
* Insert Part: ASME/ANSI inch hex cap screws, hex nuts and SAE/USS washers (#10316)
Part of #10316. New standard-part families, tabled in inches as the
standards give them and built in millimetres: hex cap screw (ASME
B18.2.1) and hex nut (ASME B18.2.2), 1/4 to 1 in UNC and UNF from the
thread catalogue, and plain washers SAE and USS (ANSI B18.22.1 Type A).
Cap screws take the standard inch lengths, 1/2 to 8 in, defaulting to
the first at or above 2.5 d.
Lengths read as fractional inches in Insert Part, Change Part Size, part
names and part numbers. Insert Part gains a Unit system list (Metric,
Inch) above Type; it opens on Metric. parts.library reports each
family's system.
Inch parts get no cosmetic thread: solid.thread takes only metric
designations (#9571), and the old path would have made a wrong metric
mark. 9/16 waits for the thread catalogue; split lock washers and
carriage bolts follow in later PRs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The editor accepts revision changes that only changed what is shown,
counted by the display revision, but only hiding and showing counted
there. Section Analysis, the surface analyses, continuity, the
selection, the status pill catching up and view.render_select bumped
the revision alone, so turning a section off with an editor open made
OK refuse ("the design changed while the feature editor was open") and
Cancel leave the timeline rolled back. They now go through
refresh_display, as visibility changes do.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #10852
* Circular pattern: the axis origin takes length expressions and follows them (#10852)
solid.pattern.circular with axis {origin, dir} kept its origin as plain
numbers, so a pattern about a parameter-driven point stayed where the
point was when the pattern was made: the seed moved with the parameter
and the copies did not. Expressions were refused (#248).
The pattern's origin is now a point of expressions, as a Mirror plane's
origin is: numbers or length expressions, evaluated on each rebuild, and
renamed with their parameters. Plain numbers are saved as numbers, as
before. timeline.edit sets pattern.origin as expressions, and editing the
pattern in its dialog keeps them. One pending format change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* claim: #9660
Signed-off-by: Maurizio Monticelli <maurizio@whatwedo.ch>
* Move bodies of differently turned components in the world together (#9660)
A Move feature moves each of its bodies in the body's own frame by one
vector and one turn. `solid.move` mapped the world vector and axis into
the frame of the first body listed only, so a body in a frame turned
otherwise (a part inserted with a non-default direction, moved together
with a block of the root) moved along its own axes.
When the bodies listed lie in frames that turn differently (or, for a
turn, also sit in different places), the move is now split into one
Move feature per frame, each with the vector and axis mapped into that
frame, in one undo step. Bodies sharing a frame still make one feature.
Fixes#9660
Signed-off-by: Maurizio Monticelli <maurizio@whatwedo.ch>
---------
Signed-off-by: Maurizio Monticelli <maurizio@whatwedo.ch>
A surface extruded from a fit-point spline is one B-rep face per span,
joined by hidden seams; the viewport picks and highlights it as one face
(Mesh::surface_patch). sketch.intersection_curve turned a face pick into
the single nearest face, so the curve stopped at that span's ends.
project3d::mesh_of now returns the picked face's surface patch and
mesh_intersection keeps the triangles of every face in it. Body sources
and Project to Surface are unchanged.
* claim: sectiontilt
* Section Analysis: tilting the plane no longer rebuilds the outline index every frame (#10373)
The section outline cut through an index of slabs along one normal, rebuilt
whenever the normal changed: tilting a Section Analysis rebuilt it every
drag frame (about 0.15 s on a 2.5 million triangle part). The index is now a
grid of cells holding each triangle by where its box sits, with the box
around each cell's triangles, so it serves every normal. It finds the same
segments, in the same order and to the bit, as cutting every triangle.
The viewport keeps one index per shown body mesh, no longer per normal.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Markus Kaltenbrunner <kaltenbrunnermarkus@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
`sheet.perforate` takes an optional `sketch` (and `profiles`): the field's
outline. Holes go only inside its closed profiles, out of their inner loops,
`margin` clear of its edges, on a grid from the outline's lower-left corner.
On a folded sheet the outline maps through each panel the sketch lies on and
is clipped to it, so it never reaches a flange in the flat; a sketch on no
face of the sheet is refused. A mirrored copy mirrors the outline, and an
edit that names no sketch (the Perforate dialog has no outline) keeps it.
Without a sketch the field covers the whole sheet as before.
The feature saves `sketch` and `profiles`, a sheet's perforation its outline
in flat coordinates: one pending format note, no migration.
Assisted-by: LLM
* claim: #8822
* Tangent Plane: line it up with a reference plane, at an angle (#8822)
`construct.plane.tangent` takes an optional `reference` (a plane or planar
face) and `angle`. On a cylinder, cone or torus the plane touches where the
face turns towards the reference, turned by the angle about the face's axis,
on the side of the pick; on a sphere it is parallel to the reference. The
plane follows the reference when it moves. The Tangent Plane dialog gets a
Reference plane input and, once one is picked, an Angle field; editing the
plane brings both back. Saved as a pending format change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #9373
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Timeline folders: editing a feature in a folder leaves no stale id, and such designs open again (#9373)
timeline.redefine runs the edited feature's command on a scratch copy with the marker just after
the feature, and takes the new definition from the feature that run makes. Inside a timeline
folder that trial feature joined the folder too; it was removed from the feature list but not
from the folder, and its id, handed back, was the next feature's. Each edit left that id in the
folder (the same one, edit after edit), naming no feature or, once a later feature took it, a
feature twice, and the reader then refused the design: "damaged design: invalid feature in a
timeline folder". The trial feature now leaves the folders as it leaves the feature list.
The reader drops a folder entry naming a feature or joint the design doesn't have, or one a
folder already holds, and opens the design: folders only group the timeline, so nothing else is
lost. A folder damaged in itself is still refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
A mirror of placed bodies follows its source, so each frame of a drag evaluated
it and made new copies with empty mesh cells. A reflection can't share its
source's triangles, so every copy was tessellated from nothing, and so was
anything an evaluated feature after the mirror made.
Keep the first copy of a body with its source: each later copy is a proper rigid
move of it, so a world state draws them from one set of triangles. The model
keeps each copy's own lazy mesh. A feature evaluated again that gives the same
solids (an import) keeps its meshes.
A mirror of placed bodies no longer searches its copies' revolved faces when no
later feature can build on bodies. That depends on the design alone and is part
of the mirror's placement digest.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* wip: the diagnosis of #10181 (the bug reproduces on current main)
sketch.project has .enabled(in_sketch) (crates/engine/src/cmd/sketch_project.rs:24)
and in_sketch (crates/engine/src/cmd/mod.rs:285) answers 'no sketch is being edited'.
Pressing P outside a sketch goes keymap::press -> sketch_tool_for
(crates/ui-egui/src/keymap.rs:451-457) -> app.start("sketch.create") with
d.then_start = Some("sketch.project"): the sketch IS created, but the Project
dialog opens and the command is refused, so the dialog shows the red row and the
'Create Issue...' button, which opens the Report a bug form over the viewport.
The probe here reproduces the bug on the CURRENT main (two variants). It is a
diagnostic probe, not the regression test: it must be replaced before a PR.
* test: a context error offers no Create Issue button (#10181)
The Project panel showed the red row for a CONTEXT error ('sketch.project is not
available right now: no sketch is being edited') and offered the 'Create Issue...'
button, which opens the Report a bug form over the viewport. A context error is
not something to report, so the panel must not offer it.
RED: the test fails with the exact message of the issue.
* fix: a context error is not something to report (#10181)
The Project panel offered "Create Issue..." for the error the engine
raises when the command is not available in the current context
("`sketch.project` is not available right now: no sketch is being
edited (Create Sketch or Edit Sketch first)"). That refusal is guidance
about the context, not a failure of the design, so there is nothing to
report: ending the sketch under an open Project panel should not invite
the user to file a bug.
error_rows already spared the missing-pick errors ("select ...", "pick
...") the same way. It now spares the context refusals too, using the
engine's own kind rather than the message text: CommandSpec gains
disabled_refusal, which is the engine's own Disabled refusal for the
command in the current session, and the UI matches the dialog's error
against it. A real failure of the command (an invalid face, say) still
shows the red row with "Create Issue...".
* style: rustfmt the test of #10181
The formatter joins the two asserts of the test onto one line (the
repository sets max_width = 150 and use_small_heuristics = Max). The
tokens of the file are unchanged: the diff is the line breaks of the
asserts and nothing else.
* Tangent Arc: a first click off a curve's end is refused at once, saying where to click (#10653)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Tangent Arc: a first click off a curve's end is refused at once, saying where to click (#10653)
The Tangent Arc tool took any first click as its start; a click on a
line between its ends snaps to a place that is no point yet (on:l3:...,
mid:l1), and the second click then failed with "unknown sketch point"
naming that internal reference.
The tool now refuses such a first click at once, with its own hint as
the error, asking the command's rule (tangent_arc_starts_at, factored
out of arc_tangent: the picked point or one at the same place, and a
drawn curve leaving it). The command refuses a snapped start with its
existing message that start must be the end point of a line or arc.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* Tests: the autosave scenario crashes once its autosave has landed (#10690)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Tests: the autosave scenario crashes once its autosave has landed (#10690)
s25_autosave_recovery 'crashed' right after the extrude; under load the
autosave of it, written on a worker thread, had not landed, so the next
launch recovered the earlier autosave without the body (step 16).
The harness's crash restart now runs frames, bounded, until the active
autosave has caught up (Autosaver::caught_up: no write running and the
last autosave holds the design as it is). The app's own ticks still do
the writing, so an autosave that stopped writing still fails the test.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* Sketch: Remove Spline Point takes one fit point out of a spline (#10783)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Sketch: Remove Spline Point takes one point out of a spline (#10783)
sketch.spline.remove_point takes one fit or control point out of a
spline. The spline keeps its id and runs through its other points, which
stay where they are. The point goes with the constraints on it, unless
another curve uses it. A closed spline's closing point, an end joined to
other geometry, the last 2 points (3 when closed), and projected, offset
or patterned splines are refused with a message.
The right-click menu of a spline point, picked alone, offers it beside
Reverse Spline Direction.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* claim: #10703
* Sketch: do not tie expression-placed points to the origin with an automatic Coincident
A point whose coordinates are parameter expressions follows those
expressions. When they came to 0 at draw time the point landed on the
origin and connect_points tied it there with a Coincident, exactly like
a snapped click; the next parameter change then conflicted with the tie.
connect_points now skips points that carry exprs; plain-number points
keep the snap.
---------
Co-authored-by: Dahak Builds <dahakbuilds@users.noreply.github.com>
* Face names: one name on two bodies is no split face (#10699)
A hole placed on the top of one of two bodies an extrude made, or on a
piece of a split body, warned "face `F2:top` was split; using the piece
nearest the picked point": the face name is on both bodies, and any
name found more than once counted as split. A name on several bodies,
one face on each, now finds the face the point lies on without the
note; pieces on one body, or a point on none of them, still say split.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Hole: look for a face name shared by two bodies on the body the point is on (#10699)
The lookup over every body counts a name on several bodies as split on
purpose (a copy's face is not a piece of the source's, see
`the_same_face_on_a_copy_is_not_a_piece_of_the_named_bodys_face`), so
the first change, which made it unique there, is undone. A hole whose
face name is found split while its point lies on one of those faces now
looks again on that body alone: one face of the name there is the face,
whole; pieces on that body still say split.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #10874
Co-authored-by: Cursor <cursoragent@cursor.com>
* Insert drawing: name the sketch size cap when a file is too dense (#10874)
A large SVG/DXF failed with opaque \"sketch is too large\". Say the 20000 point/curve limit and that scale alone does not reduce entity count, and refuse dense drawings before adding them.
Co-authored-by: Cursor <cursoragent@cursor.com>
---------
Co-authored-by: Cursor <cursoragent@cursor.com>