Commit Graph
776 Commits
Author SHA1 Message Date
jyvikoandClaude Opus 5.5 6a780de5fd Tests: the helical groove's removed volume from the cut's exact volume, not a 0.01 mm mesh's
faceted_cut_of_a_helical_groove took the volume removed as the shaft's exact volume less the cut
body's mesh volume at a 0.01 mm chord. That mesh sags inside the shaft's round wall: the uncut
shaft's own mesh at 0.01 is 0.18 mm³ short of pi r^2 h, five times the 3 % the groove is held
to, so the groove read 1.326 where the screw integral gives 1.2214 (the section's 2 pi int r dA
over 4 turns plus the ramp at z = 0). The cut is a B-rep: its exact volume (measure) gives the
removed volume within the 3 %.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:07:50 -04:00
jyvikoandClaude Opus 5.5 39e1dcea03 Faceted boolean: a body's own mesh is closed once its faces' shared corners are one vertex
faceted_boolean took the tool mesh's triangles by vertex index and refused any edge not shared
by exactly two triangles. A body's mesh (Body::mesh) gives each face its own vertices, the faces
along an edge the very same points, so a box's mesh came in as six open patches: "the mesh is
not closed". Corners at the very same point are now one vertex first (triangles keep their order,
so the history's triangle faces are unchanged).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:07:50 -04:00
jyvikoandClaude Opus 5.5 e0d5ee4963 Tests: thicken and raised-band histories checked as SMLib reports them, Meet edges and seams included
check_kept panicked on any edge origin that was not an operand's edge, but a new edge where two
faces meet has a Meet origin by the history's contract (EdgeOrigin::Meet), and SMLib's history
gives them: the raised band's and the thickened sheet's new edges. It now checks the edges an
operand still owns and passes over the meetings. The thickened sheet is the whole cylinder side
(SMLib's one face, truck's half): a wall stands along each of its free edges, the two rims, and
none along its seam, which the face meets itself along (2 + 2 faces, not 2 + its 3 edges).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:07:50 -04:00
jyvikoandClaude Opus 5.5 2b22b2cbe3 Tessellation: a face's sides are flipped where the triangles lie closer along the surface the other way
A layout can leave triangles standing on their long side across the surface:
their corners on it, their plane across it. They count several times the area
under them (the front triangle's loft tubes 0.7% and 1.1% over the finer mesh)
and no split repairs them, since each half stands the same way.

After the sag refinement a post-pass flips a side inside the face when the
two triangles on it turn less from the surface normal the other way (by more
than a degree), keep their orientation in (u, v) and against the surface
normal (nothing folds), have area in 3D, and the new side and triangle middles
stay within the tolerance of the surface or no farther than before. Boundary
sides are never flipped.

Test: tess triangles_standing_across_a_curved_sheet_are_flipped_along_it; the
boolean_regression joined_loft_frames_reference_mesh_covers_each_face_once
case now passes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:07:50 -04:00
jyvikoandClaude Opus 5.5 666ccd85d5 Tessellation: sag refinement splits a flat triangle's long side and never across an obtuse one's short side
Refinement split the side of a triangle that sagged most. Where a long
inner side lies on the surface at its middle (a section with an inflection,
a loft tube of the bike frame's front triangle) and the triangle's short
sides sag, only the short sides were split: each split left a child with the
long side and its vertex nearer to it, and the triangle beside a split side
lost its shape the same way. The triangles flattened onto the long side
without end, refinement ran to its point budget, and the mesh of the face
counted 3.4 times its area (1.45 times on a second tube).

A triangle whose widest angle is past 150 degrees now splits its longest
side, and a split never goes across an obtuse triangle's shorter side: that
triangle's longest side is split first, along the path (Rivara's
longest-edge propagation, its lengths growing, so it ends). Only sides inside
the face are split, as before.

Test: tess sag_refinement_across_an_inflection_ends_without_slivers, a sheet
with an S section meshed with a triangle flat on the chord across its
middle; it ran to its budget of 20000 points before and adds 28 now.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:07:50 -04:00
jyvikoandClaude Opus 5.5 47b1d716d0 Tessellation: a whole sphere's loop starts off its poles when its seam has two segments
A whole sphere as one face has its seam as its only edge, used both ways. In a body many times
its size the seam gets two segments at the body's chord (pole, equator, pole), so no node off
the poles follows a node off them, and the loop kept its first node, a pole: its closing step
crossed the other pole, which the drift unwrapped to a whole turn ("boundary winds around the
surface"). The sphere was left out of the mesh (cut_beside_a_sealed_void_keeps_the_body: a void
r 2 in a 75 mm part, "1 face(s) don't mesh"). The loop now starts, failing a node with an
off-pole predecessor, at a node whose predecessor is a pole on the same edge, so the step into
it is that edge's own and the step into the pole is unwrapped in the loop like any other.

Regression test a_small_sphere_void_in_a_large_block_meshes (tess tests): watertight, no face
left out.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:07:50 -04:00
jyvikoandClaude Opus 5.5 9e97bc4703 Tests: a split face without its record exports as the body has it, and the next operation joins it
export_keeps_faces_split_on_purpose took a box whose top Split Face cut in two, dropped the
split record by hand (with_split_lines(None)) and expected the STEP file to have 6 faces: truck's
export joined pieces on one surface, "as it does for pieces a boolean left". No operation makes
such a body: the split record is only set (doc eval, Split Face), never dropped, and removing a
Split Face rebuilds the part without the split. SMLib's booleans join pieces on one surface at
their end (two touching boxes unite into 6 faces), and the local modifiers heal through
boolean_record::healed, so no operation leaves incidental pieces either. The file now has what the
body has (7 faces, the export merges nothing), and the heal every later operation applies
joins the unrecorded pieces: 6 faces in the body and in its file.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:07:50 -04:00
jyvikoandClaude Opus 5.5 4626f83e5d Tests: a sketch curve splits a cylinder's one side face in two, not a half side
SMLib's cylinder side is one face round the whole turn (truck's two halves): a line at z = 5
splits it into a quarter and three quarters of 2 pi 10 x 20, two side faces, not three. (The
test still fails further on, at the face-split tool's "invalid argument", engine-builds'
cause fixed on their branch in 50356dbf2.)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:07:50 -04:00
jyvikoandClaude Opus 5.5 7ec4b7212d Tests: a face's flat area may differ from its surface's by the sails its boundary chords bridge
a_modelled_thread_in_a_bore_meshes_inside_its_block held each face's triangle area to within 5%
of its surface's area. At the 0.1 mm tolerance, face 18 failed that: 1.777 mm^2 of triangles
over 1.522 mm^2 of surface. Face 18 is the groove's crest band where it runs out through the
block's end, a wedge at most 0.44 mm wide. Its boundary sides are the helix edge's chords, 1.37
mm long and sagging 0.062 mm (inside the tolerance). A flat triangle on such a chord bridges the
sail between the chord and the edge instead of following it, and the band is no wider than the
sag. The excess, 0.255 mm^2, is less than the sails along the face's boundary (sum of 2/3 L sag
= 0.62 mm^2). Every triangle is within the tolerance: the chord check passes. No triangulation
of the inside changes this; the boundary nodes are the shared edge nodes.

The check now allows 5% plus the boundary's sails at the tolerance, 2/3 L tol per boundary side.
A zigzag that multiplies a face's area, which this test exists to catch, is still far outside
that. On the run-out root band the bound allows about 40% at 0.1 mm and 5% plus 4 mm^2 at
0.01 mm, against the former 6x.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:07:50 -04:00
jyvikoandClaude Opus 5.5 71ea626d0a Tests: a quarter disc tapered outward builds, and its volume is the exact integral of its sections
tapered_extrude_of_lines_and_arcs expected the quarter disc (its arc meeting both lines at a
corner) to be refused, "arc meets another edge at a corner". That was truck's limit. SMLib's
curvature-keeping taper builds it as mainstream CAD does: each wall continues as itself until it
meets its neighbour. The test now checks what was built. The section at d = z tan 8 deg is the
disc of radius r + d over x >= -d, y >= -d. Its area is in closed form, and the volume is its
integral by Gauss-Legendre: 458.5870559 against SMLib's 458.5870567 (2e-9). The body has 5 faces.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:07:50 -04:00
jyvikoandClaude Opus 5.5 eb40e161de Tests: the thread whose display is checked is made as the thread feature makes one, with exact helices
thread_display_tests sewed its M10 and M12 threads from cubic Bezier pieces approximating
helices, which lie about 1e-5 mm off the core and crest cylinders. No exact (same-parameter)
pcurve exists on the cylinder for such an edge, and SolidCraft's pcurves are exact B-splines
only. Sewing refused the core face ("no exact pcurve of a B-spline on a spline surface"). Truck
had fitted one. The thread feature makes its helices exactly, with SMLib's screw sweep, so the
test now does the same: the ISO ridge's section is screw-swept and joined to the core cylinder.
The section reaches a tenth of a pitch into the core along its flanks. ridge_volume is still the
thread's exact volume, and both display tests run unchanged, from the body as made and after a
STEP round trip. Imported edges that lie off their surfaces stay refused; they are Repair Part's
job.

The quality check's sag is now measured at the surface point nearest each triangle's centre.
Before, it was read at the mean of the corners' parameters. A closed surface's parameters are
kept within one period, so a triangle across the core's seam had corners a period apart, and
their mean read 6.27 mm off a triangle that lies on the surface.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:07:50 -04:00
jyvikoandClaude Opus 5.5 8eb77affb0 Kernel: a body's size counts its edges, so a sphere, cylinder or torus is its own size
Body size (the box diagonal every size-relative tolerance comes from: mesh chords, reach,
fit tolerances) came from the record's vertices alone. SMLib closes a sphere, a cylinder or a
torus along seam edges, so those vertices can be two poles, two seam ends or a single point: a
torus was 1 mm across (its preview at a hundredth of that took 214 720 triangles and broke the
budget), a 5 x 8 cylinder 8 instead of 16.2. The size now also takes three points along each
edge: points on the edges, not their control hulls, which for a rational edge can lie far off
it (a sheared L-prism's outline box was 49 km across).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:07:50 -04:00
jyvikoandClaude Opus 5.5 55f48e4e58 Tests: the sample-aliasing trap aliases by its knots, within the degree a record holds
sample_aliasing_does_not_certify_spline_caps built its trap as one polynomial of degree 17 with
a root at each of the 17 old sample locations k/16 (and a circle times such a polynomial, degree
19). A B-rep record holds splines up to degree 16 (MAX_SPLINE_DEGREE, #8618), so no record can
carry either and the evaluator refuses them: the test failed before testing anything. The trap
is now a C0 spline with a knot at every k/16: a quadratic on the line at each knot, bowing 1 mm
off it half way along the first span; and the quarter circle of radius 10 with its homogeneous
coordinates scaled by 1 + bump / 10, radius 10 at every knot and 11 at 1/32. Sampling at the old
locations still sees a line and a circle; the certifier, reading the spans' control points,
must certify neither, and doesn't.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:07:50 -04:00
jyvikoandClaude Opus 5.5 6387be309f Tests: the high-degree line prism_curve certifies is written at the record's highest degree
genuine_curves_and_oriented_traversal_are_certified built its degree-elevated line at degree
17. A B-rep record holds splines up to degree 16 (MAX_SPLINE_DEGREE, Brep::validate, #8618), so
no such edge reaches the certifier, and the evaluator refuses to build it. The line is now
written at MAX_SPLINE_DEGREE: still a line of the highest degree a record can carry.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:07:50 -04:00
jyvikoandClaude Opus 5.5 c1ead0fef7 Kernel: a sweep along a smooth path names every wall, and a closed one has no caps
The smooth-path sweep named walls only by the profile's edges in the start plane and took any
planar face nothing claimed for the end cap. A wall the start plane meets along no edge got
no name or became a cap: round a closed path, a square tube's planar top and bottom (whole
annuli, no seam) were both called end caps; along a line then an arc, the walls SMLib makes
along the arc were unnamed or caps. Like the cornered and controlled sweeps, it now also names
walls by the profile carried half way along, takes the end cap from where SMLib carries the
profile last, and round a closed path has no caps at all.

The issue #2005 tube check counted V - E + F without the ring term: SMLib's annular planar
faces have two loops each, so it checks V - E + F - (L - F) = 2 - 2g (Euler-Poincare). Along a
line then an arc SMLib makes a wall per profile segment per path segment (two, where truck
made three).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:07:50 -04:00
jyvikoandClaude Opus 5.5 d91d3f2a67 Kernel: a body moved by a non-rigid matrix keeps each face's source and paint on that face
transform_matrix moves a body by a matrix that is not a rigid motion through SMLib, which
numbers the moved body's faces afresh, then attached the input's face sources and paint in the
input's face order. Planar certificates landed on the wrong faces (a reflected, sheared plate's
hole walls and caps no longer lay on their certified planes). Each moved face now takes the
source and paint of the face its history names; a face with no known origin takes no source,
and with no history at all the paint stays as it was.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:07:50 -04:00
jyvikoandClaude Opus 5.5 de16a6b99a Kernel: a half turn's caps keep their roles when its end plane is its start plane
efd0a577b kept the cap flatness tolerance under a quarter of the gap between parallel start
and end planes. A half turn's end plane is its start plane: the gap is 0, the tolerance became
0 and neither cap was found, so m0-revolve-primitives' two flat ends could keep no sketch
attachment (design_corpus every_flat_face_of_every_corpus_design_takes_an_attached_sketch).
Only planes apart by more than rounding bound the tolerance; coinciding ones are told apart by
the profile's edges, as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:07:50 -04:00
jyvikoandClaude Opus 5.5 db9cf693a5 Kernel: an extrusion's cap is in its own plane however thin the extrusion
The roles of a swept body's faces take a face as a cap when all its points lie within a
flatness tolerance of the start or end plane, sized to the body (1e-5 of it). A box 0.1 µm
thick in a 14 mm body is thinner than that, so each cap lay in both planes and box_solid
refused "box role correspondence" (engine component_clone
boundary_material_proof_requires_resolvable_stock_and_void). Between parallel start and end
planes the tolerance stays under a quarter of their gap; a cap's points lie on its plane to
the evaluation's precision. Regression case: a 10 x 10 x 1e-4 box in
box_certificates_are_six_construction_roles...

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:07:50 -04:00
jyvikoandClaude Opus 5.5 1cb713c966 Kernel: an extrusion's wall seed marks only the edges nearest it
Each wall of a swept body is known by a seed on its piece's edge in the start plane; every
start-plane edge within `near` of a seed took its piece, `near` sized to the body
(3 x 2e-4 of its size). On a side shorter than that the neighbours' edges are near too: a
0.3 mm wall of a 1 m label is 0.15 mm from them, near 0.65 mm, so the long walls got two
pieces, had no source, and box_solid refused "box role correspondence" (gpu depth
at_ten_metres..., engine component_clone boundary_material_proof); a ring of radii 10 and
9.999 lost its side certificates (ui configuration_annulus_picker...). A seed now marks only
the edges nearest it (within the flatness tolerance of the nearest), still within `near`.
Regression case: a 1000 x 0.3 x 400 box in box_certificates_are_six_construction_roles...

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:07:50 -04:00
jyvikoandClaude Opus 5.5 5547cd98ad Blends: a picked edge is named as the blend takes it, the rim and not the seam
A chamfer picked at (10, 0, 20) on a cylinder's top rim lies on the vertex where SMLib's
cylinder has its seam. The blend takes the rim there (blend_smlib::resolve: a seam or a smooth
join loses a tie), but the name stored with the feature came from the nearest mesh edge, the
seam (`F2:side:c1`). Once the stem grew, the name found the seam and SMLib refused the chamfer
(join_extrude_from_a_chamfered_top_face). edge_names_for names the edge each pick takes as a
blend takes it (kernel::blend_edges), the nearest edge only where that finds none.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:05:37 -04:00
jyvikoandClaude Opus 5.5 ae5dc2416c Split Body: a face tool runs over its own surface's parameters
face_patch put the tool face's surface (a cylinder) over the domain of its NURBS form, which
SMLib parameterises otherwise (0..1, not the angle and height), so the patch handed to SMLib
was a sliver of the cylinder or empty and SMLib refused it as an invalid argument
(split_body_by_a_face). The domain is the analytic surface's: a whole turn, unbounded along
the axis, closed past the body as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:05:37 -04:00
jyvikoandClaude Opus 5.5 e0545b2bda Measure: an arc edge's angle is its span on the circle, not its NURBS parameter
edge_circle took a circle edge's interval as its angle. A circle SMLib holds on its NURBS form
is parameterised on that form (a fillet's quarter circle over 0..1), so the fillet's edge
measured 57.3° and an arc length of R·1 (a_fillet_edge_is_an_arc). The span is the edge's
curve_interval, the angles of its ends on the circle, as the lip already reads it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:05:37 -04:00
jyvikoandClaude Opus 5.5 f8c2fba077 STEP import: FILE_DESCRIPTION and the preprocessor name a Y-up exporter again
#5191 read the header's preprocessor version and FILE_DESCRIPTION, so a SolidWorks file named
only there was stood up. The reader had moved to crates/step (p21.rs) before #5191 merged,
and the merge kept only the originating system: a file naming SolidWorks in its description
got no exporter_up (step_replies_name_a_y_up_exporter). The parser reads both fields again,
StepImport carries them, and exporter_up looks at all three.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:05:37 -04:00
jyvikoandClaude Opus 5.5 ea65005597 geom: patches about a fill's centre are solved by blocks, their banded interiors eliminated onto what they share
The normal equations of patches about a centre were solved dense, so at most
500 free control points: the torus window, 1433 once its patches ran in their
own spaces, was refused. Each patch's interior (coordinates of points only it
holds, coupled by no row to another patch's) is a banded block now; the blocks
are eliminated exactly onto the unknowns the patches share (the spokes, the
centre, and the points rows across a spoke couple), whose Schur complement is
solved dense, and the interiors follow by back substitution. A solve takes up
to 6000 free points, as one patch does, and refuses past 4000 shared unknowns
(a 128 MB dense block) with that reason. The torus window and the pentagon now
solve (they fold, open).

The fill tests' own-edge check compares an edge's NURBS form to rounding, as
fill.rs's does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:05:17 -04:00
jyvikoandClaude Opus 5.5 c5b0385481 Fill: its tolerances follow a size that does not depend on where the body is
face_tolerance (and planarity_tolerance) was 10⁻⁶ of the body's bounding-box
diagonal, which changes as a body turns: the cup turned 0.7 rad about
(1, 2, 3) grew from 54.7 to 61.6, its fill sampled to another tolerance, a
different surface (area 974.543 against 974.527). The size is now the
diameter of the smallest ball holding the vertices (solidcraft_geom::Ball,
Welzl's algorithm, expected O(n)), the same wherever the body is and however
it is turned. Twice the farthest vertex's distance from the vertices'
centroid is that too, but up to twice the body's diameter where the
vertices crowd one end: a rounded box's set-back-13 G2 corner patch then
ran 2.0e-3 past the box (corner_g2
a_long_setback_keeps_the_g2_patch_inside_the_box, limit 1e-3).

The own-edge check of the fill tests compares an edge's NURBS form to
rounding (10⁻¹² of each coordinate): SMLib makes a conic's form again on a
round trip, the last bit of a coordinate apart.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:05:17 -04:00
jyvikoandClaude Opus 5.5 4faee7dd80 Fill: the general fill takes a loop of one or two edges in exact pieces of their curves
The iso fill needs three sides or more, so a loop of one closed edge (a tube's
end) or two was refused as "a loop of 1 edges". Such a loop's edges are now
taken in equal pieces of their own parameters (one edge in four, two in two;
a break that falls on one of the curve's knots, a conic's quarter points, is
that knot exactly), each piece the edge's own curve segmented exactly; the
patch's edges are those pieces, their ends new vertices shared by the pieces
either side. A piece of an edge the loop runs against has its parameter
reflected about the edge's interval, as a whole edge's is.

The tube end is still refused: one four-sided patch on four quarters of a
circle has corners where its sides run on straight (180°), and the G1 dome
folds there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:05:17 -04:00
jyvikoandClaude Opus 5.5 1e7713d1ec Fill: a patch's edges and vertices hold its fit's gap in SMLib's tolerance model
A record's tolerance is SMLib's intersection tolerance: SMLib holds an edge's
gap to its faces to half of it (the zone tolerance) and a vertex's gaps to a
quarter (SM_XSECT_TO_ZONETOL3D, SmBrep::ValidateAndUpdateTolerances). The fill
gave its edges and vertices the face tolerance itself, the gap its surface is
certified to, so SMLib's check refused every fitted patch (an edge/surface gap
of 2.6e-5 against 1.85e-5 where the fit holds 3.7e-5), alone or stitched to
its body. Its edges now take twice the gap and its vertices four times.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:05:17 -04:00
jyvikoandClaude Opus 5.5 b389601b06 Ruled surface: a strip on a cone is SMLib's revolve of its ruling, a cone face
A ruled strip off an arc whose rulings keep their angle to the arc's axis
(normal or tapered mode on a 30 degree lean) is a piece of a cone, but was
built as the rational B-spline between the arc and its image, which SMLib
labels with no analytic type (its CopyAndAddAnalytics only sees the plane
strips). Such a strip is now the start ruling turned about the arc's axis
through the arc's angle by SMLib's revolve, as the round corners already are:
a cone face, the same surface. a_circle_in_every_mode passes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:05:17 -04:00
jyvikoandClaude Opus 5.5 ebb1d843ab Sweep: a parallel sweep whose path runs along the profile's plane is refused again
Kept parallel (the profile as drawn), a profile flattens to nothing where the
path turns to run along its plane. The check that refuses it (the path must
cross the plane by 5° or more all the way) lived in the stations of a
controlled sweep only; a plain parallel sweep went to SMLib unchecked and
built a degenerate solid. Both take the same check now, the plain sweep on
each segment's direction of travel at 33 points along it.

A circle profile is one closed arc, one edge in SMLib: a wall per path line,
not two.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:05:17 -04:00
jyvikoandClaude Opus 5.5 b540faaf5c Thicken: a surface turned to its back grows the other way again
Going into SMLib a sheet's shell holds both sides of each face, so the side the
record keeps as the sheet's front is lost, and SMLib thickens along the
surfaces' natural normals: Reverse Normal did not change which way a thicken
grew. A sheet used against its natural normals everywhere is thickened by the
negated thickness.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:05:17 -04:00
jyvikoandClaude Opus 5.5 b68f71a2de Fill: a patch's edges are the body's own edges again, circles and ellipses included
A record edge on a circle or ellipse carries the NURBS form SMLib holds it as,
its interval on that form. The patch built its loop edges from the form alone
(sew::PartEdge had no place for it), so a fill's rim came back from SMLib as a
plain B-spline rather than the body's ellipse. PartEdge now carries the form;
assemble keeps a given form and labels the edge with what it is.

Test helpers that sampled an edge on `curve` with the form's interval picked
points off the edge ("no edge at …"); they sample `parameters()`. The fill's
own-edge check compares the curve's kind and the exact form it is parameterised
on: SMLib renormalises a conic's frame axes in the last bit on a round trip.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:05:17 -04:00
jyvikoandClaude Opus 5.5 8515dc1a34 Blend tests: a vertical round run on up a top round's end arc (ladder 07-fillets/018) is SMLib's to end, and builds
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:04:57 -04:00
jyvikoandClaude Opus 5.5 94d763c839 Tests: a round run on through an earlier one by tangent propagation is matched by the same edges together
The arc part's front edge rounded r2, then its left top edge with tangent
propagation (the Fillet feature's default): that edge runs on round the first
round's end arc and down the left front upright, so three edges end up rounded
(a sphere octant at the corner where they meet), not two. Both results were
exact: 9530.77 (meshed) is the part less three r2 strips and the octant,
9591.44 − (0.858407·(39.1667 + 19 + 8) + 8(1 − π/6)) = 9530.83; 9538.79 is
two strips less their overlap, 9591.44 − (0.858407·62.1667 − 0.7670) =
9538.84. The test compares the sequential rounds with the same edges of the
part rounded together: the picks' chains and every edge of the part the second
chain carried on into.

The other pairs still fail in SMLib (1001, or SM_ERR_INVALID_INPUT at the
knife-edge tip) where a later round ends on the first round's arc.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 07:14:45 -04:00
jyvikoandClaude Opus 5.5 0ec97c5708 Blends: tangent propagation off blends the picked edges alone; a refusal says how to change it
The Fillet and Chamfer features already blend each picked edge's tangent chain
by default (tangent_chain, true unless saved false), as mainstream CAD's
tangent propagation does; the kernel blends exactly the edges it is given.
#8678 refused, before SMLib, every edge that runs on tangentially into one left
out, which also refused blends SMLib builds (a round ending on the round its
edge runs into: blend_corner's a_round_next_to_a_round_of_another_radius, the
same feature with propagation off). Now:
- propagation off: only the picked edges are blended; where SMLib cannot end
  the blend at such a continuation, its refusal names the edge it runs into
  and that propagation (tangent_chain: true) blends the chain as one;
- propagation on, where the chain cannot be built (an r3 round carried on
  round an r2 round's end arc), the refusal says the chain was blended and
  that with propagation off only the picked edges are.
A smooth edge is still refused before SMLib. No default changes: the feature's
default was propagation on already.

The kernel tests that stand for a Fillet feature (curvecorner's sequential
rounds, issue 2422) take each pick's tangent chain, as the feature does by
default.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 07:14:45 -04:00
jyvikoandClaude Opus 5.5 229739a704 Blends: a smooth edge and an unfinished tangent chain are refused saying why; SMLib's unsupported corner is named
A smooth edge (its faces meet tangentially) has nothing to round, and an edge
that runs on tangentially into one left out has no end SMLib can blend (it
rounds a tangent chain as one sequence and failed building the face there,
status 1001): both are refused before SMLib with that reason. SMLib's new
SMLIB_ERR_CORNER_UNSUPPORTED (a vertex no blend corner handles) is
Error::CornerUnsupported and says so instead of a bare status.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 00:30:07 -04:00
jyvikoandClaude Opus 5.5 7d00ad78c4 kernel: a patch builds G0 to G4, and Continuity Analysis reads each seam's middle at the order asked
The patch fill meets its neighbours to G4, so Construction::Patch now offers g0 to g4: the
surface.patch command takes g3 and g4 and the Patch dialog's continuity row offers
"Curvature change" and "Smooth curvature change" by itself, from the one table.

The three-round corner test patches G2, G3 and G4 and reads the seams with the Continuity
Analysis too: the middle of each seam (30-70 %) at the order asked; the whole seam G1, since at
the corners the rounds' curvatures differ and no patch can meet both.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-29 00:30:03 -04:00
jyvikoandClaude Opus 5.5 0631d2d3a4 kernel: a three-round corner patched G2 and G3, read off the faces at each seam
The corner blend of a box's R8 vertical round and R4 top rounds taken off and patched: both
patches meet the tangent planes and the curvature in the middle of each seam; the G3 patch
also meets the curvature's rate of change (4e-6 to 4e-5 /mm^2), which the G2 patch leaves at
0.27 to 0.63. G3 to an edge between two faces is refused; G3 is no longer refused as such.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 00:30:03 -04:00
jyvikoandClaude Opus 5.5 ed830a168d geom: the patch fill takes the dense spline edges a blend leaves, and holds what its corners allow
- One patch has a space along u and one along v, each holding its two sides that run that way;
  a side's knot keeps its continuity when raised (multiplicity m + q - p), and each side is
  carried in exactly by interpolation at the space's Greville abscissae.
- Refinement halves the spans only in the direction whose sides miss, and one patch's normal
  equations are banded (the shorter direction numbered fastest), so a loop with a long
  intersection curve refines where it needs to.
- At a corner whose neighbours agree to a lower order than asked (their tangent planes, their
  twist between the two edges, or their forms), the stations near it ask no more than that.
- A station is held to the angle tolerance beyond the edge's own lean out of its neighbour's
  tangent plane: a fill that holds the edge cannot come nearer.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 00:30:03 -04:00
jyvikoandClaude Opus 5.5 99297495b3 geom, kernel: the patch fill meets its neighbours with G0 to G4, on rational edges too
One order-n implementation in the linkage-curve formulation (Pegna & Wolter 1992;
Hermann, Lukacs & Wolter 1999): geom::linkage reads the neighbour as a height over its
tangent plane to order n (its jet, from the surface's exact partials of any order) and
gives each order's condition on the linkage curve, with exact gradients (dual numbers),
so fill_iso solves orders 2..n by Newton's method. Each order's row is weighed by h^(k-1)
and its jump is held, carried into the fill by Taylor's theorem, within the angle tolerance.

The iso fill takes rational edges (a circle's arc on its NURBS form): homogeneous rows,
each edge scaled so the corner weights agree, the inside weights the Coons blend and
fixed, so the fill stays a linear least-squares problem. Its degree is at least n + 1,
refinement adds simple knots, breaks of different sides within rounding are one, and the
weak Hermite rows act in the tangent plane at the Coons start's own speed, so they no
longer pull against the G1 rows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
2026-10-29 00:30:03 -04:00
jyvikoandClaude Opus 5.5 7c8132e2d6 Repair Part (body.repair, #8371): rebuild refused faces, sew gaps, patch holes
A new undoable feature (`repair`, one pending format file) and command with input and
output schemas. In order:

- A cylinder, cone, sphere or torus face SMLib refuses on its own is rebuilt on a NURBS
  form of its surface laid on arcs from where the face starts
  (`form::surface_on_own_arcs`), with SMLib's own trims: the import's quarter-grid form of
  a face round most of a turn closes on itself, which SmTorus::IsNurbSurfaceTorus does not
  recognise. Geometry unchanged.
- Free edges that pair up within `gap` are sewn by SMLib's stitch; GlueEdgesGeneral gives
  each glued edge its own tolerance (at least twice its gap), the body's and the other
  edges' stay. The result is checked against the input's own SMLib check, the
  tolerance-bound tests (#5, #6, #59, #82) exempt.
- Loops of free edges left are holes: offered as surface.patch, and with patch_holes made
  (flat only when the loop is planar and every face around it is a plane, else G1) and
  sewn in.

The reply reports what changed face by face; nothing to do is refused with why.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 00:29:59 -04:00
jyvikoandClaude Opus 5.5 f11c0c5712 Bodies: an operation's result is its record, not the SMLib body it was exported from
A body made by an SMLib operation kept that SMLib body beside its record (SMLib's
export). The export is not exact to the bit, so the kept body measured and operated a
little differently from the record's import, which is what a body read back from a
file has: a box measured 24000.000000000004 mm³ live and 24000.0 reopened, a drilled
box 21989.38056 against 21989.38013. A cut ring's volume therefore changed when it
was moved, the moved ring being measured on the SMLib body the move made
(measure_centre_tests::combine_cut_volume_does_not_depend_on_placement). Every body
now imports its record when an operation first needs it, so evaluated and reopened
bodies are the same.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:12:37 -04:00
jyvikoandClaude Opus 5.5 00faac9659 kernel: a planar sheet's loop splits where it passes one vertex twice
Reading a planar sheet back from SMLib split each loop where two of its
segments started within ten times the record's tolerance (2e-5 mm), so
the two ends of an edge shorter than 2e-4 mm counted as one point and the
edge came out as a loop of its own, which the next planar boolean refused
("needs closed loops"). A loop passes a point twice where it passes one of
the record's vertices twice; the split now reads the vertices, not their
places. The sheet built from our own regions still splits by place, at ten
times the caller's tolerance.

Fixes sheet::tests::a_ledge_beside_an_edge_as_tall_as_the_setback_goes_with_the_strip
(the ledge 1e-4 above the bend line); new kernel test
a_ledge_shorter_than_the_record_tolerance_reads_back_as_one_region.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:12:07 -04:00
jyvikoandClaude Opus 5.5 b9d4ad74f4 kernel: a planar region inside another's hole keeps its material
The SMLib planar sheet united every region's material and then cut every
region's holes from it, so a region lying in another's hole (the island
inside a ring cut) was cut away with that hole. Each region is now its own
material less its own holes, and the sheet is the regions united.

Fixes sheet::tests::ring_cut_retains_exact_central_material_island (the
flat solid lost the island's π·25·2.5 mm³) and the kernel's
compound_planar_extrusion_normalizes_overlap_and_retains_islands.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:12:07 -04:00
jyvikoandClaude Opus 5.5 ccff7224c3 Shell: its planar walls carry their shell roles again
The SMLib port of shell dropped with_shell_planar_sources (then deleted it as dead
code), so a shelled body's kept walls and their inner linings had no ShellPlanar
certificate: a sketch or press-pull on a shell's floor lost its attachment (the Pi
case's Sketch2 and everything after it, press_pull_on_the_pi_case_floor) and the
shell certificate tests found no inner/outer face. The roles come from the input's
exact planar supports, so they apply to SMLib's result unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:11:55 -04:00
jyvikoandClaude Opus 5.5 c37b0d2f02 Kernel rig: a case's expected continuity order at its blend seams
expected.json may give `continuity: {order: g0…g4, edges?: "blend" | "corner"}`: the
seams of each round, chamfer face or corner patch with the faces either side of the edge it
replaced, and of each corner patch with its rounds, are measured as Continuity Analysis
measures them (seam_diagnostics at its default 33 stations and default tolerances), and the
case fails naming the worst seam, its faces, the order it reaches and the next order's worst
value. The seams come from the faces' persistent names (doc::naming::blend_seams). The older
`{near, within_mm, …}` form is kept.

Every fillet-area case with a body gets its order: constant rounds and rolling corners g1,
curvature rounds g2, chamfers g0, the corner: g2 patch g2 at its seams.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 21:22:17 -04:00
jyvikoandClaude Opus 5.5 c070f044ab STEP import: a torus face round most of its tube is formed within one turn of it
A torus face covering most of its tube off the tube's quarter lines (an
exhaust collector's bend: 326° of the tube from −113.8°) needed a fifth
quarter along the tube, which STEP counts from the outer equator: its form
ran past a full turn of the tube and SMLib refused the solid. #8496 turns
frames about the axis only, and the torus label had no tube reference.

The torus label gets a tube start (`tube_start`, radians; 0 and left out
of the record by default, so older records mean what they did): v counts
from there, in every evaluator, form, pcurve, iso curve, tessellation,
placement, SSI and SMLib transfer. A spilling torus face's tube start moves
to where its tube begins, or a turn before where it ends, whichever puts
its tube circles on the grid of a round face they are about the axis of
(a pipe's cylinder meeting the bend); circles round the tube are labelled
from the tube start (brep::form::on_tube), so their forms and pcurves lie
on the face's quarter grid exactly. The saved-format change is one file,
crates/doc/src/format/pending/torus-tube-start.rs.

Engine assembly: COLLECTOR_EXHAUST_VER_1 now comes in as a closed solid
(refused 3 -> 2); Poppy Humanoid unchanged (4).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 21:22:11 -04:00
jyvikoandClaude Opus 5.5 fc3a13f176 step_in tests: the import's repair notes for added seams and turned faces
The schema 4 reader adds a seam to a face that winds around its surface without one
(3d7e465b1) and turns over a face whose loop disagrees with its same_sense, and notes
both (the spindle torus tests assert the seam note). The tests written against truck
expected no warnings:
- step_conformance_parts_read_back_their_exact_shape: each part's seam count (the cone,
  dome, cylinder parts bounded by their rims alone); volumes, boxes, faces unchanged.
- extruded_ellipse_patch_crossing_profile_seam_stays_trimmed: same_sense .F. adds the
  turned-over note.
- implicit_bound_can_still_describe_the_complement_of_a_patch becomes
  implicit_bound_against_its_face_sense_turns_the_face_over: the strip's one bound on a
  cylinder cannot be a hole (the cylinder is unbounded along its axis, so the face would
  have no outer boundary); the loop bounds the face, turned over, the 42 mm2 strip.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:41:57 -04:00
jyvikoandClaude Opus 5.5 ae393fd9ce step_in tests: a face with too many bounds is refused by the reader's own limit
The face-bounds limit lives in crates/step's topology (MAX_BOUNDS, 54b10b9a3) since the
truck reader that said 'boundary loops' went (ab8bc6625); it names the face and its
bound count. The test asserts that message; the time bound stays.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:41:57 -04:00
jyvikoandClaude Opus 5.5 6055ce6fd3 step_in tests: knot multiplicities refused per knot, then by their sum
The reader (crates/step, f06581ca5) keeps distinct knots and their multiplicities and
never expands them; a multiplicity above degree + 1 is invalid (ISO 10303-42) and is
refused on its own as 'bad knot multiplicity' before the sum is compared. The test's
1,000,000 knots of multiplicity 64 on a degree-1 curve hit that first. Both checks are
asserted: multiplicity 64 per knot, and 1,000,000 knots of multiplicity 2 by the sum.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:41:57 -04:00
jyvikoandClaude Opus 5.5 efdc245d1f step_in tests: a face the reader refuses leaves the rest of the solid as surfaces, named
unsupported_face_is_left_out_and_reported replaced a plane with an OFFSET_SURFACE on a
placement: the reader reads offset surfaces since d41ae8512, so the face was refused
for its basis (AXIS2_PLACEMENT_3D), not for being unsupported. It now uses
CURVE_BOUNDED_SURFACE, which the reader does not read. Since cfee4a720 and 4cb0d6ee9 a
solid with a face left out comes in as a surface body of the faces that read, warned
'imported as surfaces' and 'left out', with no 'open body' warning on top (as
a_refused_solid_comes_in_as_a_surface_body_of_the_faces_that_read asserts); the test
asserts that.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:41:57 -04:00