* Dialogs: remember values and options for this app session (off by default)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
* Dialogs: translate the remember-values help text again
The help text changed to say the setting is off by default, and the
complete catalogs (ar, he, ja, vi, zh) lost their translation of it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Dialogs: recall gives a new face a fresh thread suggestion and rebuilds Move/Hole mode inputs
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Dialogs: format recall
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
* Status line: say which file an Open or Insert brought in, and whether it got a new tab
"Open done" and "Insert done" were English text built in code, so they stayed English in every
language and didn't say what was opened. They now read "Opened <file> in a new tab", "Opened
<file>" when a blank design was replaced, or "Inserted <file>", from the message catalogs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Status line: an opened design is named as its tab names it
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Status line: an Open's test and Korean strings
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Status line: an Open's message in the chosen language, and none for a design that found no tab
The message is built outside the window's language scope, so it takes the locale from the preference as the other statuses of the file loader do
An opened design is named as its tab shows it (a default name translated), an inserted one as its component is named
An open that finds no tab left keeps the error and answers it, instead of naming the design shown as opened
The test injects the finished open instead of running and polling a worker
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Status line: a design to recover that finds no tab stays offered
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Status line: a design to recover that hits the tab limit stays offered too
An Open or recovery with every tab taken was refused before the design
was read, and a design to recover was dropped from the list on that path.
It goes back in the list, as when its read fails. The staged-open test
reads the new status.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
A bend that cut-outs across it split into several cylinder faces came out slit, silently: only
the picked piece was bent, the rest of the bend was cut away with the cut-out, and the volume came
out short. Picking the other pieces too was refused ("two faces of the sheet that meet along more
than one edge"). A picked bend cylinder now takes every coaxial piece of the same radius between
the same two faces, on both skins; in the flat, a face that meets its bend neighbour along several
collinear runs gets one bend edge, and the notches between them and the bend zone's pieces there
become holes of the sheet.
Test: a_bend_split_by_slots_across_it_converts_as_one_bend (slots cut through a tray's unfolded
bends, one piece picked or every piece): the volume, flat size, outline area, bends and the three
cut-outs are the source's.
Fixes#7530.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #11048
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Intersection Curve: take two sketch curves, no helper surfaces (#11048)
Intersection Curve now also takes curves of other sketches. Each curve
stands in for the surface you would get by extruding it along its own
sketch's normal, both ways and as far as needed, so two sketch curves
(or a curve and a face) give their 3D crossing without the two Surface >
Extrude features it used to take. The surface is never added to the
model. Sketches on parallel planes are refused with an error saying why.
The result stays a linked 3D wire that follows edits to either curve.
In the tool, a curve of another sketch fills a side like a face does;
after the first pick the status bar asks for the second, a right-click
starts the picks over, and the hint returns once the curve is made.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Intersection Curve: keep other tools' right-click, update the tooltip, add a UI scenario (#11048)
The right-click change now applies to Intersection Curve only: Project to
Surface and Spun Profile behave as on main again.
The toolbar tooltip now says Intersection Curve also takes curves of other
sketches, in every catalog that has it, using each language's wording from
the Project to Surface tooltip.
New UI scenario intersection_curve_from_two_sketch_curves: a line on XY and
a line on YZ give one linked 3D wire along X at y = 0, z = 5; it also checks
the second-pick prompt and that a right-click starts the picks over.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GG4jU9aCv381PgLCsseQMP
* Intersection Curve: a picked spline wall meets whole, in one curve (#11048, #9009)
On the SMLib kernel a fit-point spline's wall is one face per span, and
Mesh::surface_patch keeps smooth-joined faces apart, so a face pick met
only the span under the pick and gave part of the crossing (#9009 again,
for faces as well as for sketch curves). A face pick now takes the faces
joined across seams and smooth joins, never across a crease.
The imprint also splits a crossing at every face boundary of either
side, so a crossing came as one wire per span. The pieces are now joined
end to end into one wire, keeping their exact curves; a piece that runs
the other way is reversed as a record curve.
A curve side's sweep is sized from the other body's exact bounds, not
its display mesh. The #9009 test's premise that the spans are one
surface_patch no longer holds and is removed; its checks are unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Intersection Curve: a picked face joins only tangent spline faces, from exact geometry (#11048)
Which faces a face pick means is now decided on the exact surfaces, not the
display mesh: the picked face and the spline faces joined to it at least
tangentially (the kernel's seam check), so a spline wall's spans still meet
as one (#9009) while a plane, a round or any analytic face is that face
alone. The pieces of a crossing are joined within ten times the kernel's
intersection tolerance instead of a fixed 1e-4 mm.
Tests: a flat face beside a round and the round itself each give their own
crossing; two sketch curves give one curve at 1/100 and 100 times the size.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Known-failing tests: the picked spline wall's intersection curve passes now (#11048, #9009)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Book: sketching step by step, with three clips and a numbered screenshot
The sketching page now opens with a first sketch in four steps: start a sketch on the Top
plane, draw a 60 x 40 rectangle and a 12 mm circle with typed values, dimension the circle
until the sketch is fully constrained, and finish. Each step has a short clip, and the last a
screenshot numbering the Sketch tools, a constraint, a dimension, the sketch's state and
Finish Sketch.
doc_shots.py gains what these needed: a setup that runs before recording, so a clip starts
where the last one ended; sketch framing; Enter sent as two input frames; and clips that keep
their pauses (hovering a plane).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Book: the sketching page's general notes get a heading after Step by step
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Book: sketching adds Offset and Trim; the sketching figures again on 0.29.0
Two more clips after the sketching walkthrough: Offset draws the rectangle's outline 4 mm inside
it with one click (Chain), and Trim cuts a notch where a circle crosses the top side. All the
sketching figures are made again on SolidCraft 0.29.0, with the clips keeping a moment on each
result.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Book: solid features step by step, with four clips
The solid features page now opens with the sketch from the sketching page made into an open
box in four steps, each with a short clip: extrude it 12 mm, shell it with the top open,
round its outer top edges, then make it 20 mm tall from the timeline while the shell and the
fillet rebuild. The panel table and what follows get a heading of their own.
doc_shots.py: the feature shots share their steps with the setups that lead up to the next
shot, and fail when a feature on the timeline carries a warning or an error, so no figure
shows one. Shell comes before Fillet for that reason: shelling through the rounds needed the
kernel's boolean retry. trim_idle.py takes --hold, the seconds of each idle stretch to keep
(default 0.1 as before); the doc clips keep 0.8 s, so a reader sees each result. The app gets
up to three minutes to answer on a busy machine.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Book: features add Hole and Circular Pattern; the Parameters dialog, numbered
The features walkthrough gains two steps before the timeline edit: a 4 mm hole on the box's
floor, then Circular Pattern repeating it four times around the tube. The edit at the end now
rebuilds all of it. The parameters page gets a screenshot of the Parameters dialog numbering
apply as you go, user parameters, model parameters by feature, an expression and its value.
The features clips are made again on SolidCraft 0.29.0.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Book: components and joints step by step, with three clips
The components and joints page now opens with a two-leaf hinge in three steps, each with a
short clip: the two bodies made into components from the Bodies folder's menu (the first one
grounded), a revolute joint on their barrel ends with Flip turning Leaf B the right way round,
and a drag that swings Leaf B about the hinge while grounded Leaf A stays put. What follows
gets a heading of its own.
doc_shots.py builds the leaves from commands, with Leaf B lifted and set back so the joint
visibly brings it into place.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Book: assemblies add Drive Joints; the assembly clips again on 0.29.0
A fourth step drives the hinge with Drive Joints: the slider swings Leaf B while a ghost shows
where it started, and OK keeps the new angle. The assembly clips are made again on SolidCraft
0.29.0.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Book: getting started, sheet metal and import/export get pictures
Getting started gains a section on the start page: a numbered screenshot (new design, open,
import, recent, samples, the File menu) and a clip opening a sample from it. Sheet metal opens
with a tray in three steps, each with a clip: a base flange from a sketched rectangle, edge
flanges from two top edges, and the flat pattern with its bends. Import and export opens with
the File menu, numbered.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #10940
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
* Emboss: an emboss or deboss that changes nothing says so (#10940)
solid.emboss on a body its tool missed (a sketch on the far side of the
material, a depth that stops short) was recorded as a success with no
warning, so a sheet metal part looked embossed when it was not. The
evaluation now compares the bodies before and after and adds a warning
when none changed. A working emboss or deboss is silent.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
* Emboss: the changed-nothing warning names what to check, not a cause it can't know (#10940)
CodeRabbit pointed out that an emboss can change nothing for other reasons
than missing the body (for example a profile that lies inside material that
is already there), so the warning no longer claims the profile misses the
body. It says the operation changed nothing and suggests checking where the
profile lies, which side of the face the sketch is on, and the depth.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Emboss test: put the missing sketch below the sheet, since main's sheet metal emboss now cuts from its underside (#10940)
On current main a deboss from the XY plane reaches the sheet (it is changed and gets
the sheet metal flat-pattern warning), so the test no longer showed an emboss that
changes nothing. A sketch 5 mm below the sheet misses it on both bases.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: thocsmith <193096300+thocsmith@users.noreply.github.com>
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
* claim: #11271
* Polygon By side: Length and Sides boxes, the typed length a side dimension (#11271)
The edge polygon tool showed no value boxes after its first click. It now
shows Length (the side from the first click) and Sides, as the inscribed
and circumscribed modes show Radius and Sides. A typed length places the
second corner and becomes a Length dimension on the first side:
sketch.draw.dimensioned takes a `length` role for sketch.polygon.edge,
an alternative to its radius (as_drawn still adds the radius when no
length is given; both together are refused).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Polygon By side test: read the design's own state so it compiles against main (#11271)
Main's Session::world_state() now returns a Result, so the new test failed
Quick compile on the merge. The sketch is in no component, so the design's
own state shows the same sketch on both the old and new bases.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Polygon By side test: take Vec2 from solidcore_record, where main moved it (#11271)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: thocsmith <193096300+thocsmith@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The fillet keeping of #5677 swaps an arc's ends when its sweep jumps by more
than half a turn with both its lines turned. Judged against a reference that
shows the corner mirrored (positions before a move, or a mirrored start), a
fillet the solve left exactly where it was looks turned, and the swap made it
its long complement: a 45-degree fillet on a 135-degree corner became a
315-degree arc with both lines cutting back through it, while the solve
reported ok.
The swap is now decided by the lines: an arc whose tangent lines all leave it
after the solve already rounds its corner and keeps its ends. A swap still
gives a corner its arc back when its lines cut back through it. A second test
keeps a real fillet over three quarters of a turn whose corner mirrored as the
long arc its lines leave (a narrower fix, letting a swap only shorten an arc,
would break it).
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
A lip kept its rim face as a plain point, so it got no persistent face
name. When a parameter made the box taller, the point stayed below the new
rim and the lip failed ("the plastic feature's placement is no longer on
its body face"). The face is now a face pick, as a boss's is, and the lip
names its body like the other placed plastic features. Both are saved as
the same [x, y, z], so files don't change.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Ribbon: an option to fold it to its tab row (#10112)
Preferences > Layout > "Show only the ribbon's tabs" (off by default), the
Ribbon Tabs Only command (view.ribbon_tabs_only), and its settings-profile key.
Rebuilt on main's redesigned Layout page.
* Ribbon Tabs Only: switching tabs with a panel menu open no longer keeps the overlay open (#10112)
A tab click now forgets the open panel drop-down of the previous tab, so the pointer leaving or Escape still closes the overlay.
* Ribbon Tabs Only: count its settings-profile key in the profile membership test (#10112)
* MCP: compact inspect_design and tool JSON, off by default (--compact / SOLIDCRAFT_MCP_COMPACT)
Split out of #2901 per review: the smaller inspect_design changed the default
for everyone, so it is now an MCP server option that is off unless asked for.
- solidcraft-cli mcp --compact, or SOLIDCRAFT_MCP_COMPACT=1 (true/yes/on;
0/false/no/off/empty leave it off; anything else is an error at start-up).
solidcraft_mcp::Options::resolve is the one place that decides, so an app
Preferences setting can feed it later.
- With it on, inspect_design summarises sketches (id, name, plane, counts of
points, curves, constraints and profiles, dof, status), returns full contents
only for the sketches named in `sketches` (names/ids, true, false or
"summary"), takes a `bodies` filter and measures only those; unknown names
list the existing ones. Tool JSON is compact rather than pretty-printed.
- Off, tools/list, argument checks, inspect_design and tool JSON are exactly
as before.
- document.inspect gains an opt-in `sketch_counts` (plane, points,
constraints); without it its reply is unchanged.
Tests: both modes in the MCP suite, Options parsing, and the CLI flag and
variable end to end.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* MCP compact output: a Preferences setting too (AI › Agents through MCP)
The desktop app's Preferences › AI gets "Compact output" under a new "Agents
through MCP" section, off by default and shown with the chat off too. The app
reports it on the control channel as `mcp.options` ({"compact": bool}); the
agent chat lets its own MCP server read it.
A bridged MCP server (`solidcraft-cli mcp --connect`) asks the app when an
agent first lists or calls a tool and keeps the answer for the session, so the
tools it listed keep their shape. An app not running yet, or busy past 2 s, is
asked again on the next call; an app from before the setting counts as off.
`--compact` and SOLIDCRAFT_MCP_COMPACT=1 still turn it on whatever the app says.
Tests: the server follows the app's answer (waits for it, keeps it, the flag
still wins); the checkbox reaches `mcp.options` and Restore Defaults clears it;
the chat gate allows `mcp.options`. docs/mcp.md and docs/control-protocol.md.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* MCP compact output: review fixes (mcp.options never blocks, headless test, locales, prefs doc)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* MCP compact output: the setting is a section of the AI page; the bridged test answers mcp.options
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* MCP compact output: the preference test sets it through ui.prefs; rustfmt
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* MCP compact output: look for a newly started app before asking its options; counts from sketch.inspect for an older app
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #4332
* Two-distance and distance-angle chamfers of free-form rims: a test on the SMLib kernel (#4332)
A spline, Bézier or text outline's rim used to be refused by the two-distance and
distance-angle chamfers. The SMLib kernel (#11351) chamfers it along the rim; this test pins
that down on a four-Bézier oval, picked as its tangent chain the way a pick takes it: the
volume taken off is the analytic one for two distances (both ways round) and for a distance
and an angle.
* Sketch: the geometry of a pierce, a point where another sketch's curve crosses this plane (#3599)
* Sketch: the Pierce constraint, a point on a curve of another sketch (#3599)
* Engine: draw a Pierce constraint at the point it holds (#3599)
* Engine: the pierce tests wait for the command that is not written yet
* style: rustfmt, the imports of the pierce geometry in the order rustfmt wants
The rebase onto the current main resolved the rename of Plane, Vec2 and Vec3
from solidcraft_geom to solidcore_record and left the two use lines in the
order the resolution wrote them. rustfmt wants them the other way round, and
the fmt phase of the gate reads the whole tree.
No token of the file changed: the same 2983 tokens before and after, only the
order of the two use lines moved.
---------
Co-authored-by: bherbruck <bherbruck@gmail.com>
Co-authored-by: vdirienzo <vdirienzo@users.noreply.github.com>
* claim: #10745
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Control channel: ui.menu refuses missing targets, reports the History item menu, and tells the joint menu items apart (#10745)
- ui.menu looks a target up and refuses one the design doesn't have ("no body `NoSuchBody`").
- The History bar's feature menu is the shared context menu (Target::Timeline), so ui.menu
reports it, ui.menuPick runs its items and {"type":"timeline","feature":id} opens it.
Its Show All toggle moves to TreeState so the menu can list Delete after the marker.
- Edit Joint Limits is ui.editJointLimits and opens Edit Joint with Limits expanded.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Icon audit: open the section and canvas menus on a real section and canvas; a hidden section has a menu too
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* ui.menu: check a group's or folder's scope and folder name; Delete after the marker gets its own id
A group or folder target is refused unless its scope is a row of its component (`c<id>` or a
placement of it) and the folder is bodies, sketches or construction. The History item menu's
delete of everything after the marker is ui.deleteAfterMarker, so ui.menuPick can tell it from
Delete (review on #10746).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* ui.menu: a component's own c<id> scope is the design root's only; test that Delete after the marker deletes
The browser draws a part's folders and groups under its placements (o:<path>), so a c<id> scope
for any component but the root names a row that isn't there (review on #10746). The History test
now picks ui.deleteAfterMarker and checks the features are gone.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* ui.menu: a placement scope must be spelt as the browser keys it
o:012 parses to placement 12 but isn't the row's key (o:12), so Show/Hide would store a key no
row reads (review on #10746).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* History item menu: no Delete after the marker when nothing shown is after it
A timeline target for a feature the bar's component filter leaves out listed no features, so the
item did nothing (review on #10746).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* ui.menu: a plane target must be construction geometry
The plane menu's Show/Hide keys the feature's name as an origin item, so any other feature got a
menu whose actions don't fit it (review on #10746).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* ui.menu: accept the view navigator's and selection filter's menus, which main added
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* AGENTS.md and the contributing skill: say how to work as an agent
Two rules that the loop's own agents follow but the repository never
wrote down, so every agent that reads it had to rediscover them:
* The code, the comments, the commit messages and the docs are in English,
always. A comment in another language is a defect: the people who
maintain the code cannot review it. A user-visible string is not inline
in the code either; it goes to the message catalogs, and the UI text
skill says how to name and translate it.
* Parallel work runs in parallel, and dependent work stays sequential.
One subagent per independent part, with a self-contained brief, and no
two subagents writing the same file. A fix and the test that proves it,
a refactor and the callers it breaks: those stay in order.
AGENTS.md is the router, so it gets the two rules in one line each, and
skills/solidcraft-contributing/SKILL.md gets the "Working as an agent"
section with the detail.
* AGENTS.md: fit the two agent rules under the router cap
`cargo xtask skills` reads the router as a router: one line per rule,
with the detail in the skill the line points at. The two new lines
broke that contract twice over. They carried their own detail (a
comment in another language is a defect; one subagent per part, no two
writing the same file) instead of pointing at the "Working as an
agent" section that already holds it, and the file grew to 5361
characters, over the 5000 a router may have.
So the two lines shrink to what a router line is, and five clauses
that repeated a rule the pointed-at skill already states in full give
up their place:
* "Act when the code, docs and rules settle a question" is in the
contributing skill, in more detail.
* The unsafe allowlist is the crash-safety skill's own list.
* "No second PR for an issue a lower-numbered one closes" and "never
force-push main, no pushes just to catch up with main" are the
contributing skill's claim and push rules.
* "Do not switch branches while the gate runs" is in the contributing
skill too.
No rule is lost: each one still has exactly one place that states it,
and that place is a skill. The router is 4970 characters.
Open GitHub issue form filled the issue through the link only up to
2,000 characters, with every space and line break encoded as three, so
most reports opened GitHub with the title alone and their text on the
clipboard, and many arrived empty (#10556, #10654).
The link now encodes only what a query value can't carry (a space is
`+`) and is limited by what GitHub keeps: 6,000 characters, and 7,000
once its sign-in page encodes it again. A report too long for that still
goes through the clipboard, whole.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #7641
* Sketch on a thickened surface follows the face (#7641)
Thicken dropped the kernel's face history, so Create Sketch refused
every face of the solid. Carry that history through, the same way
Shell and Trim do.
The regression covers the offset face and an end wall, and checks
that a boss on the offset face follows a thickness change and reopens.
* claim: #9623
Signed-off-by: Maurizio Monticelli <maurizio@whatwedo.ch>
* Sheet metal and plastic rules: Thickness in a rule's expressions is the rule's thickness
A rule's expressions read `Thickness` as the rule's thickness only while the
design had no parameter of that name; with one, the default gap, reliefs and
a `Thickness` bend radius took the parameter instead (a 2 mm rule beside
Thickness = 10 mm closed corners to a 10 mm gap). Now `Thickness` is always
the rule's, as documented; the rule's own thickness still reads the design's
parameters, so `thickness: Thickness` keeps naming the design parameter.
Renaming a parameter called Thickness, its users and what it drives follow
the same reading: only a rule's thickness field refers to it. Renaming a
parameter to Thickness is refused while another rule field uses it, since
that field would then read the rule's thickness instead.
Fixes#9623
Signed-off-by: Maurizio Monticelli <maurizio@whatwedo.ch>
---------
Signed-off-by: Maurizio Monticelli <maurizio@whatwedo.ch>
* Claim #9736
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Assembly: a move not captured yet is an unsaved change (#9736)
A component moved without capturing its position left the design reading
as saved: file.save wrote the file without the move and said nothing, and
closing the tab didn't ask. Now:
- Session::is_dirty is true while a move is pending, so closing a tab or
quitting asks "save changes?".
- file.save and file.save_as refuse while a move is pending, naming the
component and the capture and revert commands.
- In the app, Save As (and Save As JSON, Save a copy, Download design)
asks the Capture Position question first, as Save already did; a tab
closing after "Save" waits for that answer, and Cancel keeps it open.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Close: the save-changes card waits behind the Capture Position question (#9736)
Saving a tab that closes asks the Capture Position question first; the
"save changes?" card stayed drawn over it and took a second answer. It
now hides and ignores answers until the question is answered. The design
container doc says a save stops for a move not captured.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Assembly: an exploded view shown is not a move to save (#9736)
explode.show displays a view through the pending moves, as an uncaptured
move does. Those placements last only while the view is shown, so they
don't make the design unsaved and don't stop a save
(Session::moved_uncaptured). A move on top of a shown view still does.
The relink test saved with a move pending; it captures it first now.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Assembly: the pending-move save test reads the world state as main now gives it
world_state() returns a Result since the kernel merge; the test unwraps it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* Docs: add BoxInsertDesigner to the showcase
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Docs: attribution rows for the BoxInsertDesigner showcase recording
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The joint origin input only accepted faces, edges and vertices, so the world origin and sketch points could not be picked to place a joint. Extend the origin input's snap mask with ORIGIN and POINTS and resolve a sketch point (and the empty-body world-origin vertex) to a world snap in snap_of, so a joint can be placed on the design origin or a hole centre like Fusion.
* Sketch Project: a face or edge of a part's second placement projects where that placement is (#9957)
Projecting the face of `Block (Part:2)` failed with "face of Block: the
face no longer exists". The pick's body name was turned into the
definition's own name, and the model a sketch reads holds only each
component's first placement, so the face was looked for on the first
placement, somewhere else.
Sketch picks now keep the name the browser shows, and the further
placements a sketch's links name are placed into the model it reads
(`with_placed_copies`), when the sketch is evaluated and when a link is
added or refreshed. Only the named ones are placed. A link to a body
the model lacks also makes the sketch follow every placement, so moving
the copy moves what was projected from it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Sketch Project: a projection from a second placement follows renames of its part and body (#9957)
The link keeps the copy by the name the browser shows (`Block (Part:2)`),
which a rename of the component or of the body changes. component.rename
and body.rename now rename it in the sketches' links as well.
The copies a sketch reads are found through their component's bodies,
not by going through every body for every placement.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The Scale dialog gets a Type row, Uniform or Per axis. Per axis shows
X, Y and Z rows and sends factors, which solid.scale already takes. A
Scale made with factors opens per axis with its three values; before,
they rode along as an extra and the dialog's factor did nothing.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #4644
* Add the Fair Surface and Match Surface dialogs (#4644)
Neither command had a dialog, so the toolbar and command search ran them
with no parameters and they failed with "`body` is required".
Fair Surface picks the surface or some of its faces and sets the
strength, the iterations, whether the edges are kept and an optional
tolerance (blank: 0.001 of the body's size). Match Surface picks the
surface or face to rebuild, the target and an edge chain of the target,
and the continuity (G1, G2 or G3, default G2). Both preview, and Edit
Feature restores the saved picks and settings. New labels go through
the catalogs with English, Japanese, Chinese, German and Korean text.
* Keep surface-dialog strings pending with complete translations (#4644)
* Fair tolerance is a length; Fair and Match picks reopen on their saved bodies
The Fair dialog's tolerance now goes through the same design-unit length
conversion as the other surface lengths, on OK and when an edit is refilled.
Editing a Fair or Match feature looks its face and edge picks up on the body
they were saved on, so a coincident face or edge of another body cannot take
their place.
* Surface dialogs: strings stay in the pending catalog only (#4644)
* Surface dialogs: edge picks use the session world, as main's edge_sel now does (#4644)
* Surface dialogs: refuse to refill when a saved pick no longer resolves, and pass body names by reference (#4644)
* Surface dialogs: Fair and Match now open dialogs, so the refused-command tab test no longer lists them (#4644)
* Stderr: a closed stderr no longer stops the app, the CLI or the MCP server (#10111)
`eprintln!` panics with "failed printing to stderr" when stderr is a
pipe its reader has closed. A process another program starts writes
into such a pipe: `solidcraft mcp` under an agent, and the app that
one starts, which inherits it. #10111 is the app stopping that way
while an agent (Codex) connected. `solidcraft_geom::note!` (re-exported
as `solidcraft_engine::note!`) writes the same line and ignores a
failed write, as the CLI's logger already does; the app, the CLI, the
MCP server, the crash hook and the crates they run use it instead of
`eprintln!` outside tests.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Stderr: test that a closed stderr leaves the CLI's exit code as it is (#10111)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Stderr: the old name's alias and the fuzz command don't stop on a closed stderr either (#10111)
`solvecraft-cli` writes its deprecation notice before it starts
`solidcraft-cli`, so an agent still configured with the old name got the
panic before the MCP server started (found in review). It and the fuzz
command now write through `note!` too, and the test covers the alias.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Browser: the component menu keeps its everyday actions and groups the rest in flyouts
A component's or placement's right-click menu had grown to about thirty entries in seven
blocks. Activate, Edit in Place, Open Linked Design, Move/Copy, Show/Hide, Isolate, the
clipboard, Delete, Rename, Appearance, Physical Material and Properties stay on the menu;
Ground, Capture and Revert Position, Unlock Contents and Turn Up Axis move to a Position
flyout, Relink Source or Extract to File and the exports to File, New Component, New Group
and Paste New to New, and Show All Bodies, Cycle Component Color, Expand All and Collapse
All to Display. context_menu::entries lists a menu with its flyouts, as ui.menuPick reads it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Browser: the component menu nests its flyouts by topic, and flyouts no longer scroll
Position (Ground, Capture and Revert Position, Unlock Contents, Turn Up Axis), Component
(New Component, Rename, Appearance, Physical Material, Cycle Component Color, Relink Source
or Extract to File, Properties; Design on the design's row), Export (Export, Save As Mesh,
Send to Slicer) and Browser (New Group, Expand All, Collapse All) each open a flyout; Paste
New stays with the clipboard and Show All Bodies with Show/Hide. Flyouts open inside flyouts,
so Appearance keeps its quick choices inside Component; the keys walk in and out of them.
A flyout no longer scrolls or sits away from its row: every flyout has its own area, measured
whole, where a short one used to squeeze every later one into its height. A component's only
body is no longer offered as a component of its own on a folded Bodies folder's entries.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Browser: the component menu starts with what a double-click does, and keeps the old order of its sections
A linked component's menu starts with Edit in Place and Open Linked Design when a double-click
edits it in place (double_click_components), and with Activate otherwise. Position, Component
and Export follow Move/Copy, then the clipboard, then Show/Hide and Isolate, with Browser last,
as the sections came before the flyouts.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Browser: Show All Bodies is on a component's menu only while a body is hidden
It is listed while a body is hidden itself, in a hidden placement, or in a hidden Bodies folder or
group of bodies, anywhere in the design, since that is what it shows.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Browser: Relink Source and Extract to File sit right below Rename in the Component flyout
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Browser: Placement and Organize flyouts, Turn Up Axis back as a flyout, and flyout fixes
Placement (Ground, Turn Up Axis, Capture and Revert Position, Unlock Contents) follows
Move/Copy above the first separator, Turn Up Axis opens its two turns in a flyout again, and
the Browser flyout is called Organize. The Component flyout has three blocks: New Component
with Relink Source or Extract to File, then Appearance, Physical Material and Cycle Component
Color, then Rename and Properties.
A flyout of a flyout that opened to the left opens to the left too instead of covering the
menu, Left back to the menu chooses the row that opened the flyout, ui.menuPick refuses a row
that only opens a flyout, and the icon audit checks every level. The guides and the control
protocol describe the new menu paths.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Browser: ui.menu gives a flyout's rows their placeholder flag too
ui.menu set placeholder only on the top-level rows, so a client reading
a flyout row's placeholder got nothing. The icon audit now reads the flag
of the flyout rows instead of resolving their icons itself.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #11505
* Selection filter: started from command search, it offers Faces, Bodies, Components (#11505)
Command search ran select.filter with no parameters, which could only fail
with "missing field `mode`". Started from the UI (command search, a
shortcut, ui.start), it now opens its three modes as a menu with the
current one marked, as View > Visual style and Navigation tool do (#8868).
Programmatic calls keep their contract and open nothing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: thocsmith <193096300+thocsmith@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>