Commit Graph
4443 Commits
Author SHA1 Message Date
Mateusz SychandMateuszSychXpl bfb32cd6e1 Align: move bodies by frames that follow sketch and model geometry (#6257) (#7123)
* claim: #6257

* Align: move bodies by frames that follow sketch and model geometry (#6257)

solid.align takes from_frame and to_frame: a joint origin on the model
(a face's or round end's centre, an edge's middle, a corner, found again
by name) or a sketch point or a sketch circle's, arc's or ellipse's
centre. Both are resolved on every evaluation, so the bodies follow
their target when it changes. An optional angle turns the bodies about
the target's direction after the move.

The Align dialog takes sketch points and curves as From and To, offers
the Joint Origin snap and an Angle row.

* Align frames: box the joint origin (clippy large_enum_variant)

* Align frames: every moved body on the frame's component, placed once

* Align frames: a sketch id's length in characters

* Align frames: the dialog test's sketch curve hit carries its point

* Align frames: the dialog test takes Vec2 from solidcore-record

---------

Co-authored-by: MateuszSychXpl <151755914+MateuszSychXpl@users.noreply.github.com>
2026-11-03 15:47:52 +00:00
Hainlein4711 a8bc6b2945 Construct: allow axes in Point At Edge And Plane (#11141) (#11152)
* claim: #11141

* fix(ui): accept axes for point at edge and plane (#11141)
2026-11-03 15:46:17 +00:00
81e55b5443 New kernel cases go to solidcore's corpus; the rig's case list only shrinks (#11646)
* New kernel cases go to solidcore's corpus; tests/kernel-cases/ only shrinks

tests/kernel-cases/CASES lists every rig and ladder case there is today. `cargo xtask lists`
fails on a case directory it does not list, saying where a kernel case goes instead
(solidcore's crates/solidcore/tests/kernel_cases/, exported with `cargo xtask kernel-cases
--export` or written by hand), and on a listed case that is gone. AGENTS.md, CONTRIBUTING.md,
the tests skill, the rig README and EXEMPT say the same; a new command gets an EXEMPT line
naming where it is tested.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ

* CONTRIBUTING: the kernel-cases paragraph ends before the naming corpus one

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ

---------

Co-authored-by: jyviko <2501648+jyviko@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 15:42:09 +00:00
github-actions[bot] 138e3478e6 Regenerate generated files and fold pending files [skip ci] 2026-11-03 15:58:19 +00:00
Nathan Dane fbd30b0bd0 Panels: inspect and change layouts through commands (#11304) (#11454)
* claim: #11218

* Panels: add shared layout rules and retained content runtime

* claim: #11304

* Panels: inspect and change layouts through shared commands (#11304)

* Panels: account for layout commands in geometry coverage
2026-11-03 13:55:50 +00:00
Nathan Dane 372136fa6a Preferences redesign 7/11: Graphics (#9879) (#10662)
* Preferences: keep Graphics redesign independent on current main

* Preferences: repair Graphics search targets and CI regressions
2026-11-03 13:27:19 +00:00
FrankandClaude Opus 5.5 2aa45ef3ee GPU path tracer: compile the path pipeline one at a time per process (#6706) (#6813)
Each path test opens its own device and compiles the path pipeline. On a
cold driver cache that takes minutes and gigabytes per compile, and libtest
ran one per CPU thread side by side: on NVIDIA the solidcraft-gpu tests ran
for hours and committed ~80 GB. Executor::new now holds a process-wide lock
while it compiles; the first compile fills the driver's cache and the
waiting ones get the pipeline from there.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 13:04:23 +00:00
jyviko 41d6a9244a Merge pull request #11640 from tangency-labs/jyviko/kernel-cases-export-record-import
Build fix: the kernel-cases export takes the record type from solidcore-record (rest of #11626)
2026-11-03 10:08:12 -05:00
github-actions[bot] 8affa93051 Regenerate generated files and fold pending files [skip ci] 2026-11-03 15:03:56 +00:00
bherbruck 603c974f37 Fix main's build: the CLI imports the B-rep type from its new home (#11634)
The CLI's kernel_cases_export.rs still imported Brep from solidcraft_geom::brep after the layer split moved it to solidcore_record::brep. Changes this one import.
2026-11-03 09:52:19 -05:00
jyvikoandClaude Opus 5.5 98480ac83d Kernel-cases export: the record type comes from solidcore-record
The second half of #11626: apps/solidcraft-cli/src/kernel_cases_export.rs (#11568) imported
solidcraft_engine::geom::brep::Brep, which #11496 moved to solidcore_record::brep::Brep.
cargo clippy --workspace --all-targets -D warnings is clean with it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-03 09:35:51 -05:00
jyviko c553365a21 Merge pull request #11626 from tangency-labs/jyviko/trace-record-import
Build fix: the kernel trace takes the record type from solidcore-record (main red since #11496 + #11568)
2026-11-03 09:27:31 -05:00
jyvikoandClaude Opus 5.5 541e743d7c Kernel trace: the record type comes from solidcore-record
#11568's trace (crates/smlib/src/trace.rs) named the record as solidcraft_geom::brep::Brep,
and #11496 moved that type to solidcore_record::brep. Each merged green on its own; together
main does not compile (error[E0425]: cannot find type Brep in module b).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-03 09:18:31 -05:00
dc38349cbf Layer split stage 1: the B-rep record, native body file and Vec/Plane come from solidcore-record (#11496)
* Kernel: the B-rep record and the native body file come from solidcore-record

SolidCraft's portable B-rep record (`solidcraft_geom::brep`: brep.rs, topology, history,
envelope, part, curve2) and the native body file (`solidcraft_kernel::native`: the tagged binary
codec and the container) move to solidcore's `solidcore-record` crate: geometry as data, with
structural validation and no maths (solidcore's docs/layers.md, stage 1). Every caller uses
`solidcore_record::brep` and `solidcore_record::native`; the old copies are deleted.

What computes from coordinates stays with the kernel, in geom's `brep`:
- `brep::check`: the record's geometric checks (orthonormal frames, non-degenerate planes,
  unit revolution axes, non-singular placements). `check::validate` and
  `check::validate_built` are the record's validation and these together, and every caller of
  `Brep::validate` uses them, so what is accepted is unchanged;
- `brep::label`: a surface's natural ranges (a cone's apex), `curve_interval`,
  `edge_curve_interval` and `form_turns`;
- `brep::pcurve::eval`: a pcurve's point;
- `geometry::check`, `placement::moved` and `split_edges` become functions on the record.

The kernel's native module keeps the conversion between a body and its saved record
(metadata.rs) and checks the decoded record's geometry. `native/analytic.rs`, which no module
declared, is deleted.

solidcore-record is pinned to its rev on solidcore's `layer-record` branch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvoxKMbMFSQU8tzRtoJhtT

* Geometry: Vec2, Vec3, Plane and the profile types come from solidcore-record

The plain data of vectors and points, sketch planes and planar profiles (`Seg2`, `Loop2`,
`Region2`) moves to `solidcore-record`, with its constants and component-wise operators only
(owner decision, solidcore layer split). Their geometry stays in geom as traits:
`Vec2Geom`, `Vec3Geom`, `PlaneGeom`, `Seg2Geom`, `Loop2Geom`, `Region2Geom`, `Seg2ArcFit`,
`Loop2ArcFit` and `Region2ArcFit`, in scope with `use solidcraft_geom::prelude::*`. Every caller
names the types from `solidcore_record`; geom no longer defines or re-exports them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvoxKMbMFSQU8tzRtoJhtT

* Kernel: pin solidcore-record to solidcore main f5e8e9a29

solidcore-record is merged on solidcore main (tangency-labs/solidcore#2519); its crate there is
identical to the rev pinned before but for its clippy configuration. The lock is regenerated
against the merged rev.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvoxKMbMFSQU8tzRtoJhtT

---------

Co-authored-by: jyviko <2501648+jyviko@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 09:04:26 -05:00
jyviko bd2dc3fade Merge pull request #11611 from tangency-labs/jyviko/oracle-77-known-failure
Reference tests: the variable round on a box edge (case 77) is a known failure at solidcore 8ddce9016
2026-11-03 08:51:11 -05:00
jyvikoandClaude Opus 5.5 d9afdc33ae Oracle: case 77 (variable round r 2 to 5 on a box edge) is a known failure at solidcore 8ddce9016
It fails with status 1001 since #11360 moved SolidCraft onto solidcore alone, as the
kernel test variable_radius_on_a_box_edge already listed in tests/KNOWN_FAILING_TESTS.
The oracle keeps its own list, so main's Reference tests have been red since.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-03 08:49:19 -05:00
jyviko 1b51a0678b Merge pull request #11568 from tangency-labs/jyviko/rig-export
Kernel rig: export each case's kernel operations as a corpus for solidcore's rig
2026-11-03 08:00:07 -05:00
bherbruck e438a9bbea Web app: choose the release, the release candidate or the edge build (#11419)
The web app is now offered at /app/ (latest release), /app-rc/ (newest release candidate) and /app-edge/ (current main), each with its own browser storage. /app/ is built from the latest release's web zip instead of main.
2026-11-03 07:23:17 -05:00
jyvikoandClaude Opus 5.5 7b0906b918 Kernel rig export: review fixes
- Picks run on a copy of the operand: a pick builds query caches on the body it
  reads, so the traced body stays as an untraced run leaves it.
- An untrim and an extension record their picks with the pickers they run
  (`face_at`, `nearest_edge`).
- A final body matches the newest export of its record that an operation made.
- A stopped run is the kernel's when the last failed operation is followed by
  copies only.
- A re-export removes each case's old entry first; fixes.json is written whole.
- The manifest names no commit for a copy without git, never an empty one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-03 06:37:58 -05:00
jyvikoandClaude Opus 5.5 7e3824c0bc Kernel rig export: operand records in a gzip file beside each entry
An entry keeps what each operand body is and names <case>.bodies.json.gz, which
holds the records (gzip with no timestamp, so the same records give the same
bytes); the entry itself is pretty JSON. The corpus of 1202 cases is 33 MB.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-03 06:24:51 -05:00
jyvikoandClaude Opus 5.5 5fd0ac98a9 Kernel rig export: a failure is the kernel's when the last traced operation failed; grades SolidCraft computes are listed apart
An entry's operation is expressible when the kernel accounts for its result; the
values only SolidCraft grades (continuity, meshes, files, command answers, merged
counts, SolidCraft's wording of a refusal) are listed under `ungraded` instead of
making the whole case inexpressible.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-03 06:10:34 -05:00
jyvikoandClaude Opus 5.5 9c65a30265 Kernel rig: export each case's kernel operations as a corpus for solidcore's rig
`cargo xtask kernel-cases [--ladder] --export DIR` runs the rig with the kernel's
operations traced (`smlib::trace`) and writes one entry per case: the operation, or
chain of operations, that made the bodies the case ends with; each operand that came
in as a record, as that record; the parameters, with every pick by points also given
as the topology index it picked; the fix set; the case's expected values and the
rig's result. A case no kernel operation alone accounts for is written too, marked
not expressible with its reasons. DIR/manifest.json counts them per area.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-03 06:05:18 -05:00
bherbruckandClaude Opus 5.5 4bdffef061 Release: build Arch packages for pre-release versions (#11484)
The packaging action can't read a hyphenated version from the tarball's name, so the job gives it a name without the hyphen and renames the package back. A hyphenated version no longer fails the build if its Arch job fails; a plain version still does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 02:17:58 -05:00
bherbruckandClaude Opus 5.5 2aa7e3e51c Release 0.40.0-rc.1 (#11457)
Bumps the version to 0.40.0-rc.1 and folds the pending format changes into format 49. The default-layout header test now expects the room the version really takes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 00:59:58 -05:00
github-actions[bot] 7a7fa9a1db Regenerate generated files and fold pending files [skip ci] 2026-11-03 04:42:36 +00:00
jyviko 2b921df189 Merge pull request #11360 from tangency-labs/jyviko/merge-main-develop-solidcore
Kernel: solidcore is SolidCraft's only kernel; C++ SMLib removed (#8526 on #11351)
2026-11-02 23:27:16 -05:00
jyvikoandClaude Opus 5.5 38815796a3 Known-failing tests: the variable fillet dialog's round trip fails status 1001 at solidcore 8ddce9016
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 22:54:14 -05:00
jyvikoandClaude Opus 5.5 55a5f86e2e Kernel test: the 851 middle point's y written at f64's shortest digits (clippy excessive_precision)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 22:24:05 -05:00
jyvikoandClaude Opus 5.5 a1c8702854 Kernel ladder at solidcore 8ddce9016: the M10 both-hands thread splits more edges
06-threads/018-external-m10-both-hands makes 606 edges and 404 vertices (486 and 324 before),
with the same 204 faces, area and volume (to 1e-11), in two runs on the box; every other ladder
case is as the golden records it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 21:59:46 -05:00
jyvikoandClaude Opus 5.5 25fba581bd Known-failing tests at solidcore 8ddce9016
Five tests fail at the new pin and are listed with their causes: the variable round along a box
edge (status 1001, twice), the shell of a fully rounded box past its rounds' radius
(SM_ERR_INVALID_INPUT), the chamfer that would grow the part (no face instead of the
too-large refusal) and the box-edge round's wire record. The tabbed plate's outer loop with a
partial selection passes and leaves the list; issue2422's vertical edge now fails as a smooth
edge.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 21:57:45 -05:00
jyvikoandClaude Opus 5.5 61f07fb294 Fillets rig known-failing at solidcore 8ddce9016: eleven cases pass
851-fillet-arc-then-top-front and 851-fillet-top-front-then-upright build (9524.3437, 10 faces,
solidcore#2431); 5158-fillet-round-just-past-a-10mm-face, the curvature pipe on a plate's
order-2 section, the concave-arc and front-top rounds (r5, r7 and default) and the peg's front
and concave rounds and chamfers build and pass their checks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 21:55:50 -05:00
jyvikoandClaude Opus 5.5 47c685d471 rustfmt on the pin's changes
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 21:48:29 -05:00
jyvikoandClaude Opus 5.5 c7c28515ce Kernel test: the tabbed plate's rim and corner arc take off the rim's closed form
The rim alone was pinned to 7.958674274526857, the marched end rib's value; its closed form,
the spandrel (1 - pi/4) r^2 revolved about the disc's axis outside |x| < 4, is
7.958672911836132, which the rim's End (fillet_blend_corner) builds to 5e-8. With the corner
arc's Pappus volume the two take off 8.117808752; solidcore 8ddce9016 removes 8.117808800.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 21:47:28 -05:00
jyvikoandClaude Opus 5.5 01abf8af17 Engine test: the later round at a mitred corner, as solidcore 8ddce9016 builds it
At solidcore 8ddce9016 (pinned) the r2, r2, r3 corner at (20, 0, 20) is one patch: 10 faces,
7928.743041456134 mm³, the r3 round and the patch the second fillet's. The test is pinned to
that and leaves the known-failing list. The fork's setback corner (15 faces, 7928.142563938)
waits for solidcore#2310; solidcore#2382, not merged, moves the case to 7927.724282512234.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 21:47:28 -05:00
jyvikoandClaude Opus 5.5 ac3e6e0105 A panic solidcore's guard catches reaches the engine as EngineError::Internal
smlib's run() catches a solidcore panic and replaces the kernel (kept: the app does not die
natively), returning Error::Internal; the kernel turned it into KernelError::Failed and the
engine into Other, so hostile_params_never_panic and the fuzzer no longer saw kernel panics.
Now the kernel's wrapper errors go through KernelError::smlib, which keeps Internal; a body the
wrapper could not take because of a panic is Internal too. A feature whose evaluation hit it
records the result as internal (not cached: the kernel was replaced), and the command that
made it, or any command whose kernel call returns it, fails with EngineError::Internal under
its own id. Crash reports mark a panic inside a solidcore call recovered (kernel::guarded), and
the crash test's kernel mode panics inside a solidcore call.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 21:39:02 -05:00
jyvikoandClaude Opus 5.5 d9310b2389 Crash test: a panic inside the kernel is the command's internal error
The kernel crash test's command must fail with EngineError::Internal naming
diagnostics.crash_test, as a panic in the command itself does: the panic detectors
(hostile_params_never_panic, the fuzzer) look for Internal. Today it is EngineError::Other.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 21:39:01 -05:00
jyvikoandClaude Opus 5.5 440fdaed13 Kernel work runs on threads with solidcore's 8 MiB stack
solidcore's algorithms recurse (subdivision, intersection, filleting) and its README asks for
8 MiB, a native main thread's stack; Rust starts other threads with 2 MiB, and only the web
build set more. kernel::KERNEL_STACK is 8 MiB and kernel::kernel_thread a thread builder with it.
The kernel's parallel map runs on a pool of its own with that stack (on a worker of a pool
already, as in map_with_local_pools, it stays on that pool as before), the one-thread mesh pools
and map_on_threads' helpers have it, and so do the engine's interference worker and the
evaluator's plan-mesh thread. A test recurses 5 MiB deep on each.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 21:38:50 -05:00
jyvikoandClaude Opus 5.5 ce5fbf40ab smlib dumps: a call's inputs are serialised only when it fails
While a dump folder was set, every call serialised each input body before it ran, so the rig's
timings (taken with a folder set) measured the serialiser as much as the kernel. The callers now
hand run_on the bodies the call reads; they keep them until its result is known, and only a
failing call serialises them, into the folder as before. A test counts the serialisations: an
answered volume and union none, a failing call one per input.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 21:38:40 -05:00
jyvikoandClaude Opus 5.5 64010a1d36 SSI corpus: solidcore passes exactly the cases GSI_1E6_PASS lists, 111
The check had become one-sided after the C++ kernel's removal: a case that started passing,
or a change in the count, went unnoticed. As on main, a case that now passes fails the test
until it is added to the list, one that no longer passes is a regression, and the count is 111.
At solidcore 8ddce9016 solidcore passes exactly the 111.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 21:38:12 -05:00
jyvikoandClaude Opus 5.5 2baa3890bd smlib entry-point test: RoomReason::words asks no kernel
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 21:38:12 -05:00
jyvikoandClaude Opus 5.5 3131b933c7 Engine blend-fit test: solidcore is the only kernel, so the refusal always names its edge
The cherry-picked test asked kernel_route which kernel ran; that choice is gone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 20:38:25 -05:00
jyvikoandClaude Opus 5.5 c97092e385 Kernel rig: a solidcore pin change runs every area and the ladder
The workflow triggers on the root Cargo.toml and Cargo.lock, and the plan gets their diff
(--pin-diff): a changed line that names solidcore's repository (Cargo.toml's git rev, Cargo.lock's
source) selects every area and the ladder. A path filter cannot tell a pin from another
dependency's change, so the plan reads the lines; another dependency's change runs no area.
The fillet rig is not triggered: the kernel rig's fillets shard runs the same cases.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 20:37:38 -05:00
jyvikoandClaude Opus 5.5 44ec12cb69 Kernel rig plan self-test: a solidcore pin change runs every area and the ladder
A solidcore bump changes only the root Cargo.toml and Cargo.lock, which neither PATHS-ALL nor
the workflow's trigger paths list, so it ran no rig. The tests want a change to the solidcore
lines of those files to run everything, another dependency's change in them to run nothing, and
the workflow to trigger on both files.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 20:37:25 -05:00
jyvikoandClaude Opus 5.5 d2882754fa smlib: a volume's accuracy is clamped to 1e-8..1e-1, as mass_properties clamps it
core::volume calls measure::accuracy, the one clamp the measures share.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 20:35:44 -05:00
jyvikoandClaude Opus 5.5 955232fbea Test: a volume's accuracy out of range is clamped as mass_properties clamps it
core::volume passed its accuracy to solidcore as given: 0 fails (None), where mass_properties
takes 1e-8. A sphere's volume at 0, -1 and 1e-15 must be its volume at 1e-8.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 20:35:15 -05:00
jyvikoandClaude Opus 5.5 ae45cc6623 smlib and kernel: solidcore's refusal reasons carried through as typed errors
A shell, offset or thicken solidcore's one construction refuses because a face's offset folds
(SolidError::ShellRefused, ShellRefusal::Fold) is Error::WallFolds with the largest wall it
names; the kernel says "the wall is thicker than a face curves, so the face's offset would
fold; the largest wall that works is 10 mm". A blend too large carries solidcore's NoRoomReason
as Error::TooLarge's RoomReason, worded in its message before the largest size that fits:
a collapsed offset (solidcore#2431) says the ball is as wide as the face it rolls on.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 20:34:29 -05:00
jyvikoandClaude Opus 5.5 a3f06a4f94 Tests: a wall that folds names the largest wall that works, a collapsed offset says why
A thicken of solidcore#2350's parabolic sheet past its apex's radius of curvature is refused
by solidcore's one construction (ShellRefused, Fold, naming 10); the wrapper passed it on as
"solidcore: ..." with no words of its own. A round at the radius of the round it rolls on
beside the 851 part's arc wall is refused as a collapsed offset (NoRoomReason::OffsetCollapses,
solidcore#2431); the message named the size but not why. Both fail until the reasons are
carried through.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 20:34:28 -05:00
jyvikoandClaude Opus 5.5 954e10d6f0 smlib blends: a set-back vertex is added to the session before its corner is made
At solidcore 8ddce9016 three equal convex rounds at a vertex of three planes are the blend
corner's Ball (fillet_blend_corner). The wrapper set a setback on the corner after the corners
were made, so a set-back vertex was already a Ball (NByTwo) and its setback was refused
(CornerRefused): a_setback_corner_left_open_returns_its_hole (both) and setback_corner's
closed form. solidcore's AddSetBackVertex, called before the corners are made as the fork's capi
round_edges does, keeps a set-back vertex out of the Ball, and its corner is set back.

The corner a setback is set on may also be a blend corner whose event is the Setback, as the
capi takes it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 20:28:04 -05:00
jyvikoandClaude Opus 5.5 53cd9ea5aa smlib export: a ball patch goes out with its sphere and its net, a procedural round as its net
At solidcore 8ddce9016 a Ball corner is a BallPatch (fillet_blend_corner) and a round between
NURBS faces a ProceduralBlend (fillet_round_as_definition). The arrays' B-spline part of a face
had neither, so their export fell to the approximation and failed ("an approximated face surface
that is not a B-spline"): the rounded cube, the variable and curvature rounds and the
all-edges box in the smlib tests, and the Ball-corner and round cases of the rig.

Both are their nets, exactly. A ball patch also goes out as SURFACE_BALL_PATCH, its sphere's
centre and radius in FACE_DEFINITION_REALS, as the record's BallPatch reads it, and comes back
as solidcore's BallPatch on that net: the rounded cube's eight corners stay on their spheres
through the record and back.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 20:24:49 -05:00
jyvikoandClaude Opus 5.5 f3f8752153 Move the solidcore pin to 8ddce9016; its new fixes on, fillet_keep_features released
solidcore main at 8ddce9016 adds cone_unbounded_parameterized_as_nurb,
ellipse_open_arc_keeps_end_angle (solidcore#2422), fillet_round_as_definition,
fillet_round_on_round_as_definition, fillet_overflow_crease_along_edge,
plane_first_torus_section_exact, keep_exact_pcurves and shell_one_construction
(solidcore#2367), and drops fillet_extended_rail_end_at_side_edge_crossing.
Every one is on. fillet_keep_features is no longer held back: solidcore#2374
fixes the round beside a boss it refused (solidcore#2370).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 20:18:03 -05:00