solidcore#1747 lets an application attribute class override SMLib's handlers
(AttributeHandlers, Attribute::application), so history on solidcore now carries the capi's Tag
(smlib_history.cpp at tangency-labs/smlib f8fd83e2) as it is: one attribute of id
SM_AI_USER_1 + 7 per face or edge holding its origins, boundary edges and `at`, copy behaviour.
Split sets an untagged child to the split object's tag with its `at` (the fork's 1c7accd) and
joins it into a tagged one; Merge joins the tags on the sources other than the result; Coincident
joins into the target; Copy is SMLib's default. join leaves `at` alone, or adds a Tag without one
in place of whatever attribute of that id was there.
The two deviations the per-origin Generic attributes had are gone: a copy onto an object that
already has a tag now keeps that tag only, and an untagged object a merge or coincidence lands on
gets a tag with no `at`.
New C++ parity tests: a post subtracted from the cube it stands on, and a cube subtracted from
the one beside it, copy onto tagged entities (both fail on the per-origin port); a post imprinted
against a cube's side splits the top's edge into three, each piece lying where the edge lay, so
the side is Kept.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
An imported solid's faces were mapped to the file's only when SMLib's export numbered them as the
record did (native.rs, numbering). The export is in canonical order, which can list edges
otherwise: the two periodic-knot tubes of #1374 came back with their seam and rim edges listed
[2, 0, 1, 5, 3, 4], so the sheet, a valid B-rep, was refused as "SMLib renumbered the solid's
faces". The export's order says where SMLib's own face and edge i went; put back in SMLib's
order it numbers them as the record does, and SMLib's i is the record's i (an import lists them in
the record's order). numbering now takes that too, checked the same way; an edge split into
pieces is no renumbering and stays unmapped.
The tube test asserts what it should: one surface body, not a mesh, its faces the file's two
faces in order, every face meshed, in under a minute, and the area exact: each face is the file's
quadratic circle (corner weights sqrt(2)/2 to 12 digits) moved straight along its axis, a
cylinder's side, so 2 * 2 pi r h, which SMLib's measure meets to 1e-6.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A solid SMLib refused came in as a surface body of its faces; where SMLib could not stitch those
either, the importer meshed them with SolidCraft's planner and kept the triangles as a mesh body
(step_in/parallel.rs, mesh_part). A build without SMLib showed it: every STEP part of the import
rig came in as a mesh of its faces. That fallback is gone: the solid is not imported, and its
warning names it and gives the kernel's reason ("solid 'Cube': not imported: ..."); a file whose
every solid is refused fails with the same words.
The import report tells a part the kernel refuses (Refused) from one the reader cannot read
(NotImported), and its summary says "N parts couldn't be made into solids and were not
imported" in place of the mesh sentence (en, ar, de, he, ja, ko, zh). STL, 3MF, OBJ and glTF
still come in as mesh bodies: that is what those files are.
The two-tube sheet of #1374 had come in only through that fallback: SMLib's export lists its
edges in another order, which the next commit maps. Until then its test asserts the refusal and
meshes the faces as read at the body's coarse display tolerance, the regression it guards.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since the body check mode became part of the evaluation context (9acbcf924),
evaluate digests the context with the mode, but Model::adopt still took the
context without it and the default mode: the first evaluation after opening a
design from its saved model saw another context and recomputed every feature
(undoing_an_edit_after_opening_reuses_the_saved_results,
rolling_the_marker_back_keeps_results_after_cache_eviction). The saved model
now records the mode it was evaluated under (thinned ones too), adopt takes
it and digests the context as evaluate does, and a session opening a design
under another mode evaluates it again rather than showing that mode's results.
Model cache format 6.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The owner's bar running tangent into a cylinder rounds its concave arc and
its top edge both together and one after the other in either order, at
r 1 to 7. Two more peg cases come off the fillets known-failing list.
The ladder's shelled dome ring now has 9 edges, not 7: each of its two
cylinder walls is one full-turn face with its seam edge (one wall face per
extruded circle), where it was two halves. Faces, vertices, area and volume
are unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvoxKQ2rEZvcXNQnhE3Sgs
local_operation_closes_walls_to_nothing (WR-566, smlib@ccbf77a), linear_sweep_arc_to_cylinder_zero
(WR-576, smlib@fd59111) and imprint_reuses_coincident_face_edge (WR-580, smlib@81cd61a) are on:
their fork commits are in SMLIB_REV f8fd83e2. fillet_blend_curve_revolved_on_arc (WR-581,
solidcore#1759) is an own design with no fork commit yet, so it goes on HELD_BACK.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
Merged since 43ed10e54:
- #1747 application-defined attribute handlers (AttributeHandlers, Attribute::application,
application_value; fixes#1730)
- #1722 CreateUVTrimCurve's 101-point drop measures each point's surface distance
- #1763 opt-in local operation closes walls that shrink to nothing (WR-566)
- #1759 opt-in full-width blend-curve round revolved on an arc (WR-581, #919)
- #1750 opt-in imprint reuses a face's coincident edge (WR-580, #1519)
- #1488 iso curve at a knot above the degree is upstream's zero curve
- #1309 heal.gap evaluates the exact raw-knot UV trim curve
- #1708 reuse the same geometry object where upstream does (clone audit, part 2)
- #1714 a linear sweep tests its curve for an arc to the cylinder check's zero (fork fd59111)
- #1685 find_infinite_region propagates internal errors
- #1686 curve owners kept when classification edits write back
- #1777 bspline_surface_part is public (#1767); #1778 loopuse::notify_ref is public (#1766)
- docs: #1770 (planar section force_uv_classify, #1769), #1683 (curve sweep from faces)
- tests: #1443, #1713, #1275
- difftests: #1265, #1296, #1391, #1555, #1689, #1698, #1700, #1707, #1723, #1729, #1745, #1771
- site: #1804
main's CI test job passed on bba8d8798; its difftest jobs stop on an sccache-action rate limit and
main does not build with --features cpp (solidcore#1805), which SolidCraft does not use.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
Tests that asserted an older design rebuilds as the build that saved it made it
now assert what still holds: it opens, is upgraded, evaluates, round trips and
names alike every time, and a feature that lost a reference asks for it again.
- naming corpus: two builds still name every face and edge alike and find the
same faces with their stored names; a stored name that finds nothing must
leave its feature failed (it asks to reselect), never a feature that builds.
A sketch's face is found by its name as the sketch finds it.
- design corpus: the volumes, areas and bounds the saving builds recorded are
no longer compared; a corpus design may fail only by a request to reselect,
and undo leaves the features that failed on opening failed.
- fixed robustness seeds: no panic, valid bodies and volumes moving the right
way; a step the kernel refuses is not a bug.
- a format 28 design's pieces and a format 13 design's extra bodies: marked as
they open and named alike, without promising the numbers or names saved.
- action matrix baseline: the two corpus designs whose fillets, chamfer and
offset face held names saved before format 14 re-recorded.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Face and edge names stored before format 14 were worked out from geometry and
open marked `?`. They were found among the names geometry gives today, as the
builds that saved them found them, pieces by the one nearest the pick. They
find nothing now: the feature holding one fails, asking for its reference to be
picked again, which stores its exact name. The legacy face and edge names a
body worked out for them are gone.
The tests that found such names as saved now assert the request to reselect:
a saved strip projection, a version 9 emboss on an annulus, a format 10 face
sketch and the corpus design named with numbered pieces.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face or edge name a feature stored finds only the face or edge it names: the
very name (or a synonym of that face), or the named piece told apart by the
faces around it. A face split into several pieces, merged into another face,
or left only as a face of the same stem is not the face that was picked, and a
name found on several bodies is told apart only by the body the reference's
point lies on. The fallbacks are gone: no piece nearest the pick, no merged
face, no edge at the picked point, no lost link that keeps its last geometry.
A feature whose stored reference finds nothing fails with DocError::Reselect:
blends, face points, sketch planes, sketch projection links, construction
references, hole reference edges, sheet bend edges and cylinder emboss.
The tests that asserted a fallback now assert the request to reselect: split
and removed fillet edges, a merged or rejoined face, a projected edge that was
split or is gone, a projection whose body went, saved strip projections after
wall coalescence, a fillet saved on a piece of a tapered side that is whole
now, a cut that starts from a piece that is no longer that piece, and a fillet
named on the lower of two stacked boxes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A side drawn in collinear sketch pieces is one face the extrude made from each
piece (#1788): its first role is its name, and the others were kept as aliases,
like the names of faces merged into it by a later join. They are names of that
very face, not of faces merged into it: the face keeps them as synonyms, which
a stored name matches as exactly as the face's name (a piece of it, once it is
split), through copies and later features, and the face whose name a merge
keeps keeps its synonyms too. An extrude-side certificate made on one of the
pieces finds the joined face the same way, and the saved model records the
synonyms (model cache format 5).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each component's bodies lie in its own coordinates in the state a feature's
points are named in, so a part inserted twice has a face at the same point in
each copy: a thread on the second copy was named after the first copy's face.
The points are named on the feature's own component's bodies first, then on
every body for a point that lies on none of them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
FeatureKind::face_body did not name Untrim's body, so its face was looked up by
name on every body and could be taken from another one (a copy has the same
face names).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DocError::Reselect names the feature and the stored reference (a face or edge
name) that no longer finds what was picked: "<feature>: the reference `<name>`
no longer exists as it was picked; reselect it". Evaluation fills in the
feature's name; reselect_parts reads both back from a feature's error text, and
the UI shows the message translated (ar, de, en, he, ja, ko, zh in
assets/locales/pending/reference-reselect.json).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ports tangency-labs/smlib@1c7accd's capi/src/smlib_history.cpp change into
core/history.rs `read`: a face is Kept when the pieces of each of its edges
are all on its boundary and together lie where the edge lay (between its
ends, through the points it ran through), not only while each edge is still
whole. `moved` now takes all pieces of one edge: their odd-count vertices
are the edge's ends (none for a closed edge, whose end some piece still ends
on), and each recorded point lies on one of them. The capi's Split handler
now gives an untagged split child the split edge's `at`, which the
attribute-per-origin port already did; the module note says so.
Test a_face_whose_edge_is_only_cut_by_a_vertex_is_kept: a bar imprinted
across a 40 x 30 x 20 block's top cuts the top edges of y = 0 and y = 30 by
a vertex each; both kernels give the block's other five faces Kept, none
Modified, and the same history.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
The Design page's Body check section sets the validation preference
(each_feature; each_step keeps the old checks after every step; off is
experimental), applied to the session like the hole and surface extrude
preferences, to the sessions a design is opened in off the window thread,
and kept in step with diagnostics.validation. ui.prefs refuses an unknown
mode; a saved unknown one reads as the default.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
solidcraft-cli run --validation MODE, kernel-cases --validation=MODE and
cargo xtask kernel-cases --validation MODE (with --ladder too), so the rig
runs under each mode.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With input and output schemas. The mode is the session's user setting:
kept when another design is opened, started, recovered or imported (each
evaluated under it), and by timeline.compute_all. Linked and extracted
designs are evaluated under it too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The model carries the mode (Model::set_validation) and runs each feature
under it. When a step left its check, every body the feature made or
changed is checked by SMLib before the state is kept: a body the check
refuses fails the feature with the check's reason and the body's name.
The mode is part of the cache context, except each_step, whose results
are develop's.
Validation::EachStep checks every solid sweep, boolean and blend result
in SMLib as before; EachFeature leaves those checks to the end of the
feature and says a check was left; Off skips them. The evaluation installs
the mode around a feature (validating), as watch installs a watch; outside
it every step is checked as always, and the kernel's worker threads run
under the caller's mode.
Under EachFeature a body decoded from a step keeps that step's SMLib
result (for its own record only), and check_kept checks it as the step's
own check would have, then lets it go; any other kept body is checked as
SMLib imports its record. The record can pass where the result fails: a
fillet's surface of revolution whose polar curve SMLib's check refuses
(fillets/1080-fillet-sloped-basin-1-mm-rim-r0-5-4-edges) is rebuilt on
import, and its round meets a wall at 72 degrees; checking the record
alone kept that round.
The largest-size search of a blend checks every candidate as it is built,
whatever the mode: a candidate fits only as a body the check accepts.
Surface operations and stitching keep their checks.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fillets/1080-chamfer-runs-into-openings-refused already expects the
9 mm chamfer built and cut by the openings (V = 3350); its id said it is
refused. It becomes 1080-chamfer-runs-into-openings-cut-by-them, and
blend_fit's chamfer_through_the_openings_is_cut_by_them names it so.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The owner's ruling of 2026-10-30 (d7): a chamfer that reaches or runs
past a rim builds, everywhere, as SMLib's cliff overflow builds a convex
blend: on its faces' continuations, then cut by what the cliff cuts
away. The earlier rule refused a chamfer whose leg runs off its face.
SolidCraft has no such refusal of its own; SMLib refuses these, so the
cases fail on SMLib 985faaee and are listed with its reasons (traced in
gdb at SmFilletErrorInfo::NoteError):
- the sloped basin's single front edge past its rim (1 mm rim 2 and 3,
0.5 mm rim 4): CloseRemovalRegion, "a cliff overflow's fillet boundary
lies on the surfaces of two faces": the sheet's boundary along the end
wall's top edge line from the edge's vertex to the top's contact
(x = 20, y from -1 to 1, z = 30) lies on the top's plane and the end
wall's both.
- the equal-slope basin's rim loop 2 and the 5 mm pocket's rim 5.5:
CloseRemovalRegion, "a cliff overflow's fillet boundary closes on one
face" (every edge of the loop blended).
- the sloped basin's front and right edges 2: status 1001,
SmFilletNx2Corner, CalcFilletIntSideFace.
- the cylinder's rim 2 across the top and 25 down its 20 mm wall: status
1001, SmFilletNx1ClosedCorner cannot compute its geometry.
Expectations, each from a closed form or an exact quadrature:
- chamfer_wider_than_sloped_basin_rim_is_refused becomes
chamfer_wider_than_sloped_basin_rim_builds, ignored until SMLib builds
it: the triangle clipped to y >= 0, times 30 + z (shoelace):
73.450475, 142.112912, 184.526613; the rig's 1080-chamfer-sloped-
basin-*-past-the-rim cases: V = 144459.882858, 144391.220421,
144082.140054.
- blend_corner's a_rim_loop_chamfer_running_off_its_rim_is_refused
becomes ..._builds, ignored likewise: sliced at depth t the mitred loop
takes the pocket's rectangle grown by w(t) = d (1 - t / delta) on each
side, clipped to y >= 0, less the rectangle, Simpson exact on each
quadratic piece: 375.673069, V = 139957.660264 (the rig's
1080-chamfer-equal-slope-basin-1-mm-rim-loop-2 too).
- 5835-chamfer-sloped-basin-1-mm-rim-2-two-edges: the same slicing with
the front and right sides grown, 161.279149, V = 144372.054184.
- every-chamfer-pocket-rim-5-5-past-the-floor: 50 d^2 + (4/3) d^3 at
5.5, the groove 0.5 deep round the floor included, V = 19265.666667,
15 faces.
- 2893-chamfer-two-distances-past-the-bottom: the frustum r 8 to 9.6
over 20, pi 20 (64 + 76.8 + 92.16) / 3 = 4879.102831, 3 faces.
Each drops "-refused" from its id (the 5.5 pocket's says past the floor).
The same slicing reproduces the existing 5835-...-4-mm-rim-2-2-edges
(176.006388), equal-slope loop 0.5 (24.455545) and half-width
(5.426545) values.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The owner's ruling of 2026-10-30 (d7): a chamfer that reaches or runs
past a rim builds, everywhere. The earlier rule refused a full-width
chamfer, naming the largest size that fits. SolidCraft has no such
refusal of its own (a blend's TooLarge is SMLib's SMLIB_ERR_NO_ROOM,
and the doc layer only names the largest fit), and SMLib already builds
these, so only the expectations change, each from a closed form or an
exact quadrature:
- chamfer_wider_than_sloped_basin_rim_is_refused's full widths become
chamfer_as_wide_as_sloped_basin_rim_builds: the whole triangle,
d drop / 2 (60 - drop / 3), drop = 20 d / sqrt((20 - margin)^2 + 400)
(shoelace over the section, its length 30 + z between the sloped end
walls): 21.662379 (1 on 1 mm), 5.359321 (0.5 on 0.5 mm). The basin and
the removal move into sloped_basin and sloped_basin_rim_chamfer_removed.
- fillets/1080-chamfer-sloped-basin-{1,0-5}-mm-rim-as-wide-as-the-rim:
V = 144511.670954, 144261.307346.
- fillets/every-chamfer-pocket-rim-5-full-depth: 50 d^2 + (4/3) d^3 at
d = 5, V = 19583.333333, 11 faces (the walls used up).
- fillets/every-hole-top-rim-chamfer-10-full-depth: the triangle 10^2/2
revolved at rho = 5 + 10/3 (Pappus), V = 16000 - 3250 pi / 3 =
12596.607959, 7 faces.
- fillets/1113-chamfer-arc-top-edge-full-wall-height: the 9.5 case's
Int rho asin(21/rho) h(rho) drho at s = 10, by Gauss-Legendre in
u = asin(21/rho), 1303.400331, V = 8287.993768.
Each drops "-refused" from its id and its KNOWN_FAILING line goes: all
five pass on SMLib 985faaee.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fillet_chamfer_cone_stored_as_cone (WR-572, smlib@b5743ec), offset_point_vertex_caps (WR-531,
smlib@d5dadaa), approximate_surface_bezier_starter (WR-573, smlib@eae96cb),
proto_edge_splits_at_captured_vertices (WR-579, smlib@9eec159) and stitch_solid_nests_cavities
(WR-569, smlib@351c57c) are on: their fork commits are in SMLIB_REV 985faaee.
bspline_trim_keeps_rational_end_spans (WR-575, solidcore#1711) has no fork commit, so it goes on
HELD_BACK.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
A joint drive with contact on tested each sample and each of 14 bisection
steps with a brute-force mesh-against-mesh overlap check, its cost the product
of the two display meshes' triangle counts under a fixed budget. Since the
display mesh puts nodes inside planar faces, a cam and its tappet or a block and
a sphere exceed that budget ("motion exceeds contact sweep collision budget"),
and whether a motion may run depended on display tessellation.
Now, at each sample, bodies whose exact boxes meet are intersected exactly
(SMLib boolean, exact volume); a shared volume is a contact, a touch (a cam and
its follower) is none. Between the last clear sample and the first overlapping
one the drive closes in by conservative advancement: from a clear placement it
moves no point of the pair further than the pair's exact gap (body_distance),
until the gap is within 1e-9 of the bodies' size. Only clear placements are
measured, so no intersection is asked to tell touching from overlapping within
its tolerance (SMLib's boolean fails there, status 1001, on two cubes 1e-4
into each other). The budget is 2048 intersections per drive.
Fixes cmd::joints::tests::cam::a_cam_drives_a_closed_loop_and_stops_at_a_contact
and contact_sweep ordinary_curved_bodies_stop_at_their_contact_within_the_sampling_budget,
and the other contact, cam, motion, interference and clearance tests pass.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The batch brings history Kept for a face only cut by a vertex, revolve of a
curve touching its axis, loops touching at a vertex, a torus rail on its axis,
and the fillet causes behind the owner's bar running into a cylinder: a
tangent edge past a tangent side edge is the corner's edge, the rails of a
round collapsing at its end end at one point, and a trace from a tangent point
starts along the curve.
The two peg cases with the sketch's solver residues come off the fillets
known-failing list: both build.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvoxKQ2rEZvcXNQnhE3Sgs
The test it replaces probed for a polyline by placing a 0.2 um square in the
gap between the rim and a 1 um polyline: a micro feature in a millimetre part.
This one asserts the property itself, in millimetres: every rim segment of the
flat pattern is an arc of radius 10, the DXF draws one circle of radius 10, and
a 1 mm cut 0.5 mm inside the rim stays one hole.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The port asks CreatePlanarSectionCurves for UV curves, so it now forces the UV classify: an
analytic face's intersector makes no UV curve, and without the flag the trim dropped the whole
section and the call answered Empty. SmBrep.h documents the flag for exactly this case. The
capi still leaves it FALSE, so the C++ kernel keeps answering Empty on analytic faces; the
parity test now holds the port to the section there and to the C++ curves on the loft.
a_cylinder_side_section_is_its_circle is un-ignored; a_box_top_section_is_the_line_across_it
checks the line (5,0,10)-(5,10,10) across a 10 mm box's top.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
A G2 corner patch's side is G2 to its round except near the face it ends
on, and SMLib holds each side as two edges. The smooth-join test judged
each edge alone, so the G2 half was hidden and the line stopped at the
vertex in the middle of the seam. Edges between the same faces that
continue each other at a shared vertex now share one verdict: smooth only
where every one of them is.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
solidcore's local operation carries the B-rep's attributes since 1ee3a930c, which the pin
3569b5d73 holds, so history::tags_cross_a_draft runs again and matches the C++ draft. The draft's
body is no longer marked untracked: Brep::made_core_draft goes and ops::draft answers with
Brep::made_core, so a draft's history is read as every other solidcore operation's is.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
fillet_torus_span_from_start_section (WR-568, smlib@985faae), fillet_knife_edge_rounds (WR-570,
smlib@b7ec55b), taper_wall_closes_at_apex (WR-571, smlib@183ea65) and
revolution_round_offset_collapses (WR-567, smlib@8b2090f) are on: their fork commits are in
SMLIB_REV 985faaee. HELD_BACK keeps only precise_properties_trim_base_v, which has no fork commit.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
core/history.rs ports smlib_history_tag and smlib_history_read onto solidcore's
B-rep-owned AttributeStore. Each origin is an attribute of its own (its id names
the origin), so SMLib's default Split/Merge/Copy/Coincident handlers, which add
an attribute unless the object has one of its id, give the union the capi's Tag
handlers make. A face's origin carries its boundary edges then, an edge's the
points it ran through, and the read classifies Kept/Modified/Split/Merged/
Generated as the capi does.
Brep remembers the kernel that made it (history is read there; the flat arrays
carry no tags) and, for a tagged body, its operand, so the body converted for
the other kernel is tagged the same way. Blends (solidcore#1594) and drafts,
which do not carry attributes yet on solidcore, give "not supported yet" for
their history instead of an untagged one.
tags_cross_a_solidcore_boolean now passes. Parity tests against the C++ kernel:
union, subtraction, intersection, side-by-side union (merged faces), imprint,
copy and shell agree; fillet (solidcore#1594), face offset (solidcore#1060) and
draft are ignored with the reason.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
patch_continuity_and_points_cap_a_tube listed "g3" among the values surface.patch must refuse,
from #1521 when a patch built G0 to G2. Since cb8712aa0 Construction::Patch builds G0 to G4
(continuity_order.rs: `Construction::Patch => (G0, G4)`), so g3 is accepted, as it must be;
the order above what a patch builds is g5.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The block solve kept its sparse entries in hashed maps and summed the coupling of each patch's
interior onto the shared unknowns in the map's order, which a hashed map draws afresh each
time: the same loop filled to surfaces differing in their last bits, so a design read back
rebuilt another cap (engine patch_continuity_and_points_cap_a_tube, "the same surface read
back"). The entries are now in ordered maps; a fill twice of the tube's ring and of a hexagon
about a centre are bit for bit the same.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A tube's end has no corner at all; the kernel gives its circle in four quarters, and one patch
on them has a corner on each quarter joint where the loop runs straight on: flat, its two
derivatives parallel, which SMLib's check refuses (Bad Surf FlatCorner within 0.5°). Any
layout with a patch corner on such a loop has one.
Such a loop is now the ring of structured meshing (an O-grid): four patches each on one side of
the loop, two meeting at every point of it, about one inner patch (Quilt::ring). The spokes are
now any curve two patches share (Seam), each glued G1 with linear gluing functions: at an inner
vertex of valence m the characteristic value ±2cos(2π/m) (the centre's spokes as before, the
ring's inner corners with m = 3), at the loop what its two sides' derivatives there ask
(foot_gluing; 0 and their speeds' ratio where the loop runs straight on). IsoFill says where each
spoke starts and ends (SpokeEnd) and holds the inner vertices; the kernel builds them so.
The tube end caps G1 (normal within 0.0157° of the wall, sealed 10458.232 against the tube and
dome's 10458.232) and G2 (curvature across 4.6e-5 /mm against G1's 0.30), five faces with no flat
corner. A crown on the ring lifts the inner patch whole (the ring rises as v(2 − v)).
Saved designs: a general patch on a smooth closed loop (a tube's end) rebuilds as five faces
where it was one (which SMLib refused).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The crown moved the free points along the patch's own normal, whose sign is only the way the
patch happens to be parameterised: the pentagonal window's crown 0.1 sank 1.56 mm into the
cylinder (the middle 9.959 from the axis plain, 8.395 crowned) where the kernel documents it
filling out to the side the G1/G2 neighbours' normals face. The crown now takes that side: the
sum of the patch's normals against the neighbours' over the stations sets one sign for the fill.
The pentagon's middle goes out to 11.526.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The crown's bump went onto the first net with any control point clear of the loop; a coarse
net could leave points supporting the box's middle without it, so the middle rose by only a
share of crown · size (the pentagonal cup: 7.6558 of 13.3877). The net is now refined (knot
insertion, the surface unchanged) until every point whose basis is not zero at the middle takes
the bump, where the middle is inside the loop: the bubble is then exactly 1 there, as fill_loop
documents.
The kernel test measured against the face's domain, which SMLib holds as the loop's extent; the
documented box is the height field's whole domain, the loop's box and 1% more each way (as the
engine's crown test says, 28 × 28 + 1%). Its diagonal is 1.02 times the face's, so the
documented rise is 0.25 × 53.5506 = 13.387661 = 1.02 × 13.125158, which the patch now meets to
1e-6 for crowns ±0.25.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face's domain and pcurves are on Face::parameters() (its NURBS form when it has one, the
record's documented contract); the general fill tests' quadrature and the pick-order and crown
comparisons evaluated Face::surface instead. A fill SMLib recognises as an analytic surface (the
240° window's G0 patch is the cylinder itself) then read its arc-length domain as angles: the
quadrature came out 4188.79 for the window's 418.879 (10 × 41.888 of angle against 4.189).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>