Commit Graph
3909 Commits
Author SHA1 Message Date
brett19andClaude Opus 5.5 b4e0da3db8 KNOWN_FAILING_TESTS: cite solidcore#2048
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 10:01:21 -07:00
brett19andClaude Opus 5.5 ff39488aad solidcraft-tests skill stays under its length
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 08:26:19 -07:00
brett19andClaude Opus 5.5 c5e4a42f4f Format
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 08:20:36 -07:00
brett19andClaude Opus 5.5 869165d326 KNOWN_FAILING_TESTS: exact causes of the action matrix failures
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 08:09:43 -07:00
brett19 fdb9134a9b Merge branch 'solidcore' of https://github.com/brett19/solidcraft into ws/default-solidcore 2026-10-31 07:42:22 -07:00
brett19andClaude Opus 5.5 99ba9dfb1a Tests known to fail, one list per kernel; untrim carries history tags; fix two tests
KNOWN_FAILING_TESTS is now solidcore's, the default; KNOWN_FAILING_TESTS.smlib keeps
the C++ kernel's. A face copied out for untrimming now carries its tags on solidcore.
The profile test accepts either kernel's spans; ssi_corpus skips a kernel the
environment overrides.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 07:42:22 -07:00
brett19andClaude Opus 5.5 130aaa38c0 Solidcore known-failing lists at pin 9dde25e97; ladder gate stays on the C++ kernel
KNOWN_FAILING.solidcore lists the 24 cases that fail on the default kernel, 23 of them also on SMLib's
list. The ladder golden is the C++ kernel's and solidcore differs on one case, so that gate opts in.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:36:07 -07:00
brett19andClaude Opus 5.5 aca0b57eea Turn on plane_recognition_origin_after_axes
The fork places a recognized plane's origin after squaring its axes (0286682, in SMLIB_REV;
SmPlane.cpp:2836-2852 at 2fc375f), and solidcore#2004 brings the same behind this flag. It closes
sweeps/4305's Bad Gap and moves sweeps/5037 to SMLib's volume.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:14:49 -07:00
brett19andClaude Opus 5.5 83487c4d93 Pin solidcore at main 9f2c980b3 (#2004, #2005, #2006, #2008)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:14:49 -07:00
brett19andClaude Opus 5.5 ad6fd72bcf Merge solidcore 9b73dfe74 (ws/pin-5) into ws/default-solidcore
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:14:28 -07:00
brett19andClaude Opus 5.5 7979615c08 Rig gate grades the kernel given
--known-failing follows the run's kernel: KNOWN_FAILING.solidcore for the default and the CI gates,
KNOWN_FAILING for --kernel smlib. The solidcore lists come with the final pin. Also fixes the --route
test for the new default.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:11:18 -07:00
brett19andClaude Opus 5.5 4d997d16f6 smlib: SSI on solidcore, its failure dumps and call in flight; rows that are true
ssi::intersect, domain and evaluate run on solidcore (global and advanced; the basic intersector has
no public entry and says so), and ssi_corpus scores both kernels: six cases C++ passes are listed as
solidcore's misses. A failing solidcore call now leaves its B-rep inputs and what failed, and
current_call names the running call without a lock. Op::History and Op::Flat, read by nothing, are
gone from the table, so diagnostics.kernel reports only what is true.

A guard test keeps the list of entry points: with no C++ kernel each answers, but for the C++ kernel's
own arrays. route::on_cpp now fails a test that never reached C++.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:11:18 -07:00
brett19andClaude Opus 5.5 9b73dfe749 Offsets go through solidcore's simple calls; ignored tests cite solidcore issues
`shell_brep_simple`, `offset_brep_simple` and `local_operation_simple` carry the same options and
the source's attributes, so the 120 lines of key domains and notification stores in core/offset.rs
go (gap-audit D2). The held-flags comment now says what each flag's fork code does. Ignored tests cite
solidcore#1980, #1462, #1973 and #1981 instead of local files.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:01:40 -07:00
brett19andClaude Opus 5.5 5ffc55e530 Profiler: a span per solidcore call, in a category of its own
The smlib category times the C API's calls, so on the new default the kernel's calls went unseen.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 02:48:16 -07:00
brett19andClaude Opus 5.5 f01b877570 Audit the held flags against the fork's source; tabbed plate and mitred rounds parity
Reading the fork at SMLIB_REV finds `perspective_sphere_offsets` is there (709c5be: the cull projects
each sphere's own radius from its centre), so it goes on. The new
`gap_samples_use_trimmed_spans` and `twist_simple_duw_sign` are held: upstream's defects are still in
the fork.

The tabbed plate and #1997's rounded box are compared with the C++ kernel. `sweeps::List` is visible
to the crate for that.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 02:37:40 -07:00
brett19andClaude Opus 5.5 2badb54040 Geometry kernel preference: say that Routed is solidcore for every operation
The note (all seven languages), the command's description and the test: smlib keeps the C++ kernel
reachable for every family, the old behaviour.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 02:35:56 -07:00
brett19andClaude Opus 5.5 b1e5b31b2d Rig: kernel-cases runs on solidcore unless told otherwise
--kernel smlib and both remain. --known-failing still grades the SMLib side, whose lists these are,
so it needs that said, and the CI gates opt in. The ladder takes --kernel for its one backend.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 02:35:43 -07:00
brett19andClaude Opus 5.5 ee078b97c4 smlib: no unrouted C++ path on solidcore; .smb files move too
Native files run on solidcore through its public api_files (each kernel reads the other's, in both
forms). face_points routes with Split, pcurves with Convert, and an ssi::Surface no longer needs the
C API: its arguments are checked here as the C API checks them, and the C side is made only when a
family on the C++ kernel asks. intersect, domain and evaluate have no solidcore path and refuse with
Error::NotOnSolidcore. Planar region booleans and the rig CLI no longer need the smlib feature.

Tests that exercise the C++ kernel opt in per thread (route::on_cpp), so parity tests keep comparing
two kernels instead of solidcore with itself.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 02:35:43 -07:00
brett19andClaude Opus 5.5 03470c3df3 Pin solidcore at main 9dde25e97 (#1988, #1997, #1985, #1940, #1974, #1975, #1976)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 02:25:14 -07:00
brett19andClaude Opus 5.5 612ac9a367 Merge ws/pin-4: solidcore 166d2de01, variable-span and coincidence flags on, parity tests for the audit's fixes
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 02:24:21 -07:00
brett19andClaude Opus 5.5 e8e26db71c Tests hold what they measured: 871's refusal is NoRoom, no prints
The ring and lip test says it does not single out the crossing flag: it passes with the flag off
on this path.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 02:23:09 -07:00
brett19andClaude Opus 5.5 887a1c9f1d Route every operation family to solidcore by default
The routing table now sends each family to solidcore; the C++ SMLib kernel is an opt-in
(SOLIDCRAFT_KERNEL=smlib, the Geometry kernel preference, SOLIDCRAFT_KERNEL_ROUTES). Native .smb
files stay on SMLib here; the next commit moves them. Fallout follows in separate commits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 02:20:38 -07:00
brett19andClaude Opus 5.5 6c3cc42d74 Turn on the variable round, crossing and status flags; test #871, ring and lip, step wall
On, their fork commits in SMLIB_REV: `fillet_variable_span_follows_fillet` (4438859),
`simple_coincidence_crossing_is_point` (c2e3d9d), and from solidcore#1775 the statuses whose fork
passes do what the flag does: `boolean_temporary_transform_statuses` (e7ebc8d),
`primitive_path_curve_statuses`, `planar_path_sweep_statuses` and
`planar_path_profile_placement_statuses` (c8f6a31), `fillet_trim_status` (9b7cd48). The last two
were held as having no fork commit, which was wrong.

Held: `fillet_corner_statuses`, `fillet_edge_curve_domain_statuses`,
`offset_tangent_gap_statuses`, `ssi_alignment_statuses` (the fork carries on softly where these
refuse) and `translation_sweep_regularize` (no fork commit).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 01:51:42 -07:00
brett19andClaude Opus 5.5 e75015a9a2 Pin solidcore at main 166d2de01 (#1983, #1987, #1990, #1991, #1992, #1775, #1937)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 01:44:37 -07:00
brett19andClaude Opus 5.5 9fb8e778ff Merge ws/pin-3: solidcore bdd614891, tight box and SSI probation flags on, measure's dead string match removed
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 01:33:09 -07:00
brett19andClaude Opus 5.5 29134cfb80 Turn on the tight box and low angle start flags, hold the rest with what was checked
`face_tight_box_searches_trim` goes on now that solidcore#1961 brings fork 326de73.
`ssi_low_angle_start_on_probation` goes on: fork 30d25bf was rebased to 1f5c0f7, in SMLIB_REV.
Three port fixes and the new `extent3d_contains_both_segment_endpoints` stay held: the defects are
still in the fork's source at 2fc375f.

`measure::check` no longer matches `check_brep`'s operation string. solidcore does not raise that
error (a Caller body without keys is checked under arena identities), so the arm was dead; the
refusal is decided on the typed `NamingScheme` alone, and a test holds it there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 01:11:45 -07:00
brett19andClaude Opus 5.5 bdc9c8f1eb Pin solidcore at main bdd614891 (#1961)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 01:09:19 -07:00
brett19andClaude Opus 5.5 c156ab444e Merge ws/pin-2: solidcore ef3a24ab1, review fixes, mitre gap, run-on and tight drop flags, capi area and cone draft
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 00:53:00 -07:00
brett19andClaude Opus 5.5 59dfe27433 smlib: a cone about the pull drafts to the cone its generators turned make, on solidcore (capi d51a723, smlib#53)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 00:40:26 -07:00
brett19andClaude Opus 5.5 0b83327edd smlib: a body's area counts its sheet faces on solidcore (capi 9767916)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 00:40:26 -07:00
brett19andClaude Opus 5.5 f85398899a smlib: flags at solidcore ef3a24ab1; the L sheet's thicken test runs (#1950 fixed)
On: fillet_mitre_gap_patch (fork 2223108), fillet_run_on_past_far_end_only (7224896), good_drop_result_distances_in_order (eaa998a). Held back: geometric_g2_continuity and solidcore's new flags with no fork commit in SMLIB_REV.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 00:35:29 -07:00
brett19andClaude Opus 5.5 e0fb9ca9d4 Pin solidcore at main ef3a24ab1 (#1947, #1948, #1949, #1958, #1960)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 00:34:48 -07:00
brett19 b13ee97b0c Merge remote-tracking branch 'fork/ws/review-1031' into ws/pin-2 2026-10-31 00:33:43 -07:00
brett19andClaude Opus 5.5 7f6b96e65e Merge ws/next-pin: develop 20d5d8b, SMLib 2fc375f, solidcore 117a3b86d, cliff, mitre and offset-faces routing
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 00:33:32 -07:00
brett19andClaude Opus 5.5 3eb4d96e63 smlib: clippy in the chamfer repro test
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 00:31:41 -07:00
brett19andClaude Opus 5.5 a7bb27dae5 smlib: hold back the overflow-first ordering; mitre oracles and two solidcore repros
The ordering (fork 241f7ba) is ported but off (OVERFLOW_GOES_FIRST): solidcore's cliff overflow loses the attributes of target edges its subtraction replaces, so a shortened picked edge reads as removed and is silently not rounded (2 rig cases wrong). Tests: the capi's rounds_at_a_concave_face_corner_are_mitred; overflow_goes_first (ignored, gives 6107.529369565 with it on); two ignored solidcore-only repros.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 00:20:56 -07:00
brett19andClaude Opus 5.5 8e93872bbb smlib: hold back solidcore's two new flags at 117a3b86d (no fork commit)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 23:35:52 -07:00
brett19andClaude Opus 5.5 5a23119137 Pin solidcore at main 117a3b86d (#1963 closes #1950, #1925)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 23:35:52 -07:00
brett19andClaude Opus 5.5 c5503f7c3f smlib: the L sheet's thicken test names solidcore#1950, which it turned out to be
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 23:33:29 -07:00
brett19andClaude Opus 5.5 fd270252f2 smlib: convert: process kernel for wire edges, unheld surfaces refused, conics make their NURB
L1: GetWireEdges uses the process kernel, not a fresh default one.
L3: a face whose surface the B-rep's list does not hold is refused, as smlib_flat.cpp:1520.
L4: a hyperbola or parabola without its NURB makes one on a copy, as GetOrCreateGwNurbPointer.
L5: every rejection of the C++ Validate is in ours, read line by line; a mutation test against
the C++ kernel holds it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 23:32:17 -07:00
brett19andClaude Opus 5.5 0eb73bc655 smlib: an L sheet's thicken parity test, ignored for a solidcore refusal
C++ makes the closed form, 840 mm3. thicken_planar_side_walls makes solidcore answer
Unported "SmFace handle of a surface's face". Written up apart.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 23:32:17 -07:00
brett19andClaude Opus 5.5 7b6537e935 smlib: rustfmt
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 23:31:24 -07:00
brett19andClaude Opus 5.5 4ea96a750c smlib: flags at solidcore 42aab6a6d, cliff refusals by NoRoomReason, overflow-first ordering
Flags on: fillet_cliff_overflow, fillet_3x2_tangent_side_edge_roles, offset_extension_as_itself, fillet_mitre_concave_face_corners (fork commits in SMLIB_REV 2fc375f). Held back: the port's own fixes with no fork commit. Ports capi blend_call / overflow_first (fork 241f7ba) onto the hooks of solidcore #1929, with blend_dropping routed. From ws/cliff-1905: blend_failure on NoRoomReason, fillet_over_a_cliff un-ignored, a_cliff_overflow_the_fork_refuses_has_no_room.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 23:26:37 -07:00
brett19andClaude Opus 5.5 21d8c1ab49 smlib: route offset_faces to solidcore's OffsetFacesExecutive; named() keys are (kind+1)<<32|index
The keys no longer collide past arena index 1,000,000 (test at that index). Un-ignores offset_faces_top_out and tags_cross_a_face_offset (solidcore #1890, #1895).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 23:26:37 -07:00
brett19andClaude Opus 5.5 e69cbae539 smlib: port capi 2fc375f (split by a sheet) and 0f7b209 (extend run-off solved) to solidcore
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 23:26:37 -07:00
brett19andClaude Opus 5.5 67b5d928c8 smlib: history parity over closed edges, seams, three operands, sheets and merges
Closed edges including moved()'s open.is_empty() branch, a curved face split across its
seam, union_all of three, merges with several origins on each side, sheet offset, a
curved sheet's thicken and a shell of a cylinder match C++. Two tests are ignored for
solidcore differences written up apart: boolean_2d carries no attributes, and a flat
sheet's thicken loses the edge tags on the sheet's side.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 23:23:04 -07:00
brett19andClaude Opus 5.5 dda7d6a0ec smlib: a failed closest point in history's moved counts as off the piece
smlib_history.cpp:246 counts any failure of SmApiEdgeClosestPoint as off the piece, so
the face is Modified. The port passed on an error that was no status, which failed a
boolean that had succeeded. An edge without its curve shows it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 23:15:40 -07:00
brett19andClaude Opus 5.5 a0ea9ba1c4 smlib: an offset edge that vanishes is Unsupported, as the capi's status says
Found comparing drafts while checking M2: the capi's status (smlib_shim.h:82) answers
SM_ERR_OFFSET_EDGE_VANISHES (1043) as SMLIB_ERR_UNSUPPORTED; the port passed on Status(1043).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 23:15:40 -07:00
brett19andClaude Opus 5.5 651a9fd247 Pin solidcore at main 42aab6a6d
Compiles with the next commits (the develop merge's Split Body by a sheet is not routed yet, and the new flags are not listed yet).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 23:15:35 -07:00
brett19andClaude Opus 5.5 a08afa5a8b smlib: a draft that moved no face is NoEffect on solidcore too
Port the capi's moved_faces (smlib_ops.cpp:156-165, :1078), its mark on the picked
faces as solidcore#1875/#1877 lay out, since a surface has no identity apart from
its owning face. The reason it was skipped (solidcore#1462) was stale. No draft
found reaches SMLIB_ERR_NO_EFFECT on C++, so the parity test holds the same answer,
volume and counts over the nearest cases, and a unit test holds the reading.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 23:14:56 -07:00