Solidcore known-failing lists at pin 9dde25e97; ladder gate stays on the C++ kernel

KNOWN_FAILING.solidcore lists the 24 cases that fail on the default kernel, 23 of them also on SMLib's
list. The ladder golden is the C++ kernel's and solidcore differs on one case, so that gate opts in.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
This commit is contained in:
brett19andClaude Opus 5.5 committed 2026-10-31 03:36:07 -07:00
1 parent ad6fd72bcf
commit 130aaa38c0
24 files changed
+100 -10

No files matched your search

+2 -2
View File
@@ -1,7 +1,7 @@
# The fillet rig as a regression gate: a pull request that touches fillet code (the paths below)
# runs every case in tests/kernel-cases/fillets/ on SMLib, through one release build of
# runs every case in tests/kernel-cases/fillets/ on solidcore, through one release build of
# solidcraft-cli, and fails on a regression (a case that fails and
# tests/kernel-cases/fillets/KNOWN_FAILING does not list) or on a listed case that now passes
# tests/kernel-cases/fillets/KNOWN_FAILING.solidcore does not list) or on a listed case that now passes
# (it is fixed: remove its line, so the list only shrinks). See tests/kernel-cases/README.md.
#
# GitHub filters a workflow by whole files, so the fillet parts of crates/doc/src/eval*.rs and
+6 -4
View File
@@ -7,8 +7,8 @@
# matrix of shards as an artifact, one per selected area plus the ladder, in parallel, so the
# wall time is the build plus the slowest shard. See tests/kernel-cases/README.md.
#
# - An area fails on a regression (a case that fails and its tests/kernel-cases/<area>/KNOWN_FAILING
# does not list) or on a listed case that passes (it is fixed: remove its line in the same pull
# - An area, on solidcore, fails on a regression (a case that fails and its
# tests/kernel-cases/<area>/KNOWN_FAILING.solidcore does not list) or on a listed case that passes (it is fixed: remove its line in the same pull
# request, so the list only shrinks).
# - The ladder fails on any case whose status or counts differ from
# tests/kernel-cases/ladder/golden.json; a right change is re-recorded (`--record "why"`).
@@ -199,7 +199,9 @@ jobs:
SHARD: ${{ matrix.shard }}
run: |
if [ "$SHARD" = ladder ]; then
set -- --ladder --gate
# The golden is the C++ kernel's: solidcore differs on one case (shell under mitred
# rounds), so this shard stays on it until a solidcore golden is justified.
set -- --ladder --gate --kernel smlib
else
set -- --area "$SHARD" --known-failing "tests/kernel-cases/$SHARD/KNOWN_FAILING.solidcore"
fi
@@ -209,7 +211,7 @@ jobs:
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
with:
name: kernel-rig-results-${{ matrix.shard }}
path: ${{ runner.temp }}/kernel-rig/results.json
path: ${{ runner.temp }}/kernel-rig/**/results.json
if-no-files-found: ignore
# One check for the whole gate, for branch protection and the merge queue.
+4
View File
@@ -869,6 +869,8 @@ fn edges_871() -> Vec<[f64; 3]> {
/// overlap, which is refused. With SMLib built, the C++ kernel gives the same.
#[test]
fn rounds_on_the_871_part() {
#[cfg(feature = "native")]
let _cpp = crate::route::on_cpp();
let p = part_871();
let e = edges_871();
let sizes = |r: f64| vec![r; e.len()];
@@ -911,6 +913,8 @@ fn rounds_on_the_871_part() {
/// by Green's theorem). With SMLib built, the C++ kernel gives the same.
#[test]
fn tabbed_plate_rounds_mitred_on_the_arcs_continuation() {
#[cfg(feature = "native")]
let _cpp = crate::route::on_cpp();
use super::sweep::extrude;
use crate::sweeps::{Curve, DraftCorner};
const Z: [f64; 3] = [0.0, 0.0, 1.0];
+2
View File
@@ -853,6 +853,8 @@ fn offset_faces_close_a_step_wall() {
/// whose rounds go all the way down at -7. With SMLib built, the C++ kernel gives the same.
#[test]
fn mitred_rounds_follow_a_moved_top() {
#[cfg(feature = "native")]
let _cpp = crate::route::on_cpp();
use super::blend::{Corners, blend};
use crate::Blend;
let edges = [[20.0, 0.0, 10.0], [20.0, 30.0, 10.0], [0.0, 15.0, 10.0], [40.0, 15.0, 10.0]];
+7 -3
View File
@@ -232,11 +232,15 @@ running part grows one tier at a time through `base`), so the last case carries
`method` gives the derivation).
```sh
cargo xtask kernel-cases --ladder --cli target/release/solidcraft-cli
cargo xtask kernel-cases --ladder --cli target/release/solidcraft-cli --gate
cargo xtask kernel-cases --ladder --cli target/release/solidcraft-cli --record "why"
cargo xtask kernel-cases --ladder --kernel smlib --cli target/release/solidcraft-cli
cargo xtask kernel-cases --ladder --kernel smlib --cli target/release/solidcraft-cli --gate
cargo xtask kernel-cases --ladder --kernel smlib --cli target/release/solidcraft-cli --record "why"
```
The golden is the C++ kernel's, so these say `--kernel smlib`. Without it a run is on solidcore and is
graded against the same golden; today that differs on one case,
`ladder/09-shells-and-offsets/010-shell-under-rounded-top`.
The ladder needs no known-failing list: the golden is the reference. Its shard in the kernel rig
gate runs with `--gate`, which fails on any case whose status or counts differ from the golden,
better or worse, and on a case with no golden; times are not compared there (they are the
@@ -0,0 +1,3 @@
# The assemblies cases that fail today on solidcore, one a line: `<case> <why it fails today>`. Sorted.
# The kernel rig gate fails on a case that fails and is not listed, and on a listed case that passes.
# Baseline: solidcore pin 9dde25e97, tests/kernel-cases run by `cargo xtask kernel-cases`, x86_64 Linux.
@@ -0,0 +1,4 @@
# The booleans cases that fail today on solidcore, one a line: `<case> <why it fails today>`. Sorted.
# The kernel rig gate fails on a case that fails and is not listed, and on a listed case that passes.
# Baseline: solidcore pin 9dde25e97, tests/kernel-cases run by `cargo xtask kernel-cases`, x86_64 Linux.
3604-cut-with-g2-swept-tool-along-projected-edge [fail] step 12 (solid.sweep): the path curves are not connected end to end
@@ -0,0 +1,3 @@
# The construction cases that fail today on solidcore, one a line: `<case> <why it fails today>`. Sorted.
# The kernel rig gate fails on a case that fails and is not listed, and on a listed case that passes.
# Baseline: solidcore pin 9dde25e97, tests/kernel-cases run by `cargo xtask kernel-cases`, x86_64 Linux.
@@ -0,0 +1,3 @@
# The continuity cases that fail today on solidcore, one a line: `<case> <why it fails today>`. Sorted.
# The kernel rig gate fails on a case that fails and is not listed, and on a listed case that passes.
# Baseline: solidcore pin 9dde25e97, tests/kernel-cases run by `cargo xtask kernel-cases`, x86_64 Linux.
@@ -0,0 +1,3 @@
# The crashes cases that fail today on solidcore, one a line: `<case> <why it fails today>`. Sorted.
# The kernel rig gate fails on a case that fails and is not listed, and on a listed case that passes.
# Baseline: solidcore pin 9dde25e97, tests/kernel-cases run by `cargo xtask kernel-cases`, x86_64 Linux.
@@ -0,0 +1,17 @@
# The fillets cases that fail today on solidcore, one a line: `<case> <why it fails today>`. Sorted.
# The kernel rig gate fails on a case that fails and is not listed, and on a listed case that passes.
# Baseline: solidcore pin 9dde25e97, tests/kernel-cases run by `cargo xtask kernel-cases`, x86_64 Linux.
1207-fillet-bar-top-edge-after-boss-arc-round-r0-5 [fail] step 4 (solid.fillet): body `Arm`: the operation failed: SMLib fillet: SMLib's check refuses the result: 5 failed tests: SmBSplineCurve::Test #15 Bad Repeated CPts: BSplineCurve has Internal Coincident ControlPoints (causes
190-fillet-disc-rim-past-its-2mm-wall [fail] step 2 (solid.fillet): SMLib fillet: operation: SMLib failed (status 1001)
2893-chamfer-distance-and-angle-past-the-wall-refused [fail] refused, but not because "angle": step 2 (solid.chamfer): SMLib chamfer: operation: SMLib rejected the input (SM_ERR_INVALID_INPUT)
2893-chamfer-two-distances-elliptical-rim [fail] refused, but not because "not supported yet": step 3 (solid.chamfer): SMLib chamfer: operation: SMLib failed (status 1001) (tangent propagation blended the picked edges' tangent chain with them; with it off, tangent_chain:
2893-chamfer-two-distances-past-the-bottom [fail] step 2 (solid.chamfer): SMLib chamfer: operation: SMLib failed (status 1001)
4782-fillet-bar-edge-wider-than-both-faces [fail] continuity_order: got Box: no null seams want >= g1 at every blend seam
5158-fillet-round-just-past-a-10mm-face [unsupported] step 2 (solid.fillet): not supported yet: the fillet is larger than the faces beside its edges allow; the largest radius that fits is 10 mm
9-fillet-corner-curvature-with-reduce-fit [unsupported] solid.fillet builds `corner: g2` with `fit: exact` only
9-fillet-corner-curvature-with-taper-fit [unsupported] solid.fillet builds `corner: g2` with `fit: exact` only
cov-chamfer-concave-edge-through-up-down-joined-squares [fail] step 9 (solid.chamfer): SMLib chamfer: operation: SMLib failed (status 1001) (tangent propagation blended the picked edges' tangent chain with them; with it off, tangent_chain: false, only the picked edges are blended)
cov-chamfer-outer-corner-edge-of-a-shelled-box-with-a-lip [fail] step 5 (solid.chamfer): SMLib chamfer: operation: SMLib's result is not a closed solid
cov-fillet-arc-edge-on-an-oblique-cut-of-a-bar [fail] step 11 (solid.fillet): body `Tool`: the operation failed: SMLib fillet: SMLib's check refuses the result: 4 failed tests: SmBSplineCurve::Test #15 Bad Repeated CPts: BSplineCurve has Internal Coincident ControlPoints (caus
every-block-cylinder-crease-top-edge-after-arc-round-r1 [fail] step 4 (solid.fillet): SMLib fillet: operation: SMLib failed (status 1001) (tangent propagation blended the picked edges' tangent chain with them; with it off, tangent_chain: false, only the picked edges are blended)
every-hole-top-rim-r12-past-plate-bottom [fail] step 3 (solid.fillet): SMLib fillet: operation: SMLib failed (status 1001)
@@ -0,0 +1,3 @@
# The frames cases that fail today on solidcore, one a line: `<case> <why it fails today>`. Sorted.
# The kernel rig gate fails on a case that fails and is not listed, and on a listed case that passes.
# Baseline: solidcore pin 9dde25e97, tests/kernel-cases run by `cargo xtask kernel-cases`, x86_64 Linux.
@@ -0,0 +1,3 @@
# The history cases that fail today on solidcore, one a line: `<case> <why it fails today>`. Sorted.
# The kernel rig gate fails on a case that fails and is not listed, and on a listed case that passes.
# Baseline: solidcore pin 9dde25e97, tests/kernel-cases run by `cargo xtask kernel-cases`, x86_64 Linux.
@@ -0,0 +1,3 @@
# The import cases that fail today on solidcore, one a line: `<case> <why it fails today>`. Sorted.
# The kernel rig gate fails on a case that fails and is not listed, and on a listed case that passes.
# Baseline: solidcore pin 9dde25e97, tests/kernel-cases run by `cargo xtask kernel-cases`, x86_64 Linux.
@@ -0,0 +1,3 @@
# The inspect cases that fail today on solidcore, one a line: `<case> <why it fails today>`. Sorted.
# The kernel rig gate fails on a case that fails and is not listed, and on a listed case that passes.
# Baseline: solidcore pin 9dde25e97, tests/kernel-cases run by `cargo xtask kernel-cases`, x86_64 Linux.
@@ -0,0 +1,3 @@
# The plastic cases that fail today on solidcore, one a line: `<case> <why it fails today>`. Sorted.
# The kernel rig gate fails on a case that fails and is not listed, and on a listed case that passes.
# Baseline: solidcore pin 9dde25e97, tests/kernel-cases run by `cargo xtask kernel-cases`, x86_64 Linux.
@@ -0,0 +1,3 @@
# The sheet-metal cases that fail today on solidcore, one a line: `<case> <why it fails today>`. Sorted.
# The kernel rig gate fails on a case that fails and is not listed, and on a listed case that passes.
# Baseline: solidcore pin 9dde25e97, tests/kernel-cases run by `cargo xtask kernel-cases`, x86_64 Linux.
@@ -0,0 +1,11 @@
# The shell cases that fail today on solidcore, one a line: `<case> <why it fails today>`. Sorted.
# The kernel rig gate fails on a case that fails and is not listed, and on a listed case that passes.
# Baseline: solidcore pin 9dde25e97, tests/kernel-cases run by `cargo xtask kernel-cases`, x86_64 Linux.
316-shell-open-beside-a-bottom-round-r2-4-as-large-as-the-wall-refused [fail] succeeded where the case expects a refusal
316-shell-open-beside-a-bottom-round-r2-as-large-as-the-wall-refused [fail] succeeded where the case expects a refusal
545-shell-ring-cut-frame-open-at-an-outer-wall [fail] step 14 (solid.shell): SMLib shell: operation: SMLib failed (status 1001)
616-shell-open-a-rib-side-face-of-a-lid [fail] step 11 (solid.shell): SMLib shell: operation: SMLib failed (status 1001)
cov-shell-again-open-at-an-inner-wall-of-a-shelled-box [fail] step 9 (solid.shell): SMLib shell: operation: SMLib failed (status 1001)
cov-shell-pocket-whose-floor-falls-to-a-drain [fail] step 14 (solid.shell): SMLib shell: operation: SMLib failed (status 1001)
cov-shell-trough-whose-floor-falls-to-a-drain [fail] step 13 (solid.shell): SMLib shell: operation: SMLib failed (status 1001)
cov-shell-up-down-joined-squares-open-at-a-side-wall [fail] step 9 (solid.shell): SMLib shell: operation: SMLib failed (status 1001)
@@ -0,0 +1,3 @@
# The solids cases that fail today on solidcore, one a line: `<case> <why it fails today>`. Sorted.
# The kernel rig gate fails on a case that fails and is not listed, and on a listed case that passes.
# Baseline: solidcore pin 9dde25e97, tests/kernel-cases run by `cargo xtask kernel-cases`, x86_64 Linux.
@@ -0,0 +1,3 @@
# The surfaces cases that fail today on solidcore, one a line: `<case> <why it fails today>`. Sorted.
# The kernel rig gate fails on a case that fails and is not listed, and on a listed case that passes.
# Baseline: solidcore pin 9dde25e97, tests/kernel-cases run by `cargo xtask kernel-cases`, x86_64 Linux.
@@ -0,0 +1,4 @@
# The sweeps cases that fail today on solidcore, one a line: `<case> <why it fails today>`. Sorted.
# The kernel rig gate fails on a case that fails and is not listed, and on a listed case that passes.
# Baseline: solidcore pin 9dde25e97, tests/kernel-cases run by `cargo xtask kernel-cases`, x86_64 Linux.
4305-sweep-cut-groove-round-rounded-pocket-wall [fail] step 19 (solid.sweep): body `Box`: the operation failed: SMLib boolean: SMLib's check refuses the result: 8 failed tests: SmBrep::Test #3 Bad Gap: Vertex/Face gap across Edgeuse end larger than tol (offset=5.1386526e-06, to
@@ -0,0 +1,3 @@
# The tessellation cases that fail today on solidcore, one a line: `<case> <why it fails today>`. Sorted.
# The kernel rig gate fails on a case that fails and is not listed, and on a listed case that passes.
# Baseline: solidcore pin 9dde25e97, tests/kernel-cases run by `cargo xtask kernel-cases`, x86_64 Linux.
@@ -0,0 +1,3 @@
# The threads cases that fail today on solidcore, one a line: `<case> <why it fails today>`. Sorted.
# The kernel rig gate fails on a case that fails and is not listed, and on a listed case that passes.
# Baseline: solidcore pin 9dde25e97, tests/kernel-cases run by `cargo xtask kernel-cases`, x86_64 Linux.
+1 -1
View File
@@ -3,7 +3,7 @@
//! `tests/kernel-cases/ladder/ladder.json` lists tiers in order of complexity and, per tier, its
//! cases in order (paths under `tests/kernel-cases/`, so a tier may also list rig cases from other
//! areas). Each case is a test like any rig case, graded against its own `expected.json`, on
//! SMLib. On top, `tests/kernel-cases/ladder/golden.json` records per case the status, the
//! `--kernel`'s one backend. The golden is SMLib's, so a gate or a record says `--kernel smlib`. On top, `tests/kernel-cases/ladder/golden.json` records per case the status, the
//! commands' time and what was made (counts, volume, area): the run compares with it and flags
//! slowdowns and changes; cases run one at a time unless `--jobs` says otherwise, so the times are
//! not shared with other cases. `--record REASON` re-measures the golden and re-sorts each tier