Commit Graph
3740 Commits
Author SHA1 Message Date
Brett Lawson 512cf5bd48 Merge develop f1199f89 into solidcore 2026-10-30 18:47:47 +01:00
Brett LawsonandClaude Opus 5.5 63864b2984 smlib: solidcore's five new fork-carried opt-ins are on; the trim end-span opt-in waits
fillet_chamfer_cone_stored_as_cone (WR-572, smlib@b5743ec), offset_point_vertex_caps (WR-531,
smlib@d5dadaa), approximate_surface_bezier_starter (WR-573, smlib@eae96cb),
proto_edge_splits_at_captured_vertices (WR-579, smlib@9eec159) and stitch_solid_nests_cavities
(WR-569, smlib@351c57c) are on: their fork commits are in SMLIB_REV 985faaee.
bspline_trim_keeps_rational_end_spans (WR-575, solidcore#1711) has no fork commit, so it goes on
HELD_BACK.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 18:19:03 +01:00
Brett LawsonandClaude Opus 5.5 9c1f8904e0 solidcore: move the pin to 43ed10e54 (main, with solidcore#1650, fixing #1631)
Merged since 3569b5d73:
- #1650 one owner identity for binders and check_brep, so operations on caller-keyed copies
  check valid (fixes #1631: "the body names its geometry owners by its maker's keys")
- #1739 local_operation refreshes cached topology before returning
- #1749 opt-in proto edge splits at captured vertex definitions (WR-579, #1517)
- #1768 opt-in stitched solid nests its cavities (WR-569)
- #1609 opt-in extended offset caps a cone's apex with a sphere (WR-531)
- #1712 opt-in ApproximateSurface Bezier starter (WR-573, #1501)
- #1711 opt-in trim keeps a conic's short end span (WR-575, #1529; no fork commit yet)
- #1709 opt-in chamfer round an arc stored as a cone (WR-572, #1503)
- #1000 port of topology.brep_constructor
- #1530 release solidcore 1.0.1 (the crate's version is now 1.0.1)
- tests: #1746, #1735, #1710, #1748, #1757, #1762, #1754
- difftests: #1761, #1733, #1764, #1715, #1732, #1744, #1726, #1740, #1742, #1743, #1741,
  #1737, #1731, #1728, #1725, #1721, #1724, #1720, #1718, #1717, #1716, #1699, #1704, #1696,
  #1697
- chores and plans: #1734, #1772, #1774

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 18:17:38 +01:00
jyvikoandClaude Opus 5.5 f1199f89bc Joint drive: contact is decided on the exact bodies, not their display meshes
A joint drive with contact on tested each sample and each of 14 bisection
steps with a brute-force mesh-against-mesh overlap check, its cost the product
of the two display meshes' triangle counts under a fixed budget. Since the
display mesh puts nodes inside planar faces, a cam and its tappet or a block and
a sphere exceed that budget ("motion exceeds contact sweep collision budget"),
and whether a motion may run depended on display tessellation.

Now, at each sample, bodies whose exact boxes meet are intersected exactly
(SMLib boolean, exact volume); a shared volume is a contact, a touch (a cam and
its follower) is none. Between the last clear sample and the first overlapping
one the drive closes in by conservative advancement: from a clear placement it
moves no point of the pair further than the pair's exact gap (body_distance),
until the gap is within 1e-9 of the bodies' size. Only clear placements are
measured, so no intersection is asked to tell touching from overlapping within
its tolerance (SMLib's boolean fails there, status 1001, on two cubes 1e-4
into each other). The budget is 2048 intersections per drive.

Fixes cmd::joints::tests::cam::a_cam_drives_a_closed_loop_and_stops_at_a_contact
and contact_sweep ordinary_curved_bodies_stop_at_their_contact_within_the_sampling_budget,
and the other contact, cam, motion, interference and clearance tests pass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 13:11:11 -04:00
jyvikoandClaude Opus 5.5 b4af45dd07 Kernel rig: the horn torus and the circle revolved touching its axis build
SMLib's revolve now splits a curve where it touches the axis inside itself
(tangency-labs/smlib#66), so both cases come off their known-failing lists.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvoxKQ2rEZvcXNQnhE3Sgs
2026-10-30 12:14:18 -04:00
jyvikoandClaude Opus 5.5 7fe880a7bf SMLib: pin f8fd83e (tangency-labs/smlib#66)
The batch brings history Kept for a face only cut by a vertex, revolve of a
curve touching its axis, loops touching at a vertex, a torus rail on its axis,
and the fillet causes behind the owner's bar running into a cylinder: a
tangent edge past a tangent side edge is the corner's edge, the rails of a
round collapsing at its end end at one point, and a trace from a tangent point
starts along the curve.

The two peg cases with the sketch's solver residues come off the fillets
known-failing list: both build.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvoxKQ2rEZvcXNQnhE3Sgs
2026-10-30 12:14:18 -04:00
jyvikoandClaude Opus 5.5 12496c2c1d Tests: a round flange stays an exact circle through unfold, refold and DXF, with a cut near its rim
The test it replaces probed for a polyline by placing a 0.2 um square in the
gap between the rim and a 1 um polyline: a micro feature in a millimetre part.
This one asserts the property itself, in millimetres: every rim segment of the
flat pattern is an arc of radius 10, the DXF draws one circle of radius 10, and
a 1 mm cut 0.5 mm inside the rim stays one hole.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 12:05:28 -04:00
Brett Lawson a0dfdeecaf Merge develop 7c9e5ec6 into solidcore 2026-10-30 16:47:18 +01:00
Brett LawsonandClaude Opus 5.5 cd25e9e8f2 smlib: a face section on solidcore cuts planes, cylinders, cones and spheres too (solidcore#1769)
The port asks CreatePlanarSectionCurves for UV curves, so it now forces the UV classify: an
analytic face's intersector makes no UV curve, and without the flag the trim dropped the whole
section and the call answered Empty. SmBrep.h documents the flag for exactly this case. The
capi still leaves it FALSE, so the C++ kernel keeps answering Empty on analytic faces; the
parity test now holds the port to the section there and to the C++ curves on the loft.

a_cylinder_side_section_is_its_circle is un-ignored; a_box_top_section_is_the_line_across_it
checks the line (5,0,10)-(5,10,10) across a 10 mm box's top.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 16:25:29 +01:00
jyvikoandClaude Opus 5.5 7c9e5ec696 kernel: a seam held as two edges is one join, drawn whole in the shaded view
A G2 corner patch's side is G2 to its round except near the face it ends
on, and SMLib holds each side as two edges. The smooth-join test judged
each edge alone, so the G2 half was hidden and the line stopped at the
vertex in the middle of the seam. Edges between the same faces that
continue each other at a shared vertex now share one verdict: smooth only
where every one of them is.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 10:37:53 -04:00
Brett LawsonandClaude Opus 5.5 c3f5bb40b9 smlib: a draft on solidcore keeps the body's tags and face history
solidcore's local operation carries the B-rep's attributes since 1ee3a930c, which the pin
3569b5d73 holds, so history::tags_cross_a_draft runs again and matches the C++ draft. The draft's
body is no longer marked untracked: Brep::made_core_draft goes and ops::draft answers with
Brep::made_core, so a draft's history is read as every other solidcore operation's is.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 15:09:53 +01:00
Brett LawsonandClaude Opus 5.5 cf2a15ace8 smlib: solidcore's four fork-carried opt-ins are on; only the trim base v opt-in waits
fillet_torus_span_from_start_section (WR-568, smlib@985faae), fillet_knife_edge_rounds (WR-570,
smlib@b7ec55b), taper_wall_closes_at_apex (WR-571, smlib@183ea65) and
revolution_round_offset_collapses (WR-567, smlib@8b2090f) are on: their fork commits are in
SMLIB_REV 985faaee. HELD_BACK keeps only precise_properties_trim_base_v, which has no fork commit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 14:56:39 +01:00
Brett Lawson b60963b12c smlib: SolidCraft's tags and face history run on solidcore (port of the capi's smlib_history) 2026-10-30 14:56:23 +01:00
Brett Lawson d8a680915e Merge develop e46359ff into solidcore 2026-10-30 14:56:17 +01:00
Brett LawsonandClaude Opus 5.5 10c7d3afd3 smlib: tags and history on solidcore: smlib_history.cpp ported onto the Brep's attribute store
core/history.rs ports smlib_history_tag and smlib_history_read onto solidcore's
B-rep-owned AttributeStore. Each origin is an attribute of its own (its id names
the origin), so SMLib's default Split/Merge/Copy/Coincident handlers, which add
an attribute unless the object has one of its id, give the union the capi's Tag
handlers make. A face's origin carries its boundary edges then, an edge's the
points it ran through, and the read classifies Kept/Modified/Split/Merged/
Generated as the capi does.

Brep remembers the kernel that made it (history is read there; the flat arrays
carry no tags) and, for a tagged body, its operand, so the body converted for
the other kernel is tagged the same way. Blends (solidcore#1594) and drafts,
which do not carry attributes yet on solidcore, give "not supported yet" for
their history instead of an untagged one.

tags_cross_a_solidcore_boolean now passes. Parity tests against the C++ kernel:
union, subtraction, intersection, side-by-side union (merged faces), imprint,
copy and shell agree; fillet (solidcore#1594), face offset (solidcore#1060) and
draft are ignored with the reason.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 14:51:22 +01:00
Brett Lawson 76cdc727e9 Merge develop e46359ff into solidcore 2026-10-30 14:47:33 +01:00
jyvikoandClaude Opus 5.5 e46359ff04 Kernel rig: the patch cases the fill now builds come off the known-failing lists
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 09:17:35 -04:00
jyvikoandClaude Opus 5.5 25e275722d Tests: a patch's continuity g3 is valid, g5 is the hostile word
patch_continuity_and_points_cap_a_tube listed "g3" among the values surface.patch must refuse,
from #1521 when a patch built G0 to G2. Since cb8712aa0 Construction::Patch builds G0 to G4
(continuity_order.rs: `Construction::Patch => (G0, G4)`), so g3 is accepted, as it must be;
the order above what a patch builds is g5.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 09:17:35 -04:00
jyvikoandClaude Opus 5.5 c088cf43ed geom: the patches about a centre are solved the same to the last bit on every run
The block solve kept its sparse entries in hashed maps and summed the coupling of each patch's
interior onto the shared unknowns in the map's order, which a hashed map draws afresh each
time: the same loop filled to surfaces differing in their last bits, so a design read back
rebuilt another cap (engine patch_continuity_and_points_cap_a_tube, "the same surface read
back"). The entries are now in ordered maps; a fill twice of the tube's ring and of a hexagon
about a centre are bit for bit the same.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 09:17:35 -04:00
jyvikoandClaude Opus 5.5 f7409dd59f geom, kernel: a loop with fewer than three corners is filled by a ring of patches
A tube's end has no corner at all; the kernel gives its circle in four quarters, and one patch
on them has a corner on each quarter joint where the loop runs straight on: flat, its two
derivatives parallel, which SMLib's check refuses (Bad Surf FlatCorner within 0.5°). Any
layout with a patch corner on such a loop has one.

Such a loop is now the ring of structured meshing (an O-grid): four patches each on one side of
the loop, two meeting at every point of it, about one inner patch (Quilt::ring). The spokes are
now any curve two patches share (Seam), each glued G1 with linear gluing functions: at an inner
vertex of valence m the characteristic value ±2cos(2π/m) (the centre's spokes as before, the
ring's inner corners with m = 3), at the loop what its two sides' derivatives there ask
(foot_gluing; 0 and their speeds' ratio where the loop runs straight on). IsoFill says where each
spoke starts and ends (SpokeEnd) and holds the inner vertices; the kernel builds them so.

The tube end caps G1 (normal within 0.0157° of the wall, sealed 10458.232 against the tube and
dome's 10458.232) and G2 (curvature across 4.6e-5 /mm against G1's 0.30), five faces with no flat
corner. A crown on the ring lifts the inner patch whole (the ring rises as v(2 − v)).

Saved designs: a general patch on a smooth closed loop (a tube's end) rebuilds as five faces
where it was one (which SMLib refused).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 09:17:35 -04:00
jyvikoandClaude Opus 5.5 d5941c0d06 geom: a general fill's crown fills out to the side its neighbours' normals face
The crown moved the free points along the patch's own normal, whose sign is only the way the
patch happens to be parameterised: the pentagonal window's crown 0.1 sank 1.56 mm into the
cylinder (the middle 9.959 from the axis plain, 8.395 crowned) where the kernel documents it
filling out to the side the G1/G2 neighbours' normals face. The crown now takes that side: the
sum of the patch's normals against the neighbours' over the stations sets one sign for the fill.
The pentagon's middle goes out to 11.526.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 09:17:35 -04:00
jyvikoandClaude Opus 5.5 30b12cea8c geom: a crowned height field rises by the whole crown at its box's middle
The crown's bump went onto the first net with any control point clear of the loop; a coarse
net could leave points supporting the box's middle without it, so the middle rose by only a
share of crown · size (the pentagonal cup: 7.6558 of 13.3877). The net is now refined (knot
insertion, the surface unchanged) until every point whose basis is not zero at the middle takes
the bump, where the middle is inside the loop: the bubble is then exactly 1 there, as fill_loop
documents.

The kernel test measured against the face's domain, which SMLib holds as the loop's extent; the
documented box is the height field's whole domain, the loop's box and 1% more each way (as the
engine's crown test says, 28 × 28 + 1%). Its diagonal is 1.02 times the face's, so the
documented rise is 0.25 × 53.5506 = 13.387661 = 1.02 × 13.125158, which the patch now meets to
1e-6 for crowns ±0.25.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 09:17:35 -04:00
jyvikoandClaude Opus 5.5 62d41a0cfa Tests: the fill tests evaluate a face's (u, v) on its NURBS form
A face's domain and pcurves are on Face::parameters() (its NURBS form when it has one, the
record's documented contract); the general fill tests' quadrature and the pick-order and crown
comparisons evaluated Face::surface instead. A fill SMLib recognises as an analytic surface (the
240° window's G0 patch is the cylinder itself) then read its arc-length domain as angles: the
quadrature came out 4188.79 for the window's 418.879 (10 × 41.888 of angle against 4.189).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 09:17:35 -04:00
jyvikoandClaude Opus 5.5 55cb6b32b0 geom, kernel: the patch fill's sides run from corner to corner, not edge to edge
A vertex where the loop runs straight on (SMLib's seams: a cylinder's at 35.12° splits a half
circle into two arcs) was a corner of the fill's region, so a patch had a 180° corner there:
flat (its two derivatives parallel), degenerate, and refused by SMLib's check (Bad Surf
FlatCorner, within 0.5°). Half a post's side, six edges on four corners, was six patches about
a centre and folded.

The region's corners are now the vertices where the loop turns by more than the kernel's corner
test (1°, IsoSpec::corner_turn); a side is the chain of edges between two corners, held as one
exact B-spline (each edge carried exactly to the side's degree on its stretch, joined at a knot
of full multiplicity, which the knot-line rows keep tangent across). Each edge's pcurve is still
a straight line, now on its stretch of a patch's side; a spoke says where on the loop it starts
(IsoFill::feet). A loop with fewer than three corners keeps its edges as sides.

The half post is one face again (a_loop_that_does_not_bound_a_height_field_fills_with_one_face),
the 240° window is one patch, the exact cylinder (area 418.879), and the torus window fills G0
and G1.

Saved designs: a general patch on a loop with seam vertices rebuilds with fewer faces (the half
post's 6 become 1), its corners where the loop's are.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 09:17:35 -04:00
jyvikoandClaude Opus 5.5 49377d318c geom: patches about a fill's centre join G1 there, with the linear gluing function
Across each spoke the two patches' derivatives away from it were held opposed (parametric C1).
At the centre that asks the spokes' tangents d_{k-1} + d_{k+1} = 0, which for N other than a
multiple of four only d = 0 meets: every patch got a flat, singular corner at the centre (a
pentagon on a wavy rim: derivatives of 3.3e-5 there; the hexagonal rim's control net doubled
back and SMLib's check refused it as NonMonotonic).

The join is now G1 with the linear gluing function of Loop, Peters and Hahn:
d/du S_k + d/dv S_{k+1} = alpha(t) d/dt S along the spoke, alpha(t) = 2 cos(2 pi / N) t. At the
midpoint alpha is 0 (the edge's two halves leave it at the same speed, opposed); at the centre
it is the value any affine image of the regular N-star meets, d_{k-1} + d_{k+1} = 2 cos(2 pi/N)
d_k. N = 4 is the old row. The pentagon's centre corners now open 72° with derivatives of 16.2
(N = 5 to 8: 360°/N each).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 09:17:35 -04:00
jyvikoandClaude Opus 5.5 013978724e geom: the patch fill's cross-boundary targets agree with its corners
A tensor patch's cross derivative along a side is, at a corner, the tangent of the side it
meets there (the two share the corner's next control point): the compatibility condition of
Coons and Gregory interpolation. The weak rows asked t·c′ = 0 and w·c′ = s right up to every
corner, which no patch can meet where the next side is not square to the edge; at a smooth
vertex (a tube's end in four quarter arcs) the next side runs along the edge itself. The least
squares spread the contradiction into the first spans and folded them: the tube end's worst
normal went 13.8°, 17.9°, 89.8° (folded), 85.6°, ... 25.1° (folded) with refinement, and the
symmetric loop came back asymmetric.

The target is now the Coons start's own cross derivative, compatible at every corner by
construction, turned about the edge into the neighbour's tangent plane (its part along the
edge kept, the rest laid along the leave direction at its length). The tube end converges
21°, 3.8°, 0.76°, 0.18°, 0.045°, symmetric, and does not fold.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 09:17:35 -04:00
jyvikoandClaude Opus 5.5 9243b6550d SMLib history: a split line between two pieces of one face comes from nothing
An edge SMLib reports as new was given the origin "where its two faces meet", each side what
that face came from. A split line lies between two pieces of one face, so both sides are that
face and the edge read EdgeOrigin::Meet { top, top }: a face meeting itself, which no two faces
did. Such an edge now has no origin, as the history's EdgeProv documents for a new edge between
faces new to the operation (the doc now names the split line too).

New test: a_split_line_comes_from_nothing (one face split in two, its new edge has no origin).
modify_history_tests::split_a_face checks this at its last line; it still fails earlier, on its
counts ([3, 2, 2, 0, 0] for [5, 0, 2, 0, 0]) on develop's SMLib pin, until SMLib batch 3's
history fix (03bbc88) is pinned.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 09:14:44 -04:00
jyvikoandClaude Opus 5.5 738f336e12 Raytrace: a closed box dielectric is certified from its mesh's geometry, in any tiling
The closed-box certificate took exactly twelve triangles, two a face. The one mesher puts
interior points on planar faces (a 20 x 20 x 2 box comes in more than twelve), so
render.preflight refused a box as "unsupported dielectric boundary tessellation"; a box is a
box however its faces are triangulated.

The certificate now reads the mesh's geometry exactly: every triangle in the plane of one of
the faces of the box its points span (corners on it, normal exactly that axis) facing out,
and the triangles a closed, consistently oriented surface (each edge, by its ends' exact
coordinates, run once each way). Such a surface is a 2-cycle on the box's boundary, a sphere,
so it covers every point of it the same k >= 1 times, and its area is k times the boundary's:
k = 1 is decided by the area being under 1.5 times the boundary's. Up to 65536 triangles. A
thin sheet is still one or two triangles; a general closed mesh is still refused.

New test: a box with its top fanned from a point in it is certified, with the same bounds;
the point 1e-9 off the plane, or the top covered twice, is refused.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 09:14:44 -04:00
jyvikoandClaude Opus 5.5 5732b62ec3 Tapered extrude: the end check of a profile with holes takes the section a swallowed line leaves
A tapered extrusion of a region with holes checks, at its two ends, that each hole's section
stays inside the outer loop's and clear of the others. Those sections were made with the
start section's rule, which refuses a line the offset swallows ("draft extrusion that starts
before its profile where the taper closes a side"). At the far end such a line is ordinary: a
short line between two concave corners whose wall closes on the way up. The letter g of
"tres long" (8 mm, joined 2 mm with a 3 degree taper) has one, and the whole text was refused
with a message about the start that does not apply.

The end check now takes the section as it is there (offset_loop's swallowed lines left out, their
neighbours meeting where they were); whether the closing wall is built stays the draft's to
say. The g builds at 3 and 15 degrees.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 09:14:44 -04:00
jyvikoandClaude Opus 5.5 cf40a3e6c6 Boolean regression test: the raked wedge's R4 rounds the four edges the issue picked
raked_wedge (#1617, test from 7f2ae11a0 on 2026-10-17) rounds four end edges R4. Since
84bd2daad (2026-10-22) solid.fillet carries each picked edge round its tangent chain by
default, so the R4 now ran on round the end outline onto the R1.2 round's end arc, where the
round's rail on the end face would be an arc of radius 1.2 - 4 < 0, and it is refused as too
large. The issue's R4 rounds those four edges alone: the step says tangent_chain: false.

The test still fails, one step later, on SMLib: the issue's R0.854 round of both ends' outline
is refused by SMLib's own check (SmBSplineSurface Test #5, "close to singular at boundary"),
reported for the SMLib batch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 09:14:44 -04:00
jyvikoandClaude Opus 5.5 f2982b47a0 Sheet tests: the tiny cut inside the exact circle is above SMLib's modelling tolerance
tiny_cut_inside_exact_circle_survives_unfold_refold_and_dxf cut a 50 nm square 0.2 um inside
the disc's rim. SMLib models at a zone tolerance of 1e-4 mm: its check refuses the cut's 50 nm
walls as planes "degenerated to a point (tolerance=0.0001)", so the extrude was refused. A
feature below the kernel's resolution is not one it can keep, on any path.

The test's point is that the exact circle, not its display polyline, bounds the flat pattern:
a cut between the two must survive unfold, refold and the DXF. The polyline at 1e-3 has 224
chords (sagitta 10 (1 - cos(pi/224)) = 0.98 um), so the square is now 0.2 um across, centred
0.4 um inside the circle on the first chord's bisector: outside the polyline, inside the
circle, its walls and its 0.3 um gap to the rim above 0.1 um. Its hole's area is
(2e-4)^2 = 4e-8 (was 2.5e-9 for the 50 nm square).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 09:14:44 -04:00
jyvikoandClaude Opus 5.5 17a466e6b8 Ruled surface: a free strip on a straight edge gets a far curve that can bend
A strip's far curve, where its rulings turn along the edge, is a B-spline in the edge's own
spline space. A straight edge's space is one linear span, which holds only the chord between the
strip's corners: the rulings' ends (the closeness term) had no say, and the strip had no handles.
Off the patch over the cup's rim in a_strip_off_a_curved_face_is_ruled_to_its_far_curve the
normal along the straight rim at x = 14 turns by 5 degrees (x component -0.350 at the ends,
-0.262 at the middle; the patch's middle is at z 10.296, not the cylinder's 10), so the strip is
free and its rulings' ends lie up to 0.26 mm off that chord.

Such an edge is now taken as the cubic Bezier it also is (exact degree elevation: control points
at thirds, the same points at the same parameters) before the far curve is solved, so the far
curve has two interior control points: its handles. Exact strips on straight edges keep the line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 09:14:44 -04:00
jyvikoandClaude Opus 5.5 fb5ae6cdd2 SMLib import: an extruded circle's circle comes from its widest span, not the face's range
Since 6cc759750 an extruded circle is a cylinder over the face's trimmed range, and the circle was
fitted through three points of that range. On the shallow strip of the extruded-ellipse test
(radius 3000, 6 mm wide: 0.002 rad round) the three points are 2 mm apart and the fit is
ill-conditioned: the centre came 2.5e-10 mm off the circle's plane (the frame's x axis tilted
8.3e-14 out of it) and the radius 8.1e-9 mm short. SMLib took that cylinder, but on the way back
(the import's SMLib round trip, then Body::smlib) SmCylinder::IsNurbSurfaceCylinder did not find
a cylinder in SMLib's own NURBS of it, and the strip was refused as needing repair
(SM_ERR_INVALID_INPUT, AnalyticOfNurbs). Before 6cc759750 the fit ran over the record's domain,
1.4e-6 rad wider on each side, and happened to come out level.

The patch's trims were right all along: they straddle the profile's seam (u = 4, the knot
between the spline's two quarter spans) without wrapping, [3.9992930395761980, 4.0007069604238020],
which is the exact 0.001 rad either side of it.

The circle is now fixed by three points on the arc's widest knot span (a quarter turn here),
where it is determined to rounding, and checked as before at 65 points over the face's range.
A revolution's profile circle is fitted as before.

Regression test (smlib import tests): a 0.002 rad patch of an extruded circle of radius 3000
across that knot is the cylinder of radius 3000 to 1e-10 (it was 2.8e-10 short), its axis
along z to 1e-15, over exactly the patch's range.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 09:06:14 -04:00
jyvikoandClaude Opus 5.5 8d590c1982 Kernel tests: the long-setback G2 patch's reach past the box from its exact surface
a_long_setback_keeps_the_g2_patch_inside_the_box measured the patch's reach past the box on
the vertices of a display mesh at chord 1e-3, so where the tessellation's nodes fell decided
the result (#9307 moved them). It now brackets the highest max(x - 60, y - 40, z - 20) on the
patch within its trim from the exact B-spline: the surface cut into its Bezier patches, split
by de Casteljau while a patch's control hull can still beat the best surface point found
inside the trim (the pcurves), so the hull bounds it from above and the patch corners from
below.

Body::exact_bounds (SMLib's SmFace::CalculateTightBoundingBox) is not used: it gives the
patch 40 + 1.4e-14 in y at set back 12, while the surface at (u, v) (-1.509, 8.041), inside
the trim, is at y = 40.00133 (a mesh node there agrees).

The bound is 1e-9 mm: the body is convex, a convex face lies inside each tangent plane, and
the patch meets each box plane tangentially along its seam, so it reaches past none of them
but by rounding. The exact extent shows the patch does reach past the box at every setback,
each time 0.4 to 0.65 mm from a hole corner (where a round's section ends on a plane, inside
the fill's fade zone): 7.0776e-4 (s 11, z), 1.3298e-3 (s 12, y), 2.6338e-6 (s 13, y),
5.1293e-5 (s 14, x), 4.7891e-4 (s 15, x). The test fails with these numbers until the patch
construction keeps the fill convex there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 09:02:50 -04:00
Brett LawsonandClaude Opus 5.5 0bed45d82c smlib: solidcore's planar thicken side walls opt-in is on; four opt-ins wait for the fork
thicken_planar_side_walls (WR-564, solidcore#1665) is on: its fork commit, smlib@d384e86, is in
SMLIB_REV. fillet_torus_span_from_start_section (smlib@985faae), fillet_knife_edge_rounds
(smlib@b7ec55b), taper_wall_closes_at_apex (smlib@183ea65) and
revolution_round_offset_collapses (smlib@8b2090f) are past SMLIB_REV, so they go on HELD_BACK.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 13:55:13 +01:00
jyvikoandClaude Opus 5.5 9a45d42484 Kernel rig: inspect.analysis is a display analysis switch, exempt like the others
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 08:48:54 -04:00
jyvikoandClaude Opus 5.5 6ab96c6583 View analyses: one toggle group, its state in the session
Zebra, Draft, Curvature Map, Environment Map, Accessibility, Continuity,
Isocurve and Curvature Comb are one group: turning one on turns the one on
before off (Session::analyses_off), and the session says which is on
(Session::active_analysis). The new inspect.analysis names it and off: true
turns it off (typed contract and reply). The toolbar shows the active one's
button pressed, its tool running or not. Curvature Comb's button toggles:
on, the tool combs the edges clicked; again, off and the combs go; Esc or a
right click in the tool turns it off; opening another dialog leaves it on.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 08:48:54 -04:00
jyvikoandClaude Opus 5.5 0b7468729f Curvature comb: every comb shown at one scale, kept by the command
inspect.curvature_comb keeps what it shows in the session (Session::comb):
add: true combs the new picks together with those shown, so every comb
shares one scale and tooth lengths compare across curves (a curvature jump
where two edges meet shows); with nothing picked it draws those shown again
with new options; clear: true ends it. Each sketch curve keeps its own
sketch. The tool runs it once per pick and per Comb length / Teeth change,
and the viewport draws the session's combs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 08:48:54 -04:00
jyvikoandClaude Opus 5.5 9851718ea3 Curvature comb: purple envelope and orange teeth from their own theme tokens
comb_envelope and comb_teeth in the light and dark palettes (legible on each
view background), themable from a theme file, measured by the colour vision
tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 08:48:54 -04:00
Brett LawsonandClaude Opus 5.5 a6b280467a solidcore: move the pin to 3569b5d73 (main, with solidcore#1665, #1681, #1614, #1677)
Merged since dca3135cc:
- #1665 thickening a sheet puts its flat side walls on planes, opt-in (WR-564, fixes #1599)
- #1681 a UV trim made on a classification snapshot keeps its owner (fixes #1678)
- #1687 a UV trim's owner is its edge use's notification key
- #1614 B-rep attributes through sweeps and surfaces (#1462 P6)
- #1677 SmFace::DeleteInnerLoop
- #1690 EvalNormal reads the matrix of a failed evaluation (near-flat GlobalPointSolve)
- #1692 opt-in round of revolution collapses under an inward offset (WR-567)
- #1693 opt-in torus round span from its start section (WR-568)
- #1694 opt-in knife-edge rounds (WR-570)
- #1695 opt-in draft walls that close partway up end at their apex (WR-571)
- #1691 booleans pair each face only with faces whose box is near
- #1676, #1667, #1682 tests; #1701 docs

solidcore#1650 (Caller-keyed check, #1631) is not in yet.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 13:39:48 +01:00
jyvikoandClaude Opus 5.5 9b35727976 Fillet rig: the known-failing list names the report- cases, not their old ids
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 08:02:50 -04:00
jyvikoandClaude Opus 5.5 6cc7597502 SMLib import: an extruded circle is a cylinder over the face's trimmed range
This replaces the spline fallback of 64efbe7f6. A face SMLib holds as a rational spline that is
an extruded circle was recognised as a cylinder over the spline's whole parameter range: for the
upper half of the peg's wall after the front top round that range runs 393 degrees round (u in
[-15, 40.18], SMLib's support surface extended past the face), and SMLib refuses a cylinder past
one turn. The face itself, its loops' box, spans u in [0, 8 pi]: half a turn. The cylinder now
takes the face's trimmed range, the least and greatest u and v of its uses' pcurves over their
edges' intervals, found to rounding on each Bezier span (the values at the pieces' ends bound the
extreme from below, the control points from above; pieces that cannot beat the best are dropped,
the others halved). A face whose trims run more than one turn round is no face of a cylinder: it
is refused as an invalid record, never kept as a spline.

The peg (40 x 16 x 10 bar, R8 end, a disc R8 extruded 10 up on its top, joined), front top edge
rounded r2: the body measures to 1e-7 of its closed form, the three r2 corner rounds after it
build and measure, and the upper wall comes back from SMLib a cylinder of radius 8 (engine test).

The rig case of the round of the edge where that round meets the wall (tangent at one end) still
fails, for another reason: on the wall as its exact cylinder SMLib refuses the round as larger
than the faces beside its edges allow (it fades to nothing at the tangent end) instead of
returning a body its own check refuses. Its KNOWN_FAILING line says so.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 08:02:50 -04:00
jyvikoandClaude Opus 5.5 dfa84e84d1 Blends: an edge is smooth when its faces' normals agree all along it, decided exactly
This replaces the five fixed stations of 0a166bf3d, which compared the faces' normals at the
edge's ends and quarters: a sampled guess that misses a crease or a tangency between stations.

Along each use's pcurve (on the edge's own parameter), the face's natural normal Su x Sv is a
polynomial in t on every piece where the pcurve stays in one span of its knots and one knot cell
of its surface: of degree (2p + 2q - 2) r for a B-spline surface of degree (p, q) and a pcurve
of degree r, (4p + 4q - 2) r for a rational one (its homogeneous form), 0 for a plane. The cross
product of the two outward normals is then a polynomial of degree D, the sum, and it vanishes
on the piece iff it vanishes at D + 1 points of it (the piece's Chebyshev points). Pieces end at
the pcurves' knots and where a pcurve crosses a knot line of its surface (periodic copies too),
each a root of U(t) - k W(t) on a Bézier span, isolated on its Bernstein coefficients. A point
where the normals differ is a witness of a crease; agreement at all of them is a proof of
tangency (crate::tangent_edge). Outward normals opposite (a cusp, a knife edge) is not smooth,
as SMLib's GetBlendEdgeuse has it since fork 81f411d; a seam, whose two uses are on one face,
is smooth.

The C API has no edge classification query; SMLib's own (GetBlendEdgeuse at t = 0.34,
IsTangentSector at five stations) is sampled too. A fork item to make it exact and expose it is
written up for the SMLib batch. The tangent-chain walk decides each edge once.

The bar whose front face runs tangent into a cylinder R8, its front top edge rounded r2: the
round's contact with the front face and the front face's tangent line with the wall are smooth;
the round's edge with the wall (tangent at (40, 0, 8) only) and a box edge are creases; the
knife edge of #851 is a cusp, not smooth (blend.rs test). The blend, fillet and chamfer kernel
tests and the fillets rig keep their outcomes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 08:02:50 -04:00
jyvikoandClaude Opus 5.5 ccc690c535 Fillets: a curvature-continuous fillet's corners are G2 patches
A curvature-continuous fillet (type curvature, equivalent radius 2) of the three edges at a top
corner of the owner's bar built, but its corner was SMLib's own patch, which is only tangent to
the rounds: Continuity Analysis measures a 35.8 / mm curvature jump across its seams (with the
rounds G2 to the faces everywhere else), and it shows as a dome sitting on the corner, the
vertical round's shading lost under it. All three edges were rounded; the corner was not
curvature-continuous, and nothing said so.

Such a corner, where three or more rounded edges meet, is now set back (1.5 r unless a setback
names it) and left open by SMLib with the curvature sections (smlib_blend_setback_open with
SMLIB_BLEND_CURVATURE), and filled with the G2 patch fillet_g2_corners already uses for circular
rounds (fillet_g2_with_g2_corners). The `corner` option no longer leaves a curvature fillet with
SMLib's patch: its corners are always G2, and setbacks on it set back the curvature rounds (they
were circular rounds before). Where SMLib or the patch cannot build it, it is refused.

On the reported geometry every seam of the rounds and the patch is G2 (rig
report-fillet-curvature-three-edges-at-bar-corner-solver-residues), and the rounds outside the
setback cube measure exactly: V0 - 27 - (the quintic section, A2 = 0.597884, along the front edge
from 3 to the wall and along 7 and 13) = 9541.116961 (...-outside-setback). With round coordinates
SMLib's open sheet fails its own check (a 2D curve cusp, SmBSplineCurve test 13): the fillet is
refused, listed as known failing (report-fillet-curvature-three-edges-at-bar-corner).

Test: corner_g2_tests::curvature_rounds_meet_at_a_g2_corner (box corner, r5: the patch's jump
under CURVATURE_SHARE / r clear of the hole's corners, SMLib's own patch over ten times that).

Changes a default: a saved curvature fillet with such a corner rebuilds with the G2 patch; there
is no preference or fallback to SMLib's patch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 08:02:50 -04:00
jyvikoandClaude Opus 5.5 a9755bdd23 Fillet rig: the owner's reports are report- cases; the G2 corner graded at its seams
The cases from the owner's reports in the app (no issue) were named and cited after issues they
only resemble (#9, #896, #1207). They are report-<name> now and list no sources; their `what`
says where they were reported. The README gives the convention (report- for a report with no
issue or pull request, cov- for a command with no source).

report-fillet-g2-corner-of-bar-running-into-cylinder was graded by a 3^3 volume band and a face
count, which say little about a G2 corner. It keeps the band (provable: the patch differs from the
rolling ball only within the setback cube) and adds the corner seams' curvature jump, as
fillets/9-fillet-corner-r1-curvature-default-setback scaled by r = 2 (at most 0.0025 / mm, clear
of the hole's corners by 0.48 mm, within 4.4 mm of the corner). A new
...-outside-setback case cuts the setback cube [-1, 3] x [-1, 3] x [7, 11] away and grades the
three rounds outside it exactly: V0 - 27 - (front spandrel from x = 3 to the wall + (1 - pi/4) r^2
over 7 and 13) = 9342.029541. The bare face counts are dropped.

The -solver-residues recipes now take the reported sketch's points exactly (the arc's end
x = 41.649711830726524); they fail as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 08:02:50 -04:00
jyvikoandClaude Opus 5.5 de9c005f2b Blends: a blend face is named by its picked edge, not an edge it took up
A 220 x 11 two-distance chamfer of a tapered plate's bottom front edge (rig fillets/5181) runs up
the front face past its straight side edges, l2|start and l6|start, and takes them up: no result
edge comes from them. SMLib leaves the blend face untagged, and it was given every blended edge
whose two faces lie next to it: the picked edge l1|start and both taken-up side edges. Its name
came from the first in edge order, F3:blend:F2:side:l6|F2:start, an edge the user never picked.
A blend face now comes from the picked edges it lies between; only a face that lies between no
picked edge's faces (a corner's piece over a short edge the corner took up) comes from the
taken-up edges it lies between. The chamfer is F3:blend:F2:side:l1|F2:start everywhere on it.

Persistent names: a blend face that also lay between the faces of an edge the blend ran over is
now named by its picked edge only. There is no alias for the old name (5181's
F3:blend:F2:side:l6|F2:start): a saved reference to it is reported lost.

Also corrects 5181's "what": the chamfer builds (335399.749), it is not refused.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 08:02:50 -04:00
jyvikoandClaude Opus 5.5 1e6c91a108 Fillet rig: the concave arc where a bar's top meets a cylinder its sides run tangent into
An r2 round of the arc adds the spandrel ring clipped by the bar's sides, integral over rho in
[8, 10] of [2 - sqrt(4 - (10 - rho)^2)] rho 2 asin(8 / rho) = 18.455363. With round coordinates
it builds to that; with the reported design's sketch residues (~1e-10 mm) SMLib's blend fails,
status 1001 (SmFilletNx1Corner: unable to make topology at the arc's end), listed as known
failing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 08:02:50 -04:00
jyvikoandClaude Opus 5.5 c9bf97ce49 Blends: an edge is smooth only where its faces are tangent all along it
The edge where a round runs into a cylinder's wall it is tangent to at one end (the bar's front
top round meeting the wall at (40, 0, 8), where the round's contact with the front face meets the
wall's tangent line with it) was refused as smooth, "nothing to round": the faces' normals were
compared at the edge's start alone, which was that tangent end. They are now compared at five
stations from end to end, and an edge is smooth only where its faces meet tangentially at every
one: this edge is a crease everywhere but its end. The wall's seam with the front face, tangent
all along, is still refused as smooth.

The round of that edge with its tangent chain (the top's concave arc) now reaches SMLib, whose
result fails its own check (internal poles, coincident control points, cusps where the round
fades out): its rig case in fillets is listed as known failing for that SMLib defect.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 08:02:50 -04:00
jyvikoandClaude Opus 5.5 977949819e SMLib import: an extruded circle past a turn stays its exact spline
A round of a bar's top edge, where the bar's side runs tangent into a cylinder standing on its
round end, seemed to build: SMLib's result holds the cylinder's wall as a rational spline whose
parameter range runs 393° round (u in [-15, 40.18]). Going back into SMLib (to measure the body
or change it again) the record's extruded circles become SMLib cylinders with the face's range on
them, and that range was 6.866 rad: SMLib refuses a cylinder past one turn
(SM_ERR_INVALID_INPUT from BrepFromFlat's face range check). The body could not be measured, a
second round on it failed, and the app said one of its freeform faces can't be used. An extruded
circle whose range runs more than one turn round now stays the exact spline it is.

The bar of the reported design (40 x 16 x 10 with a R8 end, a disc R8 sketched on its top and
extruded 10 up, joined): the front top round removes the spandrel up to the cylinder's wall,
integral over y in [0, 2] of (2 - sqrt(4 - (2 - y)^2)) (40 - sqrt(64 - (8 - y)^2)) = 32.306475;
the three rounds at the other top corner after it remove 53.285832 in all (spandrels outside the
corner cube, the cube less the rolling ball's eighth). Both now build and measure to 1e-7; the
curvature corner of the three edges at once (setback 3) builds too.

Rig cases (fillets) for the three reports: the curvature corner of the three edges, the front
top round, and the three corner rounds after it pass; the same corner rounds with the design's
~1e-10 mm sketch residues fail in SMLib (its corner's surface of revolution is close to singular
at its boundary) and are listed as known failing. (Their ids take the report- convention in the
rig commit later on this branch.)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 08:02:50 -04:00
Brett Lawson 51c474efbc Merge develop 739e47b9 into solidcore 2026-10-30 12:47:46 +01:00