Commit Graph
3451 Commits
Author SHA1 Message Date
Brett LawsonandClaude Opus 5.5 2c8a1fa098 smlib: solidcore drafts a cylinder along the pull into a cone, as the capi since tangency-labs/smlib#27
Ports smlib PR #27 (merge f64ff8b6) into core/offset.rs::draft: a picked face on a cylinder
(end radii equal, the #27 test) gets the cone `drafted_cone` gives, through the same
LocalOperation as a tilted plane. As in the capi, the outward normal at the face's internal
point (`outward_normal`: STEP inversion, NURBS uv, the surface normal turned with the outer
faceuse) says pin or hole (s = +1 or -1). The hinge circle is the axis on the neutral plane,
at the cylinder's height v0. The radius changes by -s tan(angle) per unit along the pull. The
pull must run along the axis (to 1e-9), and the axis must cross the neutral plane;
otherwise, or when the cone would close within the face, the draft is Error::Unsupported.
The capi's control-point edit and CopyAndAddAnalytics are solidcore's Cone::lean_cylinder
(solidcore#1545), with slope -s tan(angle) (z . pull) about height v0. A cone that is not a
cylinder (smlib#53's turned generators) stays Unsupported: lean_cylinder takes cylinders only.

draft_a_curved_face (R 5, h 10, 0.1 rad: V = pi h (R^2 + R r + r^2) / 3 = 638.3350153968712,
r = R - h tan 0.1) stays ignored on solidcore. lean_cylinder keeps the clone's cylinder flag.
Under the cylinder_rebuild_mean_radius fix SolidCraft runs with, rebuild_step_from_nurb_parameters
then refuses the leaned NURB (SM_ERR 1001). With that fix off, the port meets the closed form,
but the face is still flagged a cylinder ({cylinder: 1, plane: 2} vs C++'s {cone: 1, plane: 2}).
This is a solidcore bug, to be filed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 02:39:44 +01:00
Brett LawsonandClaude Opus 5.5 accf0aac99 smlib: solidcore offsets a closed sheet, as the capi since tangency-labs/smlib#17
Ports smlib PR #17 (merge b0180137) into core/offset.rs::offset_sheet: the refusal of a
closed manifold solid is dropped, so faces that close into a solid (a sphere's one face, a
block's six) give the offset solid. The port also gains the capi's `take` check it was
missing: a result without faces is SMLIB_ERR_EMPTY (Error::Empty), not an empty body.

Tests (closed forms):
- offset_sheet_a_solid un-ignored: 32 * 22 * 12 = 8448, bounds -1 .. (31, 21, 11).
- offset_sheet_a_sphere (PR #17's capi case): r 10 moved out 2, (4/3) pi 12^3.
- offset_sheet_a_sphere_to_its_centre: r 10 moved in 10 leaves no face: Empty, as C++.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 02:31:44 +01:00
Brett LawsonandClaude Opus 5.5 eca7aec7ff smlib tests: SMLib now drafts a cylinder side and offsets a closed sheet (develop's SMLib 90aabff, fixes #27 and #17)
The C++ kernel at develop's pin (9d0fb564) builds both cases that expected a refusal;
each now expects its closed form:

- offset_sheet_a_solid (tangency-labs/smlib#17): the 30 x 20 x 10 block, every face
  moved out d = 1, convex edges extended: (a + 2d)(b + 2d)(c + 2d) = 32 * 22 * 12 = 8448,
  bounds (-1, -1, -1) to (31, 21, 11), six planes.
- draft_a_curved_face (tangency-labs/smlib#27): the cylinder R = 5, h = 10 drafted
  0.1 rad about its base, leaning in, is the frustum of radii R and r = R - h tan 0.1:
  V = pi h (R^2 + R r + r^2) / 3 = 638.3350153968712 (a cone and two planes).

C++ meets both within the file's 1e-9 relative. The solidcore side of each is ignored:
core/offset.rs still makes the old capi's refusals (a closed solid in offset_sheet,
planes only in draft). With the offset_sheet refusal dropped, solidcore gives the
block exactly; solidcore has Cone::lean_cylinder (solidcore#1545) for the draft.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 02:26:23 +01:00
Brett Lawson 921381bcb8 Merge develop 7664925f into solidcore
# Conflicts:
#	crates/ui-egui/src/prefs.rs
2026-10-30 00:47:58 +01:00
jyvikoandClaude Opus 5.5 7664925fbf Sketch: Project onto Surface keeps the side the projection meets first, in one curve
SMLib's parallel projection (CreateParallelProjectionCurves) gives every curve where the
projecting lines cross the face: a line projected down onto a ball came back as its top and its
bottom, each split at the pole, and the link's first wire was half the bottom. A projection onto
a surface is where those lines first hit it (owner's decision, as mainstream CAD does): a curve
is now kept only when the first hit on the body's mesh along the line through its middle is the
curve itself (within 4 chord tolerances), and the pieces that meet end to end are joined in
whatever order and direction they come, a piece run the other way exactly (its knots and
control points reversed; a line's, circle's or ellipse's parameter mirrored). The ball's top
is then one wire from x = -10 to 10.

three_d_sketch_curves now expects that exact curve: one wire, its ends at (±10, 0, √300), every
point of its exact curves on the sphere of radius 20 in y = 0 over the top, to the projection's
own tolerance (a millionth of the body's size), and sweeps_and_pipes_follow_3d_sketch_curves
pipes along the whole joined top. Both pass on the pinned SMLib (90aabff): the pieces lie 9.1e-6
off the sphere against a 4e-5 tolerance and meet at the pole within 4.7e-8 rad, since the fork's
8d95600 keeps the pole's exact tangent in StepBackFromSingularity.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 19:40:02 -04:00
jyvikoandClaude Opus 5.5 ac70662d63 Sweeps: a path through a drawn 3D arc follows the arc, not a spline through its three points
path_points took any wire with three or more fit points as a fitted spline, and a 3D arc keeps
its start, through and end points as its fit: the pipe along a quarter arc of radius 20 ran
along the cubic through those three points and came out 388.06 mm³, not π·2²·10π = 394.78.
A wire with its exact arc (Wire::arc) now goes to the kernel as that circle, from its start
counter-clockwise about its normal through its sweep (kernel::curve_path of the record circle).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 19:39:40 -04:00
Brett LawsonandClaude Opus 5.5 a69016f211 solidcore: move the pin to e4379b45 (main, with solidcore#1573: the #1024 rail-through-boundary-vertex test, plus the CreateCurveApproxPoints and PolyBrepCopy ports)
Rig with convert and primitive on solidcore: 466/483 (was 450/479), 482 agree with SMLib, 1 differs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 00:35:20 +01:00
jyvikoandClaude Opus 5.5 de5c338e78 Preferences: keep the older per-side reading of a symmetric surface extrude
Design defaults gains a Surfaces section with one setting,
surface_extrude_symmetric_per_side (off by default). When it is on, new
symmetric surface extrudes go their distance each way, as they did
before they matched solid extrudes. The app hands it to the session
before every command and each frame, and it stays with the user across
tabs and new designs, like the metric tap drill rule.

The Surface Extrude dialog now sends a feature's stored convention only
when the feature is already symmetric, so a one-sided one switched to
Symmetric takes the new reading, as in the solid Extrude dialog.
Labels in en, ar, he, ja, zh, de and ko.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 19:09:59 -04:00
jyvikoandClaude Opus 5.5 9008d13f31 Surface Extrude: a symmetric distance is the total, as for a solid extrude
A symmetric surface.extrude given no convention now splits its distance
evenly around the start plane (10 mm: 5 mm each side), the way
solid.extrude reads it, instead of going the distance each way. Both
commands take their default from one function, which a session setting
(surface_extrude_symmetric_per_side) can turn back to the per-side
reading for surface extrudes. timeline.edit and timeline.redefine give a
one-sided surface extrude made symmetric the same default.

Saved designs are unchanged: every surface extrude saved its convention
(legacy_per_side), and one saved before the marker existed reads per side
as it always did. The help of both commands says how the distance is
read. The 3830 kernel case, recorded with the per-side reading, now says
so explicitly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 19:09:59 -04:00
jyvikoandClaude Opus 5.5 5ada4fc8a5 SMLib: pin 90aabff, a shelled round stays a cylinder and a step wall is ruled as its plane
tangency-labs/smlib#57 on top of 60b1c6a. It fixes the two engine tests the earlier pin broke:
press_pull_on_curved_faces and a_shell_fillet_does_not_follow_a_gone_edge_onto_a_smooth_seam,
with their expectations unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 19:03:36 -04:00
jyvikoandClaude Opus 5.5 29adfd0d7f Kernel tests: the barrel's side is the exact surface of revolution of its arc
The barrel's arc has its centre across the axis, so its side is the inner (lemon) zone of a
spindle torus, which SMLib's torus does not describe (its meridian is on the X side): SMLib
(revolve-spindle) sweeps it as the exact rational surface of revolution. shell_of_a_revolved_barrel
asserted an analytic torus of major radius -10. As the owner decided, it now asserts what
matters: two flat caps and the curved side, the closed-form volume, 14 mm round at mid height,
and after the shell the two offset faces (the inner wall and floor; truck's side was in halves).
Needs SMLib with revolve-spindle (pin bump).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 19:03:36 -04:00
jyvikoandClaude Opus 5.5 bb4299e565 Tests: a drafted cube side leaves the bottom and the opposite side Kept, the rest Modified
Drafting a cube's side about its bottom edge (on the neutral plane) tilts the side and moves the
edges it shares with the top and the two faces beside it: those four are trimmed differently
(Modified); the bottom and the opposite side are untouched (Kept). Truck called all six
Modified; SMLib's history called the moved neighbours Kept. Needs the SMLib fix "history: a face
whose edges an operation moved is Modified, not Kept" (SMLib branch devgreen-kernel-records,
cdaf205) and a pin bump.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 19:03:36 -04:00
jyvikoandClaude Opus 5.5 9d0fb564e0 SMLib: pinned at 60b1c6a: the 43 fixes of 2026-10-29 (tangency-labs/smlib#14–#56)
From 7e917f0 to 60b1c6a on tangency-labs/smlib replay/1.0.1, 45 commits in 43
pull requests:

- Booleans (#28, #29, #34, #39, #45, #47, #55, #56): a coincident edge split with
  its edge, a plane grown to cover a face however far, a seam point classified to
  its face, intersection loops closed only along edges that lie on each other,
  curves inside one ProtoVertex split at its vertices, an intersection along a
  face's own edge taken as that edge, a plane a hair into a cylinder touching it
  along one line (and crossing it in two), faces and loops apart not intersected.
- Transforms (#48, #49, #50): a mirrored cylinder read back from its NURBS turns
  the right way, a rotation or reflection keeps every tolerance and a scale
  scales them, a scaled body's model size is measured from its geometry.
- Fillets and chamfers (#24, #30, #51): a chamfer round an arc is a cone, a gentle
  corner in a variable radius splits the round, a seam round's corner ball sits
  where the cylinders' axes meet.
- Shell and offset (#17, #22, #23, #25, #26, #32, #38): closed faces and closed
  sheets offset, exact lines and conics between analytic faces, cones and
  cylinders extended as themselves, a cone's apex offset as a sphere, a wall
  that would turn a face inside out refused, neighbours extended to reach a
  face moved past the body's size, an open edge's trim point on a closed curve.
- Draft (#27, #53): a cylinder along the pull drafts to a cone, a cone about the
  pull to the cone its turned generators make.
- Sweeps (#14, #31, #36, #37, #40, #43, #44): a whole turn of a holed profile
  leaves the void, a curve near a circle swept as itself (text outlines' Béziers
  pass the check), an arc centred across the axis revolves to an exact B-spline
  surface of revolution, a minor circle on the axis and a horn torus, line and
  arc paths swept exactly piece by piece.
- Surfaces (#18, #19, #20, #21): a B-spline starter in Bezier form, extend by the
  distance across the surface and as the same cone or cylinder, untrim in place.
- Intersections (#35, #46, #52): a curve into a pole keeps its tangent, a periodic
  value just past the top wraps a period down, a curve from a singular point
  starts inside.
- Checks, history, measure (#15, #16, #33, #41, #42, #54): a face whose edges
  moved is Modified, SMLib's warnings are no failed test, sheet faces count in
  the area, internal poles sought in the knot's row, a collapsed seam not
  classified, a small loop oriented on the surface's scale.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 19:03:36 -04:00
jyvikoandClaude Opus 5.5 567b764b93 Viewport tests: the offset ellipse ring's 512 wall joins are all smooth
SMLib now sweeps a curve within the tolerance of a circle as itself, not as that
circle's cylinder (tangency-labs/smlib#31, 3cfbbdd), so the offset curves' pieces
meet with one curvature at every wall join of the ring (the largest curvature
jump 4.2e-7): all 512 are smooth, where 400 were and the other 112 jumped by
0.9-3.6%. The comments that said the pieces meet only tangentially, or at small
real creases, go.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 19:03:36 -04:00
jyvikoandClaude Opus 5.5 f3b77d71b3 Tests: expectations for the SMLib fixes of 2026-10-29
With SMLib integration-overnight + b78bd4a (the fixes of 2026-10-29), three
expectations that held a refusal now build, each checked against its exact answer:

- rig fillets/1207-fillet-box-end-edge-into-unblended-round (was ...-refused): the end
  face's top edge of a cube rounded r3 along its top back edge, rounded r1 alone
  (tangent chain off), builds. Its round runs on along y through the r3 round's end
  until that surface drops below it at y = 17 + sqrt(5): V = 8000 - 20 (9 - 9 pi/4)
  - 17 (1 - pi/4) - 0.218236 = 7957.505202 (the last term the section under the round,
  integrated exactly); SMLib gives 7957.505245.
- blend_smlib smooth_edges_and_unfinished_tangent_chains_are_refused_saying_why: the
  same cube builds, at that volume.
- modify_history_tests::smlib::draft_tilts_a_side_and_keeps_its_name: the rod's side,
  a cylinder along the pull, drafts 5 deg to a frustum, radius 5 at the neutral plane
  and 5 - 10 tan 5 deg at the top, at its exact volume.

tests/kernel-cases/fillets/KNOWN_FAILING drops 1557-fillet-vertical-corners-after-
bottom-rounds, which passes now; the other eight still fail, so the gate holds
(81 pass, 8 known failing, no regression).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 19:03:36 -04:00
jyvikoandClaude Opus 5.5 de606715b0 Placement tests: a body mirrored in SMLib reads back from its record valid
Since an operation's result is its record (f11c0c571), a mirrored body is
SMLib's transform read back from SMLib's export, and two SMLib defects there
made it invalid: a mirrored cylinder came back inside out the wrong way
(SmCylinder::IsNurbSurfaceCylinder; its edges 10 to 30 mm off the surface),
and every edge's own tolerance was reset to the body's (SmBrep::Transform).
Both are fixed in SMLib (fix/mirrored-cylinder-from-nurbs e02e63e, c603293,
with e008e82 for a scaled body without vertices);
this test needs the SMLib pin moved past them.

A plate with a through hole and a box with two rounds meeting at a corner,
mirrored in x = 30 and read back from their records: SMLib finds both valid
and their volumes are the originals'.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 19:03:36 -04:00
Brett LawsonandClaude Opus 5.5 76c755508e smlib: a call answers None exactly when solidcore's error stands for an SMLib status (SolidError::sm_status, solidcore#1452)
Same set as before (Upstream and Nlib), now read from solidcore's own classification.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 23:03:37 +01:00
Brett LawsonandClaude Opus 5.5 c13d760faa smlib: a copy queried under the arena's identities is a port-side invariant (solidcore#1452)
solidcore#1452 reports a port-side failure as SolidError::PortInvariant with no SMLib status,
where it was InvalidInput.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 23:02:13 +01:00
Brett LawsonandClaude Opus 5.5 41e902eaa3 solidcore: move the pin to 0ae36782 (main, with solidcore#1452: SolidError::sm_status and a port-invariant variant)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 22:54:08 +01:00
Brett LawsonandClaude Opus 5.5 0abd028304 Merge ws/check: the body check runs on solidcore's check_brep (solidcore#1419)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 22:46:31 +01:00
Brett LawsonandClaude Opus 5.5 b8c2282090 solidcore: run the body check (smlib_brep_check) on solidcore#1419's check_brep
The check is the capi's call sequence on solidcore's public check API: ValidatePointers, then,
when that fails nothing, AssertValid over the whole body at the requested level. The report
keeps the capi's lines: "<type>::Test #N <name>: <message> [owner <type>]", the line for a
failed status with no report, and "AssertValid skipped". The failure count is the capi's: the
skipped line is not counted.

The check never reports a body valid after running fewer tests than the C++ kernel. A test
solidcore has not ported fails it with "not supported yet". So does a body whose geometry
owners are named by keys the check cannot know: NamingScheme::Unknown, or Caller other than
SolidCraft's own array import. check_brep would check those against arena identities and fail
SmBrep test 61 on every edge. Bodies imported from arrays are checked with the import's key_of.

The primitives' check and check parity tests run again. New tests: a valid box passes level 2
with an empty report on both kernels, and a box with a vertex moved 1 mm off its edges (made
through the arrays) gets the C++ kernel's report, line for line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 22:13:42 +01:00
Brett LawsonandClaude Opus 5.5 0d3c46dad2 solidcore: move the pin to 6a068272 (main, with solidcore#1419 WP4: the level-2 AssertValid tests and SmSurfOfExtrusion::AssertValid, #1578)
Turns on the new flags transform_scales_each_tolerance and
transform_model_size_from_body_box.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 22:06:55 +01:00
Brett LawsonandClaude Opus 5.5 98e5e7a05d Merge ws/convroute: Convert runs on solidcore by default
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 21:58:47 +01:00
Brett LawsonandClaude Opus 5.5 1f8d8fa9a8 Kernel routing: records convert on solidcore by default
Op::Convert moves to Backend::Solidcore: a schema 4 record becomes a solidcore body
(Brep::from_record, from_record_keeping_splines) and a body's arrays for the record mapping come
from solidcore (Brep::arrays, so to_native, to_native_report, to_native_ordered). A C++ operation
still gets its own body from solidcore's arrays through the flat import, when it asks for one.

Rig (cargo xtask kernel-cases, 479 cases, solidcore 3c17ddb1):
- convert routed alone (--kernel solidcore --route convert=solidcore): 450/479 against SMLib's
  449; 478 agree, the other (fillets/1557) fails on SMLib and passes on solidcore
- the new default table (--route primitive=solidcore,convert=solidcore): 450/479
- SMLib only (plain run, SOLIDCRAFT_KERNEL=smlib): 449/479; the only case that differs is 1557,
  better on the table

Against SOLIDCRAFT_KERNEL_ROUTES=convert=smlib, no test fails that did not already: smlib with
and without native, solidcraft-kernel --features smlib, the engine lib tests with --features
smlib, and the naming corpus (the same 116 designs differ, with the same output).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 21:53:25 +01:00
Brett LawsonandClaude Opus 5.5 22a1c20b1d solidcore: move the pin to b3baca8e (main, with solidcore#1490 and #1491: a revolve's torus is never inside out and keeps the flag, and a one-circle full turn puts its seam at the profile)
Turns on the new flags torus_keeps_inside_out and internal_pole_row_through_knot.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 21:23:31 +01:00
Brett LawsonandClaude Opus 5.5 2f623f3f22 Merge ws/devmerge2: develop ac52443d, and ablasik's cone export fix
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 21:23:05 +01:00
Brett LawsonandClaude Opus 5.5 9c7c139bdd solidcore: move the pin to b19dbcb5 (main, with solidcore#1476: a shell's implicit offsets take every base upstream casts to a B-spline, and the offset sample bound scales with the input)
Turns on the new flag torus_iso_circle_axis_from_midpoint.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 20:50:45 +01:00
Brett LawsonandClaude Opus 5.5 1f6def9d72 smlib: drop the cone test's gate on a solidcore feature this branch doesn't have
The export tests module is already gated on `native`; the cherry-picked test's
`any(native, solidcore)` names a feature that isn't declared here, which
clippy -D warnings rejects as an unexpected cfg.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 20:41:47 +01:00
Andrzej Błasik b4fb9188ad fix(smlib): export a cone of rounding-size half angle as a cylinder
The portable record rejects a cone with |half angle| < 1e-12; a52's thread
cones come out of the trims at 1e-13 and failed 10 features with
'cone dimensions'.

(cherry picked from commit d5d74105a2)
2026-10-29 20:34:36 +01:00
Brett LawsonandClaude Opus 5.5 03f97cd1d1 Merge origin/develop (ac52443d) into solidcore
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 20:34:36 +01:00
Brett LawsonandClaude Opus 5.5 8ec45a0f4d Merge ws/draft: draft faces through SmBrep::LocalOperation on solidcore
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 20:04:37 +01:00
Brett LawsonandClaude Opus 5.5 ca6a7ef21e solidcore: draft faces through SmBrep::LocalOperation (solidcore PR #1427)
core::offset::draft now finishes the capi's draft_faces: each picked plane is
copied, turned by the angle about its hinge on the neutral plane
(RotateAboutAxisAtPoint about n x pull), and solidcore's local_operation puts
the tilted planes in, under the offset calls' notification stores; its status
maps through the module's status() and the result through finish(). The tail
is adapted from ablasik's draft in crates/smlib/src/ffi/rs_ops2.rs on
ablasik/solidcraft app/solidcore-backend-on-develop (9c7e8e31), reordered to
follow the capi line for line and using core::offset's errors and checks
(ATTRIBUTION.md, Recovered contributions).

The capi's moved_faces check (SMLIB_ERR_NO_EFFECT when no result face lies on
a marked surface) is not made: solidcore surfaces carry no attributes and the
local operation reports no face history (solidcore#1462). Face moves stay on
SmOffsetFacesExecutive (#1060) and are still refused.

draft_box_sides is no longer ignored; draft_one_side, draft_one_side_out and
draft_one_side_hinged_at_the_top check the single-face wedge (a h^2 tan(t) / 2)
against both kernels.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 20:04:09 +01:00
Brett LawsonandClaude Opus 5.5 c191634b54 solidcore: move the pin to 7ca6ce7a (main, with solidcore PR #1427 SmBrep::LocalOperation, #1474 Nx1 corner, and fixes since 3c17ddb1)
Turns on the new flags local_operation_offset_status, torus_major_radius_from_origin,
fillet_corner_sphere_from_four_arcs, fillet_nx1_opposite_continuation_side_edge and
fillet_trace_rejects_short_step.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 19:09:36 +01:00
Brett Lawson 095044d539 Merge branch 'solidcore' into ws/convroute 2026-10-29 19:09:33 +01:00
jyvikoandClaude Opus 5.5 ac52443dfb Ring tests: a cut's volume is the piece it took, not the difference of the ring's volumes
notch_into_a_ring_chamfer_is_cut_exactly measured the notch as the ring's mesh volume before less
after (0.2906 against the integral's 0.28665) and oblique_cuts_through_a_chamfered_ring_are_exact
compared the two mirrored cuts the same way (3.3e-4 apart). The cut is right: the ring less the
cut ring is a piece of 0.2866521 mm³, the integral to 2e-6. A difference of two 1149 mm³ volumes
is not: the re-tessellated ring's mesh volume moves by 4e-3, and SMLib's mass properties (at
their finest, 1e-4 asked) by 1.5e-6 of the ring, 1.7e-3. Each cut is now measured as the piece it
took away (the ring before less the ring after, an SMLib boolean), to 1e-5 of the integral and
1e-6 between the two mirrored cuts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 b6b59e7b3b Naming tests: pieces of one name on a grooved disc, the merged boss wall by its point
SMLib keeps a whole cylinder one face and the arm's round end and the boss over it (one
cylinder) one face, named for the arm's end. Three naming tests relied on truck's pieces:
- a_cut_through_one_of_two_bosses_names_only_its_own_walls finds the boss's wall by a point
  on it (the centroid of truck's half cylinder lies on nothing now) and checks it keeps its
  name through the cut and the fillets;
- split_pieces_keep_their_numbers_across_evaluations keeps the torus (its sweep's walls are
  whole now, their names stable) and adds a disc whose top a round groove splits into
  F1:top#1 and #2;
- a_design_saved_before_pieces_were_numbered_by_place_keeps_their_numbers uses that disc,
  whose kernel order numbers the pieces the other way round from their place (the post's
  side of multi-body-join-cut is one face now).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 c93b3ad5ab Engine tests: SMLib's builds where truck refused or approximated
- shell_tangent_chain_that_opens_every_face_explains_how_to_keep_walls: the shell is the
  rounded box (its 37 x 27 x 57 core grown by the 1.5 ball: 71753.436) less the sharp 36 x 56
  x 28 cavity, 15305.436, to the measure's 2e-7 (SMLib: 15305.445); truck's was 15305.28.
- press_pull_on_curved_faces: the shell's inner wall behind a fillet is offset as a face
  (SMLib builds it, truck refused it as tangent to its neighbours): pulled 0.5 into the
  cavity it adds exactly the quarter ring π/4 (3² - 2.5²) 18 = 38.877.
- revolve_cut_round_a_box_corner_does_not_panic: the side face is picked by its point; the
  report's face index was truck's face order (SMLib's face 1 is the opposite side).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 24bcaca039 Engine tests: SMLib's faces, not truck's pieces, in the face counts and measures
SMLib keeps a whole cylinder (and an arc of one past half a turn) as one face closed on its
seam, where truck split it in two; its holes are exact circles; its mass properties come
within 2e-7 of a closed form. The tests that counted truck's pieces or its polygon hole now
check the exact geometry:
- extrude_of_adjacent_profiles_has_whole_edges: the cut-off cylinder is 4 faces (arc side
  4674 = 40·(2π − 1.2019)·23, chord side 1039.8, two ends);
- step_export_of_an_enclosure_with_a_screw_hole: 27 faces, as the file holds them;
- model_faces_gives_a_point...: the hole's wall is one cylinder, its centroid on the axis;
- draft_takes_a_cylinders_side_by_name: one side face (the draft itself waits for SMLib's
  draft of a cylinder);
- convert_to_sheet_metal_takes_the_plates_face_by_name: 15000 − 62.5π to the measure's 2e-7;
- a_checkpoint_survives_file_new: a unit box measures 1 + 2e-16;
- creating_a_component_recomputes_nothing: SMLib's boolean keeps the face certificate the old
  setup relied on losing, so the legacy face plane is made as a design saved before face
  attachments were certified (its anchor removed) and reopened.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 ab68a3d0fb View tests: the section cap test draws the cap in the cap colour
Since the section hatch per part (#8529), a cut is tinted toward the hatch colour its body's
name picks; Body1 picks the steel one, so the cap test's warm pixels were none
(cpu_picture_section_caps_hide_the_inside). The test turns the part hatch off: it checks that
the cap hides the inside and shows its colour, which the hatch tests cover per part.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 ca53656a20 Schema tests: an empty face list is checked on the draft, which refuses it
solid.shell takes faces: [] since 1df330c79 (a closed hollow body), so its row in
shared_types_keep_the_handlers_messages no longer matched the shared FaceRefs message. The row
uses solid.draft, which still refuses it; FaceRefs says shell's exception.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 ee9fc37935 Tests: a torus patch to thicken is cut from SMLib's one-face torus
SMLib makes a torus one face, so the face at (25, 0, 0) was the whole torus,
not a patch within half a turn each way. The patch is now the torus's piece
with x, y > 0 and z > 1, bounded by iso lines both ways (planes through the
axis, and z = 1 round the tube), and its thickened volume is the formula's
over the angles its mesh spans. (The sphere cap above it builds once SMLib's
offset takes an open edge's second trim point away from its first: SMLib
devgreen-kernel-geometry; waits for the pin.)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 b9d65e6bc8 Tests: thicken across a sharp edge extends the offsets until they meet
SMLib thickens a sheet across a convex sharp edge as other CAD does: each
face's offset is extended until the offsets meet (and trimmed where they
cross inward), where truck bridged the gap with a wedge. Owner decision:
keep SMLib's result. The exact values:
- three faces of a 10 box's corner out by 1: three slabs, a 1 × 1 × 10 block
  along each edge and a unit cube at the corner, 300 + 30 + 1 = 11³ − 10³;
- into the inside corner by 1: 10³ − 9³ (it was refused); half each way:
  10.5³ − 9.5³ (refused too);
- two faces across one edge: 2 · 100 + 1 · 1 · 10 = 210.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 8075b8f70f Tests: a swept point path is its lines, and rails must turn with a cornered path
A sweep along points follows the lines between them (no wall is fitted through
the points, sweep_sheet_points' contract, as sweeps_along_3d_paths already
says): along a quarter circle of 41 points the sheet is a wall per line, 40,
its area 10 × the polyline's length (within 10⁻⁴ of 10 × 15π); the bent chain
is 2 × 40 walls sharing every seam, 2·41 + 3·40 edges.

SMLib's sweep takes guide rails along a cornered path when each rail turns
with the path at its corners; a straight rail along a bent path is refused
for that reason, not as "guide rails along a path with sharp corners".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 6c9c679dcc Tests: a revolved sheet over one radian is one face, untrimmed over its whole span
SMLib revolves the cone frustum's sheet over angles 0…1 as one face, where
truck made two of half a radian each; the face's own span is angles 0…1 by
profile parameters 0…0.8: √125 · ∫₀^0.8 (5 + 5t) dt = √125 · 5.6.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 2c341006a0 Tests: a cylinder's side and a sphere are one face each, as SMLib builds them
SMLib makes a cylinder's side one face closed round its seam, and a sphere one
face; the tests picked "one half" of the side or "one sixth" of the sphere, which
were truck's pieces. The offset test moves the whole side (one face, area
2π·12·20); the thicken test takes half the side from a cylinder split at x = 0
(π·(11² − 10²)/2·20) and the whole side inward (π·(10² − 9²)·20); the sphere
test takes the cap above z = 5 (solid angle π: π/3·(11³ − 10³)).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 98284eb1e1 Tests: a box thinner than a body's tolerance may be refused instead of getting no certificate
prism_measure's uncertain-material check built a 20 x 20 x 1e-5 box and asked that it get no
cap certificate. SMLib refuses that box (its loops fail SMLib's orientation check): at 1e-5 it
is half a body's tolerance (2e-5) thick, no solid. Refused or built without a certificate, the
property holds.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 908bc756c6 Tests: the matchsurf and mixed-fillet helpers read an edge on the curve its interval is on
edge_at (matchsurf) and the mixed fillet mitre check evaluated `e.curve` at parameters from
`e.interval`, which is the interval on the edge's NURBS form when it has one (SMLib's edges
do): they picked and sampled the wrong points. They now evaluate `e.parameters()`, as the fill
helpers do since aa534cc6d's fix on the kernel-geometry branch. (Both tests still fail, for
their own causes: the G2/G3 match leaves a curvature jump of 2 at the seam, and SMLib's mixed
blend lies 4e-7 off its section circle.)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 30ceb44e6d Tests: SMLib's faces, one per swept segment, closed along a seam, replace truck's halves
Truck split what it swept: a big arc into two faces, a full circle into halves, a turn into
two or three parts, a sphere into six patches, a torus into six; it numbered boxes' faces in its
own order and sewed stepped cuts slab by slab. SMLib sweeps each profile segment into one face,
closes a full cylinder, sphere or torus along one seam edge, and cuts without slabs. The record,
face source, helix, display mesh, measure and boolean history tests still expected truck's
pieces. Each expectation now follows the geometry, checked by the tests' own independent
measures: every face's origin against the profile segment its mesh lies over (unchanged),
faces picked by where they lie instead of by truck's face numbers, and the merged counts by the
kernel-cases ladder's rule (each whole curve once, and each cylinder's seam): a cylinder 3
faces, 3 edges, 2 vertices; a ball cut from a slab 7, 14, 10. The truck-only stepped-prism
check (walls coalesced across slabs) becomes the property it stood for: the stock's walls stay
whole, one face each, Kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 3c680d21a9 Geometry: the closest point on a full circle just before its start is found before its end
Seg2::closest_param starts Newton from the nearest of 65 samples. On a closed segment (a full
circle) the start and end samples are one point and the first wins the tie; for a point just
before the start (in the sweep's sense) Newton then wants a parameter below 0, the clamp holds
it at 0, and the answer is the start point, off by up to a sample spacing (0.15 mm on a 5 mm
circle). The record tests' face-to-segment matching read an SMLib cylinder's side as lying
over no segment because of it. A closed segment whose answer lands on an end now also tries
Newton from the other end and keeps the nearer; every other answer is bit for bit as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 d0daee90ff Tests: a cam's edge is picked on its rim, off the vertex where its circle's seam meets it
picked_edges_give_the_sketch_s_table picked [E + R, 0, 5]: on SMLib's extruded circle that is the
vertex where the side's seam meets the top rim, a pick either edge answers, and it took the
seam. The pick is now a quarter turn round the rim, [E, R, 5]; the product's pick rule is
unchanged (owner's call).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00