Files
solidcraft/docs/render-materials/TRANSPORT-MASTER-BATCH-2026-10-23.md
T
9e6e0b8df1 Render workspace: complete experimental ribbon, resources and effects integration (#5493) (#5494)
* wip(render): reconcile completed material and image pipeline source with 0.20 (#5493)

Source-only integration reference for staged review, not a merge-ready aggregate.
Donor: 0xlillith/solidcraft@aea20b0115.
Upstream: 858e5995d6.

Retain original CPU/material contracts and explicit GPU donor provenance in
docs/render-materials-lab.md (#2067, #2191, #2780, #3306). Preserve released
format migrations and current navigation/startup/shell behavior. New saved
records use pending descriptors. The physical-card descriptor follows the
maintainer's material-engineering-cards naming request, with a legacy-lab
format-29 regression. Replace raw new panel hosts with shared containers.

Repository checks, complete workspace/all-target Clippy, and the independent
physical/resource authoring checks pass for this source. The fresh full local
CI invocation has reached test compilation and is not yet complete. Do not
transfer donor native output or prior test totals to this integration.

Generated review screenshots, video, package ZIP and machine logs remain at
the immutable personal evidence pin. Uncommitted geometric displacement is
backed up separately, not silently included. No kernel/vendor change, direct
main write, release or independent contributor-branch rewrite.

Co-authored-by: Christian Svensson <blue@cmd.nu>

* test(cli): pin the Compact camera-sample admission diagnostic (#5493)

The bounded request still refuses 1024x1024x64 samples before host initialization and writes no output. Update only the stale expected diagnostic to the existing Compact budget wording; production limits and code are unchanged. Exact-tree CLI regression suite: 14 passed, 0 failed. The full repository gate has been invoked separately and is not yet complete.

* Normalize UI container violation paths across platforms

Report repository-relative paths with forward slashes so diagnostics and the existing nested-package regression assertions agree on Windows and Unix. Keep the container detection rules unchanged.

Validation: official ui-containers gate and all seven focused xtask tests passed; rustfmt and diff checks passed. Only xtask/dependencies were compiled; no application build or heavy tests.
(cherry picked from commit 44b58d8e10)

* fix(render): preserve camera contracts and correct acceptance regressions (#5493)

Preserve Design view.apply semantics with a separate strict Render camera command. Retain existing translations when English-only aliases collide; add material-axis entries and camera-specific pitch labels. Compare complete validated engineering cards and retain job handles before cancellation.

Focused and native acceptance is pinned to tree f8a423b21f. Full CI has been invoked separately and is not claimed green. Landing follows the render integration policy in #5493.

* fix(render): resolve showcase licence and upstream resource hygiene (#5493)

Record SychPL's explicit MIT OR Apache-2.0 grant, retaining source/model bytes and the Ubuntu lettering notice. Remove 80 absent attribution rows, personal fork records, dead delivery attributes and three fork/resource-only workflows. Existing xtask assets now performs bounded offline hash checks and rejects orphan render attribution; no parallel draft CI or package installation. Original authoring reproduction remains explicit. Scoped xtask tests, assets, Clippy, formatting and prepared SELENE validation pass; no application or renderer-wide result is inferred.

* fix(render): align saved bounds and progressive sample resolution (#5493)

Address review r4364211669/r4364211677/r4364211681/r4364211691/r4364211695. Persisted light/frame domains respect the existing 1e9 document bound; related LED/rectangle/direction cases use the same bound. Workstation primary resolve shares the 4096 admission cap and film counters use checked conversions. Exact candidate: 485 CPU render tests, 21 render document tests and strict scoped Clippy pass, including positive boundary round trips and 2048/4096 end-to-end checkpoints. No released format/migration edits, relaxed test limits or full-stack acceptance claim.

* wip(render): isolate optional resources and harden sample handling (#5493)

Review work in progress: opt-in encoded render library with reproducible runtime catalog exports; native-only robust dependency through the workspace; checked bloom slices; per-sample point-light diagnostics; independent area-light spatial/film keys. Resource-module binaries in both configurations, generation, Cargo production feature graphs and attribution checks pass. Full engine/render regression and combined acceptance are pending: do not merge this donor as a constituent or treat scoped resource proof as runtime acceptance.

* fix(gpu): preserve donor allocations through the scope-safety repair (#5722)

Port the native-validated #5723 scope-cleanup correction into the experimental donor, retaining its adaptive, volume, aging, photographic and bloom allocations. Same reverse-drain helper and regression cases; the donor combination still needs its own compile/test gate and is not covered retroactively by render-base results.

* claim: #1369

* Reject unknown pending concepts after format folding (#1369)

* test(render): close bounded sampling and bloom review regressions (#5493)

Validate the optional-resource/lighting/dependency donor at its exact tree. Required Vulkan GPU 127/0/3; CPU renderer 487/0; engine Render 72/0; document render 21/0; lean library 7/0; strict scoped Clippy, assets/layers/lists/containers and lean-engine WASM pass. Preserve original failed controller/typing attempts. This is the draft donor/disposition source, not a replacement for constituent render PRs or final main acceptance.

* wip(render): preserve stable aging target validation candidate

Exact staged source from prior review work on donor 3b892eab5e. This is a recovery/review checkpoint, NOT accepted delivery. An actual command-path regression currently fails because the selected executor refuses ordered surface aging. No assertion, capability or admission limit is weakened. Native/UI/full combination acceptance remains pending. Saved/runtime split adds one pending descriptor and retains original file scope; no main/render branch is changed.

* test(render): preserve numeric setup intent at the admitted coordinate bound

Follow up jyviko review on #5494 without weakening the corrected saved-coordinate contract. The positive clicked fixture uses 1e9 instead of inadmissible 2e9; explicit out-of-range cases still refuse, and the full saved setup round-trips through JSON and the native container. Exact-source Render workspace 95/0 and strict all-target UI Clippy pass. This does not incorporate the separately failing stable-aging candidate or claim full current-render acceptance.

* test(render): use the real GPU executor for saved aging

Move successful native cold-reopen Check/Start coverage from the CPU-backed protocol fixture into the production GPU executor tests. Verify capture-index changes preserve the stable target and that enabling aging changes both PNG and raw EXR output. Retain explicit, allocation-free refusal coverage for executors without aging support. Production capabilities and admission checks are unchanged.

* fix(render): persist stable identities for targeted aging (#5493)

Separate saved RenderBodyTarget identities from captured mesh ordinals. Reject legacy ambiguous targets, resolve Check/Start after visibility changes and preserve native reopening, copies and undo. Unsupported executors still refuse; real AMD Vulkan regression completes saved aging after reordered capture.

Source tree 6b84c8ad passes document 23, engine Render 75, GPU effects 5 and Render UI 95 with no failures; scoped strict Clippy, WASM and repository gates pass. Fresh CLI/native reopen and clean/aged GPU exports pass with identical physical totals and inspected actual images. Whole current-render integration is separate.

* fix(render): reconcile combined CPU/GPU contracts on current upstream

Unify captured resources/status and CPU-vs-GPU request schemas after the real two-parent integration; remove obsolete duplicate Vulkan selector and retain combined platform-filter regression. Deduplicate only identical or superseded test definitions, retaining the stronger card metadata and reserved-executor assertions. No assertions, admission limits or feature refusals are weakened.

All targets of render dependencies, GPU, engine, UI, CLI and native app pass cargo check with raytrace-cpu and bundled-render-library at tree c70d00d1. Native executable tests and full current-source acceptance remain pending. This is a private integration rehearsal for subsequent constituent PRs, not an aggregate official render/main merge.

* test(render): retain one complete host lifetime regression set

Deduplicate byte-identical DropProbe/task-lifetime tests and retain the adapted environment/texture ownership regressions with every assertion and complete memory estimate. Keep the registered-geometry admission regression once; only struct field order differed. Replace a one-element diagnostic loop with its equivalent block, preserving all wrap/width assertions.

Test-only integration repair. Formatting and diff checks pass; refreshed executable validation is required. No production behavior, limits, assertions or ignores changed.

* fix(doc): recognize the proven format-29 card descriptor alias

Normalize only the historical format-29 physical-material-cards spelling, and only when material-engineering-cards is registered. Admission and migration de-duplication use the same identity. Unknown concepts, wrong versions and incapable readers still refuse before mutation. Six controlled-history Rust regressions and actual CLI migration/no-clobber acceptance pass. No version, released migration or CI changes. Refs #5793, #1369, #5493.

* test(render): preserve grounding refusal before explicit instance moves

Update the two Render binding fixtures for upstream first-occurrence grounding. Verify grounded movement refuses without changing document/history, then explicitly unground through the public command before the intended move. Retain every target, resource, copy and persistence assertion. Refs #5493.

---------

Co-authored-by: Christian Svensson <blue@cmd.nu>
Co-authored-by: Victor Santos Oliveira <56417388+Vittuu@users.noreply.github.com>
Co-authored-by: cfaulkingham <colin.faulkingham@gmail.com>
2026-10-24 14:21:59 +00:00

88 lines
12 KiB
Markdown
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
# Transport and retained-master continuation — 2026-10-23
This is an implementation checkpoint on the personal `lab/render-scale-resources` branch, not a release or a claim that the entire rendering roadmap is complete. Production source and acceptance evidence must be distinguished. The full GPU and freshly linked application acceptance for this batch is pending at this checkpoint.
## Remote gate diagnosis
The resource gate on `3727ae9e` failed in the CPU-enabled renderer tests on both Ubuntu and Windows. The two failing tests asserted an empty retained-memory pool after completion notification but before the native worker had destroyed its temporary job handle. Local serial execution had hidden that scheduling dependency.
Commit `74f3d615` synchronizes the test-owned worker before exact lease assertions. It changes test synchronization only: production reservations are not released early, assertions are not weakened, and locks or permission checks are not bypassed. Both strict renderer feature configurations and the CPU suite with 16 test threads passed locally.
GitHub did not start a replacement run. Manual dispatch returned HTTP 422, `Actions has been disabled for this repository`, while the repository permission endpoint returned `enabled: true` and the workflow itself was active. The reason for that service-side discrepancy is not established. No Actions, permissions, branch-protection or account configuration was changed. The last failed run is retained; a local pass is not represented as a remote CI pass.
## Completed full-model acceptance of the preceding native application
The native application built from `106f5d57`, SHA-256 `e09ea35eb164355782c34335129f4be057ecd1a669b22a047246b0d341814211`, opened an isolated copy of the exact SELENE functional master. Source SHA-256: `3bd2bfa1c6336394c4a4208d30b52c80d06658a3bd7ea57cc93b774411d1bd68`.
The model retained 2,116 evaluated bodies, 2,094 originally visible bodies and 2,144,099 visible triangles, without timeline errors or warnings. A complete-geometry 480 × 300, 32-sample GPU pair used the reviewed surface and dielectric assignments. Bloom changed PNG presentation without changing the raw EXR digest: `68c1d403b745c6e9d1c31b5b0bb43e887dfcf9eb669d5115c2b346d73272c4fc`.
Native light/docked and dark/floating captures were visually reviewed. The process quit normally with exit code 0, without forced termination; the original model and personal preferences remained unchanged. This is full-geometry integration acceptance at low output resolution, not a new 4K production/convergence benchmark, and not acceptance of the new transport code below.
## Independent-pilot adaptive allocation
The optional GPU `adaptive` object contains `pilot_samples`, `min_samples`, `relative_error`, `absolute_error` and `coverage_error`. The ordinary `samples` value is the production ceiling, not a certified noise bound.
Each pixel first evaluates an independent pilot stream. RGB and coverage moments estimate a bounded production allocation. Pilot radiance is discarded. The original production stream then supplies a fixed number of samples conditional on that pilot allocation; pilot values never become an adaptively stopped final mean. Final per-pixel means feed the same raw EXR, display transform and optional surface denoiser.
Bounds are 16–256 pilots, at least 16 production samples and the existing ceiling of 4,096 production samples. RGB and coverage are considered separately. Nonfinite or overflowing estimates choose the cap, and invalid path radiance fails rather than being hidden. Rare paths can still be missed by a finite pilot, and capped pixels may remain noisy. Dispatch compaction and a global certified stopping rule are not implemented.
Two auxiliary float4 arrays add an explicitly admitted 32 bytes per pixel. Completed job metadata reports minimum/maximum production counts, capped pixels, total production samples and actual primary-path evaluations. This does not count every secondary or shadow ray and is not a timing guarantee.
## Conditional Fresnel stratification
`transmission_samples` accepts 1, 2 or 4. One retains the original stream. Additional strata share the primary and prefix path, stratify the first glass reflection/transmission decision, then decorrelate later random dimensions. Snell refraction, Fresnel response, absorption and geometric medium certification are not replaced by clamping or denoising.
Each invocation traces one bounded subpath. An initial nested-path-loop implementation caused excessive native shader compilation and its review was stopped before any numerical acceptance; that attempt is not a passing test. Strata now advance through host dispatch rather than wrapping the whole integrator in another shader loop. Extra strata cost extra work, and opaque prefixes can be repeated. Quantitative acceptance compares an absorbing-sheet fixture at equal path budget, not merely equal sample labels. No universal speed or noise-free glass claim is made.
## Bounded homogeneous participating medium
The optional GPU `volume` object describes one finite world-millimetre box, scalar extinction per millimetre, RGB scattering albedo and an HG mean cosine. Analog free-flight events occur on camera and indirect paths. Real scattering uses area, environment and sun sources; straight lighting connections include Beer attenuation. The corresponding no-event density is included in the path/light MIS comparison. Volume scattering changes raw transport; it is not a camera-overlay fog filter.
Zero extinction preserves prior transport and consumes no new random variates. Bounds, mean-free-path precision, extinction, albedo and anisotropy are validated before execution. Volume transport requires explicit studio or environment lighting. Glass boundaries, multiple Fresnel strata and the surface-guided denoiser are explicitly refused with an active medium. The UI does not silently clear those choices.
This is not heterogeneous density, nested glass/volume transport, emission, spectral scattering, surface subsurface scattering, a measured optical material, or a physical lunar atmosphere. The existing finite path-depth budget remains authoritative. Physical-vacuum lunar scenes must keep the medium off.
## Nondestructive retained-master presentation
`render.result.regrade` accepts an exact completed job identity and an explicit `presentation` object. It creates a distinct, cancellable job without capturing geometry, invoking a transport executor or mutating the design. Its fixed dimensions and camera belong to the captured master, not a later scene edit.
The decoder accepts only the exact retained native uncompressed FLOAT32 RGBA linear-sRGB/D65 profile. Header, dimensions, offsets, row lengths and sample values are validated. Arbitrary external EXR input is not supported. A PNG without a retained raw companion cannot be reconstructed into a master.
Exposure, tone mapping, RGB gains, contrast, saturation, vignette, camera backdrop and optional display bloom use the shared presentation implementation. The source EXR remains byte-identical and is shared through its original frame lease. Repeated regrading points directly to the original master instead of creating a retention chain. Provenance records the immediate source job, original master job, master digest and exact presentation settings.
A separate metadata lease survives as long as either the derivative job or its frame retains that provenance. Working pixels, bloom buffers and PNG encoding are bounded and admitted. Cancellation cannot publish a partial derivative or destroy the source. Denoising is not reapplied: the raw master does not retain its geometric guides. The shared ribbon and Output inspector expose the same command and use existing completed-frame export protections.
## Resource coverage and clean-room boundary
The native studio set is expanded from 8 to 25 authored compositions, covering all 24 existing original HDR environments while preserving the previous eight identities. Automotive, paint-band review, CNC tooling, service bays, makerspaces, electronics rework, FDM inspection, printed-part photography and aerospace inspection have explicit native compositions. Each keeps camera, geometry and optical assignments intact and declares what it does not synthesize. Complete resolve/apply/undo/offline-reopen and runtime acceptance are required for every new entry; source availability alone is not that evidence.
These producers do not make every advanced material or scene concept executable. Existing authored resources and explicitly supported projections remain separate from unbound specifications. Density grids, nested optical media, spectral transport, displacement, subsurface surfaces, temporal production and other unresolved dependencies retain their unavailable state. The expanded-catalog roadmap is not marked complete.
The algorithms and code in this batch are original. Public mathematical references cover variance/stratification, Beer transmittance and phase-function definitions; no third-party integrator or codec implementation is copied. No runtime dependency or external scene imagery is added.
References:
- https://pbr-book.org/4ed/Monte_Carlo_Integration/Improving_Efficiency
- https://pbr-book.org/4ed/Volume_Scattering/Transmittance
- https://pbr-book.org/4ed/Volume_Scattering/Phase_Functions
- https://openexr.com/en/latest/OpenEXRFileLayout.html
## Acceptance checkpoint
The renderer core has executed 473 passing tests with zero failures, including allocation-oracle, native-master decode/regrade/lease/cancellation and homogeneous-medium mathematical checks. Earlier strict all-workspace checks passed before the final volume integration. The combined current-head strict checks, real GPU transport tests, native application walkthrough and any final catalog-family acceptance must be recorded separately when actually executed. No aggregate project CI, merge or release is claimed here.
## Frozen GPU execution on db68f9e3
The complete hardware/Vulkan GPU suite finished with **108 passed, 0 failed, 3 explicit ignores** on the AMD Radeon 8060S. The exact source tree stayed unchanged. Static WGSL validation and its 528-byte parameter-layout assertion passed separately. Total GPU-suite runtime was 338.13 seconds including cold pipeline setup; this is not per-image render time or a universal startup promise.
The mixed 16 × 16 adaptive fixture used 5,226 production samples plus 4,096 independent pilot evaluations: 9,322 total primary-path evaluations, compared with 16,384 for the fixed 64-sample budget. Its per-pixel production counts ranged from 16 to 64, with 23 pixels at the cap. This is work-accounting evidence, not a certified equal-noise benchmark.
The absorbing-sheet fixture compared 64 ordinary paths with 16 groups of four conditional strata over 32 seeds. Mean squared error against the analytic reference changed from `4.5285017712954006e-5` to `4.037571061352023e-6`, about 11.2 times lower at the same primary-path budget. This measured pilot does not establish faster rendering or universal improvement for every glass scene.
The homogeneous slab produced mean coverage `0.6313934326171875` against `1-exp(-1)`. Single-scattering linear RGB was `0.19750170083716512` against independent slab quadrature `0.1985499369280803`. Absorption-only RGB was exactly zero. HG inverse-CDF/phase tests passed including nearly isotropic media. Zero extinction preserves the previous output; volume/glass and volume/denoiser refusals remain tested.
All **48 authored PBR surfaces and 25 native compositions** completed actual 48 × 32, four-sample GPU images. Every setup reopened exactly and preserved engineering geometry/materials. The 73 PNGs and per-resource receipts are in the isolated `resource-execution-r3` evidence folder. This is individual executable-pack coverage, not a visual certification, all 1,200 material/studio combinations, or completion of the 600 advanced material concepts.
The GPU engine test also regraded a retained master after the CAD geometry changed. It retained the original capture generation and raw-master pointer/digest, changed only the PNG and left the design/revision intact. The fresh UI test build, native control walkthrough and new application/CLI acceptance are still separate pending checks.
Public `ui.inspect` now exposes the current Render draft method, exact active/completed job identities and export destination format without evaluating geometry or pumping a job. Native acceptance can inspect the actual clicked job instead of guessing a session or serial.