Commit Graph
4000 Commits
Author SHA1 Message Date
brett19andClaude Opus 5.5 da4db59a3d HELD_BACK: geometric_g2_continuity's reason is 2992 alone
3368's timeout was the machine's load: it takes 156 s with g2 off, as it took at pin 7.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 12:10:13 -07:00
brett19andClaude Opus 5.5 5d7dca1a91 Offset tests: both kernels refuse a top moved -9; the sphere to its centre waits on solidcore
The C++ kernel at 26cc451 refuses the moved top at -9, as ours does. #2027's numbers need 4.7e-9 at
-7.5, not 1e-6. offset_splits_corner_vertices makes the sphere moved to its centre fail with 1001 rather
than an empty result: ignored with the reason until solidcore answers it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 11:19:50 -07:00
brett19andClaude Opus 5.5 38849d7b00 Hold geometric_g2_continuity: with the rational-span flag off, 2992 and 3368 don't end
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 11:19:50 -07:00
brett19andClaude Opus 5.5 32b26888c1 Turn on offset_keep_cavity_regions and offset_four_face_vertex_split
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 11:00:12 -07:00
brett19andClaude Opus 5.5 9df34988cd Pin solidcore at main bb6b65706 (#2049, #2051, #2055)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 11:00:12 -07:00
brett19andClaude Opus 5.5 2cd566aae0 Hold bspline_trim_keeps_rational_end_spans: it fails 3078's check
With it on sheet-metal/3078 fails SmBSplineCurve::Test #15 Bad Repeated CPts; held off the case passes,
same volume. Holding it is the case the new rule asks for: a check failure.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 10:59:04 -07:00
brett19andClaude Opus 5.5 9337aff4c4 Every solidcore fix on unless it appears broken (brett19's rule)
The rule that a flag goes on only if the fork has it is gone: differing from SMLib is no evidence
against a fix. All 32 held flags are on, fillet_refuse_crossing_rails with solidcore#2053 among them.
HELD_BACK now takes only a flag shown broken, with its case and numbers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 10:28:27 -07:00
brett19andClaude Opus 5.5 2b1a63d3f9 Pin solidcore at main 2898e1197 (#2053)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 10:27:49 -07:00
brett19andClaude Opus 5.5 d4eb66f25e Turn on offset_splits_corner_vertices (fork 2e1bb8c's behaviour)
The fork at 26cc451 offsets four faces at a vertex to two vertices joined by a new edge, as the
flag does, by another route. On, the rig's two drain floors pass, at SMLib's volumes within 4e-15,
and nothing else moves.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 10:18:03 -07:00
brett19andClaude Opus 5.5 6a0166853f A round mitred to one that overflows goes first with it (fork 9ba2b12); flags() and warnings
overflow_first takes the mitred pairs of the stopped call (solidcore#2045's mitred_edges) and
grows the rounds that go first through every mitre, as the capi's. The flag test reads
UpstreamFixes::flags (solidcore#2024), and the check's own filter of SMLib's warning gives way to
AssertReport::is_warning (solidcore#2023).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 09:37:58 -07:00
brett19andClaude Opus 5.5 15e3a61dab Pin 8: decide the new solidcore flags against the fork at 26cc451
On: query_statuses_pass_on, sweep_statuses_pass_on, ssi_proto_topology_statuses_pass_on,
analytic_inversion_answers_apart, fillet_statuses_pass_on, fillet_corner_per_vertex_fan,
fillet_rail_trim_at_near_knot, and fillet_corner_statuses and fillet_edge_curve_domain_statuses
(both soft like the fork since solidcore#2036). Held, the fork keeps upstream's code:
proto_edge_split_upper_keeps_the_old_max, point_on_start_point_squared_tolerance.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 09:36:12 -07:00
brett19andClaude Opus 5.5 eff6416d46 Pin solidcore at main f75e9d2e8 (#2023, #2024, #2034-#2040, #2043-#2045)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 09:34:32 -07:00
brett19andClaude Opus 5.5 7f1bf7cde6 Merge origin/develop 88e00486b
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 09:34:28 -07:00
brett19andClaude Opus 5.5 ed16c4bfc1 Merge develop b0d1ba345 (SMLib 26cc451) through ws/develop-b0d1ba
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 09:34:28 -07:00
brett19andClaude Opus 5.5 0b627d6373 Restore all_solid's loop: an unused index slipped in
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 08:31:30 -07:00
brett19andClaude Opus 5.5 2647b12e55 Hold back fillet_refuse_crossing_rails: not in the fork
The fork has no such check: SmFilletExecutive.cpp:3654 stops overlapping bands,
which stays on. Off, 5 of the 12 action-matrix failures on solidcore pass (oracle/28,
30, 36, 54, typical/filleted-shelled-box's fillet), each failing with the flag's
closest-point query's 1001; the rig does not move.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 08:12:56 -07:00
brett19andClaude Opus 5.5 b6285e5252 Overflowing rounds go first again (solidcore#1980)
OVERFLOW_GOES_FIRST on. The rig shows no wrong volume: 5158's plate keeps its
value and 1080-notched-r8 moves to within 7e-11 of the C++ kernel. The sloped basin's
R4 rounds are refused as in the C++ kernel at 2fc375f.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 07:25:03 -07:00
jyvikoandClaude Opus 5.5 88e00486bb STEP import: a face bounded by a slit alone is the whole of its closed surface
A loop that runs out along a chain of edges and straight back (a meridian from a sphere's pole
stopping short of the other, out and back) encloses no (u, v) area, yet on a closed surface it
bounds all of it less a cut of none. The reader only read such a face when the slit already ran
pole to pole (and moved the sphere's frame onto it only then), so the 2 mm ball whose meridian
stops at 2.5 rad was refused for its empty loop.

The slit is now made the face's seams, so its loop bounds the surface's whole domain: on a
sphere, a revolution whose profile ends on its axis, or a spline closed round u that collapses
at both ends, the slit's meridian is run on to both poles, out and back (a sphere's frame put
on the slit first, whichever two points it joins); on a torus, the circle the slit lies along is
closed and the other circle through its start is the second seam. The seams on a sphere are its
own meridians (angle 0 on the equator), so their pcurves are exact lines on its form.

Tests: non_antipodal_seam_sphere_imports_as_a_whole_ball passes (its known-failing line goes);
seam_only_torus_imports_as_a_whole_ring adds a torus bounded by a slit along its tube.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 10:05:22 -04:00
jyvikoandClaude Opus 5.5 77f127c61e STEP import: a face bounded by seams alone runs its loop the other way, never turns over
A loop that uses each of its edges once each way (a whole torus within its tube and ring seams)
is the same set of uses run backwards, so it says nothing of the face's side. One written
clockwise in (u, v) turned the face over, against its same_sense: the torus came in inside out
with a warning. Such a loop is now reversed and the face keeps its side.

Test: seam_only_torus_imports_as_a_whole_ring, both orders of the two seams, volume 2π²Rr².

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 10:05:22 -04:00
brett19andClaude Opus 5.5 8ad306e695 boolean2d through boolean_2d, typed edge-vanishes, typed put-back refusal
boolean2d goes through api_brep::boolean_2d, SM_ERR_OFFSET_EDGE_VANISHES through
is_offset_edge_vanishes (solidcore#2016). A mitred round that cannot be put back
(solidcore#2027) is Error::Unsupported. The tests held for solidcore#1462, #1973,
#1980 and #1981 run again. copy_of stays as it is: results of offset_faces on a
brep_copy (NamingScheme::Notify) fail check_brep.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 06:57:15 -07:00
brett19andClaude Opus 5.5 6295833c45 Held flags re-read at SMLib 26cc451: none changes
Each held flag's fork site is untouched by 2fc375f..26cc451. The capi's
mitre rule (fork 9ba2b12) has no solidcore call to read yet; noted at
OVERFLOW_GOES_FIRST.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 06:50:04 -07:00
brett19andClaude Opus 5.5 14b1d19563 Pin 7: decide the new solidcore flags against the fork
On: fillet_corner_face_curve_halves, brep_edit_statuses_pass_on,
fillet_run_on_bspline_trims, offset_tangent_gap_statuses and ssi_alignment_statuses
(both soft like the fork since solidcore#2017). The other new flags are held back,
each with the fork's source as the reason.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 06:48:40 -07:00
brett19andClaude Opus 5.5 c26f9760de Merge develop b0d1ba345 into solidcore
SMLib moves to 26cc451 with develop. Merged cleanly; the kernel test
changes are develop's, moved or tightened.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 06:48:37 -07:00
brett19andClaude Opus 5.5 7e92386297 Merge fork/solidcore into the develop merge
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 06:48:07 -07:00
jyvikoandClaude Opus 5.5 b0d1ba3457 Kernel rig: the three spline walls' face counts wait for the one-wall decision; their volumes grade them
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 a250062c29 Kernel rig: 1985's enclosure is 78 x 77 (74 and 73 inside, 2 mm walls); its volume 38063.827 by hand
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 57edcf61ac Kernel rig: the oblique-cut round keeps its old grade until the new blend algorithm lands
Its seams grade needs the continuity check to skip the body the round is not on. Fillet cases
wait for the new algorithm.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 cd56cd3ad4 Kernel rig: 3841 is 168's rim touching its coin along a circle, and 4092's reduced recipe is its report less a flange clear of the failing join; the kept cases carry their sources
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 6c2a2f3959 Kernel rig: the oblique-cut round graded by its seams (tangent, not curvature-continuous); the flanged rhombus says what it tests (its reliefs stay apart at 60 mm)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 37a4c56477 Kernel rig: the three modelled-thread joins and the fine M48 graded on their volume (the basic profile's groove, Pappus)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 889a2f866c Kernel rig: the cut mirrored loft graded on the box its sections pin
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 8e0f6403c3 Kernel rig: the hub's six swept grooves graded on its volume (the revolved hub less each tube's part inside it)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 130f2adaf7 Kernel rig: the two G0 window patches graded on the box the part they close keeps
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 bfdb79418c Kernel rig: the flange beside the ledge graded on a volume range (the flange's two readings of its length)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 f6847c97c9 Kernel rig: the base with two adjacent flanges and a hole graded on its volume (base, bends and panels folded)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 9b4162a334 Kernel rig: the flanged rhombus graded on its volume (flat area x thickness, all four reliefs cut) and its walls' ends
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 27b7e202a8 Kernel rig: the two folded 72 degree trays graded on their volume (flat area x thickness) and the walls' reach
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 0bcc24ccd1 Kernel rig: the concave round into the peg's cylinder graded on a volume range (the torus it must add, the band it can't leave)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 49c7b982ef Kernel rig: the chamfered corner of the lipped shell graded on its volume (the chamfer's triangle through the wall)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 63dd6ae6f5 Kernel rig: the two 851 chamfers of 2 graded on their volume (the cone's sweep, and its union with the front edge's prism)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 4b512f69e3 Kernel rig: shell/3576 was the ladder's drafted box with rounds shelled, recipe for recipe; the ladder case grades it and carries #3576 and #3573
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 764719c538 Kernel rig: 391 graded on its volume (the shelled housing, sharp to rounded at the flange, less the letters' 0.6 mm deboss) and box
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 f2aba03f87 Kernel rig: 616 graded on its volume (the lid less its 0.5 mm-offset cavity, sharp to rounded concave edges) and box
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 fd9d159f4a Kernel rig: the arc-sided plate shell graded on its volume (sharp to rounded at the hole's bottom), faces and box
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 edb558bd12 Kernel rig: the shell-again case graded on its volume (the shelled box less the 0.5 mm-offset cavity in its walls) and box
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 be8e728cda Kernel rig: 545 graded on its volume (the frame less its 0.5 mm-offset cavity, sharp to rounded concave edges), its sealed pillar void and box
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 a53f1640e8 Kernel rig: the up-down squares shell graded on its volume (the columns less the 0.346 mm-offset cavity, sharp to rounded concave edges) and box
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 1893a50161 Kernel rig: 4567 graded on its volume (the revolved spline less its revolved 2 mm offset), faces and box
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 bdb321cdba Kernel rig: 745 graded on its volume (the end moved 1 mm plus the spline boss's exact area), faces and box
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
jyvikoandClaude Opus 5.5 ba75de350a Kernel rig: 4492 graded on its box and a volume range (the face's 19 mm sweep added, within the block's sides)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00