A twist about a straight path maps a profile circle centred on the path's
line onto itself, so its swept wall is exactly the cylinder. The skin
through the stations stayed within 3.9e-9 of it (6.6e-9 on the outer wall),
and a boolean with another body on that cylinder failed with status 1001
(solidcore#2184; the kernel's handling of a B-spline face lying on a
cylinder stays open there).
sweep_controlled now builds those walls exactly when the path is lines
along the profile's normal and there is no end scale or rails: a profile
whose every loop is such a circle is swept untwisted, and such holes in
another outer loop are cut as exact cylinders from the skinned sweep of
the rest. Other loops, and an axis-centred arc inside a loop of other
curves, are skinned as before; a failed cut falls back to skinning all.
Regression test in smlib_sweeps_tests.rs: #2184's tubes joined at 10, 16,
18, 20 and 30 degrees give one closed body of 11.5625 pi with cylinder
walls; a twisted hexagon with the bore keeps a cylinder bore.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEtwSrdwZxqTQp5MfnU
Conflicts kept both sides:
- eval.rs: main's thread-search change (#10227) moved into develop's eval_thread.rs; construction axis/point source bodies with the branch's fallible construction_state; main's identity shortcut in the branch's fallible placed().
- eval_more.rs: main's box helpers and beyond_cylinder_reach kept (main's cut and tap-marking code uses them), body_box meshing through Body::mesh.
- project3d/project.rs: SMLib meeting_edges kept; a face pick now takes its whole surface patch (#9009) through meeting_edges over a set of faces.
- frames.rs: main's split_move (#9660) with the branch's fallible to_local.
- ao.rs: main's draw_opaque with the branch's open-body triangles.
- dialogs.rs, move_preview.rs, viewport.rs: both sides.
- Generated files from main. Tests calling world_state() unwrap its Result.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
A primitive cut skips the sheets kernel::apart (exact bounds grown by the record tolerance)
finds clear of its tool; the bend check leaves the clear case to kernel::boolean, which answers
it from the same exact boxes with no intersection work. The mesh-box helpers are gone, and their
four lines leave xtask/mesh-decisions.txt (172 sites left).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
Each round runs whole to its section square to its edge at its setback (the owner's rule, at
least 1.5 r, scaled to the least at which the G1 fill is certified convex), and the hole is the
setback split: one patch per round and the triangle in three quadrilaterals, 15 faces, G1.
Outside the box the sections span the body is the three strips', so its volume is theirs within
that box's. A later r3 round at the mitred corner makes the body all three at once make
(7928.142563938, 15 faces), as the engine and the model-cache tests have it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
SMLib's setback corner takes a G1 fill only once certified convex, and refuses a setback too
short for that as SMLIB_ERR_NO_ROOM with SMLIB_FIT_SETBACK_AT_LEAST, the smallest setback that
builds. The kernel reads it (solidcraft-smlib binds smlib_blend_fit_size) and names it; the
Fillet dialog says it in plain words. Other room refusals keep their words. The r5 box corner
set back 5.5 is refused naming 5.962, which builds.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
smlib b7e83cd7c: origin/develop (SMLib pin 5e8c9c1) and origin/main.
Conflicts, both sides kept:
- Cargo.toml: solidcore's pinned solidcore dependency beside main's solidcraft-testkit.
- tests/KNOWN_FAILING_TESTS: solidcore's default-kernel list kept (refreshed from this
merge's run in a following commit); smlib's list for SMLib 5e8c9c1 becomes
tests/KNOWN_FAILING_TESTS.smlib.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
With swap_uv_keeps_analytic_definition (#2281) on, the fillet's cylinder in
box_and_fillet_have_stable_wire_records keeps the frame it was made with:
its origin moves along the axis from x = 0 to x = -20 (the edge runs x 0 to
40), with the same axis, radius 2 and trims; the last bits of the axis and
radius move with it. The same surface; turning that flag alone off gives
the old record back. Re-blessed with NATIVE_BREP_BLESS=1.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
solidcore#2223 (closed by #2302, under fillet_section_end_trim_at_creases):
the R25 rim and the x > 0 R2 corner arc rounded together at r 0.5 on the
plate 2 high take off 8.117810114 (the rim's 7.958674274526857 and the
corner arc's Pappus 0.15913583972191622) within 1e-7, 12 faces, valid. A
new test beside the tabbed-plate test, which shares its outline.
The tabbed-plate test gets past that pair and now stops at the two R2
corner arcs picked together: 1001 in trim_at_creases (cliff_overflow with
the crease trims off), though each builds alone (solidcore#2314). Its
known-failing line says so.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
With #2262 and fillet_gn_section_generator on, solidcore builds a
variable round as the union of its balls, so fillet_variable's
refusal from sync-2 (9f64cce54, solidcore#2250) comes off. Laws with a
corner stay refused (solidcore#430); a law whose balls fold is refused
by solidcore (NoRoomReason::BallsFold) and arrives as Error::NoRoom.
Against closed forms, solidcore and SMLib d01d7b0 agreeing to 1e-11:
- 1 to 3 along 30 mm removes 27.858907 against the balls' union's
27.857434 (great circles 27.898239); a law of one radius 2 removes
25.753574 against (1 - π/4) 4 · 30 = 25.752220: both 5.3e-5 over,
the solver's surface fit, as on the C++ kernel.
- the rig's 1 to 5 cone: 11956.21991 against 11956.22243 (2.1e-7).
- kernel tests: a_linear_radius_runs_from_the_start_end (18.5378),
variable_radius_on_a_box_edge, down_to_zero (22.5949),
taper_follows_the_room (the wedge 5245.68 against the balls'
union) pass.
The refused test becomes a_variable_round_is_the_union_of_its_balls
(the two closed forms, either direction, a folding law refused, a pick
miss named first). the_wedge_round_keeps_its_volume held 5223.0386,
measured before the fork's balls' union; it now takes its closed form
from removed_by_balls.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
The round's cylinder keeps the frame it was made on when it is turned (SMLib's SwapUV no longer
re-derives it): its origin sits at x = −20 on the same axis line, (x, 2, 8) along x, radius 2.
Same cylinder; one number in the record moves.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
SMLib's Ball corner is always the rational patch exactly on the sphere (owner ruling, blend
design §23), so the corner counts as an 'other' face beside the three cylinders and six planes.
The removed volume still checks the corner against r³ − πr³/6.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
A sphere split into two halves along a circle about its axis, each half covering a pole with no
seam, gets a seam per half from the first vertex of its loop to the pole. The circles between the
halves group their frames so they turn together, and when the two seams are not a whole number of
quarters apart no one turn fits both: the group kept its frames, a half's form ran past one turn,
SMLib's trim (SMLib and solidcore alike) across the form's end crossed the face, and the mesh
folded over the ball (a rotor's ball showed torn; its half had 196 times its area in triangles).
When no one turn fits the group, each spilling face is now turned on its own to start on a quarter
line. On the rotor file this also clears three other faces that were filled leniently and a
0.076 mm edge gap; regression test in step_in/tests.rs with the area and volume of each half.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
(cherry picked from commit b3188e005d427043b918267449c2336a1777e54f)
SMLib d01d7b0's capi builds the curvature section as the Gⁿ generator's order 2 at the
equal-area thumbweight (fork 6148773), taking off (1 - π/4) r² at a square corner. Our capi
port still built solidcore's blend-curve quintic (113/756 r²): a body every check passes,
off the closed form (862's box edge 7892.38 against 7845.49). solidcore has no Gⁿ generator
yet (solidcore#2250, port in progress as #2260), so Blend::Curvature now gives
Error::Unported, "not supported yet" with the issue, rather than another section. The
refusal comes off when the pin carries #2260 and 6148773 with fillet_gn_section_generator on.
The C++ closed-form case takes the equal-area volume; its solidcore twins are ignored until then.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
removed_by_balls integrates, in each plane square to a right-angled edge, the corner the union
of the balls leaves (by rays from the edge, the least entry over the balls), cut to the body's
section. The law with a corner through a middle point is its own test, listed as failing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On the round's rails the order-2 section takes off what the ball's circle does: (1 - pi/4) s^2 at a
square corner, first moment 0.0474559669443 s^3 (w = -0.5252123889). The kernel and engine tests
and the curvature rig cases take their volumes from it by their own methods; the pipe on the plate
from its own wedge (70.52878 degrees, w = -0.8544103493). The G2 corner patch's seam test is listed
until the corner step.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The hole and placement sections stay on main's Tools page and network locations on its General page; the geometry kernel section stays on the Design page. prepare_preferences refuses a kernel choice before main's checks. tests/KNOWN_FAILING_TESTS keeps solidcore's lines until rebuilt from a run on this tree.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
The process runs on one kernel, so `Choice` and the routing table (`Op`, `Overrides`,
SOLIDCRAFT_KERNEL_ROUTES) go, and every call asks `route::backend()`. SOLIDCRAFT_KERNEL takes smlib or
solidcore as before.
- The preference offers solidcore and SMLib. A saved `routed` loads as solidcore without an error;
asked for now, by ui.prefs or diagnostics.kernel, it is refused. Another unknown saved value stays
as saved and runs on the default, as it did.
- diagnostics.kernel answers {choice, environment}. `smlib` on a build without the C++ kernel, wasm
included, is refused as not available, never answered by the other kernel; a saved `smlib` there
says so on the status line and the preference page.
- The conversion between kernels stays: a body computed before the choice changed still needs it, and
so do the parity tests.
The notes' translations in 6 languages and the new message's are machine-written, not reviewed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
Main's thread.direction keys go with develop's thread hand, which replaced them. Vietnamese for the
messages develop added while main made vi a complete catalog. CGA and 1-bit themes set develop's
comb and section hatch colours. A ribbon button with a persistent effect is pressed only while its
tool runs, so persistent_ribbon_pressed alone decides how its effect is shown; other analyses stay
pressed while on. Two of main's ui tests listed as failing on SMLib, with why.
Gates: fixed thread tables become slices, one collapsed if, rustfmt.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
A polyline can be a chord off its edge, more than two edges are apart near a
tangent point. A pick exactly on a ball's rim took the straight edge the rim is
tangent to, and solidcore built a chamfer of that edge with a clean check.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
(cherry picked from commit c786db6bf4)
A polyline can be a chord off its edge, more than two edges are apart near a
tangent point. A pick exactly on a ball's rim took the straight edge the rim is
tangent to, and solidcore built a chamfer of that edge with a clean check.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
A leader off either surface is refused like a curve with no spline to follow. Tests: a traced rim
drawn on the circle and plane within tolerance, the same leader 1 mm off refused, and kernel bodies
with arcs through the production prepare against closed forms.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
world_state, view::bounds, home_camera and scene return Result on develop; new
main code takes that with ? or session_world. New fixtures carry the spline's
nurbs. ForeignCopy::of returns Result. occurrence_placement_with walks the path
with its moves, since the placement index holds pending_moves only.
The hlr port is separate and still to come: this commit does not compile as it
stands in crates/geom/src/hlr.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
main beb35029a (Release 0.29.0), develop 05f5e8601. Committed as resolved and
not yet compiling; fixes follow by layer.
Where the two sides could not both stay as written:
- Section caps: develop's stencil crossing count (with hatch by part) kept;
main's WINDING/NOT_CAP marking and its fs_solid_touch removed. main's #9407
test is kept and has to hold on the count.
- crates/kernel/src/prism.rs: develop's, which has no 3D prism boolean; main's
#6904 route has nothing to change there. Its test still has to be ported.
- Continuity legend: main's details card, with develop's G3/G4 classes.
- inspect.analysis one at a time: while main's "several analyses" preference is
set, turning one on leaves the others on.
- Model cache: FORMAT 8, since neither side's reader reads the other's records.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
KNOWN_FAILING_TESTS is now solidcore's, the default; KNOWN_FAILING_TESTS.smlib keeps
the C++ kernel's. A face copied out for untrimming now carries its tags on solidcore.
The profile test accepts either kernel's spans; ssi_corpus skips a kernel the
environment overrides.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
A loop that runs out along a chain of edges and straight back (a meridian from a sphere's pole
stopping short of the other, out and back) encloses no (u, v) area, yet on a closed surface it
bounds all of it less a cut of none. The reader only read such a face when the slit already ran
pole to pole (and moved the sphere's frame onto it only then), so the 2 mm ball whose meridian
stops at 2.5 rad was refused for its empty loop.
The slit is now made the face's seams, so its loop bounds the surface's whole domain: on a
sphere, a revolution whose profile ends on its axis, or a spline closed round u that collapses
at both ends, the slit's meridian is run on to both poles, out and back (a sphere's frame put
on the slit first, whichever two points it joins); on a torus, the circle the slit lies along is
closed and the other circle through its start is the second seam. The seams on a sphere are its
own meridians (angle 0 on the equator), so their pcurves are exact lines on its form.
Tests: non_antipodal_seam_sphere_imports_as_a_whole_ball passes (its known-failing line goes);
seam_only_torus_imports_as_a_whole_ring adds a torus bounded by a slit along its tube.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A loop that uses each of its edges once each way (a whole torus within its tube and ring seams)
is the same set of uses run backwards, so it says nothing of the face's side. One written
clockwise in (u, v) turned the face over, against its same_sense: the torus came in inside out
with a warning. Such a loop is now reversed and the face keeps its side.
Test: seam_only_torus_imports_as_a_whole_ring, both orders of the two seams, volume 2π²Rr².
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>