A twist about a straight path maps a profile circle centred on the path's
line onto itself, so its swept wall is exactly the cylinder. The skin
through the stations stayed within 3.9e-9 of it (6.6e-9 on the outer wall),
and a boolean with another body on that cylinder failed with status 1001
(solidcore#2184; the kernel's handling of a B-spline face lying on a
cylinder stays open there).
sweep_controlled now builds those walls exactly when the path is lines
along the profile's normal and there is no end scale or rails: a profile
whose every loop is such a circle is swept untwisted, and such holes in
another outer loop are cut as exact cylinders from the skinned sweep of
the rest. Other loops, and an axis-centred arc inside a loop of other
curves, are skinned as before; a failed cut falls back to skinning all.
Regression test in smlib_sweeps_tests.rs: #2184's tubes joined at 10, 16,
18, 20 and 30 degrees give one closed body of 11.5625 pi with cylinder
walls; a twisted hexagon with the bore keeps a cylinder bore.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEtwSrdwZxqTQp5MfnU
- Cut To the far side of a curved wall (#8634): the tool stops past the first crossing of the
face ahead of the profile; SMLib's whole bore is one face that a line crosses twice, so the
single-crossing rule found none and the cut took nothing.
- Clearing view analyses goes through refresh_display, as main's #10687 made the others, so an
open feature editor keeps OK and Cancel after Zebra.
- vi, a complete catalog on main, gets the setback-too-short message.
- fillets/KNOWN_FAILING: 4782's cause is now its continuity check (SMLib f916a8d builds the
expected volume).
- Known failing, as main's tests assume truck: the spline wall's spans as one mesh patch, a
hole touching an edge at a point leaving one body, and a copy of a copy's triangles matching
a fresh mesh.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
Develop's list was taken on develop alone. Main's code (tap-marking reach, cut and hole box
checks, join pieces, print faces, placed measuring, selection items, imported mesh payloads) and
the branch's own exact_edges and named_vertex use meshes too; three listed functions were renamed
by main (face_outline and plate_recesses into FaceSlice, paste into build).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
Conflicts kept both sides:
- eval.rs: main's thread-search change (#10227) moved into develop's eval_thread.rs; construction axis/point source bodies with the branch's fallible construction_state; main's identity shortcut in the branch's fallible placed().
- eval_more.rs: main's box helpers and beyond_cylinder_reach kept (main's cut and tap-marking code uses them), body_box meshing through Body::mesh.
- project3d/project.rs: SMLib meeting_edges kept; a face pick now takes its whole surface patch (#9009) through meeting_edges over a set of faces.
- frames.rs: main's split_move (#9660) with the branch's fallible to_local.
- ao.rs: main's draw_opaque with the branch's open-body triangles.
- dialogs.rs, move_preview.rs, viewport.rs: both sides.
- Generated files from main. Tests calling world_state() unwrap its Result.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
1213: the loft is a cubic skin through the five sections (ellipses between
them), not a torus; its volume 131601.597487935 by quadrature less the exact
rolling-ball removal 233.662461919 gives 131367.935026 (was a Pappus estimate
on a torus, 131360.148, at rel 5e-4).
4782: the section's area in closed form, 25 pi/3 - 5 sqrt(75) + 25, so
V = 630.2934873 (was a grid estimate, 630.293125).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
A primitive cut skips the sheets kernel::apart (exact bounds grown by the record tolerance)
finds clear of its tool; the bend check leaves the clear case to kernel::boolean, which answers
it from the same exact boxes with no intersection work. The mesh-box helpers are gone, and their
four lines leave xtask/mesh-decisions.txt (172 sites left).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
* claim: #9914
Co-Authored-By: Claude <noreply@anthropic.com>
* test: Move/Copy copy of a picked component (#9914)
Tests for a component picked in Move/Copy with Create Copy: it is copied as an
independent component placed with the move, the original stays, one undo removes
the copy; a body picked with Create Copy stays a body copy; a component picked
without Create Copy moves its bodies as before.
Co-Authored-By: Claude <noreply@anthropic.com>
* fix: Move/Copy copies a picked component as a component (#9914)
With Create Copy ticked and the component pick mode on (or a Browser component
row), a picked component is copied as an independent component (Paste New,
component.paste_new) and the copy moves by the move's transform (occurrence.move
in the world). Bodies picked still copy as bodies; without Create Copy a component
still moves its bodies. The copy and the bodies are one undo step.
Co-Authored-By: Claude <noreply@anthropic.com>
* fix: solid.move copies of components reply like a move and roll back (#9914)
A copying move with components replies as a solid.move does: the bodies' feature reply,
with the copies listed in occurrences. The bodies are mapped to their frame before any
copy is made. The solid.move help documents occurrences. A copy that fails part way
changes nothing and leaves no undo step.
Co-Authored-By: Claude <noreply@anthropic.com>
* fix: Move/Copy takes a picked component whether or not Create Copy is ticked (#9914)
A component picked in the component pick mode, or a Browser component row, goes into
the Move bodies input as a component, so Create Copy can be ticked after picking it.
Without Create Copy the component still moves its bodies. Not while editing an
existing move. The Browser model tests read the bodies the command would move.
Co-Authored-By: Claude <noreply@anthropic.com>
* fix: Move/Copy preview draws a copied component where the copy lands (#9914)
The fast preview took the component's bodies from the listed occurrences as well as the
bodies, drawn moved by the move, so a component copy previews at the moved place
instead of the scratch design's unplaced states. Test: a component-only copy and a
mixed copy preview where the copy lands.
Co-Authored-By: Claude <noreply@anthropic.com>
* fix: a copying move refuses bodies that are not a list (#9914)
With components, a bodies value that is not a list was ignored; without components it
is refused. It is refused now, before anything is copied.
Co-Authored-By: Claude <noreply@anthropic.com>
* test: an edited move never takes a component pick, through the click (#9914)
Clicks the component in component pick mode while an existing move is edited: the pick
stays a body. Fails when the editing condition is dropped.
Co-Authored-By: Claude <noreply@anthropic.com>
* fix: Move/Copy preview takes components only for a copy, and the mixed test can fail (#9914)
The engine refuses `occurrences` without `copy`, so the preview leaves
such params to the full preview too. The mixed-copy test now gives the
component a taller box, so its height shows the component was drawn.
Co-Authored-By: Claude <noreply@anthropic.com>
* docs: component_pick no longer needs Create Copy ticked (#9914)
Co-Authored-By: Claude <noreply@anthropic.com>
* test: a component picked with its parent is copied once (#9914)
Co-Authored-By: Claude <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* claim: #9284
* Localization: Russian "Close draft" reads as a draft analysis (#9284)
The report form's "Close draft" button said «Закрыть анализ уклонов»
(close draft analysis). It closes the report draft: «Закрыть черновик»,
the word the Russian catalog already uses for this draft.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Hole: a hole moved off the material says it removes no material (#10701)
A hole whose position, parameter or sketch point moves it off the part
cut nothing and said nothing: the feature had no warning, and a
parameter sweep listed the value as fine. A hole whose tool is clear of
every body it cuts now warns "the hole removes no material" ("1 of 2
holes remove no material" for several), as a pattern does of its
copies. The check compares boxes only, from the meshes the hole already
found its face on, so a large hole pattern costs no extra booleans.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Hole: a hole wider than the part says it removes all of it (#10702)
A through hole wider than the part removed the whole body with no
message, also when a parameter widened it later. The hole now warns
"the hole removes all of Body1" when a body it cuts is gone after the
cut.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The card's area is as tall as it was the frame before, and the first
frame laid the body out shorter than it ends up, so the scroll area
stayed short and the Hatch row (and Flip, for a tilted plane) was cut
off. The card may now grow to the height it is allowed.
The offset is shown to the design's length decimals and a tilted normal
to three places, as the pill shows them.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #10127
* Assemblies: a construction axis follows its component when the component rotates (#10127)
A construction axis or point built on a body now goes with that body when
Move/Copy moves or turns it. Each construction records the bodies its picks
lie on; the Move feature (not a copy) carries along every construction whose
bodies it all moved, with the same transform in the construction's component
frame. One that also reads something fixed stays where it is.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Markus Kaltenbrunner <kaltenbrunnermarkus@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
sheet.fold refused any fold whose bend zone wasn't a rectangle. It now
crosses the sheet's own outer edges, slanted or on any curve: the outline
is cut exactly across the zone, the panels keep their real outlines, and
flanges and other folds still go on them. The flat pattern's DXF keeps the
curve as drawn. A sharp corner in the zone stays refused.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
A permission question counted as one of SolidCraft's own tools when its title merely contained
"solidcraft". Now the whole title must be a tool of the chat's own MCP server, named as
`mcp__solidcraft-app__<tool>`, and its kind must be `other` or not given. Anything else goes through
the user's mode and remembered answers, or is asked in the panel.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Rig (fillets/KNOWN_FAILING.solidcore): the two 851 rows develop now rounds with their tangent
chain fail 1001 as on SMLib; the pipe on a plate's curvature round is graded to 5e8c9c1's
section, which solidcore has yet to port. Tests (KNOWN_FAILING_TESTS): main's box STL and
boss-torus tests, as on SMLib; the box-corner test and four C++ comparisons that expect
5e8c9c1's Ball corners and rounds.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
* claim: #10704
* Section Analysis: view.pick skips edges and vertices in the removed half
near_edges now applies the same section `kept` predicate the mouse picker
uses (viewport::pick, since #6722), so an agent picking through view.pick /
ui.pick no longer gets edges and corners the user cannot see.
---------
Co-authored-by: Dahak Builds <dahakbuilds@users.noreply.github.com>
A client could connect and send nothing, or only blank lines, and hold one of the 16 connection
seats for as long as it liked. All reads before the token now share one five-second deadline; the
connection is then closed without a reply. An authenticated connection may idle as before.
`solidcraft-cli mcp --connect` used to open a connection at start and hold it until the first tool
call. It now only checks that the app is there, and the first call connects.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
On Windows the token file is restricted with `icacls`, which may not finish in time (#6145). That
counted as success everywhere, and is safe in the default folder, the user's own local app data.
A folder picked with SOLIDCRAFT_CONTROL_DIR may be readable by others, so there a timeout now
removes the still empty file and returns an error. The default folder behaves as before. The
decision is a small function of its own, tested without running icacls.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Each round runs whole to its section square to its edge at its setback (the owner's rule, at
least 1.5 r, scaled to the least at which the G1 fill is certified convex), and the hole is the
setback split: one patch per round and the triangle in three quadrilaterals, 15 faces, G1.
Outside the box the sections span the body is the three strips', so its volume is theirs within
that box's. A later r3 round at the mitred corner makes the body all three at once make
(7928.142563938, 15 faces), as the engine and the model-cache tests have it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
SMLib's setback corner takes a G1 fill only once certified convex, and refuses a setback too
short for that as SMLIB_ERR_NO_ROOM with SMLIB_FIT_SETBACK_AT_LEAST, the smallest setback that
builds. The kernel reads it (solidcraft-smlib binds smlib_blend_fit_size) and names it; the
Fillet dialog says it in plain words. Other room refusals keep their words. The r5 box corner
set back 5.5 is refused naming 5.962, which builds.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
A design's lock file went through the same writer as the design, which follows a symbolic link
so a linked design is saved where it lives. The lock now has a writer of its own that refuses
anything at its path but a regular file and replaces only that name. Reading a lock takes only a
regular file and no more than a lock's size. Saving a design through a link works as before.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
smlib b7e83cd7c: origin/develop (SMLib pin 5e8c9c1) and origin/main.
Conflicts, both sides kept:
- Cargo.toml: solidcore's pinned solidcore dependency beside main's solidcraft-testkit.
- tests/KNOWN_FAILING_TESTS: solidcore's default-kernel list kept (refreshed from this
merge's run in a following commit); smlib's list for SMLib 5e8c9c1 becomes
tests/KNOWN_FAILING_TESTS.smlib.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
With swap_uv_keeps_analytic_definition (#2281) on, the fillet's cylinder in
box_and_fillet_have_stable_wire_records keeps the frame it was made with:
its origin moves along the axis from x = 0 to x = -20 (the edge runs x 0 to
40), with the same axis, radius 2 and trims; the last bits of the axis and
radius move with it. The same surface; turning that flag alone off gives
the old record back. Re-blessed with NATIVE_BREP_BLESS=1.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
Also points the links at tangency-labs/solidcraft. The old list asked for reports of file access outside the allowed folders, and for crashes.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Selectable transcript labels do not request TextEdit focus, so the global
clipboard handler also copied, cut and pasted selected CAD geometry while
the user worked with chat text.
Keep keyboard ownership with the visible chat after a pointer press until
the next press outside it. Release it when the panel is hidden, and do not
use selections from other native viewports as a global CAD shortcut guard.
Cover real label selection, clipboard events, fallback key events, quick
select-all, hidden panels and deliberate return to the CAD viewport.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #10689
Co-authored-by: Cursor <cursoragent@cursor.com>
* Edit Hole: seed the face where the hole is now (#10689)
Project the stored position onto the drilled face along the hole direction when opening the editor, matching evaluation, so OK works after a parameter moves the face.
Co-authored-by: Cursor <cursoragent@cursor.com>
---------
Co-authored-by: Cursor <cursoragent@cursor.com>
solidcore#2223 (closed by #2302, under fillet_section_end_trim_at_creases):
the R25 rim and the x > 0 R2 corner arc rounded together at r 0.5 on the
plate 2 high take off 8.117810114 (the rim's 7.958674274526857 and the
corner arc's Pappus 0.15913583972191622) within 1e-7, 12 faces, valid. A
new test beside the tabbed-plate test, which shares its outline.
The tabbed-plate test gets past that pair and now stops at the two R2
corner arcs picked together: 1001 in trim_at_creases (cliff_overflow with
the crease trims off), though each builds alone (solidcore#2314). Its
known-failing line says so.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
* Holes and cuts: count the bodies a cut works on in the cost tests
A test helper, cut_work, adds a feature at the end of a design and reports
how many bodies its cut ran booleans on and which bodies it left exactly
as they were (same geometry, key and face names). A new test pins that a
cut still goes through the boolean where its tool touches a face, runs
along an edge, passes a hair beside a body or drills into a dome.
The sheet metal hole (#10226) and cosmetic thread (#10227) work reuse the
helper for their own shortcuts.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Holes and cuts: leave bodies the tool cannot reach untouched without a full cut
A cut ran a whole boolean against every body of its component, and for a
body its tool does not reach that boolean only handed the body back: about
7 ms per body, so a hole in a design of 200 blocks took 1.3 s. Now a body
whose box lies clear of every tool's box is left as it is. Both boxes are
their meshes' grown past how far the exact faces can curve out from them,
the same test sheet metal cuts already use, so a tool that touches a body,
grazes it or drills into a dome still goes through the boolean. Bodies
shown in another frame, mesh bodies and Intersect (which removes the
bodies it misses) are unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Cosmetic tap markings: look for their cylinder only in nearby bodies
A tap marking (a Thread feature, or the marking of a tapped hole) looked
for the cylinder at its point in every body of the design, and each
search meshes the body afresh: with many bodies and many markings that
grew quadratically (200 markings on 200 cylinders: 33 s of a 33 s run).
A body is now passed over when its box, from the mesh it keeps and
grown past that mesh's deflection, lies farther from the point than the
search itself would look (a twentieth of the body's size, plus its own
mesh's deflection). The search finds no face there, so the marking and
everything else stay the same.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The eight UpstreamFixes flags new since adf26ddbc, all on; HELD_BACK stays
empty: none is broken by the flag rule.
Toggled on the rig on solidcore (all eight off against on, then each alone
off on the 43 cases whose volume moved): 982/1014 pass either way, no case
changes status, the largest volume change is 1.35e-8 relative.
- fillet_overflow_trim_at_creases (#2279): 19 cases, up to 1.35e-8. The
sloped basin rounds move toward their closed forms (r4 1.24e-8 -> 2.1e-10
off, r4 2 edges 6.1e-9 -> 4.3e-10); 4055's bar chamfer over a joined pin
moves from 2e-11 to 1.35e-8 off its closed form, inside its tolerance.
- face_shrink_bound_on_knot (#2281): 9 cases, at most 5.7e-13.
- swap_uv_keeps_analytic_definition (#2281): 11 cases (tapered booleans,
shells, an oblique cone rim), at most 3e-14.
- face_trim_curves_kept_where_exact (#2281): 10 cases, last bits only.
- offset_updates_result_tolerances (#2297),
fillet_section_end_trim_at_creases (#2302, solidcore#2223),
boolean_coincident_strip_drops_crossing (#2285),
cone_iso_circle_at_axial_height (#2289): no rig case moves.
No boolean, shell or offset case moves by more than 5.7e-13. The tangent-peg
cases of solidcore#2256 keep their statuses, volumes and checks bit for bit.
Rig time 1433 s off, 1344 s on; 3368-two-faceted-prisms-cut-then-joined
timed out once in the flags-off rig and passes alone with them off in 152 s
at the same volume.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
* claim: #5388
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Sketch: rebuilding a projection keeps the sketch's own curves on its points (#5388)
When a projected face changed shape, update_link rebuilt the link with
drop_link_entities, whose remove_points also deleted every curve using a
projected point: a circle the user drew on a projected hole's centre vanished,
and the extrude on it lost its profile. Before the projected points go, the
sketch's own curves on them move to a free point at the same place.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Selecting a plane in the view now draws the grid on it, so the plane a
sketch would use shows before the button is clicked. Deselecting returns
the grid to the ground.
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>