Commit Graph
3219 Commits
Author SHA1 Message Date
Brett Lawson d477d76d92 Merge ws/blend: fillets, chamfers, setbacks and variable fillets on solidcore 2026-10-28 23:55:54 +01:00
Brett LawsonandClaude Opus 5.5 525d8e1e61 Kernel: fillets and chamfers on solidcore
core/blend.rs ports the capi's composition round the fillet executive
(smlib_ops.cpp blend_call, round_edges, chamfer_offsets/chamfer_edges,
chamfer_radius, blend_failure, setbacks_fit, law_ok/law_pinches/law_along,
finish; smlib_pick.h): picking edges and corners by point with the
NoMatch/Ambiguous rule, per-edge kinds and sizes, bevelled chamfer corners,
N x N convex corner setbacks (CornerRefused otherwise), the B-spline
variable law, and the capi's errors (Argument, NoRoom, NoEffect, Empty,
NotSolid, SMLib statuses). ops.rs routes fillet, chamfer, blend,
blend_setback, blend_setback_open, fillet_variable and chamfer_sides on
Op::Blend as the boolean family is routed.

What the capi asks of fork-only SMLib that solidcore lacks is "not
supported yet", refused where the capi first reaches it: curvature blends
(fd3b6a7), two-distance and angle chamfers (f653ac9), open corners
(60af574), laws with a corner (6eecf04), and rails leaving their face, which
the fork may build over the cliff (8ba4667).

core/blend_tests.rs checks closed forms (one edge, all twelve edges, a
chamfer, Pappus on a cylinder rim, a setback corner, a linear variable
round, the errors) and, with native, C++ parity on volume, counts and
faces by kind, or the same error.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgExNEwfR9CX2RAzp2Pt
2026-10-28 23:55:16 +01:00
Brett LawsonandClaude Opus 5.5 ce5de8bcfe Sphere measurement cases wait on solidcore#1437 (trim_boundary_seam_wrap at the poles)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgExNEwfR9CX2RAzp2Pt
2026-10-28 23:45:12 +01:00
Brett LawsonandClaude Opus 5.5 86e4226ae7 solidcore backend: every UpstreamFixes flag on, and the ignored cases name their solidcore issues
Every opt-in fix of an upstream SMLib defect is a fix, so all are on; a test
fails when a solidcore bump adds a flag that is not. The face-properties
accuracy cases wait on solidcore#1435, the census on #1436, the body check on
#1419.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgExNEwfR9CX2RAzp2Pt
2026-10-28 23:37:22 +01:00
Brett LawsonandClaude Opus 5.5 992a2f64c8 Merge ws/measure: mass properties, area, bounds, distances and checks on solidcore
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgExNEwfR9CX2RAzp2Pt
2026-10-28 23:35:26 +01:00
Brett LawsonandClaude Opus 5.5 1ba63d464f Kernel: the Measure and Check families on solidcore
core/measure.rs composes smlib_measure.cpp on solidcore's ports: mass properties through
SmBrep::ComputePreciseProperties directly (the [1e-8, 1e-1] envelope, material regions, the
face-by-face sheet fallback, moments about the box middle moved to the centroid), the area face
by face, the tight box, the edge/face gap, and IsManifoldSolid. solidcore has no
SmApiBrepMaterialCensus and no topology-level AssertValid, so solid_count and check say
"not supported yet". Each public method routes as Brep::volume does; the table is unchanged.

core/measure_tests.rs checks the primitives against the closed forms (now shared in
measure::closed) and, with SMLib built, against the C++ kernel. The cases solidcore misses are
ignored with their cause: face properties at 1e-8 (no knot-span splitting, fork 08d9a14),
solidcore#1431, the census and AssertValid.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgExNEwfR9CX2RAzp2Pt
2026-10-28 23:33:30 +01:00
Brett Lawson 567198a358 Merge ws/boolean: booleans, unions, 2D booleans and imprints on solidcore 2026-10-28 23:32:59 +01:00
Brett Lawson 3a9bed4611 Merge ws/pref: the Geometry kernel preference and diagnostics.kernel tests 2026-10-28 23:32:30 +01:00
Brett LawsonandClaude Opus 5.5 5cf4cb2121 Kernel: booleans, unions, 2D booleans and imprints on solidcore
Op::Boolean's operations get a solidcore backend (core/boolean.rs), each the
fork capi's logic round SM_API: smlib_boolean_with's operand copies
(SmApiBrepCopy), IsManifoldSolid of the inputs and finish's closed-result
check with non-manifold results allowed (closed_nonmanifold);
smlib_boolean_union_all's balanced pairwise tree; smlib_boolean2d's
SmPrimitiveCreation::Boolean2D with its no-face early return; smlib_imprint's
SmApiBooleanWithOptions(SM_BO_IMPRINT, keep tool) and its no-cut result.
ops.rs routes each like Brep::volume. The routing table is unchanged.

Tests: ten cases against analytic volumes (union, intersection, through slot,
flush notch, void, cylinder hole, 3x3 union_all, disjoint, sphere less a cap,
imprint), every result exported to a validated record; with SMLib built, the
same on C++ gives equal volume, counts and faces by surface kind.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgExNEwfR9CX2RAzp2Pt
2026-10-28 23:32:19 +01:00
Brett LawsonandClaude Opus 5.5 22351d84cc Preferences: a Geometry kernel setting, applied through diagnostics.kernel
Preferences > Design gains a Geometry kernel segmented control (Routed, SMLib,
solidcore), saved with the other preferences and applied through the
diagnostics.kernel command at startup and when it changes, so an agent's
choice in between stands. When SOLIDCRAFT_KERNEL overrides it the control is
disabled and a hint says the environment variable wins. ui.prefs refuses an
unknown geometry_kernel.

diagnostics.kernel now refuses a `choice` of the wrong type instead of
reading it as no choice. Tests cover the routing report, setting the choice
(skipped under SOLIDCRAFT_KERNEL), unknown and hostile choices, and put the
choice back to routed however they end. The command's label and the new
strings are in a pending locale file, complete for ar, he, ja and zh.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgExNEwfR9CX2RAzp2Pt
2026-10-28 23:31:56 +01:00
Brett LawsonandClaude Opus 5.5 976acfd76c Conversion tests: each ignored case names its solidcore issue (#1431, #1432, #1433)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgExNEwfR9CX2RAzp2Pt
2026-10-28 23:18:10 +01:00
Brett Lawson e1be233e89 Merge ws/convert: solidcore bodies to and from the flat arrays 2026-10-28 23:17:06 +01:00
Brett LawsonandClaude Opus 5.5 3eeb83433d Kernel: solidcore bodies to and from SMLib's flat arrays, and its primitives
core::to_arrays ports FlatFromBrep (through BrepData::from_brep: same ids, face/edge/vertex
order, analytic kinds with radian ranges, NURBS forms, SMLib's own UV trims and tolerances);
core::from_arrays ports Validate, FlatToBrepData and BrepFromFlat (MakeTopologyFromData,
healing unless SOURCE says SMLib wrote the arrays). Cylinders, spheres, cones and tori are made
in solidcore when Op::Primitive routes there, like boxes. cpp_arrays copies every array, so
Brep::core gets what the import needs; flat.rs gains WIRE_EDGE_NURBS_FORM.

All six primitives export to records that validate and check, and their arrays match the C++
kernel's (ints exact, reals 1e-12). Where solidcore lacks a port the C++ calls
(SmCircle::IsNurbCurveCircle, SmCylinder::IsNurbSurfaceCylinder, SmTorus::IsNurbSurfaceTorus,
SmSurface::ApproximateSurface, SmShell::IsInnerShellOf) the conversion says "not supported
yet"; the round trips that need them, and a sphere's volume at 1e-8 (SM_ERR in solidcore), are
ignored with the reason.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgExNEwfR9CX2RAzp2Pt
2026-10-28 23:16:31 +01:00
Brett LawsonandClaude Opus 5.5 12ace49736 diagnostics.kernel: read and set which kernel answers, and see the routing table
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgExNEwfR9CX2RAzp2Pt
2026-10-28 22:53:26 +01:00
Brett Lawson ff909b58d5 Merge ws/rig: kernel-cases --kernel smlib|solidcore|both 2026-10-28 22:48:08 +01:00
Brett LawsonandClaude Opus 5.5 8c12073be7 Kernel: a solidcore backend behind crates/smlib, routed per operation
crates/smlib's Brep now holds a body of either kernel and converts it for the
other through the flat arrays the first time an operation routed there needs
it. route.rs is the routing table (every family on SMLib until the rig shows
parity), with SOLIDCRAFT_KERNEL=smlib|solidcore|routed and a preference to
override it; a failing solidcore call fails, with no fallback to C++. core.rs
runs every solidcore call on one process kernel under a panic guard, and
wires box, volume and counts. solidcore is a git dependency pinned by rev,
the web app links with an 8 MiB stack, and cargo-deny allows its git source.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgExNEwfR9CX2RAzp2Pt
2026-10-28 22:48:08 +01:00
Brett LawsonandClaude Opus 5.5 d7224d4c65 kernel-cases: --kernel smlib|solidcore|both, each case's process on SOLIDCRAFT_KERNEL, and the two side by side
A solidcore run keeps results.json, dumps/ and report.md in <out>/solidcore/; both runs every
case on each backend in one job pool, keeps docs/kernel-cases.md as the SMLib report and writes
docs/kernel-cases-backends.md and <out>/backends.json (cases that differ first). The default
(smlib) is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgExNEwfR9CX2RAzp2Pt
2026-10-28 22:46:11 +01:00
Brett LawsonandClaude Opus 5.5 21eba6a381 claim: solidcore backend for develop
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgExNEwfR9CX2RAzp2Pt
2026-10-28 22:30:05 +01:00
jyvikoandClaude Opus 5.5 cfaf4ab557 Kernel rig: the reason each refused sheet-metal, sweep, crash and ladder case must be refused for
Ten `refused` cases outside the fillets had no `refusal` since #8445 made one required. Each
was run; its refusal is the right answer for the reason its method gives, and that reason is
now its `refusal`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 16:59:05 -04:00
jyvikoandClaude Opus 5.5 97a31c0c0c SMLib: the prebuilt where a union that seals a void keeps its enclosing shell first
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-28 16:46:06 -04:00
jyvikoandClaude Opus 5.5 ee4d4b5a55 STEP import: a round face off its frame's quarter lines is formed within one turn
A cylinder, cone, sphere or torus face of less than one turn that does not
start on a quarter line of its frame, with more than three quarters left to
it, spilled into a fifth quarter of the quarter grid: its NURBS form ran past
one turn and SMLib refused the solid ("an edge lies 12-16 mm off the face's
surface"), which came in as surfaces.

Before its edges are labelled on it, such a face's frame is turned about its
own axis (brep::form::turned: the same surface, its angle parameter measured
from further on) so it starts on a quarter line and its form spans four
quarters. Round faces a circle edge about both their axes joins share one
quarter grid, so they turn together by one angle, chosen so every one of them
fits in four quarters; a group with a face that cannot be turned keeps the
file's frames. Each face's box on its label is measured once and reused.

Engine assembly: PULLEY_WATER_PUMP and MOUNT_SCAVENGE_PUMP_01 now come in as
solids (refused 5 -> 3); Poppy Humanoid unchanged (4).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-28 16:40:54 -04:00
jyvikoandClaude Opus 5.5 2dd505d836 kernel tests: rustfmt
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-28 16:13:50 -04:00
jyvikoandClaude Opus 5.5 d0081b235e kernel: a placed copy is planned as its original, moved, as its mesh already is
A body showing another's display (a later instance of a part an assembly
places several times) took that part's mesh, placed, but was planned for
the GPU viewport on its own: Poppy Humanoid's display planned all 247
bodies where its meshes came from 94 parts. Body::mesh_plan now plans the
original once (kept with the shared display, as its meshes are) and moves
the plan, so the copy's display is the part's triangulation, as its mesh
is. Body::unmeshed_faces needs no case of its own for a copy any more.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 16:13:50 -04:00
jyvikoandClaude Opus 5.5 c1713994f9 Body::unmeshed_faces counts on the coarse plan, without making the mesh
The STEP import's mesh check made a coarse mesh of every part (planned,
evaluated, its seams and smooth edges flagged) only to see which faces had
triangles, and threw it away. A face has triangles in the evaluated mesh
exactly where its plan has a triangle on its own nodes, so the count is now
read off the plan (TessPlan::faces_with_triangles, the condition evaluate
keeps a triangle by).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 16:13:50 -04:00
jyvikoandClaude Opus 5.5 25642b6d26 STEP import: a part's later instances in a window wait for its first, not end the window
A window of planned solids ended at the second instance of a part not yet
read, so an assembly that places a part several times in a row converted
in windows of one or two solids, each waiting for its slowest read before
the next began (Poppy Humanoid: 14 windows of 1 to 30 reads on 8 workers).
The window now always takes MAX_WINDOW solids; an instance of a part an
earlier job of the window reads is placed after that job, from the
orientation it found, as the next window would have placed it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 16:13:50 -04:00
jyvikoandClaude Opus 5.5 025344dee2 A refused face is tinted as well as ringed
A face whose boundary is only two small circles (a tube's bend) did not show where it is from
its ring alone: its triangles are now drawn over in the error colour at 35%, depth-tested like
the selected face's tint, under the ring.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-28 15:58:06 -04:00
jyvikoandClaude Opus 5.5 090fcec6ca A refused face is ringed in the error colour while the window points at it
While a feature dialog says that a part's face can't be used for modelling, and while the
pointer is over that part's "needs repair" row in the browser, the face is outlined round its
edges in the theme's error colour, over the shading and dimmed where the model hides it, like
the selection's outline; it goes when the message or the hover does. Show face now frames the
face without selecting it (a selection in a dialog becomes its pick and cleared the message).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-28 15:58:06 -04:00
jyvikoandClaude Opus 5.5 c15c394433 Open and import card: the step marks share one box, size and stroke
The current step's spinner was egui's, sized to the text and drawn as a small partial arc next
to the tick and the ring. All three marks now share one box the label's height, centred on its
capitals (the first glyph's ink, not the line box), at the same left edge: the tick, a turning
three-quarter circle and the ring are the same diameter, the spinner with the tick's stroke,
whole at 100% and 200% UI scale.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-28 15:58:06 -04:00
jyvikoandClaude Opus 5.5 d3b8c3dc5b Browser: Repair Part is planned under #8371
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-28 15:58:06 -04:00
jyvikoandClaude Opus 5.5 1880117368 A part the modelling kernel refuses is named, with what is wrong and what to do
SMLib's import says only that it refuses a body, so the kernel now keeps a structured
refusal with the body's SMLib cache (Body::smlib_refusal / smlib_refused: the first face SMLib
refuses on its own, found by sending each face alone, and its surface kind). A STEP import sends
each part's first instance as an operation would, notes the parts that need repair in the
import report, and the browser marks them ("VALVE_COVER_01: needs repair").

A feature dialog whose operation fails on such a part says, instead of the kernel's words and
an issue report: "Couldn't join to VALVE_COVER_01. One of its rounded faces can't be used for
modelling.", with Repair part (body.repair, declared as planned, also in the part's menu) and
Show face (selects and frames the face).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 15:58:06 -04:00
jyvikoandClaude Opus 5.5 920acc5279 STEP import: the feature's warning says in words what became of the parts
The kernel's import warnings get a structure (ImportReport: the file's parts, how many came
in as solids, and each warning's kind, part, faces and count; the reads' notes are typed as
repairs or faces left out). The Import feature's result carries it (and the model cache keeps
it), and the timeline tooltip and the status line after an import word it from the catalogs:
"Imported 40 of 43 parts as solids. 1 part couldn't be made into a solid and is shown as a
mesh. 3 faces couldn't be repaired and are missing." with what may help. Entity numbers and
the kernel's wording stay in Copy Warning Message, which now lists every warning.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 15:58:06 -04:00
jyvikoandClaude Opus 5.5 b7d813bd6c Open and import card: three plain steps instead of a status line
An open or an import lists its three steps (a STEP or IGES file: reading the file, checking
and repairing the parts, building the model; a design: reading, rebuilding the features,
preparing the view), the ones done ticked, the current one with a spinner the height of its
text and how far it is, and the bar for that step. The other file operations keep their one
line, led by the same small spinner. New kit control: ui_kit::steps.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 15:58:06 -04:00
jyvikoandClaude Opus 5.5 baa44fc64b Fillet dialog: a setback the field flags is not refused again under the dialog
The Setback field's "More than 2 mm" is the message; the kernel's refusal of
that setback shows no text under the dialog and no Create Issue (it is the
user's value to change), and its raw text stays in Copy Details.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-28 15:49:25 -04:00
jyvikoandClaude Opus 5.5 06fbcdfec6 Fillet dialog: Setback shows its default as a length and flags one too small before OK
The Setback field reached the command and the kernel used it: on a box corner
with r 2 rounds a 3 mm setback built, while 1.5 and 2 mm failed inside SMLib
(status 1001), shown as "could not be built" with nothing saying why. A setback
must reach past where the rounds meet without one (the radius on square faces).

The kernel now refuses such a setback before SMLib runs, naming the least
(the pre-check of aa2b09bc2 on fillet-kernel-cases), and exposes that least
(fillet_least_setback). The field shows the default, 1.5 x the radius, as an
editable length that follows the radius until the user types one, and outlines
a value at or below the least in the warning colour with "More than 2 mm"
under it (ui_kit::checked_row, warning_caption). Its hover text says what a
setback does, the default and the least.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-28 15:49:25 -04:00
jyvikoandClaude Opus 5.5 c33bae8701 Section cap: only closed bodies take part in the crossing count
An open body (a surface body, a mesh that does not close) has no inside: its faces counted
with the rest took the cap from the closed body it lay in or behind. The body's closedness,
which the kernel knows (`ModelBody::is_closed`: no shell left open, a mesh body every side of
which two triangles share), goes with it to the renderer (`SceneMesh`, `PlannedBody`,
`InstancedMesh`, a block's closed runs, the loose open triangles), and the count draws closed
bodies only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-28 15:43:35 -04:00
jyvikoandClaude Opus 5.5 33acb6dc39 Section cap by crossing count: a body touching the cut body no longer shows through
The cap went to the nearer surface by depth: a back face (the cut body's far wall) or a front
face. Where bodies touch, the cut body's far wall and the other body's face lie at one depth,
and rounding settled each pixel either way: the other body showed through the cap in specks,
stripes and triangles (an engine's sleeves in their bores, pins in their bosses). The stencil
now counts the faces behind the plane instead, from a base of 128: a back face adds one, a
front face takes one away; above the base, the plane is inside a body and the cap is drawn in
the nearest back face's cut colour, at the plane's depth. Elsewhere the faces draw as without
a section, an open body's inside lit rather than hatched. All four draw paths (built, planned,
instanced, instanced flat).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-28 15:43:35 -04:00
jyvikoandClaude Opus 5.5 cd4f725729 STEP import: a surface model's closed shell beside a sheet is a solid of its own
A SHELL_BASED_SURFACE_MODEL with both closed and open shells (Poppy Humanoid's
thighs: the part and a two-face sheet on it) came in as one body, open for the
sheet's edges. Each closed shell is now read as an item of its own, a solid in
the model's colour, and the model's open shells as a surface body.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-28 15:42:23 -04:00
jyvikoandClaude Opus 5.5 61a1f8bf26 STEP import: a face's NURBS form ends where its boundary does, within its tolerance
A face's form covers the quarters of its box, and the box is the extent of its
boundary's points, which run past a quarter's end by as much as the edges lie
off the surface (nanometres in a file of 1e-11 mm digits). A half tube's form
then took the quarter past each end and went round the whole tube, which SMLib
does not take for a torus: 16 parts of an alternator came in as meshes. An end
within the tolerance of a quarter's end (the angle on the face's widest circle
there) is now on it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-28 15:42:23 -04:00
jyvikoandClaude Opus 5.5 3fd5e138ce kernel: rustfmt
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-28 15:13:23 -04:00
jyvikoandClaude Opus 5.5 97721ad05f Fillet setbacks not past where the rounds meet are refused naming the least; the rig grades a refusal by its reason
A corner setback must reach past where the corner's rounds' contact lines
meet without one (smlib_blend_setback); short of it SMLib failed with its
own status (1001). The kernel now refuses it before SMLib runs, for the
rolling-ball corner (fillet_setback) and the curvature corner
(fillet_g2_corners) alike, naming the least: on each face at a corner of
planar faces and straight edges the two rails, r tan(psi/2) from their
edges, cross (d2 + d1 cos alpha) / sin alpha along an edge (r on faces
square to each other). Other corners stay SMLib's to refuse.

The rig's `refused` cases now name the reason (`refusal`, a part of the
message, required), so a failure for another reason no longer passes; a
`solid_or_refused` case may name one. Fillets: the setback cases and
783, 3435 pass; 1390, 896, 4782 past-a-full-round and the no-tangent-chain
case are refused for an unclear reason and fail.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 15:13:23 -04:00
jyvikoandClaude Opus 5.5 762262953f kernel rig: the owner's fillet failures of 2026-10-28 as fillet cases, with the option combinations
22 hand-written cases in tests/kernel-cases/fillets:
- 1207-fillet-bar-top-edge-and-boss-arc-together (r2, r1, fit reduce,
  fit taper, curvature corners): a bar's top edge and the partial base
  arc of a boss standing out over the bar's side rounded together. The
  rounds' volumes away from the corner, the corner patch within (2r)^3.
  SMLib's 3x2 mixed corner fails here (1001) until the fork's fix.
- 1207-fillet-bar-top-edge-after-boss-arc-round (r2, r0.5, no tangent
  chain): the edge rounded after the arc; r0.5 fails SMLib's check.
- 9-fillet-corner-*: setbacks not past the radius refused (rolling and
  curvature corners), the curvature corner at r1, and the curvature
  corner with reduce and taper fits (not supported yet).
- 4782-fillet-*: full rounds (two end verticals at half the width, exact,
  reduce, taper), a round at half the wall, radii past the full round
  (refused; reduce gives the full round) and a round wider than both
  faces (built by subtraction).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 15:13:23 -04:00
jyvikoandClaude Opus 5.5 29744b8115 Preview: the ghost leaves out the surface the changed body keeps
The old body was drawn as ghost whole, behind the new body by a fixed depth bias. A curved
face the change re-meshes (a boss face whose boundary a fillet moves) has a new triangulation
that crosses the old one by up to the chord error, far past that bias, so the ghost showed
through it in slivers. Old triangles lying on the new body's surface are now left out; the
removed material is still shown.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 15:02:54 -04:00
jyvikoandClaude Opus 5.5 912bccef65 Isocurve Analysis: faces on one surface share their lines
The held parameter was spaced over each face's own trimmed (u, v) box, so the pieces of a
face split by a boss showed different lines that missed each other at the split. The lines
now sit on a ladder of the surface: a bounded parameter's range in count + 1 steps, a linear
one (a plane's, a cylinder's or cone's axis) at a round world spacing from the world origin.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 15:02:54 -04:00
jyvikoandClaude Opus 5.5 e4844753cb SMLib: the prebuilt with a torus or sphere keeping its NURBS form, and the concave mixed fillet corner
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-28 14:30:19 -04:00
jyvikoandClaude Opus 5.5 739153d3dc Fillet dialog: one option model, plain labels, refusals in plain words
The dialog follows the options solid.fillet takes together: If too large
(fit) and Corners show only for Constant radius, a curvature corner and a
fitted radius rule each other out and the other resets visibly, and an
option that does not apply is never sent (it used to send `corner: g2`
with Reduce or Taper and get refused). Variable Radius shows only for the
types that take it; the Advanced section held only the fit and is gone.
Each option has a one-line hover text. Kernel refusals read in plain
words, with the raw text in the hover, Copy Details and the issue report.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 13:52:32 -04:00
jyvikoandClaude Opus 5.5 529fb7cf35 Release: macOS builds on macos-15 (GitHub retires macos-14 on 2026-11-02)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-28 12:51:33 -04:00
jyvikoandClaude Opus 5.5 e197856205 STEP import: a refused solid's surface body faces as the file has it
SMLib holds both sides of a sheet's faces and gives each back on its surface's
natural side, so a sheet whose file uses faces the other way came back
renumbered. The reader no longer turns them (that lost the file's side);
instead SMLib is given the sheet with those faces turned over exactly on the
record, and they are turned back on SMLib's body, each face mapped through.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 10:36:56 -04:00
jyvikoandClaude Opus 5.5 4cb0d6ee96 STEP import: a refused solid comes in as a surface body of its exact faces
A solid the reader or SMLib refuses was shown as a mesh of its faces (#8223):
exactness lost, cracks between faces, and no modelling. It now comes in as an
open surface body of the faces that read, sharing their edges as the file has
them; each face left out is named.

- The reader reads a solid with a set of faces left out (read_solid_without):
  a sheet whose faces face their surfaces' natural normals, as SMLib gives a
  sheet's faces back, so SMLib's body numbers the faces as the record does.
- Tier 1: the faces that cannot be read alone and the face each refusal names
  (named_face) are left out, up to 8 reads. Tier 2, when a refusal names no
  face of the solid: the one-face bodies stitched by SMLib. Tier 3, when SMLib
  cannot stitch them: the mesh of them, as before.
- Report: "imported as surfaces: <why>" and "left out: face #..."; the
  ImportedBody field shown_as_mesh is now refused.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 10:36:56 -04:00
jyvikoandClaude Opus 5.5 fd5319a0e2 docs: the kernel's move from truck to SMLib, as written up on #4012
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 08:17:51 -04:00
jyvikoandClaude Opus 5.5 0102f95dc2 Tessellation tests: rustfmt
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 08:09:31 -04:00