* Sketch drag: a step that throws points far from the sketch counts as failed
A held step of a drag that moved a point more than 1000 times the sketch's
size plus the drag's way was taken as solved, so a drag could leave points
around 1.4e6 mm away while reporting it reached the cursor. Such a step now
fails like one the solver cannot solve, and the cursor correction refuses it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Sketch drag: a step that presses a line to no length counts as failed too
An end dragged past the point where its line would have to turn over (a
line held at its midpoint and by an angle, dragged past the midpoint; a
rectangle's corner dragged across the opposite side) pressed the line to no
length, where it has no direction left for its constraints. A step leaving a
line under 1/1000 of its length at the drag's start now fails like one that
throws points far away, so the drag stops just short of it (48 such drags in
4000 random sketches, none with this).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #7854
* MCP batch: refuse a step with an unknown key (#7854)
A step's parameters under another key (`args`) were dropped and the
command ran without them. The batch is now refused before its first
step, naming the key.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* MCP batch: a step carrying `expect` is refused, saying it is the batch's argument
#9904 gave batch an `expect` argument and tested that a step carrying one runs with
nothing checked. That is the silent drop this branch refuses: the step is now refused
before it runs, and the error says `expect` belongs to the batch.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Light a feature's faces after a later edit renamed them
Selecting a feature in the Browser or the timeline lights its geometry on the
model, by the face names the feature gave (`F<feature>:…`). A later edit that
moves or renames those faces (Offset Face, Replace Face, Delete Face) leaves
them named after whatever last touched them, so selecting the earlier feature
lit nothing.
When no face carries the feature's name, compare the model states either side
of it instead: a face whose name is new, or whose area, centroid or plane
moved, is a face the feature changed. Each is found on the body as it is now
by its name, or by a parallel plane and nearest centre, so a face a later
feature moved again is still lit.
The Browser row of the feature a picked face belongs to already lights; that
is unchanged (a body row lights too, as #3009 asks).
Test: a box raised twice with Offset Face; selecting the first raise lights
the face the second one renamed.
* Browser: light the feature of a picked face, not its whole body
Picking a face in the view lit the body's row as if the body were selected,
which in NX is not what a face pick shows: the Part Navigator marks the
feature the face belongs to. Faces, edges and vertices no longer light their
body row; the feature row of the picked face shows as selected instead
(`picked_feature`), while the session's selection stays the face or edge, so
Replace Face, sketches and the rest keep the pick they take.
The live face of the view still lights the face itself; the timeline already
marked the feature of a picked face and is unchanged.
Tests: the browser's 178 tests pass (selection arrays unchanged; only the
rows lit differ).
---------
Co-authored-by: clarkliu <277482660@qq.com>
The second fillet of a side whose radius is half its length needs all
that is left of the line, and was refused as too large. Such a fillet
now takes the whole line: the line goes, the arc ends where the line did
and is tangent to the curve that goes on from there. A 20 x 10 rectangle
filleted with r = 5 becomes a slot, a 10 x 10 square a circle. Several
corners in one call keep their arcs by id, as removing a line renumbers
the curves.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #7507
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Sketch Fillet: a corner held by Coincident takes a fillet when a dimension measures to it (#7507)
Before rounding a corner whose two lines meet only through a
Coincident constraint, Fillet and Chamfer weld the two points into
one, but not when anything else referred to the second line's point,
such as a dimension measuring to the corner: the fillet was then
refused ("the lines must share a corner point"). The point is now
welded as well, and what referred to it refers to the corner, the
same place. A point that a constraint names together with the corner,
or a linked point, is still not welded.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Two selected lines that stop short of each other or cross were refused
with "the lines must share a corner point". Now each line's end on the
shorter side of their meeting point moves there first (extending a line
that stops short, cutting a line that runs past), and the corner is
rounded or cut as before. Parallel lines, ends held by other geometry
and lines whose length is held are refused and change nothing.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
An offset's ends follow its source curves on every solve, so a break's new
ends were pulled back: a broken offset arc came out in three pieces going
the long way round, and the solve moved curves the break never touched.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The offset sets an offset circle's radius from its source after the solve,
but the solve still counted that radius as a free unknown, so a
dimensioned circle and its offset reported 1 DOF instead of 0. Lines and
arcs were not affected: the offset already holds their end points. The
solve now holds an offset circle's radius too.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #10057
* Pattern and Mirror dialogs: explain Object Type, and say why a sketch is not taken (#10057)
The Object Type row of the Rectangular, Circular and Path Pattern and Mirror
dialogs gets a tooltip saying what Bodies and Features are and that a sketch
is neither. A sketch clicked for their objects, in the view, the Browser or
the History, now shows a hint naming what to pick and what to do with a
sketch instead of being ignored.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #8706
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Properties: measure faster, show progress, and stop when closed (#8706)
Properties on a large assembly measured every placed copy of every body
afresh (transform plus three fine tessellations each), so it took minutes.
#5203 (in #8103) already moved the measurement beside the window; this
builds on it.
- A rigid placement reuses the body's own cached measurement: volume, area
and counts unchanged, centre placed, box from the placed corners (quarter
turns) or from the body's shared mesh placed (other turns). Scaled or
mirrored placements are still measured as placed.
- Bodies are grouped by component once and the subtree traversal groups
occurrences by parent once (both were quadratic).
- The measurement beside the window is watched by a Progress: the card
says "Measuring... n of N bodies" with a bar, and closing it (or
switching designs) cancels the worker at its next body instead of
leaving it running.
- component.properties and occurrence.properties are answered on a copy for
control-channel requests too, as inspect.measure is.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Properties: count the measuring work instead of timing it in the reuse test (#8706)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
A switch between design tabs cancels the open dialog and tool of the design
left and shows MODEL. With the new Interface preference "Keep dialogs and
tools open when switching designs" (keep_work_on_tab_switch, off by default)
each tab keeps its dialog (with its picks and values), its editing state, its
tool and its toolbar tab, and has them back when it is shown again. A feature
still computing after OK is cancelled as before. A feature edit's saved source
revision follows the view refresh of the switch, so its Cancel still restores
the history.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #9743
* Update Links: linked designs that changed while the tab was away come back as one undo step (#9743)
Coming back to an assembly's tab read each changed link in an Update Links
run of its own, so each became its own undo step: one Undo took back one
component and left another copy of the same part at the new version.
component.update_links now takes `components`, a list, and goes on past a
design it cannot read: that link keeps its bodies, is named in `failed` and
gets a warning. The tab return sends one request with every changed link,
records as read only the ones that were, and says on the status line which
one could not be read.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Delete: the delete runs with what its check computed ahead (#9917)
With the history rolled back, a delete builds the history after the
marker to see what it breaks, once in the check that runs off the window
thread (Session::ahead) and once more in the delete itself, on the window
thread. The check's results were lost on the way: the dry run's scratch
session and the whole-history copy dropped what the model keeps, and the
check's kept results never reached the delete. The scratch and the copy
now keep what their model keeps, and the delete (at once or after the
confirmation) runs with the check's kept results, so it finds the
history there instead of building it again.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Delete: test that a confirmed delete runs with what its check kept (#9917)
With the history rolled back, deleting a side of the plate's outline is
checked off the window thread and confirmed first; the confirmation
carries the check's kept results, and the delete adds nothing to them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #10050
* Hide the origin point behind bodies like the axes and planes
The origin point is a flat dot painted after the 3D scene, so it always sat
over bodies while the axes and planes respect the through-bodies rule
(#2697, #2618). Ask the meshes the same question the depth test asks the
axes: is a nearer kept face in front of the origin along the view ray.
Fixes#10050
---------
Co-authored-by: Dahak Builds <dahakbuilds@users.noreply.github.com>
* Sketch: a centre rectangle's centre lines up with the axes when dragged (#10086)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Sketch: a centre rectangle's centre lines up with the axes when dragged (#10086)
A centre rectangle's centre is held at the middle of a construction
diagonal (Midpoint), on none of its curves. Dragged by the centre, the
rectangle's own lines stayed snap targets and held the centre at their
middle, so it never lined up with the origin; dragged as a whole, the
centre wasn't a moving point, so only the corners lined up.
drag_snap::moving_points now takes all dragged entities at once and
treats a point held at a line's middle as going where the line's ends
go: it moves with a line whose two ends move, and when it is dragged
its line and the shape round it are no targets.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* claim: #10066
* Keep one dialog field active at a time (#10066)
Pick fields drew their accent ring from the dialog's active-input index
while text editors drew theirs from egui keyboard focus, so a Circular
Pattern dialog could show Axis and Quantity active together. A pick
field now drops its ring while a text editor holds the keyboard, and
clicking a pick field (or its clear button) takes the keyboard back.
Selection routing (d.active) is unchanged.
* Format editor_has_focus onto one line
---------
Co-authored-by: Dahak Builds <dahakbuilds@users.noreply.github.com>
* Navigation: wheel and trackpad gestures go on under a value box (#10061)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Navigation: wheel and trackpad gestures go on under a value box (#10061)
Any area above the model took navigation's wheel input, so a two-finger
pan, orbit or zoom stopped as the pointer crossed a floating value box
(Extrude's distance), and none could start over one. Model-anchored
canvas areas (Surface::Canvas: value boxes, a dimension's editor,
readouts) scroll nothing: navigation's wheel, trackpad pan and orbit and
pinch now go on under them. Their clicks stay theirs, and with value
stepping on the wheel stays with the value under the pointer.
Container::area records the canvas areas it builds; navigation asks
whether the top layer under the pointer is one (container::is_canvas).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* Rename Body: a pasted placement's body renames by the name the browser shows (#10017)
The browser lists the bodies of a component's second placement by their
placed names (`KB (K:2)`) and the context menu's Rename sends that name,
but body.rename looked it up only among the model's own bodies and
refused it ("no body"). It now takes a placed copy's name as the body it
shows, as appearance.assign does (#9740): the body is renamed in its
component, so every placement shows the new name.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Rename Body: test renaming a pasted placement's body by its placed name (#10017)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Rename Body: the test also hides the copy first and undoes the rename (#10017)
A copy hidden by its placed name stays hidden under its new name, and
one undo brings both names back (checks from the review on #10026).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #9079
* Modify ▸ Delete with nothing selected asks for a pick instead of a parameter error (#9079)
Starting `timeline.delete` from the ribbon, the command palette or the
control channel ran it with no parameters, so the notice showed the
engine's check ("`features` must list features, or `groups` timeline
folders"). It now deletes what is selected, as the Delete key does, and
with nothing selected shows a hint saying what to pick, changing nothing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #10005
Signed-off-by: Maurizio Monticelli <maurizio@whatwedo.ch>
* F2 renames a group clicked in the Browser (#10005)
A group has no selection of its own: clicking its Browser row only
records it as the picked folder, which V uses. F2's rename_selection
looked only at the selection, picked components and canvases, so on a
group it did nothing, or renamed a body that was still selected.
F2 now takes a clicked group row first, as V does, and opens the same
Rename box as the group's context-menu Rename, which commits through
browser.rename_group. This works for groups inside components as well.
Fixes#10005
Signed-off-by: Maurizio Monticelli <maurizio@whatwedo.ch>
---------
Signed-off-by: Maurizio Monticelli <maurizio@whatwedo.ch>
* claim: #7974
* Viewport: dark parts keep their shape: linear-light shading and a sky fill (#7974)
Preferences > Graphics "Keep the shape of dark parts" (off by default)
shades the viewport in linear light: the key light and eye fill over a
sky fill that grows as a face turns up, plus the 4% of that sky every
dielectric reflects (a little more toward grazing), encoded to sRGB
once. Near-black faces keep a gradient; light and mid-grey faces stay
within a few levels of the sRGB shading. The world's up direction and
the switch ride in a new `sky` vec4 at the end of the viewport uniform,
and the frame key, so turning it on redraws. Off, the shader takes the
old path unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Preferences: a shortcut recorded from a search result takes the key (#10043)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Preferences: a shortcut recorded from a search result takes the key (#10043)
A Preferences search lists matching shortcuts with their key buttons,
but a recording started there only counted while the Shortcuts page
itself was open, and the page skipped its recorder during a search: the
key went into the search box and ran its command behind Preferences.
keymap::capturing now counts a recording while a search shows, and the
recorder runs for it; clicking back into the search field stops the
recording, so the search keeps its own typing. The recording's message,
a taken key's Use anyway / Cancel choice and the next-step hint show
above the search's shortcut matches too (outcome, shared with the page).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* fix(ui): disable bold in Edit Text when font has no bold face (#9940)
- Check whether font has bold face via font_data_styled() before enabling bold toggle
- Automatically uncheck bold and disable bold button with explanatory tooltip for built-in font
- Prevent sending bold: true in sketch.edit_text when font lacks bold face
- Add unit regression test in sketch_text::tests
Fixes#9940
* style: format choice.rs in ui_kit
* i18n: move sketch_text.no_bold to pending locale catalog with complete translations
* test(sketch_text): assert disabled bold on built-in font without error (#9940)
* claim: #9970
Signed-off-by: Maurizio Monticelli <maurizio@whatwedo.ch>
* Agent chat: no error when an agent does not serve session/set_model (#9970)
An ACP agent can list models in the unstable `models` field of its
session/new reply without serving `session/set_model`; it answers
JSON-RPC -32601 and the Assistant showed that as an error each time the
model was switched. Agents that offer the model as a configuration option
already go through session/set_config_option. A -32601 reply to
session/set_model is now logged at debug level instead of shown; every
other error still shows.
Fixes#9970
Signed-off-by: Maurizio Monticelli <maurizio@whatwedo.ch>
---------
Signed-off-by: Maurizio Monticelli <maurizio@whatwedo.ch>
* Delete: the check in a rolled-back history builds the history once when nothing breaks (#9917)
With the history rolled back, the check before a delete (which features
the delete would break) built the whole history twice, before and after
the change, with the marker removed. On a large design each build ran
every boolean after the marker: deleting twelve splines took half a
minute on the window thread. Only a feature that fails after the change
can be newly broken, so the history after it is built first, and when
nothing fails there the history before it isn't built at all.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Delete: test that the check in a rolled-back history still reports what breaks (#9917)
Deleting a hole in the plate changes the plate and every cut after the
marker and breaks none of them: the check reports nothing. Deleting a
side of the outline breaks the plate, and the check still says so, with
a cache too small to keep a state.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #8341
Co-authored-by: Cursor <cursoragent@cursor.com>
* Graphics: keep a preferred card when surface marks it incompatible (#8341)
Prefer the saved adapter by exact then case-insensitive name, including when only listed as surface-incompatible, and explain in Preferences when another card is still in use.
Co-authored-by: Cursor <cursoragent@cursor.com>
* Format and clippy
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* feat(engine,ui): allow restricting point-to-point align to chosen axes (#9946)
* style: apply cargo fmt across crates
* fix(clippy): use filter then map instead of bool::then in filter_map
* claim: History: build the row plan once per revision and draw only the visible rows
* History: build the row plan once per change and draw only the rows in view
The vertical History worked out its rows from the design on every frame: for each row it
searched every folder's last feature (cubic in features and folders), cloned every name, and
looked up each row's result, sketch and selection by a linear search. It also drew and
hit-tested every row, including the ones scrolled out of view.
- The row plan (features, folders' depth, extent, header places, contents and joints, the rows
with listed sketches, which sketches have patterns) is built once per design change, keyed
by session, revision, marker, counts and the "Sketches: under their feature" choice, and kept
in the egui context; the visible order is kept beside it until a folder or fold opens.
- A feature row outside the scroll area's clip takes its place and publishes its handles, but
is not drawn or made interactive; one being found, dragged or focused, or under an open
menu, is drawn as before.
- Selection and results are collected once per frame; folder rows read their contents from
the plan.
- The horizontal strip collects the picked features (selection and dialog items) once per
frame and writes a chip's tooltip only while it shows.
Tests compare the plan with the per-frame searches it replaced on tangled folders in every
fold state, the kept plan with a fresh one after each kind of change, and the History drawn
with every row against the culled one (same places, same text in view, fewer rows drawn).
An ignored test times the panel on a large design.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Drop a needless borrow
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
* claim: #8749
Co-authored-by: Cursor <cursoragent@cursor.com>
* Recover egui chrome after a long pause between frames.
Sleep/wake can leave the window black while the GPU device stays up: re-upload
the font atlas, clear cached icon textures, and repaint when the frame clock
jumps so the ribbon and panels are not stuck blank (#8749).
Co-authored-by: Cursor <cursoragent@cursor.com>
* Format
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Sketch: a driven dimension nothing fixes any more takes a value again (#10018)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Sketch: a driven dimension nothing fixes any more takes a value again (#10018)
A dimension placed while a constraint fixed what it measures goes in
driven, and stayed driven once that constraint was deleted: a
double-click only said it has no value to edit. The double-click now
tries making it driving on a scratch copy; when nothing else fixes it,
the value box opens at the measured value, and Enter makes it driving
(sketch.toggle_driven) at the typed value (parameters.change) in one
undo step. A refused value goes back to a checkpoint, so it stays
driven. While something still fixes it, it stays read-only as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* claim: #9945
* Sketch: Project gives its new curves the selected line type (#9945)
The sketch palette gives the drawing line type (construction, centerline, infinite) to the
curves a SKETCH › CREATE command reports under `curves`. Project reports what it made per link,
`links[].curves`, so its curves were never found and stayed normal lines whatever the palette
said. `apply_mode` now also reads the links' curves, so a projected line becomes construction,
centerline or infinite and a projected circle construction, in the projection's own undo step.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EMbqRqYimvY26QzcvrojSC
---------
Co-authored-by: sascha2101 <221609842+sascha2101@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #9489
* Sketch: the Line tool can switch to a tangent arc and back without changing tool (#9489)
With Preferences > Sketch > "Rest on a line's last point to switch to a
tangent arc" on (off by default), leaving the chain's last point and resting
back on it for 0.35 s makes the next click a tangent arc, by the existing
sketch.arc.tangent command, and the same gesture goes back to lines. A label
at the cursor says which. sketch.arc.tangent's end can now name an existing
point, so an outline drawn this way closes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Sketch: the cursor label names the command in words (#9489)
The label asked the catalog for a message id that doesn't exist, so it showed
the id. It now takes the command's translated label, and the test checks the
words it paints. Moved clear of the pointer's own badge.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Show/Hide put every sketch it showed in `shown_sketches`, the list of
finished sketches kept shown although a feature uses them. Hiding and
showing a sketch nothing used yet put it on that list, so once an
Extrude used it, it stayed shown instead of hiding itself as a sketch
never hidden does. Show now marks only a sketch a feature already uses;
one nothing uses is shown anyway and leaves the list alone.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>