Commit Graph
3815 Commits
Author SHA1 Message Date
brett19andClaude Opus 5.5 ae76f0567c smlib: C++ bodies cross solidcore and come back with the C++ kernel's own arrays
C++ -> arrays -> solidcore -> arrays -> C++ over a filleted box, a holed plate,
a swept B-spline, an ellipse edge, a sealed void, sheets, wire edges with a point
shell, two lumps and a shelled rounded box. The reference is the C++ kernel's own
crossing, which itself moves trims by about 1e-7 on a shelled box; tolerances and
EXTENT are excepted, and the test says why. No port difference found.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 23:10:05 -07:00
brett19andClaude Opus 5.5 922f781e2e Merge ws/combined-1031: solidcore 6a2e8c68f, split-face and triage fixes, develop 456e5b7
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 22:44:33 -07:00
brett19andClaude Opus 5.5 068c6ac762 smlib: fillet_over_a_cliff stays ignored at solidcore 6a2e8c68f with its current refusal
The rail still leaves the face it rolls on (FilletErrorType::NoRoom), which the crate reports as
Unsupported: solidcore#960's cliff overflow (fork 8ba4667) is not complete.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:56:18 +01:00
brett19andClaude Opus 5.5 1b291f750e smlib: gate the C++-only test helpers on the native feature
tests_of (measure_tests) and Raw::canonical (history) are used only by tests that compare with the
C++ kernel, so clippy without native flagged them as dead code.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:27:25 +01:00
brett19andClaude Opus 5.5 727796cbcc smlib: turn on solidcore's new fork fixes at 6a2e8c68f
fillet_nx1_tangent_side_edge_same_convexity (WR-600, fork 7992ec7) and
fillet_removal_takes_ring_fillets (WR-605, fork 52bfef0) each port a tangency-labs/smlib commit
that is an ancestor of SMLIB_REV 68fb9162. The pin needs no API change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:27:25 +01:00
brett19andClaude Opus 5.5 da6cc21c2c smlib: pin solidcore to 6a2e8c68f (main after #1070)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:24:08 +01:00
brett19 b9659c8e5d Merge ws/develop-456e5b7 into ws/combined-1031 2026-10-31 03:23:48 +01:00
brett19 8de0453f58 Merge ws/triage-1031 into ws/combined-1031 2026-10-31 03:23:48 +01:00
brett19 84939bca6f Merge ws/split-g2-trim into ws/combined-1031 2026-10-31 03:23:48 +01:00
brett19andClaude Opus 5.5 10ffd88d01 smlib: untrim out of the body runs on solidcore now that CopyFaces through the merge copies (solidcore#1872)
The capi's copied.GetSize() != 1 is SMLIB_ERR_EMPTY, not a refusal; the four out-of-body untrim
cases are no longer ignored.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:21:52 +01:00
brett19andClaude Opus 5.5 783a4075fa smlib: Split Face on solidcore intersects a face's surface through its face's cache
cut_face intersected the face's surface with a non-plane tool (or a plane strip) by a plain
global_surface_intersect on an evaluation copy of the face's surface. That copy keeps its face
owner, and solidcore refuses a trimmed cache for a face-owned surface reached without the
B-rep ("TrimSrfCache::build_tree_with_face for a face-owned surface", Unported), so a B-spline
face cut by plane strips (surface.trim with sketch lines on a spline sheet) failed with "SMLib
cannot build this exactly". The C++ reaches the face through face->GetSurface(); the port now
solves through the B-rep's BrepFaceServices with the face's cache handle, as solidcore's own
face_planar_section_curves does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:21:51 +01:00
Brett LawsonandClaude Opus 5.5 6f81622a3e smlib: a blend at a corner no type handles is CornerUnsupported on solidcore, as on C++
The capi's blend_failure maps SM_FILERR_CORNER_UNSUPPORTED to
SMLIB_ERR_CORNER_UNSUPPORTED. solidcore notes that code (with
fixes.fillet_vertex_error_diagnostics, which we turn on) when
CreateFilletCorners leaves a vertex without a corner, but the port's
blend_failure mapped only NoRoom, so such a blend failed with the bare
status 1001 (fillets/1390-chamfer-hole-rim-touching-bottom). The note is
kept through the later step that fails because of it, as solidcore's own
FilletSession::do_fillet keeps it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:08:46 +01:00
Brett LawsonandClaude Opus 5.5 a626da2936 smlib: turn on solidcore's new fork fixes at 9b398723b; hold back the rest
On (each ports a tangency-labs/smlib commit that is an ancestor of SMLIB_REV 68fb9162):
revolve_splits_curves_on_axis (WR-590, e4f1377), cover_wraps_across_closed_seam (WR-599,
16bf1cb), imprint_extension_keeps_analytic_curve (WR-601, bec8a0b),
fillet_trace_from_tangent_point_toward_next (WR-603, 68fb916),
fillet_tangent_point_one_sided_step (WR-595, f8fd83e), fillet_rails_meet_at_one_end_point
(WR-594, 5fdefb9), fillet_trace_reaches_rails (WR-609/610, a9277fd, 6e77631),
delete_vertex_joins_seam_iso_curve (WR-598, 829b982), box_face_failures_propagate (WR-596,
0df62c8, 35008b1, 449c81c), ellipse_adjust_step_interval_keeps_turns (WR-211, 5c0b5ed),
fillet_cleanup_removes_input_slits (WR-602, cac11ea), fillet_rail_end_on_continued_surface
(WR-630, 3f22e97), glue_vertices_joins_every_region (WR-607, 661f79c).

Held back: temporary_radius_setup_errors (#458), ellipse_step_interval_checks (#428),
perspective_sphere_offsets (#525) and curve_loop_normal_from_area (#1776) have no fork commit;
fillet_trim_inside_by_best_dot (de4dae6), fillet_half_degree_crease (2e8758b),
fillet_split_edge_keeps_near_half (ceb3272) and good_drop_result_distances_in_order (0b4de8c)
port fork commits not in SMLIB_REV; corner_patch_face_side_twist (7fd9fb0) is unpublished.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:02:12 +01:00
Brett LawsonandClaude Opus 5.5 368a3ca293 smlib: pin solidcore to 9b398723b (main after #1840)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:01:55 +01:00
Brett LawsonandClaude Opus 5.5 0afb20287d smlib: closed_nonmanifold on solidcore takes a failed edge query as false, as the capi does
The capi's closed_nonmanifold (smlib_ops.cpp) returns false for an edge that
is null or whose GetEdgeuses fails; the port propagated the error, failing the
boolean instead of reporting it not solid. The per-edge test is now
`edge_closes`, which takes either failed query as false.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 02:53:22 +01:00
Brett LawsonandClaude Opus 5.5 b4ee38083f smlib: solidcore's check counts no SmBrep test 21 warning, as the capi's does
The capi's smlib_brep_check (smlib_check.cpp, `advisory`) skips SmBrep test 21,
"Suspicious Shell Count": a warning AssertValid reports without failing. The
solidcore port counted it, so a sheet of faces offset apart across a sharp edge
(one shell per face, rightly) was refused after the stitch whenever the Check
family ran on solidcore (surfaces/cov-offset-two-faces-across-a-sharp-edge-come-apart).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 02:53:22 +01:00
Brett Lawson 6edfba0a79 Merge remote-tracking branch 'origin/develop' into ws/develop-456e5b7 2026-10-31 02:47:23 +01:00
Brett Lawson 1ad666601d smlib: the Split and Transform families run on solidcore (split, untrim, extend, stitch, merge faces, copy and transform)
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	crates/smlib/src/core.rs
2026-10-31 01:39:15 +01:00
Brett Lawson c117401cff Merge develop 134a34f8 into solidcore 2026-10-31 01:39:06 +01:00
jyvikoandClaude Opus 5.5 456e5b7fa5 Tests: the io crate's hand-built saved models list their rounds, as format 7 records do
Model cache format 7 (f3cf0c4f3) records a `rounds` list in every saved model, and reading one
without it is refused ("saved model: rounds"), as is a model without any of its other lists:
the states, the preview and the thinned model all came back empty. The io tests' saved_model
and timeline_model wrote format-6 records, so six tests (the round trip, the repeated part
stored once, and the four too-big-for-the-file cases) read nothing. Their bodies are none made
by rounds: the list is empty, and every expectation stays as it was.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 20:07:43 -04:00
Brett LawsonandClaude Opus 5.5 cedd11eb4b smlib: untrim and extend on solidcore (smlib_untrim_face, smlib_extend_sheet), routed by Op::Split
A port of the fork capi's smlib_untrim.cpp (holes taken away with DeleteInnerLoop, the outer
boundary back on the surface's box with the kept holes rebuilt by MakeVertexLoop and
MakeEdgeInFace) and smlib_extend.cpp (CreateExtendedSurface corrected to the distance across the
side's middle, CopyAndAddAnalytics, a cone or cylinder continued naturally kept analytic).

An untrim of a face out of its body (in_place = 0) is not supported yet on solidcore: its
CopyFaces through the merge copies nothing (the merge copy's failure is ignored). Those cases'
solidcore tests are ignored; their C++ closed-form tests run. Closed-form, C++ parity,
hostile-argument and history tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 00:47:39 +01:00
Brett Lawson a42710ef98 Merge develop 134a34f8 into solidcore 2026-10-31 00:47:30 +01:00
Brett LawsonandClaude Opus 5.5 4168920ad4 smlib: stitch and merge faces on solidcore (smlib_stitch, smlib_merge_faces), routed by Op::Split
A port of the fork capi's smlib_stitch (StitchFaces at the caller's tolerance, once, then
OrientTrimmedSurfaces; not StitchAndOrient) and smlib_merge_faces (the kept edges picked by
point, then RemoveTopologicalEdgesAndVertices and finish). Closed-form, C++ parity,
hostile-argument and history tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 00:47:30 +01:00
Brett LawsonandClaude Opus 5.5 cdddae8a17 smlib: Split Face and Split Body on solidcore (smlib_split_faces, smlib_split_body), routed by Op::Split
A port of the fork capi's smlib_split.cpp: faces cut where tool surfaces meet them
(CreatePlanarSectionCurves for a plane reaching over the face, GlobalSurfaceIntersect otherwise,
then MergeCurvesOnSurface with the tool), and a solid sliced (SM_BO_SLICE) by a one-face sheet
on the tool, once turned over. A tool Surface keeps its constructor's description, from which
solidcore makes its own surface as smlib_ssi.cpp makes SMLib's. Closed-form, C++ parity,
hostile-argument and history tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 00:47:30 +01:00
Brett LawsonandClaude Opus 5.5 58ed3002c4 smlib: copies and transforms on solidcore (smlib_brep_copy, smlib_brep_transform), routed by Op::Transform
A port of the fork capi's smlib_brep_copy and smlib_brep_transform: SmApiBrepCopy, then
SmBrep::Transform(matrix, TRUE) on the copy (solidcore's transform_matrix). Brep::try_clone and
Brep::transformed take it when Op::Transform runs on solidcore; the default stays SMLib.
Closed-form, C++ parity, hostile-matrix and history tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 00:47:30 +01:00
Brett LawsonandClaude Opus 5.5 d20aee0757 smlib: solidcore's boolean_wire_edge_keeps_faceuse_shell opt-in is on (the fork's be8ac73, in SMLIB_REV)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 00:43:38 +01:00
Brett LawsonandClaude Opus 5.5 ec3a21778e smlib: a blend on solidcore has a history, as on the C++ kernel
solidcore#1594 carries the body's attributes through its fillets, so a solidcore blend's faces
and edges keep their tags. Brep::made_core_blend, which marked a solidcore blend's history
untracked ("not supported yet: the history of a blend on solidcore (solidcore#1594)"), goes:
solidcore's blends are made_core bodies, as its other operations' are, and Brep::history reads
them. tags_cross_a_fillet runs again, and tags_cross_a_chamfer joins it: one edge of a box
rounded or chamfered keeps the bottom and back, trims the top, front and sides and makes the
blend face, on both kernels, with the same history face by face.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 00:35:23 +01:00
Brett LawsonandClaude Opus 5.5 c9fcf82a54 smlib: solidcore's four new fork-carried opt-ins are on; the fillet trim status waits
boolean_wire_edge_keeps_faceuse_shell (WR-585, solidcore#1753, smlib@be8ac73),
fillet_nx1_tangent_corner_edge (WR-593, #1816, smlib@1ff7353), fillet_torus_rail_on_axis (WR-592,
#1814, smlib@994f129) and loops_go_on_round_the_vertex (WR-591, #1813, smlib@9209e76) are on:
their fork commits are in SMLIB_REV 68fb9162. fillet_trim_status (WR-604, solidcore#674) has no
fork commit, so it goes on HELD_BACK.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 00:24:30 +01:00
Brett LawsonandClaude Opus 5.5 509209838a solidcore: move the pin to afcee131a (main, with solidcore#1594, #1674, #1595)
Merged since 15e72dff9:
- #1594 B-rep-owned attributes carried through fillets (#1462 P3): a blend's faces and edges
  keep their origins
- #1674 offset results and sweep wires named by their geometry owners (fixes #1670, #1671)
- #1595 SmBrep::Transform with a matrix
- #1753 opt-in a new edge joining a wire shell to a faceuse shell keeps the faceuse shell
  (boolean_wire_edge_keeps_faceuse_shell, WR-585, fork be8ac73)
- #1816 opt-in Nx1 corner takes a tangent edge past the tangent side edge as its corner edge
  (fillet_nx1_tangent_corner_edge, WR-593, fork 1ff7353)
- #1813 opt-in loop ordering goes on round a vertex where loops touch
  (loops_go_on_round_the_vertex, WR-591, fork 9209e76)
- #1814 opt-in torus rail point on the arc's axis (fillet_torus_rail_on_axis, WR-592, fork 994f129)
- #1784, #1785 offset round divergences and the offset fillet coincidence hang (unconditional,
  with BuildOffsetOfFaceuse's lamina delete fix)
- #674 opt-in SmFilletGeom::Trim returns its first trim error (fillet_trim_status, WR-604)
- #1821 blend.fillet_removal (SmFilletRemoval, DeleteFilletFace)
- #1786, #1797 deleting a shell, face or loop removes its records
- #1782 fillet corner insertion treats a removed patch-face record as deleted
- #1832 brep writer keeps owned surfaces under a caller's naming
- #1690 EvalNormal reads the matrix of a failed evaluation (near-flat GlobalPointSolve)
- #1702 curve AssertValid
- #475/#677, #481/#668, #527/#662 opt-in curvature, oscillation and refine-range tests
- tests and difftests: #1680, #1793, #1830, #1831, #1841, #1842, #1843, #1845;
  plan: #1849; CI: #1802

(#1803, HANG-51, was already in 15e72dff9.) main's CI test job passed on afcee131a.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 00:24:15 +01:00
jyvikoandClaude Opus 5.5 134a34f895 Tests: a corner patch of rounds 2/3/4 takes no more than the strips leave in its block
three_rounds_at_a_corner bounded the patch's extra cut at 3 mm³ beyond the strips, a figure
with no derivation; SMLib's all-at-once body at radii 2, 3, 4 takes 3.099 (V 7878.579574
against strips 7881.678). That body is the strips' outside the block its patch lies in: its
rounds are the strips' cylinders ending at a's section y = rc, b's x = 20 − rc and c's rails
where they meet a's and b's (the patch's four corners, now asserted), so the patch takes at
most what the strips leave in that block (11.86 at 2/2/3, 32.69 at 2/3/4). The lower bound is
that block; the upper one, at most the strips' volume, stays.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 19:19:30 -04:00
jyvikoandClaude Opus 5.5 f3cf0c4f37 Model cache: a body made by rounds keeps them, so a later round blends them the same after opening
A design gave another body when opened from its model cache: the rounds a body was made of
lived only in memory, so a later round at their mitre was built sequentially (or refused, as
too large) after opening and blended with them when evaluated anew. The saved model now
records, per kernel body made by rounds, the body they were made on (a place in the bodies,
stored once though no state holds it) and the edges with their radii; reading it attaches
them back down each chain, and a thinned model keeps those bodies with the bodies made from
them. Model cache format 7.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 19:19:30 -04:00
jyvikoandClaude Opus 5.5 9760feed48 Kernel: a body's record of rounds goes with its history, and can be read back
The rounds that made a body are over the body its history is over: a new history (an
operation carrying a step's result back to its own operands) leaves the record out, so a
later round never reads one history against another body. Body::rounds gives the record and
Body::with_rounds_of takes one back, checked (edges of the body before them, a fillet's
radii, the body's history over that body), for a saved model to keep it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 19:19:30 -04:00
jyvikoandClaude Opus 5.5 5d1b18f405 Tests: a later r3 round at an r2 mitre, through the Fillet feature, makes the all-at-once corner
Two box edges rounded r2 in one fillet, then the upright edge at their mitre r3 in a second
fillet (tangent chain on, so the seam comes with it): 10 faces, 7928.743041 mm³ as
fillet_radii of the box gives, the r2 rounds' names kept, the r3 round and the corner patch
the second fillet's.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 19:19:30 -04:00
jyvikoandClaude Opus 5.5 3e5b358afd Fillets: a later round at a corner where earlier rounds meet blends them again with it
The owner's ruling of 2026-10-30: a later fillet on an edge at a vertex where earlier
rounds already meet in a mitre makes the corner rounding all of them at once makes, one
smooth patch, the mitre gone. A body made by constant-radius rounds keeps what they were
made on and which edges they rounded at which radius; a later round reaching such a corner
blends the earlier rounds' edges (from the earliest of those meeting there on) with the new
edges in one SMLib blend of the body before them. The result's history is put over the body
the later round was given: an earlier round's face is that face trimmed anew (its name
kept), the corner patch and the new rounds are the later fillet's. A picked mitre seam has
no round of its own: it is refused unless a new edge of its radius meets it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 19:19:30 -04:00
Brett LawsonandClaude Opus 5.5 736f179414 solidcore: move the pin to e7585558 (main, with solidcore#1595: SmBrep::Transform with a 4x4 matrix)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 23:49:45 +01:00
Brett Lawson a2deba2690 Merge develop 6d8e002f into solidcore
# Conflicts:
#	crates/ui-egui/src/prefs.rs
2026-10-30 22:47:56 +01:00
jyvikoandClaude Opus 5.5 6d8e002f86 UI: rim and wall picking tests for a circle of arcs that is one wall
A circle drawn as two half arcs now extrudes to one full-turn wall with its
seam edge, and each rim is one closed edge (tangency-labs/smlib#67). The tests
keep their intent on that body: a rim clicked once is one item, measured and
highlighted whole and picked from either side; a wall picked either side of
its seam is the same surface, lit whole, and toggles off from the other side;
every face is its own patch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 17:09:44 -04:00
jyvikoandClaude Opus 5.5 8ed4663ae8 Mesh convert: a reconstructed bore is one wall, so the bracket has 9 faces
The L's six sides, its two caps and the bore: since tangency-labs/smlib#67 the
full circle the conversion fits extrudes to one full-turn wall, not two halves.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 17:09:44 -04:00
jyvikoandClaude Opus 5.5 2c19013710 kernel: the record test takes the one wall a circle of arcs extrudes to
Since tangency-labs/smlib#67 an extruded profile's arcs on one circle sweep one
full-turn wall face, made from all of them (Profile 4, 5 and 6 here), where it
was a face per arc. The geometric check of the record finds a face over several
segments by its triangles' centres and vertices on them; the revolved arcs keep
a face each.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 17:09:44 -04:00
Brett LawsonandClaude Opus 5.5 a2d5971be5 smlib: the quarter-cylinder sheet offset and the half-disc extrude match the C++ kernel on solidcore
offset_sheet_quarter_cylinder (both solidcore tests) and extrude_half_disc_split_arc's
solidcore_matches_the_cpp_kernel pass: solidcore#1495's linear_sweep_arc_is_cylinder (fork
12918e9, now on) sweeps the partial arc to an SmCylinder as the C++ kernel does (solidcore#1477).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 21:59:53 +01:00
Brett LawsonandClaude Opus 5.5 b0568524be smlib: solidcore's four new fork-carried opt-ins are on; the trimmed face tight box waits
boolean_new_face_closure_both_sides (WR-584, smlib@69c5198), linear_sweep_arc_is_cylinder
(#1477, smlib@12918e9), offset_closes_loop_gaps (WR-578, smlib@7ff0a94 and 34318f4) and
cylinder_plane_tangent_within_tolerance (WR-510, #1525; smlib#55, squash-merged as c2f1788 with
SmCone.cpp as in the bd20f6e the flag cites) are on: their fork commits are in SMLIB_REV 68fb9162.
face_tight_box_searches_trim (WR-588, solidcore#1811) is the fork's beb6061 from smlib#68, which
landed after 68fb9162, so it goes on HELD_BACK. The three held-back flags have no fork commit in
68fb9162 yet.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 21:59:53 +01:00
Brett LawsonandClaude Opus 5.5 f64857f953 solidcore: move the pin to 15e72dff9 (main, with solidcore#1752, #1495, #1796)
Merged since bba8d8798:
- #1752 opt-in two-sided closure test for a new face (WR-584, fork 69c5198)
- #1495 opt-in linear sweep of an arc square to its plane makes a cylinder (#1477, fork 12918e9)
- #1758 opt-in offset closes loop gaps between offset faces (WR-578)
- #1571 opt-in plane within a face's zone tolerance of a cylinder wall touches it along one line
  (#1525, WR-510)
- #1811 opt-in trimmed face's tight box is found inside its trim (#1799, WR-588)
- #1796 test: an offset surface exports through ApproximateSurface (#1441)
- #1751 test for stitch_solid_nests_cavities (WR-569)
- #1738 ResolveOverlappingProtoEdges sets point-class parameters on lent B-reps
- #1803 resolve_overlapping_proto_edges stops an overlap group that re-forms forever (HANG-51)
- #1820 screw sweep with exact walls and axial cylinders (#1162, #1163)
- #1706 SmOffsetSurface and SmSrfInVolume AssertValid
- #1358 the brep_p3 runner refuses the HANG-16 regime on the Rust side too
- #1791 curve_class/point_class dispatch gaps are not unported
- tests and difftests: #1719, #1824, #1373; plan: #1780; CI: #1810, #1802

main's CI test job passed on 15e72dff9.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 21:44:01 +01:00
Brett LawsonandClaude Opus 5.5 5f7a21157e smlib: the half-disc extrude's C++ comparison cites solidcore#1477
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 21:39:50 +01:00
Brett LawsonandClaude Opus 5.5 fecd4bee35 smlib: an extruded profile's arcs on one circle sweep one wall face on solidcore
Ports tangency-labs/smlib 7dee48f (capi/src/smlib_sweeps.cpp, one_wall_per_circle) to
the solidcore extrude: before a straight sweep, each run of consecutive arcs of a loop on
one circle (centres and radii within the zone tolerance, axes alike at the rim) becomes one
arc; a loop made only of such arcs is the full circle, its seam at the drawn circle's start
when the arcs share its frame, else at the middle of the longest arc. Draft, revolve and the
other sweeps are unchanged.

Tests: a circle drawn as two halves (one frame) and as a quarter plus three quarters (two
frames) extrude to 3 faces, 3 edges, 2 vertices with one cylinder, area 150π and volume
250π, on solidcore and on the C++ kernel (parity on counts and kinds); a half disc whose arc
is two quarters gives one curved wall, 4/6/4, area 75π + 100. Its kinds parity is ignored:
solidcore sweeps any partial arc (a single half arc too) to a surface of extrusion where the
C++ kernel makes a cylinder.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 21:33:16 +01:00
jyvikoandClaude Opus 5.5 26b42048c0 Preferences: the Body check note says each option in one short line
"After every step: checks each sweep, boolean and blend." / "Once per
feature: checks each feature's result once." / "Off (experimental): no
check.", in the order the options are shown, in en, ar, he, ja, zh, de
and ko.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 16:19:33 -04:00
jyvikoandClaude Opus 5.5 a71450aebd Preferences: symmetric surface extrudes read only the total distance
The Design preference surface_extrude_symmetric_per_side, which gave new
symmetric surface extrudes their distance on each side, is removed with
its Surfaces section, its session field and its labels. A symmetric
surface.extrude given no convention splits the total around the start
plane, as solid.extrude does; timeline.edit and timeline.redefine give a
one-sided extrude made symmetric the same. default_extrude_convention,
which only existed to read the preference, goes too.

An explicit `convention: legacy_per_side` and the marker saved designs
carry are unchanged. A saved preferences file that carries the key loads
as before (the prefs test now covers both removed keys).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 16:19:33 -04:00
jyvikoandClaude Opus 5.5 2ae53d387f Preferences: metric tapped holes drill only the tap maker's drill
The Design preference metric_tap_drill_major_less_pitch, which gave new
metric tapped holes the major diameter less the pitch (M8: 6.75 mm), is
removed with its Holes section, its session field and its labels. A new
tapped hole given no diameter drills the tap maker's drill (M8: 6.8 mm);
a custom metric size the table lacks still takes the major less the pitch.
A saved preferences file that carries the key loads as before: serde
ignores keys Prefs doesn't have, and the key is not written back.

The preference's UI test becomes an engine test of the default drill
(M8, 1/4-20 UNC, a given diameter) and a prefs test that a saved file
with the removed key still loads.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 16:19:33 -04:00
jyvikoandClaude Opus 5.5 222211de43 Model cache: a thinned model keeps the check mode only as the model records it
SavedModel::thinned wrote `"validation": null` into the records of a model
that records no check mode, so a thinned model was never the model it came
from, even with room for every state, and its manifest grew by that key
(design::tests::a_thinned_model_keeps_the_final_state_then_the_slowest_that_fit,
a_model_cache_too_big_for_the_file_keeps_fewer_states). It copies the mode
when there is one and adds nothing otherwise; the tests' timeline model records
one, as every saved model does now, and a thinned model is asserted to keep it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 16:19:28 -04:00
Brett LawsonandClaude Opus 5.5 bb4ff018e5 Merge develop 6700e6ef into solidcore
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 20:48:25 +01:00
Brett LawsonandClaude Opus 5.5 9a901d1362 smlib: tag history on solidcore is one application Tag per object, with the capi's handlers
solidcore#1747 lets an application attribute class override SMLib's handlers
(AttributeHandlers, Attribute::application), so history on solidcore now carries the capi's Tag
(smlib_history.cpp at tangency-labs/smlib f8fd83e2) as it is: one attribute of id
SM_AI_USER_1 + 7 per face or edge holding its origins, boundary edges and `at`, copy behaviour.
Split sets an untagged child to the split object's tag with its `at` (the fork's 1c7accd) and
joins it into a tagged one; Merge joins the tags on the sources other than the result; Coincident
joins into the target; Copy is SMLib's default. join leaves `at` alone, or adds a Tag without one
in place of whatever attribute of that id was there.

The two deviations the per-origin Generic attributes had are gone: a copy onto an object that
already has a tag now keeps that tag only, and an untagged object a merge or coincidence lands on
gets a tag with no `at`.

New C++ parity tests: a post subtracted from the cube it stands on, and a cube subtracted from
the one beside it, copy onto tagged entities (both fail on the per-origin port); a post imprinted
against a cube's side splits the top's edge into three, each piece lying where the edge lay, so
the side is Kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 20:23:40 +01:00