crates/smlib now wraps solidcore alone; the crate keeps its name (the
rename is a later move).
- Gone: the C++ FFI (src/ffi.rs, src/ffi/), build.rs and its `cc`
build dependency, SMLIB_REV, SMLIB_PREBUILT, the `native` feature, the
backend routing (src/route.rs: Backend, the choice, SOLIDCRAFT_KERNEL),
init(), the C API's log and profiler lines, the flat-array handle
(flat::Flat, Brep::export) and the history records' decoder. Brep is
solidcore's body; Error loses NotBuilt and Version; set_dump_dir can no
longer fail. blend_fit/Fit go: only the C++ kernel ever named a fit.
- The `smlib` feature is gone from the kernel, the engine and the apps
(cli, web, desktop); the kernel's smlib-gated tests and the board fixture
example run on solidcore, the side-by-side boolean example (a comparison
with the C++ kernel) is deleted.
- Tests that compared with the C++ kernel are deleted (the parity and
closed-form halves run on C++, cpp_round_trip, arrays_match_the_cpp_kernel,
validate_refuses_what_the_cpp_kernel_refuses, the cross-kernel file test,
the SSI corpus run on C++). Their solidcore-only assertions stay in the
same files as checks against solidcore: the blend and boolean history
changes, the offset drafts (one Unsupported, all building), the L sheet's
thickened volume, the 871 rounds and the moved mitred top. The tests that
were built only with the C++ kernel and already ran on solidcore (ops,
sweeps, check, measure, import, export) are ungated.
- tests/KNOWN_FAILING_TESTS drops the six lines of the deleted comparisons.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
- file.export_step, export_stl, export_3mf, export_obj: a 30x20x10 box
written and read back (the meshes converted to a solid): V 6000,
A 2200, 6 faces, box (5,-10,0)-(35,10,10).
- file.export_urdf: a hinged arm on a grounded base: 3 links, 2 joints,
and the base's mesh, written in metres, reads back as the
1 x 0.5 x 0.2 box (V 0.1, A 1.6).
- body.print_face: a cylinder's flat end is accepted, its side refused.
PATHS adds the URDF writer and the print face modules.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
- assembly.mass_properties: two boxes (2 g/cm3) in a rigid group: mass
0.006 kg, centre (18.333,5,5), inertia diag(0.1, 1.0333, 1.0333) kg mm2
by the parallel-axis theorem.
- occurrence.align: a block's end face onto a base's top face: a quarter
turn about y, centre (70,20,20), box (65,15,10)-(75,25,30).
- joint.find_limits: a slider between two stops: min -20, max 10 mm.
- component.move_features, browser.reparent and
component.move_sketches.to_parts: items moved into a turned and moved
part keep their world place (volumes, centres and boxes by hand).
The mass case assigns a material it creates, so material.create and
material.assign leave EXEMPT. PATHS names the new command modules.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
62 of the commands main added change no geometry: the view and render
panes, rendering lights and results, appearance tools, settings profiles,
point clouds (drawn as points, never a body), the selection, two sketch
edits, component links and History bar visibility, edit.repeat,
timeline.play, inspect.compare_picture (a picture against the outline),
and component.paste_from_design, which pastes the app's cross-window
clipboard that no command fills. Each joins EXEMPT's first section under
its family's reason.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
- The per-target cut loop skips a body whose exact box lies clear of
every tool's, as main's version did with mesh boxes. The sheet culls
(#10226, #10301) and this one now leave the far sheets and bodies alone:
a_cut_leaves_bodies_it_cannot_reach_as_they_were passes and leaves the
known-failing list.
- a_cut_still_runs_where_its_tool_touches_grazes_or_meets_a_curved_face:
a tool 0.5 µm clear of the block is now left out (exact boxes; 0.5 µm is
far past the bodies' tolerances); touching and 0.1 mm in still cut.
- Known failing, with reasons: main's edge lookup by a stored point
(#11286, on the display mesh) is not taken; SMLib refuses the
wrong-way chamfer for its tangent chain first.
- EXEMPT: main's eight new sketch-only commands.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
Three conflicts:
- crates/smlib flat.rs and export.rs: #8526's export copies the C++
arrays by id range; the ranges now run to the ball-patch arrays
(FACE_DEFINITION_REAL_COUNT, FACE_DEFINITION_REALS), with
WIRE_EDGE_NURBS_FORM (35) and FACE_DEFINITION_REAL_COUNT (36) both kept.
- tests/KNOWN_FAILING_TESTS: solidcore's lines and develop's, each test
once; tests/KNOWN_FAILING_TESTS.smlib takes develop's SMLib a18bbe5 lines
too. The first full run trims both.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
Develop's CI after the a18bbe5 pin (run 41522001173) fails 14 tests that
passed on f916a8d, and passes two listed ones. Each new line says what the
test sees on v1.1.0-alpha; v1.1.0-alpha.1 fixes the setback hole's cause.
shell_tangent_chain_that_opens_every_face_explains_how_to_keep_walls and
oracle 37-pyramid-apex-blend pass and leave their lists.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
On SMLib v1.1.0-alpha, 06/018 makes 597 or 594 edges from the same input:
the union's post-process keeps pointers to edges it has deleted. A golden
entry's `unstable` reason makes the gate compare that case's status only
and name it in its output; recording keeps the reason, and only an edit of
the golden removes it. v1.1.0-alpha.1 fixes the cause and removes the mark.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
Fixed (off the known-failing list): the Mixed corner's peg cases and the concave arc with the front top edge (smlib #123), and the 40° boss junction (smlib #124). Eight cases in all.
New failures, recorded as they are, each with its reason. They passed on f916a8d.
- **Six cases grade a blend seam G0 where G1 (or G2) is wanted,** at the end of the round's contact seam, after smlib #124's End at a smooth vertex. Two of them also shift in volume.
- **Four cases come back unsupported** after smlib #125, which leaves setbacks to the Setback's corners only.
- **Ladder 07/012** makes 9 faces, 20 edges and 13 vertices, where its golden had 8, 18 and 12. Its golden entry is the new result, with the reason added.
Whether each change is by design or a defect is being established. A defect is fixed in solidcore, where the End and the Setback are being brought over (#2364, #2365), not in the frozen SMLib.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
SMLib's flat arrays now carry the corner of three equal rounds as `SURFACE_BALL_PATCH` (kind 6): its net as a NURBS face's block, with its sphere's centre and radius as its definition (ids 36 and 166). The record reads it as `ball_patch {center, radius}`, a label like the analytic kinds, with the net as its `nurbs`. A plain sphere with a form won't do: the net is not a piece of SMLib's sphere NURBS, so SMLib's `IsNurbSurfaceSphere` would refuse it.
Written back, a ball patch is kind 6 with the same definition, which SMLib takes once its net is certified on that sphere. Elsewhere:
- Offsets classify it as its sphere, so its offsets stay exact and collapse at the centre.
- Face kinds count it as a sphere: fillet_three_edges_at_a_corner's corner is now `sphere`, no longer `other`.
- STEP, which has no ball-patch entity, gets the net as the face's B-spline surface, pcurves included.
- Iso curves and SSI of the label are refused; the face's form is what evaluates.
Test: a_rounded_cubes_ball_patches_go_round_with_their_spheres. The cube's eight corners are ball patches about the corners pulled in by r. Points of each patch lie on its sphere to 1e-12. The patches are kind 6 again after import, with the same definitions bit for bit, and the closed-form volume holds.
Format: pending/ball-patch-faces.rs. Docs: docs/native-brep.md and the rig README's `surface_types` (`ball_patch`).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
On the Blacksmith CI runners two quick same-size writes can share a modification time, and a
stale review page once accepted changed art there
(test_changed_art_reopens_and_requires_deliberate_current_acceptance failed intermittently).
art_rev() now hashes every file by content on main (b622a466); this test keeps it that way by
giving an edited SVG its old timestamp back and checking that the stale page is refused.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
solidcore, the pure-Rust kernel, is always built and stays the default. The
`smlib` feature (apps, engine, kernel; solidcraft-smlib's `native`) now has
to be asked for to compile and link SMLib: the app, the CLI and the web app
drop it from `default`, and solidcraft-gpu's dev-dependency no longer forces
it on. Without it no C++ toolchain, fetch-smlib.sh, prebuilt or build.rs work
is needed.
On a build without it, asking for the C++ kernel (SOLIDCRAFT_KERNEL=smlib,
diagnostics.kernel, the rig) is refused with Error::NotBuilt, which now says
"this build doesn't include the C++ SMLib kernel; build with --features
smlib", and SOLIDCRAFT_KERNEL=smlib logs that once. `cargo xtask
kernel-cases` builds the CLI with --features smlib only when --kernel smlib
or both asks for it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEtwSrdwZxqTQp5MfnU
Conflicts, resolved hunk by hunk:
- main's mesh-based changes stay out:
- #10303's `beyond_cylinder_reach` (eval_thread);
- #8634's `cut_end_past_face` (eval);
- #9009's mesh surface-patch pick in `project3d::part_of`, which would add a mesh decision.
- frames: `split_move` keeps propagating `world_state`'s error, not swallowing it.
- surface_analysis and eval_cost_tests: the same code; our side.
- KNOWN_FAILING_TESTS: our #9107/#8634 reasons; brett's new `a_hole_wider_than_the_part_says_it_removes_all_of_it` (main's #10701 on SMLib); the mirrored-mesh test known-failing until the mesher moves to solidcore.
No excluded symbol came back (`beyond_cylinder_reach`, `cut_end_past_face` and the rest, counts unchanged), and no truck dependency.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
SMLib f916a8d's setback corner (smlib#104: three rounds of different radii, the curvature
rounds' G2 corner, too-short setbacks refused naming the least) is solidcore#2310, not ported
yet: five tests that now want it fail on solidcore. Main's three tests that assume truck fail
here as on SMLib. blend_fit asks no kernel on solidcore (it names no size there yet).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
- Cut To the far side of a curved wall (#8634): the tool stops past the first crossing of the
face ahead of the profile; SMLib's whole bore is one face that a line crosses twice, so the
single-crossing rule found none and the cut took nothing.
- Clearing view analyses goes through refresh_display, as main's #10687 made the others, so an
open feature editor keeps OK and Cancel after Zebra.
- vi, a complete catalog on main, gets the setback-too-short message.
- fillets/KNOWN_FAILING: 4782's cause is now its continuity check (SMLib f916a8d builds the
expected volume).
- Known failing, as main's tests assume truck: the spline wall's spans as one mesh patch, a
hole touching an edge at a point leaving one body, and a copy of a copy's triangles matching
a fresh mesh.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
1213: the loft is a cubic skin through the five sections (ellipses between
them), not a torus; its volume 131601.597487935 by quadrature less the exact
rolling-ball removal 233.662461919 gives 131367.935026 (was a Pappus estimate
on a torus, 131360.148, at rel 5e-4).
4782: the section's area in closed form, 25 pi/3 - 5 sqrt(75) + 25, so
V = 630.2934873 (was a grid estimate, 630.293125).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
Develop's structure stays: the SMLib kernel, the fallible world state, the thread code in
eval_thread.rs, exact record curves for intersections. Main's changes are applied to it:
a split solid.move (#9660) in the fallible to_local, the identity placement shortcut in the
fallible placed body, the mirror's kept meshes against stamp(doc, ...), the AO term passes
with open bodies in the prepass, the section index for every normal, Edit Hole's seed, the
context refusal note, analyses turned off through refresh_display (#10687).
Not taken (main's mesh-based versions; tests listed in KNOWN_FAILING_TESTS): the tap marking
and cut box shortcuts (#10303), Cut To the far side of a curved wall (#8634), Sketch Intersect
by surface patch (#9107).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
Rig (fillets/KNOWN_FAILING.solidcore): the two 851 rows develop now rounds with their tangent
chain fail 1001 as on SMLib; the pipe on a plate's curvature round is graded to 5e8c9c1's
section, which solidcore has yet to port. Tests (KNOWN_FAILING_TESTS): main's box STL and
boss-torus tests, as on SMLib; the box-corner test and four C++ comparisons that expect
5e8c9c1's Ball corners and rounds.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
Each round runs whole to its section square to its edge at its setback (the owner's rule, at
least 1.5 r, scaled to the least at which the G1 fill is certified convex), and the hole is the
setback split: one patch per round and the triangle in three quadrilaterals, 15 faces, G1.
Outside the box the sections span the body is the three strips', so its volume is theirs within
that box's. A later r3 round at the mitred corner makes the body all three at once make
(7928.142563938, 15 faces), as the engine and the model-cache tests have it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
smlib b7e83cd7c: origin/develop (SMLib pin 5e8c9c1) and origin/main.
Conflicts, both sides kept:
- Cargo.toml: solidcore's pinned solidcore dependency beside main's solidcraft-testkit.
- tests/KNOWN_FAILING_TESTS: solidcore's default-kernel list kept (refreshed from this
merge's run in a following commit); smlib's list for SMLib 5e8c9c1 becomes
tests/KNOWN_FAILING_TESTS.smlib.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
solidcore#2223 (closed by #2302, under fillet_section_end_trim_at_creases):
the R25 rim and the x > 0 R2 corner arc rounded together at r 0.5 on the
plate 2 high take off 8.117810114 (the rim's 7.958674274526857 and the
corner arc's Pappus 0.15913583972191622) within 1e-7, 12 faces, valid. A
new test beside the tabbed-plate test, which shares its outline.
The tabbed-plate test gets past that pair and now stops at the two R2
corner arcs picked together: 1001 in trim_at_creases (cliff_overflow with
the crease trims off), though each builds alone (solidcore#2314). Its
known-failing line says so.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
The rig on solidcore: 982/1014 pass (968 at pin 13). Fourteen cases
come off the lists (the curvature rounds, the variable cone, 3604's G2
swept tool, the curvature fillet after a fillet). Six remain with new
causes: the G2 pocket corner and the bar corner's three edges (two) G1
at one seam and the cylinder-side G2 corner not closed, as on SMLib;
the oblique three-edge corner refused for its mixed wedges; the mixed
corner refused as on SMLib.
Tests (nextest, ci profile, PR filter): 34 come off
KNOWN_FAILING_TESTS (curvature and variable rounds). three_rounds_at_a_corner
is listed (its corner's variable transition at 0.144°, as on SMLib
d01d7b0); chord_and_variable_fillets now fails on its waist law's
corner (solidcore#430).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
A seam's two sides are the same face, and edge names list each face an edge
bounds once, so SMLib's extruded circle names its side's seam F2:side:c1, with
no separator. The name grammar now says one face also means a seam. The #5858
test no longer counts one '|' an edge: every part of every edge name is a
whole face name of the edge, one per face it bounds, two for the rims and one
only for the side's seam (checked to run bottom to top on the circle).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
The R20 fillet with fit reduce on one top edge of a 10 mm box builds on SMLib
without a reduced-radius warning, so the fixture had no warned feature. It
now rounds the four vertical edges at R6, reduced to the full round (5), as
the copy-warning test beside it does, and checks the warning says so.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
SMLib meshes a 10 mm box in 108 triangles, so the hard-coded 12 a box stopped
the test before it reached the culling. The expected counts are now each
body's span in the scene.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz