ISO 4753's chamfered end bounds the end's diameter by the minor diameter. The default took the
modelled root (the basic d1) for it, so the cone's small circle lay on the root cylinder and
the chamfer ring pinched to nothing wherever the groove reached the end. The default is now
the external minor diameter d3 = d - 1.226869 P of ISO 724, below d1: the cone crosses the
root, each end is a whole disk of d3 inside a whole conical ring. ISO 4753 is for ISO metric
threads; the other forms, whose root is already their design minor, give chamfer_depth.
Ladder 06/017's analytic volume follows (1945.354522563); its golden entry re-measured.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A regression test for the groove stopping at the plate's top: the boss loses the
closed-form volume and the plate keeps all of its 9600 mm³, with and without a runout
and a chamfered tip.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Curvature continuous is the Type entry's name; Corners (Ball, Smooth patch) and Setback are
described with the command words they write. The codes (G1, G2) stay in the text, where they
explain the words.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
Patch, Boundary and Blend Surface list Position, Tangent, Curvature and Curvature change; each
order's code (G0 to G3) and what it means is in the row's hover text. The Continuity Analysis
legend, its seam markers and its status line use the same words (Crease for a G0 seam). The
segments now draw their labels translated. The new labels carry over each catalog's existing
translation with the code taken off, so no language loses its wording; a word another label
already translates keeps that translation.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
The Continuity G1|G2 control repeated Type (both set `type`) and G1 silently cleared the
corner; it is gone, and Type names the section in words: "Curvature continuous", its code (G2)
in the row's hover text. The vertex choice moves out of Advanced as Corners: Ball | Smooth
patch, shown only while the edges have a corner where three or more rounded edges meet (or the
fillet already has a smooth patch), enabled for Constant radius with Exact fit and saying why
when not. Smooth patch shows Setback: one distance for every corner, sent as `setbacks` at each
corner's vertex; left empty, the command's default (1.5 x the radius) applies. A fillet saved
with setbacks reopens with them: one distance at exactly the dialog's corners shows in Setback,
any other list is kept as saved. "Smooth" in Variable Radius is "Smooth radius change". The
stale "G2 corner construction is not supported yet" tooltip and the "Fit and G2 corners" note
are replaced by new messages (en, ar, de, he, ja, ko, zh).
No command parameter changes; saved designs open unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
A face whose boundary crosses itself in (u, v) (a cusp, a sliver whose sides
sag across each other) was an error, and the body had no display plan. It is
now planned once more with a lenient constrained Delaunay in (u, v): sides
crossing one already kept are left out, the rest is seeded and refined as any
face, and its points lie on the surface, where the GPU evaluates them. The
display has no hole, but the face is still a defect upstream, in its pcurves
or seams: PlanStats::lenient names it with the strict plan's refusal, and the
display plan logs a warning for each such face, so it is never silent.
The face boundaries keep coming from the exact pcurves (d61efb306); cdt::Fill
gets its `lenient` field back (dropped in 3f2585569). The old flat fill (#4021,
tess/fallback.rs) stays gone: develop removed it in 9138e8704. A face the
lenient fill refuses too (loops that do not close in (u, v), or wind round a
seam or pole) stays an error naming the face. Closes#4453's intent on develop.
(cherry picked from commit 84de5aa071)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
SMLib's out_failed_corner reaches Rust as Error::CornerRefused { corner }, and the
kernel names the corner by its point: a G2 fillet at a corner of mixed convexity
says where it is and that SMLib sets back only corners whose rounds are all
convex or all concave. Engine test checks the message through solid.fillet.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
The inner corner of a 20 x 20 x 10 notch in the 60 x 40 x 20 box, three
concave r5 rounds with corner: g2: one valid body of 13 faces within the box,
the patch's twelve seams jumping at most 1e-3 per mm clear of the hole's six
corners (2.7e-4 measured; the ball corner jumps 0.2). The continuity check
looks within 11 mm of the corner: the vertical round, 2.5 mm long past its
setback, meets its faces 11.2 mm out with every round's G1 jump.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The inner corner of a notch, three concave r5 rounds, takes the set-back G2
patch as a convex corner does: one valid solid with the ball corner's 13
faces, seam jump 6.3e-4 per mm clear of the hole's corners against the
ball's 0.2. A corner of two convex rounds and a concave one is refused as not
supported: SMLib sets back only corners of one convexity.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
expected.json `continuity`: over the tangent seams wholly within `within_mm`
of `near`, the curvature jump across them (exact surfaces, 65 stations a
seam) at most `curvature_jump_per_mm` clear (`clear_mm` along the seam) of the
vertices where two of them turn, where a neighbour's own G1 seam ends.
07/015, the box corner's three r5 rounds with corner: g2: one valid body of 10
faces within the box, its patch's twelve seams jumping at most 1e-3 per mm
clear of the hole's six corners by 1.2 mm (2.7e-4 measured; the ball corner
of 009 jumps 0.2). Its golden entry is the passing run's.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
FeatureKind::Fillet with corner G2 is kernel::fillet_g2_corners, its setbacks
the corners' distances (the rest 1.5 r); setbacks now go with either corner.
The engine's corner test builds the G2 corner, default and set back 7, one
closed solid of 10 faces within 0.1% of the ball corner's volume.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A corner where three or more rounded edges meet, every edge there rounded, is
set back (1.5 r unless a setback names it) and left open by SMLib
(blend_smlib::fillet_setback_open: the sheet and each corner's hole, in the
sheet's orders); each hole is filled by fill::matched_patch, the height field
over its plane fitted to the position, tangent plane and normal curvature
across the boundary of every face beside it (exact second derivatives), rounds
and planes alike, each edge's pcurve its exact projection; SMLib sews the
sheet and the patches into one solid, which must close. The history is the
sewing's carried through the sheet's, each patch face made from the rounded
edges its neighbours come from.
corner_g2 is that construction now. The polar patch over three sections it
held (never sewn in) could not be: its boundary is a closed cubic through
stations, which rounds off a corner of the loop, and the setback hole has six.
The 60 x 40 x 20 box corner of r5 rounds (07/015): 10 faces, a valid closed
solid (record and SMLib's check), curvature jump across the patch's seams
6.3e-4 per mm clear of the hole's corners against the ball's 0.2; set back 8
between the hull and prism bounds; set back 11 to 15 inside the box but by
under 7e-4; all eight corners of a box filled; refusals named.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SeamReport.stations: each station's edge fraction, gap, normal angle and
curvature jump, alongside its point, so a seam's profile (where a jump holds,
where it fades) can be read and plotted, not only its worst value.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
smlib_blend_setback_open's binding: the sheet, and per corner a Hole, its
edges in order (each starting where the one before ends), each with the face
beside it and whether that face runs it forwards. The holes' buffer starts at
64 edges a corner and grows once to the length a first call names. Tested on
the r5 box corner set back 8: 9/30/22, a sheet SMLib's check passes, one hole
of twelve edges chained end to start; an unrounded edge at the corner is
Unsupported.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fill_loop's bicubic height field over the loop's plane, fitted to the
neighbours' derivatives as well as the loop: every condition of a graph is
linear in its heights (G1: the gradient from the face's normal; G2: the second
derivative along the face's leave direction from its normal curvature), so
one banded least-squares solve with the thin-plate energy decides the surface.
Its parameters stay plane coordinates, so an edge's pcurve is still the edge
projected onto the plane, exactly.
Where a round's section meets a plane at a corner of the loop, the section has
the round's curvature and the plane is flat across its own curve: no surface
is G2 to both there. The G2 rows fade in over 15% of the run from each corner;
asked over a few cells instead, the plane's flatness to the second order along
its curve pulls the surface off the whole side. Grids go to 128 spans, which
G2 to a plane along a curved line needs. The thin-plate weight is a thousand
times fill_loop's: with the slope and curvature rows acting a little inside
the loop, the weaker one let the surface rise past a plane it is G2 to (0.06
mm at a box corner of r5 rounds set back 8).
loop_frame is fit_once's plane, shared.
Tests: the hole a setback leaves at a box corner of r5 rounds set back 8,
within 2.2e-5 of the loop, 0.027 degrees and 4.7e-4 per mm of its neighbours
clear of the corners; set back 7.5 to 15, under its planes but by under 7.2e-4;
a hole in a cylinder filled with the cylinder's own second order; refusals.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What each category records, self and total time, the table and the Chrome
trace; the CLI's --profile and --profile-out on scripts, designs and STEP
files; diagnostics.profile over the control channel.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
The profiler is process-wide, so the engine's other tests (the schema
check's failing diagnostics.profile calls among them) record into it while
this test does. It now shows the reset by the wall time starting again,
and checks only rows that are certain to be there.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
- Graphics page: "Profile operations" (off by default) starts and stops the
profiler when it changes; an agent's diagnostics.profile in between stands,
and SOLIDCRAFT_PROFILE=1 is not undone by the default at start-up.
- The desktop app reads SOLIDCRAFT_PROFILE at start-up.
- Labels in en, ar, de, he, ja, ko, zh. The pending-messages test compares
right-to-left pending text in display order, as the catalogs give it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Session::execute is a command span; Model::evaluate and each feature computed
(by its type) are spans; io's import, export and design read/write too; the
STEP reader's topology, pcurves and solid record.
- diagnostics.profile (contract + output schema): report, start/stop, reset,
Chrome trace file.
- A STEP/IGES import's reply carries its own profile while recording.
- Every app compiles the profiler in by default (feature `profile`);
SOLIDCRAFT_PROFILE=1 starts it.
- solidcraft-cli run/eval/bench-open --profile print the table on stderr,
--profile-out writes the trace; run --profile works on designs and STEP files.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Booleans, blends, sweeps, lofts, shell/draft/offset, healing and sewing,
SMLib conversions, meshing and measuring; the import as parse, index,
per-solid read, placement and mesh check, convert batches and finish.
The existing per-step boolean/tessellate capture names its spans too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The C API logs each call with its steady_clock time; the log sink records
that as an smlib span (child of whatever runs on the calling thread).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
solidcraft-profile (L0, standalone): spans with self and total time, SMLib-timed
records, a bounded trace (200k events) and an aggregate that stays; compiled in
with the `enabled` feature, off at run time until switched on.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An edge is left out of the shaded view only where its two faces meet
with one tangent plane (normals within 0.5 degrees) and one curvature
across the edge: at each station the faces' normal curvatures square to
the edge agree within 0.5 degrees' worth, |k1 - k2| <= 0.0087 x
max(|k|, 1/L), L the edge's length, so the continued faces turn apart
by no more than that over a radius of curvature or the edge's length.
Fillet boundaries (0 to 1/r), corner-patch joins and a plane tangent to
a cylinder are drawn again, straight ones included. A modelled thread's
flank pieces (one sweep) differ by at most 0.0046 and stay hidden.
Second derivatives of a spline surface now exist at a boundary point a
pcurve carries a rounding step past the knot range, as its point and
first derivatives already did.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Smoothness (normals within 0.5 degrees) and a crease are separate
verdicts. A crease is certified where the normals differ by more than
the evaluation can account for: each pcurve point's measured distance
off the edge's own curve times the faces' larger principal curvatures.
So a real crease too small to see is not drawn in the shading but stays
a pickable edge in the wireframe, overriding a coarse same-surface seam
fit, as before; exact tangent joins (fillets, seams, a thread's flank
pieces) are no crease.
The viewport's smooth-wall test expects the wireframe to draw
`edge_visible` edges: the offset ellipse's pieces meet at real creases
of 1e-4 rad that the old checker could not certify.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The M10 thread's 32 flank-piece joins meet with normals about 1.5e-6
degrees apart (measured independently with seam_diagnostics); each is
left out of the shaded view, stays pickable and stays in the wireframe.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An edge is left out of the shaded view when its two faces' outward
normals, evaluated on their exact surfaces at each use's own pcurve,
agree within half a degree at eight stations along it (a seam one face
meets itself across is the same test with its two pcurves); it is a
protected crease when they differ by more. Replaces the special cases
for ruled clamped Bezier patches, planes, cylinders and cones. Fillet
tangent joins and corner-patch joins are hidden too; they stay
pickable and in the wireframe.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The truck vendor/ crates went with the kernel's move to SMLib, so their
mapping and the test that selected the kernel for vendor/truck-shapeops
are gone; egui-wgpu is the one vendored crate left.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
A collapsible if (assemble.rs), two manual assign operations (sew.rs), a range loop indexing
the placement inverse's translation row (step_in), and two needless borrows (engine features),
which failed CI's clippy -D warnings. No behaviour change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Seven labels of the thread dialog had no English catalog entry, so they stayed English in every
language (every_ui_label_literal_reaches_an_english_catalog_entry): Extent, Ends, Chamfer Angle,
Chamfer Depth, the two ISO 4753 hints and the designation hint. They are in
assets/locales/pending/thread-dialog-labels.json with Arabic, Hebrew, Japanese and Chinese, the
catalogs that must be complete. The ISO 4753 hints are looked up by id, and the designation hint
takes its example as {example}, so a right-to-left language places it where it reads.
pending_messages_are_in_the_catalogs compared a pending message with the catalog's text, which
for Arabic and Hebrew is in display order since #3768; it compares with that order now, as the
catalog stores it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Main's Arabic and Hebrew catalogs (#3768) arrived with thread.direction, thread.left_hand and
thread.right_hand, the labels of #4414's screw direction, which this branch replaced with the
thread's hand and took out of every catalog.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each job fetched the prebuilt SMLib into target/ before Swatinem/rust-cache restored target/,
which replaced it, so every build that links SMLib stopped with "SMLib ... is not fetched"
(the Docker image of #7403). The fetch now follows the cache restore in every job.
develop (the SMLib kernel's trunk until it merges into main) gets main's push runs: CI runs on
pushes to it, a push compares against the last passing push to its own branch, and its runs save
the Rust caches the PRs into it restore.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Move/Copy's pick from the browser (#4774) read Session::world_state as the placed model; it now
returns why a model cannot be placed, so the browser reads it as the other panels do, through
open_meshing::session_world (no placed bodies when it cannot be placed).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
v0.24.0 (format 39) saved a left-hand Thread or tapped Hole as `handedness: "left"`; this
branch replaced main's handedness (#4414) with the thread's `hand`, and features don't refuse
unknown fields, so such a design opened right-handed without a word. The pending format change
thread-hand.rs renames `handedness` to `hand` on Hole and Thread features (a `right` is
dropped, anything else refused).
Tapped holes take `hand` again, right or left (never both, and only with `thread`): the Hole
feature saves it, its thread is cut and annotated that way, solid.hole takes `hand?`, the hole
dialog's tapped rows have the thread dialog's Hand choice (without Both), editing a hole keeps
it, and hole presets save it under v0.24.0's `thread_options.handedness` key, so presets saved
by v0.24.0 recall it.
Test: a format-39 design with a left-hand thread and tapped hole opens left-handed; a hole's
`hand` refuses both and needs a thread.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every job that builds the kernel with SMLib runs scripts/fetch-smlib.sh after the toolchain:
the host's prebuilt archive, the matrix target's for cross builds, wasm32's for the web jobs.
RISC-V has no archive, so its check compiles the sources with g++-riscv64-linux-gnu.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HoZgkCdAVrscuw2kjQTWDs
tangency-labs/smlib's prebuilt workflow builds the C API once per commit for every Rust target
SolidCraft builds (Linux x86_64 and aarch64, macOS arm64 and x86_64, Windows x64, x86 and ARM64,
wasm32 with wasi-sdk's C++ runtime) and releases it as prebuilt-<commit>. SMLIB_PREBUILT pins each
archive's SHA-256. scripts/fetch-smlib.sh now downloads the host's archive (or the named
targets'), checks its hash and the commit it was built from, and falls back to the sources for a
target with no archive; --source fetches the sources, --pin writes SMLIB_PREBUILT from the
release. build.rs links a fetched archive whose hash matches the pin, else compiles as before,
now with -ffp-contract=off like the archives: every platform does the same arithmetic. No
network access in build.rs.
SMLIB_REV moves to 8b57e7e: the workflow, and fixes for MSVC (no directive inside a macro
argument, SM_PI for M_PI), the no-fused-multiply-add build and a test that needed a POSIX shell.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HoZgkCdAVrscuw2kjQTWDs
On the web target the smlib build compiles SMLib for wasm32-wasip1 with wasi-sdk's clang
(WASI_SDK_PATH), with wasm exceptions in the exnref encoding that wasi-sdk's libc++ and Rust
use, and links wasi-sdk's libc++, libc++abi, libunwind and libc. The WASI calls libc makes are
defined in ffi.rs: stdout and stderr go to the log, the clocks are the page's (the C API times
every call), and there is no file system or environment. solidcraft-web gets an smlib
feature, off until CI has wasi-sdk.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HoZgkCdAVrscuw2kjQTWDs
Code main added since the last rebase reads the placed model, a camera or a scene
as values; on this branch they return Result. Picks and the edit dialogs read the
session's placed model through open_meshing::session_world, as the others do; the
revolve and circular-pattern axes, the model axis of a command and the warming of a
computed edit pass the error on; tests unwrap. A test meshing bodies uses
Body::mesh, the one mesher.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HoZgkCdAVrscuw2kjQTWDs
The reworked thread has its own direction, `hand: right|left|both`, on SMLib's
exact screw sweep. Main's #4414 added a second one, `handedness: right|left`, on
Hole and Thread, for the faceted groove this branch replaces. It is taken out: the
field, its pending format change (never released), the hole dialog's direction row,
its hole-preset option, its strings and its tests, which measured the faceted
groove. A tapped hole is right-handed, as before #4414.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HoZgkCdAVrscuw2kjQTWDs
A modelled thread never changes the size of the shaft it is on (#1018, #2853): a
shaft thicker than the thread is refused with the size to make it, as
tests/kernel-cases/threads/2705 expects ("this 14.6 mm shaft is too thick for a
modelled M14 thread; make the shaft 14 mm for M14"). This takes out the turn-down
of #4256: `thread_turn`, the fit that let a thicker shaft through, and its tests;
the 9 mm shaft refusing an M8 and the preview's M6 refusal on an 8 mm shaft are
back as they were before it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HoZgkCdAVrscuw2kjQTWDs
Main's reader (#1609, #3845, #3928) and the branch's met in the rebase, and the
tree kept main's gap closing: it moved a trim piece's end vertex onto the mean
of the gap's ends without changing its curve, and widened the STEP file's
stated accuracy to cover the move. SMLib checks each edge against its vertex at
the body's tolerance and refused the box (SmTrimmingTools Edge/Edge Gap 0.005 >
0.00425, rig 3845); the first piece of a trim curve with no start point was
also turned against the second (rig 3913, "edge loop is not connected").
The reader keeps main's structure (groups and subfigure instances as products,
names, placements, separate lumps as separate solids, the originating system)
and sews each group's surfaces the branch's way: each meeting point of two
pieces is one vertex, where most piece ends there agree, and a line or clamped
B-spline that misses it is rebuilt to end there exactly. Main's limits on which
gaps are one corner written loosely (0.1 mm, 5% of the shorter piece) decide
which meeting points are joined; the stated accuracy stays the file's. A trim
curve's first piece starts at its end away from the second when no start point
is given.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The IGES reader (#1609) writes each group and subfigure instance's placement as a
CARTESIAN_TRANSFORMATION_OPERATOR_3D_NON_UNIFORM. The branch's STEP reader took
only the uniform operator, and only its origin: every IGES assembly placement
was refused ("placement location: expected a reference") and put at the origin.
An operator, uniform or not, is now read as main reads it: its axes (the global
ones where omitted), its scales (1, and the first for the second and third) and
its origin, refused when singular. A placement may then scale, so the inverse
that maps one placement onto another inverts the linear part by its adjugate
instead of transposing it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The corner pick (#5173) counts the edges meeting at a picked point; seams already
did not count, and now a tangent join between two spans of one smooth curve does
not either (4332: a chamfer on a spline rim was refused as two edges).
3383: the first occurrence is grounded by default on main, so the recipe
ungrounds it before moving it. 5024: a hole's position must lie on a face, so the
centre is on the box's top edge; the volume is half of the drilled cut, exact.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>