Commit Graph
4746 Commits
Author SHA1 Message Date
bherbruckandClaude Opus 5.5 8564006ffb Drawing: format_pending is one of the record's fields (#12448)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 01:45:23 +00:00
708d5a149d Plane at Angle: use axis direction only with a pivot (#12041) (#12131)
* claim: #12041

Co-authored-by: ReDead <ReDead@users.noreply.github.com>

* Plane at Angle: use axis direction only with a pivot (#12041)

Add a direction_only option that projects the axis onto the base and
turns about a pivot (or the base origin), with dialog checkbox and
conditional Pivot pick. Older designs keep turning about the full line.

Co-authored-by: ReDead <ReDead@users.noreply.github.com>

* i18n: add ar, he, vi for Use axis direction only (#12041)

Complete catalogs need every English message; the pending locale file
was missing those three so cargo xtask i18n --check failed.

Co-authored-by: ReDead <ReDead@users.noreply.github.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: ReDead <ReDead@users.noreply.github.com>
2026-11-06 01:38:49 +00:00
0c094142d3 Sketch Break and Extend: a cut or stop on a shape's centre ends there, with no second point (#12299) (#12301)
* Sketch Break and Extend: tests for a cut or stop on a center rectangle's centre

Breaking a center rectangle's diagonal at the centre leaves two points there, and extending a line up to the centre ends it on one diagonal only. These tests fail on main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Sketch Break and Extend: a cut or stop on a held midpoint ends there, as Trim does

Break dropped the broken line's Midpoint and joined the pieces at a new point held only on the cutter, so a center rectangle's centre came loose and a corner drag pulled the two points apart. It now uses Trim's rule (one helper, hold_cut): the pieces meet at the held point, which moves its hold to the cutter's middle when the sketch already implies that, and otherwise stays on the cutter.

Extend stopped on a point it lays on the curve it meets unless that curve ends there. A point held at another line's middle (a center rectangle's centre) is now a stop too, so the extension joins it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
2026-11-05 23:27:01 +00:00
1939adba6b Sketch Dimension: pick an origin axis as a reference (#2364) (#2373)
* claim: #2364

* Sketch Dimension: an origin axis can be picked as a reference (#2364)

The dimension tool ignored clicks on an origin axis and the engine's
sketch.dimension did not resolve x/y. Axis picks now map to the sketch's
linked axis line, as Symmetry and the other line constraints already do,
in all three entry points (click-then-pick, select-then-D, and the command).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Sketch Dimension: tests for a circle centre and a line against the sketch axes (#3137, #3320)

Folds in the cases from #3298: a circle's centre point dimensioned to the
x / y axis (#3137), and a line's angle and an end's distance to the x axis
(#3320). The axis resolution from #2364 already covers them; a plain circle
or arc with a line still measures to its edge (#1803).

Co-authored-by: Phanoob <phanoob@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Sketch Dimension: the axis test picks the line off its midpoint, which is a point pick (#4872)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Phanoob <phanoob@gmail.com>
Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
2026-11-05 23:13:42 +00:00
Robson PereiraandClaude Opus 5.5 207679e261 Face and edge dialogs name the body of their picks (#7174)
Fillet, Chamfer, Offset Face (and Press Pull on a curved face, which opens
it), Draft, Replace Face and Delete Faces sent only the picked points. The
feature then checked every body's edges for them and evaluated on the body
whose mesh box is nearest the first point (`body_at`):

- In an assembly, a bore or pin inside a housing that comes first in the
  body list was looked for on the housing, which has no face there, and the
  command failed with "no face at [...]".
- In a large design, `body_at` meshed every body (and Fillet/Chamfer worked
  out every body's edges) on each preview and apply: seconds per change.

These dialogs now name the body when every pick lies on one, as Shell does
since #4555; picks on several bodies name none, as before. Press Pull passes
a given body on to Offset Face.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:38:11 +00:00
github-actions[bot] 4cbbccb935 Regenerate generated files and fold pending files [skip ci] 2026-11-05 22:50:08 +00:00
PaddleStroke 22f8da2689 View: hold a shortcut to drag and zoom (#11701) (#11706)
* claim: #11701

* Allow assigned shortcuts to drag the view to zoom
2026-11-05 22:08:53 +00:00
51d8842e8a Create Sketch: the flat faces of a cone take an attached sketch (#7476) (#7772)
* claim: #7476

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Create Sketch: the flat faces of a cone take an attached sketch (#7476)

The cone primitive was evaluated as an unnamed tool, so its faces had
only geometric names, which a face attachment refuses as not exact.
Its faces are now named from the revolve that builds it, as a
cylinder's are: `bottom`, `side` and, on a cut-off cone, `top`. A
sketch on its base or top attaches by that history name and follows
the cone's height.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Fix compile after the layer split

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
2026-11-05 21:54:30 +00:00
95fd121bb3 Mesh export: mesh bodies in parallel and weld seams through a grid (#9613)
* claim: Mesh export: mesh bodies in parallel and weld seams through a grid

* Mesh export: mesh bodies on threads and find seam splits through a grid

STL, OBJ and 3MF exports meshed and welded one body after the other on
one core. Each body is now meshed (and welded) on its own thread with
map_on_threads, as the model cache encodes them; results stay in body
order and every body is welded on its own, so the files are the same,
byte for byte. Of several failing bodies the first one's error is the
export's, as before.

The search for vertices lying on open sides (T-junctions) looked at
every open-side vertex for every open side. It now bins those vertices
on a grid and looks only in the cells around each side; the vertices it
finds come out in the same ascending order, so the splits are the same.
A side whose box spans more cells than there are vertices, or that is
not finite, still looks at all of them. A test compares the result with
the previous all-pairs search (kept in the test module) on a cube meshed
at six resolutions per face with jittered vertices and broken triangles.

ASCII STL and OBJ write each line into the text instead of formatting
a string per line and appending it (same bytes).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Fix compile after the layer split

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
2026-11-05 21:54:19 +00:00
PeppaWutzandbherbruck 1444801d96 Agents and scripts: the canvas commands describe their exact parameters and reply (#12275) (#12338)
canvas.insert, canvas.decal, canvas.edit, canvas.calibrate and canvas.delete
now publish typed input and output schemas. Each parameter is read the way
the handler reads it today and refused with the handler's own message, and
the replies are built from the same types the output schemas describe, so the
JSON they return does not change. Their lines leave unconverted.txt.

The plane check of sketch.create's plane reader is split out so the canvas
contract can use it without changing what it accepts.

Part of #2829.

Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
2026-11-05 21:38:07 +00:00
github-actions[bot] 28dcbbc862 Regenerate generated files and fold pending files [skip ci] 2026-11-05 21:52:00 +00:00
7e96aabd6d i18n: catalogue 214 dialog labels; complete Czech terms (#8421)
Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 21:16:02 +00:00
github-actions[bot] 52893744a5 Regenerate generated files and fold pending files [skip ci] 2026-11-05 21:11:13 +00:00
Thijs DamsmaandCodex 4699b9cc89 Sketch library: include the built-in font in vendored sources (#12162) (#12174)
* claim: sketch font is included in vendored sources (#12162)

Co-Authored-By: Codex <noreply@openai.com>

* fix: include the sketch default font in vendored sources

Co-Authored-By: Codex <noreply@openai.com>

---------

Co-authored-by: Codex <noreply@openai.com>
2026-11-05 20:26:05 +00:00
4eb0c6f5ec Agents and scripts: Manage, Assign and List Plastic Rules describe their exact parameters and reply (#12313) (#12314)
* claim: #12313

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Plastic rules: input and output schemas for Manage, Assign and List Plastic Rules (#12313)

The three plastic rule commands get typed contracts and replies, in a
new `schema/plastic.rs` laid out like the sheet metal rules', and leave
`schema/unconverted.txt`.

- Each key reads as its handler reads it, with the handler's message:
  the rule name as `plastic.manage_rules` trims and limits it, `bodies`
  through `config::NameList` (which mirrors `params::string_list`), the
  ten rule values as `LengthExpr` and `AngleExpr`.
- `name` and `bodies` are optional in the types and required in the
  schemas (a `require` transform), so a call without them still gets
  the handler's own message.
- Keys of the wrong type that the handlers ignore today (a non-boolean
  `active` or `delete`, a rule value that is neither a number nor text,
  a non-text `from`, `material` or `rule`) are refused; in warn the call
  still works, with a warning. A test pins each one.
- The handlers build their replies from the reply types through a small
  `typed_reply`; the JSON is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Assign Plastic Rule: the schema's `bodies` is a name or a non-empty list, not null

The field is `Option<NameList>`, so its published schema allowed `null`
(from the `Option`) and an empty list (from `NameList`), both of which
the handler refuses ("`bodies` must list bodies"). It now has its own
schema: a name, or a list of 1 to 10 000 names. The reader is unchanged,
so strict still gives the handler's message for those calls. The schema
test adds both cases.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
2026-11-05 20:00:52 +00:00
PeppaWutzandbherbruck a07b60cd81 Agents and scripts: the linked-component commands describe their exact parameters and reply (#12277) (#12351)
component.insert_design, update_links, relink, break_link, links, extract,
copies and replace_with_link now publish typed input and output schemas.
Each parameter is read as its handler reads it today, with the same error
messages, and each reply is built from the typed value and serializes to the
same JSON as before. Their lines leave unconverted.txt.

Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
2026-11-05 20:00:28 +00:00
bd3053f57b Insert SVG: shapes a file only defines or hides are not imported (#11039) (#11050)
* claim: #11039

* Insert SVG: shapes a file only defines or hides are not imported (#11039)

read_svg drew every shape it met, whatever its parents were, so a circle
inside defs, clipPath, mask, symbol, marker or pattern, or one hidden by
display: none, became a sketch curve a browser never shows (and could
punch a hole in an extrude). Those elements and their contents are now
skipped; the stack still follows the end tags, so what comes after reads
as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: thocsmith <193096300+thocsmith@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 19:52:26 +00:00
Homero ThompsonandClaude 49ab9179a7 The command reference: the parameters as a table, with their type and whether they are required (#5237) (#11074)
* The command reference: the parameters as a table, with their type and whether they are required (#5237)

The command reference shows each command's parameters as one raw line of
registry notation, so a reader has to read it as code to learn what a
command takes. The generated page now lists the same parameters as a table:
the name, the type, whether the command needs it, and what the registry
says about it. The complete parameter text stays in the automation details,
so nothing is lost for the scripts that read it.

The table is generated from the command registry, like the rest of the page,
so it cannot drift from the commands. The notation is read by a small parser
that knows what the registry writes: names written apart share the type
that follows them, a question mark marks a parameter optional, a pipe
between names offers alternative names for one parameter, a pipe after the
colon lists the types it accepts, a parenthesis says what the parameter
does, and the text after an arrow is the reply the command gives, not a
parameter.

Co-Authored-By: Claude <noreply@anthropic.com>

* test: the parameter table keeps its description literal

The parameter table shows registry text, so a description that carries
inline Markdown must be shown literally: backticks, emphasis and links
are characters, not syntax.

The type of a parameter ends where its sentence ends, so the sentence
that follows it is not part of the type.

Both tests fail on the current code.

* fix: render the parameter description as prose

The description cell of the parameter table is registry text, and the
rest of the file already renders registry text with prose(): backticks,
emphasis and links are characters, not syntax. table_cell() only kept
the table and the page intact, so a description like `#name = expression`
came out as a code span and a description with `*bold*` came out as
emphasis.

The name and the type keep table_cell(): they are identifiers and
notation, and they are not Markdown prose.

* fix: cut the parameter type at the end of the sentence

A type runs to the end of the clause, so the sentence that follows it
belongs to the command, not to the type: `construction?: bool. Returns
sides {bottom, right, top, left}` showed the whole sentence as the type
of `construction`, and the description of `sides` with it.

The type now ends at a full stop followed by a space and a capital
letter. A dotted or multiword type such as `sketch.rectangle` or
`number or expression` does not match that pattern, so it keeps its
current handling.

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-05 19:52:16 +00:00
8c4caf9372 Insert Part help: say which way point and direction place the part (#11729) (#11755)
Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 19:51:56 +00:00
202b775de4 Agents and scripts: Add, Rename, Delete, Comment, Favorite and Move Parameter describe their exact parameters and reply (#11941) (#11943)
* claim: #11941

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* User parameters: input and output schemas for Add, Rename, Delete, Comment, Favorite and Move (#11941)

describe_command now gives the exact parameters and reply of the six
commands that manage a design's user parameters by name, and the warn
and strict parameter checks use them. The handlers read their
parameters from the raw JSON, so the contracts in the new
schema/parameters.rs read each key as its handler does, with its
message; `value` stays as parameters.add's other name for `expression`,
and `comment` is required in the schema but left to the handler's
message in the type. The replies are built from typed values instead of
json! literals, with the same JSON; parameters.add's reply flattens an
untagged AddedValue (a number's value or a text parameter's text).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Parameters: the schemas count a `null` expression and Move's neighbour as left out

`parameters.add` reads a `null` `expression` or `value` as left out
(`expr_arg`), so the schema's "expression or value" alternatives now
also need the key's type (number or text): `{"expression": null}` alone
no longer matches, while `{"expression": null, "value": 3}` does.

`parameters.move` needs exactly one of `before` and `after`. The schema
now says so with a `oneOf` whose alternatives each need their key as
text, so a `null` neighbour (read as left out) counts as neither, and
both or neither is refused. `conforms` doesn't read `oneOf`, so the test
pins it and counts the matching alternatives itself.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
2026-11-05 19:51:46 +00:00
P'tite TêteandP'tite Tête 2c35a027f5 fix: Edit Feature of a surface revolve maps a new axis into a moved component (#12298)
- timeline.redefine maps a surface revolve's {origin, dir} axis through an edit-only table entry
- a new surface revolve still goes whole through to_active_frame (picked edge and face axes)
- tests: made and edited in a moved and a turned component against the solid revolve; a picked edge axis

Co-authored-by: P'tite Tête <asso@ptitetete.com>
2026-11-05 19:51:18 +00:00
146a43f38e Agents and scripts: Motion Study, List and Delete describe their exact parameters and reply (#12155) (#12156)
* claim: #12155

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Motion studies: input and output schemas for Motion Study, List and Delete (#12155)

describe_command now gives the exact parameters and reply of
motion.study, motion.list and motion.delete, and the warn and strict
parameter checks use them. The handler reads its parameters from the
raw JSON, so the contracts in schema/motion.rs read each key as it
does, with its message (a study by id or name, steps, and keys of
[step, value] points); whether the study, joint and value exist stays
the handler's to check. The replies are built from typed values
instead of json! literals, with the same JSON, through `typed_reply`
(the contact commands' helper, renamed now that it serves both);
motion.list's traces stay as motion_trace.rs builds them.

The parameter audit found two tests in cmd/motion_tests.rs sending
`delete: true` to motion.delete, a key only Edit Contact Set takes; a
`deletion` helper now sends it only there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Motion Study: a point's step must be a number in the schema, as the handler reads it

The schema typed both elements of a key's point as "a number or text",
so `["0", 20]` matched it although the handler refuses a step that isn't
a number ("points are [step, value]"). The two are now typed apart with
`prefixItems`: the step a number, the value a number or an expression,
each under 1e9 in size, as `study_key_problem` and the handler read them.
Elements after those two, which the handler ignores, are left free.

The 1e9 limit, written twice in the key check, is now the named
`MAX_POINT_MAGNITUDE`, used by the check and the schema alike. A new test
checks nine point shapes against both the schema and the key check, so
the two can't drift apart.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
2026-11-05 19:51:04 +00:00
e04bc060f6 Web app: clippy for wasm passes with -D warnings (#12222) (#12251)
* claim: #12222

* Web app: clippy for wasm passes with -D warnings (#12222)

cargo clippy -p solidcraft-web --target wasm32-unknown-unknown stopped at
drop(file) in safe_write.rs and showed 12 more warnings only that target
has. Each is fixed where it is:

- safe_write::create_atomic and control_auth::write_token_file_with close
  their File by scope (a block; Result::map's closure) instead of drop(),
  which clippy's drop_non_drop flags where File is a stub.
- Native-only imports, the AHEAD constant and the point-cloud worker's
  Condvar are behind cfg(not(target_arch = "wasm32")); Exported::bodies
  and Start::Later, read or built only natively, allow dead_code there.
- home::ask_present uses ctx in its browser branch; the browser blur stub's
  begin returns a Scope, as the native one does.
- The web app drops three map_err(JsValue::from) on dyn_into's error,
  which is a JsValue already.

Native builds behave the same.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: thocsmith <193096300+thocsmith@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
2026-11-05 19:50:25 +00:00
PeppaWutzandbherbruck 464da90238 Agents and scripts: the Browser folder commands and Rename Body describe their exact parameters and reply (#12276) (#12339)
browser.collapse_all, browser.expand_all, browser.group, browser.move,
browser.order, browser.rename_group, browser.ungroup, browser.visibility
and body.rename now publish input and output schemas, so agents and
scripts can read exactly which parameters they take and what they
return, and the warn and strict parameter checks cover them.

Each parameter is read the way the handler reads it today, with the same
error messages. The replies are built from typed values and serialize to
the same JSON as before. Part of #2829.

Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
2026-11-05 19:49:12 +00:00
SS-ENandClaude Opus 5.5 0b32d3619d Extract a component whose body was built in another component (#12153)
* Extract a component whose body was built in another component

component.extract now takes along the outside features that built, changed or moved
in a body the component owns, when they touch nothing that stays outside. Otherwise
it names the feature that blocks it. Fixes #12142.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Kernel case: extracting a component with a body moved in now succeeds

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 19:48:19 +00:00
austin62jakeandClaude Opus 5.5 eb10552c61 Agents and scripts: the native studio and quality profile commands describe their exact parameters and reply (#11766) (#11768)
* claim: #11766

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Render presets: input and output schemas for the native studio and quality profile commands (#11766)

describe_command now gives the exact parameters and reply of
render.preset.resolve and render.preset.apply (review and apply a
native studio composition) and render.quality.prepare (review a fixed
sampling budget), and the warn and strict parameter checks use them.
The handlers already read their parameters with strict serde types;
those types move to the new schema/render_presets.rs, gain descriptions
and JsonSchema, and become the contracts. The replies are built from
typed StudioComposition and QualityPlan values instead of json!
literals, with the same JSON.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Render presets schema: `set` names the setup's fields

As on #11762 and #11742: `patched_settings` reads a `set` patch onto
the saved setup as a RenderSetup, which refuses unknown fields, so the
schema now names the setup's 14 fields with additionalProperties false
(still at most 13 at once). A new test covers it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-05 19:45:18 +00:00
Homero Thompson e95f65fd54 IO: the STEP import limit is the import limit, not the design limit (#2721) (#11851) 2026-11-05 19:43:45 +00:00
austin62jakeandClaude Opus 5.5 1fdc56835b Agents and scripts: New, Edit, Inspect and Delete Physical Material describe their exact parameters and reply (#11862) (#11865)
* claim: #11862

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Physical materials: input and output schemas for New, Edit, Inspect and Delete Physical Material (#11862)

describe_command now gives the exact parameters and reply of
material.create, material.edit, material.inspect and material.delete,
and the warn and strict parameter checks use them. The handlers read
their parameters from the raw JSON, so the contracts in the new
schema/materials.rs read each key as its handler does, with its
message: `null` keeps its meaning (`color: null` and `physical_card:
null` clear), the look keys reuse the appearance commands' types, and
the card keeps the handler's own check, with its schema from
schema/material_properties.rs (whose card_schema becomes pub(super)).
The replies are built from typed values instead of json! literals, with
the same JSON.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Colour schema: a colour's text form allows what color_param reads

inspect::color_param trims the text and drops any number of leading
`#`, so "  #ff00ff  " and "##ff00ff" are colours to appearance.assign
and the material commands, but ColorParam's published pattern refused
them. The pattern is now built from schema::types' whitespace class (as
AxisDir's is), which becomes pub(crate), and a test pins it next to the
reader's answers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Colour pattern: a byte may be `+` and one hex digit, as the reader takes it

`inspect::color_param` parses each of the three bytes with
`u8::from_str_radix`, which accepts a leading `+`, so "+fff00" is read as
[15, 255, 0] today. The schema's pattern asked for six hex digits and
would have made strict refuse a colour the handler accepts. The pattern
now allows either two hex digits or `+` and one digit per byte, and the
test pins both the reader's answer and the pattern's text, since
`conforms` doesn't read patterns.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-05 19:42:20 +00:00
austin62jakeandClaude Opus 5.5 3fde538320 Agents and scripts: Inspect HDR Source and Save Render Settings with HDR describe their exact parameters and reply (#11761) (#11762)
* claim: #11761

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Render HDR: input and output schemas for Inspect HDR Source and Save Render Settings with HDR (#11761)

describe_command now gives render.hdr.inspect's and
render.settings.capture_hdr's exact parameters and reply, and the warn
and strict parameter checks use them. The handlers already read their
parameters with strict serde types; those types move to the new
schema/render_hdr.rs, gain descriptions and JsonSchema, and become the
contracts, so the check is no stricter than the handlers. The replies
are built from typed HdrInspected and HdrCaptured values instead of
json! literals, with the same JSON. `expected_sha256` is the doc crate's
HdrId, whose schema is written by hand (64 lowercase hex digits or null).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Render HDR schema: `set` names the setup's fields, and its job may be the saved one's

`patched_settings` puts a `set` patch's keys onto the saved setup and
reads the result as a RenderSetup, which refuses unknown fields. The
schema now names the setup's 14 fields with additionalProperties false
(still at most 13 at once), so `set: {"widht": 10}` is refused, as the
handler refuses it; the values stay the handler's to check. The
description now says the setup the changes make (a saved one keeps the
fields left out) needs a cpu_raytrace or gpu_path job, not that every
patch must give one. A new test covers the field names.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-05 19:41:27 +00:00
SilentWolf75andCursor 283ccd0b21 Web: tab title follows a renamed design (#11375) (#11381)
* claim: #11375

Co-authored-by: Cursor <cursoragent@cursor.com>

* Web: tab title follows a renamed design (#11375).

When an OPFS design is renamed, open tabs keep the new path and a borrowed design name so the tab matches the file list.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-11-05 19:41:04 +00:00
ermanandermanyop-stack 6b222aedf7 test(ui): cover #11088 Paste New parent context (#11110)
* claim: #11088

* test(ui): cover Paste New into a selected parent

* test(ui): use SolidCore Vec3 in clipboard regression

* test(ui): verify copied face attachment through menu

* style(ui): apply clipboard test formatting

---------

Co-authored-by: ermanyop-stack <278786764+ermanyop-stack@users.noreply.github.com>
2026-11-05 19:39:38 +00:00
CamWightandClaude Opus 5.5 bcdbb91f26 Assemblies: one children-by-parent index for the occurrence walk (#12173)
Document::placements scanned every occurrence for each component it visited,
so its cost was placements times occurrences, on every world placement. The
new OccurrenceTree (crates/doc/src/occurrence_tree.rs) lists each component's
children once, in one pass and in document order; placements walks it with
the same order, caps and stop behaviour, through placements_with, which takes
each occurrence's transform from the caller. inside_component reads the same
index instead of scanning per component.

Tests compare the walk with the scanning one on 13 shapes and on hostile
generated documents, at its caps, in document order and with a given
transform. Release, 97,540 placements: about 120 ms -> 15.5 ms, the same in
either run order (docs/perf.md).

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 19:39:35 +00:00
cronos 21a1269d5c Sketch Trim: keep the stored offset distance after deleting its dimension (#12186) 2026-11-05 19:39:21 +00:00
Alastair D'Silva d580c4256c Evaluation: add --validation to solidcraft-cli eval and skip largest-fit search when validation is off (#12136) 2026-11-05 19:39:16 +00:00
SS-ENandClaude Opus 5.5 1b52186524 Timeline: reordering a feature says when nothing moved and returns its new index (#12171)
* timeline.reorder: say when nothing moved, and return the new index (#12140)

A position past the end was capped to the last slot; when the feature was
already there the command reported success with no sign nothing moved. The
reply now gives position (index now), from and moved, with a note that says
why nothing moved or that the last slot was used. A move that puts a feature
ahead of what it uses says so, and the command refuses before changing the
design if the feature would not land at the asked position.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* timeline.reorder: word a refused move by its direction; note a marker-only change

A feature moved later can fail for reasons other than order, such as a cut that
removes its body, so the move-earlier hint is given only when it moved earlier.
With `active`, a feature left in place gets a note saying only the history
marker moved, or that nothing moved.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 19:38:38 +00:00
Thijs DamsmaandCodex 3e6eadc118 Offline web test timeouts show which build each script ran (#3956) (#12206)
* claim: offline script marker diagnostics for #3956

Co-Authored-By: Codex <noreply@openai.com>

* Report script build markers in offline web test timeouts

Expose the existing started and shared dataset markers in diagnostic state. Preserve missing markers as null without changing readiness or retry behavior.

Co-Authored-By: Codex <noreply@openai.com>

---------

Co-authored-by: Codex <noreply@openai.com>
2026-11-05 19:37:59 +00:00
ABDULLAH 87358ef724 Arabic: component spelling, tab-close tip, MCP compact note, surface grain angle, Output names, mouse word, Hole bridging, intersection curve help, ground shadow tip, pan term, Move names and newer-file notices (#12151)
* Arabic: one spelling of component in the Browser rows start closed note, dialog wording in the tab-close tip

* Arabic: no direction marks in the MCP compact output note

* Arabic: general term for the surface grain angle, Output name in the image import note and the Output inspector header

* Arabic: one word for the mouse in the right-click notes of the intersection curve pick and the Play History button

* Arabic: bridging term in the Hole dialog, intersection curve help pronoun, ground shadow tip wording

* Arabic: pan term in the drag-keeps-mode help and the vertical pan direction option

* Arabic: Move Sketch Points name, Move tool name in the drag highlight preference, file format wording in the newer-file notices
2026-11-05 19:37:36 +00:00
austin62jakeandClaude Opus 5.5 3d73822442 Agents and scripts: Parameter Sweep's schema requires its parameter, as text (#12312)
* claim: Parameter Sweep's schema requires parameter

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Parameter Sweep: the schema requires `parameter`, as text

`inspect.parameter_sweep` refuses a call without `parameter`, or with a
`null` or numeric one ("`parameter` is required (parameters.list)"), but
its published schema (#10978) neither required the key nor ruled out
`null`: the field's `#[schemars(required)]` has no effect on a key with
`serde(default)`, and `Option<String>` publishes `["string", "null"]`.

The contract keeps the key optional in its type, so the handler, not the
check, gives its own message when it's left out; the schema now requires
it through a struct-level transform, as the contact commands do, and
types it as a string. A new test checks the schema against a call
without the key, with `null` and with a number; it fails without this
change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-05 19:37:22 +00:00
Homero ThompsonandHermes Agent 51f4074506 Split and Trim errors name the command a script can run (#4712) (#11205)
* Sketch modify: name the public command in the split and trim errors (#4712)

Part of #4712.

The split inside the sketch modify tools refused in the name of the
internal `split` step, and the free-form trim in the name of the
internal `trim` one: `invalid parameters for `split`: a circle needs
two points to split at` names a command nobody can write, so an agent
or script reading the message has nowhere to go.

Both now name the public command the caller used: `sketch.modify` for
the split shared by trim and break, `sketch.trim` for the trim. The
descriptions are unchanged.

Co-authored-by: Hermes Agent <noreply@anthropic.com>

* Sketch modify: the split names the command the caller used (#4712)

`sketch.modify` is not a command a caller can write: the registered
sketch commands are `sketch.trim`, `sketch.trim.path` and `sketch.break`.
The split shared by trim and break therefore refused in the name of a
command that does not exist, and a script reading the message had
nowhere to go.

`split_at` takes the command of its caller and refuses in that name:
`sketch.trim` when the trim splits the curve, `sketch.break` when the
break does. Both callers already had the command in hand.

The test now states the decision: the refusal of `sketch.break` carries
`sketch.break`, and the rendered text names no other command.

Co-authored-by: Hermes Agent <noreply@anthropic.com>

---------

Co-authored-by: Hermes Agent <noreply@anthropic.com>
2026-11-05 19:28:22 +00:00
github-actions[bot] 796b7c40d3 Regenerate generated files and fold pending files [skip ci] 2026-11-05 19:17:37 +00:00
FrankandClaude Opus 5.5 9cdee588f2 Extrude Two Sides: fix the side and missing value box of Distance 2 (#11203)
* Extrude: Two Sides keeps each distance on the side Direction gives it

Distance 2 stays on the side Direction gives it, whatever the sign of Distance 1, and its value box shows on the canvas. Rebased onto main as one change.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Two Sides extrude: keep older designs' sides by a marker, and the full profile search

- A saved two-sided extrude is marked `second_follows_first` instead of having a literal
  negative distance rewritten: expressions such as `-width` keep the old sides when their
  parameters change, `-0 mm` keeps its span, and a feature's named inputs keep their values.
- Live sketch drags and the restored model cache use the full profile search evaluation uses,
  so a sketch whose only closed boundary is projected keeps its profiles.
- The canvas Distance 2 box stays while its text does not evaluate.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Tests: give the extrude added on main the second_follows_first field

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 18:39:09 +00:00
Nathan Dane 90d9c6488a Panels: add columns, stacks and tabs with exact drag previews (#11305) (#11608)
* claim: #11305

* Panels: add columns, stacks and tabs with exact drag previews (#11305)
2026-11-05 18:38:54 +00:00
Nathan Dane edb7882815 Appearance: browse themes in a carousel or grid, filter them, and set Day and Night themes (#12120)
* Appearance: theme picker with carousel, grid, filters and Day/Night slots

* Appearance: theme picker arrows move a screenful of themes

* Theme picker: translations, token metrics, wheel helper in navigation, reveal tolerance

* Theme picker: keep both new Appearance preferences after the rebase

* Appearance: adapt theme picker to egui 0.37
2026-11-05 18:38:42 +00:00
db3558d820 Extrude: the distance arrow snaps to a parallel face and outlines it (#2398) (#9688)
* claim: #2398

* Extrude: the distance arrow stops at a parallel face and outlines it (#2398)

While Extrude's distance arrow is dragged, a flat face parallel to the
profile and lying over it takes the distance exactly once the tip comes
within 8 screen points of its plane, and the face is outlined as a hovered
face is. A cut dragged through a block so stops at its far side. Faces
beside the profile don't catch the arrow; Alt/Ctrl (free drag) turns it off.
The distance stays a number in the existing parameter.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Extrude face stop: clippy (test-only current, +=)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Extrude face stops: a preference, on by default, keeps the old round steps (#2398)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Extrude face stops: follow world_state returning a Result (#2398)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Extrude face stops: import Vec/Plane from solidcore_record after the layer split

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
2026-11-05 18:31:55 +00:00
b2f5da6ca7 joints: support custom names and joint type-dependent default names (#10340) (#10165)
* joints: support custom names in dialog and type-based default names

Allow users to specify a custom name in the Joint dialog and generate
type-prefixed default names (e.g. "Planar Joint1", "Revolute Joint1")
instead of generic "Joint{n}".

- Add `name` field to `JointForm` and display a text row in the Joint
  dialog with a dynamic placeholder matching the chosen type.
- Update `new_joint_name` in `cmd/joints.rs` to take `JointKind` and
  prefix auto-generated names with the joint kind label.
- Prioritize non-empty custom names and pass them through `joint.create`,
  `joint.as_built`, and `joint.edit`.
- Pre-populate the existing joint name in `edit_joint` to allow renaming
  directly from the Edit Joint dialog.

* joints: add tests for custom and type-based joint naming

Verify that the joint dialog and engine command layer correctly generate
type-prefixed default names and respect user-specified custom names.

- Add engine-layer test `new_joints_generate_type_prefixed_names_or_keep_custom_name`
  to verify `joint.create` and `joint.as_built` naming logic.
- Add UI-layer test `joint_dialog_applies_custom_name_or_falls_back_to_type_default`
  to ensure the `JointForm` captures and submits names correctly.

* Format dialogs_assembly_tests.rs (trailing blank line)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 18:31:43 +00:00
Steven WatersandClaude f1159a5d51 Added mesh import units for STL and OBJ (#10406)
Co-authored-by: Claude <noreply@anthropic.com>
2026-11-05 18:31:26 +00:00
github-actions[bot] ffc84dbe2e Regenerate generated files and fold pending files [skip ci] 2026-11-05 17:28:40 +00:00
942e1540db Bulgarian localization (#8256) (#8303)
* claim: #8256

* Add initial Bulgarian translation (114 keys)

* Delete claim.txt

* Delete translate.py

* Delete assets/locales/bg.json

* Restore the bg catalog the locale list needs, fix indent

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Bulgarian: translate the strings the catalog tests require, drop ids that no longer exist

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 16:28:09 +00:00
6500c42c9f Agents and scripts: sketch Copy, Cut and Paste describe their exact parameters and reply (#10963) (#10964)
* claim: #10963

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Sketch Copy, Cut and Paste: input and output schemas (#10963)

sketch.copy, sketch.cut and sketch.paste get typed contracts and reply
types in schema/sketch_clipboard.rs and leave unconverted.txt. `at` and
`translate` read as the paste reads them, with its message; the replies
are built from Copied and Pasted, with the same JSON as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Sketch clipboard: import Vec2 from solidcore_record after the layer split

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
2026-11-05 16:14:13 +00:00
github-actions[bot] 655c1f3336 Regenerate generated files and fold pending files [skip ci] 2026-11-05 16:21:12 +00:00