map_planar_sources took every plane of a cut's tool as competing with an input face on it,
facing either way, and dropped that face's exact role. A text pocketed 1 mm down from a block's
top has its tool's top on the top's plane facing up, as the top does; the top then lost its
CertifiedExtrudeCap, and the sketch on it reported "the top cap of Extrude1 no longer exists"
(a_face_sketch_saved_with_fitted_letters_reopens_and_builds_the_same). A cut's tool faces enter
the result turned round, as the walls of the hollow, so a tool face can only take the place of a
face on its plane facing against it (a pocket's floor, a face the tool sat on from outside). Only
that orientation competes now; the existing blocking cases (a tool's bottom on a pocket floor, a
tool face against a wall) are unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
same_support took two planes as one support only within 4096 ulps (normals 9e-13 apart,
origins about 1e-12). Faces SMLib rebuilds through a boolean lie within its own resolution of
the plane they were made on, not within ulps: a cap at z = 10 notched by a cut came back with
its origin 2.1e-11 off and its frame turned 1.36e-12 rad, so its CertifiedExtrudeCap was
dropped and the sketch on it reported "the top cap of Extrude1 no longer exists".
Supports are now compared at SMLib's own coincidence rule, SmPlane::CoincidenceCheck: normals
within the angle the tolerance makes across the plane (`tolerance / size`) and each origin within
the tolerance of the other plane, the tolerance being the record's `tolerance` (SMLib's per-brep
XSectTol3d, the one its booleans test surfaces for coincidence with). The body's size stands
for the plane's extent (at least as large, so no looser); rounding stays the floor. The normal
window the candidates are searched in follows the same angle.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The truck booleans answered a tool clear of the body without intersecting (the operand kept,
its record shared). The SMLib boolean always rebuilt the body, so a cut that could not reach a
body still handed back a new record: a hole far from a second body reported that body changed
(#2904's test), and a body clear of a pocket's cutter was no longer the same solid. A cut or
intersection whose operands are apart (their exact boxes, grown by twice the tolerance as
union_apart takes them, do not meet) now gives the body itself with its faces and edges kept,
or nothing, with no SMLib call.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two readings of the SMLib record went wrong in emboss_cylinder:
- The footprint arcs were labelled on the sketch's radial frame. The assembly gives each new
circle edge the NURBS form on its label's quarter grid, and the wall face keeps its own form on
its frame's grid (a cylinder's seam lies at an odd angle, build::SEAM_ANGLE). The two grids
differ by a non-quarter turn, so the arc's form is not a straight line in the face's (u, v)
and no exact pcurve exists: "no exact pcurve of a NURBS on a spline surface". The arcs at the
wall's radius are now labelled on the wall face's frame (form::on_frame), so their forms lie on
the face's grid and the pcurve is exact.
- wall_angles took the edge's interval as the circle's angles. On an SMLib record the interval
is on the edge's NURBS form (2πr long for a whole turn), so a wall spanned some 63 rad: a
profile across the seam was accepted, and a wall of radius 0.1 was refused as off its seam.
It now reads Edge::curve_interval.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face that meets itself along a line (the Pinch case's boss side, turned 30 degrees: the hole's
wall touches it along a vertical line from the hole's bottom to the top rim) has its loop run up
that line and back down. Its motorcycle trace runs from the slit's tip to the bottom and the
iso-line grid meshes it, but the band between the grid cells and the boundary was filled by a
parity flood that flipped at every constraint, the slit's too: the band on one side of the slit
was taken for outside, the face did not follow its boundary, and the lenient fill took over.
The band now crosses a side the loops run along both ways without counting it, as the
triangulation itself already did. Delaunay's sag refinement had the same flood and left the far
side of a slit unrefined (the lenient fill's 0.52 mm^3 shortfall); it takes the slits too.
The Pinch case now meshes strictly: the boss side is 628.3177 mm^2 against 200 pi = 628.3185, and
hole_tangent_inside_a_stepped_boss_cuts_exactly passes. New tess test: a square with a slit
meshed by the cut grid follows the slit both ways and covers the square's area exactly.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Where a face meets itself along a line (a hole's wall tangent inside the wall round it: the
boss side touched by the hole along a vertical line, run up and back down), its loop runs along
that line both ways. The triangulation's region test flipped inside and outside at every
constraint side, so crossing the slit put the face's far side outside it; the follow check
wanted every boundary side under exactly one triangle, where a slit has one each side. Sides the
loops run along an even number of times no longer flip the region, and the follow check wants a
triangle per run. (The Pinch case's boss side still falls back to the lenient fill, now within
0.52 mm^3 of the exact 8717.92 where it was 340 short; the strict fill's remaining mismatch on
the seam-cut face is open.)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A ring whose inner circle touches the outer one (a boss standing on a disc, tangent inside its
rim) is one loop through the touching vertex, both circles leaving it along one tangent. There
the inner circle's first node falls on the outer circle's last chord whenever the outer chord is
twice the inner (exactly but for the next order: the inner circle at s rises s^2 / 2r, the outer
chord at s/2 of its length rises L^2 / 8R, equal for L = 2l, R = 2r), as the samplings fell
here. No crossing by the untangle test, but no triangulation can keep both as constraints: the
strict fill refused the face, and the lenient one, dropping constraints, filled the inner disc
(314 of the ring's 942 mm^2, the Pinch test's 1047 mm^3 shortfall). A node of one chord lying on
another (inside it, not at its ends, and not two chords along one line, as a seam's two uses a
period apart are) now has that chord halved. Regression test: the ring meshes strictly, to
300 pi.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fillet_an_open_curved_edge, fillet_sharp_arc_and_arc_loop and
fillet_mixed_arc_and_line_removed_volume_converges took the volume a round removes as the
difference of two mesh volumes, which magnifies their sag (each mesh lies within its chord of its
faces, so the difference can be off by both areas times the chord: for the r 0.25 round at a
1e-4 chord 1.8e-3 of what it removes). Measured exactly (SMLib, 1e-8) the rounds are right:
the open curved edge's removal 25.7629198 against Pappus' 25.7629199, the sharp arc loop's against
its lens quadrature, the mixed joint's 2.7155830 and 0.6842666 against the reference 2.7155785 and
0.6842658 (1.7e-6 and 1.2e-6: the blend's own fit, whose section error the joint test reports).
The removals are now exact, the mixed one held to 1e-5 of the reference; the meshes' removal is
held to its chord bound of the exact one.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Support::station reads the curve leaving a boundary from five samples: one-sided where the
support ends at the station, central where the surface goes on past it. The central five-point
formulas had the first and second derivatives' signs reversed ((-f0 + 8 f1 - 8 f3 + f4) and
(f0 - 16 f1 + 30 f2 - 16 f3 + f4) over 12h, 12h^2, the negatives of the standard ones), so the
curvature read there pointed away from where the surface bends. Truck's half cylinders ended at
every picked line and read one-sided; SMLib's cylinder is one periodic face, the seam is inside it,
and the central branch read the wall bending outward (+radial / R): the G2 and G3 matches to it
built sheets bending the wrong way, and the continuity check, reading the same frames, called
them G2. The central formulas are now the standard ones.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_split_in_the_plane_of_a_face_keeps_all_of_the_body held the two parts' volumes to the body's
within a millionth, each read from a mesh at a 1e-3 mm chord. Nothing was lost: the parts came
out at exactly the closed forms (780.3707 and 1035.2797 for the 5 mm groove, 1815.6504 together);
the whole body's own mesh sagged 0.0034 mm³ short of that round the hole, twice the millionth.
They are now SMLib's exact volumes (1e-8).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
measure now integrates to SMLib's finest relative accuracy, 1e-8 (da57f37e5, cherry-picked from
the engine-commands branch), not 1e-4: the mirrored bracket's union and twice its half, each an
integral good to 1e-8, agree to 2e-8. (The test stops earlier on this base, at the mirrored
operand SMLib's check refuses: the mirror-regressions agent's cause.)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
measure asked SMLib for a relative accuracy of 1e-4, after SmApiBrepComputeMassProperties'
documented clamp to [1e-4, 1e-1]. smlib_brep_mass_properties does not go through that call: it
calls the kernel's integration directly because the clamp "leaves curved faces off by 1e-5 to
1e-3", and takes [1e-8, 1e-1] (solidcraft_smlib::MEASURE_ACCURACY). Asking 1e-4 threw that
away: a swept cylinder's centre came out 5e-7 off its exact place, and a 0.0177 mm³ crescent
(a pin 0.59 µm off its hole) 0.27% off the lens of two circles. Measured at 1e-8, the sweep
centres are exact to 1e-7 and the crescents match the closed form to 1e-6; the engine-commands
batch runs in the same 20 s.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cap_support_origin_is_not_a_trimmed_face_height read the drilled block's last face as a cap. The
record's face order is SMLib's: its last face can be the hole's wall, which has no cap loop, and
the test unwrapped None. The cap is now the first face on a plane square to z.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_lip_swept_on_a_round_rim_joins_it compared the union's mesh volume with the two operands' at a
1e-5 chord to 1e-3 mm³. Each mesh lies within its chord of its own faces, and the union is
tessellated by its own faces (the lip's foot merged into the top): two meshes of one solid differ
by up to their area times twice the chord, 0.02 here; they differed by 1.6e-3. The bound is now
that. overlapping_holes_and_mirror_joins held the mirrored union to 2v within 1e-9, below the
relative accuracy SMLib integrates volumes at (1e-4, measure::ACCURACY): the two integrals
differed by 2.3e-8. (That test now stops earlier, at the mirrored operand SMLib's check refuses,
the mirror-regressions agent's cause.)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
faceted_cut_of_a_helical_groove took the volume removed as the shaft's exact volume less the cut
body's mesh volume at a 0.01 mm chord. That mesh sags inside the shaft's round wall: the uncut
shaft's own mesh at 0.01 is 0.18 mm³ short of pi r^2 h, five times the 3 % the groove is held
to, so the groove read 1.326 where the screw integral gives 1.2214 (the section's 2 pi int r dA
over 4 turns plus the ramp at z = 0). The cut is a B-rep: its exact volume (measure) gives the
removed volume within the 3 %.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
faceted_boolean took the tool mesh's triangles by vertex index and refused any edge not shared
by exactly two triangles. A body's mesh (Body::mesh) gives each face its own vertices, the faces
along an edge the very same points, so a box's mesh came in as six open patches: "the mesh is
not closed". Corners at the very same point are now one vertex first (triangles keep their order,
so the history's triangle faces are unchanged).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
check_kept panicked on any edge origin that was not an operand's edge, but a new edge where two
faces meet has a Meet origin by the history's contract (EdgeOrigin::Meet), and SMLib's history
gives them: the raised band's and the thickened sheet's new edges. It now checks the edges an
operand still owns and passes over the meetings. The thickened sheet is the whole cylinder side
(SMLib's one face, truck's half): a wall stands along each of its free edges, the two rims, and
none along its seam, which the face meets itself along (2 + 2 faces, not 2 + its 3 edges).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A layout can leave triangles standing on their long side across the surface:
their corners on it, their plane across it. They count several times the area
under them (the front triangle's loft tubes 0.7% and 1.1% over the finer mesh)
and no split repairs them, since each half stands the same way.
After the sag refinement a post-pass flips a side inside the face when the
two triangles on it turn less from the surface normal the other way (by more
than a degree), keep their orientation in (u, v) and against the surface
normal (nothing folds), have area in 3D, and the new side and triangle middles
stay within the tolerance of the surface or no farther than before. Boundary
sides are never flipped.
Test: tess triangles_standing_across_a_curved_sheet_are_flipped_along_it; the
boolean_regression joined_loft_frames_reference_mesh_covers_each_face_once
case now passes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refinement split the side of a triangle that sagged most. Where a long
inner side lies on the surface at its middle (a section with an inflection,
a loft tube of the bike frame's front triangle) and the triangle's short
sides sag, only the short sides were split: each split left a child with the
long side and its vertex nearer to it, and the triangle beside a split side
lost its shape the same way. The triangles flattened onto the long side
without end, refinement ran to its point budget, and the mesh of the face
counted 3.4 times its area (1.45 times on a second tube).
A triangle whose widest angle is past 150 degrees now splits its longest
side, and a split never goes across an obtuse triangle's shorter side: that
triangle's longest side is split first, along the path (Rivara's
longest-edge propagation, its lengths growing, so it ends). Only sides inside
the face are split, as before.
Test: tess sag_refinement_across_an_inflection_ends_without_slivers, a sheet
with an S section meshed with a triangle flat on the chord across its
middle; it ran to its budget of 20000 points before and adds 28 now.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A whole sphere as one face has its seam as its only edge, used both ways. In a body many times
its size the seam gets two segments at the body's chord (pole, equator, pole), so no node off
the poles follows a node off them, and the loop kept its first node, a pole: its closing step
crossed the other pole, which the drift unwrapped to a whole turn ("boundary winds around the
surface"). The sphere was left out of the mesh (cut_beside_a_sealed_void_keeps_the_body: a void
r 2 in a 75 mm part, "1 face(s) don't mesh"). The loop now starts, failing a node with an
off-pole predecessor, at a node whose predecessor is a pole on the same edge, so the step into
it is that edge's own and the step into the pole is unwrapped in the loop like any other.
Regression test a_small_sphere_void_in_a_large_block_meshes (tess tests): watertight, no face
left out.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
export_keeps_faces_split_on_purpose took a box whose top Split Face cut in two, dropped the
split record by hand (with_split_lines(None)) and expected the STEP file to have 6 faces: truck's
export joined pieces on one surface, "as it does for pieces a boolean left". No operation makes
such a body: the split record is only set (doc eval, Split Face), never dropped, and removing a
Split Face rebuilds the part without the split. SMLib's booleans join pieces on one surface at
their end (two touching boxes unite into 6 faces), and the local modifiers heal through
boolean_record::healed, so no operation leaves incidental pieces either. The file now has what the
body has (7 faces, the export merges nothing), and the heal every later operation applies
joins the unrecorded pieces: 6 faces in the body and in its file.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib's cylinder side is one face round the whole turn (truck's two halves): a line at z = 5
splits it into a quarter and three quarters of 2 pi 10 x 20, two side faces, not three. (The
test still fails further on, at the face-split tool's "invalid argument", engine-builds'
cause fixed on their branch in 50356dbf2.)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_modelled_thread_in_a_bore_meshes_inside_its_block held each face's triangle area to within 5%
of its surface's area. At the 0.1 mm tolerance, face 18 failed that: 1.777 mm^2 of triangles
over 1.522 mm^2 of surface. Face 18 is the groove's crest band where it runs out through the
block's end, a wedge at most 0.44 mm wide. Its boundary sides are the helix edge's chords, 1.37
mm long and sagging 0.062 mm (inside the tolerance). A flat triangle on such a chord bridges the
sail between the chord and the edge instead of following it, and the band is no wider than the
sag. The excess, 0.255 mm^2, is less than the sails along the face's boundary (sum of 2/3 L sag
= 0.62 mm^2). Every triangle is within the tolerance: the chord check passes. No triangulation
of the inside changes this; the boundary nodes are the shared edge nodes.
The check now allows 5% plus the boundary's sails at the tolerance, 2/3 L tol per boundary side.
A zigzag that multiplies a face's area, which this test exists to catch, is still far outside
that. On the run-out root band the bound allows about 40% at 0.1 mm and 5% plus 4 mm^2 at
0.01 mm, against the former 6x.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tapered_extrude_of_lines_and_arcs expected the quarter disc (its arc meeting both lines at a
corner) to be refused, "arc meets another edge at a corner". That was truck's limit. SMLib's
curvature-keeping taper builds it as mainstream CAD does: each wall continues as itself until it
meets its neighbour. The test now checks what was built. The section at d = z tan 8 deg is the
disc of radius r + d over x >= -d, y >= -d. Its area is in closed form, and the volume is its
integral by Gauss-Legendre: 458.5870559 against SMLib's 458.5870567 (2e-9). The body has 5 faces.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
thread_display_tests sewed its M10 and M12 threads from cubic Bezier pieces approximating
helices, which lie about 1e-5 mm off the core and crest cylinders. No exact (same-parameter)
pcurve exists on the cylinder for such an edge, and SolidCraft's pcurves are exact B-splines
only. Sewing refused the core face ("no exact pcurve of a B-spline on a spline surface"). Truck
had fitted one. The thread feature makes its helices exactly, with SMLib's screw sweep, so the
test now does the same: the ISO ridge's section is screw-swept and joined to the core cylinder.
The section reaches a tenth of a pitch into the core along its flanks. ridge_volume is still the
thread's exact volume, and both display tests run unchanged, from the body as made and after a
STEP round trip. Imported edges that lie off their surfaces stay refused; they are Repair Part's
job.
The quality check's sag is now measured at the surface point nearest each triangle's centre.
Before, it was read at the mean of the corners' parameters. A closed surface's parameters are
kept within one period, so a triangle across the core's seam had corners a period apart, and
their mean read 6.27 mm off a triangle that lies on the surface.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Body size (the box diagonal every size-relative tolerance comes from: mesh chords, reach,
fit tolerances) came from the record's vertices alone. SMLib closes a sphere, a cylinder or a
torus along seam edges, so those vertices can be two poles, two seam ends or a single point: a
torus was 1 mm across (its preview at a hundredth of that took 214 720 triangles and broke the
budget), a 5 x 8 cylinder 8 instead of 16.2. The size now also takes three points along each
edge: points on the edges, not their control hulls, which for a rational edge can lie far off
it (a sheared L-prism's outline box was 49 km across).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sample_aliasing_does_not_certify_spline_caps built its trap as one polynomial of degree 17 with
a root at each of the 17 old sample locations k/16 (and a circle times such a polynomial, degree
19). A B-rep record holds splines up to degree 16 (MAX_SPLINE_DEGREE, #8618), so no record can
carry either and the evaluator refuses them: the test failed before testing anything. The trap
is now a C0 spline with a knot at every k/16: a quadratic on the line at each knot, bowing 1 mm
off it half way along the first span; and the quarter circle of radius 10 with its homogeneous
coordinates scaled by 1 + bump / 10, radius 10 at every knot and 11 at 1/32. Sampling at the old
locations still sees a line and a circle; the certifier, reading the spans' control points,
must certify neither, and doesn't.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
genuine_curves_and_oriented_traversal_are_certified built its degree-elevated line at degree
17. A B-rep record holds splines up to degree 16 (MAX_SPLINE_DEGREE, Brep::validate, #8618), so
no such edge reaches the certifier, and the evaluator refuses to build it. The line is now
written at MAX_SPLINE_DEGREE: still a line of the highest degree a record can carry.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The smooth-path sweep named walls only by the profile's edges in the start plane and took any
planar face nothing claimed for the end cap. A wall the start plane meets along no edge got
no name or became a cap: round a closed path, a square tube's planar top and bottom (whole
annuli, no seam) were both called end caps; along a line then an arc, the walls SMLib makes
along the arc were unnamed or caps. Like the cornered and controlled sweeps, it now also names
walls by the profile carried half way along, takes the end cap from where SMLib carries the
profile last, and round a closed path has no caps at all.
The issue #2005 tube check counted V - E + F without the ring term: SMLib's annular planar
faces have two loops each, so it checks V - E + F - (L - F) = 2 - 2g (Euler-Poincare). Along a
line then an arc SMLib makes a wall per profile segment per path segment (two, where truck
made three).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
transform_matrix moves a body by a matrix that is not a rigid motion through SMLib, which
numbers the moved body's faces afresh, then attached the input's face sources and paint in the
input's face order. Planar certificates landed on the wrong faces (a reflected, sheared plate's
hole walls and caps no longer lay on their certified planes). Each moved face now takes the
source and paint of the face its history names; a face with no known origin takes no source,
and with no history at all the paint stays as it was.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
efd0a577b kept the cap flatness tolerance under a quarter of the gap between parallel start
and end planes. A half turn's end plane is its start plane: the gap is 0, the tolerance became
0 and neither cap was found, so m0-revolve-primitives' two flat ends could keep no sketch
attachment (design_corpus every_flat_face_of_every_corpus_design_takes_an_attached_sketch).
Only planes apart by more than rounding bound the tolerance; coinciding ones are told apart by
the profile's edges, as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The roles of a swept body's faces take a face as a cap when all its points lie within a
flatness tolerance of the start or end plane, sized to the body (1e-5 of it). A box 0.1 µm
thick in a 14 mm body is thinner than that, so each cap lay in both planes and box_solid
refused "box role correspondence" (engine component_clone
boundary_material_proof_requires_resolvable_stock_and_void). Between parallel start and end
planes the tolerance stays under a quarter of their gap; a cap's points lie on its plane to
the evaluation's precision. Regression case: a 10 x 10 x 1e-4 box in
box_certificates_are_six_construction_roles...
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each wall of a swept body is known by a seed on its piece's edge in the start plane; every
start-plane edge within `near` of a seed took its piece, `near` sized to the body
(3 x 2e-4 of its size). On a side shorter than that the neighbours' edges are near too: a
0.3 mm wall of a 1 m label is 0.15 mm from them, near 0.65 mm, so the long walls got two
pieces, had no source, and box_solid refused "box role correspondence" (gpu depth
at_ten_metres..., engine component_clone boundary_material_proof); a ring of radii 10 and
9.999 lost its side certificates (ui configuration_annulus_picker...). A seed now marks only
the edges nearest it (within the flatness tolerance of the nearest), still within `near`.
Regression case: a 1000 x 0.3 x 400 box in box_certificates_are_six_construction_roles...
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A chamfer picked at (10, 0, 20) on a cylinder's top rim lies on the vertex where SMLib's
cylinder has its seam. The blend takes the rim there (blend_smlib::resolve: a seam or a smooth
join loses a tie), but the name stored with the feature came from the nearest mesh edge, the
seam (`F2:side:c1`). Once the stem grew, the name found the seam and SMLib refused the chamfer
(join_extrude_from_a_chamfered_top_face). edge_names_for names the edge each pick takes as a
blend takes it (kernel::blend_edges), the nearest edge only where that finds none.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
face_patch put the tool face's surface (a cylinder) over the domain of its NURBS form, which
SMLib parameterises otherwise (0..1, not the angle and height), so the patch handed to SMLib
was a sliver of the cylinder or empty and SMLib refused it as an invalid argument
(split_body_by_a_face). The domain is the analytic surface's: a whole turn, unbounded along
the axis, closed past the body as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
edge_circle took a circle edge's interval as its angle. A circle SMLib holds on its NURBS form
is parameterised on that form (a fillet's quarter circle over 0..1), so the fillet's edge
measured 57.3° and an arc length of R·1 (a_fillet_edge_is_an_arc). The span is the edge's
curve_interval, the angles of its ends on the circle, as the lip already reads it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#5191 read the header's preprocessor version and FILE_DESCRIPTION, so a SolidWorks file named
only there was stood up. The reader had moved to crates/step (p21.rs) before #5191 merged,
and the merge kept only the originating system: a file naming SolidWorks in its description
got no exporter_up (step_replies_name_a_y_up_exporter). The parser reads both fields again,
StepImport carries them, and exporter_up looks at all three.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The normal equations of patches about a centre were solved dense, so at most
500 free control points: the torus window, 1433 once its patches ran in their
own spaces, was refused. Each patch's interior (coordinates of points only it
holds, coupled by no row to another patch's) is a banded block now; the blocks
are eliminated exactly onto the unknowns the patches share (the spokes, the
centre, and the points rows across a spoke couple), whose Schur complement is
solved dense, and the interiors follow by back substitution. A solve takes up
to 6000 free points, as one patch does, and refuses past 4000 shared unknowns
(a 128 MB dense block) with that reason. The torus window and the pentagon now
solve (they fold, open).
The fill tests' own-edge check compares an edge's NURBS form to rounding, as
fill.rs's does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
face_tolerance (and planarity_tolerance) was 10⁻⁶ of the body's bounding-box
diagonal, which changes as a body turns: the cup turned 0.7 rad about
(1, 2, 3) grew from 54.7 to 61.6, its fill sampled to another tolerance, a
different surface (area 974.543 against 974.527). The size is now the
diameter of the smallest ball holding the vertices (solidcraft_geom::Ball,
Welzl's algorithm, expected O(n)), the same wherever the body is and however
it is turned. Twice the farthest vertex's distance from the vertices'
centroid is that too, but up to twice the body's diameter where the
vertices crowd one end: a rounded box's set-back-13 G2 corner patch then
ran 2.0e-3 past the box (corner_g2
a_long_setback_keeps_the_g2_patch_inside_the_box, limit 1e-3).
The own-edge check of the fill tests compares an edge's NURBS form to
rounding (10⁻¹² of each coordinate): SMLib makes a conic's form again on a
round trip, the last bit of a coordinate apart.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The iso fill needs three sides or more, so a loop of one closed edge (a tube's
end) or two was refused as "a loop of 1 edges". Such a loop's edges are now
taken in equal pieces of their own parameters (one edge in four, two in two;
a break that falls on one of the curve's knots, a conic's quarter points, is
that knot exactly), each piece the edge's own curve segmented exactly; the
patch's edges are those pieces, their ends new vertices shared by the pieces
either side. A piece of an edge the loop runs against has its parameter
reflected about the edge's interval, as a whole edge's is.
The tube end is still refused: one four-sided patch on four quarters of a
circle has corners where its sides run on straight (180°), and the G1 dome
folds there.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A record's tolerance is SMLib's intersection tolerance: SMLib holds an edge's
gap to its faces to half of it (the zone tolerance) and a vertex's gaps to a
quarter (SM_XSECT_TO_ZONETOL3D, SmBrep::ValidateAndUpdateTolerances). The fill
gave its edges and vertices the face tolerance itself, the gap its surface is
certified to, so SMLib's check refused every fitted patch (an edge/surface gap
of 2.6e-5 against 1.85e-5 where the fit holds 3.7e-5), alone or stitched to
its body. Its edges now take twice the gap and its vertices four times.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A ruled strip off an arc whose rulings keep their angle to the arc's axis
(normal or tapered mode on a 30 degree lean) is a piece of a cone, but was
built as the rational B-spline between the arc and its image, which SMLib
labels with no analytic type (its CopyAndAddAnalytics only sees the plane
strips). Such a strip is now the start ruling turned about the arc's axis
through the arc's angle by SMLib's revolve, as the round corners already are:
a cone face, the same surface. a_circle_in_every_mode passes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Kept parallel (the profile as drawn), a profile flattens to nothing where the
path turns to run along its plane. The check that refuses it (the path must
cross the plane by 5° or more all the way) lived in the stations of a
controlled sweep only; a plain parallel sweep went to SMLib unchecked and
built a degenerate solid. Both take the same check now, the plain sweep on
each segment's direction of travel at 33 points along it.
A circle profile is one closed arc, one edge in SMLib: a wall per path line,
not two.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Going into SMLib a sheet's shell holds both sides of each face, so the side the
record keeps as the sheet's front is lost, and SMLib thickens along the
surfaces' natural normals: Reverse Normal did not change which way a thicken
grew. A sheet used against its natural normals everywhere is thickened by the
negated thickness.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A record edge on a circle or ellipse carries the NURBS form SMLib holds it as,
its interval on that form. The patch built its loop edges from the form alone
(sew::PartEdge had no place for it), so a fill's rim came back from SMLib as a
plain B-spline rather than the body's ellipse. PartEdge now carries the form;
assemble keeps a given form and labels the edge with what it is.
Test helpers that sampled an edge on `curve` with the form's interval picked
points off the edge ("no edge at …"); they sample `parameters()`. The fill's
own-edge check compares the curve's kind and the exact form it is parameterised
on: SMLib renormalises a conic's frame axes in the last bit on a round trip.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The arc part's front edge rounded r2, then its left top edge with tangent
propagation (the Fillet feature's default): that edge runs on round the first
round's end arc and down the left front upright, so three edges end up rounded
(a sphere octant at the corner where they meet), not two. Both results were
exact: 9530.77 (meshed) is the part less three r2 strips and the octant,
9591.44 − (0.858407·(39.1667 + 19 + 8) + 8(1 − π/6)) = 9530.83; 9538.79 is
two strips less their overlap, 9591.44 − (0.858407·62.1667 − 0.7670) =
9538.84. The test compares the sequential rounds with the same edges of the
part rounded together: the picks' chains and every edge of the part the second
chain carried on into.
The other pairs still fail in SMLib (1001, or SM_ERR_INVALID_INPUT at the
knife-edge tip) where a later round ends on the first round's arc.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Fillet and Chamfer features already blend each picked edge's tangent chain
by default (tangent_chain, true unless saved false), as mainstream CAD's
tangent propagation does; the kernel blends exactly the edges it is given.
#8678 refused, before SMLib, every edge that runs on tangentially into one left
out, which also refused blends SMLib builds (a round ending on the round its
edge runs into: blend_corner's a_round_next_to_a_round_of_another_radius, the
same feature with propagation off). Now:
- propagation off: only the picked edges are blended; where SMLib cannot end
the blend at such a continuation, its refusal names the edge it runs into
and that propagation (tangent_chain: true) blends the chain as one;
- propagation on, where the chain cannot be built (an r3 round carried on
round an r2 round's end arc), the refusal says the chain was blended and
that with propagation off only the picked edges are.
A smooth edge is still refused before SMLib. No default changes: the feature's
default was propagation on already.
The kernel tests that stand for a Fillet feature (curvecorner's sequential
rounds, issue 2422) take each pick's tangent chain, as the feature does by
default.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A smooth edge (its faces meet tangentially) has nothing to round, and an edge
that runs on tangentially into one left out has no end SMLib can blend (it
rounds a tangent chain as one sequence and failed building the face there,
status 1001): both are refused before SMLib with that reason. SMLib's new
SMLIB_ERR_CORNER_UNSUPPORTED (a vertex no blend corner handles) is
Error::CornerUnsupported and says so instead of a bare status.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The patch fill meets its neighbours to G4, so Construction::Patch now offers g0 to g4: the
surface.patch command takes g3 and g4 and the Patch dialog's continuity row offers
"Curvature change" and "Smooth curvature change" by itself, from the one table.
The three-round corner test patches G2, G3 and G4 and reads the seams with the Continuity
Analysis too: the middle of each seam (30-70 %) at the order asked; the whole seam G1, since at
the corners the rounds' curvatures differ and no patch can meet both.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF