Commit Graph
3849 Commits
Author SHA1 Message Date
brett19andClaude Opus 5.5 63d4bb5d8b smlib: hold back two fork fixes solidcore has only half of
face_tight_box_searches_trim lacks fork 326de73 and good_drop_result_distances_in_order lacks
eaa998a's tight convergence test. With them on, 15 thread cases fail on their tight box and the
peg's round is refused; both agree with SMLib eaa998a with them off.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 23:02:51 -07:00
brett19andClaude Opus 5.5 cc3a7329c8 smlib: classify_point returns its with_body call directly (clippy let_and_return)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 22:44:05 -07:00
brett19andClaude Opus 5.5 2b49e6c251 smlib: stitch closes a sheet sewn onto a solid's edges into it (capi e5d9bba)
Port of the capi's close_onto_shared_edges in core/merge.rs: edges still free after the manifold
stitch are glued at the same tolerance to the edges they lie on, whatever uses those
(allow_spine_edges), on a copy. Faces then between two material regions go. The copy is kept when
no edge has more than two faces. A gluing that leaves fewer material regions than it found is
refused with Error::Unsupported.

Tests in core/merge_tests.rs mirror capi/tests/sheets.cpp, on solidcore and on C++: a biquadratic
cover over a 10 mm cube sews into a closed solid of 6 faces and 1100 mm^3; a bicubic cover lying
on the top is refused; a flap off a top edge stays beside the cube, 7 faces, 1000 mm^3, 700 mm^2.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 22:34:48 -07:00
brett19andClaude Opus 5.5 d9e922a5a7 smlib: a knife edge's chamfer is the chord of the ball of radius the distance (capi e96898d)
chamfer_radius takes the distance itself at a cusp; test knife_edge_chamfers against the capi's
closed form (not yet run).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 04:59:21 +01:00
brett19andClaude Opus 5.5 fe44a27e33 smlib: blend_dropping routes to solidcore (capi 241f7ba)
The overflow-first rounds need the fork's cliff overflow, which solidcore has not ported: on
solidcore the rounds blend together and no pick is dropped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 04:59:21 +01:00
brett19andClaude Opus 5.5 b09c48a42a smlib: classify_point runs on solidcore (capi 34d6b2b)
SmBrep::Point3DClassify at the body's zone tolerance through solidcore's BrepClassifier; test
points_classify_as_the_capi mirrors the capi's cases, with C++ parity under native.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 04:59:21 +01:00
brett19andClaude Opus 5.5 d6cb8f12c9 smlib: the fixes SMLIB_REV eaa998a carries are on
fillet_trim_inside_by_best_dot (fork de4dae6), fillet_half_degree_crease (2e8758b),
fillet_split_edge_keeps_near_half (ceb3272), good_drop_result_distances_in_order (0b4de8c, landed
as eaa998a), curve_loop_normal_from_area (be45e8d) and face_tight_box_searches_trim (beb6061; the
fork's 326de73 knot division is not in solidcore yet) leave HELD_BACK.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 04:59:11 +01:00
brett19 cb31c0d4bf Merge origin/develop e18fb40d8 into ws/develop-e18fb40 2026-10-31 04:47:55 +01:00
brett19andClaude Opus 5.5 068c6ac762 smlib: fillet_over_a_cliff stays ignored at solidcore 6a2e8c68f with its current refusal
The rail still leaves the face it rolls on (FilletErrorType::NoRoom), which the crate reports as
Unsupported: solidcore#960's cliff overflow (fork 8ba4667) is not complete.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:56:18 +01:00
brett19andClaude Opus 5.5 1b291f750e smlib: gate the C++-only test helpers on the native feature
tests_of (measure_tests) and Raw::canonical (history) are used only by tests that compare with the
C++ kernel, so clippy without native flagged them as dead code.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:27:25 +01:00
brett19andClaude Opus 5.5 727796cbcc smlib: turn on solidcore's new fork fixes at 6a2e8c68f
fillet_nx1_tangent_side_edge_same_convexity (WR-600, fork 7992ec7) and
fillet_removal_takes_ring_fillets (WR-605, fork 52bfef0) each port a tangency-labs/smlib commit
that is an ancestor of SMLIB_REV 68fb9162. The pin needs no API change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:27:25 +01:00
brett19andClaude Opus 5.5 da6cc21c2c smlib: pin solidcore to 6a2e8c68f (main after #1070)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:24:08 +01:00
brett19 b9659c8e5d Merge ws/develop-456e5b7 into ws/combined-1031 2026-10-31 03:23:48 +01:00
brett19 8de0453f58 Merge ws/triage-1031 into ws/combined-1031 2026-10-31 03:23:48 +01:00
brett19 84939bca6f Merge ws/split-g2-trim into ws/combined-1031 2026-10-31 03:23:48 +01:00
brett19andClaude Opus 5.5 10ffd88d01 smlib: untrim out of the body runs on solidcore now that CopyFaces through the merge copies (solidcore#1872)
The capi's copied.GetSize() != 1 is SMLIB_ERR_EMPTY, not a refusal; the four out-of-body untrim
cases are no longer ignored.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:21:52 +01:00
brett19andClaude Opus 5.5 783a4075fa smlib: Split Face on solidcore intersects a face's surface through its face's cache
cut_face intersected the face's surface with a non-plane tool (or a plane strip) by a plain
global_surface_intersect on an evaluation copy of the face's surface. That copy keeps its face
owner, and solidcore refuses a trimmed cache for a face-owned surface reached without the
B-rep ("TrimSrfCache::build_tree_with_face for a face-owned surface", Unported), so a B-spline
face cut by plane strips (surface.trim with sketch lines on a spline sheet) failed with "SMLib
cannot build this exactly". The C++ reaches the face through face->GetSurface(); the port now
solves through the B-rep's BrepFaceServices with the face's cache handle, as solidcore's own
face_planar_section_curves does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:21:51 +01:00
jyvikoandClaude Opus 5.5 e18fb40d8d Reference tests: the eight cases that fail on SMLib eaa998a name their cause as known failures
Develop 38fd4a4f6's Reference tests fail 34, 35, 77, 78 and 81 (STEP export finds fillet edges
4.6e-5 to 6.1e-5 off their surfaces against 2e-5), 37 (the apex blend 0.193 off), 80 (the
taper-to-fit area) and 83 (thicken status 1001). Each expected.json names its cause in
known_failure, which the oracle already reads: a known failure that passes fails the job.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 22:20:00 -04:00
jyvikoandClaude Opus 5.5 d23c37027c Tests: the known-failing list takes develop's 10 failing tests
Develop 38fd4a4f6 (CI run 41157648345, after the SMLib eaa998a pin) fails 10 cargo tests; each
is listed with the cause its failure message gives. Seven are SMLib refusals or results off
their derived volumes (fillet, chamfer and shell), the cli action matrix and naming corpus
among them; the two corner_g2 tests are the fitted G2 corner patch bulging past the box, which
the explicit G2 corner fixes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 22:20:00 -04:00
jyvikoandClaude Opus 5.5 5bb43bdb13 CI: the test jobs grade their junit against tests/KNOWN_FAILING_TESTS
Native Linux tests and the GPU path test shards no longer fail on any failed test: nextest's
"tests failed" exit (100) goes to `cargo xtask known-failing --junit`, which fails on a failure
the list does not name and on a listed test that passes. Any other nextest exit (a build error,
a bad filter) still fails the step at once. The tests skill says to list a failing test with its
cause, in place of ignoring it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 22:20:00 -04:00
jyvikoandClaude Opus 5.5 a26d3ee41c xtask: known-failing grades a nextest junit report against tests/KNOWN_FAILING_TESTS
`cargo xtask known-failing --junit PATH` reads nextest's junit (a file, or every .xml under a
directory, so all of a run's junit artifacts at once) and fails on a test that failed and the
list does not name, and on a listed test that passed (FIXED: take its line off, as the kernel
rig's gate does). A listed test that did not run is neither, since a pull request tests only the
packages it touches. The list has the rig's KNOWN_FAILING format (`<test> <cause>`, sorted, the
rig's own parser), with `<test>` nextest's `<binary id>::<test name>`; `cargo xtask lists`
checks it is sorted. The list starts empty.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 22:20:00 -04:00
jyvikoandClaude Opus 5.5 7953944175 Fillet rig: 1668's R7 past the inside corner is refused at 4 + 2 sqrt2
The round's centre (32 - r, 42 - r) leaves the hollow's corner (30, 40)
outside its circle, opening the wall, where sqrt2 (r - 2) = r: the case
expects the refusal naming 6.828. 2852's R30, refused naming 25.24, now
passes too: both come off the known-failing list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 22:19:55 -04:00
jyvikoandClaude Opus 5.5 b75d176673 kernel: a round that would cut through its wall into a hollow is refused
The owner's rule of 2026-10-30: a round running past a rim of its faces
into open air builds; one whose section would remove material through to
a hollow behind its edge (a slit into the hollow, a cut through the part)
is refused as too large, so the fillet names the largest radius that fits.

Decided exactly in the section of a straight convex edge between planar
faces: the round's centre is at depth r below both planes, and it opens
where its arc uncovers a boundary point strictly inside the wedge with no
material beyond it toward the centre (the body's exact point
classification). Looked at: straight edges parallel to the round's (a
hollow's corner), cylinders about parallel axes (a rounded corner), and a
picked concave parallel edge's own round, which fills the corner.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 22:19:55 -04:00
jyvikoandClaude Opus 5.5 c19500fceb Fillet: the radius-too-large choice in plain nouns
"If too large: Stop and say so / Largest that fits / Narrow where needed"
becomes "Face limits: Exact radius / Largest radius / Narrowed radius", in
every language of the catalog, with the error and the tip that name them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 22:19:51 -04:00
Brett LawsonandClaude Opus 5.5 6f81622a3e smlib: a blend at a corner no type handles is CornerUnsupported on solidcore, as on C++
The capi's blend_failure maps SM_FILERR_CORNER_UNSUPPORTED to
SMLIB_ERR_CORNER_UNSUPPORTED. solidcore notes that code (with
fixes.fillet_vertex_error_diagnostics, which we turn on) when
CreateFilletCorners leaves a vertex without a corner, but the port's
blend_failure mapped only NoRoom, so such a blend failed with the bare
status 1001 (fillets/1390-chamfer-hole-rim-touching-bottom). The note is
kept through the later step that fails because of it, as solidcore's own
FilletSession::do_fillet keeps it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:08:46 +01:00
Brett LawsonandClaude Opus 5.5 a626da2936 smlib: turn on solidcore's new fork fixes at 9b398723b; hold back the rest
On (each ports a tangency-labs/smlib commit that is an ancestor of SMLIB_REV 68fb9162):
revolve_splits_curves_on_axis (WR-590, e4f1377), cover_wraps_across_closed_seam (WR-599,
16bf1cb), imprint_extension_keeps_analytic_curve (WR-601, bec8a0b),
fillet_trace_from_tangent_point_toward_next (WR-603, 68fb916),
fillet_tangent_point_one_sided_step (WR-595, f8fd83e), fillet_rails_meet_at_one_end_point
(WR-594, 5fdefb9), fillet_trace_reaches_rails (WR-609/610, a9277fd, 6e77631),
delete_vertex_joins_seam_iso_curve (WR-598, 829b982), box_face_failures_propagate (WR-596,
0df62c8, 35008b1, 449c81c), ellipse_adjust_step_interval_keeps_turns (WR-211, 5c0b5ed),
fillet_cleanup_removes_input_slits (WR-602, cac11ea), fillet_rail_end_on_continued_surface
(WR-630, 3f22e97), glue_vertices_joins_every_region (WR-607, 661f79c).

Held back: temporary_radius_setup_errors (#458), ellipse_step_interval_checks (#428),
perspective_sphere_offsets (#525) and curve_loop_normal_from_area (#1776) have no fork commit;
fillet_trim_inside_by_best_dot (de4dae6), fillet_half_degree_crease (2e8758b),
fillet_split_edge_keeps_near_half (ceb3272) and good_drop_result_distances_in_order (0b4de8c)
port fork commits not in SMLIB_REV; corner_patch_face_side_twist (7fd9fb0) is unpublished.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:02:12 +01:00
Brett LawsonandClaude Opus 5.5 368a3ca293 smlib: pin solidcore to 9b398723b (main after #1840)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 03:01:55 +01:00
jyvikoandClaude Opus 5.5 38fd4a4f65 Skills: the tests skill's unit-test example stays under the 3600-character limit
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 2fab949916 kernel: blend_smlib laid out by the 2024 edition's rustfmt
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 571d711c8f kernel: the re-blend's removed picks formatted as rustfmt lays them out
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 62fe29dbdb Fillet rig: the cases SMLib 737c392 builds come off the known-failing list
The gate on aarch64 Linux reports 16 fillet cases FIXED with the pinned SMLib: the sloped and
equal-slope basin rim chamfers and rounds past their rims (1080-*, 5835-*), the pocket rim
chamfer past the floor, and the three pocket rim rounds now mitred at the pocket's corners
(every-pocket-*). No other area's gate reports a case fixed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 baf51b2714 kernel tests: the rim chamfers running off their rims build, on SMLib 737c392
chamfer_wider_than_sloped_basin_rim_builds and a_rim_loop_chamfer_running_off_its_rim_builds
waited for SMLib to build the cliff overflow (CloseRemovalRegion refused it,
SM_FILERR_NO_ROOM). The pinned SMLib builds it (eddf0ede4, bba9914b6): both pass on aarch64
Linux and are no longer ignored.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 a85d22e608 kernel: Body::contains, the mesh test, is gone
Every caller asks Body::classify_point now.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvoxKQ2rEZvcXNQnhE3Sgs
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 7ca072ec61 ui, cli tests: probes ask for the exact point class
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvoxKQ2rEZvcXNQnhE3Sgs
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 cdff4ac7c6 engine tests: probes ask for the exact point class
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvoxKQ2rEZvcXNQnhE3Sgs
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 3b88f1acc5 doc: a hole decides whether it exits at its drill point's shoulder exactly
Material past the depth needs a body with the point inside, air before it needs every body to
have it outside; a point within a body's tolerance of the exit face is neither.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvoxKQ2rEZvcXNQnhE3Sgs
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 7b3e66cbae kernel: Body::classify_point decides inside, outside or on the boundary exactly
SMLib's point classification at the body's own tolerance, on the exact faces and edges, in
place of a mesh at a chord of 2e-3 of the body's size (about 0.4 mm on a 200 mm part). A point
within the tolerance of a face, edge or vertex is OnBoundary, never decided by a ray. A mesh
body's triangles are its exact shape: on them within the record's tolerance, else by ray
crossings. The kernel's own probes move to it; Body::contains goes once its last callers have.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvoxKQ2rEZvcXNQnhE3Sgs
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 56d39a5764 smlib: Brep::classify_point says exactly where a point lies against a body
Binds the fork's smlib_brep_classify_point (SmBrep::Point3DClassify at the body's own zone
tolerance): inside, outside, or on the boundary within that tolerance of a face, an edge or a
vertex. A box and a cylinder just off its curved wall in measure's tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvoxKQ2rEZvcXNQnhE3Sgs
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 20c0c2ffcc Kernel rig: a sloped basin's mitred rim rounds are checked tangent along their contact lines
1080-fillet-sloped-basin-1-mm-rim-r0-5-4-edges asked G1 at every blend seam. Its front wall
leans 19 over 20 and the others 10 over 20, so at each rim corner the two mitred rounds meet the
sloped corner edge at different heights (0.155625 and 0.276393 below the top): the deeper round
runs on past the corner edge and is cut by the plane of the other's wall, a crease by
construction, the gap below the shallower round filled on that plane. The check now measures
the rounds' contact seams, on the top and on each wall, where the rounds are tangent. The
volume is unchanged.

With SMLib smlib-batch-4-mitre (1c15364): the case passes (V 144530.427946 against
144530.427909, 15 faces, sound); before it, only the four corner creases failed the check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 58e0d8346e Tests: a 15° tapered text builds, every letter grown, exact where its outline gives it
Owner ruling d6: the letter t of "tres long" was drafted inward by SMLib (its
loop's normal, summed from the cross products of its chords, pointed down;
fixed in SMLib). With the fix every letter grows, and the join builds at 3°
and 15° by the Round rule and by the default rule (tangent for spline
outlines), where before 15° was expected to be refused.

Exact where the outline derives it: a letter's section at height z is its
outline offset by e = z tan a, by the Round rule of area A + P e + C e² while
the offset trims nothing (Steiner; C half each loop's turning less
tan(t/2) - t/2 at each reflex corner), so the letter is
A h + P k h²/2 + C k² h³/3. Each extruded alone, the t at 3° and s, l and o
at 3° and 15° are checked to 1e-6 (SMLib measures them within 1.3e-9; its
mass properties integrate to 1e-8). The concave joins of r, n, g and e are
tighter than e already at 3° (their swallowtails trimmed: r 1.1e-3 under the
formula), the t's by 15° (9.9e-5 over), and on the block the letters grow
into each other, so the whole word is checked for what holds exactly: one
closed body with the block, and half-way up every point of each straight
letter's outline inside the solid (the t drafted inward failed that).

With SMLib's fix (smlib-batch-4-text-loops 82133b2).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 9308224ef5 Fillet rig: the knife edge's 0.5 chamfer builds
SMLib's trim took a fillet meeting its face at more than 78 degrees for one with no side
(smlib-batch-4-rulings 971e567); the chord of the knife edge's 0.5 chamfer meets the flat face at
81 degrees. The case comes off the known-failing list.

Needs SMLIB_REV at that SMLib once it is pushed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 3772a6e972 kernel, doc: an overflowing round goes first; an edge it removes is gone, and the fillet says so
SMLib (smlib-batch-4-rulings 0e83cca, SMLIB_ABI_VERSION 5) rounds the edges whose rounds overflow
their faces first and then what is left of the others; smlib_blend_dropping says which picks'
edges the overflow removed whole. The smlib crate binds it (Brep::blend_dropping), the kernel
returns those picks (fillet_removing), and a fillet notes them as its warning: "the edge at
(0, 0, 10) was removed by the larger round, so it is not rounded" (a 50 x 50 x 20 block, R21 on
its bottom front edge with the front left upright: the block is R21's alone, in closed form).

Ruling d8: [21, 5, 5] on a 20 cube builds as R21 alone (6107.529370); the test is no longer
ignored. R25 with R2 at a corner (blend_corner) builds the same way, R25's alone in closed form,
where it was refused. The rig's 1080 notched block outline at R8 builds now and comes off the
known-failing list.

Needs SMLIB_REV at that SMLib once it is pushed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 6f0bf0dea5 Tests: a 1 degree crease rounds, and the knife edge's chamfers build, on SMLib smlib-batch-4-rulings
With SMLib's smooth limit at half a degree (422e6f1) the 1 degree crease rounds R2 and R20
(the test is no longer ignored), and with a cusp's chamfer the ball of radius d (d231547) the
The 0.5 one stays, for its own cause (the chamfer face left apart from the body). Two corner
cases the same SMLib (replay/1.0.1 and those commits) builds come off too.

Needs SMLIB_REV at that SMLib once it is pushed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 6f7172dc8a kernel tests: a corner round wider than its faces overflows and takes the corner's other edges
R21 on a 20 mm cube's edge builds (6107.529370, closed form, to 2e-12). With R5 on the
corner's other edges the R21 takes the faces they lie on, so the body is R21's alone; SMLib
fails that blend (status 1001, fillet error 4, Unable to Trim Rail Curve) and the test is
ignored until it builds. It replaces the refusal test that expected TooLarge.

Ruling d8 (2026-10-30).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 c23ef9d93a Fillet rig: the knife-edge chamfers name SMLib's cause, a cusp's ball radius of 0
smlib_chamfer turns the distance into a ball radius d sqrt((1 - c)/(1 + c)), c the faces'
binormals' dot (capi chamfer_radius); at #851's cusp the binormals agree, the radius is 0 and
the call is SM_ERR_INVALID_INPUT before the fillet executive runs (gdb: chamfer_edges sees
radius 0; the dump's why is empty). SolidCraft hands every chamfer to SMLib, so the
ball-contact chord (the ball of radius d: 3.822 wide at d = 2, 159.2365 removed) is SMLib's to
build.

Ruling d4 (2026-10-30).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 4f64a035ab kernel: one smooth angle, and a round too small to change the part is refused
The blend's tangent angle is the shaded view's half degree (smooth_edges::ANGLE), one value
for smooth. A constant round lies r (sec(d/2) - 1) inside the crease it replaces (about
r d^2/8); below the edge's tolerance it changes nothing and is refused before SMLib (which
answered SM_ERR_INVALID_INPUT), naming the smallest radius that rounds,
tolerance / (sec(d/2) - 1). d is the least turn along the edge
(tangent_edge::least_angle_along, at tangent_all_along's stations).

Ruling d3 (2026-10-30). The block's tolerance is 2e-5 mm, not 0.1 um: at 1 deg the smallest
radius is 0.526 mm, so R2 and R20 reach SMLib, which still calls an edge within 2 deg smooth
(SmEdge::GetBlendEdgeuse); that test is ignored until SMLib uses 0.5 deg.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 04955683f8 Tests: a strip's tangent and curvature run-offs are the distance long across the surface
SMLib measures an extension's distance across the surface (smlib_extend_sheet corrects
CreateExtendedSurface until the parameter line through the side's middle is that long), so each
run-off of the cylinder strip, swept 20 along z, adds 5 x 20: 10 pi/2 20 + 100 = 414.159 for
both. The parabola-length formula (418.18) was truck's.

Ruling d2 (2026-10-30).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 abe571b277 SMLib: pin eaa998a (tangency-labs/smlib#68, #69, #70)
Batch 4: drafts and loops, mitre corners, rim chamfers, rulings, tight box, stitch, point
classification, eased corners. Batch 5: a face's tight box divides its cells at the surface's
knots (thread boxes exact); a cylinder, cone, sphere or torus is extended along its own circles.
Batch 6: a revolution's extension closes its turn; a dropped point's foot is the converged one.
The C API is ABI 5 (smlib_blend_dropping and smlib_brep_classify_point are new; nothing existing
changed), so the binding expects 5.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 21:55:53 -04:00
Brett LawsonandClaude Opus 5.5 0afb20287d smlib: closed_nonmanifold on solidcore takes a failed edge query as false, as the capi does
The capi's closed_nonmanifold (smlib_ops.cpp) returns false for an edge that
is null or whose GetEdgeuses fails; the port propagated the error, failing the
boolean instead of reporting it not solid. The per-edge test is now
`edge_closes`, which takes either failed query as false.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 02:53:22 +01:00
Brett LawsonandClaude Opus 5.5 b4ee38083f smlib: solidcore's check counts no SmBrep test 21 warning, as the capi's does
The capi's smlib_brep_check (smlib_check.cpp, `advisory`) skips SmBrep test 21,
"Suspicious Shell Count": a warning AssertValid reports without failing. The
solidcore port counted it, so a sheet of faces offset apart across a sharp edge
(one shell per face, rightly) was refused after the stitch whenever the Check
family ran on solidcore (surfaces/cov-offset-two-faces-across-a-sharp-edge-come-apart).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 02:53:22 +01:00