Commit Graph
3252 Commits
Author SHA1 Message Date
jyvikoandClaude Opus 5.5 60f33f6fc6 Feature walks: Repair Part has its fixture, its gap an input and its body renamed with the rest
#8676 added FeatureKind::Repair without a fixture, so
feature_walk_tests::the_record_covers_every_variant failed. The fixture sets
every field (body, gap, patch_holes); the records, written with
FEATURE_WALK_BLESS=1, show its one input (Gap, a length) and that copying with
bodies renamed rewrites its body.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 07:14:45 -04:00
jyvikoandClaude Opus 5.5 a0eaceab5e SMLib tests: a round larger than the cube is cut as if its faces went on, at its exact volume
At the 7e917f0 pin SMLib builds the r50 round of a 20 cube's edge that
hostile_inputs_are_errors expected to fail: a convex blend that overflows its
faces' far edges is built by subtraction (blend on the faces extended, then cut),
as the chamfer past the faces two lines below already is. The body is exact: the
two ends, the two far faces and the round (5 faces, 9 edges, 6 vertices), volume
20 (F(40) - F(30) - 300) = 1094.85273 with F(u) = (u sqrt(2500 - u^2) +
2500 asin(u / 50)) / 2, the cube's section inside the r50 circle about
y = z = -30. The test checks that answer instead of an error.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 07:14:45 -04:00
jyvikoandClaude Opus 5.5 94d763c839 Tests: a round run on through an earlier one by tangent propagation is matched by the same edges together
The arc part's front edge rounded r2, then its left top edge with tangent
propagation (the Fillet feature's default): that edge runs on round the first
round's end arc and down the left front upright, so three edges end up rounded
(a sphere octant at the corner where they meet), not two. Both results were
exact: 9530.77 (meshed) is the part less three r2 strips and the octant,
9591.44 − (0.858407·(39.1667 + 19 + 8) + 8(1 − π/6)) = 9530.83; 9538.79 is
two strips less their overlap, 9591.44 − (0.858407·62.1667 − 0.7670) =
9538.84. The test compares the sequential rounds with the same edges of the
part rounded together: the picks' chains and every edge of the part the second
chain carried on into.

The other pairs still fail in SMLib (1001, or SM_ERR_INVALID_INPUT at the
knife-edge tip) where a later round ends on the first round's arc.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 07:14:45 -04:00
jyvikoandClaude Opus 5.5 0ec97c5708 Blends: tangent propagation off blends the picked edges alone; a refusal says how to change it
The Fillet and Chamfer features already blend each picked edge's tangent chain
by default (tangent_chain, true unless saved false), as mainstream CAD's
tangent propagation does; the kernel blends exactly the edges it is given.
#8678 refused, before SMLib, every edge that runs on tangentially into one left
out, which also refused blends SMLib builds (a round ending on the round its
edge runs into: blend_corner's a_round_next_to_a_round_of_another_radius, the
same feature with propagation off). Now:
- propagation off: only the picked edges are blended; where SMLib cannot end
  the blend at such a continuation, its refusal names the edge it runs into
  and that propagation (tangent_chain: true) blends the chain as one;
- propagation on, where the chain cannot be built (an r3 round carried on
  round an r2 round's end arc), the refusal says the chain was blended and
  that with propagation off only the picked edges are.
A smooth edge is still refused before SMLib. No default changes: the feature's
default was propagation on already.

The kernel tests that stand for a Fillet feature (curvecorner's sequential
rounds, issue 2422) take each pick's tangent chain, as the feature does by
default.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 07:14:45 -04:00
jyvikoandClaude Opus 5.5 229739a704 Blends: a smooth edge and an unfinished tangent chain are refused saying why; SMLib's unsupported corner is named
A smooth edge (its faces meet tangentially) has nothing to round, and an edge
that runs on tangentially into one left out has no end SMLib can blend (it
rounds a tangent chain as one sequence and failed building the face there,
status 1001): both are refused before SMLib with that reason. SMLib's new
SMLIB_ERR_CORNER_UNSUPPORTED (a vertex no blend corner handles) is
Error::CornerUnsupported and says so instead of a bare status.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 00:30:07 -04:00
jyvikoandClaude Opus 5.5 ef93b18eda SMLib: pinned at 7e917f0: a corner patch tangent to its sides, an unsupported corner named, a torus from a NURBS a whole turn round its tube
tangency-labs/smlib#11 (the Coons corner patch is tangent to its sides' surfaces), #12
(SMLIB_ERR_CORNER_UNSUPPORTED for a vertex no blend corner handles) and #13 (a torus found in a
NURBS has its major radius from its origin and a whole turn of its tube). Prebuilt hashes written
by scripts/fetch-smlib.sh --pin.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 00:30:07 -04:00
jyvikoandClaude Opus 5.5 7c9a9051d8 Patch: the continuity choice's hover text says the corners stay tangent where the faces round them clash
The Patch dialog's continuity row keeps each order's hover line and adds one: the patch meets
the faces round it at the chosen continuity along each side, and at a corner where those faces
meet each other with different curvatures it stays tangent (G1) there. New text in
assets/locales/pending/patch-continuity-corners.json, in English and the complete catalogs
(Arabic, Hebrew, Japanese, Chinese), German and Korean.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 00:30:03 -04:00
jyvikoandClaude Opus 5.5 102cde292c Kernel rig: patched holes graded by their continuity, at clashing corners and in one sheet
Four continuity cases for the patch fill. A hole in one smooth sheet (a cubic Bezier profile
extruded, a square trimmed out) patched g2 and g3: every seam reaches the order, corners
included, since round the hole there is one surface. The hole a three-round corner's blend
face leaves, patched g2 and g3: exactly g1 over each whole seam, since at the hole's corners
the rounds meet each other G1 (their curvatures differ by 1/4 or 1/8 per mm) and a patch smooth
there has one curvature; the middle of each seam reaches the order (kernel test).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 00:30:03 -04:00
jyvikoandClaude Opus 5.5 7d00ad78c4 kernel: a patch builds G0 to G4, and Continuity Analysis reads each seam's middle at the order asked
The patch fill meets its neighbours to G4, so Construction::Patch now offers g0 to g4: the
surface.patch command takes g3 and g4 and the Patch dialog's continuity row offers
"Curvature change" and "Smooth curvature change" by itself, from the one table.

The three-round corner test patches G2, G3 and G4 and reads the seams with the Continuity
Analysis too: the middle of each seam (30-70 %) at the order asked; the whole seam G1, since at
the corners the rounds' curvatures differ and no patch can meet both.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-29 00:30:03 -04:00
jyvikoandClaude Opus 5.5 11af682c0f examples: cleaning up rounds by patching their messy faces, G2 and G3
Two command scripts in examples/clean-up: a round along a plate's edge running into a boss
wall, and a corner where three rounds meet. Each takes the blend's messy face off (face.delete
heal false) and patches the hole with Curvature (g2) and, beside it, Curvature change (g3).
Gauss-Legendre constants at f64 precision.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 00:30:03 -04:00
jyvikoandClaude Opus 5.5 0631d2d3a4 kernel: a three-round corner patched G2 and G3, read off the faces at each seam
The corner blend of a box's R8 vertical round and R4 top rounds taken off and patched: both
patches meet the tangent planes and the curvature in the middle of each seam; the G3 patch
also meets the curvature's rate of change (4e-6 to 4e-5 /mm^2), which the G2 patch leaves at
0.27 to 0.63. G3 to an edge between two faces is refused; G3 is no longer refused as such.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 00:30:03 -04:00
jyvikoandClaude Opus 5.5 2397a691c4 geom: the patch fill is faired at the order it is asked for
A fill asked G^n is faired with the thin plate plus the energy of order n + 1 (each to unit
trace), so the change of curvature its conditions ask at the edges spreads over the fill
instead of being squeezed into the first span; Gram matrices on six-point Gauss-Legendre,
exact for quintics.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 00:30:03 -04:00
jyvikoandClaude Opus 5.5 7d9c84bdb6 geom: the patch fill is tangent continuous across its own C0 knot lines, and tapers what its corners do not allow
- Rows across a patch's C0 knot lines (a side's break where it is only C0 in its parameter, such
  as a circle's quarter joint in homogeneous form): the one-sided derivatives across in the
  ratio of the crossing sides' speeds there, blended between them. Without them the fill rippled
  along those lines (zebra stripes in steps) and SMLib's surface check refused it.
- Space::basis_left: the basis of the piece ending at a knot.
- Orders above a corner's agreement come back smoothly over the next share of the side
  instead of switching on at once.
- Orders above G1 are best effort once refinement is spent: the fill is returned with its
  jumps reported; the tangent plane, the points and an unfolded fill stay hard.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 00:30:03 -04:00
jyvikoandClaude Opus 5.5 ed830a168d geom: the patch fill takes the dense spline edges a blend leaves, and holds what its corners allow
- One patch has a space along u and one along v, each holding its two sides that run that way;
  a side's knot keeps its continuity when raised (multiplicity m + q - p), and each side is
  carried in exactly by interpolation at the space's Greville abscissae.
- Refinement halves the spans only in the direction whose sides miss, and one patch's normal
  equations are banded (the shorter direction numbered fastest), so a loop with a long
  intersection curve refines where it needs to.
- At a corner whose neighbours agree to a lower order than asked (their tangent planes, their
  twist between the two edges, or their forms), the stations near it ask no more than that.
- A station is held to the angle tolerance beyond the edge's own lean out of its neighbour's
  tangent plane: a fill that holds the edge cannot come nearer.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 00:30:03 -04:00
jyvikoandClaude Opus 5.5 99297495b3 geom, kernel: the patch fill meets its neighbours with G0 to G4, on rational edges too
One order-n implementation in the linkage-curve formulation (Pegna & Wolter 1992;
Hermann, Lukacs & Wolter 1999): geom::linkage reads the neighbour as a height over its
tangent plane to order n (its jet, from the surface's exact partials of any order) and
gives each order's condition on the linkage curve, with exact gradients (dual numbers),
so fill_iso solves orders 2..n by Newton's method. Each order's row is weighed by h^(k-1)
and its jump is held, carried into the fill by Taylor's theorem, within the angle tolerance.

The iso fill takes rational edges (a circle's arc on its NURBS form): homogeneous rows,
each edge scaled so the corner weights agree, the inside weights the Coons blend and
fixed, so the fill stays a linear least-squares problem. Its degree is at least n + 1,
refinement adds simple knots, breaks of different sides within rounding are one, and the
weak Hermite rows act in the tangent plane at the Coons start's own speed, so they no
longer pull against the G1 rows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
2026-10-29 00:30:03 -04:00
jyvikoandClaude Opus 5.5 f351f42df6 Repair Part: the repair runs once, as the feature evaluates
The command worked the repair out itself for its reply and the feature worked it out again
when it evaluated. The evaluation now keeps the kernel's report on the feature's result (as
an import keeps its import report, cached with it), and the command's reply is built from
that: one repair per call, and a part with nothing to repair fails the evaluation, which
leaves the design unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 00:29:59 -04:00
jyvikoandClaude Opus 5.5 f56e34d1ce Refused part: the Repair Part comments say it is built
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 00:29:59 -04:00
jyvikoandClaude Opus 5.5 7c8132e2d6 Repair Part (body.repair, #8371): rebuild refused faces, sew gaps, patch holes
A new undoable feature (`repair`, one pending format file) and command with input and
output schemas. In order:

- A cylinder, cone, sphere or torus face SMLib refuses on its own is rebuilt on a NURBS
  form of its surface laid on arcs from where the face starts
  (`form::surface_on_own_arcs`), with SMLib's own trims: the import's quarter-grid form of
  a face round most of a turn closes on itself, which SmTorus::IsNurbSurfaceTorus does not
  recognise. Geometry unchanged.
- Free edges that pair up within `gap` are sewn by SMLib's stitch; GlueEdgesGeneral gives
  each glued edge its own tolerance (at least twice its gap), the body's and the other
  edges' stay. The result is checked against the input's own SMLib check, the
  tolerance-bound tests (#5, #6, #59, #82) exempt.
- Loops of free edges left are holes: offered as surface.patch, and with patch_holes made
  (flat only when the loop is planar and every face around it is a plane, else G1) and
  sewn in.

The reply reports what changed face by face; nothing to do is refused with why.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 00:29:59 -04:00
jyvikoandClaude Opus 5.5 e0c7867b9b run_strict: the box's volume to 1e-9, as SMLib integrates it
allow_errors_writes_anyway_and_a_saved_design_keeps_failing compared the box's volume
with 4000.0 to the bit, which the old kernel's closed-form planar volume gave. SMLib
integrates mass properties numerically (relative accuracy 1e-4 asked for) and gives
the 20 x 20 x 10 box within a unit or two in the last place (3999.999999999999), the
correct answer to the precision the measure has. The test now checks 4000 mm³ to a
relative 1e-9.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:13:01 -04:00
jyvikoandClaude Opus 5.5 b121d8d008 frames tests: the moved combine tool's part is made ungrounded
a_combine_tool_stays_where_it_is_placed makes a part and then moves its occurrence
to check that a combine tool stays where it is placed. Since #2804 the design's first
part is grounded when it is made, so the occurrence.move refused and the test never
reached its question. The part is now made with grounded: false, as a part that is
meant to be moved is; the checks are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:12:48 -04:00
jyvikoandClaude Opus 5.5 f11c0c5712 Bodies: an operation's result is its record, not the SMLib body it was exported from
A body made by an SMLib operation kept that SMLib body beside its record (SMLib's
export). The export is not exact to the bit, so the kept body measured and operated a
little differently from the record's import, which is what a body read back from a
file has: a box measured 24000.000000000004 mm³ live and 24000.0 reopened, a drilled
box 21989.38056 against 21989.38013. A cut ring's volume therefore changed when it
was moved, the moved ring being measured on the SMLib body the move made
(measure_centre_tests::combine_cut_volume_does_not_depend_on_placement). Every body
now imports its record when an operation first needs it, so evaluated and reopened
bodies are the same.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:12:37 -04:00
jyvikoandClaude Opus 5.5 bc6d31e603 GPU tests build their designs with SMLib, and the GPU jobs fetch it
The GPU path tests (and the Windows FXC job, cargo test -p solidcraft-gpu) build real
designs through solidcraft-engine, a dev-dependency without its smlib feature. Run on
their own (-p solidcraft-gpu), nothing in the build turns SMLib on, so every geometric
step answered "this build has no SMLib" (10 path::* tests on develop). The
dev-dependency now asks for engine/smlib, as the apps do, and both jobs fetch SMLib
before building.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:12:31 -04:00
jyvikoandClaude Opus 5.5 52343ba23b Robustness tests: a round's tangent chain and the lid's closed-form volume
fillet_into_an_earlier_round picked the box's upright after rounding its top edge
and expected only that edge rounded. Since solid.fillet rounds each picked edge's
tangent chain by default (84bd2daad), the upright runs on through the first round's
end arc into the top right edge, and that is rounded too. The two-radius checks now
ask for exactly the picked edges (tangent_chain: false), and a new check rounds the
chain and expects what a round of the 38 mm top right edge takes off as well.

ribs_flush_with_a_window_change_nothing_away_from_them compared the lid with
6703.5222 mm³, the old kernel's chorded volume. The lid's closed form (the plate
with its rounded corners, the skirt, less the window, the slot and the notch) is
6703.5344 mm³, which SMLib gives; the test computes it, and the script's
description says it. Each rib's volume and area are checked to SMLib's mass
property accuracy (2e-7 relative) instead of 1e-6 absolute.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:12:09 -04:00
jyvikoandClaude Opus 5.5 5d25684a13 sheet tests: the flat pattern as SMLib's exact 2D boolean makes it
Three expectations encoded the old truck planar booleans' incidental output;
each is replaced by the exact answer:

- a_base_trimmed_for_a_flange_keeps_its_arcs: the flat outline has 10 edges,
  not 12. The flange's bend zone and panel meet in line, and the union of
  the two is one line along each side (a region's boundary has no vertex in
  the middle of a straight run). Lengths and areas are unchanged and still
  checked to 1e-9.
- a_base_trimmed_through_a_free_form_curve_follows_it_with_arcs, renamed
  ..._keeps_it_exact: the trim cuts the parabola exactly, so the base keeps
  one conic and three lines instead of tangent arcs within 0.001 mm. The
  strip (183.564 = ∫ y from 197 to 200, or 600) and the bend's length
  (62.364) are now checked to 1e-6 and 1e-9 instead of 0.22 and 2e-3; the
  chorded comparison stays.
- pockets_with_free_form_outlines_are_machined_beside_free_form_cut_outs:
  the machining record holds the pocket's four exact conics in their order,
  started at another of them; the check is for the same closed loop, not
  the same first segment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:12:07 -04:00
jyvikoandClaude Opus 5.5 00faac9659 kernel: a planar sheet's loop splits where it passes one vertex twice
Reading a planar sheet back from SMLib split each loop where two of its
segments started within ten times the record's tolerance (2e-5 mm), so
the two ends of an edge shorter than 2e-4 mm counted as one point and the
edge came out as a loop of its own, which the next planar boolean refused
("needs closed loops"). A loop passes a point twice where it passes one of
the record's vertices twice; the split now reads the vertices, not their
places. The sheet built from our own regions still splits by place, at ten
times the caller's tolerance.

Fixes sheet::tests::a_ledge_beside_an_edge_as_tall_as_the_setback_goes_with_the_strip
(the ledge 1e-4 above the bend line); new kernel test
a_ledge_shorter_than_the_record_tolerance_reads_back_as_one_region.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:12:07 -04:00
jyvikoandClaude Opus 5.5 b9d4ad74f4 kernel: a planar region inside another's hole keeps its material
The SMLib planar sheet united every region's material and then cut every
region's holes from it, so a region lying in another's hole (the island
inside a ring cut) was cut away with that hole. Each region is now its own
material less its own holes, and the sheet is the regions united.

Fixes sheet::tests::ring_cut_retains_exact_central_material_island (the
flat solid lost the island's π·25·2.5 mm³) and the kernel's
compound_planar_extrusion_normalizes_overlap_and_retains_islands.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:12:07 -04:00
jyvikoandClaude Opus 5.5 068c6a6dcb Shell certificate tests: the saved strips are saved data, not rebuilt pieces
Two tests rebuilt the old kernel's raw strips (a shell's wall split along its
opening, a stepped tab's -x wall split by the Join and the Cut) with today's
kernel and took the saved piece's name and projection from them. SMLib leaves
those walls one face, so there is no strip to rebuild: the tests now say so (the
wall is one face) and give the saved link as what an older file holds, its piece
name and its rectangle (y 10..20 x z 0..20 on the -x wall, the same 4-line
projection the strip had), and keep every check of what the model does with it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:11:55 -04:00
jyvikoandClaude Opus 5.5 ccff7224c3 Shell: its planar walls carry their shell roles again
The SMLib port of shell dropped with_shell_planar_sources (then deleted it as dead
code), so a shelled body's kept walls and their inner linings had no ShellPlanar
certificate: a sketch or press-pull on a shell's floor lost its attachment (the Pi
case's Sketch2 and everything after it, press_pull_on_the_pi_case_floor) and the
shell certificate tests found no inner/outer face. The roles come from the input's
exact planar supports, so they apply to SMLib's result unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:11:55 -04:00
jyvikoandClaude Opus 5.5 ab3ba1af44 Mesh: a ray through an edge two triangles share crosses one of them
Mesh::ray_crossings and InsideIndex counted a triangle crossed by a
Möller-Trumbore test with half-open barycentric bounds (u in [0, 1), u + v < 1).
Those bounds depend on each triangle's own vertex order, so on an edge two
triangles share the ray was in both or in neither: the bracket example's hole
centre lies on a diagonal of the base's top triangulation and was counted 0 or 2
times instead of once (bracket_example_cuts_two_through_holes_and_reopens).

Both now use ray_crosses, a watertight test: each edge's side of the ray is the
signed volume dir · ((p - o) × (q - o)), which is exactly antisymmetric in
floating point, so the two triangles of an edge see it with opposite signs, and a
ray exactly on an edge's line is put on one side by the edge's endpoints in
lexicographic order. New geom test ray_crossings_count_a_shared_edge_once crosses
a grid at every inner edge, straight down and obliquely.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:11:51 -04:00
jyvikoandClaude Opus 5.5 17465a63b8 Tests: the kernel-cases ladder is the reference for what the kernel builds; the seeded robustness goldens go
The seeded robustness goldens (tests/robustness/goldens.json, tests::robustness_goldens) recorded
what truck built for seeds 0-95, so they now fail on every seed SMLib builds differently. The
kernel-cases ladder (tests/kernel-cases/ladder, cargo xtask kernel-cases --ladder), whose cases
each carry their own right answer, supersedes them.

Gone with them: fuzz::golden, the CI goldens lane (the goldens output, SLOW_SEEDS, the re-record
hint), their nextest filter and priority entries, the mutants sample and the tests/robustness/
test-data mapping in affected.py. The robustness seeds and tests::robustness stay. The docs point
at the ladder.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:11:42 -04:00
jyvikoandClaude Opus 5.5 175b4f2acd GPU tessellation: the shader's basis slots follow the CPU evaluator's highest degree
tess.wgsl sized its basis arrays for degree 7 by hand. It now holds 17 slots, degree 16 as the
CPU evaluator, and a test fails when the two drift apart again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:11:39 -04:00
jyvikoandClaude Opus 5.5 b91ad9de25 Splines: every degree a B-rep record holds is evaluated, so a G4 blend of degree 9 gets its pcurves
A G4 blend curve is one Bezier of degree 9, and the face extruded from it a spline surface of
degree (9, 1). The record accepts splines up to degree 16 (Brep::validate), but the evaluators
behind pcurves, tessellation and Continuity Analysis capped the degree at 7
(MAX_SPLINE_DEGREE), so the SMLib export refused the face with "pcurve: not supported yet: a
spline surface of degree (9, 1)". The cap was not an algorithmic limit: every routine under it
is the general NURBS Book algorithm, sized by fixed arrays of MAX_SPLINE_DEGREE + 1 slots.

MAX_SPLINE_DEGREE is now the record's own bound, 16, and Brep::validate reads the same
constant. The display evaluator's first-derivative basis (tess::basis_ders) works on two
one-dimensional tables (A2.2 at degree p and p - 1, eq. 2.7) instead of a square one, as its
GPU twin does, so the larger bound costs a low-degree surface nothing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:11:39 -04:00
jyvikoandClaude Opus 5.5 517fc01dcf Fillet rig: a regression gate on every pull request that touches fillet code
cargo xtask kernel-cases --known-failing FILE grades a set against its
baseline: it fails on a case that fails and is not listed (a regression)
and on a listed case that passes (fixed: its line goes, so the list only
shrinks). The Fillet rig workflow runs the fillet set that way on pull
requests touching the blend, fillet, corner and continuity kernel files,
crates/smlib, eval*.rs, engine features.rs or the cases: one release
build of solidcraft-cli on a Blacksmith runner, SMLib prebuilt, sccache
on a sticky disk that main and develop commit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 21:23:24 -04:00
jyvikoandClaude Opus 5.5 52339b7ec3 Kernel rig: fillet cases for the open fillet issues, each with its exact answer
New: an r5 curvature corner at a box corner (its patch must seam G2), an
edge running tangentially into a round left out (refused: continues
tangentially), a convex r10.01 round 0.01 past a 10 mm face (built by
subtraction: V = 7139.875, A = 2585.140). The bar and boss arc rounded
together say their crease (15.6 deg r2, 13.1 deg r1); 1390 expects SMLib's
unsupported-corner refusal, the honest reason today; past a full round
the exact fit's refusal names the largest radius that fits, 7.5 mm.

KNOWN_FAILING lists the 18 of 89 fillet cases failing today, each with
its cause.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 21:23:24 -04:00
jyvikoandClaude Opus 5.5 39bf63b16a Kernel rig: designed continuity cases, G0 to G4, that prove the measurement
A new `continuity` area: seams whose order is certain by construction, each graded
`exact` (reads its order and not the next) at picked edges with Continuity Analysis's
default stations and tolerances: a box's crease (g0), a chamfer in place of a round (g0),
an r5 round on planes (g1), and a profile closed by a g1, g2, g3 or g4 blend curve between
lines, extruded (g1 … g4). `continuity.edges` may now be a list of points, picked as
`inspect.continuity` picks them, and `continuity.exact` asks for the order and no more.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 21:22:17 -04:00
jyvikoandClaude Opus 5.5 c37b0d2f02 Kernel rig: a case's expected continuity order at its blend seams
expected.json may give `continuity: {order: g0…g4, edges?: "blend" | "corner"}`: the
seams of each round, chamfer face or corner patch with the faces either side of the edge it
replaced, and of each corner patch with its rounds, are measured as Continuity Analysis
measures them (seam_diagnostics at its default 33 stations and default tolerances), and the
case fails naming the worst seam, its faces, the order it reaches and the next order's worst
value. The seams come from the faces' persistent names (doc::naming::blend_seams). The older
`{near, within_mm, …}` form is kept.

Every fillet-area case with a body gets its order: constant rounds and rolling corners g1,
curvature rounds g2, chamfers g0, the corner: g2 patch g2 at its seams.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 21:22:17 -04:00
jyvikoandClaude Opus 5.5 c070f044ab STEP import: a torus face round most of its tube is formed within one turn of it
A torus face covering most of its tube off the tube's quarter lines (an
exhaust collector's bend: 326° of the tube from −113.8°) needed a fifth
quarter along the tube, which STEP counts from the outer equator: its form
ran past a full turn of the tube and SMLib refused the solid. #8496 turns
frames about the axis only, and the torus label had no tube reference.

The torus label gets a tube start (`tube_start`, radians; 0 and left out
of the record by default, so older records mean what they did): v counts
from there, in every evaluator, form, pcurve, iso curve, tessellation,
placement, SSI and SMLib transfer. A spilling torus face's tube start moves
to where its tube begins, or a turn before where it ends, whichever puts
its tube circles on the grid of a round face they are about the axis of
(a pipe's cylinder meeting the bend); circles round the tube are labelled
from the tube start (brep::form::on_tube), so their forms and pcurves lie
on the face's quarter grid exactly. The saved-format change is one file,
crates/doc/src/format/pending/torus-tube-start.rs.

Engine assembly: COLLECTOR_EXHAUST_VER_1 now comes in as a closed solid
(refused 3 -> 2); Poppy Humanoid unchanged (4).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 21:22:11 -04:00
jyvikoandClaude Opus 5.5 bd2785717d UI: a header layout chosen by the host app
SolveApp::header (toolbar::HeaderLayout) lets the app that hosts the UI
choose where the application bar puts three things; the default is the
current desktop layout, pinned by a test:

- command search: in the ribbon's tab row (default), or in the bar
  immediately left of Settings, folding to its magnifier when the bar is
  short of room (the ribbon's tabs then run to its end);
- Report a bug: a labelled button (default), or an icon drawn like Settings
  and Help with its name as tooltip and accessible label;
- the version: in the bar (default), or as a Help menu row after About that
  opens the release notes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:43:19 -04:00
jyvikoandClaude Opus 5.5 b3cb826ed4 Engine: an optional check before every command
An app that embeds the engine can install a check on the Session
(Session::set_command_check). Session::execute asks it before each command
with the command id, its parameters and the session (read only); a refusal
comes back as EngineError::Refused with the check's reason and leaves the
design unchanged. Without a check nothing changes.

The check belongs to the host: it survives opening and starting designs,
scratch copies (previews, off-thread evaluation) carry it, and the desktop
UI hands it on to every document tab and to designs opened in the
background.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:43:19 -04:00
jyvikoandClaude Opus 5.5 c7373279d8 Viewport: hidden edges are drawn before the visible ones, so a visible edge is never covered by a light hidden copy
An edge along a face seen edge on lies within a pixel of the nearer face beside it, which hides
part of its width; its hidden copy, drawn after the visible edges, laid a light line over the
visible edge of that nearer face (some 100 px on a box at yaw 1.565). Drawn first, it is covered.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:42:39 -04:00
jyvikoandClaude Opus 5.5 ce71791ece Spline surfaces: a closed spline whose outermost knots appear once is periodic
uv::closed tells a spline closed on itself (periodic, one knot interval per period) by
its first and last control rows and knots clamped at both ends, checked as k[0..=p] and
k[n..=n+p] all equal. Over its interval [k[p], k[n]] a spline of degree p never uses
k[0] or k[n+p]: it starts at its first control point and ends at its last when
k[1..=p] and k[n..n+p-1] repeat. A periodic quadratic circle written with knot
multiplicities 1,2,...,2,1 (as OpenCascade writes one) was taken as open, so its seam
edge's two uses got one pcurve and the face was refused as a loop across a closed
spline surface's seam without a seam edge (periodic_knot_tube_faces_import_and_mesh:
"pcurves failed on 2 of 2 faces"). The check now skips the outermost knots; the knots
the existing test calls unclamped (uniform) stay open.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:41:57 -04:00
jyvikoandClaude Opus 5.5 44b859fe6e STEP import: a whole sphere bounded by one seam has its frame on that seam
A SPHERICAL_SURFACE face bounded by one meridian used both ways is a whole ball, but the
file's placement need not have its poles at the meridian's ends: a sphere's frame is any
right-handed frame about its centre (the same surface, its natural normal outward). With
the poles elsewhere, the seam is a slit across the face's form, not the form's own seam;
SMLib's export refused the record ("a closed shell bounds two regions and encloses one"),
and the ball was not imported
(seam_only_sphere_whose_placement_axis_misses_its_poles_imports_as_a_whole_ball).

Before anything is measured on the frame, such a sphere's frame is put on its seam: the
axis through the seam's ends (which must be antipodes on the sphere, within the
tolerances), the x axis through the seam's middle. A seam already between the frame's
poles keeps the file's frame.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:41:57 -04:00
jyvikoandClaude Opus 5.5 4688c0f20a STEP import: a whole round face whose seam is off its frame's quarter lines is turned onto one
A cylinder, cone, sphere or torus face of one whole turn has a NURBS form of the four
quarters from the one its seam starts in (brep::form::face_quarters). When the seam is
not on a quarter line of the file's frame, the seam's second use lies a period on, past
the form's end: the face's domain stopped at the form's end and SMLib measured a ball
whose seam meridian is 0.7 rad off its frame's x axis 2.2% short
(tilted_seam_only_sphere_imports_as_a_whole_ball: 32.03 vs 32.74 mm3), and a 5 mm ball
with its seam 1 rad off, holding a 2 mm void, 481.0 vs 490.1
(seam_only_sphere_void_is_turned_inside_out).

turn_quarters, which says whether turn_frames (ee4d4b5a5) turns a face's frame, counted
such a whole turn as four quarters, never a spill. It now counts the quarters the face's
angle interval needs on the grid (brep::form::quarters, as for a face of less than a
turn): five for a whole turn off the quarter lines, so the frame is turned about its
axis to put the seam on one, and the form's seam is the face's.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:41:57 -04:00
jyvikoandClaude Opus 5.5 fc3a13f176 step_in tests: the import's repair notes for added seams and turned faces
The schema 4 reader adds a seam to a face that winds around its surface without one
(3d7e465b1) and turns over a face whose loop disagrees with its same_sense, and notes
both (the spindle torus tests assert the seam note). The tests written against truck
expected no warnings:
- step_conformance_parts_read_back_their_exact_shape: each part's seam count (the cone,
  dome, cylinder parts bounded by their rims alone); volumes, boxes, faces unchanged.
- extruded_ellipse_patch_crossing_profile_seam_stays_trimmed: same_sense .F. adds the
  turned-over note.
- implicit_bound_can_still_describe_the_complement_of_a_patch becomes
  implicit_bound_against_its_face_sense_turns_the_face_over: the strip's one bound on a
  cylinder cannot be a hole (the cylinder is unbounded along its axis, so the face would
  have no outer boundary); the loop bounds the face, turned over, the 42 mm2 strip.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:41:57 -04:00
jyvikoandClaude Opus 5.5 ae393fd9ce step_in tests: a face with too many bounds is refused by the reader's own limit
The face-bounds limit lives in crates/step's topology (MAX_BOUNDS, 54b10b9a3) since the
truck reader that said 'boundary loops' went (ab8bc6625); it names the face and its
bound count. The test asserts that message; the time bound stays.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:41:57 -04:00
jyvikoandClaude Opus 5.5 6055ce6fd3 step_in tests: knot multiplicities refused per knot, then by their sum
The reader (crates/step, f06581ca5) keeps distinct knots and their multiplicities and
never expands them; a multiplicity above degree + 1 is invalid (ISO 10303-42) and is
refused on its own as 'bad knot multiplicity' before the sum is compared. The test's
1,000,000 knots of multiplicity 64 on a degree-1 curve hit that first. Both checks are
asserted: multiplicity 64 per knot, and 1,000,000 knots of multiplicity 2 by the sum.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:41:57 -04:00
jyvikoandClaude Opus 5.5 efdc245d1f step_in tests: a face the reader refuses leaves the rest of the solid as surfaces, named
unsupported_face_is_left_out_and_reported replaced a plane with an OFFSET_SURFACE on a
placement: the reader reads offset surfaces since d41ae8512, so the face was refused
for its basis (AXIS2_PLACEMENT_3D), not for being unsupported. It now uses
CURVE_BOUNDED_SURFACE, which the reader does not read. Since cfee4a720 and 4cb0d6ee9 a
solid with a face left out comes in as a surface body of the faces that read, warned
'imported as surfaces' and 'left out', with no 'open body' warning on top (as
a_refused_solid_comes_in_as_a_surface_body_of_the_faces_that_read asserts); the test
asserts that.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:41:57 -04:00
jyvikoandClaude Opus 5.5 6c355fdf72 step_in tests: the cube fixture's edge directions clear of the assembly fixtures' ids
8eb93ff06 gave every cube edge its own line through two vertices, with the lines'
directions and vectors at #600 to #623. two_instance_assembly writes its occurrences
at #600 to #614, so 10 ids were defined twice, the reader kept the cube's, and the file
had no assembly: one body where hand_written_assembly,
later_instances_show_the_first_instances_mesh_placed and
repeated_items_are_shared_and_one_use_items_are_not expect two. The directions move to
#340 to #363, which no fixture uses.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:41:57 -04:00
jyvikoandClaude Opus 5.5 8b4b4a9d6a SMLib pcurves: an end SMLib moves within the tolerance it held the edge at is mapped
An edge that lies off its face's surface has its tolerance raised to cover the
gap before SMLib makes its trims (cover_gaps). Where such an edge runs out of
its patch, SMLib ends it where its drop onto the patch ends when that is within
the edge's cross-section tolerance of its vertex (SmEdgeuse::CreateUVTrimCurve),
and moves the edge's interval there. The moved end was checked against the
edge's tolerance before it was raised (1e-5 mm), so two faces of Poppy
Humanoid's left thigh, whose edges SMLib ended 0.08-0.1 um short with a held
tolerance of 0.77 um, were refused ("SMLib moved an edge's interval"). The end
is now checked against the tolerance SMLib held the edge at.

Poppy Humanoid: thigh_left comes in as a closed solid (refused 4 -> 3).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:41:16 -04:00
jyvikoandClaude Opus 5.5 d2858cb3d9 STEP import: a circle edge between two vertices is the arc between them, however short
An edge on a circle or ellipse read as a full turn whenever its two vertices lay
within the file's uncertainty of each other. The engine assembly's water pump
housing has a 20.4 um arc between two vertices in a part whose uncertainty is
20.5 um: read as a turn, its cylinder face's loop wound once round the axis with
no second bound ("a face around an open surface of revolution with one bound")
and the housing came in as surfaces. A full turn is now an edge with one vertex,
or two at one point; two vertices apart bound the arc between them.

Engine assembly: HOUSING_MAIN_WATER_PUMP_01 comes in as a closed solid
(refused 5 -> 4). No other edge of the engine or Poppy Humanoid read this way.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:41:16 -04:00