A face's grid lines are thinned to MAX_FACE_GRID points (and now to at most that, where the
rounding of thin() could leave it a little over), but the cut grid adds the face's motorcycle
traces to them and then refused when its cells came out over the cap. The face fell through to
Delaunay, whose refinement budget a face of that size is far past: a split coil's wall at the
measuring tolerance got 90 000 triangles where it needs 320 000, and the halves of #793's coil
measured 1.5% short of the whole. The cut grid now thins its full lines (the same evenly spaced
choice as the face's grid, moved into grid.rs) until the cells fit.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
SMLib writes a modelled thread's groove walls as splines winding once per pitch, and splits the
bore or shaft into one face per turn, so no face of revolution has a loop turning more than once
and turns_more_than_once missed the body. Truck's mesher then took the winding walls: meshes
reaching 1.4 mm past the block (#1995, #2526, #3311, ladder 06/004), volumes of -1.8e7 and boxes
120 m wide (#2038 join, ladder 06/003), or spade's "!previous_region.is_empty()" assertion inside
its constrained triangulation (#3952, ladder 06/001, 06/002). A spline face now has an axis too:
the mean binormal of an iso-line that winds more than once about it, through the iso-line's
centre; a boundary loop turning more than once about that axis routes the body to the display
plan, as a helical trim on a cylinder already did.
Truck's own coils (sweep_helix's spline walls) go the same way; their walls are longer than a
grid's 1024 lines resolve at the measuring tolerance (three turns of a 20 mm coil need ~1200),
so a direction may now have 8192, the grid as a whole still capped at MAX_FACE_GRID.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A thread's root band that runs out through an end face (a strip a quarter pitch wide winding
ten turns, ending obliquely, so it has no four corners to blend) fell through to the butterfly
of a round face. Its cuts ran lengthwise through the strip, seeded the whole way: ~200 000
points whose triangles zigzagged along the band, six times its area and up to 1.6x the chord
tolerance off the surface. A curved face whose division across one parameter has no inner line
(straight and within a side there) and with no room for a lattice seed now skips the patch and
cut-grid layouts and goes straight to Delaunay of its boundary nodes with sag refinement:
11 600 triangles for the whole part instead of 438 000, within the tolerance, the triangles'
area matching the surface's. A fillet narrower than a side but curved across keeps its layouts
(Delaunay from its boundary alone runs out of refinement budget at fine tolerances).
cdt::has_room tells "no seed fits" apart from "the lattice is too large to look through".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Each loop of a face is projected on its own, so along a closed direction a
hole can come out a whole period away from the outer loop. A revolved
dome (rational spline closed in v, bounded by its rim, its seam both ways
and the pole) has its outer loop opened at the pole into v in [-1, 0],
while a hole cut by a ball next to the seam projected into [0, 1]: the
triangulation covered the hole as well, and the cut measured 48118.36 mm³
instead of SMLib's 46424.50 (tangency-labs/solidcore#433, kernel case
sweeps/3528-revolved-dome-cut-by-a-ball-on-its-seam). Every other loop is
now moved by whole periods to the copy nearest the outer loop.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
On a thread's root band (1.4 mm tall at a pitch of 1.5) a point on the band's lower rim lies
0.1 mm from the rim of the turn below. The search's starts are dense across the band and
sparse along it, so its four nearest starts all lay on the turn below, Gauss-Newton settled
there, and the pcurve fit refused the edge ("the curve at 0 lies 0.1008 mm off the surface",
ladder/06-threads/007). The search now goes on through the nearest 32 starts until one
converges within the accepted distance, and stops at the first that does.
The test strips now put their knots at other angles on each turn (7.3 control points a
turn), as SMLib's screw sweeps do.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
SMLib's intersection curves carry knots of full multiplicity where the curve is in fact
differentiable (its derivative the same either side). The pcurve fit took every such knot
for a corner and fitted the two sides apart; on a thread's flank, whose u runs hundreds of
times as fast as its v, the pieces met at up to 1.4 deg in (u, v), and SMLib's check refused
the record read back (Test #7 Bad CurveKink, offset 0.9997 against cos 1 deg).
A knot that leaves a spline only continuous by its multiplicity now gets a cubic with a
tangent there when the spline's one-sided derivatives (EvalCurve::sides) agree within 1e-9
of their size. Knots where the curve does turn are corners as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A thread cut by SMLib's screw sweep leaves flanks that are cubic splines of hundreds of knot
spans along the helix (an M6 through 20 mm: about twenty turns over u in [0, 1]). With no
hint (an edge's first sample), the projection started from a 17 x 17 grid over the parameter
box: one start every turn and a quarter, so the nearest starts lay on the turns beside the
point's own, Gauss-Newton settled there, and the pcurve fit gave up with "the curve at 0
lies 0.87 mm off the surface" (pitch x cos 30 deg, the next turn's flank). Every modelled
thread failed its export that way.
The search now starts, along each direction where the surface has its own knots (a
spline's, a revolution's profile's), from each knot span's start and two points inside it as
well as the 16 even steps, capped at 16384 points of the surface, so every turn is searched.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Without the native feature nothing reads a sweep's curve list, and clippy -D warnings
refused its two fields as dead code. The list is built through List::new in both builds;
only the native build keeps the slices the C API reads.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
SMLIB_REV moves from e1ac3c3 to capi-solidcraft 276b509: thread groove
booleans (#435, #410), a holed profile swept along a bent path (#411), a
revolution a turn past its range (#428), shell and offset faces (#402, #380,
#403), the check linear in the body (#431), a far box that leaked (#377),
fillets and chamfers where a neighbouring round collapses (#416, #417, #420,
#379), tangent faces round a non-manifold edge (#383) and split faces of an
exact NURBS surface (#387).
The last one is why the SMLib block-and-cylinder decode test no longer finds a
spline edge on part of its curve: SMLib keeps a split face's parameterization
now. The test keeps its volume check; the decode of such edges stays covered
by spline_edges_on_part_of_their_curve_load_as_that_piece.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
An SMLib result where one shell uses an edge four or more times (a hole tangent to the outline,
touching holes, stepped cuts touching along a line) was refused as "not supported yet: a solid
touching itself along an edge". The export now reads SMLib's radial order round each edge
(EDGEUSE_NEXT_RADIAL, EDGEUSE_RADIAL_ENTRY) and the side of each face its material is on, and
gives each pair of faces across one sector its own copy of the edge: the pairs across material,
so the surface is cut apart round each wedge of material, unless one face would get two copies
(a face on both sides of the line), which SMLib's check refuses as coincident edges (tests 33,
34); then the pairs across the empty sectors, so that face keeps one edge on both sides, as
SMLib's crack edges do. The vertices at the ends stay shared: copies would give a face passing
the point twice two coincident vertices, which SMLib refuses too (test 32). Geometry unchanged;
each copy keeps its edge's tolerance and history (Order.pieces). The radial arrays are checked
as hostile input (in range, cycles on their own edge).
Tests: a hole tangent to a block's outline exports with the line copied once per wedge (each
copy joining faces on one side of it), every edge two uses, and goes back into SMLib valid at
the same volume; a blind hole tangent to a side leaves the side a crack; through SMLib both come
back as one solid with verified history and empty validity.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
After a parameter edit, a feature's stored face point is moved onto the
face its name finds. That used the face's nearest point to the old pick,
which lies on the face's boundary whenever the pick no longer lies on the
face: a shell opened at the end of a bar picked (150,15,10), on the edge
it shares with the bottom face, so truck opened the wrong face and SMLib
refused the pick (#2531).
FaceHit::pick_point keeps the point where it still lies on the face clear
of its edges, and otherwise takes the face's nearest point among points at
least a margin inside its triangles (a few pick tolerances, capped at half
the roomiest triangle's inradius on narrow faces).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
With SOLIDCRAFT_KERNEL=smlib, kernel::draft hands the picked faces (a point inside each,
from the face under each pick) to Brep::draft, with SMLib's own history: the tilted faces are
the faces themselves (Modified). Faces SMLib can't draft (a round wall, a face not parallel to
the pull) are "not supported yet", never truck. Tested in modify_history_tests: a 40 x 30 x 20
block's side at 5 degrees removes 20 x 20 tan 5 deg / 2 x 30, with its history checked against
the geometry.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Flat faces tilted by an angle about the line where each meets a neutral plane, leaning in along
the pull, and the faces around them extended or trimmed to meet them
(tangency-labs/smlib@e1ac3c3, SMLib's local operation). A face that isn't flat or isn't parallel
to the pull is Error::Unsupported. The test drafts a cube side by +-5 degrees, removing or adding
the analytic wedge to 1e-6.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cargo xtask kernel-cases --kernel both, solidcraft-cli built with smlib
at c65fc91a (fork bf7c272), SMLib through SOLIDCRAFT_KERNEL=smlib. 372
cases: default 235 pass, smlib 269. SMLib's gains are booleans (50 to
66), fillets (32 to 41), shell (5 to 11) and STEP import (13 to 17, its
solids now SMLib bodies); its losses are sweeps (54 to 51 pass, 15 not
supported yet on SMLib) and threads (17 fail, of which the default kernel
hangs on 4).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face on a B-spline surface whose first and last control columns are the
same (closed around u), bounded by loops that go once around without a seam
edge, was refused ("a loop across a closed spline surface's seam"). It now
gets a seam as cylinders and cones do, along the surface's own boundary
column (u at the start of its knots, an exact iso-curve of the net), each
loop split where it crosses that column when it has no vertex on it; the
period is the knots' width. At a pole a loop may jump across u, where the
seam's two uses meet a period apart.
The step-conformance NURBS cylinder, dome and torus ring now read. With
SOLIDCRAFT_KERNEL=smlib all 17 parts import into SMLib with their exact
volumes and face counts. A spline closed in v only, or both ways, is still
refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A gap the boolean fixed on one side only left the freed edge in its common-edge map, and the next
pass read it: a square-wire coil cut into the wall of a bore crashed the process on SMLib
(sweeps/2552). It now fails with an error.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib leaves a corner patch where blends meet untagged, and blends() matches no single edge to
it, so it had no origin, and the edges between two blend faces (two chamfers' mitre) none
either. The history checks refused both (modify_history_tests' corner, whole-box and mitre
cases on SMLib). Now a patch without origin is made in place of all the edges of the blend
faces beside it, as truck records a corner, and every edge of a face new to the blend is where
its two faces meet.
modify_history_tests with SOLIDCRAFT_KERNEL=smlib: the three blend cases pass (28 of 30; the
painted shell and the painted box cut's pieces are the shell's and boolean's). Truck: 30 of 30.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With SOLIDCRAFT_KERNEL=smlib, chamfer_sides (two distances, or a distance and an angle) runs
SMLib's new unequal chamfer instead of being refused: `d1` back along the face facing up most
(down most with `flip`, as truck's chamfer_sides picks its first face), the other side by the
distance or angle, with the body's history as for the other blends. A radius law SMLib refuses
as having a corner is "not supported yet", never truck's round.
Tests (with the feature): 5 and 2 on a cube edge either way round (the top face keeps 15 or 18
of its 20, the chamfer face comes from the edge), 5 at 45 degrees, and the corner law refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brep::chamfer_sides reaches the fork's smlib_chamfer_sides: `distance` back along the face
whose outward normal leans most along a given direction, the other side by a second distance
(ChamferSecond::Distance) or at an angle to the first face (ChamferSecond::Angle). The fork's
smlib_fillet_variable refuses a radius law with a corner with SMLIB_ERR_UNSUPPORTED, which the
crate reads as Error::Unsupported ("not supported yet"): SMLib's section fit ran smoothly
across the corner and missed the law (4 -> 2 -> 4 on a 20 mm edge took 35.1 mm3 for 40.1;
tangency-labs/solidcore#430). Both are in the fork at the pinned bf7c272.
Tests (ops_tests.rs), against analytic values: 5 and 2 either way round (the centroid tells
which face took the 5), 5 at 30 degrees, rejected arguments; a quadratic law 4, 1, 4 and a law
down to zero (1e-5), the corner law refused and the same points joined C1 built.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With SOLIDCRAFT_KERNEL=smlib, kernel::measure and measure_mass take volume, area and centroid
from SMLib's Brep::mass_properties (integrated on the exact surfaces, accuracy 1e-8). The mesh
measure is still made, as an independent check. Where SMLib disagrees with it beyond the mesh's
own accuracy (1e-3; tangency-labs/solidcore#384), or can't take the body, the mesh measure
stands and the measurement says why. BodyMeasure and MassMeasure carry `measured_by` (smlib |
mesh) and `notes`, and inspect.measure shows both. The box and topology counts stay the mesh's.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib's tolerance update now fixes the vertex gaps its check reports (gaps over half a vertex's
tolerance), and every boolean, blend, shell, offset and sweep result grows its vertex and edge
tolerances over gaps below SMLib's own rounding bound before it is handed out. A thread's groove
cut from a shaft no longer fails SMLib's check on vertex gaps of about 1e-5 mm, and an offset
sphere face no longer fails it on an edge gap of 5.015e-6 against 5e-6 (shell/2939).
Also carries the fork's blend commits since ca2559f (second offset per edge, two-setback
chamfers, variable radius laws with a corner refused) and the IGES knot check.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Where two edge uses of a loop meet at a pole (meridians of a sphere), the periodic parameter's
jump there is free, and the pcurves took whichever jump made the loop counter-clockwise. Two
meridians a three-quarter turn apart bound a quarter of the sphere or three quarters of it, and
the loop alone can't tell which: a half disc revolved 270 degrees on SMLib came back as a quarter
ball turned inside out (sweeps/2667, V = -226 against 678.6).
pcurve::pcurves_within takes the face's parameter box, as SMLib gives it, and picks the jumps
whose extent in that parameter is nearest the box's; pcurves is unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each solid item of a STEP file goes through the schema 4 reader
(solidcraft_step::topology, at the file's units and uncertainty) into
SMLib through the flat converter, healed where SMLib's check refuses it,
and comes back as a kernel body; its faces keep the file faces they came
from. A solid the reader or SMLib refuses is not imported, with the
reason: there is no truck fallback on this path. truck's own reader is
unchanged and stays the default.
Test: the 17 step-conformance parts read into SMLib with their exact
volumes and face counts, every face traced to an ADVANCED_FACE; the three
NURBS parts stay refused by the reader (a loop across a closed spline
surface's seam), as on schema 4 today.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
smlib_record_ordered is smlib_body_ordered for a record of any origin (a
STEP file's, not only a body's): SMLib's body of it, healed where SMLib's
check refuses it as given, with where each of SMLib's faces and edges is in
the record's order. A record SMLib refuses outright now goes through the
healer too before the import gives up.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Schema 4 lets a circle or ellipse edge run up to one turn past its seam
(a quarter arc after the seam is [2π, 2.5π]); SMLib's circles take angles
within [-2π, 2π], and the flat import refused the whole body as invalid
input. The mapping now gives SMLib the same arc a whole turn back, and moves
the edge's pcurves on B-spline faces by the same amount, since their
parameter is the edge's. step-conformance's plate_100_holes now imports.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Solid::face_origin lists the ADVANCED_FACE or FACE_SURFACE entity of each
of the record's faces, in the record's face order, so a body made from the
record (in another kernel) can trace its faces to the file, as the truck
import's face_origin does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Imprint cuts each face of a body where a tool body meets it (the fork's
smlib_imprint, SMLib's imprinting boolean) and gives None where the tool
crosses no face. Trim builds on it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
169 rig and ladder cases on both kernels, graded against each case's own answer: where SMLib
fails, grouped by what goes wrong (wrong geometry, a crash, the thread groove's boolean failing
SMLib's check, shell refusals, sweeps with no SMLib path yet).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SolidCraft's own record of a body SMLib made (the rig's record check, the saved body, the next
SMLib import) re-fitted every pcurve at the kernel's working tolerance, 1e-5 mm. SMLib's fillet
and chamfer surfaces lie some 2e-5 to 2e-4 mm off their faces, so 15 fillet and chamfer cases
failed that check although SMLib's own passed. And SMLib reported one tolerance for a whole body,
the largest any part of it needed, so one loose edge (a pocket cut left one at 0.23 mm) made the
whole body loose on its way back into SMLib.
Now the tolerances go per edge and per vertex, both ways:
- solidcraft-smlib reads and writes the fork's new SMLIB_FLAT_EDGE_TOLERANCE and
VERTEX_TOLERANCE arrays. Export gives each edge and vertex record its own (never below the
floor, which becomes the body's). Where those understate what an approximated edge needs on
its face (SMLib holds a blend's end curve 2.3e-5 mm off its plane at 2e-5), the export falls
back to SMLib's largest everywhere, as before. Import writes each record edge's and vertex's
tolerance.
- `geom::brep::pcurve::EdgeUse` carries its edge record's tolerance, and a pcurve is fitted to
it where it is larger than the face's.
- The kernel's decoded body keeps its record's edge and vertex tolerances
(`Body::tolerances`, in its edge and vertex order) after an SMLib operation and a saved body's
decode, and keeps them through a rigid placement. Its record writes them again; anything that
builds a new solid drops them.
SMLIB_REV moves to the fork commit that adds the arrays (smlib-blends-abi2 4a67471, ABI 2).
Rig and ladder fillet and chamfer cases on SMLib: 43 pass before, 60 now, none lost. Tests: a
pcurve fitted to its use's own tolerance, and the ladder's 08/006 cylinder rim chamfer whose
record, saved body and placed copy all stay valid and SMLib's check takes back.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
A pick at the vertex where a cylinder's seam meets its rim lies on both edges. The body's
nearest-edge order took the seam on SMLib-made bodies, and SMLib refused to chamfer it
(the ladder's part chamfer, step 22, SM_ERR_INVALID_INPUT). A seam or a tangent join is never a
blend's edge, so a pick as near to one as to a sharp edge takes the sharp edge; anywhere else the
nearest edge stands.
Test: every pick round a cylinder's top rim, the seam's end among them, takes the rim.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
Every blend entry point asks `backend()` and, on SMLib, hands its arguments to blend_smlib.rs:
fillet, fillet_each and fillet_radii (a radius per edge), fillet_g2 (SMLib's G2 blend-curve
section between the round's contacts), fillet_chord (constant-width section), chamfer, and
fillet_variable_spline (the radius law as an SMLib B-spline law; fillet_variable and
fillet_variable_points reach it, and fillet_max, fillet_max_each and fillet_tapered run on these).
Options SMLib has no construction for are refused as "not supported yet", never built by truck:
G2 corner patches, and chamfers with two different setbacks (distance and distance, or distance
and angle; equal setbacks are the equal-distance chamfer).
Each pick takes the body's nearest edge in its own edge order, as truck's blends do, and SMLib is
given that edge's midpoint, so a pick at a vertex never leaves SMLib to choose between edges. The
body goes in tagged as operand 0, SMLib's check must pass, and the decoded result carries SMLib's
history in the body's orders, the blend faces given FaceOrigin::Edge of the edge each replaced
(the picked edges and the rest of their tangent chains). The truck path is unchanged.
Tests (with the feature): a round's volume and its face's origin, a size per edge for rounds and
chamfers, a linear law from either end, refused sizes and picks.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
The Rust side of the fork's smlib_blend and smlib_fillet_variable, which the kernel's fillets and
chamfers need on SMLib: `Brep::blend` takes a size per picked edge and a `Blend` (circular round,
curvature-continuous round between the round's contacts, constant-chord round, equal-distance
chamfer); `Brep::fillet_variable` rounds one edge with a clamped B-spline radius law from the end
nearest a start point. Selection errors map as for the other picking operations.
SMLIB_REV moves to the fork commit that adds them (smlib-blends, on capi-solidcraft ffcf56d).
Tests: per-edge rounds and chamfers and the chord round against analytic volumes, the linear law
from either end, and refused laws and picks.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
The fork's booleans now hand out closed non-manifold results (SMLIB_REV e87e9b3, ABI 3): solids
touching each other along an edge or at a vertex, which the C API refused as "not a closed
solid". The SMLib → schema 4 mapping now gives each closed boundary its own record shell: the
faces sharing one runtime shell on the empty side and one on the material side, so solids that
share their empty side's runtime shell get a shell each. An edge or vertex faces of more than
one shell use is split into one copy per shell (same curve, interval and point), so every
shell is a closed manifold boundary; regions list each shell as before. The history follows: an
Order's `pieces` give each record edge of a split SMLib edge with the faces it bounds, and each
piece keeps the edge's origins.
SMLib's own check refuses the radial order of faces round an edge solids share, so a
non-manifold result is checked as the separate solids it becomes (imported as given). A solid
touching itself along an edge (one shell using an edge more than twice) is still refused, now
as "not supported yet: a solid touching itself along an edge".
Tests: cubes sharing an edge or a vertex unite into two shells of 1000 mm³ each, every face and
edge's history verified against the geometry; two opposite quarters cut off a slab leave two
solids. Of the pinch tests run through SMLib, cut_leaving_pieces_meeting_along_a_line now
passes; the other nine are solids touching themselves.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
The kernel runs exact helical sweeps and never resizes; the check that
refuses a thread off its hole's or shaft's size is the engine's sugar
(AGENTS.md). So the seven cases (995, 1443, 2152, 2969, 3366, 2369,
2705) go back to expecting that refusal and its message, as 1375e905 had
them, reversing 1588dd70.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On SOLIDCRAFT_KERNEL=smlib the thread's groove (the ISO 68-1 trapezoid, as before) is a B-rep
screw sweep (kernel::sweep_helix, SMLib's screw sweep) cut from the body by the B-rep boolean,
whose history carries the threaded face's names on. Truck keeps the faceted groove and the
faceted boolean. thread_groove_shape holds what both build from; the size checks before it
(a hole or shaft off the thread's size is refused with the size to use) are unchanged, so
neither kernel fits a thread to a face that is too large or too small.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
With SOLIDCRAFT_KERNEL=smlib, extrude (and extrude_whole_sides, so boxes and cylinders too),
revolve and revolve_whole, extrude_tapered(_between), sweep and sweep_with, loft,
loft_with_rails, loft_regions and sweep_helix (coils, and the threads' grooves) build their
bodies with the fork's sweeps (smlib_sweeps.rs): the profile's segments go to SMLib as curves
(lines, arcs, Béziers and conics as NURBS), the result comes back through its schema 4 record,
and one SMLib's own check refuses is an error. What SMLib has no sweep for answers "not
supported yet", never truck's sweep: twists, end scales, guide rails and orientation
directions; paths with corners and paths of points; lofts with holes or to a point; draft
extrusions of profiles with holes or with a straight foot.
History is in the builders' vocabulary, found from the result's geometry as provenance.rs does
for operations without exact history: a wall comes from the segments its start edge runs along
(and, for extrusions and revolutions, whose middles it holds half-way), the face in the start
plane where the profile bounds it is the start cap, the one at the end the end cap. Straight
extrusions also carry their faces' construction sources (ExtrudeCap, ExtrudeSide), which the
box and cylinder certificates need. The loft's section matching is truck's own, now
loft_numbered_loops (split out of loft_numbered_wires, unchanged), so both kernels pair the
same vertices.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
Brep::extrude (straight or drafted), Brep::revolve, Brep::sweep (turning with the path or only
moving along it), Brep::loft and Brep::screw_sweep wrap the fork's new smlib_sweeps.cpp shims.
Profiles, paths and sections are lists of sweeps::Curve (lines, circular arcs, NURBS), turned
into the C API's curve lists here; the FFI is ffi/sweeps.rs. SMLIB_REV moves to the fork head
that has the shims (c33df0f, on capi-solidcraft 1499681).
Tests check each sweep against closed-form volumes and SMLib's check, and hostile curve lists.
(The crate's test build currently stops at import/tests.rs, which calls import::surface without
its new analytic_planes argument; that is the import's, not this change's.)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
The SMLib shell passed the user's pick points to SMLib, which refuses a point as near to two
faces; a pick on a hole's wall at the line between its two halves (kernel-cases shell/4010)
failed. The open faces are now picked as truck's shell picks them (the face of the nearest
triangle), grown by the faces on the same surface joined to them (offset::with_same_surface:
a round wall stored in pieces opens whole), and SMLib gets one point inside each.
Offset faces keeps its design on both kernels: when moving the faces fails on a body with
split lines, the chosen pieces are pressed (swept and joined or cut) instead, as truck's path
always did; the booleans of the press run on the selected kernel.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
smlib_body_ordered keeps SMLib's face and edge order for history only where SMLib's export
numbers the body as its record does, and compared each loop edge for edge in the same order
and direction. SMLib walks a face whose surface it turned (a hole's wall, a concave cylinder)
the other way round and may start the loop elsewhere, so a plate with a hole lost its history
through every SMLib boolean and shell although its faces and edges are numbered alike. A loop
now matches when it walks the same edges in the same cyclic order, or in the opposite order
with every edge reversed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
With SOLIDCRAFT_KERNEL=smlib (the one kernel switch), shell, offset_faces and thicken send
the body to SMLib tagged as operand 0 (offset_backend.rs) and bring the result back with
SMLib's own history, as booleans do. A result SMLib's check refuses is an error.
SMLib's tags travel through the copies its offset makes, so a shell's inner wall and a
thickened sheet's moved copy read as pieces (Split) of the face they came from. A result face
lying more than half the operation's distance from its tagged face is recorded as that face's
offset (FaceOrigin::Offset) and its edges as where its faces meet; a thickened sheet's walls,
new to SMLib, are recorded as made in place of the sheet edge their edges are tagged with, as
truck's thicken records them. Offset faces pick the faces truck's path picks (a round wall's
pieces together) and pass SMLib one point inside each; the moved faces are Modified.
The histories are checked against the geometry as truck's are (modify_history_tests), with
the analytic volumes, the thicken direction, and the refusal of walls past the L-shaped body's
inradius (8.79) that its box (half extent 10) let through before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
Brep::offset_faces and Brep::thicken reach the fork's new smlib_offset_faces and
smlib_thicken; SMLIB_REV moves to the fork commit that adds them. The shim now refuses an
inward wall that leaves no room inside the body with its own status, Error::NoRoom, instead of
an argument error, so callers can say what is wrong; the test that a wall thicker than the box
fails now expects exactly that.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
The analytic mapping refused every revolution that is none of SMLib's plane, cylinder, cone,
sphere or torus (a profile of any other curve, a placement that is no rigid motion), which
now also kept those faces from kernel-smlib's exact rational B-spline import (da7ccba9). Such a
face now stays a revolution, so the import sends it as its B-spline; the analytic surfaces are
still taken wherever they fit.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
All operations move to SMLib at once, so the selector is no longer the booleans' own:
`SOLIDCRAFT_KERNEL=smlib|truck` (read once, unset is truck, the same refusals for an unknown
value or SMLib in a build without it) is answered by `solidcraft_kernel::backend()`
(crates/kernel/src/backend.rs), which every operation's dispatch calls. The boolean's SMLib path
moves to smlib_boolean.rs. The regression rig's kernel check (`boolean_kernel`) now answers from
the switch, and the rig and CLI set SOLIDCRAFT_KERNEL.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
The record of a truck body is built to the body's working tolerance (1e-6 of its size, at
least 1e-5 mm), and truck's offsets and blends leave some edges a few times farther than that
from a face they bound: no pcurve fits, so the record and every SMLib boolean on the body
failed ("pcurve of loop 0 use 0 ...: the curve at 0 lies 3.2e-5 mm off the surface" in a
shelled revolve of the robustness generator). The record for SMLib now retries at ten and a
hundred times the working tolerance for the body, its edges and vertices before refusing; the
saved native body keeps the working tolerance. Robustness seed 64 (a filleted extrusion
joined to a cylinder), refused this way before, now builds as truck does to 1.6e-6 of its
volume.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
An SMLib cylinder, cone, sphere or torus decoded as a truck revolution with its parameters
swapped (angle, profile), which truck's own revolutions never have. The tessellator then put a
cone's apex at the wrong angle: a drill point through SMLib and back meshed 41 % too large and
oracle cases 18, 55 and 56 measured wrong areas and volumes. The profile now runs against the
record's v, unswapped, which keeps the record's natural normal and truck's (profile, angle).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
Truck's bodies are trusted into SMLib as given, but some miss SMLib's rules by a little (an
edge's vertex 4.4e-5 mm off it against a tolerance of 3.3e-5 after a truck operation), and
every boolean on them was refused by the check of its result. An operand whose trusted import
fails SMLib's check is imported again through SMLib's healer, and the healed body is used only
where SMLib then finds it valid; its numbering is checked against the record as before, so a
heal that renumbers leaves the result without history rather than with a wrong one.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
A revolve's flat ends (a line square to the axis turned about it) were refused, so any
revolved profile off the axis could not reach SMLib (oracle case 29). Such a face now goes as
SMLib's plane square to the axis, its range the box round the sector the line sweeps.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
kernel-smlib already gives solidcraft-engine and solidcraft-cli an `smlib` feature (for the
regression rig); the note on SOLIDCRAFT_BOOLEANS now says they are how the oracle, the naming
corpus and the robustness goldens run their booleans through SMLib.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT