Commit Graph
754 Commits
Author SHA1 Message Date
jyvikoandClaude Opus 5.5 f8c2fba077 STEP import: FILE_DESCRIPTION and the preprocessor name a Y-up exporter again
#5191 read the header's preprocessor version and FILE_DESCRIPTION, so a SolidWorks file named
only there was stood up. The reader had moved to crates/step (p21.rs) before #5191 merged,
and the merge kept only the originating system: a file naming SolidWorks in its description
got no exporter_up (step_replies_name_a_y_up_exporter). The parser reads both fields again,
StepImport carries them, and exporter_up looks at all three.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:05:37 -04:00
jyvikoandClaude Opus 5.5 ea65005597 geom: patches about a fill's centre are solved by blocks, their banded interiors eliminated onto what they share
The normal equations of patches about a centre were solved dense, so at most
500 free control points: the torus window, 1433 once its patches ran in their
own spaces, was refused. Each patch's interior (coordinates of points only it
holds, coupled by no row to another patch's) is a banded block now; the blocks
are eliminated exactly onto the unknowns the patches share (the spokes, the
centre, and the points rows across a spoke couple), whose Schur complement is
solved dense, and the interiors follow by back substitution. A solve takes up
to 6000 free points, as one patch does, and refuses past 4000 shared unknowns
(a 128 MB dense block) with that reason. The torus window and the pentagon now
solve (they fold, open).

The fill tests' own-edge check compares an edge's NURBS form to rounding, as
fill.rs's does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:05:17 -04:00
jyvikoandClaude Opus 5.5 c5b0385481 Fill: its tolerances follow a size that does not depend on where the body is
face_tolerance (and planarity_tolerance) was 10⁻⁶ of the body's bounding-box
diagonal, which changes as a body turns: the cup turned 0.7 rad about
(1, 2, 3) grew from 54.7 to 61.6, its fill sampled to another tolerance, a
different surface (area 974.543 against 974.527). The size is now the
diameter of the smallest ball holding the vertices (solidcraft_geom::Ball,
Welzl's algorithm, expected O(n)), the same wherever the body is and however
it is turned. Twice the farthest vertex's distance from the vertices'
centroid is that too, but up to twice the body's diameter where the
vertices crowd one end: a rounded box's set-back-13 G2 corner patch then
ran 2.0e-3 past the box (corner_g2
a_long_setback_keeps_the_g2_patch_inside_the_box, limit 1e-3).

The own-edge check of the fill tests compares an edge's NURBS form to
rounding (10⁻¹² of each coordinate): SMLib makes a conic's form again on a
round trip, the last bit of a coordinate apart.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:05:17 -04:00
jyvikoandClaude Opus 5.5 4faee7dd80 Fill: the general fill takes a loop of one or two edges in exact pieces of their curves
The iso fill needs three sides or more, so a loop of one closed edge (a tube's
end) or two was refused as "a loop of 1 edges". Such a loop's edges are now
taken in equal pieces of their own parameters (one edge in four, two in two;
a break that falls on one of the curve's knots, a conic's quarter points, is
that knot exactly), each piece the edge's own curve segmented exactly; the
patch's edges are those pieces, their ends new vertices shared by the pieces
either side. A piece of an edge the loop runs against has its parameter
reflected about the edge's interval, as a whole edge's is.

The tube end is still refused: one four-sided patch on four quarters of a
circle has corners where its sides run on straight (180°), and the G1 dome
folds there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:05:17 -04:00
jyvikoandClaude Opus 5.5 1e7713d1ec Fill: a patch's edges and vertices hold its fit's gap in SMLib's tolerance model
A record's tolerance is SMLib's intersection tolerance: SMLib holds an edge's
gap to its faces to half of it (the zone tolerance) and a vertex's gaps to a
quarter (SM_XSECT_TO_ZONETOL3D, SmBrep::ValidateAndUpdateTolerances). The fill
gave its edges and vertices the face tolerance itself, the gap its surface is
certified to, so SMLib's check refused every fitted patch (an edge/surface gap
of 2.6e-5 against 1.85e-5 where the fit holds 3.7e-5), alone or stitched to
its body. Its edges now take twice the gap and its vertices four times.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:05:17 -04:00
jyvikoandClaude Opus 5.5 b389601b06 Ruled surface: a strip on a cone is SMLib's revolve of its ruling, a cone face
A ruled strip off an arc whose rulings keep their angle to the arc's axis
(normal or tapered mode on a 30 degree lean) is a piece of a cone, but was
built as the rational B-spline between the arc and its image, which SMLib
labels with no analytic type (its CopyAndAddAnalytics only sees the plane
strips). Such a strip is now the start ruling turned about the arc's axis
through the arc's angle by SMLib's revolve, as the round corners already are:
a cone face, the same surface. a_circle_in_every_mode passes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:05:17 -04:00
jyvikoandClaude Opus 5.5 ebb1d843ab Sweep: a parallel sweep whose path runs along the profile's plane is refused again
Kept parallel (the profile as drawn), a profile flattens to nothing where the
path turns to run along its plane. The check that refuses it (the path must
cross the plane by 5° or more all the way) lived in the stations of a
controlled sweep only; a plain parallel sweep went to SMLib unchecked and
built a degenerate solid. Both take the same check now, the plain sweep on
each segment's direction of travel at 33 points along it.

A circle profile is one closed arc, one edge in SMLib: a wall per path line,
not two.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:05:17 -04:00
jyvikoandClaude Opus 5.5 b540faaf5c Thicken: a surface turned to its back grows the other way again
Going into SMLib a sheet's shell holds both sides of each face, so the side the
record keeps as the sheet's front is lost, and SMLib thickens along the
surfaces' natural normals: Reverse Normal did not change which way a thicken
grew. A sheet used against its natural normals everywhere is thickened by the
negated thickness.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:05:17 -04:00
jyvikoandClaude Opus 5.5 b68f71a2de Fill: a patch's edges are the body's own edges again, circles and ellipses included
A record edge on a circle or ellipse carries the NURBS form SMLib holds it as,
its interval on that form. The patch built its loop edges from the form alone
(sew::PartEdge had no place for it), so a fill's rim came back from SMLib as a
plain B-spline rather than the body's ellipse. PartEdge now carries the form;
assemble keeps a given form and labels the edge with what it is.

Test helpers that sampled an edge on `curve` with the form's interval picked
points off the edge ("no edge at …"); they sample `parameters()`. The fill's
own-edge check compares the curve's kind and the exact form it is parameterised
on: SMLib renormalises a conic's frame axes in the last bit on a round trip.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:05:17 -04:00
jyvikoandClaude Opus 5.5 8515dc1a34 Blend tests: a vertical round run on up a top round's end arc (ladder 07-fillets/018) is SMLib's to end, and builds
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:04:57 -04:00
jyvikoandClaude Opus 5.5 94d763c839 Tests: a round run on through an earlier one by tangent propagation is matched by the same edges together
The arc part's front edge rounded r2, then its left top edge with tangent
propagation (the Fillet feature's default): that edge runs on round the first
round's end arc and down the left front upright, so three edges end up rounded
(a sphere octant at the corner where they meet), not two. Both results were
exact: 9530.77 (meshed) is the part less three r2 strips and the octant,
9591.44 − (0.858407·(39.1667 + 19 + 8) + 8(1 − π/6)) = 9530.83; 9538.79 is
two strips less their overlap, 9591.44 − (0.858407·62.1667 − 0.7670) =
9538.84. The test compares the sequential rounds with the same edges of the
part rounded together: the picks' chains and every edge of the part the second
chain carried on into.

The other pairs still fail in SMLib (1001, or SM_ERR_INVALID_INPUT at the
knife-edge tip) where a later round ends on the first round's arc.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 07:14:45 -04:00
jyvikoandClaude Opus 5.5 0ec97c5708 Blends: tangent propagation off blends the picked edges alone; a refusal says how to change it
The Fillet and Chamfer features already blend each picked edge's tangent chain
by default (tangent_chain, true unless saved false), as mainstream CAD's
tangent propagation does; the kernel blends exactly the edges it is given.
#8678 refused, before SMLib, every edge that runs on tangentially into one left
out, which also refused blends SMLib builds (a round ending on the round its
edge runs into: blend_corner's a_round_next_to_a_round_of_another_radius, the
same feature with propagation off). Now:
- propagation off: only the picked edges are blended; where SMLib cannot end
  the blend at such a continuation, its refusal names the edge it runs into
  and that propagation (tangent_chain: true) blends the chain as one;
- propagation on, where the chain cannot be built (an r3 round carried on
  round an r2 round's end arc), the refusal says the chain was blended and
  that with propagation off only the picked edges are.
A smooth edge is still refused before SMLib. No default changes: the feature's
default was propagation on already.

The kernel tests that stand for a Fillet feature (curvecorner's sequential
rounds, issue 2422) take each pick's tangent chain, as the feature does by
default.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 07:14:45 -04:00
jyvikoandClaude Opus 5.5 229739a704 Blends: a smooth edge and an unfinished tangent chain are refused saying why; SMLib's unsupported corner is named
A smooth edge (its faces meet tangentially) has nothing to round, and an edge
that runs on tangentially into one left out has no end SMLib can blend (it
rounds a tangent chain as one sequence and failed building the face there,
status 1001): both are refused before SMLib with that reason. SMLib's new
SMLIB_ERR_CORNER_UNSUPPORTED (a vertex no blend corner handles) is
Error::CornerUnsupported and says so instead of a bare status.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 00:30:07 -04:00
jyvikoandClaude Opus 5.5 7d00ad78c4 kernel: a patch builds G0 to G4, and Continuity Analysis reads each seam's middle at the order asked
The patch fill meets its neighbours to G4, so Construction::Patch now offers g0 to g4: the
surface.patch command takes g3 and g4 and the Patch dialog's continuity row offers
"Curvature change" and "Smooth curvature change" by itself, from the one table.

The three-round corner test patches G2, G3 and G4 and reads the seams with the Continuity
Analysis too: the middle of each seam (30-70 %) at the order asked; the whole seam G1, since at
the corners the rounds' curvatures differ and no patch can meet both.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-29 00:30:03 -04:00
jyvikoandClaude Opus 5.5 0631d2d3a4 kernel: a three-round corner patched G2 and G3, read off the faces at each seam
The corner blend of a box's R8 vertical round and R4 top rounds taken off and patched: both
patches meet the tangent planes and the curvature in the middle of each seam; the G3 patch
also meets the curvature's rate of change (4e-6 to 4e-5 /mm^2), which the G2 patch leaves at
0.27 to 0.63. G3 to an edge between two faces is refused; G3 is no longer refused as such.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 00:30:03 -04:00
jyvikoandClaude Opus 5.5 ed830a168d geom: the patch fill takes the dense spline edges a blend leaves, and holds what its corners allow
- One patch has a space along u and one along v, each holding its two sides that run that way;
  a side's knot keeps its continuity when raised (multiplicity m + q - p), and each side is
  carried in exactly by interpolation at the space's Greville abscissae.
- Refinement halves the spans only in the direction whose sides miss, and one patch's normal
  equations are banded (the shorter direction numbered fastest), so a loop with a long
  intersection curve refines where it needs to.
- At a corner whose neighbours agree to a lower order than asked (their tangent planes, their
  twist between the two edges, or their forms), the stations near it ask no more than that.
- A station is held to the angle tolerance beyond the edge's own lean out of its neighbour's
  tangent plane: a fill that holds the edge cannot come nearer.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 00:30:03 -04:00
jyvikoandClaude Opus 5.5 99297495b3 geom, kernel: the patch fill meets its neighbours with G0 to G4, on rational edges too
One order-n implementation in the linkage-curve formulation (Pegna & Wolter 1992;
Hermann, Lukacs & Wolter 1999): geom::linkage reads the neighbour as a height over its
tangent plane to order n (its jet, from the surface's exact partials of any order) and
gives each order's condition on the linkage curve, with exact gradients (dual numbers),
so fill_iso solves orders 2..n by Newton's method. Each order's row is weighed by h^(k-1)
and its jump is held, carried into the fill by Taylor's theorem, within the angle tolerance.

The iso fill takes rational edges (a circle's arc on its NURBS form): homogeneous rows,
each edge scaled so the corner weights agree, the inside weights the Coons blend and
fixed, so the fill stays a linear least-squares problem. Its degree is at least n + 1,
refinement adds simple knots, breaks of different sides within rounding are one, and the
weak Hermite rows act in the tangent plane at the Coons start's own speed, so they no
longer pull against the G1 rows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
2026-10-29 00:30:03 -04:00
jyvikoandClaude Opus 5.5 7c8132e2d6 Repair Part (body.repair, #8371): rebuild refused faces, sew gaps, patch holes
A new undoable feature (`repair`, one pending format file) and command with input and
output schemas. In order:

- A cylinder, cone, sphere or torus face SMLib refuses on its own is rebuilt on a NURBS
  form of its surface laid on arcs from where the face starts
  (`form::surface_on_own_arcs`), with SMLib's own trims: the import's quarter-grid form of
  a face round most of a turn closes on itself, which SmTorus::IsNurbSurfaceTorus does not
  recognise. Geometry unchanged.
- Free edges that pair up within `gap` are sewn by SMLib's stitch; GlueEdgesGeneral gives
  each glued edge its own tolerance (at least twice its gap), the body's and the other
  edges' stay. The result is checked against the input's own SMLib check, the
  tolerance-bound tests (#5, #6, #59, #82) exempt.
- Loops of free edges left are holes: offered as surface.patch, and with patch_holes made
  (flat only when the loop is planar and every face around it is a plane, else G1) and
  sewn in.

The reply reports what changed face by face; nothing to do is refused with why.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 00:29:59 -04:00
jyvikoandClaude Opus 5.5 f11c0c5712 Bodies: an operation's result is its record, not the SMLib body it was exported from
A body made by an SMLib operation kept that SMLib body beside its record (SMLib's
export). The export is not exact to the bit, so the kept body measured and operated a
little differently from the record's import, which is what a body read back from a
file has: a box measured 24000.000000000004 mm³ live and 24000.0 reopened, a drilled
box 21989.38056 against 21989.38013. A cut ring's volume therefore changed when it
was moved, the moved ring being measured on the SMLib body the move made
(measure_centre_tests::combine_cut_volume_does_not_depend_on_placement). Every body
now imports its record when an operation first needs it, so evaluated and reopened
bodies are the same.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:12:37 -04:00
jyvikoandClaude Opus 5.5 00faac9659 kernel: a planar sheet's loop splits where it passes one vertex twice
Reading a planar sheet back from SMLib split each loop where two of its
segments started within ten times the record's tolerance (2e-5 mm), so
the two ends of an edge shorter than 2e-4 mm counted as one point and the
edge came out as a loop of its own, which the next planar boolean refused
("needs closed loops"). A loop passes a point twice where it passes one of
the record's vertices twice; the split now reads the vertices, not their
places. The sheet built from our own regions still splits by place, at ten
times the caller's tolerance.

Fixes sheet::tests::a_ledge_beside_an_edge_as_tall_as_the_setback_goes_with_the_strip
(the ledge 1e-4 above the bend line); new kernel test
a_ledge_shorter_than_the_record_tolerance_reads_back_as_one_region.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:12:07 -04:00
jyvikoandClaude Opus 5.5 b9d4ad74f4 kernel: a planar region inside another's hole keeps its material
The SMLib planar sheet united every region's material and then cut every
region's holes from it, so a region lying in another's hole (the island
inside a ring cut) was cut away with that hole. Each region is now its own
material less its own holes, and the sheet is the regions united.

Fixes sheet::tests::ring_cut_retains_exact_central_material_island (the
flat solid lost the island's π·25·2.5 mm³) and the kernel's
compound_planar_extrusion_normalizes_overlap_and_retains_islands.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:12:07 -04:00
jyvikoandClaude Opus 5.5 ccff7224c3 Shell: its planar walls carry their shell roles again
The SMLib port of shell dropped with_shell_planar_sources (then deleted it as dead
code), so a shelled body's kept walls and their inner linings had no ShellPlanar
certificate: a sketch or press-pull on a shell's floor lost its attachment (the Pi
case's Sketch2 and everything after it, press_pull_on_the_pi_case_floor) and the
shell certificate tests found no inner/outer face. The roles come from the input's
exact planar supports, so they apply to SMLib's result unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:11:55 -04:00
jyvikoandClaude Opus 5.5 c37b0d2f02 Kernel rig: a case's expected continuity order at its blend seams
expected.json may give `continuity: {order: g0…g4, edges?: "blend" | "corner"}`: the
seams of each round, chamfer face or corner patch with the faces either side of the edge it
replaced, and of each corner patch with its rounds, are measured as Continuity Analysis
measures them (seam_diagnostics at its default 33 stations and default tolerances), and the
case fails naming the worst seam, its faces, the order it reaches and the next order's worst
value. The seams come from the faces' persistent names (doc::naming::blend_seams). The older
`{near, within_mm, …}` form is kept.

Every fillet-area case with a body gets its order: constant rounds and rolling corners g1,
curvature rounds g2, chamfers g0, the corner: g2 patch g2 at its seams.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 21:22:17 -04:00
jyvikoandClaude Opus 5.5 c070f044ab STEP import: a torus face round most of its tube is formed within one turn of it
A torus face covering most of its tube off the tube's quarter lines (an
exhaust collector's bend: 326° of the tube from −113.8°) needed a fifth
quarter along the tube, which STEP counts from the outer equator: its form
ran past a full turn of the tube and SMLib refused the solid. #8496 turns
frames about the axis only, and the torus label had no tube reference.

The torus label gets a tube start (`tube_start`, radians; 0 and left out
of the record by default, so older records mean what they did): v counts
from there, in every evaluator, form, pcurve, iso curve, tessellation,
placement, SSI and SMLib transfer. A spilling torus face's tube start moves
to where its tube begins, or a turn before where it ends, whichever puts
its tube circles on the grid of a round face they are about the axis of
(a pipe's cylinder meeting the bend); circles round the tube are labelled
from the tube start (brep::form::on_tube), so their forms and pcurves lie
on the face's quarter grid exactly. The saved-format change is one file,
crates/doc/src/format/pending/torus-tube-start.rs.

Engine assembly: COLLECTOR_EXHAUST_VER_1 now comes in as a closed solid
(refused 3 -> 2); Poppy Humanoid unchanged (4).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 21:22:11 -04:00
jyvikoandClaude Opus 5.5 fc3a13f176 step_in tests: the import's repair notes for added seams and turned faces
The schema 4 reader adds a seam to a face that winds around its surface without one
(3d7e465b1) and turns over a face whose loop disagrees with its same_sense, and notes
both (the spindle torus tests assert the seam note). The tests written against truck
expected no warnings:
- step_conformance_parts_read_back_their_exact_shape: each part's seam count (the cone,
  dome, cylinder parts bounded by their rims alone); volumes, boxes, faces unchanged.
- extruded_ellipse_patch_crossing_profile_seam_stays_trimmed: same_sense .F. adds the
  turned-over note.
- implicit_bound_can_still_describe_the_complement_of_a_patch becomes
  implicit_bound_against_its_face_sense_turns_the_face_over: the strip's one bound on a
  cylinder cannot be a hole (the cylinder is unbounded along its axis, so the face would
  have no outer boundary); the loop bounds the face, turned over, the 42 mm2 strip.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:41:57 -04:00
jyvikoandClaude Opus 5.5 ae393fd9ce step_in tests: a face with too many bounds is refused by the reader's own limit
The face-bounds limit lives in crates/step's topology (MAX_BOUNDS, 54b10b9a3) since the
truck reader that said 'boundary loops' went (ab8bc6625); it names the face and its
bound count. The test asserts that message; the time bound stays.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:41:57 -04:00
jyvikoandClaude Opus 5.5 6055ce6fd3 step_in tests: knot multiplicities refused per knot, then by their sum
The reader (crates/step, f06581ca5) keeps distinct knots and their multiplicities and
never expands them; a multiplicity above degree + 1 is invalid (ISO 10303-42) and is
refused on its own as 'bad knot multiplicity' before the sum is compared. The test's
1,000,000 knots of multiplicity 64 on a degree-1 curve hit that first. Both checks are
asserted: multiplicity 64 per knot, and 1,000,000 knots of multiplicity 2 by the sum.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:41:57 -04:00
jyvikoandClaude Opus 5.5 efdc245d1f step_in tests: a face the reader refuses leaves the rest of the solid as surfaces, named
unsupported_face_is_left_out_and_reported replaced a plane with an OFFSET_SURFACE on a
placement: the reader reads offset surfaces since d41ae8512, so the face was refused
for its basis (AXIS2_PLACEMENT_3D), not for being unsupported. It now uses
CURVE_BOUNDED_SURFACE, which the reader does not read. Since cfee4a720 and 4cb0d6ee9 a
solid with a face left out comes in as a surface body of the faces that read, warned
'imported as surfaces' and 'left out', with no 'open body' warning on top (as
a_refused_solid_comes_in_as_a_surface_body_of_the_faces_that_read asserts); the test
asserts that.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:41:57 -04:00
jyvikoandClaude Opus 5.5 6c355fdf72 step_in tests: the cube fixture's edge directions clear of the assembly fixtures' ids
8eb93ff06 gave every cube edge its own line through two vertices, with the lines'
directions and vectors at #600 to #623. two_instance_assembly writes its occurrences
at #600 to #614, so 10 ids were defined twice, the reader kept the cube's, and the file
had no assembly: one body where hand_written_assembly,
later_instances_show_the_first_instances_mesh_placed and
repeated_items_are_shared_and_one_use_items_are_not expect two. The directions move to
#340 to #363, which no fixture uses.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:41:57 -04:00
jyvikoandClaude Opus 5.5 d2858cb3d9 STEP import: a circle edge between two vertices is the arc between them, however short
An edge on a circle or ellipse read as a full turn whenever its two vertices lay
within the file's uncertainty of each other. The engine assembly's water pump
housing has a 20.4 um arc between two vertices in a part whose uncertainty is
20.5 um: read as a turn, its cylinder face's loop wound once round the axis with
no second bound ("a face around an open surface of revolution with one bound")
and the housing came in as surfaces. A full turn is now an edge with one vertex,
or two at one point; two vertices apart bound the arc between them.

Engine assembly: HOUSING_MAIN_WATER_PUMP_01 comes in as a closed solid
(refused 5 -> 4). No other edge of the engine or Poppy Humanoid read this way.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:41:16 -04:00
jyvikoandClaude Opus 5.5 ee4d4b5a55 STEP import: a round face off its frame's quarter lines is formed within one turn
A cylinder, cone, sphere or torus face of less than one turn that does not
start on a quarter line of its frame, with more than three quarters left to
it, spilled into a fifth quarter of the quarter grid: its NURBS form ran past
one turn and SMLib refused the solid ("an edge lies 12-16 mm off the face's
surface"), which came in as surfaces.

Before its edges are labelled on it, such a face's frame is turned about its
own axis (brep::form::turned: the same surface, its angle parameter measured
from further on) so it starts on a quarter line and its form spans four
quarters. Round faces a circle edge about both their axes joins share one
quarter grid, so they turn together by one angle, chosen so every one of them
fits in four quarters; a group with a face that cannot be turned keeps the
file's frames. Each face's box on its label is measured once and reused.

Engine assembly: PULLEY_WATER_PUMP and MOUNT_SCAVENGE_PUMP_01 now come in as
solids (refused 5 -> 3); Poppy Humanoid unchanged (4).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-28 16:40:54 -04:00
jyvikoandClaude Opus 5.5 2dd505d836 kernel tests: rustfmt
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-28 16:13:50 -04:00
jyvikoandClaude Opus 5.5 d0081b235e kernel: a placed copy is planned as its original, moved, as its mesh already is
A body showing another's display (a later instance of a part an assembly
places several times) took that part's mesh, placed, but was planned for
the GPU viewport on its own: Poppy Humanoid's display planned all 247
bodies where its meshes came from 94 parts. Body::mesh_plan now plans the
original once (kept with the shared display, as its meshes are) and moves
the plan, so the copy's display is the part's triangulation, as its mesh
is. Body::unmeshed_faces needs no case of its own for a copy any more.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 16:13:50 -04:00
jyvikoandClaude Opus 5.5 c1713994f9 Body::unmeshed_faces counts on the coarse plan, without making the mesh
The STEP import's mesh check made a coarse mesh of every part (planned,
evaluated, its seams and smooth edges flagged) only to see which faces had
triangles, and threw it away. A face has triangles in the evaluated mesh
exactly where its plan has a triangle on its own nodes, so the count is now
read off the plan (TessPlan::faces_with_triangles, the condition evaluate
keeps a triangle by).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 16:13:50 -04:00
jyvikoandClaude Opus 5.5 25642b6d26 STEP import: a part's later instances in a window wait for its first, not end the window
A window of planned solids ended at the second instance of a part not yet
read, so an assembly that places a part several times in a row converted
in windows of one or two solids, each waiting for its slowest read before
the next began (Poppy Humanoid: 14 windows of 1 to 30 reads on 8 workers).
The window now always takes MAX_WINDOW solids; an instance of a part an
earlier job of the window reads is placed after that job, from the
orientation it found, as the next window would have placed it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 16:13:50 -04:00
jyvikoandClaude Opus 5.5 1880117368 A part the modelling kernel refuses is named, with what is wrong and what to do
SMLib's import says only that it refuses a body, so the kernel now keeps a structured
refusal with the body's SMLib cache (Body::smlib_refusal / smlib_refused: the first face SMLib
refuses on its own, found by sending each face alone, and its surface kind). A STEP import sends
each part's first instance as an operation would, notes the parts that need repair in the
import report, and the browser marks them ("VALVE_COVER_01: needs repair").

A feature dialog whose operation fails on such a part says, instead of the kernel's words and
an issue report: "Couldn't join to VALVE_COVER_01. One of its rounded faces can't be used for
modelling.", with Repair part (body.repair, declared as planned, also in the part's menu) and
Show face (selects and frames the face).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 15:58:06 -04:00
jyvikoandClaude Opus 5.5 920acc5279 STEP import: the feature's warning says in words what became of the parts
The kernel's import warnings get a structure (ImportReport: the file's parts, how many came
in as solids, and each warning's kind, part, faces and count; the reads' notes are typed as
repairs or faces left out). The Import feature's result carries it (and the model cache keeps
it), and the timeline tooltip and the status line after an import word it from the catalogs:
"Imported 40 of 43 parts as solids. 1 part couldn't be made into a solid and is shown as a
mesh. 3 faces couldn't be repaired and are missing." with what may help. Entity numbers and
the kernel's wording stay in Copy Warning Message, which now lists every warning.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 15:58:06 -04:00
jyvikoandClaude Opus 5.5 06fbcdfec6 Fillet dialog: Setback shows its default as a length and flags one too small before OK
The Setback field reached the command and the kernel used it: on a box corner
with r 2 rounds a 3 mm setback built, while 1.5 and 2 mm failed inside SMLib
(status 1001), shown as "could not be built" with nothing saying why. A setback
must reach past where the rounds meet without one (the radius on square faces).

The kernel now refuses such a setback before SMLib runs, naming the least
(the pre-check of aa2b09bc2 on fillet-kernel-cases), and exposes that least
(fillet_least_setback). The field shows the default, 1.5 x the radius, as an
editable length that follows the radius until the user types one, and outlines
a value at or below the least in the warning colour with "More than 2 mm"
under it (ui_kit::checked_row, warning_caption). Its hover text says what a
setback does, the default and the least.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-28 15:49:25 -04:00
jyvikoandClaude Opus 5.5 cd4f725729 STEP import: a surface model's closed shell beside a sheet is a solid of its own
A SHELL_BASED_SURFACE_MODEL with both closed and open shells (Poppy Humanoid's
thighs: the part and a two-face sheet on it) came in as one body, open for the
sheet's edges. Each closed shell is now read as an item of its own, a solid in
the model's colour, and the model's open shells as a surface body.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-28 15:42:23 -04:00
jyvikoandClaude Opus 5.5 61a1f8bf26 STEP import: a face's NURBS form ends where its boundary does, within its tolerance
A face's form covers the quarters of its box, and the box is the extent of its
boundary's points, which run past a quarter's end by as much as the edges lie
off the surface (nanometres in a file of 1e-11 mm digits). A half tube's form
then took the quarter past each end and went round the whole tube, which SMLib
does not take for a torus: 16 parts of an alternator came in as meshes. An end
within the tolerance of a quarter's end (the angle on the face's widest circle
there) is now on it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-28 15:42:23 -04:00
jyvikoandClaude Opus 5.5 3fd5e138ce kernel: rustfmt
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
2026-10-28 15:13:23 -04:00
jyvikoandClaude Opus 5.5 97721ad05f Fillet setbacks not past where the rounds meet are refused naming the least; the rig grades a refusal by its reason
A corner setback must reach past where the corner's rounds' contact lines
meet without one (smlib_blend_setback); short of it SMLib failed with its
own status (1001). The kernel now refuses it before SMLib runs, for the
rolling-ball corner (fillet_setback) and the curvature corner
(fillet_g2_corners) alike, naming the least: on each face at a corner of
planar faces and straight edges the two rails, r tan(psi/2) from their
edges, cross (d2 + d1 cos alpha) / sin alpha along an edge (r on faces
square to each other). Other corners stay SMLib's to refuse.

The rig's `refused` cases now name the reason (`refusal`, a part of the
message, required), so a failure for another reason no longer passes; a
`solid_or_refused` case may name one. Fillets: the setback cases and
783, 3435 pass; 1390, 896, 4782 past-a-full-round and the no-tangent-chain
case are refused for an unclear reason and fail.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 15:13:23 -04:00
jyvikoandClaude Opus 5.5 912bccef65 Isocurve Analysis: faces on one surface share their lines
The held parameter was spaced over each face's own trimmed (u, v) box, so the pieces of a
face split by a boss showed different lines that missed each other at the split. The lines
now sit on a ladder of the surface: a bounded parameter's range in count + 1 steps, a linear
one (a plane's, a cylinder's or cone's axis) at a round world spacing from the world origin.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 15:02:54 -04:00
jyvikoandClaude Opus 5.5 e197856205 STEP import: a refused solid's surface body faces as the file has it
SMLib holds both sides of a sheet's faces and gives each back on its surface's
natural side, so a sheet whose file uses faces the other way came back
renumbered. The reader no longer turns them (that lost the file's side);
instead SMLib is given the sheet with those faces turned over exactly on the
record, and they are turned back on SMLib's body, each face mapped through.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 10:36:56 -04:00
jyvikoandClaude Opus 5.5 4cb0d6ee96 STEP import: a refused solid comes in as a surface body of its exact faces
A solid the reader or SMLib refuses was shown as a mesh of its faces (#8223):
exactness lost, cracks between faces, and no modelling. It now comes in as an
open surface body of the faces that read, sharing their edges as the file has
them; each face left out is named.

- The reader reads a solid with a set of faces left out (read_solid_without):
  a sheet whose faces face their surfaces' natural normals, as SMLib gives a
  sheet's faces back, so SMLib's body numbers the faces as the record does.
- Tier 1: the faces that cannot be read alone and the face each refusal names
  (named_face) are left out, up to 8 reads. Tier 2, when a refusal names no
  face of the solid: the one-face bodies stitched by SMLib. Tier 3, when SMLib
  cannot stitch them: the mesh of them, as before.
- Report: "imported as surfaces: <why>" and "left out: face #..."; the
  ImportedBody field shown_as_mesh is now refused.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 10:36:56 -04:00
jyvikoandClaude Opus 5.5 0102f95dc2 Tessellation tests: rustfmt
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 08:09:31 -04:00
jyvikoandClaude Opus 5.5 5bfecd8a03 Tessellation: a loop corner on a side collapsed within its vertex's tolerance is a pole; a face no method plans is left out, named
A face's boundary node on a patch side collapsed to within the tolerance of
the vertex there (capped at the chord tolerance), not to a point, is a pole:
its parameter along the collapsed direction is free, as the record check and
the STEP loop check take it (`uv::collapsed`, shared with
`SurfaceEval::pole_within`). A loop through such a corner no longer winds
round the surface as projected, and plans strictly (Poppy Humanoid's
connector, face 43: a quarter of a sphere cap on a closed rational spline).

A face the strict plan and the lenient fill both refuse no longer fails the
whole body's mesh: it is left out with no triangles, named in
PlanStats::unmeshed (logged by the display plan, counted by
Body::unmeshed_faces), and the rest of the body is meshed; a body none of
whose faces plan is still the first face's error. Body::volume_at gives no
volume for a mesh with a face left out.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 08:09:31 -04:00
jyvikoandClaude Opus 5.5 cfee4a7208 STEP import: a solid no B-rep can be made of is shown as a mesh of the faces that read
When the reader or SMLib refuses a solid, each of its faces is read on its
own as a one-face surface body (solidcraft_step::topology::read_faces_with)
and meshed by the planner; the triangles together are a mesh body (the
existing kind STL/3MF imports make), marked ImportedBody::shown_as_mesh with
the refusal. The report says 'shown as a mesh: <reason>' and names each face
left out. Modelling operations refuse it as any mesh body.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 07:53:35 -04:00
jyvikoandClaude Opus 5.5 5a596dd952 STEP import: a patch side collapsed within its vertex's tolerance is a pole of the loop
The check that a loop does not jump across a spline surface's parameters took a
pole only within the face's tolerance. A corner patch written with one side
shrunk to a few µm (Poppy Humanoid's connectors: 5 µm in a 1e-5 mm file) was
refused, though the record check takes the same junction as a pole at the
tolerance of the vertex the uses meet at. The import check now uses that
vertex's tolerance; the loop runs along the collapsed side, its boundary iso
line. A jump that is still refused says whether the surface closes there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 00:12:05 -04:00
jyvikoandClaude Opus 5.5 fab8948b35 Clippy: assign operators and is_multiple_of in the continuity code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 21:15:20 -04:00