edge_check_orders_tangent_faces (solidcore#1684, fork 5533bbb) and
revolve_arc_touching_axis_is_horn_torus (solidcore#1679, fork c4e378d) are
both in SMLIB_REV 1ccd4612. precise_properties_trim_base_v (solidcore#1664,
WR-563) stays off: the fork has no commit for it, so the C++ kernel still
starts the area integrals at the domain's lowest v. The flag test now names
what is held back.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
The kernel switch broke these tests only through their counts, which record how a kernel splits
faces rather than whether the result is right. Each now checks its intent:
- a fitted circle is the exact circle (centre, radius, a full turn), not "one segment";
- the tight bend sweeps a valid solid of Pappus' volume, πr²(40 + 5π/2), not a count of faces,
edges and vertices;
- the Pi case keeps each outer side one face, stays valid after every feature and rebuilds the
same topology at 32 whether built there or edited there, without a hard-coded table of totals;
- a certified paint stays on the wall's radius and covers as many faces after an edit, a copy
and reopening as when it was painted;
- the offset sleeve and the extended strip are checked by their exact areas only.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
saved_curved_strip_projection_is_lost_after_exact_wall_coalescence built its "old" strip by
cutting the cavity raw (paint turning off the construction shortcut), where truck sewed the cut
slab by slab and split the outer round at the cavity's floor. SMLib cuts without slabs: the raw
cut's round is one face, so there was no piece to save a projection on, and the test stopped at
"must have a piece suffix". The link is now what such a build saved, written out: the face name
`F2:blend:F1:+x|F1:+y#1` (the lower piece, numbered up its spread) and the piece's projection on
YZ, the rectangle y 24..30, z 0..2 (the quarter round from (40, 24) to (34, 30), its arcs and
straight sides), 12 mm³ when extruded 1. The current wall is checked to be one face with that
stem and no planar authority.
The test still fails: the link is found on the whole wall ("was split; using the nearest
piece"), not lost, and the strip's material grows to 6 × 30 × 1 = 180 mm³. project.rs takes a
missing piece as removed only on a certified planar or coalesced face, which truck's shell
made and SMLib's does not. That is a persistent-name decision for the owner (see the PR).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fillets_on_tapered_bosses_saved_before_still_find_their_edges compared the part with
69454.885209 mm³, what the truck build that saved it measured. In closed form: the 80 × 40 × 20
block (64000); the 20 × 20 boss 10 high tapered 5° in, a frustum to a 20 − 20 tan 5° square
(3660.251034); the Ø16 boss tapered alike, a cone frustum to radius 8 − 10 tan 5° (1798.751833);
less the R1 round on a sloping corner, the corner's section r²(cot φ/2 − (π − φ)/2) at its
dihedral angle φ = 90.435° times its length between z = 20 and 30 (2.124401), and the R0.5
round all round the cone's top, the section at the rim's 95° turned about the axis by Pappus
(1.928463): 69454.950004. SMLib's part measures 69454.950004.
The test still fails before that check: Fillet2's saved edge `F4:side:c1#1|F4:top#[F4:side:c1]`
names a half of the cone wall truck built, which SMLib builds whole, so it is found with a
"was split" warning (a persistent-name question, see the PR).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since 0a216d692 tangent and curvature extensions are SMLib's G1 and G2 extension of the surface
(smlib_extend_sheet, CreateExtendedSurface), and the face stays one face on it, as
surface_extend's docs say; extend_a_cylinder_strip_every_way still counted truck's separate
run-off face (2). It counts 1.
The test still fails after this, on the curvature run-off's area (see the PR): SMLib's G2
extension of the quarter cylinder by 5 gives 413.882 (a section 4.986 long), where the test
works out the parabola's 418.182.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cut_keeps_posts_joined_while_apart_in_one_body expected the reply's `bodies` as
["Case", "Case (1)"]. That list is the state's order, which is SMLib's lump order (the -x half
first); the names follow the pieces' faces (lineage::order_lumps, 08cf526fe): the piece whose
least face name sorts first keeps "Case". That is the +x half, whose least is `F1:+x`, before the
-x half's least, its piece of `F1:+y`. The test now checks the names as a set, that the +x half
(from x = 1) is "Case" and the -x half (from x = -30) "Case (1)", and each half's volume as
before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since 09c979a4b a circle is one closed arc, so an extruded circle's wall, a hole's wall and a
cylinder's side are one face each, closed along a seam. Tests that counted truck's two halves:
- certified_annulus_side_rows_follow_radius_edits_and_clone and
certified_side_transfer_preserves_geometry_and_unsupported_taper_refuses_atomically: the
painted outer wall is 1 face (every vertex of it still at the painted radius), not 2;
- offset_surface_of_a_cylinder_and_a_box_top: the offset sleeve is 1 face (its area 2π·12·20
unchanged);
- press_pull_then_curved_face_offsets_it: a click on the hole's wall offsets its 1 face;
- pi_case_faces_per_step_at_both_heights: each standoff (a ring, Ø6 round a Ø2.5 hole) adds 4
faces, not 6: its outer and inner wall, its top, the floor inside its hole. So 23 after the
first and 35 after the pattern of four; the port openings (3 × 4), the end cut-out (4) and the
five vents (5 × 4) are planar and add what they did: 47, 51, 55, 71.
- the_round_sides_of_a_thin_ring_are_named_by_the_circle_they_run_beside: a thin ring 2 thick
about the R10 circle has two walls, `F2:wall:c1:left` (radius 9: the counter-clockwise
circle's left is inside) and `F2:wall:c1:right` (radius 11), with no numbers; each name is
found again by a point on its own wall.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
box_and_fillet_have_stable_wire_records compared the encoding of a box and a filleted box
with records truck built (2f4d6acac). Since f11c0c571 an operation's result is the record
SMLib gives, which numbers the box's faces in its own order and the fillet's edges by its
history, so the golden differed in face order, face sources and edge history, not in the
encoding. Rewritten with NATIVE_BREP_BLESS=1 and checked against the geometry: the box 6
planes, 12 edges, 8 vertices, each face source's plane its face's; the filleted box 7 faces,
15 edges, 10 vertices (one edge replaced by a face: +1, +3, +2), the round a cylinder of radius
2 along x on the axis (y, z) = (2, 8), 2 from y = 0 and z = 10.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since 09c979a4b a full circle in a profile is one arc of a whole turn, so what is built from
it is one closed edge and one wall closed along its seam. Five kernel tests still expected
truck's halves:
- a_small_hole_in_a_large_spline_face_cuts_cleanly: the Ø1 hole adds one face (its wall),
not two; the removed volume (π · 0.25 · 40) is unchanged.
- fit_loop (two mesh_convert tests): a fitted circle is Loop2::circle, one segment.
- tight_bend_counts: a Ø10 tube swept up 20, round a quarter turn of radius 5, along 20. The
circle starts at (5, 0), which runs up to (5, 0, 20) on the bend's axis, where the turn
leaves it: the bend face has no seam and both straights' seams end there. By the ladder's
rule (each whole curve once, each seam): 5 faces (2 caps, one per path segment), 6 edges
(4 circles, 2 seams), 3 vertices (the seams' ends: (5,0,0), (5,0,20), (25,0,20)), the
record's own counts.
- extruded_circles_go_as_cylinders: the record holds the wall as the cylinder it is (one
face of three), no longer a rational spline; it still goes into SMLib as its cylinder.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each is in the fork at develop's SMLIB_REV 1ccd4612 (tangency-labs/smlib 8088f5e, cae8618,
1072d1b, bc6ddf9, 577f7be, 67b8a1e, d2d9586, f11d0ac, 02fc29b, c0d74ee, and ef4ab25, e9fde8f,
d8c61db, 1693c9d), so solidcore stays with SolidCraft's C++.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
SmBrep::CreatePlanarSectionCurves over the body with the 3D, UV and face outputs, the curve
tolerance as the approximation tolerance and bForceUVClassify left FALSE, as the capi calls it;
a face list not one per curve is unsupported, the picked face's curves go out as NURBS, none is
empty. The section of a lofted wall is the line across it, the same on both kernels. As the
capi leaves bForceUVClassify FALSE, a face on an analytic surface (a box's top, a cylinder's
side) has no UV curve and is trimmed away: both kernels report it empty, and the closed-form
circle on a cylinder is ignored on that.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
Each is in the fork at develop's SMLIB_REV 1ccd4612 (tangency-labs/smlib b4f8c57, 54ca3e0,
b283ea2, a1ee273, e36feb1, cd85d34, 0dbe681, 8d95600), so solidcore stays with SolidCraft's C++.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
CreateParallelProjectionCurves now takes the curve itself (any of the SmBSplineCurve classes),
so smlib_project_curves passes its line, arc or B-spline as the capi's GetRootCurve() does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
SMLib 90aabff's smlib_sweep_placed sweeps a path of lines and arcs that turns with the path
(not closed, each piece leaving in the direction the one before arrives in) one segment at a
time, exactly: a line by the linear sweep, an arc by the rotational sweep, the profile
carried from each to the next, every piece's faces copied into one B-rep and stitched, the
caps the profile at both ends. The port (from solidcore#1581's head) sent that path to the
curve sweep, whose fitted walls differ from the C++ kernel's cylinder and torus. `segmented`,
`carried` and `piecewise` (with `Rigid` and `Segment`) are ported, ahead of the curve sweep.
On solidcore the second piece's copy fails: copy_faces without the merge into a B-rep that
already has faces finds no notification record for what it makes (solidcore#TBD, repro in
the bug file), so sweep_along_a_bent_path is ignored on solidcore until that is fixed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
solidcore#1568 (#1462 P1) carries a B-rep's attributes through a boolean, but the tags
`Brep::tagged` puts on the C++ body never reach solidcore: the crossing is the capi's flat
arrays, which carry no attributes (smlib.h, smlib_flat.cpp), and the history is read back
on the C++ body after the same crossing. tags_cross_a_solidcore_boolean stays ignored, its
reason now that crossing rather than solidcore.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
Wires solidcore#1597's per-session fillet options into the smlib crate's port of the capi's
round_edges and blend_call:
- solidcore#1438: a curvature-continuous blend runs the blend-curve section
(SM_FSG_BLEND_CURVE, continuity 2) with `set_blend_curve_at_thirds` on before the edges
are prepared, as round_edges sets SetBlendCurveAtThirds. The new case
fillet_curvature_one_edge takes abc - 113/756 r^2 L (the quintic with its inner control
points at thirds), to 1e-9, on both kernels.
- solidcore#1439: `smlib_blend_setback_open` sets `set_mark_corner_patches` and reads
`corner_patch_faces` before the session drops; after the stitch each set-back corner's
patch is the live faces (p1::faces) marked with its index, and any mark left on the body
is removed (RemoveAttributeFromTopology). The capi's open_corners is ported: each patch's
rim chained from the faces beside it, the patches deleted with their edges and vertices
(DeleteFace(f, TRUE)), and the holes listed per corner point in the result's edge and
face order. The C++ kernel's own test case (60 x 40 x 20 box, r5, set back 8) gives the
same 9 faces, 30 edges, 22 vertices and the same twelve-edge hole on both kernels.
The module note drops the two refusals; the unsupported test keeps the variable law's
corner and the cliff.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
solidcore#1585 records the caller keys where a NamingScheme::Caller body is built (an array
import through make_topology_from_data, api_brep_copy), and check_brep checks the body
under them. So `check` runs plain check_brep on every body but an Unknown one, and the
keyed path for our own array imports (Keys::Convert, check_brep_with_keys under
convert::key_of) is gone. A Caller body whose maker recorded no keys (check_brep's
InvalidInput) is refused as not supported, as an Unknown body still is, never a failed
check.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
Wires the two solidcore fixes into the smlib crate's solidcore port of the capi sweeps:
- solidcore#1449: `fixes()` turns on `taper_tangent_corner_planes`. `extrude`'s draft
no longer refuses a sharp corner under the curvature rule (or the tangent rule with a
profile of lines and arcs) as not supported: it calls
`create_taper_extrude_with_corner` with the rule (curvature -> CurveExtension,
tangent -> LinearExtension, round -> FilletCorner), and a refused corner is the
capi's `Error::Corner { why, at }` (Apart, WallCloses, NotExact at the corner's
point), as the C++ path reports `SmTaperCornerRefusal` and `pOptRefusedCorner`.
The tangent/sharp/has_corner checks that only fed the refusal are gone.
- solidcore#1450: a sweep along a path that is neither straight nor arcs about one
axis runs `create_curve_sweep_with_placements` with `profile_at_path_start` (and
`translational_sweep` for a translating frame), and `placed` takes the first,
middle and last placements. As in the capi's `smlib_sweep_placed`, round a closed
path the ends are not capped (the caps would lie on each other inside the solid)
and the faces are stitched, a lamina left being not solid.
The tests the two issues held back run again (extrude_square_drafted_curvature,
extrude_draft_wall_closes, sweep_along_a_bent_path), with a new case round a closed
rounded rectangle (Pappus). The module note drops the two refusals.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
The flags solidcore added since ddfb3895, each a port of a fork commit that SMLIB_REV
(90aabff) already carries, so solidcore and the C++ path agree with them on:
- taper_tangent_corner_planes (WR-521, #1449; tangency-labs/smlib e8f23e0)
- revolve_holed_profile_void (WR-529; 38b4212)
- local_operation_refuses_loose_tangent_edges (WR-530, #402; 23c5b0a)
- extrusion_origin_scaled_zero (WR-511, #1508; tangency-labs/smlib#31)
- boolean_skips_faces_apart (WR-527, #1526/#1527; 60b1c6a)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
A folded edge's Hermite pcurve on a bend's form breaks where the edge's angle crosses a
quarter. At the 120 degree corner with flanges at 60 and 90 degrees under a tear, an edge
starts 3.25e-12 of its parameter short of a quarter: the crossing was kept as a break
(breaks within 1e-12 of the parameter merged), the pieces halved to 1.6e-12, and SMLib,
given knots 1.6e-12 apart, handed the pcurve back with 15 equal knots at degree 7 ("SMLib
export: pcurve: loop 0 use 1: given pcurve: portable B-rep: knot multiplicity"). A crossing
whose point on the edge lies within the pcurve's lift accuracy (FOLD_TOL of the edge's size)
of the previous break is that break; the end is never merged into the start.
Fixes sheet::tests::every_pair_of_angles_is_torn_or_keeps_its_notch (torn pairs 37, 37, 27).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two expectations encoded truck-era output:
- a_flange_bent_inside_keeps_the_base_sketchs_arcs_in_the_flat_pattern_and_the_dxf: the
DXF has 7 LINEs, 4 ARCs, 11 shapes (was 9, 4, 13). The flat outline is SMLib's exact 2D
union of the plate, the bend zone and the flange panel; a zone's side and its panel's side
meet in line, and a region's boundary has no vertex in the middle of a straight run, so
each flange side is one line: 6 outline lines (plate top, left, right; flange sides and
end) and the bend's centre line. The same reason as 5d25684a1 gave for
a_base_trimmed_for_a_flange_keeps_its_arcs (12 to 10 edges). Areas, the bend length and
the volumes are checked as before and hold.
- hole_beside_two_adjacent_edge_flanges_cuts_and_bends_stay_guarded: the folded volume was
14057.2 +- 0.1, a faceted measure; since 32ae0cd9c the measure is SMLib's exact integral,
14057.3837123. Exactly, a folded sheet holds its flat area A times t, less each bend's flat
strip L·t·(R + K·t)·π/2, plus its sector L·t·(R + t/2)·π/2: t·A + t²·(½ − K)·(π/2)·L. With
t = R = 2.5, K = 0.44, A = 5597.0353454 (the flat pattern) and L = 75 + 35, that is
13992.5883635 + 64.7953485 = 14057.3837120, within 2e-11 relative of the measure. The
test now checks that identity to 1e-9.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face's sheet name is the name 80% of its mesh triangles' centres agree on. SMLib's
mesher fans a 1 mm rim (30 mm tall) into four triangles about its middle; two of their
centres lie 1/6 mm from the panel's top or bottom face, inside the 0.2·t tolerance, and
took that face's name, so the rim got no name (rim.side0/side1/ext0/ext1 of the tray's
flanges: 6 faces unnamed). A flat face's name now needs its plane to face along the
triangle's normal (within 1e-3); otherwise the point is a rim's, a bend's or an ext rim's.
No face changes name: these faces had none.
sheet::face_names_tests::a_trays_faces_have_readable_sheet_names_that_follow_its_size now
passes its naming checks and fails later, on the point named_face_point gives for a rim
(the roomiest triangle's incentre, 0.497 mm from the rim's edge, not 0.5).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A hole drawn on a flange's face and cut through ("direction": "negative") was refused as
"below the supported 0.000001 mm extrusion resolution": the flange panel's frame, turned
up by the cosine and sine of 90 degrees, puts the panel's origin at -1.9999999999999998
along the sketch normal, so the cut ends 2.2e-16 mm short of the sheet's far face and
reads as a layer 2.2e-16 thick. A depth within four units in the last place of the
numbers it is worked out from (the frame origins, the tool's span and the thickness) now
lands on the face. A real thin layer stays: a 1e-8 mm layer of a sheet 1e5 mm from the
origin (bound 9e-11 there) is still refused
(partial_depth_intersect_sub_extrusion_resolution_layers_refuse_atomically passes).
Fixes sheet::tests::a_sketch_on_a_sheet_face_follows_the_sheet_when_its_thickness_changes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since 09c979a4b a circle in a profile is one closed arc (Loop2::circle). The sheet's
faces passed it to the sew as one arc edge from a point back to itself, which the sew
refuses ("sew: a degenerate edge"): a sewn edge runs between two vertices, and an arc
edge is the circle through its ends and middle. A disc's flange failed (first with the
4-face minimum, then with the degenerate edge). Each closed curve of a cell is now split
into its two exact halves (Seg2::split_half) where the cell's edges are prepared, as a
hole's wall already came out: a disc is two caps and two half walls.
sheet::tests::tiny_cut_inside_exact_circle_survives_unfold_refold_and_dxf now builds the
disc flange and fails later, on SMLib's extrude of the 50 nm tool (an SMLib tolerance
defect, reported separately).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The case expected "drill 6.75 mm for M8", the major diameter less the pitch.
Since 05f1c6b9a (Tapped holes: the tap maker's drill for every form) a tabulated
size names the tap maker's drill, 6.8 mm for M8 x 1.25 (Yamawa YEU23 p.704), as
case 2115 already grades and engine thread_tests.rs asserts; major less pitch
is for a size no table lists. The refusal itself and its reason are unchanged.
The case passes and leaves threads/KNOWN_FAILING.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The zero-area triangle is dropped (previous commit): the box converts with six
faces and V = 1000 mm^3, as the case expects.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A triangle whose corners lie on one line (or weld into one another) adds no
surface, so welding now drops it, with any corner only it used, instead of
refusing the whole mesh as having a degenerate triangle. The closed and
consistently oriented check that follows still refuses a mesh that needed it to
close, and a mesh of nothing but such triangles is refused by name. Dropping its
unused corners keeps a dropped triangle from widening the part's extent, which
the prism search reads from every position.
Regression test a_zero_area_triangle_is_dropped: the 20 x 10 x 5 box with the
case's extra triangle (0,0,0) (10,0,0) (20,0,0) converts to six faces and
V = 1000 mm^3.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fixed_seeds_run_clean expected the join of a box touching the first only along
an edge to be refused with "zero-thickness edge contact". Since 94ee28d5c (doc:
a join keeps solids that only touch as separate bodies) such a join succeeds and
keeps the new box a body of its own with an along_edge notice, which
join_touching_along_an_edge_keeps_a_separate_body asserts in engine tests.rs.
The seed now expects that: the notice, two bodies, each valid, and the volumes
unmoved, 25 x 15 x 10 + 17.5 x 17.5 x 20 = 3750 + 6125 mm^3.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib's thickening of the test sheet makes a top face of 72 x 78 control points,
which the 4096-point cap refused (TooLarge) before the solver saw it. The band
cap (2^21 entries, 16 MB) is what bounds the system's memory and its
factorisation (at most n min(n, bw)^2 work); the 72 x 78 bicubic net needs
5320 unknowns 213 apart, 1.14 M entries, well within it. The point cap now
bounds only the per-step energy sweep and the net's copies: 2^14 points, above
the band's own limit for square bicubic nets (about 90 x 90), so a face is
refused for the system it needs rather than its size. The hostile-input test
asks for 129 x 129 and checks the refusal is TooLarge.
a_body_face_is_faired_with_its_edges_untouched_and_its_history_kept passes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The README demo's Raspberry Pi case stands four standoffs on its floor: Extrude2's ring of
radius 3 round a 1.25 hole, patterned by RectangularPattern1. Each is its outer wall, its inner
wall, its top and the floor inside it: four faces. The recorded counts were truck's, which made
each cylindrical wall two halves (six faces a standoff): 25 after feature 6, 43 after the
pattern, and 8 more than now at every step after it. On SMLib each wall is one face closed on
its seam, and the counts are 23, 35, 35, 47, 47, 51, 51, 55, 71 from feature 6 on (the feature
names show it: F6:side:c1, F6:side:c2, F6:top and the floor piece bounded by F6:side:c2 per
standoff). The outer sides stay one face each, and (b) and (c) still agree step by step.
Fixes cli rebuild_topology::pi_case_faces_per_step_at_both_heights.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- A modelled thread reopened with the designation 1/4-20 UNC on the M8 it was made as: the
thread is metric, and since b4549d270 (threads in the standard forms) an unknown designation
is named with its form: "unknown metric thread `1/4-20 UNC` (like M8 or M8x1)". The test looked
for the old wording, "ISO metric".
- Press Pull on a hole's wall opens Offset Faces with the whole wall: one face, closed on its
seam, on SMLib (a cylinder wall was two halves on truck).
Fixes ui-egui dialogs_thread::contribution_tests::expanded_catalogue_rejects_external_taper_holes_and_nonmetric_thread_features
and preselect_tests::press_pull_then_curved_face_offsets_it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face on a B-spline surface closed around u (first and last control columns the same) may lie
across the surface's start without winding round it: the strip on a radius-3000 rational
cylinder whose seam is 0.001 rad into the strip. A kernel's trims run inside the surface's
knots, so its pcurve came back clamped at the start, 2.28 mm off its edge, and the strip was not
imported.
Before seams are added, such a surface is started anew in the middle of the stretch of u the
face leaves free (each loop followed round, unwrapped across the start; a face winding round is
the seams' to handle): the new start inserted to full multiplicity and the piece after it put
before the piece before it, a period on. The same points, a period apart in parameter before
the new start: exact. The face then lies inside the knots.
Fixes kernel step_in::tests::explicit_outer_bound_crossing_a_closed_nurbs_seam_stays_trimmed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two tests counted the old 2D boolean's edges, which kept a vertex wherever an operand's corner
or edge end lay on another's edge. SMLib's planar boolean leaves no vertex that is no corner:
edges on one line within the tolerance are one edge. The results are the same regions with
fewer, whole edges, and each test's point stands (no edge shorter than the tolerance, no sliver):
- a quadrilateral cut away from below a square whose bottom edge it lies on within 1e-8 (tilted
1e-9 rad) leaves the square's four 10 mm edges (its corner at x = 4 is within 1e-8 of that
edge's line), and its union runs along y = 0 as one 14 mm edge (the quadrilateral's bottom
edge is within 1e-8 of y = 0 all along): [4, 5, 5, 10, 10, 14];
- the bent plate and the strip under it: their ends on the line x = 150 are one edge from
y = 47 to 80, six edges for every turn and offset tried, the shortest 3.
Fixes prism::planar_tests::overlapping_lines_a_hair_from_parallel_do_not_cross and
a_bent_edge_crossing_its_neighbour_by_their_corner_leaves_no_sliver.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reading a planar sheet's faces back as regions, each hole went to the smallest outline whose
Loop2::contains held its middle: even-odd against the outline's polyline within 1e-3 mm. A
5e-5 mm square cut 1.7e-4 mm inside a radius-10 circle lies outside the polyline's chords there,
so no outline held it and the cut failed ("face 0 has a hole outside its material"). An
outline now holds a point by its polyline within a quarter of the point's distance from it (its
nearest point on the exact segments), which no chord can pass the point by.
Fixes kernel prism::planar_tests::tiny_tool_between_circle_and_display_chord_is_not_lost.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
94bd8719a (#3730) turned a BREP_WITH_VOIDS void inside out when it enclosed volume of the
outer shell's sign: SOLIDWORKS writes .F. over a void shell already facing into its cavity,
SolidCraft .T. That lived in the truck reader; the schema-4 reader (crates/step) that replaced
it took the flag alone, and the block with a 20 x 6 x 5 cavity read as 15600 (the cavity added)
instead of 15000 - 600 = 14400.
The reader now takes each void's sign from the faces themselves before it orders the record:
the divergence theorem on the record's surfaces and pcurves (sew's face_flux of p / 3, moved
to geom's brep::eval so both use it). A void enclosing volume of the outer shell's sign has its
faces turned over. Flipping on the finished record is not an option: its edges are ordered by
the faces' sides.
Fixes kernel step_in::tests::a_void_reads_as_a_cavity_whichever_way_its_shell_flag_points.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The expected 6703.5222 was a mesh measure (truck). The lid exactly: the 76.8 x 89.3 x 2.4
plate less its four 3 mm corner rounds ((76.8 * 89.3 - 36 (1 - pi/4)) * 2.4 = 16441.2344), the
skirt ring ((71.5 * 84 - 68.5 * 81) * 3 = 1372.5), less the window (68 * 61 * 2.4 = 9955.2) and
the slot (44 * 10 * 2.4 = 1056) through the plate, and the notch through the skirt's 1.5 mm wall
(22 * 1.5 * 3 = 99): 6703.534401. The window and slot lie inside the ring's opening and the
notch above the plate, so nothing else overlaps. SMLib measures 6703.534401575, 2.6e-7 off.
The test now computes that closed form and holds the body to 1e-6.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A whole circle is now one closed rational curve (Loop2::circle is one segment), whose first
control point is repeated as its last: the mean of its nine control points sat r/9 towards the
seam, and a rail scaled each station about that point. A rail bulging from radius 10 to 15
(r = 10 + 5 sin(pi z/40)) then grew the circles as if r = 10 + 5.625 sin, volume
4632.8 pi + 9000 = 23553.9 against the solid of revolution's pi * integral r^2 dz =
4500 pi + 8000 = 22137.2 (+6.4%; the engine's arc rail +6.5%).
The middle is now the curves' centroid by length, integral x ds / integral ds (8-point
Gauss-Legendre per knot span on the rational point's speed): the shape's alone, however its
curves are written; a circle's is its centre. geom's GAUSS_8 is public for it.
Fixes kernel loft_rails_tests::a_bulging_rail_makes_the_solid_of_revolution_of_the_rail and
engine loft_rails_tests::a_rail_turns_a_loft_into_its_solid_of_revolution_and_stretching_is_an_edit.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>