Commit Graph
626 Commits
Author SHA1 Message Date
jyvikoandClaude Opus 5.5 2f83aaa5da kernel: clippy's own fixes across the kernel (needless borrows, assign ops, contains)
Machine-applied by cargo clippy --fix: borrows the compiler dereferences at once, an
unused import, a manual += , an entry() for contains_key+insert, a needless Ok(?),
contains() for iter().any(). No behaviour changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 2a09b99431 kernel: the test target compiles: the last tests on the record and SMLib
mesh memo (one remembered mesh per tolerance), history (a bare body from a record), tests.rs
(no coarse-missing field, lumps for touching shells), outline (the foot found by the planar
faces in its plane), chamfer sides (the rim from the record's edges), seam faces, coplanar
and issue 679 and pinch tests (the boolean is SMLib's: the diagnostics assertions go, every
volume, shell and validity check stays), boolean history (a cut of two pieces through the
boolean), integration tests naming solidcraft_kernel::MeshTolerance.
Deleted, testing internals that are gone: boolean_history_tests' glue_merges_across_the_seam
and faces_pushed_apart (coplanar::glue, boolean_apart), planar_fallback (polybool's
planar_boolean) and bore_union_of_a_bore_in_two_arcs_has_no_history (coplanar::bore_union);
issue_851's the_sphere_at_a_box_corner_is_the_planar_corner_builders (blend_vertex); pinch's
prism_boolean shell check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 018bdbad3f kernel: tests.rs reads the record
The truck reads become record reads: an intersection edge of a moved cut, the fillet
mitre edges sampled with CurveEval, the cache estimate from the record's faces and edge
uses, holed faces by their loops. The drain pads and the coincident-faces booleans keep
their volumes and faces without the boolean diagnostics and the polygon boolean.
Deleted, testing internals that are gone: a_tapered_s_curve_is_cut_into_pieces_that_follow_its_offset
(build::offset_error/offset_splits), planar_fallback_names_the_curved_faces (the polygon
fallback), mixed_loop_blend_guards_selection_and_construction and
loop_chamfer_mixed_arc_and_line_uses_offset_intersections (loopblend),
an_attempt_budget_stops_the_boolean_and_is_shared_by_nesting (with_attempt_budget),
placing_a_body_does_not_turn_its_revolved_faces_again (REPHASED, truck's revolution phase),
and the truck debug runs debug_coplanar_union_rate, debug_truck_sphere, debug_sphere_patches,
debug_sphere_cases, debug_sphere_rotations, debug_cube_sphere_measure, debug_heal_sphere_cut,
debug_coplanar_cylinder_union, debug_drilled_hole, debug_face_param_areas and
debug_revolved_tube_cut (truck_shapeops booleans, build::sphere_patches).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 623f1b9c16 kernel: native and SMLib-import tests on the record; the adapter's tests go
native.rs's test module keeps its encode/decode, wire-record, hostile-input and appearance
tests. Deleted with the adapter they tested: pcurves_on_planes_are_the_curves_mapped_exactly,
pcurves_fit_curved_faces_within_tolerance, pcurves_of_seams_lie_a_period_apart and
pcurve_pictures, with their helpers (pcurves_of, check_pcurves, check_faces, curved_bodies,
seam_faces, draw). smlib_import_tests count shells on the record; their notes no longer
speak of truck.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 8237cc927d kernel: mesh, lump, loft-rail, untouched-face and intersection-curve tests read the record
- thin faces: the face pinched against its own edge is a record sheet (sew::assemble) meshed
  by the body's mesher; its triangles still cover its boundary polygon.
- trimmed loft faces, loft rails: distances to faces through the record's SurfaceEval.
- untouched faces: edges and in-line stations from the record's edges and vertices.
- intersection curves: the #1252 regression on a record sheet whose edge is a traced
  intersection of parallel planes: meshing neither panics nor goes non-finite.
- lumps: shells counted on the record; the certified witness is Brep::compound of its three
  bodies, faces known by surface and box.
- Deleted, testing internals that are gone: intersection_curve_tests'
  degenerate_intersection_polylines_return_none_without_panicking,
  closed_intersection_retains_the_closure_and_spherical_supports and
  open_intersection_keeps_endpoints_on_both_planes (truck's IntersectionCurveWithParameters)
  and a_result_with_an_edge_that_does_not_evaluate_is_refused (boolean_record::edges_evaluate);
  body_lump_tests' unowned_overlapping_and_touching_cavities_are_errors_not_dropped_geometry
  and shortcut_clearance_refuses_curved_contact_hidden_between_mesh_vertices (truck shells
  joined without regions, separated_lumps) — kept as spheres_apart_join_as_two_lumps — and the
  shell-order permutation of nested_cavities (the record names each cavity's region).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 e1b9ea10cc kernel: placement, history, mesh-memo, display and issue tests read the record
- placement: a rigid placement moves the record and nothing else (regions, shells, loops
  with their pcurves, edges and their uses equal; every vertex moved; the identity's
  history), on a cylinder whose wall's loop uses its seam twice.
- issue 2005, 616, 674, 1038, 1510, join between caps, regularization protection, history,
  mesh memo, display mesh: the truck reads become record reads (shells closed by edge
  uses, faces by the record's surfaces, vertices by the record's points, the mesher's own
  boundary budget); the nearly-in-plane slab of 1510 is an extruded record body.
- Deleted, testing internals that are gone: issue 616's glue_joins_every_face_the_pieces_share
  (coplanar::glue) and the_retry_guard_refuses_changes_away_from_the_tool
  (boolean_guard::check_retry); issue 674's partial_contact_does_not_join_tangent_or_separated_faces
  (coplanar::imprint_union); issue 1038's hinted_division_matches_the_search_from_nothing
  (truck's vendored parameter_division); issue 1510's a_face_close_to_the_plane_but_off_it_is_not_moved
  (ops::off_plane). The boolean-diagnostics assertions (no retry, no tool nudge) went with
  capture_boolean_diagnostics; the rest of each test is kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 1b7fda4d33 kernel: surfaces and SMLib blends without the smlib feature gate
solidcraft-smlib is a dependency of every build (it answers NotBuilt without
SMLib), so the SMLib sides of surfaces.rs and blend_smlib.rs no longer sit
behind cfg(feature = "smlib"), and their stub modules go; blend_smlib's tests
run in every build like the rest. This also uses offset_backend::thicken and
the smlib_sweeps curve conversions in builds without the feature, which left
them unused there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 dead22ba7a kernel: corner rules for direction, rails and closed paths; no feature gate on SMLib sweeps
The three refusals of the cornered controlled sweep become the owner's rules:
- an orientation direction turns the section about the corner's binormal like
  any sweep, then turns it back about its normal to the direction's frame
  evenly along the next run, as a twist (direction_offset: the turn between
  the carried section and the direction law's section there);
- guide rails follow a path with corners when each rail has a corner of its
  own at every corner of the path, in the plane halving it and by the same
  turn about the same axis; the rails are cut there into each run's
  (run_rails), anything else is refused with the corner named;
- round a closed path with corners the first run starts from the closing
  mitre and the last ends on it; a twist is allowed where the profile maps
  onto itself (closing_offset), an end scale is refused.
Each run's station count now follows its own turn, twist included.

solidcraft-smlib is a dependency in every build (it answers NotBuilt without
SMLib), so smlib_sweeps' imp is no longer behind the smlib feature and its
stubs and not_built go; polyhedron calls offset_backend in every build.
Deleted as unused: sweep_path::{closed_path, turn, stations}.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 caa5ed0e63 kernel: twisted and scaled sweeps round corners by the plain sweep's corner model
A sweep that twists or scales refused any path whose direction jumps by more
than 1e-3 rad, a branch on the path's shape. It now takes the corner model of
the plain sweep: each smooth run is swept through stations by the laws a smooth
path has (twist and scale running with the length along the whole path, each
run going on from the section the last ended with), and the runs meet at each
corner in a mitre. Turning with the path, each run goes on past its corners as
a prism of its section there (the laws hold still across the mitre: the two
runs' sections meet on the plane halving the corner only when both are the
corner's section) and is cut back to that plane, then turned through the
corner onto the next run; only moving along the path, the runs meet at the
corner's section. The mitre plane is one function for both (mitre_of).

Refused, with the reason, where a control has no meaning at a sharp corner: an
orientation direction (it turns the section by its own turn, not the corner's,
so the two runs' sections don't meet), guide rails (their sections jump where
the path turns), and a closed path with corners (a twist or scale keeps the
last section off the first).

(not built: base in progress; no error in these files)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 337b8096f9 kernel: dead code the ports left is gone; core files formatted
(sheets agent's f57070d7 merged before this)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 206c53487e kernel: dead code the ports left behind, deleted
Every lib warning under --features smlib outside the files agents are editing
(assemble.rs, sweep_path.rs) pointed at code nothing calls any more:
- body: shell_nesting;
- boolean_record: of_pair and its Traced alias;
- planar_regularize: the generated-wall regularization (and its branches in the
  certified one, which was its only other path); planar_sources:
  with_shell_planar_sources;
- plane_fit: plane_through, EdgeSampler, planar_face, plane_frame (the patch is
  fill's); only loop_area is left;
- polyhedron: solve3; prism: wall_along; offset: Surf::normal;
- record: regions, region; shell_groups: groups, parents and their limits;
- splitface: side_of_point, Analytic, analytic_face, face_sides, canonical;
- spline_conv.rs, all of it (surfaces builds NURBS records); an unused import in
  tess/uv.rs.
The tests of deleted items go with them: prism's wall_along test, the shell
grouping test in body_lump_tests, and the generated-regularization assertion in
regularization_protection_tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 ee79235f59 kernel: surfaces, bridge and loft rails clippy-clean; picked_loop gone
picked_loop's one caller was the patch, which is fill's now. The rest is
clippy's: a record borrowed where it was already a reference, an Ok(..?) that
was the value itself.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 a5f5809ba6 kernel: a ruled strip's side builder needs no mutable binding
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 748e796b2b kernel: sweep histories attach with no edge origins given
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 7646e8ff6c kernel: compiles on the record — trim reads the tool's side near its body; mesh memo typed
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 1d48112013 kernel: STEP import tests and docs without the deleted face splitting
split_band_edges_are_seams tested split.rs's splitting of a face that winds around its
surface into two (deleted with the truck reader; the record keeps the face with a seam):
deleted. ImportedBody::file_faces says each body face is a file face.

(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 ed43871f7c kernel: IGES export from the record
Each body's record is written directly: a manifold solid B-rep (186) per material region
with its voids, open shells as 514 form 2, faces on the record's exact surfaces and edges
on its exact curves over their intervals, in the STEP form solidcraft_step::write::topology
gives them (one geometry model for both exports). The detour through STEP text and its
re-parse is gone; the maximum coordinate is the largest coordinate written.

(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 ab8bc6625a kernel: STEP import and export on the schema 4 record and SMLib
Import: every solid is read by solidcraft_step::topology into its record and taken into
SMLib as given (step_in/parallel.rs smlib_part), the one path; the truck readers
(step_in/brep.rs, split.rs, geom.rs) are deleted. Placements are column-major 4x4 matrices
from solidcraft_step::read placements; an instance is its part's record moved there
(ops::transform_matrix), or the very part at the identity. Assemblies, names, colours,
shared displays and the public API are unchanged. step_orientation_errors lists the faces
the STEP reader turns over (their loops disagree with their same_sense).

Export: each body's record is written by solidcraft_step::write::topology as the exact
B-rep (solids per material region, open shells as a surface model, the record's pcurves);
step_out writes products, units, colours and assemblies around it with Writer. The truck
writer and every post-processing pass (split-face merging, sheet trimming, analytic
recognition, short-edge collapse, the re-read fallback) are deleted. The context's
uncertainty is the loosest record tolerance exported.

Tests: ported to the record API with their assertions. Deleted, as tests of deleted
internals: conic_tests extruded_ellipse_seam_uses_profile_angles_for_oblique_sweeps and
conic_arcs_are_exact (truck geometry reader), tests offset_surface_analytic_geometry_and_
orientation, offset_surfaces_nested_and_hostile and periodic_knot_bsplines_are_read_on_
their_domain (truck geometry reader), corpus_truck_and_schema_4_counts (truck comparison);
the orientation counter asserts (crate::body::ORIENTED, gone with orienting by mesh).

(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 4897ce17b4 kernel: loft rails tests measure against the record's surfaces
(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 5aaf405d8d kernel: the second-derivative tests check the record's SurfaceEval::second
The vendored truck-geometry they pinned is gone; the same finite-difference checks, degrees
2 to 5 and a rational surface, now pin SurfaceEval::second, which every curvature the kernel
reads comes from.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 bd1095fff0 kernel: the general fill's tests read the record; five- and six-sided fills are patches about a centre
The helpers read every face of the fill as a record surface over its box, the loops'
(u, v) polygons from their exact pcurves, the rim from the free edges and curvature from
SurfaceEval::second; check_face takes the fill's faces (one, or the patches about a centre)
whose free edges lie on the body's edge curves. Expectations changed by the coordinator's
decision on loops of five or more edges: the pentagon fills as five patches (each rim edge
in halves, five spokes: at least 15 edges), the hexagon through a point as six patches with
18 edges. Every other assertion is kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 4a8ca6d0f1 kernel: Assembly::finish ends in Brep::canonical
finish lays out the faces left and added (each stored relative to its surface's natural
normal with its pcurves and box, now one function, stored()), the source's shells and
regions (a region whose outer shell lost every face gone) and the edges and vertices as
they are, then calls Brep::canonical; its own ordering walk is deleted. check_geometry
and the face and edge maps are kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 13e9aca7ec kernel: exact projection, section and iso curves exported; SMLib at the fork's integration head
(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 d9274aaf1f kernel: the point-path sweep test expects the polyline's walls
sweeps_along_3d_paths asserted at most 8 faces for a 41-point path: one wall
per profile segment fitted through the points, which the exact construction
no longer makes (no curve is fitted through samples). A point path is the
polyline its points make, swept line by line and mitred at each point, so the
circle's two arcs give two walls along each of the 40 lines, and two caps:
82 faces. The volume check stands (a mitred sweep of a profile centred on its
path keeps area × length).

(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 849bb1f24b kernel: face sections along a direction as SMLib's exact curves
face_section_along cuts a face through a point by the plane that holds the
face's exact normal there and a direction (Brep::face_section): the iso curve
"along a direction" of a link, as record curves on their intervals, the
B-splines SMLib made. The projection and the section share the picking reach,
the curve tolerance, the error words and the conversion to record curves.
(Intersection links take the base's meeting_edges, SMLib's imprint.)

lib.rs (coordinator): export point_path::face_section_along.
(not built: base in progress; no error in these files)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 95e9a80faf kernel: iso_curves, a face's isoparametric curve exactly, trimmed by its loops
iso_curves gives the isoparametric curve of a body's face through a point, along
its first or second parameter, as record curves: on a B-spline surface the
surface's own row at the point's other parameter (each control point its
column evaluated there, homogeneous, so exact for rational nets), on an
analytic surface its line or circle. It is cut where it crosses the face's
loops: each crossing solved on the loop's pcurve itself (bracketed on samples,
then bisected on the pcurve), the pieces between kept where their middle lies
inside the face (even-odd over the loops), neighbouring inside pieces joined.
A revolved surface record is not supported yet.

lib.rs (coordinator): export point_path::iso_curves.
(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 7b5d732e38 kernel: project_onto_face, sketch curves projected onto a face as SMLib's curves
project_onto_face projects sketch segments along a direction onto the face of a
body at a point through Brep::project_curves (smlib_project_curves), each
projected piece the B-spline SMLib made, returned as a record curve
(RationalSpline) on its interval, within a millionth of the body's size.

lib.rs (coordinator): export point_path::project_onto_face.
(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 453d6395e6 kernel: the last truck wire, face and loft helpers leave the construction files
The base no longer links truck, so build.rs and sweep_path.rs drop what was
kept only for other modules: chain and profile wires, the profile face,
loft wires and their ruled and smooth faces, across/section_parameters, the
cubic interpolations and NetFit, the uniform wires, the six sphere patch
faces, and sweep_path's ruled_sheet and smooth_sheet with the station helpers
only they used. Their callers switch to planar_face_record,
smlib_sweeps::{chain_curves, body_from_record, sphere}, sketch_record_curve,
the SMLib sweeps with open ends, and bspline::CurveN::interpolate.
offset_backend and polyhedron pick faces through provenance::closest_on_tri,
boolean_guard being gone.

Callers left to switch (other ports): surfaces.rs, loft_rails.rs,
surface_offset.rs, surface_ruled.rs, step_in/brep.rs, trimmed_face_mesh_tests.rs.
(not built: base in progress; no error in these files)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 6d0993817f kernel: a ruled strip whose rulings turn along a free-form edge is refused, not fitted
Rulings that are constant, or keep their angle to an arc's axis, move the edge by
an affine map: the far edge is the edge's exact image and the strip exact. Any
other ruling field (a normal turning along a free-form face, a tangent carried
round a free-form curve) ends on an offset curve, which has no exact NURBS form
in general: SMLib holds one only implicitly (SmOffsetCurve) or approximates it
(NL_CrvOffset.h, N_CrvOffsetApprox), and its ruled surface (SmApiCreateRuledSurface)
takes two B-spline curves it is given. Such a strip was a B-spline fitted within
1e-3; it is now refused by name. The fitted-strip test checks the refusal.

The round-corner cases count one face per corner: SMLib's revolve makes a quarter
turn one face, where truck's cone builder made two (12 faces and joins, now 8).

(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 715ed5db74 kernel: matchsurf and loft blend tests read the record
The helpers that read a face's surface, its edges and its seam shape read the record
(SurfaceEval, CurveEval, matchsurf's Patch) instead of truck faces; every assertion is
kept.

(not compiled: the kernel's test target waits on the base's step_*, build, sweep_path and
surface_ruled ports)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 65e141ac47 kernel: stitch splits an edge at another sheet's vertex lying on it
Before sewing, each edge of one input is split exactly (Brep::split_edges) at every vertex
of another input that lies on it within the stitch tolerance away from its own ends, so a
patch whose corner meets a body's edge part way (the five-plus-sided fill's midpoints)
sews with no T-junction. The pieces carry their edge's history. The search is the nearest
of 64 samples refined by golden section, over the vertices within a chord's reach of the
edge's samples. Nothing else in stitch changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 98548fe164 kernel: one canonicaliser; one tensor sheet
sew::assemble and surfaces::Parts::canonical each lay out their record as its parts stand
(regions, shells, faces, edges with no uses, vertices) and end in Brep::canonical; their own
ordering walks are deleted. spline_conv::tensor_face (no callers left) is deleted in favour
of surfaces::tensor_sheet, and fill's copy of the spline surface record in favour of
surfaces::spline_surface.

(not type-checked: the kernel stops at name resolution in step_*, build, sweep_path and
surface_ruled)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 db0ac61294 kernel: ruled surfaces on the record
The strips keep their model (exact where the rulings move the edge by an affine
map, a ruled B-spline fitted within 1e-3 otherwise; mitred or rounded corners;
an inside corner cut back). Each strip is built on its own on the record: the
chain edge as its exact NURBS (a circle or ellipse arc rational quadratic), the
far edge its image (its control points mapped) or the fit's, the surface a plane
or the ruled NURBS between them with straight pcurves along its parameter lines.
A mitre's triangles are flat polygons; a round corner's sector is SMLib's revolve
of the incoming side about the corner's axis. The faces are stitched by SMLib
(surfaces::sheet_of, which now takes the operation's operands), each strip made
in place of its edge, each corner face in place of the two edges there. Tests
read the record; the check that the strips stand on the box's own edges now
looks for edges lying along them, as the result is a body of its own.

(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 0d611ed84e kernel: surface sweeps mitre at corners, as the solid sweep does
A surface sweep along a path with corners was refused. Each smooth run is now
swept on its own with open ends by the solid sweep's corner model: carried on
straight past each corner, imprinted with the planes halving the corners and the
pieces between them kept (a point inside each face, smlib_face_points), the
profile turned through each corner onto the next run; the runs are stitched.
Only moving along the path, the runs meet as they are. Each wall keeps the
segments its uncut face came from through SMLib's tags. Sweep options along a
path with corners are refused as the solid sweep refuses them. The sheet
builders use smlib_sweeps' curve and path_curve; their own copies are gone.

(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 30b02cdfa8 kernel: the solid loft's rails anchored by loft_rails::railed; path curves shared
smlib_sweeps' loft_rails kept its own copy of the rail law with the anchoring
4056 was refused by (a rail lying in the last section's plane met at its first
crossing there). It now builds the sections with loft_rails::Section and takes
the sections and stations loft_rails::railed gives, so the law and its fix live
in one place. path_curve is exported beside curve for the sheet builders.

(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 f4fa8a407a kernel: the touching-face checks, extrusion batching and clearance probe are gone
The doc puts exact tools into SMLib's boolean as drawn, so nothing asks whether a touching tool
can be joined, batches extrusions, or probes for room to grow a profile.

(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 22fde06a3b kernel: loft blend on the record, through bridge's record API
loft_blend hands its net to surfaces::tensor_sheet (the bridge's own one-face sheet);
section_frames picks the face that bounds the whole chain and faces the run best from the
record's edge uses and the face's SurfaceEval normal, and reads its frames with
bridge::frames. Behaviour and messages unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 87907628e5 kernel: surface match on the record, through bridge's record API
match_surface and seam_continuity read faces as record surfaces (SurfaceEval over the
face's domain), pick the face and its kept side's edges from the record, chain and frame
the target through bridge::chain/frames, keep the crown whose bridge strays least from the
original, and turn the bridge face to the target's sense by building it again turned
(surfaces::Parts). The history is over [body, target]: the face modified from the body's,
its edges new. Behaviour, constants and messages unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 7c0d9b5e82 kernel: the general fill on loops of five or more edges, its patches about a centre
general_fill takes loops of three to sixteen edges. quilt_body assembles fill_iso's
patches into one sheet: each loop edge whole, or for five or more its two halves at the
middle of its interval, both on the edge's exact curve record and sharing a midpoint
vertex; each spoke a new edge from that vertex to the centre; every pcurve the straight
line in (u, v) of its side. The history marks every face generated, each edge or half a
piece of the body's own edge, each spoke new. A reversed loop edge's knots keep the
interval's ends exactly, so pieces name the edge's own vertices.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 9398b2586d kernel: intersection edges exported from the crate root
(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 1b27c134de kernel: an intersection curve is where SMLib's imprint cuts, exactly
sketch.intersection_curve (LinkSource::Intersection, crates/doc/src/
project.rs) intersected the two bodies' display meshes triangle by triangle
and chained the segments into polylines: a curve known only as points, off
the true intersection by the meshes' chord.

kernel::meeting_edges(a, a_face, b, b_face, chord) takes each side whole or
as one face (that face alone as a surface body, surfaces::taken), tags both
and imprints the first by the second in SMLib (smlib_imprint: "each of its
faces that `tool` meets cut along the intersection", capi/include/smlib.h).
SMLib intersects the faces' surfaces and trims each curve to both faces, so
the edges the imprint makes are exactly where they meet; its own history
says which they are (an edge no edge of either operand became). Each comes
back as its record curve on its interval, from SMLib's export of the
imprinted body, with its points from that body's mesh at `chord`. Sides that
do not meet give none.

The intersection link now stores each edge as a wire with its exact curve
(Wire::exact, the existing WireCurve; no new type or format change), its
points at 1/1000 of the larger body. project3d::mesh_intersection, its
triangle/triangle test and segment chaining go; project3d::mesh_of becomes
part_of (the body and, for a face reference, the face index).

Needs in crates/kernel/src/lib.rs (the coordinator's): `mod intersection;`
and `pub use intersection::{MeetingEdge, meeting_edges};`.

Not built: base in progress (kernel-smlib/no-truck 513ebe47 does not build).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 beebf22032 kernel-cases: --dumps=DIR leaves each failing SMLib call's inputs for replay
A rig case whose SMLib call fails left nothing to replay it from: nothing called
solidcraft_smlib::set_dump_dir. `solidcraft-cli kernel-cases --dumps=DIR` now points SMLib's
dump folder at DIR/<area>-<case> before each case runs, so a failing call leaves its
arguments and B-reps there (smlib_brep_read reads them back into a scratch C program), and
turns it off after the run. Off without the flag. The kernel exposes it as
smlib_dump_dir, beside smlib_built (the CLI reaches SMLib only through the kernel).

(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 08f061b02f kernel: boundary surfaces on the record
Edge chains are the body's record edges, walked along their curves the way the
chain runs; G1/G2 conditions read the open edge's face on the record with its
exact first and second derivatives (SurfaceEval::derivs, ::second). The face is
built on the record: each side the network surface's boundary row on its knots,
split at the chains' inner vertices into edges over parts of the side's interval
(no knot insertion), each with its straight pcurve; a collapsed side is left out.
boundary_join counts the record's edges. Tests ported.

(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 0013249c48 kernel: Patch of a body's edges is fill's patch with no crown
fill::patch_loop makes the planar face of a certainly planar loop and the patch
otherwise; patch_edges keeps its own copy of neither.

(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 252b2947a1 kernel: mesh bodies built by Body::of_mesh; fuzz booleans have no fallback counts
Mesh distance callers take geom's closest_on_triangle in place of the deleted guard's copy.

(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 e00645ca5e kernel: crate root follows the split, surfaces and SSI ports
coplanar, planar_faces and seam_faces are gone (strategies around the old mesh boolean); their
remaining tests mount from the crate root.

(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 c83bd8f94b kernel: T-spline and offset tests read the body's record
(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 b5a7d52b73 kernel: bridges and surfaces read the body's own record
bridge::{chain, frames, frames_across, chain_closes} and surfaces take
body.record() instead of encoding one; a surface body is Body::from_record of the
canonical record, a stitched one Body::from_smlib_record of SMLib's export, its
history matched to the input record when SMLib's import numbers it alike.
record::attach takes the new form.

(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 5c1b335e1b kernel: bridges read their support faces on the record
The bridge core was already its own geometry; its readings went through truck.
Chains are edges of the body's record (index, direction), measured along each
edge's record curve the way the chain runs; a support face is a record face whose
surface is evaluated with its exact first derivatives (SurfaceEval::derivs) where
truck's were finite differences; the station's parameters come from SurfaceEval's
projection. The bridge face is surfaces::tensor_sheet, and blend_between records
it as new over [a, b]. frames, frames_across and chain_closes take the body and
face index. Boundary patches go through the same bridge. Tests ported.

(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 9b5e0a8b42 kernel: T-spline sheets as record faces; NURBS faces on the record
surfaces.rs gains the record pieces NURBS faces are built from: a NURBS surface
and curve as record geometry, a pcurve along a parameter line, a whole tensor face
bounded by its net's boundary rows and columns (exact for a clamped surface), and
all_new for a face new to an operation. tspline_sheet makes a regular T-spline
that tensor face and an irregular one its Bézier elements, each side split at the
T-points, each edge an exact Bézier piece of its side with a straight pcurve on
every patch it bounds, shared between neighbours. Tests ported to the record.

(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00