Machine-applied by cargo clippy --fix: borrows the compiler dereferences at once, an
unused import, a manual += , an entry() for contains_key+insert, a needless Ok(?),
contains() for iter().any(). No behaviour changes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
mesh memo (one remembered mesh per tolerance), history (a bare body from a record), tests.rs
(no coarse-missing field, lumps for touching shells), outline (the foot found by the planar
faces in its plane), chamfer sides (the rim from the record's edges), seam faces, coplanar
and issue 679 and pinch tests (the boolean is SMLib's: the diagnostics assertions go, every
volume, shell and validity check stays), boolean history (a cut of two pieces through the
boolean), integration tests naming solidcraft_kernel::MeshTolerance.
Deleted, testing internals that are gone: boolean_history_tests' glue_merges_across_the_seam
and faces_pushed_apart (coplanar::glue, boolean_apart), planar_fallback (polybool's
planar_boolean) and bore_union_of_a_bore_in_two_arcs_has_no_history (coplanar::bore_union);
issue_851's the_sphere_at_a_box_corner_is_the_planar_corner_builders (blend_vertex); pinch's
prism_boolean shell check.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The truck reads become record reads: an intersection edge of a moved cut, the fillet
mitre edges sampled with CurveEval, the cache estimate from the record's faces and edge
uses, holed faces by their loops. The drain pads and the coincident-faces booleans keep
their volumes and faces without the boolean diagnostics and the polygon boolean.
Deleted, testing internals that are gone: a_tapered_s_curve_is_cut_into_pieces_that_follow_its_offset
(build::offset_error/offset_splits), planar_fallback_names_the_curved_faces (the polygon
fallback), mixed_loop_blend_guards_selection_and_construction and
loop_chamfer_mixed_arc_and_line_uses_offset_intersections (loopblend),
an_attempt_budget_stops_the_boolean_and_is_shared_by_nesting (with_attempt_budget),
placing_a_body_does_not_turn_its_revolved_faces_again (REPHASED, truck's revolution phase),
and the truck debug runs debug_coplanar_union_rate, debug_truck_sphere, debug_sphere_patches,
debug_sphere_cases, debug_sphere_rotations, debug_cube_sphere_measure, debug_heal_sphere_cut,
debug_coplanar_cylinder_union, debug_drilled_hole, debug_face_param_areas and
debug_revolved_tube_cut (truck_shapeops booleans, build::sphere_patches).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
native.rs's test module keeps its encode/decode, wire-record, hostile-input and appearance
tests. Deleted with the adapter they tested: pcurves_on_planes_are_the_curves_mapped_exactly,
pcurves_fit_curved_faces_within_tolerance, pcurves_of_seams_lie_a_period_apart and
pcurve_pictures, with their helpers (pcurves_of, check_pcurves, check_faces, curved_bodies,
seam_faces, draw). smlib_import_tests count shells on the record; their notes no longer
speak of truck.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
- thin faces: the face pinched against its own edge is a record sheet (sew::assemble) meshed
by the body's mesher; its triangles still cover its boundary polygon.
- trimmed loft faces, loft rails: distances to faces through the record's SurfaceEval.
- untouched faces: edges and in-line stations from the record's edges and vertices.
- intersection curves: the #1252 regression on a record sheet whose edge is a traced
intersection of parallel planes: meshing neither panics nor goes non-finite.
- lumps: shells counted on the record; the certified witness is Brep::compound of its three
bodies, faces known by surface and box.
- Deleted, testing internals that are gone: intersection_curve_tests'
degenerate_intersection_polylines_return_none_without_panicking,
closed_intersection_retains_the_closure_and_spherical_supports and
open_intersection_keeps_endpoints_on_both_planes (truck's IntersectionCurveWithParameters)
and a_result_with_an_edge_that_does_not_evaluate_is_refused (boolean_record::edges_evaluate);
body_lump_tests' unowned_overlapping_and_touching_cavities_are_errors_not_dropped_geometry
and shortcut_clearance_refuses_curved_contact_hidden_between_mesh_vertices (truck shells
joined without regions, separated_lumps) — kept as spheres_apart_join_as_two_lumps — and the
shell-order permutation of nested_cavities (the record names each cavity's region).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
- placement: a rigid placement moves the record and nothing else (regions, shells, loops
with their pcurves, edges and their uses equal; every vertex moved; the identity's
history), on a cylinder whose wall's loop uses its seam twice.
- issue 2005, 616, 674, 1038, 1510, join between caps, regularization protection, history,
mesh memo, display mesh: the truck reads become record reads (shells closed by edge
uses, faces by the record's surfaces, vertices by the record's points, the mesher's own
boundary budget); the nearly-in-plane slab of 1510 is an extruded record body.
- Deleted, testing internals that are gone: issue 616's glue_joins_every_face_the_pieces_share
(coplanar::glue) and the_retry_guard_refuses_changes_away_from_the_tool
(boolean_guard::check_retry); issue 674's partial_contact_does_not_join_tangent_or_separated_faces
(coplanar::imprint_union); issue 1038's hinted_division_matches_the_search_from_nothing
(truck's vendored parameter_division); issue 1510's a_face_close_to_the_plane_but_off_it_is_not_moved
(ops::off_plane). The boolean-diagnostics assertions (no retry, no tool nudge) went with
capture_boolean_diagnostics; the rest of each test is kept.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
solidcraft-smlib is a dependency of every build (it answers NotBuilt without
SMLib), so the SMLib sides of surfaces.rs and blend_smlib.rs no longer sit
behind cfg(feature = "smlib"), and their stub modules go; blend_smlib's tests
run in every build like the rest. This also uses offset_backend::thicken and
the smlib_sweeps curve conversions in builds without the feature, which left
them unused there.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The three refusals of the cornered controlled sweep become the owner's rules:
- an orientation direction turns the section about the corner's binormal like
any sweep, then turns it back about its normal to the direction's frame
evenly along the next run, as a twist (direction_offset: the turn between
the carried section and the direction law's section there);
- guide rails follow a path with corners when each rail has a corner of its
own at every corner of the path, in the plane halving it and by the same
turn about the same axis; the rails are cut there into each run's
(run_rails), anything else is refused with the corner named;
- round a closed path with corners the first run starts from the closing
mitre and the last ends on it; a twist is allowed where the profile maps
onto itself (closing_offset), an end scale is refused.
Each run's station count now follows its own turn, twist included.
solidcraft-smlib is a dependency in every build (it answers NotBuilt without
SMLib), so smlib_sweeps' imp is no longer behind the smlib feature and its
stubs and not_built go; polyhedron calls offset_backend in every build.
Deleted as unused: sweep_path::{closed_path, turn, stations}.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A sweep that twists or scales refused any path whose direction jumps by more
than 1e-3 rad, a branch on the path's shape. It now takes the corner model of
the plain sweep: each smooth run is swept through stations by the laws a smooth
path has (twist and scale running with the length along the whole path, each
run going on from the section the last ended with), and the runs meet at each
corner in a mitre. Turning with the path, each run goes on past its corners as
a prism of its section there (the laws hold still across the mitre: the two
runs' sections meet on the plane halving the corner only when both are the
corner's section) and is cut back to that plane, then turned through the
corner onto the next run; only moving along the path, the runs meet at the
corner's section. The mitre plane is one function for both (mitre_of).
Refused, with the reason, where a control has no meaning at a sharp corner: an
orientation direction (it turns the section by its own turn, not the corner's,
so the two runs' sections don't meet), guide rails (their sections jump where
the path turns), and a closed path with corners (a twist or scale keeps the
last section off the first).
(not built: base in progress; no error in these files)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Intersection::point started its Newton solve from the last point found (a Cell holding both
surfaces' parameters) when that landed near the leader, as truck took a hinted point. The
answer then depended on what was evaluated before, so CurveEval was not Sync, and the
clearance check, which shares a body's DistanceShape (its edges' CurveEvals) across worker
threads, did not compile; with threads it would also have made the result depend on their
interleaving. Each point is now solved from the leader's own point, the path the hint fell
back to, and the unused trace tolerance goes with the hint.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
sheet_hole_cut chose by failure: a hole's drills were tried all at once and, if that was
refused, one by one; each drill was tried as a flat cut-out and, if that was refused (or
machined nothing), as a bore. Now the drill's geometry decides, one path each:
- SheetBody::drilled_panels: the panels a straight drill meets and how square it is to each
(|panel normal · axis|); a drill into a bend is refused, as before. add_bore uses it.
- sheet_drill: square across every panel it meets is Drill::Across (sheet_primitive_cut, a
cut-out or pocket of the flat pattern), along every one into a rim is Drill::Along
(sheet_bore_cut, a bore), meeting no sheet is None, and anything else (square to one panel
and along another, or at an angle) is refused with the angle message.
- The all-at-once pass (sheet_drill_cuts) passes its errors on; its None (the drills not all
square along one axis) still puts the model back and drills them one by one.
- sheet_bore_cut passes add_bore's refusal on instead of answering None.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The boss's post and ribs, the boss's hole, the snap fit's arm and the rest started a few
hundredths of their height inside the material (and the hole and the groove ran on as far
past the face), and the groove's cutter reached past the rim edge into the free side, so no
face of a tool lay on a face of the part. SMLib joins and cuts touching faces exactly: each
tool is now the feature's own shape, from the face (a drafted post or rest sized at the
face, the groove's band the rim's own, free reach 0). The material each adds or removes is
the same.
kernel::rim_band's `free` is now always 0 from the doc.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The kernel has no boolean retries now, nor their diagnostics
(capture_boolean_diagnostics, BooleanDiagnostics, BooleanStrategy), nor the near-coaxial
crescent (coaxial_overlap, coaxial_candidate, with_attempt_budget). What read them goes:
- doc: FeatureResult and the evaluation cache carry no boolean diagnostics, and no "Boolean
retry" warning; the saved model no longer writes them (an older file's are ignored);
- engine: timeline.inspect / feature inspection drop `boolean_diagnostics`; fuzz runs and
the CLI fuzz summary drop their retry counts;
- inspect.interference: each pair is the bodies' Intersect, measured; the near-coaxial
crescent, the by-piece intersection of bodies in several pieces and the unverified notes
go (the command's doc no longer lists near_coaxial);
- inspect.clearance: an overlap is the bodies' Intersect, measured near its region; the pin
tries, the cut-down copies of large bodies (clipped, narrowed), the union cross-check
(union_disagrees, contradicted) and the malformed-part check (plausible) go, and the
measure near the origin passes its move's error on.
Tests: the retry test and the unit tests of the deleted checks are removed; the barrel join
test (tests/boolean_diagnostics.rs, now tests/barrel_join.rs) keeps its geometry checks;
the pin-in-bushing test expects the filleted case measured; assertions on empty diagnostics
and on near_coaxial are dropped; the corpus fixtures lose the diagnostics key and the one
retry warning.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Every lib warning under --features smlib outside the files agents are editing
(assemble.rs, sweep_path.rs) pointed at code nothing calls any more:
- body: shell_nesting;
- boolean_record: of_pair and its Traced alias;
- planar_regularize: the generated-wall regularization (and its branches in the
certified one, which was its only other path); planar_sources:
with_shell_planar_sources;
- plane_fit: plane_through, EdgeSampler, planar_face, plane_frame (the patch is
fill's); only loop_area is left;
- polyhedron: solve3; prism: wall_along; offset: Surf::normal;
- record: regions, region; shell_groups: groups, parents and their limits;
- splitface: side_of_point, Analytic, analytic_face, face_sides, canonical;
- spline_conv.rs, all of it (surfaces builds NURBS records); an unused import in
tess/uv.rs.
The tests of deleted items go with them: prism's wall_along test, the shell
grouping test in body_lump_tests, and the generated-regularization assertion in
regularization_protection_tests.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
split_band_edges_are_seams tested split.rs's splitting of a face that winds around its
surface into two (deleted with the truck reader; the record keeps the face with a seam):
deleted. ImportedBody::file_faces says each body face is a file face.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Each body's record is written directly: a manifold solid B-rep (186) per material region
with its voids, open shells as 514 form 2, faces on the record's exact surfaces and edges
on its exact curves over their intervals, in the STEP form solidcraft_step::write::topology
gives them (one geometry model for both exports). The detour through STEP text and its
re-parse is gone; the maximum coordinate is the largest coordinate written.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
write::topology::layout says which shells make each solid (a material region's outer shell
and its voids) and which are sheets, and outer_loop which loop of a face is its outer one;
the STEP writer uses both, and the IGES writer can too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Import: every solid is read by solidcraft_step::topology into its record and taken into
SMLib as given (step_in/parallel.rs smlib_part), the one path; the truck readers
(step_in/brep.rs, split.rs, geom.rs) are deleted. Placements are column-major 4x4 matrices
from solidcraft_step::read placements; an instance is its part's record moved there
(ops::transform_matrix), or the very part at the identity. Assemblies, names, colours,
shared displays and the public API are unchanged. step_orientation_errors lists the faces
the STEP reader turns over (their loops disagree with their same_sense).
Export: each body's record is written by solidcraft_step::write::topology as the exact
B-rep (solids per material region, open shells as a surface model, the record's pcurves);
step_out writes products, units, colours and assemblies around it with Writer. The truck
writer and every post-processing pass (split-face merging, sheet trimming, analytic
recognition, short-edge collapse, the re-read fallback) are deleted. The context's
uncertainty is the loosest record tolerance exported.
Tests: ported to the record API with their assertions. Deleted, as tests of deleted
internals: conic_tests extruded_ellipse_seam_uses_profile_angles_for_oblique_sweeps and
conic_arcs_are_exact (truck geometry reader), tests offset_surface_analytic_geometry_and_
orientation, offset_surfaces_nested_and_hostile and periodic_knot_bsplines_are_read_on_
their_domain (truck geometry reader), corpus_truck_and_schema_4_counts (truck comparison);
the orientation counter asserts (crate::body::ORIENTED, gone with orienting by mesh).
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A placed revolution is written exactly whenever its placement maps revolutions about the
axis onto revolutions (one scale across the axis, another along it, then a rotation or
reflection), its profile placed with it; a conic profile stays a conic under a similarity.
A void's CLOSED_SHELL keeps the record's sides (normals out of the material, into the void)
through an ORIENTED_CLOSED_SHELL .T., as SolidCraft has written voids. Reader::frame reads an
assembly placement (AXIS2_PLACEMENT_3D, or _2D in the XY plane).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
write::topology writes each material region as a MANIFOLD_SOLID_BREP (BREP_WITH_VOIDS
with its voids as ORIENTED_CLOSED_SHELLs), open shells as a SHELL_BASED_SURFACE_MODEL,
faces as ADVANCED_FACEs on their exact surface with FACE_OUTER_BOUND/FACE_BOUND of
EDGE_LOOPs and VERTEX_LOOPs, edges as EDGE_CURVEs on their exact curve over the record's
interval, and the record's exact pcurves as PCURVEs of SURFACE_CURVE/SEAM_CURVE. A record
surface's (u, v) map linearly onto STEP's (planes on their orthonormal frame, narrowing
cones turned over, revolutions angle first), and pcurves go through the same map.
Writer::add_distinct writes topology entities unshared. topology::Solid lists the faces
the reader turned over (their loops disagree with their same_sense).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
doc's FeatureResult has no boolean_diagnostics any more (truck's Boolean
retry reports, gone with truck; SMLib's boolean has no retries). The
timeline.inspect and doc.inspect replies drop the key.
Tests of the removed reports: tests/boolean_diagnostics.rs is deleted (it
checked truck's retry events and their survival through the cache, undo and
reopen); the assertions that a feature's report had no events go from
features_more_tests, patterns_tests, hole_face_tests and tests/rim_cut (the
rest of each test stays). The CLI corpus's expected replies
(move-bodies, issue-489-stacked-join, issue-616-lid-ribs) drop the key; the
issue-616 one listed a planar_fallback event. docs/robustness.md: its
section on retries becomes one on SMLib's booleans, which have none.
Left to the blends work: engine fuzz.rs (its retry-event counts) and
clearance/interference (capture_boolean_diagnostics, coaxial_overlap,
with_attempt_budget).
Not built: base in progress (kernel-smlib/no-truck 66ab6b7f does not build).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The kernel's BooleanDiagnostics and capture_boolean_diagnostics are gone
with truck: they reported the retries and fallbacks truck's booleans took
(shifted operands, refined tolerances, a planar fallback), and SMLib's
boolean has none. Model::evaluate ran every feature inside
capture_boolean_diagnostics, warned with its summary and kept the report
in FeatureResult, its cache entry and the saved model ("diagnostics").
The feature runs as it is, FeatureResult and CachedEval lose the field, and
the saved model neither writes nor reads "diagnostics" (a model saved with
it still opens: the key is not looked at).
Callers outside doc that read FeatureResult::boolean_diagnostics change
with it: engine's timeline.inspect reply here; engine's fuzz report and
clearance/interference belong to the blends work.
Not built: base in progress (kernel-smlib/no-truck 66ab6b7f does not build).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The vendored truck-geometry they pinned is gone; the same finite-difference checks, degrees
2 to 5 and a rational surface, now pin SurfaceEval::second, which every curvature the kernel
reads comes from.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The helpers read every face of the fill as a record surface over its box, the loops'
(u, v) polygons from their exact pcurves, the rim from the free edges and curvature from
SurfaceEval::second; check_face takes the fill's faces (one, or the patches about a centre)
whose free edges lie on the body's edge curves. Expectations changed by the coordinator's
decision on loops of five or more edges: the pentagon fills as five patches (each rim edge
in halves, five spokes: at least 15 edges), the hexagon through a point as six patches with
18 edges. Every other assertion is kept.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
finish lays out the faces left and added (each stored relative to its surface's natural
normal with its pcurves and box, now one function, stored()), the source's shells and
regions (a region whose outer shell lost every face gone) and the edges and vertices as
they are, then calls Brep::canonical; its own ordering walk is deleted. check_geometry
and the face and edge maps are kept.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
sweeps_along_3d_paths asserted at most 8 faces for a 41-point path: one wall
per profile segment fitted through the points, which the exact construction
no longer makes (no curve is fitted through samples). A point path is the
polyline its points make, swept line by line and mitred at each point, so the
circle's two arcs give two walls along each of the 40 lines, and two caps:
82 faces. The volume check stands (a mitred sweep of a profile centred on its
path keeps area × length).
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
An Iso link along an explicit direction on a solid now takes
kernel::face_section_along, the face cut by the plane holding its exact normal
and the direction, instead of the triangles' section. With the projection, the
u/v iso curves and the base's exact intersection edges, every linked 3D curve
on a solid keeps its exact curves (Wire::exact); curves that meet end to end
become one wire (joined_wires, shared by the projection and the iso curves).
Mesh bodies, which have only their triangles, keep the triangle-based curves.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
face_section_along cuts a face through a point by the plane that holds the
face's exact normal there and a direction (Brep::face_section): the iso curve
"along a direction" of a link, as record curves on their intervals, the
B-splines SMLib made. The projection and the section share the picking reach,
the curve tolerance, the error words and the conversion to record curves.
(Intersection links take the base's meeting_edges, SMLib's imprint.)
lib.rs (coordinator): export point_path::face_section_along.
(not built: base in progress; no error in these files)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Brep::face_section (smlib_face_section: one face cut by a plane) hands back
the NURBS SMLib made with their intervals, through one reader of smlib_curves
(take_curves) shared with project_curves. The face-pick errors map to
NoMatch/Ambiguous in one place (picked). SMLIB_REV at fork eedfa51.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
LinkSource::Iso with `u` or `v` on a solid now takes kernel::iso_curves: the
face's isoparametric curve through the point, exactly, cut by the face's
loops, each piece a wire with its exact curve. An explicit direction (the face
cut by a plane: an intersection curve, waiting for SMLib's exact SSI curves)
and a mesh body still use the triangles' section.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
iso_curves gives the isoparametric curve of a body's face through a point, along
its first or second parameter, as record curves: on a B-spline surface the
surface's own row at the point's other parameter (each control point its
column evaluated there, homogeneous, so exact for rational nets), on an
analytic surface its line or circle. It is cut where it crosses the face's
loops: each crossing solved on the loop's pcurve itself (bracketed on samples,
then bisected on the pcurve), the pieces between kept where their middle lies
inside the face (even-odd over the loops), neighbouring inside pieces joined.
A revolved surface record is not supported yet.
lib.rs (coordinator): export point_path::iso_curves.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A sketch curve linked onto a face (LinkSource::OnSurface) was projected onto
the face's display triangles, so the wire was a polyline on the mesh. On a
solid it is now kernel::project_onto_face of the curve's exact segments, along
the sketch normal turned toward the face: the wire's exact curves are the
B-splines SMLib made, pieces meeting end to end one wire, the points sampled
from them for display. A mesh body, which has only its triangles, is still
projected onto them.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
project_onto_face projects sketch segments along a direction onto the face of a
body at a point through Brep::project_curves (smlib_project_curves), each
projected piece the B-spline SMLib made, returned as a record curve
(RationalSpline) on its interval, within a millionth of the body's size.
lib.rs (coordinator): export point_path::project_onto_face.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The base no longer links truck, so build.rs and sweep_path.rs drop what was
kept only for other modules: chain and profile wires, the profile face,
loft wires and their ruled and smooth faces, across/section_parameters, the
cubic interpolations and NetFit, the uniform wires, the six sphere patch
faces, and sweep_path's ruled_sheet and smooth_sheet with the station helpers
only they used. Their callers switch to planar_face_record,
smlib_sweeps::{chain_curves, body_from_record, sphere}, sketch_record_curve,
the SMLib sweeps with open ends, and bspline::CurveN::interpolate.
offset_backend and polyhedron pick faces through provenance::closest_on_tri,
boolean_guard being gone.
Callers left to switch (other ports): surfaces.rs, loft_rails.rs,
surface_offset.rs, surface_ruled.rs, step_in/brep.rs, trimmed_face_mesh_tests.rs.
(not built: base in progress; no error in these files)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The FFI for smlib_project_curves and the smlib_curves result (fork 5f9af50),
and the safe call: a curve list projected along a direction onto the picked
face, back as Curve::Nurbs with each curve's interval. SMLIB_REV at 5f9af50
(fork integration head 1934b57 + the untrim status fix + the projection shim).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Rulings that are constant, or keep their angle to an arc's axis, move the edge by
an affine map: the far edge is the edge's exact image and the strip exact. Any
other ruling field (a normal turning along a free-form face, a tangent carried
round a free-form curve) ends on an offset curve, which has no exact NURBS form
in general: SMLib holds one only implicitly (SmOffsetCurve) or approximates it
(NL_CrvOffset.h, N_CrvOffsetApprox), and its ruled surface (SmApiCreateRuledSurface)
takes two B-spline curves it is given. Such a strip was a B-spline fitted within
1e-3; it is now refused by name. The fitted-strip test checks the refusal.
The round-corner cases count one face per corner: SMLib's revolve makes a quarter
turn one face, where truck's cone builder made two (12 faces and joins, now 8).
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
SMLib is the only kernel now. cargo xtask kernel-cases ran every case once
per kernel asked for (--kernel default|smlib|both), setting
SOLIDCRAFT_KERNEL per run, and wrote a column per kernel; solidcraft-cli no
longer reads that variable.
The rig and the ladder run each case once, through solidcraft-cli built with
--features smlib (cargo run passes it), and report one result per case:
--kernel and the env var are gone. Each run has an output folder (--out,
default target/kernel-cases, target/kernel-ladder for the ladder) holding
results.json (every case's full result, which --results used to write on
request) and dumps/<area>-<case>/: every case runs with
solidcraft-cli kernel-cases --dumps=<out>/dumps, so a failed SMLib call
leaves its inputs for replay.
The ladder's golden holds one entry per case: golden.json is the last
recording's smlib entries, which predate SMLib running every case (its
reason says so); record it again after the first SMLib-only run.
docs/kernel-cases.md (until the next run regenerates it),
tests/kernel-cases/README.md, docs/kernel-smlib-sweeps-shell.md (its truck
column and comparisons dropped), xtask's and solidcraft-cli's usage text:
one kernel. Nothing was run.
clippy -p xtask --all-targets: clean.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The helpers that read a face's surface, its edges and its seam shape read the record
(SurfaceEval, CurveEval, matchsurf's Patch) instead of truck faces; every assertion is
kept.
(not compiled: the kernel's test target waits on the base's step_*, build, sweep_path and
surface_ruled ports)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Before sewing, each edge of one input is split exactly (Brep::split_edges) at every vertex
of another input that lies on it within the stitch tolerance away from its own ends, so a
patch whose corner meets a body's edge part way (the five-plus-sided fill's midpoints)
sews with no T-junction. The pieces carry their edge's history. The search is the nearest
of 64 samples refined by golden section, over the vertices within a chord's reach of the
edge's samples. Nothing else in stitch changes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Each piece keeps the edge's curve on a sub-interval, a new vertex sits on the curve at each
split, every use becomes uses of the pieces with its pcurve cut at the same parameters
(bspline::segment), wire edges likewise; the result is in canonical order with each
edge's source edge. What a sheet needs so that another's vertex on one of its edges is a
vertex of both.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
sew::assemble and surfaces::Parts::canonical each lay out their record as its parts stand
(regions, shells, faces, edges with no uses, vertices) and end in Brep::canonical; their own
ordering walks are deleted. spline_conv::tensor_face (no callers left) is deleted in favour
of surfaces::tensor_sheet, and fill's copy of the spline surface record in favour of
surfaces::spline_surface.
(not type-checked: the kernel stops at name resolution in step_*, build, sweep_path and
surface_ruled)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt