Commit Graph
1591 Commits
Author SHA1 Message Date
jyvikoandClaude Opus 5.5 25175d68ca Merge #8526 (brett19/solidcore e30cfd2ac): solidcore as the default kernel, C++ SMLib behind --features smlib
Three conflicts:
- crates/smlib flat.rs and export.rs: #8526's export copies the C++
  arrays by id range; the ranges now run to the ball-patch arrays
  (FACE_DEFINITION_REAL_COUNT, FACE_DEFINITION_REALS), with
  WIRE_EDGE_NURBS_FORM (35) and FACE_DEFINITION_REAL_COUNT (36) both kept.
- tests/KNOWN_FAILING_TESTS: solidcore's lines and develop's, each test
  once; tests/KNOWN_FAILING_TESTS.smlib takes develop's SMLib a18bbe5 lines
  too. The first full run trims both.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 16:42:23 -05:00
jyviko c533128ebe Merge remote-tracking branch 'upstream/main' into merge-main-develop
# Conflicts:
#	crates/doc/src/eval.rs
#	crates/doc/src/name_lookup.rs
#	crates/doc/src/sheet.rs
2026-11-02 16:28:15 -05:00
jyvikoandClaude Opus 5.5 5f4d700610 After the merge with main: its new code on develop's exact bounds, types and thread fields
- The sheet cut's cull (#10301) and the tapped wall's (#10227) use each
  body's exact box (`exact_box`), not its display mesh.
- model.threads replies with develop's thread fields: form, hand (right,
  left or both) and starts.
- surface.boundary's schema checks a network curve's continuity as the
  handler does, and words a list entry's error as it does.
- Main's new tests take develop's Hole fields and world_state's Result.
- mesh-decisions: contact_sweep's triangle check is now `depth` (main
  split `hits`).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 16:19:46 -05:00
jyviko 98a6f591eb Merge remote-tracking branch 'upstream/main' into merge-main-develop
# Conflicts:
#	crates/doc/src/eval_more.rs
#	crates/doc/src/placement_reuse.rs
#	crates/engine/src/cmd/contact_sweep.rs
#	crates/engine/src/cmd/diagnostics.rs
#	crates/engine/src/cmd/inspect.rs
#	crates/engine/src/cmd/sheet_tests.rs
#	crates/engine/src/cmd/sketch_inspect.rs
#	crates/engine/src/cmd/view_navigation.rs
#	crates/engine/src/schema/diagnostics.rs
#	crates/engine/src/schema/diagnostics_tests.rs
#	crates/engine/src/schema/mod.rs
#	crates/ui-egui/src/sketch_line_arc.rs
2026-11-02 15:54:06 -05:00
bherbruckandClaude Opus 5.5 59ffd38019 Timeline: selecting a joining extrude no longer lights round walls an earlier feature made (#11263) (#11286)
A join that reports no history names faces by comparing the meshes before and
after. When the join makes the body bigger, round walls are meshed differently
and miss their old mesh at the naming tolerance, so they were named as the new
feature's faces. A curved face with no match now looks again within the two
meshes' chord tolerances. An edge name saved while a wall had the wrong name
falls back to the edge at its stored point.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 19:40:17 +00:00
semmelrindeandClaude Opus 5.5 5e54681c80 Sketch: instances stepped in from an arc stop where the arc runs out, not turn round (#11068)
* Sketch: instances stepped in from an arc stop where the arc runs out, not turn round

Each instance after the first takes its side from a point one more step
past the last one. Stepping toward an arc's centre past an arc smaller
than the distance, that point lands beyond the centre, and the side was
read by comparing the point with the two offsets at the full distance:
the one toward the centre doesn't exist there, so the other won and the
next instance went back out onto an earlier one. The side is now read a
hair from the curve, where both offsets exist, and the point stops
halfway to the centre. The arc then runs out of room and the command is
refused there, as for a ring.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Offset side: read off the picked line or arc itself

A tiny step compared at large coordinates rounds away, and an arc left
smaller than that step by an earlier instance still has no offset toward
its centre: both turned the side round. A line's side is now its
half-plane and an arc's inside or outside its circle, as a circle's
already was; other curves compare both offsets' distance as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 19:40:16 +00:00
Mateusz SychandMateuszSychXpl 7bdaec8f4d Joints: large assemblies with many closed loops no longer leave a new joint in conflict (#9687) (#11146)
* claim: #9687

* Joints: Edit Joint and Unsuppress meet a conflicting loop joint as Joint does (#9687)

joint.create (#10371) turns an angle a half turn when a new loop-closing joint
comes out as a conflict, so a second planar joint whose faces point the same way
meets. joint.edit never did, so a design saved before that (the report's rail on
two planar joints) kept the conflict however the joint was edited, and a joint
unsuppressed after its part was turned away stayed one too, though Move's hint
says to edit the conflicting joint.

An edit that places the joint again (type, offset, angle, flip, a side, or
unsuppressing it) now tries the same half turns. A rename alone moves nothing.

* Joints: a loop group over the solver's values still moves the loops that need to (#9687)

A frame held by many planar joints (the report's printer: six planar joints
between two profiles, and more) ties its loops into one group through the
shared values. Past MAX_LOOP_VALUES (64) such a group was only checked, so a
new joint closing a loop in it (Joint35, the rail on the 450 mm profile, which
took the group from 63 to 69 values) stayed a conflict, and nothing in the
group could be driven or dragged any more.

Such a group now moves the values of the loops that need to move, those open
at the start or reading a held value that moves, when they are few enough,
while every loop of the group stays a residual, so the others stay closed.
Groups within the cap solve as before.

* Joints: closed loops through a moving value follow on their own closing joint (#9687)

In a loop group over the solver's values, a closed loop that runs through a
value the open or driven loops move (a part slid on one planar joint and held
by a second) kept its closing joint's values, so its gap opened and the solve
failed. Those closing joints' values move too: they are on no tree path, so
freeing them pulls in no further loop.

* Joints: loops a motion link ties to a following closing joint follow too (#9687)

A followed closing joint whose value a motion link sets moves the value its
link chain starts from; closed loops through that value now follow on their own
closing joints as well, until no more do or the values pass the solver's cap.

* Joints: say what the narrowed loop solve does not find (#9687)

* Joints test: measure the peg's 30 degree turn from where the loop left P0 (#9687)

---------

Co-authored-by: MateuszSychXpl <151755914+MateuszSychXpl@users.noreply.github.com>
2026-11-02 19:38:17 +00:00
brett19andClaude Opus 5.5 e30cfd2acf Tests and the rig for a default build without the C++ kernel
- step_in's a_solid_smlib_refuses_with_its_faces_is_refused_not_meshed assumed
  a build without SMLib has no kernel; on solidcore the cube imports, so it
  now runs only under SOLIDCRAFT_KERNEL=smlib and says it skipped otherwise.
- rounds_on_the_871_part and mitred_rounds_follow_a_moved_top compare with
  the C++ kernel (listed in tests/KNOWN_FAILING_TESTS) when it is built; their
  solidcore half runs as *_on_solidcore on a build without it, so each list
  entry is graded only where its comparison runs.
- kernel-cases without --cli builds the CLI once (with --features smlib when
  a run asks for the C++ kernel) before the cases, so the first cases don't
  spend their timeout compiling it.
- rustfmt for diagnostics.kernel's message.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEtwSrdwZxqTQp5MfnU
2026-11-02 12:30:22 -07:00
semmelrindeandClaude Opus 5.5 861fb8ad56 Hole: a countersink cuts nothing outside its diameter above the face (#5041) (#8261)
The countersink tool was a cone started at the run-on height above the
face, so above the face it was wider than the countersink and kept
widening: a wall or step just past the rim was notched. The tool is now
one revolved profile: the cone from just above the face down into the
hole, and above it a cylinder of the countersink's own diameter. The cone
is the profile's first segment, so its face keeps the name csink:side:0.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 18:55:37 +00:00
leValdemar19andClaude Opus 5.5 f7d66d2b5b Sketch Break: break at a shared point separates the curves that meet there (#7410) (#7950)
* claim: #7410

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Sketch Break: break at a shared point separates the curves that meet there (#7410)

Two lines drawn as one chain share their corner point. There was no way to pull them apart:
Break there said "nothing to break at there", and deleting the point deleted both lines.

sketch.break aimed at a point where the picked curve ends and another curve also meets now
gives the picked curve its own end there (`<curve>.start` or `.end` when that id is free), at
the same place: both curves stay where they are and are no longer joined. The Break tool
snaps a click on the corner to that point, so clicking it works the same way.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 18:53:04 +00:00
austin62jakeandClaude Opus 5.5 780c1163f9 Typed schemas for the crash report commands (#10909) (#10910)
* claim: #10909

* Crash report commands: input and output schemas (#10909)

diagnostics.crash_reports, diagnostics.crash_report,
diagnostics.crash_reports.clear and diagnostics.crash_test get typed
contracts and reply types in schema/diagnostics.rs and leave
unconverted.txt. Strict now refuses an `id` that isn't text on clear,
which the handler reads as no id and so deletes every report.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-02 18:45:04 +00:00
austin62jakeandClaude Opus 5.5 fa1eb57e3b Typed schemas for the standard views and Normal To (#10898) (#10899)
* claim: #10898

* Standard views and Normal To: input and output schemas (#10898)

view.front, view.back, view.left, view.right, view.top, view.bottom,
view.isometric and view.normal_to get typed contracts (an optional
`camera`, read by the new shared CameraParam type with the commands' own
reader) and a CameraReply output, and leave unconverted.txt.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-02 18:44:40 +00:00
semmelrindeandClaude Opus 5.5 6602ab823f Typed schemas for Undo, Redo and the checkpoints (part of #2829) (#10945)
edit.undo, edit.redo, edit.checkpoint and edit.restore_checkpoint get
input and output schemas in schema/edit.rs: the first three take no
keys, the last takes `checkpoint` (with the handler's message for a bad
id) and `forget`. The handlers build their replies from the reply
types. Their lines leave unconverted.txt.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 18:44:14 +00:00
PapaEcho ccdb470e01 Sheet metal rules: typed input contracts and replies (#6581) (#10921)
* claim: sheet rule contracts (#6581)

* feat(engine): add typed sheet-rule contracts (#6581)
2026-11-02 18:43:19 +00:00
austin62jakeandClaude Opus 5.5 a54d0517f7 Typed schemas for the local library commands (#10938) (#10939)
* claim: #10938

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Library commands: input and output schemas (#10938)

library.inspect, library.export and library.apply get typed contracts
and reply types in schema/libraries.rs and leave unconverted.txt. The
handlers' own serde parameter types move there and become the
contracts, so the contract is exactly what each handler reads; the
catalog, provenance and apply result schemas are written by hand, since
solidcraft-io doesn't use schemars.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-02 18:43:07 +00:00
austin62jakeandClaude Opus 5.5 7015c296ea Typed schemas for List Edges, List Faces and List Threads (#10942) (#10943)
* claim: #10942

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* List Edges, List Faces and List Threads: input and output schemas (#10942)

model.edges and model.faces take a typed `body`; model.threads takes no
parameters. Their replies are built from ModelEdges, ModelFaces and
ModelThreads in schema/inspect.rs, with the same JSON as before, and the
three commands leave unconverted.txt.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-02 18:41:09 +00:00
austin62jakeandClaude Opus 5.5 b73eb6c243 Typed schemas for the curvature comb, minimum radius, isocurve and centre of mass commands (#10949) (#10950)
* claim: #10949

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Curvature comb, minimum radius, isocurve, centre of mass: schemas (#10949)

The four analysis commands get typed contracts and reply types in
schema/sketch_inspect.rs and leave unconverted.txt. Each point list has
its own type with its handler's messages and reads only as many points
as the handler does; `count`, `density` and `scale` read numbers as
params::num does. The replies are built from the types, with the same
JSON as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-02 18:40:25 +00:00
austin62jakeandClaude Opus 5.5 38cc3507db Typed schemas for the configuration table, rules, activate and preview commands (#11059) (#11060)
* claim: #11059

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Configuration table, rules, activate and preview: schemas (#11059)

config.table, config.rules, config.activate and config.preview get typed
contracts and reply types in schema/config.rs and leave unconverted.txt.
A new `table` builds the table from ConfigTable; show and the activation
build their replies from it, so the unconverted config commands still
return the same JSON.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-02 18:40:10 +00:00
austin62jakeandClaude Opus 5.5 90e30126ea Typed schemas for Boundary Surface (#11083) (#11084)
* claim: #11083

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Boundary Surface: input and output schemas (#11083)

surface.boundary gets a typed contract in schema/surface_boundary.rs and
the shared FeatureResult as its output, and leaves unconverted.txt. One
struct holds both forms; each key reads as the handler reads it, with
its messages, and `u` and `v` check their items where the handler does
without the design, index included.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-02 18:39:56 +00:00
austin62jakeandClaude Opus 5.5 e3bbd8258a Typed schemas for Loose Ends and Tie Loose Ends (#10959) (#10960)
* claim: #10959

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Loose Ends and Tie Loose Ends: input and output schemas (#10959)

sketch.loose_ends and sketch.loose_ends.tie get typed contracts and
reply types in schema/sketch_ends.rs and leave unconverted.txt.
SketchTarget reads `sketch` as sketch_store::target does and PointIds
reads `points` as the tie does, each with the handler's messages. The
replies are built from the types, with the same JSON as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-02 18:39:20 +00:00
austin62jakeandClaude Opus 5.5 0f8b971ef0 Typed schemas for Bill of Materials (#11075) (#11076)
* claim: #11075

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Bill of Materials: input and output schemas (#11075)

assembly.bom gets a typed contract and reply types in schema/bom.rs and
leaves unconverted.txt. Each key reads as the handler reads it, with its
message; the reply is built from Bom, BomRow and BomChild, in the old
field order, so the reply and the files it writes are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-02 18:38:30 +00:00
NOWN-DEVandClaude Opus 5.5 9432cdfee8 Sheet metal: material joined in the plane of a panel is kept (#6843) (#6855)
* claim: #6843

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PsiqyXWBFGTCX9J51bhysc

* Sheet metal: material joined in the plane of a panel is kept (#6843)

An extrude join through sheet metal went through the generic boolean:
the body grew, but the sheet model didn't, so the flat pattern, DXF and
bend table were refused, and the next sheet feature (a refold) dropped
the material ("what ... changed is not kept").

An untapered extrude join one sheet thick in the plane of a panel (the
base or a flange's panel, unfolded or folded) now joins the sheet model:
each region of its sketch becomes part of the one panel it is one piece
with, apart from every bend zone and the other panels, so the flat
pattern, its DXF and a refold keep it, and it follows its sketch's
parameters as a cut made there does. Cut-outs it covers are filled. A
join of another depth, out of every panel's plane, touching a bend zone
or another panel, or over a pocket, label, bore or perforation keeps the
generic path and its warning.

The extrude records its sketch plane and depth for a join too (its
profile grows into the material it joins, so it never counted as
untrimmed). The test that refused a joined tab beside a plain base now
refuses a block standing on the sheet instead; the tab is kept.

Fixes #6843.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 18:31:33 +00:00
Mateusz SychandMateuszSychXpl dadefec702 Joint dialog: Find Limits fills the limits from where parts collide (#5968) (#7047)
* claim: #5968

* Joint dialog: Find Limits fills the limits from where parts collide (#5968)

joint.find_limits sweeps each value of a joint both ways from where it is,
on a copy and with its own limits left out, and answers where the parts it
moves first touch another part, where a closed loop stops closing, or that
nothing is met within a turn (angles) or the parts' reach (distances).
Edit Joint's Limits section gets a Find Limits button that runs it on the
joint as the dialog has it, off the window thread, and fills the rows.

joint.sweep now tells touching bodies apart from the other bodies of the
same two parts: on the Hinge Assembly sample the pins touch where it starts,
and the plates used to pass through each other unnoticed.

* find_limits: read the session only

* find_limits: a joint with nothing to meet, edits during a search, tiny ranges

* find_limits: keep touching at the start per pair of parts

Per body, the Hinge Assembly sample's plates, which only come flush in
the end plane the two leaves share, stopped the search. The leaves never
pass into each other: the sample's answer is a whole turn.

* find_limits: touching boxes cost no collision work; stale results and rounding

* find_limits: each pair of bodies of resting parts held to its own depth; loops without bodies

* find_limits: a 32-bit budget it can pass, a repaint with the result, a bad form says so first

* find_limits: each pair of resting bodies gets its own margin

* find_limits: Arabic, Hebrew and Vietnamese strings (complete catalogs on main)

* find_limits: search the joint with Edit Joint's side picks

Edit Joint now keeps the joint's sides as picks in its inputs, and its OK
commands compare them with what it opened on. Built without them, the
commands Find Limits applies first asked for the sides again, so every
search failed.

---------

Co-authored-by: MateuszSychXpl <151755914+MateuszSychXpl@users.noreply.github.com>
2026-11-02 18:28:28 +00:00
686056e4de Opening: a design saved by 0.24 opens with its sketches in later versions (#8151) (#10379)
* claim: #8151

* Opening: a design saved by 0.24 keeps the body a Join To Object runs to (#8151)

Since 0.24.1 a Join extrude To Object also joins the body it runs to
(#6424). Designs saved by 0.24.0 and earlier were built without that,
so on 0.25 the reported box swallowed its lid: the lid's sketch, the
holes, the cut and the moves after it failed.

An extent may now save `to_body_apart: true`, which leaves that body
apart. One pending format change sets it on every Join extrude To
Object of a design of format 39 or older as it opens; designs of
format 40 and later keep the join. Editing the extrude keeps the field.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Markus Kaltenbrunner <kaltenbrunnermarkus@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 18:13:04 +00:00
brett19andClaude Opus 5.5 5a93e6c4d2 Make the C++ SMLib kernel opt-in at build time (feature smlib, off by default)
solidcore, the pure-Rust kernel, is always built and stays the default. The
`smlib` feature (apps, engine, kernel; solidcraft-smlib's `native`) now has
to be asked for to compile and link SMLib: the app, the CLI and the web app
drop it from `default`, and solidcraft-gpu's dev-dependency no longer forces
it on. Without it no C++ toolchain, fetch-smlib.sh, prebuilt or build.rs work
is needed.

On a build without it, asking for the C++ kernel (SOLIDCRAFT_KERNEL=smlib,
diagnostics.kernel, the rig) is refused with Error::NotBuilt, which now says
"this build doesn't include the C++ SMLib kernel; build with --features
smlib", and SOLIDCRAFT_KERNEL=smlib logs that once. `cargo xtask
kernel-cases` builds the CLI with --features smlib only when --kernel smlib
or both asks for it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEtwSrdwZxqTQp5MfnU
2026-11-02 10:56:02 -07:00
semmelrindeandClaude Opus 5.5 d7ad69e64f Pattern and Mirror: a hole placed by edge distances can be copied (#8055) (#8231)
A pattern or mirror replays its source hole's definition, so a hole with
reference edges finds its centre again from them. That happens after the
hole is drilled: through the part, the centre is then in the opening, and
the check that the centre lies on the face refused every copy. The replay
now skips that check; placing the hole itself still makes it.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 17:16:51 +00:00
jyvikoandClaude Opus 5.5 8f0c79b209 After the merge: main's two new tests take world_state's Result, as the rest of their files do
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 10:30:35 -05:00
jyvikoandClaude Opus 5.5 6f7e51acb5 After the merge: split_move's Result reaches its callers; to_local's duplicated move check goes
`frames::split_move` returns a Result on this branch: an unplaceable model is an error, not a silent no-split.
- Move/Copy of a component (main's #9914) propagates it, as its other calls do.
- `to_local` had the solid.move check twice after the merge (brett's Option one and ours). Ours stays, after the no-picks/not-placed return.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 10:26:30 -05:00
jyvikoandClaude Opus 5.5 a840c9cd31 Merge main (01b592e0c): its 20 commits since brett's sync 5
Conflicts:
- doc/eval.rs: ours. Main's #6452 adds a `copy` flag so a pattern's or mirror's copy skips the join-end trimming. This branch has no join-end trimming, so the flag has nothing to switch, and its parameter is removed rather than kept unused. #10698's exact cone and torus normals merged cleanly.
- doc/sheet.rs, engine/cmd/sheet_tests.rs, gpu/tests.rs: both sides added beside each other; both kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 10:14:29 -05:00
jyvikoandClaude Opus 5.5 0510de7e2d Merge brett19/smlib (e1d532d90, sync 5): main's and develop's latest through brett's branch
Conflicts, resolved hunk by hunk:
- main's mesh-based changes stay out:
  - #10303's `beyond_cylinder_reach` (eval_thread);
  - #8634's `cut_end_past_face` (eval);
  - #9009's mesh surface-patch pick in `project3d::part_of`, which would add a mesh decision.
- frames: `split_move` keeps propagating `world_state`'s error, not swallowing it.
- surface_analysis and eval_cost_tests: the same code; our side.
- KNOWN_FAILING_TESTS: our #9107/#8634 reasons; brett's new `a_hole_wider_than_the_part_says_it_removes_all_of_it` (main's #10701 on SMLib); the mirrored-mesh test known-failing until the mesher moves to solidcore.

No excluded symbol came back (`beyond_cylinder_reach`, `cut_end_past_face` and the rest, counts unchanged), and no truck dependency.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 10:13:30 -05:00
RayandClaude Opus 5.5 f6e932f61a Rounded Rectangle: corners take parameter expressions, as a 2-point rectangle's do (#10956)
`sketch.rectangle.rounded` read `p0` and `p1` with `req_vec2`, so a corner typed as an
expression (`["W / 2", "H / 2"]`) was refused with "`p0` must be a point [x, y]", although the
2-point rectangle it hands the corners to already places expression corners and keeps them
following their parameters. The corners are now read with `corner_arg`, as the 2-point and
center rectangles read theirs; the worked-out values still check the radius against the sides.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 14:10:17 +00:00
NOWN-DEVandClaude Opus 5.5 e33b8cfb07 Sheet metal convert: trays made in SolidCraft convert back (#7529) (#7580)
Convert to Sheet Metal refused a tray made with SolidCraft's own sheet metal, exported and
imported again: its walls run on past each bend's end (notch, tear and round corner reliefs), so
the edges beside the bend cylinder's edge never reach the other face's plane and the face could
not be trimmed ("a face beside a chamfer picked as a bend does not reach the face across it").
Where that edge is round or runs on along the bend's line, the face now keeps its corner and
steps down square to the other plane, a step the bend's setback takes up again; the inset drops
an edge the setback leaves shorter than the tolerance.

Test: trays_of_its_own_sheet_metal_convert_back (notch, tear and round, the walls made in one
flange feature, and notch and round with the short walls in a second one): the volume, the flat's
size and outline area and every bend's length are the source's.

Fixes #7529.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 14:04:39 +00:00
Dahak BuildsandDahak Builds 768dc253dd Fix mirror/pattern feature copy dropping bottom slice on hollow parts (#6452) (#7994)
* claim: #6452

* Engine: a pattern or mirror copy of a join keeps its ends as drawn (#6452)

The copy's tool is rebuilt against the current state, which already holds
the source feature's own material; the embedded-join-end trim (#2059)
read that material as the target already filling the copy's bottom band
and trimmed it away before the copy matrix was applied. Mirroring or
patterning a join on a hollow part silently lost the floor-level slice.
Copies now skip the trim: their ends are where the source drew them.

* chore: re-trigger duplicate PR check

---------

Co-authored-by: Dahak Builds <dahakbuilds@users.noreply.github.com>
2026-11-02 14:03:53 +00:00
dudedagger42andClaude Opus 5.5 1d98b59883 Sketch Break: a length becomes the distance between the old ends; no piece of no length (#6826) (#6834)
Breaking a dimensioned line left the length on the first piece, which the solver stretched
back to the whole length, skewing the line. A cut on (or a hair from) an end, as where a tangent
arc meets a line, made a zero-length piece with its coincident and collinear ties every time
Break was clicked there.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 14:03:42 +00:00
Homero ThompsonandClaude Opus 4.8 6649cf4cfe Project: a refusal that names no body names the kind alone (#10626) (#10859)
The refusal of sketch.project ended in "face of " with nothing after the
"of" when the reference named no body: a picked face, edge or vertex is
found by its geometry, so the body it belongs to is not in the reference.

LinkSource::describe() now drops the "of <body>" when there is no body to
name and names the kind alone ("face", "edge", "vertex", "spun
profile", "isoparametric curve"). A source that names a body keeps its
name.

Only the text changes: the command refuses exactly what it refused before.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-11-02 13:49:26 +00:00
brett19andClaude Opus 5.5 d93a8bfd17 Merge ws/sync-5 (smlib at e1d532d90) into solidcore (sync 5)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEtwSrdwZxqTQp5MfnU
2026-11-02 06:48:46 -07:00
semmelrindeandClaude Opus 5.5 9b431fea16 Hole: on a cone or torus face, drill along the face's normal, not a facet's (#10698) (#10885)
A hole placed on the side of a cone with no direction drilled along
the nearest display-mesh triangle's normal, up to 2.6° off the
surface's normal and sideways. Planes, cylinders and spheres already
gave their exact normal; cones and tori now do too, from the surface
the kernel reports for the face.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 13:48:20 +00:00
Colin Faulkingham 2339510e41 Sketch Trim: keep endpoint tangency on the surviving arc (#10851) (#10853)
* claim: #10851

* Sketch Trim: keep endpoint tangency on the surviving arc (#10851)
2026-11-02 13:47:26 +00:00
semmelrindeandClaude Opus 5.5 ac9d4e8a1d Move to Component: a sketch on a face inside the moved part goes along (#11063) (#11072)
* Move to Component: a sketch on a face inside the moved part goes along (#11063)

A face attachment stores the placement path it was found through. Moving
the placement into another component changes that path, the stored one
no longer starts at the design, and the move was refused as breaking
the sketch. Face attachments of sketches and construction planes, and
an emboss's face, now follow the move as the session's paths already do.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Move to Component: attachments made through any placement of the old parent follow

A parent placed more than once is one definition: a face attachment made
through another placement of it than the one named also ran through the
moved placement and broke. Every stored path through the moved placement
now runs through its new place. A path that would grow past the 64
placements a design keeps is refused instead of saved unreadable.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 13:46:12 +00:00
Christian Glombek 39163148d9 Sheet metal: an edge flange on part of a stepped outline spans that part (#11034) (#11046)
A flange picked on one segment of a stepped base outline ran the base
face's whole length: trimming the picked edge back to the bend line
merged it with the outline's own edge on that line beyond the step, and
the flange took the merged edge. It now stays off the base's edges that
already lay on the bend line, so it spans the segment picked, with no
relief there: the base is already back at the bend line. The same
outline made by cutting notches into a rectangle gave the right flange
already.

Assisted-by: LLM
2026-11-02 13:45:56 +00:00
semmelrindeandClaude Opus 5.5 3ca311f922 Sketch: a dog bone's outline outside it meets outside both notches (#10984) (#11000)
* Sketch: a dog bone's outline outside it meets outside both notches (#10984)

Where two tangent arcs touch at a cusp, the copies of the two arcs cross
twice, both crossings as far from the cusp, and rounding chose one: on
one side of a dog bone the outline ran both copies on and drew a loop
into the bone. Such a tie now takes the crossing that cuts both copies
short.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Dog bone test: the outline goes outside, away from the picked bottom line

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 13:45:56 +00:00
Colin Faulkingham b978eeddcd Sketch: preserve short reference-line directions when dimensioning (#11001) (#11117)
* claim: #11001

* fix(sketch): keep short infinite references aligned
2026-11-02 13:45:36 +00:00
brett19andClaude Opus 5.5 e1d532d903 Merge origin/main (3c806394b) into smlib (sync 5)
Conflict: crates/ui-egui/src/render_workspace_tests.rs takes main's
reflection-editor flow (#8000) and reads the world through
open_meshing::session_world, as smlib's side did.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEtwSrdwZxqTQp5MfnU
2026-11-02 05:45:34 -07:00
brett19 c043e0b873 Merge ws/sync-4 (smlib with develop f916a8d and main 0.30) into solidcore
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz

# Conflicts:
#	crates/kernel/src/blend_smlib.rs
#	tests/KNOWN_FAILING_TESTS
2026-11-02 03:03:21 -07:00
brett19andClaude Opus 5.5 5862ee223f After the merge: main's new tests on the SMLib kernel
- Cut To the far side of a curved wall (#8634): the tool stops past the first crossing of the
  face ahead of the profile; SMLib's whole bore is one face that a line crosses twice, so the
  single-crossing rule found none and the cut took nothing.
- Clearing view analyses goes through refresh_display, as main's #10687 made the others, so an
  open feature editor keeps OK and Cancel after Zebra.
- vi, a complete catalog on main, gets the setback-too-short message.
- fillets/KNOWN_FAILING: 4782's cause is now its continuity check (SMLib f916a8d builds the
  expected volume).
- Known failing, as main's tests assume truck: the spline wall's spans as one mesh patch, a
  hole touching an edge at a point leaving one body, and a copy of a copy's triangles matching
  a fresh mesh.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
2026-11-02 03:02:43 -07:00
Colin Faulkingham 3c806394b0 Edit Sketch: restore timeline and undo state when finishing (#10691) (#10791)
* claim: #10691

* Fix sketch edit completion history (#10691)
2026-11-02 09:37:38 +00:00
brett19andClaude Opus 5.5 083b525adf Merge origin/main into smlib
Conflicts kept both sides:
- eval.rs: main's thread-search change (#10227) moved into develop's eval_thread.rs; construction axis/point source bodies with the branch's fallible construction_state; main's identity shortcut in the branch's fallible placed().
- eval_more.rs: main's box helpers and beyond_cylinder_reach kept (main's cut and tap-marking code uses them), body_box meshing through Body::mesh.
- project3d/project.rs: SMLib meeting_edges kept; a face pick now takes its whole surface patch (#9009) through meeting_edges over a set of faces.
- frames.rs: main's split_move (#9660) with the branch's fallible to_local.
- ao.rs: main's draw_opaque with the branch's open-body triangles.
- dialogs.rs, move_preview.rs, viewport.rs: both sides.
- Generated files from main. Tests calling world_state() unwrap its Result.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
2026-11-02 01:33:06 -07:00
Dahak BuildsandDahak Builds ef939b52eb Parameters: one meaning for value in every reply; round reported numbers (#10747) (#10812)
* claim: #10747

* Parameters: value is mm/degrees in every reply; round reported numbers (#10747)

---------

Co-authored-by: Dahak Builds <dahakbuilds@users.noreply.github.com>
2026-11-02 08:26:24 +00:00
brett19 a8202960b9 Merge origin/develop into smlib (SMLib pin f916a8d)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz

# Conflicts:
#	.github/workflows/ci.yml
2026-11-02 01:22:44 -07:00
jyvikoandClaude Opus 5.5 597b23ba8e Sheet metal: cuts and holes pass over sheets and bends by their exact boxes, never a mesh's
A primitive cut skips the sheets kernel::apart (exact bounds grown by the record tolerance)
finds clear of its tool; the bend check leaves the clear case to kernel::boolean, which answers
it from the same exact boxes with no intersection work. The mesh-box helpers are gone, and their
four lines leave xtask/mesh-decisions.txt (172 sites left).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 02:58:29 -05:00