* claim: #4226
* Esc ends the navigation bar's Pan, Orbit and Zoom modes (#4226)
The nav bar toggled a mode on, but nothing cleared it on Esc, so a left drag
kept panning, orbiting or zooming. Esc now ends an active nav mode first;
the next Esc reaches the tool or dialog as before.
each_frame_hands_the_view_its_motion_through_the_drivers_mapping dropped
the output of a frame it ran (`let _ = ctx.run_ui(...)`). epaint panics
in debug builds when a TexturesDelta is dropped with deltas left ("Dropped
TexturesDelta with 1 unapplied deltas"), so the test failed under a plain
`cargo test` on every platform while the ci profile passed. It now clears
them, as the other UI tests do since #60.
Co-authored-by: Tyler Chiriboga <18270301+Tyler-Chiriboga@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #4380
* "Don't Save" looks like a button in the Save changes prompt (#4380)
The prompt's third action used the kit's low-emphasis text style, so it
didn't read as clickable and people thought Cancel was the only way out.
Add an opt-in secondary_left style to the confirm footer (a framed
secondary button from the theme tokens) and use it for Don't Save.
* Save prompt test: clear each frame's texture delta once it is applied
egui 0.36 panics when a TexturesDelta with unapplied deltas is dropped;
the test kept only the last frame's output and dropped the earlier ones.
* claim: #4440
* Flat Pattern view: draw perforation holes (#4440)
The flat view drew the outline, cut-outs, pockets and bend lines but not
perforation fields, though the flat-pattern data and the DXF export list
their holes. The view now reads the hole centres from the sheet through
SheetBody::perforation_holes, caches them per model state and body, and
draws them as circles in the cut-out style. Holes outside the viewport or
smaller than one pixel are skipped, and the cache is capped at one million
holes.
* claim: #4464
* Sketch offset keeps its source lines free to turn (#4464)
An offset adds a Parallel between each source line and its offset line.
Since offsets became associative, the offset's points are held during a
solve, so each Parallel pinned its source line to the offset line's
current direction: a closed chain lost its turning freedom (8 degrees of
freedom became 6), and Horizontal or an angle edit on a source line was
refused as conflicting.
The solver and the constructive reading now leave out a Parallel that
ties an offset line to the source it follows while the association lives;
the association already keeps them parallel. After Break the stored
Parallel drives again.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #5254
* Toolbar: a constraint dragged out of the small box becomes a full button (#5254)
The Constrain panel's small box of constraint icons was a fixed list, so
dragging one onto the full-size buttons saved a new order but it was still
drawn in the box. The toolbar settings now remember, per tab, which box
commands were moved out; those are drawn as full buttons, the box closes
up, and dropping one back on a box icon returns it. Reset Toolbar restores
the default box, and settings saved before this load unchanged.
* Renaming a body that later features change evaluates nothing (#2467)
Model::rename_body now keeps the results when later features change the
body (a pattern, a chamfer, a join). It still evaluates when a body of
that name comes and goes or isn't the same body throughout, when a later
body's name is worked out from it (X (2)), or when a message quotes it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Rename box: rename off the window thread, and locked bodies follow a rename (#2467)
The rename box commits body.rename through run_heavy, so a rename that
still evaluates later features (one names the body in its targets)
computes beside the window instead of freezing it. Locked bodies now
follow a body.rename from anywhere (the rename box, the control channel,
scripts), not only the rename box.
---------
Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #3187
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Reorder design tabs by dragging them (#3187)
A tab dragged along the strip follows the pointer while the others make
room, and lands where it is released; Escape, or releasing down the
window, leaves the order as it was. With the custom title bar a drag that
starts mostly up or down (or on the only tab) still moves the window.
The control channel's ui.documents gains a move action (from, to).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Phanoob <phanoob@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #1783
* FreeCAD/Rhino import: decode caps with room for detailed parts (#1783)
cadmpeg decoded FreeCAD and Rhino files under its service profile, whose
million collection items and 2.56e8 work units a detailed part (a sprocket,
a threaded rod, a part with a few hundred faces) runs past: the import was
refused with "resource limit on CollectionItems: BudgetExceeded". Allow
8 million items and 2e9 work units, half of cadmpeg's desktop profile; the
input-size cap stays SolidCraft's STEP limit and every other cap stays at
the service profile's.
decoding_is_capped checks the two raised caps (and that they stay below the
desktop profile's) and that every other cap is still the service one.
Fixes#1783
* claim: #3278
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* 2-point circle takes a typed diameter (#3278)
After its first point the 2-point circle tool showed no value box, so the
circle could only be sized with the cursor. It now shows a Diameter box,
like the centre circle: the typed value puts the second point that far
along the cursor's direction, and Enter draws the circle.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Phanoob <phanoob@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Macos: keep touchpad/key modifiers true to fusion
* fix: remove obsolete orbit snap reset from trackpad navigation
Upstream removed ViewportState::orbit_snap. The new trackpad orbit path retained one reference, causing E0609 in the PR merge build.
Validation: all seven trackpad tests pass; cargo check -p solidcraft-ui-egui --all-targets passes on the exact failing CI merge 66a2791b with this fix applied; rustfmt and diff checks pass.
Co-Authored-By: GitHub Copilot <noreply@github.com>
* fix: retain Fusion trackpad help in refactored preferences
Preserve upstream's new preferences pages and apply the translated Fusion trackpad tooltip in prefs/navigation.rs.
Validation: cargo build -p solidcraft passed. Tests and full CI were not run, as requested.
Co-Authored-By: GitHub Copilot <noreply@github.com>
* style: format Fusion trackpad preferences tooltip
Apply rustfmt's required wrapping for the relocated tooltip. No behavior changes.
Validation: cargo fmt --all -- --check and git diff --check passed.
Co-Authored-By: GitHub Copilot <noreply@github.com>
---------
Co-authored-by: GitHub Copilot <noreply@github.com>
* claim: #3471
* Delete in a rolled-back history warns about the features after the marker (#3471)
With the timeline rolled back, the checks a delete runs first (the
confirmation's "these features will fail", timeline.dependents and
selection.delete's would_fail) compared models evaluated only up to the
marker. Features after it, broken by the delete, were not listed, so their
error marks turned up only once the timeline moved to the end.
newly_broken_in_history evaluates both sides over the whole history when
either has a marker (on copies; the model and document are unchanged) and is
used by the delete's report and by timeline.dependents.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #3042
* Warn when cut pattern copies remove no material
A rectangular or circular pattern whose copies miss the body succeeded silently and those copies did nothing. The pattern now reports how many of its cut copies removed no material, and keeps the copies that land.
* claim: #4003
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Frames: the profile library (#4003)
The first slice of frames and weldments: the cross-sections structural members
will be made of, each SolidCraft's own parametric definition built in code
(no vendor or standard size tables are shipped).
- solidcraft_doc::frame: bar, round bar, rectangular and round tube, angle,
channel, I-beam and a generic T-slot extrusion as exact line/arc regions,
with defaults worked out from the profile's size, refusals that name the
dimension that does not fit, anchors and placement, and exact section
properties (area, centroid, Ixx/Iyy/Ixy by Green's theorem).
- frame.profile.list, frame.profile.properties (with mass per metre for a
density) and frame.profile.insert (draws a profile into a sketch, locked by
default, at a point, anchor and angle).
- Tests against hand-computed values (rectangles, circles, composite
rectangles by the parallel-axis theorem, fillet spandrels), hostile input,
extrusion volume, undo; catalog entries in every locale; docs/frames.md;
ROADMAP M15.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Frames: drop the built-in T-slot profile (#4003)
Aluminium extrusions and other vendor sections come from the user's own
sketch (drawn or inserted from the vendor's DXF), so the library keeps the
plain steel shapes only.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Frames: members along frame sketch lines (#4003)
frame.member lays one body per straight line of a frame sketch (2D lines or
3D sketch lines), its cross-section square to the line from end to end:
- profile: a built-in profile, or profile_sketch, a sketch whose material
(nested loops alternating, so two circles make a tube) is the section in
its own x and y around its origin; profiles picks override it.
- anchor (origin, centre, centroid or a bounding-box corner or edge middle),
angle (an angle expression, so a parameter), mirror.
- Orientation: the profile's y as near world up as the line allows, x
square to both; a vertical member's x is world X (frame::member_axes).
- Members follow sketch and parameter edits, undo as one step, save and
reopen (format: pending/frame-members.rs), and are named after the profile
(Rect Tube 40x40x3, (2)…), numbering on past names already taken.
Tests against hand-computed volumes and bounding boxes (rectangle, 3D
tower lines, parameter edit, sketch tube profile and picks, anchor/angle/
mirror), refusals, undo/redo and reopen; walk fixtures and goldens; docs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Frames: fixes from the adversarial review (#4003)
- Default member lines are what was drawn: projected and other linked curves
and 3D wires (a face sketch's edges) and lines of no length are left out.
- A profile sketch's material starts from its drawn profiles, as
solid.extrude's "all" does, so a section sketched on a face works; the
even-odd test uses outlines and boxes worked out once, capped at 256.
- Member names are pinned to their lines (`names`, by line id; `body_name`
is the base): deleting or adding a line, or deleting another feature, no
longer renames other members, and frame.member stores every name it gives.
body.rename renames a member on its line (also for later member features);
a copy whose body_names were set still names its members by position.
- Built-in profile dimensions are expressions (ProfileSpec): they follow
parameters, bare numbers take the design's units, and they are feature
inputs. frame.profile.properties/insert read them the same way.
- Default root/toe radii shrink to the room a thick section leaves; radii
given are checked by name; a radius must be 0 or at least 0.01 mm; error
messages report the wall or flange value given, not twice it.
- A line within 1e-6 rad of vertical orients as vertical, so rounding never
turns a post a quarter turn.
- A 2D frame sketch in a differently placed component is mapped into the
member's frame, and member features recompute when placements change.
- Caps before lookups for a design's `lines`; a line listed twice is
refused; a 3D wire that runs back on itself is not a line.
Regression tests for each, from the review's scenarios.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Frames: the Frame Member dialog on the ribbon (#4003)
- Frame Member (MODEL > Create) opens a dialog: the frame sketch's lines
picked in the view (or All Lines), a built-in profile and its dimensions or
a section picked in another sketch, anchor, angle, mirror and name, with a
live preview. Edit Feature reopens it filled in.
- Lines picked in the view keep their sketch (a SKETCH_LINES input picks
ExternalSketchCurve): line ids are each sketch's own, so two 3D sketches
both have a `w2`, and the members went on the newer sketch's lines.
- timeline.redefine takes frame.member. Members keep their names through an
edit unless it gives them a new body_name; frame.member takes `names`.
- A member whose section is a whole profile sketch keeps it when edited
(the dialog shows the sketch instead of picking every region, which would
fill a tube's hole).
- An original frame_member icon, open for review, on the ribbon, timeline
and browser.
- The angle profile is listed as L-Angle, and web and flange as Web/Flange
thickness, so they translate apart from the existing Angle, Web and Flange;
the dialog's labels are in en, ja and zh. en-GB no longer repeats the frame
command labels it spells the same.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Nine tests dropped an egui frame's output with its texture delta still
unapplied (the expression completion editor's frames, the slot preview's
three, the browser's feature rows). epaint asserts against that in debug
builds, so they failed under the dev profile and passed only where debug
assertions are off. They clear the delta as the other tests do; one more
hover test that dropped its output the same way does too.
* claim: #4083
* Feature editors refill named edges and faces where they are now (#4083)
After an upstream sketch change, Fillet, Chamfer, Shell and Draft evaluated
correctly, but their editors refilled the originally clicked points and
could then fail with "no edge at ...". Resolve the stored names through the
document's naming helpers first, keep the resolved index, and map the pick
into the displayed body's frame; the point lookup stays as the fallback.
* claim: #4097
* Sketch fillet keeps a corner placed by an expression (#4097)
Filleting a corner whose position comes from parameter expressions deleted
the point and its expressions, so the sketch gained two degrees of freedom
and later parameter changes distorted the outline. keep_corner now also
keeps fixed or expression-positioned points as virtual sharp corners.
* claim: #4150
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Browser: a second click on a Document Settings entry closes its window (#4150)
Each entry under Document Settings only opened its window. A second click on
Units closed the menu on the press (the row is outside it) and opened it again
on the release; Precision left Preferences open; Parameters and Design
Properties came back as a fresh copy. Now a click on an entry whose window is
open closes it the way the window's own x does:
- Units: context_menu::toggle_for with the row as the opener, the fix#1522
made for the workspace button's menu. A right-click still opens it at the
pointer.
- Precision: prefs::close(app, true), the Cancel/x path that puts back what
changed since the window opened (now pub(crate)).
- Parameters and Design Properties: the window is dropped, as its x does. A
Parameters value typed but not applied yet is dropped with it, as today's
second click already drops it.
Fixes#4150
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #4353
* Renaming a plane keeps its projections, canvases and hidden state (#4353)
timeline.rename only renamed the feature in other features' references. A sketch's
projection of a construction plane, a canvas placed on it and the hidden list keep it
by name too, so they lost it: the sketch warned that the plane no longer exists, the
canvas left the view and a hidden plane showed again. Document::rename_feature_keys
renames it in sketch links and canvases, as rename_body_keys does for bodies; the
selection follows in the command, and the hidden list in Session::refresh_from, so a
hidden plane stays hidden through undo and redo too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #5269
* DXF: write and read a Bézier at its own degree (#5269)
The DXF writer and reader held a spline's degree to 7, the value MAX_BEZIER_DEGREE had before
#1642 raised it to 9. A G4 blend (one Bézier of degree 9) was written as a degree-7 SPLINE over
its first 8 control points, so a flat pattern's cut-out stopped 4.444 mm short in the file.
- seg_shape takes its limit from MAX_BEZIER_DEGREE: a Bézier is written whole, at its own degree.
- read_dxf reads SPLINE degrees 1 to MAX_BEZIER_DEGREE, the degrees a sketch spline takes.
- Tests: every Bézier degree 4 to 9, a degree-9 round trip, the reader's degrees, hostile SPLINE
degrees and too few control points, the G4 cut-out exported and read back with its areas, and a
degree-9 SPLINE with 2 to 10 points inserted into a sketch.
Fixes#5269
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #3989
* ui-egui tests: offscreen GPU tests start their devices one at a time
Every offscreen test started a wgpu instance of its own, and starting one
makes the Vulkan loader scan its drivers. With several test threads two
tests doing that at once crashed the test process with SIGSEGV inside the
loader (loader_icd_scan). offscreen_device now holds a process-wide lock
while it starts the instance, adapter and device; each test keeps its own
device and the rendering still runs side by side.
A new Graphics preference, "Show reference geometry through bodies", draws
inactive sketch contours, origin and construction planes and their axes over
shaded bodies. It is off by default, so the viewport looks as before: reference
geometry is depth-tested and a section leaves it whole (#1229); Create Sketch
and dialogs picking a plane still draw the planes through the model.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
#5109 added Frame::hover_tint and selection_tint; two test frames that landed alongside it didn't set them, so solidcraft-gpu's tests stopped compiling on main.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Sketch on a picked origin plane uses the plane shown, also in a moved component
After a STEP file opens its component stays the active one, and standing it up
turns that component a quarter about X. Starting a sketch on XY picked in the
viewport then sent `{"plane": "XY"}`, which names the active component's own
XY: upright after the stand-up. The sketch landed on the world XZ, Look At
turned to face Y and the extrude went along Y.
The viewport and browser only show the design's origin planes, so a picked
origin plane now goes to sketch.create written out as that world plane while
the active component is moved; sketch.create maps it into the component's
frame once. The flip toward the viewer uses the same plane.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Stand-up axes tests: stand the file up through the offer when one is waiting
#5655 offers to stand up SolidWorks files instead of turning them silently.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Hovering or selecting whole bodies -- a browser row, a History group, a body
under the pointer in body-pick mode -- built a CPU copy of every body's
triangles into the highlight scene. On a 40-body 4.3 MB STEP assembly that was
147 bodies, 70 MB of triangle copies and a 519 ms frame.
The model already has the same geometry on the GPU. The highlight now names it
and the renderer draws it again in the highlight colour:
- bodies drawn from a display plan: the model's evaluated plan chunks, with a
hover/selection tint uniform (the chunks stay resident in the model scene);
- bodies drawn as placements of shared triangles: the same placements of the
model's shared triangles, coloured per instance;
- bodies the model builds on the CPU: their vertex range in the model scene's
block.
See-through and faded bodies keep the CPU feedback, which colours them; faces
and edges highlighted on their own are unchanged. The highlight looks the same
(verified side by side).
On the assembly the highlight build drops from 519 ms to 9 ms and no longer
copies any triangles; selecting the whole assembly takes 9-20 ms.
Co-authored-by: Claude Code <noreply@anthropic.com>
* claim: #5295
* An empty intersect is refused instead of deleting the body (#5295)
An intersect whose boolean came out empty removed the target body and
reported success. The shared evaluator now refuses it when nothing of a
named target would remain, when nothing of any target would remain, or
when the tools meet a target and the result is still empty. An unnamed
target the tools miss altogether is still removed, as an intersect with
every body does (#5160). Sheet metal flat machining follows the same rule.
* Sheet metal: an intersect with already removed material is refused (#5295)
* claim: #133
* mesh: Save As Mesh declares the panel that shows it (#133)
The ribbon redesign (#2176) removed the MESH tab, but three things still
pointed at it:
- `file.save_mesh` declared `.at("MESH", "MODIFY")`. The command inventory
prints the placement a spec declares, so `docs/features.md` advertised a
`MESH > MODIFY` location no ribbon has. Its real home is already
INSERT / FILES (`SECTIONS` lists it), so the declaration now agrees with
the ribbon; `destination()` resolved it there before and after, so nothing
moves on screen.
- The user guide sent people to "the Mesh tab under Modify" for Save as mesh.
- A test now refuses any command that declares a tab the ribbon removed, and
pins where Save As Mesh lives.
`PLACEMENTS` keeps its MESH entries: those migrate toolbars users saved under
the old panels, which is a different question from what a spec declares.
---------
Co-authored-by: Geraldrunion <geraldrunion@users.noreply.github.com>
* claim: #4563
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Section Analysis: a Hatch option, off for a plain cut in the body's colour (#4563)
The Section Analysis dialog gets a Hatch check box beside Flip, and
inspect.section a hatch?: bool (default true), so scripts, the CLI and the
control channel reach it too. Hatched, a cut is its body's colour tinted
toward the cap colour with 45 degree stripes, as before; off, it is the
body's own solid colour. The viewport (cap alpha in the uniform), the CPU
rasterizer and ui.render follow it, and the section keeps it when hidden
and shown again or edited.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #4589
* Expression suggestions stay closed while another control is dragged (#4589)
A drag elsewhere leaves a text box its focus (egui gives it up on a click,
not a drag), so dragging the Drive Joints slider rewrote the focused Angle
box under its old selection. A letter before the caret ("5.0 d|eg") made a
new word, a fresh undismissed popup, and the list opened over the slider.
Dismissed suggestions now stay closed until the box is typed in, a drag of
another widget dismisses them, and a hidden list forgets its row rects.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #4609
* Mesh Convert works without activating the component first (#4609)
Inserting a mesh puts it in a new component while the parent stays
active, so Convert Mesh always refused the first time. Convert now
resolves the mesh body's owning component and adds the conversion
there when the active component is that component or an ancestor,
leaving the active component unchanged. From another branch it still
refuses, and the error names the component to activate.
* Control: a whole-design measure reads a copy off the window thread
`inspect.measure` and `document.inspect` (which measures every body by
default) ran on the window thread. On a large assembly that took about a
minute, the window answered nothing meanwhile, and Windows closed it as
not responding (#4604). They change nothing, so they now run on a copy of
the session on a worker and are answered from there, like exports, but
whatever the "agent commands off the window thread" preference says: an
answer from the design as it was when asked has no order to keep. The
window keeps answering `ui.*` and drawing meanwhile.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Control: clearance and interference checks read a copy off the window thread too
inspect.clearance and inspect.interference only read the design, and on a
large assembly measure every pair of bodies: on a 153-body design a clearance
check computed for over five minutes on the window thread, the window showing
"not responding". They join inspect.measure and document.inspect in running on
a copy, answered from there.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #4030
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Sketch Symmetry: a dimensioned shape slides onto the axis (#4030)
With a rectangle's width dimensioned, Symmetry of its two sides about an
axis was refused: the second side can't move on its own, the axis never
moves, and the ordinary solve that slides the whole rectangle only ran
when every first-picked entity could move. One movable first entity is
now enough.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #4328
* Fix sheet conversion picks on tangent bend edges (#4328)
Resolve cylindrical bends through the nearest edge's incident faces when a
pick on a tangent boundary resolves to its planar panel. This keeps valid
remote bends connected, including picks on the other skin of a shell.
Keep conversion geometry and picks in the body's local frame, and format
conversion diagnostics through its world placement. Cover rotated bend
picks and disconnected-pick coordinates with synthetic regressions.
A join failed with the kernel's internal error "tolerance must be no less
than 1e-6" at vendor/truck-geometry/src/decorators/intersection_curve.rs:172:
IntersectionCurve::parameter_division asserted truck's minimum tolerance,
and the guard turned the panic into a failed operation. A tolerance below
truck's TOLERANCE, or one that is not a number, now divides at TOLERANCE:
the curve's points are only found to within it anyway.
The test divides the intersection edges of a hole cut through a B-spline
face at 5e-7, 1e-12, 0, -1 and NaN: each gives the division at 1e-6. Without
the fix it panics with the reported message at the reported line.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* claim: #4593
* Pattern and mirror: a rib as the source (#4593)
A pattern or mirror of features refused a rib as a source ("Rib1
cannot be patterned or mirrored yet"). A rib's walls run until they
meet the body, so each copy is built again where it is: the rib's
sketch is moved by the copy's transform and the walls are run against
the bodies there, as a hole is drilled again at each copy. The copies
join the body, as the rib does. The rib's own tool building moves into
rib_tools, which the rib feature calls unmoved.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Sketch Point: a point put on a midpoint or a curve snap is held there (#4691)
The Point tool sent only a snapped point's coordinates and sketch.point
took only [x, y], so a point clicked on a line's midpoint (or on a curve,
or a model vertex) was free to move off it. sketch.point now takes the
snap forms the other draw commands take ("mid:<line>", "on:<curve>:x,y",
{vertex}, {on_edge}); the snap makes the point with its constraint. The
tool passes those snaps as themselves; a snap to an existing point still
goes as coordinates, where `connect` joins them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Sketch Point: refuse a snap it can't read instead of answering as if it made a point
sketch_project::snap_points leaves a snap it can't parse ("on:c1:abc",
"on:c1", "on:c1:1,2,3") as it was given, and sketch.point then read
that string back as the point it had made: no error, no point, and an id
a script would go on to dimension. It now takes the snap only when it
names a point of the sketch, and otherwise refuses, listing the snap
forms (found by the test agent on #4745).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The app's background loader (file_load::control) kept only `up` and
`names` of a control-channel open or import, so file.insert_step's
`matrix` and `name` were dropped and the part landed at the origin, and
file.insert_mesh lost all its options. It keeps every parameter but the
path, as given; each command checks them as it does when run directly.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
timeline.rollback / timeline.roll_to read a negative position as 0, so
an agent passing -1 for "one step back" rolled the whole timeline back
and every body disappeared, with no error. A negative position is now
refused. The two commands shared one function that refused in
roll_to's name; each now refuses in its own.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>