Commit Graph
665 Commits
Author SHA1 Message Date
jyviko ec6fa9706a kernel: a seam with one face on both of its sides is a seam, and no pick takes it
seam_flags matched only an edge between two faces on one curved surface.
A whole turn of a cylinder is one face whose seam it uses twice, and
history::edge_faces lists that face once, so the seam came out as [x]
and was never flagged: it was drawn and picked, and a blend pick at the
vertex where it meets a rim (ladder 07-fillets/017's (23, 15, 20) on a
boss's base circle) resolved to the seam, which SMLib then rejected. An
edge both of whose uses lie on one curved face is now a seam too, for
every consumer of the flag (display, picking, blend resolve, projection).

The blend's own edge selection took the plain nearest edge: the tangent
chain seeded from it and grew into seams (a pick at the top of a boss's
seam ran down it into the base round's seam, ladder 08-chamfers/008), and
the variable fillet's edge and the fillet's grouping of picks could
differ from the edge the blend resolved. They now take the edges the
blend's resolve picks, and a chain never grows into a seam or a smooth
join.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
(cherry picked from commit 709c19c7fd60db522d35e147f21821360bf34668)
2026-10-27 02:28:52 -04:00
jyviko 4b418c0d2d kernel: how a body's material regions meet, read from the record
Brep::region_contacts lists each pair of material regions that shares a
face, an edge (used by faces of both) or a vertex, with the most it
shares; pairs not listed are apart. Body::region_contacts reports it for
a boolean's result (lump positions as in Body::lumps), and Body::parts
cuts a body into groups of lumps (lumps is parts of one each). Exact
facts from the record only: no geometry, no decision.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
(cherry picked from commit 64a1d688e68e5f0c5b1f9e4fe0d2facfaa4744be)
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 8eb93ff063 step_in tests: the cube fixture's edges lie on their lines
Every edge of the hand-written cube was a LINE along one filler direction,
trimmed by vertices up to 1 mm off it; the reader refuses such an edge (a
degenerate edge on a line). Each edge now has the line through its two
vertices, so the assembly, instancing and unit tests read a valid cube.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 89e23d1eb0 record: a body built from a sketch has new edges, with no origins
of_faces gave every edge it was not told about the meeting of its two faces.
A builder (extrude, revolve, loft, a primitive) has no operands: every face it
makes is new, so its edges are new too (EdgeProv: empty when it is new and lies
between faces new to the operation), not where profile segments meet. With no
operands an edge's origins are only what the builder states.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 42e50a87c6 smooth edges: tangent joins of planes, cylinders and cones, along straight splines too
The display's smooth joins were certified only between ruled B-spline patches
along a Line record. SMLib gives an extruded profile's rulings as degree-1
B-splines of two control points, and sweeps a profile curve within tolerance of
an arc as a cylinder (a ring of 256 cubics is 512 cylinder faces), so no join
was certified. A straight edge is a line or such a B-spline; a plane, cylinder or
cone gives its outward normal along the edge in closed form at both ends (their
difference is the uncertainty, so an edge that is no ruling certifies nothing).

The closed-edge fixture cuts its hole with one circle: SMLib trims a loop of
eight cubics as eight edges.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 667ee5665e kernel tests: a blend meant to run along a tangent chain asks for it
The kernel blends exactly the edges given; the Fillet and Chamfer features
expand each pick to its tangent chain (kernel::tangent_chain) before the call
(4593fd07). Six tests written before that passed one pick and expected the
chain: they now ask for it as the features do, with their analytic expectations
unchanged (10 faces along the rounded corner, the sphere corners of #1557, the
boss's half circle, the rounded rectangle's tiny end, the rounded box's loops).
blend_smlib's notes no longer say SMLib follows the chains.

fillet_tabbed_plate_outer_loop_and_partial_selection_after_hole is left as it
is: it fillets every exact subset of the outer edges, and SMLib still fails some.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 1bf2062590 STEP and IGES import: SMLib makes the pcurves that have no closed form
A use with no closed-form pcurve (an approximated intersection curve on a cone,
a spline edge on a spline surface) no longer refuses its solid. Its face goes to
SMLib alone, an open sheet with the trims it has and without the others, and
SMLib makes those as it makes every trim it needs (GetOrCreateUVTrimCurve on
export); they come back on the record's parameters and the face is closed and
checked as before. The STEP reader takes the trim maker from the kernel
(read_solids_with, read_solid_with); read_solids stays exact-only.

Kernel lib tests: 490 pass, 239 fail (were 468 / 261; pushed head 475 / 254),
none newly failing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 fd71e6a954 kernel: assembled faces and edges on their NURBS forms
`Assembly::finish` (lip, emboss, delete face, and the other operations that take a body apart
and rebuild it) puts on a NURBS form every cylinder, cone, sphere, torus or revolution face that
none of its uses brings a pcurve to (over its boundary's extent on its label), and every edge
whose uses bring none and whose faces are planes, splines or on forms (a circle about such a
face's axis labelled on its frame). Their pcurves are then exact on the forms. A face or edge
with a pcurve of its own keeps the parameters that pcurve is on.

Rig and ladder unchanged (333/372, 101/116; 529 and 3368 flip between pass and a 40 s timeout
with the machine's load). The kernel tests of lip, emboss, delete face and assemble fail as
before (none new).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 6c385c8439 sew, step: face forms from the boundary's extent; trimmed profiles exact
sew and the STEP reader build a revolved face's NURBS form over `form::extent` (its boundary on
its label) instead of a pass of pcurves on the label, and compute its pcurves within the form's
box. The STEP reader gives revolutions their form too, and a trimmed swept profile its file's
trim range exactly (points on the axis fit either side of it). The STEP seam tests read edge
angles through `Edge::curve_interval`, intervals and domains being in the forms' parameters.
step 37/37.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 c376e84034 step: imported faces and edges on their NURBS forms
`form::edge` is the one rule sew and the STEP reader share: a circle about a revolved face's
axis is labelled on that face's frame, and a circle or ellipse edge gets its form. The STEP
reader now gives every imported edge its label and form before any pcurve, and every
cylinder, cone, sphere and torus face its form over the extent its label's pcurves give; the
pcurves, the outer-loop choice and the turn-over test then run on the forms, and the record
carries them.

With the pcurve fit turned off, the STEP and IGES circle cases pass (8 of the 9 import cases
that needed it; 3208's ellipse on an extruded spline surface remains).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
2026-10-27 02:28:51 -04:00
jyvikoandClaude Opus 5.5 fd873bb839 sew: an edge folded across a bend gets a Hermite pcurve on the bend's form
A flat-pattern edge folded across a bend is a helix, which no NURBS is: sheet metal already
gives its 3D curve as degree-7 Hermite pieces of the fold, within 1e-7 mm. Its pcurve on the
bend is now built the same way, on the edge's own parameter: degree-7 Hermite pieces matching
the point and first three derivatives of its angle about the axis (through the form's quarter
parameter, by the chain rule) and of its height along it, broken where the angle crosses a
quarter (the form's parameter is only once differentiable there), halved until they lift onto
the edge within 1e-7 of its size. An approximation by construction from exact derivatives, like
the edge; nothing is fitted. B-spline and NURBS edges alike (a NURBS's derivatives from its
homogeneous form). Breaks within rounding of each other are one.

With the pcurve fit turned off, all 44 sew cases that needed it pass; with it on, all 44 pass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
2026-10-27 02:28:51 -04:00
jyvikoandClaude Opus 5.5 76a254137c sew: a circle on a revolved face is labelled on that face's frame
The bend's rim arcs carried frames of their own (x toward the arc's start), a fraction of a
quarter from the bend cylinder's, so their forms were off the cylinder's quarter grid and no
straight pcurve lay along them. `form::on_frame` relabels such a circle on the face's frame (the
same circle, its interval shifted); its form is then on the face's grid, its pcurve u = ±s + c.
`along` takes u or v as the edge's parameter either way along, offset. The volume test steps to
a pcurve's ends exactly (t0(1-f) + t1 f), as an interval's end may now carry rounding.

With the fit off, 38 of the 44 sew cases pass (from 29). With it on, the rig is unchanged
(333/372, ladder 101/116, no case changed).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
2026-10-27 02:28:51 -04:00
jyvikoandClaude Opus 5.5 a4180ab42f sew: faces and edges on their NURBS forms, their pcurves exact
Every circle and ellipse edge sew builds now carries its NURBS form, its interval in the form's
parameter; every cylinder, cone, sphere and torus face its form over the extent its label's
pcurves give; and every pcurve is computed on the forms, so a bend's rim circle is a straight
line on the bend and an affine image on the flange, exactly. The volume test evaluates the faces
on their forms. A form interval's end within rounding past its last quarter stays on it.

With the pcurve fit turned off, 29 of the 44 sew cases that needed it pass (from none); with it
on, all 44 pass as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
2026-10-27 02:28:51 -04:00
jyvikoandClaude Opus 5.5 58f60adbfb kernel: an assembled face keeps its NURBS form
The assembly kept a face's domain and pcurves, which are in its NURBS form's parameters, but
dropped the form and computed new pcurves and the domain on the analytic surface. The form now
travels with the face, and its pcurves and domain are computed on it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:51 -04:00
jyvikoandClaude Opus 5.5 f070eee2b6 brep, kernel: a face's side is read on its NURBS form (#4149)
A shell's `forward` is about the surface the face's (u, v) are on, its NURBS form when it has
one, which may run against its cylinder, cone, sphere or torus. The kernel read it against the
analytic surface, so a fillet's bore whose form runs the other way was a shaft and an M10 thread
was refused in its 8.5 mm hole. `Face::form_turns` says when the form turns the normal.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:51 -04:00
jyvikoandClaude Opus 5.5 6892ceac78 brep, kernel: code that reads an edge's angles takes them from the circle, code that evaluates takes the NURBS form
Edge::curve_interval (and brep::curve_interval for assemble's edges) gives the interval on the
edge's curve itself: a form circle's angles of its ends, its frame turned by the SMLib conversion
so the angle grows along the NURBS. lip and the ruled surfaces read arcs by it; the hull, the
blend tangents, the patch pcurves, point paths, IGES output and the prism runs evaluate on
Edge::parameters. assemble carries an edge's form through.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:51 -04:00
jyvikoandClaude Opus 5.5 b1326e48d6 brep: an edge on a line, circle or ellipse carries the NURBS form SMLib holds it as
The edge mirror of a face's NURBS form: Edge::nurbs keeps the NURBS SMLib holds a conic as, and
the edge's interval and its pcurves' parameter are its. Edge::parameters is the curve every
evaluation at a parameter uses; curve says what the edge is. Nothing writes the form yet.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:51 -04:00
jyvikoandClaude Opus 5.5 369c897d85 kernel, cli: clippy and the cli tests build again
prism.rs's sheet regions import Surface and Vec3 only where they are built (the smlib feature),
so the kernel without it has no unused imports; the cli's tests that measure meshes at their own
tolerance depend on solidcraft-kernel.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:51 -04:00
jyvikoandClaude Opus 5.5 de0e5bf526 kernel: a tangent chain stops at a smooth edge
An edge whose two faces meet tangentially has no corner to round, and SMLib refuses a blend along
it. The chain now runs on sharp edges only, as a tangent chain does (fillets/3369: a rim edge that
ends on the tangent seam of a stadium).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:51 -04:00
jyviko e6f993fff0 Revert "kernel: merged topology counts no seam edge (a face on both sides of it)"
This reverts commit 1c490ddde7.
2026-10-27 02:28:51 -04:00
jyvikoandClaude Opus 5.5 2752eee616 kernel: merged topology counts no seam edge (a face on both sides of it)
Case tessellation/818 counts a whole cylinder's seam since circles are one closed arc (42 edges,
want 40, 'no seams'). Not built or run yet.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:51 -04:00
jyviko 5e7aba8df9 loft sections matched to their neighbours 2026-10-27 02:28:51 -04:00
jyvikoandClaude Opus 5.5 d0ff1dcfa4 doc: an extrude's taper without a corner rule picks one per profile
Extent.corner is optional: unset, each profile preserves curvature where
every curve is a line or an arc and takes the tangent rule where another
curve has a corner, with a note in the feature's warning; a rule the user
gave is kept. draft_corners reports not_exact as the kernel builds (any
free curve in a cornered profile). Builds (release CLI); cases not yet run.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 84bd2daadc doc, engine, kernel: solid.fillet and solid.chamfer round each picked edge's tangent chain by default
The kernel blends exactly the edges given; the feature's tangent_chain (default true, saved
only when false: pending format note blend-tangent-chain) expands each pick to its tangent
chain (kernel::tangent_chain) before the kernel call. A variable or spline round takes its
edge alone. Scripts and MCP passing one pick get the chain again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 b6a3b31ff9 brep: a face on a cylinder, cone, sphere or torus carries the NURBS form SMLib holds it as
Every SMLib analytic surface is a B-spline surface, and its trims are in that NURBS's
parameters. Face::nurbs keeps that NURBS: the face's domain and pcurves are its (u, v), and
`surface` says what the face is. Face::parameters is the surface every (u, v) evaluation uses.
The SMLib conversion reads and writes it (fork FACE_NURBS_FORM, SMLIB_REV c4483f6); the STEP
writer writes the analytic surface and the face's edges without pcurves.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 bcbb990051 kernel, smlib: a blend larger than its faces is SMLib's refusal; blends take exactly the given edges
SMLib (fork 68e3086) refuses a blend whose rails leave the faces they roll on with
SMLIB_ERR_NO_ROOM, which the kernel reports as KernelError::TooLarge. The kernel's own
pre-checks go: blend_fit's fit check and the 256-station band check of the variable fillet.
The shim no longer follows tangent chains; the Fillet/Chamfer dialog already expands a pick
to its chain (its Tangent Chain option) and stores every edge in the feature.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 0213c3dfa6 kernel: union_all, one SMLib union of many bodies checked once, history over every operand
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 384c5866f1 kernel: a tapered extrusion closes its corners by a rule, preserving curvature by default
extrude_tapered(_between) take a DraftCorner: PreserveCurvature (each wall
continues as itself, a line's plane or an arc's cone, until it meets its
neighbour; SMLib's SM_OC_CURVE_EXTENSION), Tangent (the offsets continued
along their end tangents) or Round (an arc about the corner). A corner
the rule cannot close is refused with its point and why
(solidcraft_smlib::Error::Corner). draft_corners reports, per sharp
corner of a profile, what each rule gives: how far each offset curve runs
on or is trimmed, whether the corner cuts inside the exact offset, or why
the rule refuses it. SMLib pinned at the fork's draft-corners head.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 0414f5a7a1 kernel: assemble's unused CurveEval import goes with edge_point
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 d100417433 kernel: emboss reads a wall's span from its arc's interval
The angles a cylindrical wall spans came from its arc's two ends about its middle; a wall in
one piece has a whole circle for an edge, whose ends are one point. The circle's parameter is
its angle, so the span is the edge's interval about the angle of its middle: half the turn
either side for a whole wall, as for any arc.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 8e6c24aeb7 kernel: a raised band reads its arcs' circles from the record
A rim's arc was its two ends and the point halfway, its circle found through the three: a
whole circle, one closed edge now, has one end and no circle through it. Each arc piece carries
its circle's centre and the angle it turns about the face's normal, read off the record circle
(its parameter is the angle), and offsets, profiles, edges and walls are made from those; the
loops' turning is read through points a third and two thirds along each arc. assemble's
unused edge_point goes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 01845c189f kernel: planar sheets are built one simple loop at a time
Seven sheet-metal cases failed in smlib_planar_faces (status 1001/1006). Every refused
curve list, in the rig's dumps, has curves of which more than two meet at one end point:
flange regions of one flat pattern touching at their corners (405, 349 x2, 436, 1481, 725,
723) and an outline passing a point twice where a cut-out's corner lies on the sheet's edge
(1095). SmBrep::CreatePlanarFacesWith3DCurves, behind SmApiCreatePlanarFaces, documents
that it fails for such "spine points (where more than two curves share a common
end-point)" (SmBrep.cpp); the sheet handed it all of an operand's loops at once.

A sheet is now built one simple loop at a time: each loop (outer counter-clockwise, holes
clockwise) split where it passes a point twice, each simple loop its own planar face, the
counter-clockwise ones united and the clockwise ones taken away with SMLib's 2D boolean,
which takes faces touching at a point. extrude_planar_regions uses the same sheet.

The read-back keeps the contract the regions had: a face's loop that passes a point twice
(a cut-out touching the outline) comes back as simple loops, counter-clockwise pieces
material and clockwise ones holes of the piece that holds them.

Release CLI, SOLIDCRAFT_KERNEL=smlib: 405, 349 (72 and 90 degrees), 436, 1481, 723 and 725
pass. 1095 now gets past the planar regions; its extrusion of a plate with a cut-out
touching its edge at one point fails in SMLib's export ("a closed shell bounds two regions
and encloses one"). Every other sheet-metal case fails or passes as in rig-1, and 529
(a hang in rig-1) passes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 44744d3aae kernel: a face's boundary runs along a pole as its pcurves say
The five "boundary winds around the surface" refusals of the first SMLib rig run (solid.hole
1355, solid.revolve 1853, 1866 at 180°, 3191, 466) are one mechanism: a revolved face whose
profile ends on the axis (a drill point, a cone tip, a half slot about its centreline) has a
pole, and its two meridian edges meet there with pcurves half or a whole period apart in the
angle, the parameter the pole leaves free. The boundary unwrapped every step to the nearest
copy, so at the pole it moved the next meridian a period along (1866's quarter sphere: from π
to 2π instead of 0) or, where the pole closed the loop (3191: v from 1 back to 0), the closing
step did; the loop then drifted a whole period and the face was refused as winding.

The pcurves are exact and run on continuously, so nothing within an edge is unwrapped now.
Where one edge meets the next, a pcurve starting a whole period from where the previous one
ended is moved back by it, except in a direction the meeting point is a pole of: there the
two pcurves' own values are the ends of the boundary's run along the pole, which the split
poles then carry. Each loop starts at a node off every pole whose predecessor is off them too,
so seam::drift's nearest-copy closing step never crosses a pole. All five cases pass;
tessellation/ and sweeps/ otherwise as in the rig run (1856 and 3006 pass, slow under a
machine load of 190; 2552 hangs as before).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 afce22bb60 solidcraft-smlib: mass properties of any body, by its material regions (fork 311946c)
SMLib's mass properties no longer refuse bodies that are not one manifold
solid: several lumps and lumps touching along edges or points are the sum
over their material regions, and a sheet is its faces' area and centre with
volume 0. Docs of Brep::mass_properties and kernel::measure say so.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 78937d1dbc brep: one basis-derivative routine, bspline::basis_derivatives
The ruled surface's far-curve solve kept its own copy of NURBS Book A2.3. The
geom crate now exposes bspline::basis_derivatives (the basis functions alive at
a parameter and their derivatives up to an order, each from its local knots via
local_basis, on the span tess::span_of picks); tess's second-derivative surface
evaluation and the ruled surface both use it, and the copy is gone. smlib's
mod list back in order.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 9e2c1c57c8 kernel: ruled surface docs and test for the free strip's far curve
The refusal test now checks the strip is built, one face, and that moved
handles move its far curve; the module notes say what a free strip is.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 81cef1c60e kernel: a free ruled strip is the exact ruled surface to a far curve of its own
Owner's decision for strips whose rulings turn freely along their edge (a face's
normal along a free-form face, which was refused): the far edge is not the
offset curve but a B-spline the kernel defines, and the strip is exactly the
ruled surface between the edge and it.

The far curve has the edge's own degree, knots and weights (so the ruled NURBS
needs no knot merging); it runs from the strip's start corner to its end corner
(where the rulings at the edge's ends reach); its interior control points are
given (handles) or the least-squares solution of weighted terms, the
construction's parameters: closeness to the rulings' ends at the edge's
Greville abscissae (W_CLOSE), fairness by arc length (W_FAIR), each end leaving
along the chord to the other end (W_TANGENT, one small function), and at a joint
where the chain runs on smoothly with shared sides the first and second
derivatives by arc length matched to the neighbour's (W_JOIN), in one solve
along the chain, an exact neighbour's far edge matched as it is. Exact strips
are unchanged.

ruled_far_handles gives each free strip's default handles; ruled_surface_with
takes moved ones. The Ruled Surface feature saves them as `far` (per chain
edge, null for the default; pending format note ruled-far-handles), and
surface.ruled takes them as `far`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 a0e17daa5f kernel: cargo fmt
Formatting only, so the kernel passes cargo fmt --check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 f6afec8eab kernel: dead code left by the port deleted; clippy -D warnings clean on all targets
No caller is left for: Assembly::sheet and assemble::outward_normal, Body::shell_nesting,
regularize_generated_planar_faces, with_shell_planar_sources, boolean_record's Traced and
of_pair, offset's normal, plane_fit's plane_through, EdgeSampler, planar_face and
plane_frame (fill has its own on the record), polyhedron's solve3, prism's wall_along,
record::regions/region, splitface's side_of_point, Analytic, analytic_face, face_sides and
canonical, surfaces::picked_loop, sweep_path's closed_path, turn and stations,
shell_groups' groups and parents with their limits, and the whole of spline_conv. Their
tests go with them: prism's curved_prism_wall_requires_positive_separable_rational_weights,
body_lump's shell_grouping_preserves_large_disconnected_patterns_and_bounds_hostile_work,
and regularization protection's check of the generated regularizer. Three names follow
clippy's conventions: into_face -> direction_into_face, from_to -> ends_along, and Params::
to_eval takes its Copy self by value; fill's clash loop walks its slots.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 2f83aaa5da kernel: clippy's own fixes across the kernel (needless borrows, assign ops, contains)
Machine-applied by cargo clippy --fix: borrows the compiler dereferences at once, an
unused import, a manual += , an entry() for contains_key+insert, a needless Ok(?),
contains() for iter().any(). No behaviour changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 2a09b99431 kernel: the test target compiles: the last tests on the record and SMLib
mesh memo (one remembered mesh per tolerance), history (a bare body from a record), tests.rs
(no coarse-missing field, lumps for touching shells), outline (the foot found by the planar
faces in its plane), chamfer sides (the rim from the record's edges), seam faces, coplanar
and issue 679 and pinch tests (the boolean is SMLib's: the diagnostics assertions go, every
volume, shell and validity check stays), boolean history (a cut of two pieces through the
boolean), integration tests naming solidcraft_kernel::MeshTolerance.
Deleted, testing internals that are gone: boolean_history_tests' glue_merges_across_the_seam
and faces_pushed_apart (coplanar::glue, boolean_apart), planar_fallback (polybool's
planar_boolean) and bore_union_of_a_bore_in_two_arcs_has_no_history (coplanar::bore_union);
issue_851's the_sphere_at_a_box_corner_is_the_planar_corner_builders (blend_vertex); pinch's
prism_boolean shell check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 018bdbad3f kernel: tests.rs reads the record
The truck reads become record reads: an intersection edge of a moved cut, the fillet
mitre edges sampled with CurveEval, the cache estimate from the record's faces and edge
uses, holed faces by their loops. The drain pads and the coincident-faces booleans keep
their volumes and faces without the boolean diagnostics and the polygon boolean.
Deleted, testing internals that are gone: a_tapered_s_curve_is_cut_into_pieces_that_follow_its_offset
(build::offset_error/offset_splits), planar_fallback_names_the_curved_faces (the polygon
fallback), mixed_loop_blend_guards_selection_and_construction and
loop_chamfer_mixed_arc_and_line_uses_offset_intersections (loopblend),
an_attempt_budget_stops_the_boolean_and_is_shared_by_nesting (with_attempt_budget),
placing_a_body_does_not_turn_its_revolved_faces_again (REPHASED, truck's revolution phase),
and the truck debug runs debug_coplanar_union_rate, debug_truck_sphere, debug_sphere_patches,
debug_sphere_cases, debug_sphere_rotations, debug_cube_sphere_measure, debug_heal_sphere_cut,
debug_coplanar_cylinder_union, debug_drilled_hole, debug_face_param_areas and
debug_revolved_tube_cut (truck_shapeops booleans, build::sphere_patches).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 623f1b9c16 kernel: native and SMLib-import tests on the record; the adapter's tests go
native.rs's test module keeps its encode/decode, wire-record, hostile-input and appearance
tests. Deleted with the adapter they tested: pcurves_on_planes_are_the_curves_mapped_exactly,
pcurves_fit_curved_faces_within_tolerance, pcurves_of_seams_lie_a_period_apart and
pcurve_pictures, with their helpers (pcurves_of, check_pcurves, check_faces, curved_bodies,
seam_faces, draw). smlib_import_tests count shells on the record; their notes no longer
speak of truck.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 8237cc927d kernel: mesh, lump, loft-rail, untouched-face and intersection-curve tests read the record
- thin faces: the face pinched against its own edge is a record sheet (sew::assemble) meshed
  by the body's mesher; its triangles still cover its boundary polygon.
- trimmed loft faces, loft rails: distances to faces through the record's SurfaceEval.
- untouched faces: edges and in-line stations from the record's edges and vertices.
- intersection curves: the #1252 regression on a record sheet whose edge is a traced
  intersection of parallel planes: meshing neither panics nor goes non-finite.
- lumps: shells counted on the record; the certified witness is Brep::compound of its three
  bodies, faces known by surface and box.
- Deleted, testing internals that are gone: intersection_curve_tests'
  degenerate_intersection_polylines_return_none_without_panicking,
  closed_intersection_retains_the_closure_and_spherical_supports and
  open_intersection_keeps_endpoints_on_both_planes (truck's IntersectionCurveWithParameters)
  and a_result_with_an_edge_that_does_not_evaluate_is_refused (boolean_record::edges_evaluate);
  body_lump_tests' unowned_overlapping_and_touching_cavities_are_errors_not_dropped_geometry
  and shortcut_clearance_refuses_curved_contact_hidden_between_mesh_vertices (truck shells
  joined without regions, separated_lumps) — kept as spheres_apart_join_as_two_lumps — and the
  shell-order permutation of nested_cavities (the record names each cavity's region).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 e1b9ea10cc kernel: placement, history, mesh-memo, display and issue tests read the record
- placement: a rigid placement moves the record and nothing else (regions, shells, loops
  with their pcurves, edges and their uses equal; every vertex moved; the identity's
  history), on a cylinder whose wall's loop uses its seam twice.
- issue 2005, 616, 674, 1038, 1510, join between caps, regularization protection, history,
  mesh memo, display mesh: the truck reads become record reads (shells closed by edge
  uses, faces by the record's surfaces, vertices by the record's points, the mesher's own
  boundary budget); the nearly-in-plane slab of 1510 is an extruded record body.
- Deleted, testing internals that are gone: issue 616's glue_joins_every_face_the_pieces_share
  (coplanar::glue) and the_retry_guard_refuses_changes_away_from_the_tool
  (boolean_guard::check_retry); issue 674's partial_contact_does_not_join_tangent_or_separated_faces
  (coplanar::imprint_union); issue 1038's hinted_division_matches_the_search_from_nothing
  (truck's vendored parameter_division); issue 1510's a_face_close_to_the_plane_but_off_it_is_not_moved
  (ops::off_plane). The boolean-diagnostics assertions (no retry, no tool nudge) went with
  capture_boolean_diagnostics; the rest of each test is kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 1b7fda4d33 kernel: surfaces and SMLib blends without the smlib feature gate
solidcraft-smlib is a dependency of every build (it answers NotBuilt without
SMLib), so the SMLib sides of surfaces.rs and blend_smlib.rs no longer sit
behind cfg(feature = "smlib"), and their stub modules go; blend_smlib's tests
run in every build like the rest. This also uses offset_backend::thicken and
the smlib_sweeps curve conversions in builds without the feature, which left
them unused there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 dead22ba7a kernel: corner rules for direction, rails and closed paths; no feature gate on SMLib sweeps
The three refusals of the cornered controlled sweep become the owner's rules:
- an orientation direction turns the section about the corner's binormal like
  any sweep, then turns it back about its normal to the direction's frame
  evenly along the next run, as a twist (direction_offset: the turn between
  the carried section and the direction law's section there);
- guide rails follow a path with corners when each rail has a corner of its
  own at every corner of the path, in the plane halving it and by the same
  turn about the same axis; the rails are cut there into each run's
  (run_rails), anything else is refused with the corner named;
- round a closed path with corners the first run starts from the closing
  mitre and the last ends on it; a twist is allowed where the profile maps
  onto itself (closing_offset), an end scale is refused.
Each run's station count now follows its own turn, twist included.

solidcraft-smlib is a dependency in every build (it answers NotBuilt without
SMLib), so smlib_sweeps' imp is no longer behind the smlib feature and its
stubs and not_built go; polyhedron calls offset_backend in every build.
Deleted as unused: sweep_path::{closed_path, turn, stations}.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 caa5ed0e63 kernel: twisted and scaled sweeps round corners by the plain sweep's corner model
A sweep that twists or scales refused any path whose direction jumps by more
than 1e-3 rad, a branch on the path's shape. It now takes the corner model of
the plain sweep: each smooth run is swept through stations by the laws a smooth
path has (twist and scale running with the length along the whole path, each
run going on from the section the last ended with), and the runs meet at each
corner in a mitre. Turning with the path, each run goes on past its corners as
a prism of its section there (the laws hold still across the mitre: the two
runs' sections meet on the plane halving the corner only when both are the
corner's section) and is cut back to that plane, then turned through the
corner onto the next run; only moving along the path, the runs meet at the
corner's section. The mitre plane is one function for both (mitre_of).

Refused, with the reason, where a control has no meaning at a sharp corner: an
orientation direction (it turns the section by its own turn, not the corner's,
so the two runs' sections don't meet), guide rails (their sections jump where
the path turns), and a closed path with corners (a twist or scale keeps the
last section off the first).

(not built: base in progress; no error in these files)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 337b8096f9 kernel: dead code the ports left is gone; core files formatted
(sheets agent's f57070d7 merged before this)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 206c53487e kernel: dead code the ports left behind, deleted
Every lib warning under --features smlib outside the files agents are editing
(assemble.rs, sweep_path.rs) pointed at code nothing calls any more:
- body: shell_nesting;
- boolean_record: of_pair and its Traced alias;
- planar_regularize: the generated-wall regularization (and its branches in the
  certified one, which was its only other path); planar_sources:
  with_shell_planar_sources;
- plane_fit: plane_through, EdgeSampler, planar_face, plane_frame (the patch is
  fill's); only loop_area is left;
- polyhedron: solve3; prism: wall_along; offset: Surf::normal;
- record: regions, region; shell_groups: groups, parents and their limits;
- splitface: side_of_point, Analytic, analytic_face, face_sides, canonical;
- spline_conv.rs, all of it (surfaces builds NURBS records); an unused import in
  tess/uv.rs.
The tests of deleted items go with them: prism's wall_along test, the shell
grouping test in body_lump_tests, and the generated-regularization assertion in
regularization_protection_tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00