Commit Graph
3432 Commits
Author SHA1 Message Date
Brett LawsonandClaude Opus 5.5 0abd028304 Merge ws/check: the body check runs on solidcore's check_brep (solidcore#1419)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 22:46:31 +01:00
Brett LawsonandClaude Opus 5.5 b8c2282090 solidcore: run the body check (smlib_brep_check) on solidcore#1419's check_brep
The check is the capi's call sequence on solidcore's public check API: ValidatePointers, then,
when that fails nothing, AssertValid over the whole body at the requested level. The report
keeps the capi's lines: "<type>::Test #N <name>: <message> [owner <type>]", the line for a
failed status with no report, and "AssertValid skipped". The failure count is the capi's: the
skipped line is not counted.

The check never reports a body valid after running fewer tests than the C++ kernel. A test
solidcore has not ported fails it with "not supported yet". So does a body whose geometry
owners are named by keys the check cannot know: NamingScheme::Unknown, or Caller other than
SolidCraft's own array import. check_brep would check those against arena identities and fail
SmBrep test 61 on every edge. Bodies imported from arrays are checked with the import's key_of.

The primitives' check and check parity tests run again. New tests: a valid box passes level 2
with an empty report on both kernels, and a box with a vertex moved 1 mm off its edges (made
through the arrays) gets the C++ kernel's report, line for line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 22:13:42 +01:00
Brett LawsonandClaude Opus 5.5 0d3c46dad2 solidcore: move the pin to 6a068272 (main, with solidcore#1419 WP4: the level-2 AssertValid tests and SmSurfOfExtrusion::AssertValid, #1578)
Turns on the new flags transform_scales_each_tolerance and
transform_model_size_from_body_box.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 22:06:55 +01:00
Brett LawsonandClaude Opus 5.5 98e5e7a05d Merge ws/convroute: Convert runs on solidcore by default
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 21:58:47 +01:00
Brett LawsonandClaude Opus 5.5 1f8d8fa9a8 Kernel routing: records convert on solidcore by default
Op::Convert moves to Backend::Solidcore: a schema 4 record becomes a solidcore body
(Brep::from_record, from_record_keeping_splines) and a body's arrays for the record mapping come
from solidcore (Brep::arrays, so to_native, to_native_report, to_native_ordered). A C++ operation
still gets its own body from solidcore's arrays through the flat import, when it asks for one.

Rig (cargo xtask kernel-cases, 479 cases, solidcore 3c17ddb1):
- convert routed alone (--kernel solidcore --route convert=solidcore): 450/479 against SMLib's
  449; 478 agree, the other (fillets/1557) fails on SMLib and passes on solidcore
- the new default table (--route primitive=solidcore,convert=solidcore): 450/479
- SMLib only (plain run, SOLIDCRAFT_KERNEL=smlib): 449/479; the only case that differs is 1557,
  better on the table

Against SOLIDCRAFT_KERNEL_ROUTES=convert=smlib, no test fails that did not already: smlib with
and without native, solidcraft-kernel --features smlib, the engine lib tests with --features
smlib, and the naming corpus (the same 116 designs differ, with the same output).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 21:53:25 +01:00
Brett LawsonandClaude Opus 5.5 22a1c20b1d solidcore: move the pin to b3baca8e (main, with solidcore#1490 and #1491: a revolve's torus is never inside out and keeps the flag, and a one-circle full turn puts its seam at the profile)
Turns on the new flags torus_keeps_inside_out and internal_pole_row_through_knot.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 21:23:31 +01:00
Brett LawsonandClaude Opus 5.5 2f623f3f22 Merge ws/devmerge2: develop ac52443d, and ablasik's cone export fix
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 21:23:05 +01:00
Brett LawsonandClaude Opus 5.5 9c7c139bdd solidcore: move the pin to b19dbcb5 (main, with solidcore#1476: a shell's implicit offsets take every base upstream casts to a B-spline, and the offset sample bound scales with the input)
Turns on the new flag torus_iso_circle_axis_from_midpoint.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 20:50:45 +01:00
Brett LawsonandClaude Opus 5.5 1f6def9d72 smlib: drop the cone test's gate on a solidcore feature this branch doesn't have
The export tests module is already gated on `native`; the cherry-picked test's
`any(native, solidcore)` names a feature that isn't declared here, which
clippy -D warnings rejects as an unexpected cfg.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 20:41:47 +01:00
Andrzej Błasik b4fb9188ad fix(smlib): export a cone of rounding-size half angle as a cylinder
The portable record rejects a cone with |half angle| < 1e-12; a52's thread
cones come out of the trims at 1e-13 and failed 10 features with
'cone dimensions'.

(cherry picked from commit d5d74105a2)
2026-10-29 20:34:36 +01:00
Brett LawsonandClaude Opus 5.5 03f97cd1d1 Merge origin/develop (ac52443d) into solidcore
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 20:34:36 +01:00
Brett LawsonandClaude Opus 5.5 8ec45a0f4d Merge ws/draft: draft faces through SmBrep::LocalOperation on solidcore
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 20:04:37 +01:00
Brett LawsonandClaude Opus 5.5 ca6a7ef21e solidcore: draft faces through SmBrep::LocalOperation (solidcore PR #1427)
core::offset::draft now finishes the capi's draft_faces: each picked plane is
copied, turned by the angle about its hinge on the neutral plane
(RotateAboutAxisAtPoint about n x pull), and solidcore's local_operation puts
the tilted planes in, under the offset calls' notification stores; its status
maps through the module's status() and the result through finish(). The tail
is adapted from ablasik's draft in crates/smlib/src/ffi/rs_ops2.rs on
ablasik/solidcraft app/solidcore-backend-on-develop (9c7e8e31), reordered to
follow the capi line for line and using core::offset's errors and checks
(ATTRIBUTION.md, Recovered contributions).

The capi's moved_faces check (SMLIB_ERR_NO_EFFECT when no result face lies on
a marked surface) is not made: solidcore surfaces carry no attributes and the
local operation reports no face history (solidcore#1462). Face moves stay on
SmOffsetFacesExecutive (#1060) and are still refused.

draft_box_sides is no longer ignored; draft_one_side, draft_one_side_out and
draft_one_side_hinged_at_the_top check the single-face wedge (a h^2 tan(t) / 2)
against both kernels.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 20:04:09 +01:00
Brett LawsonandClaude Opus 5.5 c191634b54 solidcore: move the pin to 7ca6ce7a (main, with solidcore PR #1427 SmBrep::LocalOperation, #1474 Nx1 corner, and fixes since 3c17ddb1)
Turns on the new flags local_operation_offset_status, torus_major_radius_from_origin,
fillet_corner_sphere_from_four_arcs, fillet_nx1_opposite_continuation_side_edge and
fillet_trace_rejects_short_step.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 19:09:36 +01:00
Brett Lawson 095044d539 Merge branch 'solidcore' into ws/convroute 2026-10-29 19:09:33 +01:00
jyvikoandClaude Opus 5.5 ac52443dfb Ring tests: a cut's volume is the piece it took, not the difference of the ring's volumes
notch_into_a_ring_chamfer_is_cut_exactly measured the notch as the ring's mesh volume before less
after (0.2906 against the integral's 0.28665) and oblique_cuts_through_a_chamfered_ring_are_exact
compared the two mirrored cuts the same way (3.3e-4 apart). The cut is right: the ring less the
cut ring is a piece of 0.2866521 mm³, the integral to 2e-6. A difference of two 1149 mm³ volumes
is not: the re-tessellated ring's mesh volume moves by 4e-3, and SMLib's mass properties (at
their finest, 1e-4 asked) by 1.5e-6 of the ring, 1.7e-3. Each cut is now measured as the piece it
took away (the ring before less the ring after, an SMLib boolean), to 1e-5 of the integral and
1e-6 between the two mirrored cuts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 b6b59e7b3b Naming tests: pieces of one name on a grooved disc, the merged boss wall by its point
SMLib keeps a whole cylinder one face and the arm's round end and the boss over it (one
cylinder) one face, named for the arm's end. Three naming tests relied on truck's pieces:
- a_cut_through_one_of_two_bosses_names_only_its_own_walls finds the boss's wall by a point
  on it (the centroid of truck's half cylinder lies on nothing now) and checks it keeps its
  name through the cut and the fillets;
- split_pieces_keep_their_numbers_across_evaluations keeps the torus (its sweep's walls are
  whole now, their names stable) and adds a disc whose top a round groove splits into
  F1:top#1 and #2;
- a_design_saved_before_pieces_were_numbered_by_place_keeps_their_numbers uses that disc,
  whose kernel order numbers the pieces the other way round from their place (the post's
  side of multi-body-join-cut is one face now).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 c93b3ad5ab Engine tests: SMLib's builds where truck refused or approximated
- shell_tangent_chain_that_opens_every_face_explains_how_to_keep_walls: the shell is the
  rounded box (its 37 x 27 x 57 core grown by the 1.5 ball: 71753.436) less the sharp 36 x 56
  x 28 cavity, 15305.436, to the measure's 2e-7 (SMLib: 15305.445); truck's was 15305.28.
- press_pull_on_curved_faces: the shell's inner wall behind a fillet is offset as a face
  (SMLib builds it, truck refused it as tangent to its neighbours): pulled 0.5 into the
  cavity it adds exactly the quarter ring π/4 (3² - 2.5²) 18 = 38.877.
- revolve_cut_round_a_box_corner_does_not_panic: the side face is picked by its point; the
  report's face index was truck's face order (SMLib's face 1 is the opposite side).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 24bcaca039 Engine tests: SMLib's faces, not truck's pieces, in the face counts and measures
SMLib keeps a whole cylinder (and an arc of one past half a turn) as one face closed on its
seam, where truck split it in two; its holes are exact circles; its mass properties come
within 2e-7 of a closed form. The tests that counted truck's pieces or its polygon hole now
check the exact geometry:
- extrude_of_adjacent_profiles_has_whole_edges: the cut-off cylinder is 4 faces (arc side
  4674 = 40·(2π − 1.2019)·23, chord side 1039.8, two ends);
- step_export_of_an_enclosure_with_a_screw_hole: 27 faces, as the file holds them;
- model_faces_gives_a_point...: the hole's wall is one cylinder, its centroid on the axis;
- draft_takes_a_cylinders_side_by_name: one side face (the draft itself waits for SMLib's
  draft of a cylinder);
- convert_to_sheet_metal_takes_the_plates_face_by_name: 15000 − 62.5π to the measure's 2e-7;
- a_checkpoint_survives_file_new: a unit box measures 1 + 2e-16;
- creating_a_component_recomputes_nothing: SMLib's boolean keeps the face certificate the old
  setup relied on losing, so the legacy face plane is made as a design saved before face
  attachments were certified (its anchor removed) and reopened.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 ab68a3d0fb View tests: the section cap test draws the cap in the cap colour
Since the section hatch per part (#8529), a cut is tinted toward the hatch colour its body's
name picks; Body1 picks the steel one, so the cap test's warm pixels were none
(cpu_picture_section_caps_hide_the_inside). The test turns the part hatch off: it checks that
the cap hides the inside and shows its colour, which the hatch tests cover per part.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 ca53656a20 Schema tests: an empty face list is checked on the draft, which refuses it
solid.shell takes faces: [] since 1df330c79 (a closed hollow body), so its row in
shared_types_keep_the_handlers_messages no longer matched the shared FaceRefs message. The row
uses solid.draft, which still refuses it; FaceRefs says shell's exception.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 ee9fc37935 Tests: a torus patch to thicken is cut from SMLib's one-face torus
SMLib makes a torus one face, so the face at (25, 0, 0) was the whole torus,
not a patch within half a turn each way. The patch is now the torus's piece
with x, y > 0 and z > 1, bounded by iso lines both ways (planes through the
axis, and z = 1 round the tube), and its thickened volume is the formula's
over the angles its mesh spans. (The sphere cap above it builds once SMLib's
offset takes an open edge's second trim point away from its first: SMLib
devgreen-kernel-geometry; waits for the pin.)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 b9d65e6bc8 Tests: thicken across a sharp edge extends the offsets until they meet
SMLib thickens a sheet across a convex sharp edge as other CAD does: each
face's offset is extended until the offsets meet (and trimmed where they
cross inward), where truck bridged the gap with a wedge. Owner decision:
keep SMLib's result. The exact values:
- three faces of a 10 box's corner out by 1: three slabs, a 1 × 1 × 10 block
  along each edge and a unit cube at the corner, 300 + 30 + 1 = 11³ − 10³;
- into the inside corner by 1: 10³ − 9³ (it was refused); half each way:
  10.5³ − 9.5³ (refused too);
- two faces across one edge: 2 · 100 + 1 · 1 · 10 = 210.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 8075b8f70f Tests: a swept point path is its lines, and rails must turn with a cornered path
A sweep along points follows the lines between them (no wall is fitted through
the points, sweep_sheet_points' contract, as sweeps_along_3d_paths already
says): along a quarter circle of 41 points the sheet is a wall per line, 40,
its area 10 × the polyline's length (within 10⁻⁴ of 10 × 15π); the bent chain
is 2 × 40 walls sharing every seam, 2·41 + 3·40 edges.

SMLib's sweep takes guide rails along a cornered path when each rail turns
with the path at its corners; a straight rail along a bent path is refused
for that reason, not as "guide rails along a path with sharp corners".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 6c9c679dcc Tests: a revolved sheet over one radian is one face, untrimmed over its whole span
SMLib revolves the cone frustum's sheet over angles 0…1 as one face, where
truck made two of half a radian each; the face's own span is angles 0…1 by
profile parameters 0…0.8: √125 · ∫₀^0.8 (5 + 5t) dt = √125 · 5.6.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 2c341006a0 Tests: a cylinder's side and a sphere are one face each, as SMLib builds them
SMLib makes a cylinder's side one face closed round its seam, and a sphere one
face; the tests picked "one half" of the side or "one sixth" of the sphere, which
were truck's pieces. The offset test moves the whole side (one face, area
2π·12·20); the thicken test takes half the side from a cylinder split at x = 0
(π·(11² − 10²)/2·20) and the whole side inward (π·(10² − 9²)·20); the sphere
test takes the cap above z = 5 (solid angle π: π/3·(11³ − 10³)).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 98284eb1e1 Tests: a box thinner than a body's tolerance may be refused instead of getting no certificate
prism_measure's uncertain-material check built a 20 x 20 x 1e-5 box and asked that it get no
cap certificate. SMLib refuses that box (its loops fail SMLib's orientation check): at 1e-5 it
is half a body's tolerance (2e-5) thick, no solid. Refused or built without a certificate, the
property holds.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 908bc756c6 Tests: the matchsurf and mixed-fillet helpers read an edge on the curve its interval is on
edge_at (matchsurf) and the mixed fillet mitre check evaluated `e.curve` at parameters from
`e.interval`, which is the interval on the edge's NURBS form when it has one (SMLib's edges
do): they picked and sampled the wrong points. They now evaluate `e.parameters()`, as the fill
helpers do since aa534cc6d's fix on the kernel-geometry branch. (Both tests still fail, for
their own causes: the G2/G3 match leaves a curvature jump of 2 at the seam, and SMLib's mixed
blend lies 4e-7 off its section circle.)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 30ceb44e6d Tests: SMLib's faces, one per swept segment, closed along a seam, replace truck's halves
Truck split what it swept: a big arc into two faces, a full circle into halves, a turn into
two or three parts, a sphere into six patches, a torus into six; it numbered boxes' faces in its
own order and sewed stepped cuts slab by slab. SMLib sweeps each profile segment into one face,
closes a full cylinder, sphere or torus along one seam edge, and cuts without slabs. The record,
face source, helix, display mesh, measure and boolean history tests still expected truck's
pieces. Each expectation now follows the geometry, checked by the tests' own independent
measures: every face's origin against the profile segment its mesh lies over (unchanged),
faces picked by where they lie instead of by truck's face numbers, and the merged counts by the
kernel-cases ladder's rule (each whole curve once, and each cylinder's seam): a cylinder 3
faces, 3 edges, 2 vertices; a ball cut from a slab 7, 14, 10. The truck-only stepped-prism
check (walls coalesced across slabs) becomes the property it stood for: the stock's walls stay
whole, one face each, Kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 3c680d21a9 Geometry: the closest point on a full circle just before its start is found before its end
Seg2::closest_param starts Newton from the nearest of 65 samples. On a closed segment (a full
circle) the start and end samples are one point and the first wins the tie; for a point just
before the start (in the sweep's sense) Newton then wants a parameter below 0, the clamp holds
it at 0, and the answer is the start point, off by up to a sample spacing (0.15 mm on a 5 mm
circle). The record tests' face-to-segment matching read an SMLib cylinder's side as lying
over no segment because of it. A closed segment whose answer lands on an end now also tries
Newton from the other end and keeps the nearer; every other answer is bit for bit as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 d0daee90ff Tests: a cam's edge is picked on its rim, off the vertex where its circle's seam meets it
picked_edges_give_the_sketch_s_table picked [E + R, 0, 5]: on SMLib's extruded circle that is the
vertex where the side's seam meets the top rim, a pick either edge answers, and it took the
seam. The pick is now a quarter turn round the rim, [E, R, 5]; the product's pick rule is
unchanged (owner's call).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 da4f122f4c Tests: a face picked by point is found on a block of 256 drilled holes, as on #6720's thread
a_face_picked_by_point_on_a_block_with_a_modelled_thread_is_found guarded #6720 (the face search
charged the whole mesh once per face) with a modelled thread's 5 000 facets. On SMLib a modelled
thread is a few exact helical faces, so the block had nowhere near the 1000 faces the test
asserts, and the case no longer reached the old charge. A block drilled with 16 x 16 holes does:
the test now asserts its faces times its mesh's triangles is past the search's 2 000 000 budget
(the old charge) while their sum is well inside it (the new), then picks its top by point.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 913a61329a Tests: a tilted cylinder's Intersect cut is checked on the cylinder, not by its mesh's count
intersect_keeps_its_exact_cuts pinned the tilted cylinder's section to 21 segments and one
segment's ends to 1e-4: the crossings of truck's mesh. The cut is the mesh's segments, as many
as the tessellation crosses (20 on SMLib's), each end within the section's reach of the surface,
the display tolerance (a thousandth of the mesh's size, doc::project::fit_segments; SMLib's ends
lie 6e-4 off at most, the test's limit is 0.051). The test now checks that every curve is a
line, at least 16 of them, and every end lies that close to the cylinder of radius 5.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 93bbde86ef Tests: a script keeps a fillet a parameter makes impossible, a radius below zero
ids_names_suppression_marker_and_failures_survive needs a feature that a parameter change makes
fail, to see the failure survive the script's replay. It made a 1 mm round 50 mm, which truck
refused as too big; SMLib builds a convex round wider than its faces by subtraction (the owner's
overflow decision), so that round now succeeds. A radius of -1 mm fails on any kernel, and the
replay still has to keep the failing feature, its id and its marker.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 138acad018 UI tests: a frame member's volume is compared to the accuracy SMLib measures at
a_whole_sketch_section_stays_whole_through_an_edit compared the ring member's volume before and
after turning its section 30° to 1e-6. kernel::measure integrates at SMLib's finest relative
accuracy, 1e-4 (measure::ACCURACY, the clamp SmApiBrepComputeMassProperties documents): the
exact π (20² − 17²) 600 = 209230.07 mm³ came out 209229.86 before and 209230.43 after. The
test compares to 1e-4; the filled circle it guards against is 3.6 times the ring.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 b71e5ae6f4 Tests: edges are read on their NURBS forms, a chamfer's chain is its caller's, the cap test's hatch
- An SMLib circle edge's `interval` is on its NURBS form (`Edge::parameters`), and an analytic
  face's `domain` on the form's (u, v). edges_are_on_smlibs_curves evaluated `curve` at the
  form's interval and took the domain for angles; it checks the side's whole turn and height
  on the form and a rim's turn by `curve_interval`. The tangent hole test's edge middles were
  read the same way (the copy seemed to join faces on opposite sides of the line).
- kernel::chamfer blends the edges it is given; a feature's pick is extended by
  kernel::tangent_chain first (doc eval). The chamfer tests do the same:
  one_chamfer_pick_follows_the_tangent_chain_at_any_part_size removes its 54.66 mm³ again.
- Since the section hatch per part (#8529) a cut is tinted with the hatch colour its body's
  name picks (Body1: steel); the GPU cap test turns the part hatch off, as the CPU one does
  (2885f101b on devgreen-engine-builds).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 2523d13cf0 UI tests: SMLib's cylinder has one wall and one edge per rim; split rims come from two arcs
truck made a cylinder's wall and rims in halves; SMLib makes one wall face and one closed edge
per rim (one face per profile segment, a circle being one closed curve since 09c979a4b). The
tests of what joins a rim's or a wall's pieces for picking, measuring and the agent chat
(circular_rim_hover_click..., circular_items_measure..., curved_face_hover..._cross_the_seam,
a_rim_clicked_once_is_one_item_not_its_pieces) now build their cylinder from a circle drawn as
two half arcs, extruded, so the pieces they test exist. A ring's outer circle is one wall face
(configuration_annulus_picker...: 1, was 2). The certified small crease is no longer taken for
a seam (truck's coarse fit did; the seam flags compare exact surfaces now) and, a kink of a
millionth, is smooth for the shading while still a measured crease: sharp, drawn in wireframe,
picked (smooth_edges::Join).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 ff0dda5377 UI tests: picks that name one thing, and a thread that names its start
- The shaft's rim was picked at its polyline's first point, the vertex where the wall's seam
  meets it, as near the seam as the rim; SMLib's cylinder lists the seam first, so the pick
  took it ("the edge is not circular", "the revolve axis does not lie in the sketch plane").
  The rim is picked at its middle.
- The gear discs touch at x = 10, on both walls; G1 is picked on its far side.
- 366b90597 refuses a thread of some length picked in the middle of a face free at both ends
  and asks for `from`; the cosmetic thread test gives it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:20:38 -04:00
jyvikoandClaude Opus 5.5 b2c5b1f5e9 Designs before format 14: a split's pieces take the names its later features use them by
Builds before format 14 named the pieces a cut splits a body into in truck's shell order, and
the later features of such a design name the piece they work on by that name. SMLib orders the
pieces otherwise, so split-body-pieces' fillet and chamfer landed on the wrong piece, its
reference "no longer exists" (design_corpus body_names_saved_before_exact_history_keep_their_pieces,
old_designs_open_and_evaluate_as_saved). For a feature saved so (`shell_piece_order`), each
name its pieces are known by goes to the piece the points the later features naming it picked
lie on; a name no later feature uses keeps SMLib's order, and so do all of them where the picks
do not tell the pieces apart. docs/compatibility.md says so.

That makes the feature's result depend on features after it, which neither its fingerprint nor
its cache key cover: a script replays the design one feature at a time, so the split was
evaluated before the fillet and chamfer existed, kept SMLib's order, and was reused once they
came (script_roundtrip corpus_designs_replay_from_their_scripts: 'Body1 (1)' 4765.663706234679
opened against 4765.663706134907 replayed). The state now keeps a digest of the picks it named
the pieces by (`ModelState::legacy_picks`), and every reuse (the last results, the cache, the
kept, rolled-back and primed results) takes a state for such a feature only while the design's
later features pick the same, so the replay names the pieces again as the file does when it
opens. A saved model's states carry no lineage and are taken as saved.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:16:22 -04:00
jyvikoandClaude Opus 5.5 73b028b5b0 Kernel: a drafted extrusion of a profile with holes, every wall leaning on the material's side
SMLib's draft extrusion takes one loop, so a tapered extrude of a region with holes was refused
("SMLib draft extrusion of a profile with holes"), and designs that use one no longer opened
(modern-plastic's Rest: design_corpus, action_matrix a_small_hole_through_the_wall_of_a_plastic_rest).
As other CAD does, every wall now leans by the taper relative to the pull on the material's
side: the outer loop is drafted, and each hole, taken counter-clockwise, is drafted the other
way and cut from it, so a taper that narrows the outer boundary widens the holes. Exact: each
loop is SMLib's draft extrusion of it, the walls' roles are found as the foot's are. Refused,
saying why, where the taper would make a hole meet the outer wall or another hole at either
end of the extrusion.

Test: a 40 mm square with a 10 mm square hole, 30 up at 5° inward, is the one frustum less the
other to 1e-6 with ten faces; at 30° the hole would pass the outer wall and is refused.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:16:22 -04:00
jyvikoandClaude Opus 5.5 68a217d980 Reference tests: the loft case is analytic, SolidCraft's correspondence with its closed form
17-loft's expected values were FreeCAD's (OpenCASCADE's Part.makeLoft), which runs each side of
the square to its quarter of the circle at uniform angle (arc length). That correspondence has
no exact rational B-spline form, and SolidCraft keeps its surfaces exact: its ruled loft runs
each side to one rational quarter of the circle's B-spline by their own parameters, 35080.7251
mm^3, 0.13% less (the oracle failed on volume and the second moments). The owner chose this
correspondence. The case is now worked out in tools/oracle-analytic/cases_basic.py: the section
area is quadratic in t with the loops' mixed area, so volume and centroid are closed forms of it
(the mixed area and the wall area by Gauss-Legendre on the exact rational arcs); its note says
why it differs from OpenCASCADE and gives that volume, and its `compare` leaves out the surface
check against OpenCASCADE's reference.stl. All its checks pass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:16:22 -04:00
jyvikoandClaude Opus 5.5 319e6b8b3b Kernel tests: the chamfer on a tangent wall junction is measured on meshes fine enough
chamfer_the_top_lip_at_a_tangent_wall_junction measured the removed volume as the difference of
two meshes at chord 0.0005. The display planner meshes the two bodies differently, so their
chord errors no longer cancel as truck's meshes did: 37.404, 37.672, 37.761 and 37.759 mm³ at
chords 0.002, 0.0005, 0.0001 and 0.00003, converging on the expected 37.762 (the chamfer as the
chord between the contact lines of a 2 mm ball, integrated exactly). SMLib's chamfer is that
one; the test measures at chord 0.0001.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:16:22 -04:00
jyvikoandClaude Opus 5.5 426a505a87 Display meshes: tests count the planner's grids; a mesh's outline is one line per straight edge
The display mesh is the tessellation planner's (8b6bfc48c: the mesher plans a schema 4
record), which grids a planar face with no side longer than a fifth of the body's extent
(docs/capabilities.md, "Display meshes"); truck's mesher gave a box face two triangles. The
tests that counted truck's mesh now count the planner's, worked out by hand from that rule:
- a 10 x 20 x 30 box (37.4 mm diagonal): edges in 2, 3 and 5 pieces, faces of 2 x 3, 2 x 5
  and 3 x 5 cells, 124 triangles; welded, the box lattice's 3 x 4 x 6 nodes less the
  1 x 2 x 4 inside it, 64 positions (obj_export_is_welded_and_keeps_names);
- a 20 x 15 x 10 box: 4 x 3, 4 x 2 and 3 x 2 cells, 104 triangles (an_opacity_class_change...);
- a 20 x 20 x 10 box saved as a mesh: its edges in 4 and 2 pieces, 40 segments per box
  (imported_mesh_edges_draw_in_each_style...);
- the cylinder's top cap is under a third of its triangles (select_other_over_a_dense_cluster...).

An imported mesh's outline was one line per crease side, so a box exported at that spacing
showed each edge in pieces: a click on a 10 mm edge measured 5 mm, or hit the node between
two pieces (measure_imported_stl_edges_and_vertices..., mesh_outline_hover_cache...). Outline
sides that run straight on through a vertex no other outline side meets are now one line, as
the CAD model's edge was.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:16:22 -04:00
jyvikoandClaude Opus 5.5 983b1ca8f0 Sketch projection: a projected face's curves meet at the face's vertices
A face's edges are projected exactly: lines, and arcs read off SMLib's NURBS within the
planar-edge tolerance (Body::planar_edges). An SMLib shell's offset corner is a NURBS whose
arc came out with its centre 2e-6 mm off and its ends up to 6e-7 mm from the lines they meet,
beyond the link's merge tolerance (1e-7): the inner loop of the sensor enclosure's case top
projected as sixteen loose curves, the offset of one found no chain to follow, and the Lid lip
extrude found no profile l13..a16 (the five acceptance scenarios, action_matrix
an_axis_through_a_corner_round_that_a_parameter_moves). Each edge's pieces now end on the
edge's vertices where they lie within the edge's and the reading's tolerance of them (the
vertex is the point both edges share), and an arc whose ends moved takes the centre nearest
its own that is equally far from both, so the sketch keeps both ends on its circle.
Body::planar_edges_tolerance names the reading tolerance planar_edges uses.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:16:22 -04:00
jyvikoandClaude Opus 5.5 271f0c5de1 STEP import: a face's loop through a pole closes its turn, so a dimple keeps its area
A round face's box (form::extent) unwrapped each periodic parameter from one boundary point to
the next. Through a pole the loop goes on from anywhere round the direction the pole collapses:
a hemisphere bounded by its rim and its seam put its second seam use on the first and its box a
quarter turn off the seam, while its pcurves ran from the seam. Past the first pole the loop is
now moved the whole periods that close it. Reference case 14's re-imported dimple had a
quarter of its area missing (9601 against 9706 mm2).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:16:22 -04:00
jyvikoandClaude Opus 5.5 4a0c139106 UI kit: a field's scenario handle is where the field shows
A field scrolled out of a dialog's field area still published its handle at the centre of its
whole rect. The tapped hole's dialog has grown (thread hand, tap drill, thread end rows) past
1000 px, so its section's Thread depth field scrolls under the footer, and a click on that
handle pressed OK: the edit was applied (tapped_thread_depth_field_keeps_focus_and_typing_...
saw the model change at the click; focusing a field commits nothing). A field's handle is now
the middle of its visible part and is left out when none of it shows, so a scenario can only
click where a user could; the rect keeps its whole extent. The test opens a window tall enough
for the section.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:16:22 -04:00
jyvikoandClaude Opus 5.5 6a6cd8f56c Sketch: a sketch's bounds reach its circles' and arcs' extremes
Sketch::bounds took the points of each segment's polyline. Since 09c979a4b a whole circle is
one closed arc whose chords start at its start angle, so none lands on the circle's left or
bottom: a radius 5 circle at (-300, 0) spanned x from -304.50, and Home and Fit framed short
of it (home_and_fit_frame_the_moved_body_not_its_old_place). An arc's bounds now add the
quarter points of its circle it sweeps through, which are exact.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:16:22 -04:00
jyvikoandClaude Opus 5.5 e657e40867 UI kit gallery: entries for the controls added without one
checked_field, checked_row and warning_caption (the fillet Setback check), text_field_tip (tap
drills), continuity_row, continuity_row_explained and continuity_tip (the continuity choice) and
steps (opening progress) are pub(crate) ui_kit functions with no gallery entry, which
gallery_covers_every_inline_element requires of every one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:16:22 -04:00
jyvikoandClaude Opus 5.5 7bb5bb3d56 Locales: Arabic and Hebrew for the version and section hatch labels
help.version (help-menu-version) and prefs.section_hatch* (section-hatch-by-part) came with
ja and zh only; ar and he are complete catalogs too, so
every_complete_catalog_carries_every_english_message failed on them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:16:22 -04:00
jyvikoandClaude Opus 5.5 43c1b7b881 UI tests: Isocurve Analysis's engine colour is drawn from the theme's accent
be859aa0d added `colors::ISOCURVE` to the engine palette; the GPU viewport draws iso curves in
the theme's accent (`scene_palette`, the isocurve pass), so the engine value is only the
headless snapshot's, like the body and grid colours. every_engine_colour_tag_is_placed lists
it with those neutral tags.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:16:22 -04:00