Commit Graph
1900 Commits
Author SHA1 Message Date
bherbruckandClaude Opus 5.5 0a054bcbdb kernel-cases: booleans from #3404-#4124 (28 cases, 76 skipped)
Cases: mirror of a cut under a wall (#4011), coplanar intersect (#3671), multi-lump
intersect (#3526), split along a face plane (#3447), 64-peg join (#3455), boss on a rod
(#3485), collinear cylinders and pin in a bore (#3497), swept G2 cut (#3604), spokes
tangent to a hub (#3612), sphere and pyramid (#3633), column in a channel (#3665),
extrude to a point on an edge (#3729), emboss on a cylinder (#3782), circle-only join
(#3841), ring on a perforated plate (#3887), symmetric revolve cut (#4008), walls round a
floor (#4058), slab beside a bore (#4095), and others. The rest are skipped with a reason
in skipped-c.json.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 05:57:05 -04:00
Brennen HerbruckandClaude Sonnet 5.5 e80dbde005 kernel-cases: sheet-metal skipped sources (87)
Every other sheet-metal-keyword issue and PR, one line each: UI, docs, file
format, naming and attachments, DXF output, feature requests, user designs
with no repro, and failures that belong to booleans, fillets, shell, sweeps
or threads.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-21 05:54:30 -04:00
Brennen HerbruckandClaude Sonnet 5.5 33a52ff053 kernel-cases: sheet-metal tray and unfold cases from #349, #405, #436, #514, #723, #1797, #3417
Trays at 72 degrees and with four angles and heights, a tray shrunk by a
parameter and unfolded, an L bracket unfolded and refolded, opposite flanges
at 105 and 120 degrees, torn corners folded, and a rhombus whose square
reliefs would overlap.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-21 05:54:30 -04:00
Brennen HerbruckandClaude Sonnet 5.5 76fede4276 kernel-cases: sheet-metal convert and unfolded tray cases from #479, #488, #723, #725, #839, #1092, #1285, #1481
Unfolded trays graded by the flat size W + 2(H - BD): torn, round and square
relieved corners, per-feature reliefs, rounded plate corners; a shelled tray
and a bracket converted at their bends; an L converted to the rule's radius.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-21 05:54:30 -04:00
Brennen HerbruckandClaude Sonnet 5.5 cce2c57b0b kernel-cases: sheet-metal flange and cut-out cases from #416, #529, #570, #601, #634, #659, #702, #978
A flange beside the leg of an L, along what a cut-out leaves of an edge,
beside a ledge as tall as its setback, a return on a flange's far edge, a
round hole, a slanted slot and an ellipse across a bend, a hundred slots with
four folds, and the refusal of rule values sheet.flange would ignore.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-21 05:54:30 -04:00
Brennen HerbruckandClaude Sonnet 5.5 7f9345608d kernel-cases: sheet-metal cut-out, flange and refusal cases from #296, #1095, #1280, #1295, #1311, #1979, #3078, #3234, #3324, #3353
Cut-outs folded and refolded, a hole square to a 45 degree flange, a slot
that parts a flange from its base, an inside flange on a plate turned
62 degrees, cuts after cuts, a hole beside two adjacent flanges and a flange
on a flange's side edge; refusals for a flange on a bend line and a flat
pattern after a fillet; a mirrored sheet body that must stay sheet metal.
Volumes by hand (K = 0.5 folds: flat area * t; otherwise bend volumes).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-21 05:54:30 -04:00
Brennen HerbruckandClaude Sonnet 5.5 5140736d1e kernel-cases: sheet-metal convert and hole cases from #774, #1040, #1092, #3316, #541, #542, #560, #955
Plates converted to sheet metal (holes, long thin strips, engraving, a
channel with modelled bends, position kept) and holes and cut-outs
through or into a sheet; volumes by hand from the plate and the holes.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-21 05:54:30 -04:00
Brennen HerbruckandClaude Sonnet 5.5 30796b2646 kernel-cases: sheet-metal fold cases from #262, #264, #638, #639, #685
Folds of tabs and plates, graded by closed form: a fold keeps the blank's
flat length, so V = flat area * t + theta * w * t^2 * (1/2 - K). Tabs
on one line (#264, #638), a tab on an L's inside edge (#639), a fold just
inside a tab root and a refusal at the root (#262), a fixed point on the
top face of a large plate (#685).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-21 05:54:30 -04:00
bherbruckandClaude Opus 5.5 9029c693f3 kernel-cases: booleans from #2896-#3383 (11 cases) and the skipped list
Cases for the near-contact gap join, a countersunk hole beside a distant
body, a perforated plate under a ring, a sealed void, a rim and tooth join,
a frustum cut, a line-to-line pin, a flush notch, spoke patterns and a join
into a rotated occurrence. The rest of the bundle is in skipped-b.json with
one line each.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 05:50:12 -04:00
bherbruckandClaude Opus 5.5 dfc6328ca7 kernel-cases: booleans from #2564-#2896 (11 cases)
Hand-derived cases for tapered and collinear extrudes, pattern and mirror
copies keeping their targets, a cut up to a face, a prism joined to a
round-cornered slab, a clip round a small hole, and near-contact joins.

2564, 2583, 2601, 2754, 2755 (pattern, mirror), 2801, 2810, 2826, 2580,
2896 (overlap)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 05:50:12 -04:00
bherbruckandClaude Opus 5.5 9824189915 kernel-cases: booleans from #13-#2534, first half (30 cases, 73 skipped)
Spheres cut twice (#1717), box/cylinder intersect (#1647), crossing cylinders
moved far (#1649), coaxial cut from a thin disc (#500), coincident cylinder
walls (#114, #2008, #1910, #1865), rim touching a coin (#168), holes along
walls and beside rounds (#559, #562, #1279, #1355, #2055), tangent holes
(#307), blind cut in a cylinder (#308), through-all cut (#423), shallow cuts
(#1858), skin left by a short cut (#1730), delete face (#1927), collinear
extrude sides (#1949), hidden bodies (#2464), mirror and patterns (#2003,
#2524, #2076), tapered extrudes (#831), text cut (#1195), split (#13).
Every other item in the bundle is in skipped-a.json with its reason.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 05:49:10 -04:00
Brennen HerbruckandClaude Sonnet 5.5 71841d3d5d kernel-cases: tessellation skipped sources (253)
Every other tessellation-keyword issue and PR, with one line each:
rendering and GPU drawing, UI, performance, display-plan plumbing, and
failures that belong to booleans, fillets, threads, import, shell,
sheet metal or crashes.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-21 05:48:32 -04:00
Brennen HerbruckandClaude Sonnet 5.5 57b72b5334 kernel-cases: tessellation cases from #311-#2712 (14 cases)
311 ramp cut across a round blank, 784/811 filleted and drilled bodies
for STL export, 818 blind hole in a filleted ring, 819/921 pocket that
splits a wall seam, 1263 concave arc with a knife-edge tip, 1615/1653
crossed lofted tubes, 1648/1850 sphere touching a box edge, 1666/1670
two twisted lofts, 1753 bowl rim cut by a cylinder, 1813/2712 lens face
thinner than the tolerance, 2069 notched ring moved far away, 2528
slot joined with an overlapping cylinder.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-21 05:48:32 -04:00
bherbruckandClaude Opus 5.5 871b7cea11 kernel-cases: crashes and hangs from the #140-#4149 reports (9 cases, 45 skipped)
140 join with a pad hanging past the edge, 1219 bore fillet then grooves,
1985/2243 STEP export of two enclosures, 3540 cut with a coincident cylinder
face, 3685/1559 delete a fillet face, 4092 loft + ribs + pad union (two
recipes), 2992 disk and 36 twisted loft blades. Everything else is skipped
with a reason (private designs, other areas, UI, perf only).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 05:47:59 -04:00
bherbruckandClaude Opus 5.5 eb61abb3f3 kernel-cases: import from #1721-#4006 (19 cases, 59 skipped)
STEP: 3730 void shell flag, 3098 tiny-knot B-spline edges, 2043 opposing
surface sense, 3208 extruded ellipse over its seam, 3352 vertex off its
curve, 3963 closed spline edge, 4005/4006 near-degenerate cones, 3871
cone point, 3880 seam cylinder and dome, 1721 closed B-spline tube.
IGES: 3806 revolved arc cap, 3845 trim gaps, 3359/3913 reversed trim
pieces, 3886 tiny knot span, 3912 reversed hole trim, 3972 two boxes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 05:43:31 -04:00
bherbruckandClaude Opus 5.5 c97887e604 kernel-cases: shell and offset from #12-#4144 (21 cases, 59 skipped)
4009 closed shell, 4010 shell open at a hole wall, 2531 point pick after an edit,
3468/3898 offset next to a fillet, 12 split face piece, 566 swept bar, 745/3893
freeform boss (two variants), 3103 tapered cylinder, 3669/2990 loft, 3283/3650
and 2939 curved offsets, 3506 and 1972 split then shell, 3576, 391, 1494, 1525.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 05:42:46 -04:00
bherbruckandClaude Opus 5.5 f932aec784 kernel-cases: the no-keyword kernel items, #25-#4148 (4 cases, 98 skipped)
Cases: #3702 (a board in the cavity of a case with a filleted rim, cut leaves the case
unchanged) and #258 (STEP cone to a point, with and without an apex vertex, and the 0.5 mm
pin). Everything else in the bundle is skipped with a reason in skipped-other.json.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 05:40:18 -04:00
bherbruckandClaude Opus 5.5 6a03284ea9 kernel-cases: an smlib feature for the CLI, and no grading of a kernel the build isn't running
- solidcraft-cli and solidcraft-engine forward an `smlib` feature to solidcraft-kernel/smlib, so
  `cargo build -p solidcraft-cli --features smlib` gives the rig SMLib's check.
- solidcraft_kernel::boolean_kernel() says which kernel this process runs booleans on.
  `default` until the SMLib switch (SOLIDCRAFT_BOOLEANS=smlib) lands and answers there. An smlib
  run on a build without the switch reports "not supported yet" instead of grading the default
  kernel under SMLib's name.
- An area may keep its skipped list in parts (skipped-<part>.json).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 05:31:54 -04:00
Brennen HerbruckandClaude Opus 5.5 568e2627c0 kernel: boolean runner grades the seeds against a reference volume
Rows without an analytic volume (the fuzz seeds) get one from the
primitives' definitions, by no kernel: along each vertical line both
operands are exact z intervals, combined exactly, integrated over a grid
whose cell edges include every straight face, with the half-resolution
grid bounding what error is left. Each kernel's volume is graded against
it (within 1e-3 relative or 3x that bound), in the JSON per row and in the
report's summary.

On 64 seeds truck is right on all 192 rows. SMLib's own measure is wrong on
13, all with cylinders or spheres, although truck's measure of the same
exported bodies is right on every one of them; 5 give no closed solid.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 05:24:01 -04:00
bherbruckandClaude Opus 5.5 57bc3c5623 kernel-cases: a regression rig that grades each kernel against the case's own answer
Every geometry case the old kernel got wrong becomes tests/kernel-cases/<area>/<id>/: an
engine script or oracle recipe, and expected.json with the right answer, from analysis or a
hand calculation, or else the invariants. Never a kernel's output.

- solidcraft-cli kernel-cases <dir>...: runs a case and grades it. The checks are the outcome
  (succeeds, or refuses cleanly), the body count, and one closed shell per body that passes the
  record's structure and geometry checks and, with SMLib built, SMLib's check(All). Counts,
  volume, area, centroid and box are graded where the case gives them. Each run is pass, fail,
  not supported yet or crash.
- cargo xtask kernel-cases [--kernel default|smlib|both]: one process per case, so a native crash
  or a hang (--timeout) is that case's result. It writes docs/kernel-cases.md: coverage per area
  and source, results per kernel, and the sources looked at and skipped (<area>/skipped.json).
- solidcraft_kernel::validity and smlib_built, which the rig's checks use.

tests/kernel-cases/README.md gives the format.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 05:23:13 -04:00
jyvikoandClaude Opus 5.5 8665746eab kernel: boolean runner measures SMLib's results again on truck
When SMLib's volume of a boolean result differs from truck's, the report could
not tell a wrong body from a wrong SMLib measure. The runner now measures the
result it exports back to truck as well, keeps that volume in the JSON, and
shows it in the export column wherever it leaves SMLib's own measure or SMLib
could not measure the body at all.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
2026-10-21 05:14:20 -04:00
jyvikoandClaude Opus 5.5 3002a80e34 kernel: boolean runner times both kernels and runs the cut sequence
The side-by-side runner now reports how long each boolean takes on truck and
on SMLib (the call alone), and apart from that the SMLib side's conversions:
the operands' truck→SMLib import and the result's SMLib→truck export, which
the app pays while truck still holds the bodies. The report gains a times
summary (median, worst, total), solid counts, the analytic volume of each named
case's union, intersection and cut, and how many results land on it.

It also runs the "each cut gets slower" case from TASK_kernel-smlib-booleans as
a named sequence: a 63.6 × 31.7 × 9.5 block, a Ø20 × 10 boss joined on top, a
slot front to back, a Ø6 cross hole through the boss and a slot that splits
the block, each step on the previous result. SMLib keeps its own results from
step to step (only the tools come from truck), in a child process like the
cases, and every step's volume is checked against its closed form.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
2026-10-21 05:04:10 -04:00
jyvikoandClaude Opus 5.5 1a2c21e06c kernel: side-by-side boolean runner calls SMLib's boolean
The smlib_booleans example answered "not supported yet" for every SMLib case.
Now it runs solidcraft_smlib::Brep::boolean on the tagged operands (cut maps
to Subtract, None is an empty result), reads the result's history from the
tags, and measures its volume with mass_properties at MEASURE_ACCURACY, so the
report compares truck and SMLib on real results.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
2026-10-21 04:59:26 -04:00
jyvikoandClaude Opus 5.5 0eacff3ee4 brep: orientation, not position, tells a face's outer loop
truck lists some planar faces' hole loops before the outer loop, so the
rule that loops[0] is the outer loop never held for truck's records; moving
it in the adapter would renumber those faces' edges, which history and
names stand on. The outer loop is the one that runs counter-clockwise about
the natural normal (what check_geometry checks); the order is the
producer's, and SMLib's import puts the outer loop first, as SMLib needs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
2026-10-21 02:58:14 -04:00
jyvikoandClaude Opus 5.5 bff2379abc brep: check_geometry refuses loops that enclose no area or turn the wrong way
check_geometry compared pcurve ends with edge points only, so a loop whose
pcurves enclose nothing passed whenever its uses lift onto the same 3D points:
SMLib's hole-rim fillet with both seam uses on u = 0, or a whole sphere whose
pole-to-pole seam has both uses on one line (the continuity check skips the
pole). Such a face has no surface and meshes to nothing.

Each edge loop's signed (u, v) area is now taken over 16 points of each use's
pcurve: a loop within 1e-9 of the square of its extent of zero is refused
(Problem::Empty), and each face must have exactly one counter-clockwise loop
about the natural normal, the rest clockwise (Problem::Turn). Outer and inner
are told apart by area rather than position, because the truck adapter writes a
face's wires in truck's order, which puts a hole first on some planar faces of
the sample designs (the model cache test caught it).

Fixtures: the pole-to-pole seam on one line, and a sheet whose plane axes are
swapped so its loop runs clockwise; a seamed sphere passes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
2026-10-21 02:55:17 -04:00
jyvikoandClaude Opus 5.5 fa68b66c56 brep: splines closed on themselves are periodic for pcurves and tessellation
A spline surface whose first and last control rows coincide in a direction
(points and weights, knots clamped there) closes on itself, but the display
evaluator's domain gave NURBS no period. The pcurve routine therefore never
moved a seam's second use by a period: SMLib's fillet round a hole's rim (a
rational spline closed in u) got both seam pcurves on u = 0, its outer loop
enclosed no (u, v) area, the decoded face tessellated to nothing and the body
measured 6839.73 mm3 against SMLib's 6989.00.

tess::uv::closed detects the closure from the record, within 1e-9 of the
control net's extent; the domain then has period = the active knot interval's
width, and the evaluator wraps a parameter outside that interval back inside
it, so pcurves, projection, sizing and the display plan all treat the direction
as periodic. The record stays as it is. The display plan hands both evaluators
wrapped parameters (the GPU does not wrap).

Tests: a rational torus band, a NURBS cylinder and a NURBS dome with a pole,
each bounded by a seam used twice, get seam pcurves one period apart; a record
of the band passes check_geometry and its seam uses on one line are refused;
SMLib's hole-rim fillet decodes with every face meshed and SMLib's volume
within 1e-3.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
2026-10-21 02:52:36 -04:00
jyvikoandClaude Opus 5.5 4067ab4c9b solidcraft-smlib: booleans, fillet, chamfer and shell through SMLib
Brep::boolean (union, subtract, intersect; Ok(None) for an empty result), Brep::solid_count,
Brep::fillet, Brep::chamfer and Brep::shell, over the fork's smlib_ops.cpp shims (ffi/ops.rs).
Edges and faces are chosen by points, each the nearest within a tolerance; a point that
selects nothing or cannot decide is Error::NoMatch / Error::Ambiguous with its index, and a
solid input that gives anything but a closed solid is Error::NotSolid. Fillets and chamfers
take whole tangent chains; a chamfer distance is the setback along each face; a shell's
thickness is negative inward.

The C API with these shims is version 2 (the fork's capi-flat line), so ABI_VERSION is 2.

Tests (ops_tests.rs) against analytic volumes and counts, SMLib's own check at every level on
each result, and history through a tagged box minus box: union 9000 mm3 [11, 24, 16]; slot
6000 [10, 24, 16]; intersection 1000; empty results; a split body (2 solids); a cube with all
12 edges rounded r = 2 against the Minkowski formula; one chamfer (7910, [7, 15, 10]); shells
open at the top inward (3392), outward (4672) and closed; a tangent chain from one pick equal
to picking all three edges; hostile sizes, tolerances, points and counts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
2026-10-21 02:16:29 -04:00
jyvikoandClaude Opus 5.5 f2f2f2d267 solidcraft-smlib: rebuild SMLib when its own sources change
build.rs asked Cargo to rerun only when capi/ changed, so a fix in the fork's source/ (SMLib
or SM_API) left the old objects linked: the tests kept crashing on a kernel bug already fixed
on disk. It now watches source/ too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
2026-10-21 02:13:47 -04:00
Brennen HerbruckandClaude Opus 5.5 86f9842088 kernel: schema 4 STEP records of revolved and conic-bounded parts against closed-form volumes
The hyperbola and parabola cone pieces and the revolved cylinder, read by solidcraft-step into
schema 4 and built back into truck bodies, keep their closed-form volumes with their faces
pointing out.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 02:10:25 -04:00
Brennen HerbruckandClaude Opus 5.5 24a17899d3 solidcraft-step: surfaces of revolution and extrusion, offset surfaces, hyperbola and parabola edges
SURFACE_OF_REVOLUTION reads as a placed revolution (u the angle, v the profile's parameter,
STEP's normal); SURFACE_OF_LINEAR_EXTRUSION as an exact spline surface, the profile as a
(rational) B-spline times degree 1 along the vector; a circle extruded along its axis or
revolved in a plane through the axis as the cylinder or ring torus it is. Line, conic and
open-conic profiles are bounded by the face (a closed conic's seam outside it, a revolved
profile stopped at the axis). OFFSET_SURFACE of the analytic kinds reads as the moved
surface, checked at each level. Hyperbola and parabola edges read as exact rational
quadratic pieces and a Bezier on STEP's parameter. Faces winding around a revolution get
seams along its profile. Every mapping is checked point by point and normal by normal
against STEP's own surface.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 02:10:25 -04:00
jyvikoandClaude Opus 5.5 9823cf46c7 brep: a budget of 4,000,000 items, pcurves included
Schema 4 counts every pcurve's control points as items, which schema 3 had
none of, so a body that fitted the old 1,000,000 no longer does (a STEP
plate of 50k faces). The binary envelope's own caps on bytes, values and
entries per collection still bound a body.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
2026-10-21 01:55:38 -04:00
Brennen HerbruckandClaude Opus 5.5 5a4a6f3fdf solidcraft-step: refuse loops across a closed spline surface's seam; conformance parts and truck volumes
A face winding around a closed (non-periodic) spline surface without a seam edge has loops
that jump across the surface's domain; it is refused for now instead of making a record whose
loops do not close. The step-conformance parts are read in a test, and the kernel's ignored
corpus comparison builds each record back into a truck solid to compare volumes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 01:51:54 -04:00
Brennen HerbruckandClaude Opus 5.5 e66ee38f15 solidcraft-step: seams for STEP faces that wind around their surface, looser pcurve fits
A face on a cylinder, cone or sphere bounded by loops that go round the axis (a band
between two circles, a dome on its equator, a cone on its base and apex) gets a seam:
a ruling or meridian from one loop to the other (split where it has no vertex at that
angle) or to the pole it covers, so every loop closes in (u, v) as schema 4 requires.
Pcurves may be fitted up to 1 mm off for edges that lie off their surfaces. The kernel
gets an ignored corpus test comparing truck's face and edge counts with schema 4's.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 01:51:54 -04:00
Brennen HerbruckandClaude Opus 5.5 eaa247d88a solidcraft-step: STEP topology into schema 4 B-rep records
read_solids walks MANIFOLD_SOLID_BREP, BREP_WITH_VOIDS and SHELL_BASED_SURFACE_MODEL
into solidcraft_geom::brep records: lines, conics, B-splines and polylines; planes, the
analytic surfaces and B-spline surfaces; edge intervals from the vertices' parameters;
loops relative to the surface's natural normal; outer loops, regions, voids and sheets;
pcurves from the 3D edges; the canonical order. Unsupported geometry refuses its solid
with a reason and the rest of the file is still read.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 01:51:54 -04:00
Brennen HerbruckandClaude Opus 5.5 3914ea60f5 solidcraft-step: representation context units and uncertainty, shared with the kernel's STEP reader
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 01:51:54 -04:00
Brennen HerbruckandClaude Opus 5.5 4e96737413 kernel: the boolean runner builds every SMLib operand
Boxes and cylinders go into SMLib as truck's own B-reps, through their
schema 4 records (smlib_body), so both kernels start from the same input
whatever the axis. Spheres and tori are SMLib's primitives about +Z, like
truck's, since the import doesn't take truck's revolved surfaces yet. All
41 cases' operands now build; only the boolean itself waits for its shim.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 01:51:15 -04:00
bherbruckandClaude Opus 5.5 08e3620c1a solidcraft-smlib: mass properties of every primitive against closed forms
Cylinders (also against oracle 02 and 38's expected.json), spheres, cones, frustums and tori,
at the origin and 2e5 mm out: area, volume, centroid, moments and products within 1e-6.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 01:48:17 -04:00
bherbruckandClaude Opus 5.5 fb8e9d1bf9 solidcraft-smlib: check test on every primitive
Cylinder, sphere, frustum, cone and torus pass SMLib's check at every level.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 01:46:14 -04:00
jyvikoandClaude Opus 5.5 1522e1332d solidcraft-smlib: SMLib bodies into SolidCraft through schema 4
SMLib B-reps leave the C API as its flat arrays, read through the crate's
one flat wrapper (crate::flat::Flat, copied out as import::Arrays), and
become schema 4 records: shell pairs merged, sheets collapsed, radial cycles
normalised, analytic surfaces as their kinds (narrowing cones kept), loops
reversed where SMLib's surface is inside out, every pcurve from
brep::pcurve, canonical order, then validate() and check_geometry(). Edges
arrive as their own kinds; NURBS edges that are lines or circular arcs (the
primitives' circles) are recognised as a fallback and counted. With the
kernel's `smlib` feature, body_from_smlib() decodes them into a Body.

Adds the cylinder, sphere, cone and torus primitives. Each primitive passes
SMLib's own check at every level, its volume from the exact mass properties
matches the closed form, and it goes round SMLib -> schema 4 -> SMLib with
its counts, volume and a clean check. Truck now meshes a whole sphere
bounded only by its seam (SMLib's sphere) through the display plan.

SMLIB_REV moves to the fork's capi-primitives (the primitives on capi-flat
40bb855).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
2026-10-21 01:38:16 -04:00
Brennen HerbruckandClaude Opus 5.5 4d72f7e878 solidcraft-smlib: schema 4 records into SMLib through the flat arrays
SMLIB_REV moves to the fork's capi-static 40bb855 (flat arrays, C ABI 2).
flat.rs wraps them (Flat: arrays by id, Brep::export, Flat::import,
Brep::is_manifold_solid; FFI in ffi/flat.rs). import.rs lays a schema 4 record
out as those arrays: a closed shell becomes one SMLib shell per region it
separates, a sheet's shell holds both sides of each face, the infinite region
is marked void as SMLib has it, pcurves become UV trims on B-spline faces only
(reversed for edgeuses against their edge), planes with non-unit axes go as
their exact bilinear patch. Brep::from_record builds the SMLib body.

kernel: brep_record(body) gives a body's schema 4 record, and smlib_body
(feature smlib) its SMLib body, trusted (no healer: healing moved a
cylinder's volume by 9e-7). Box, cylinder and tilted cylinder keep their
analytic volume in SMLib (1e-9, 1e-6) and are manifold solids; truck's
spheres and tori are revolutions, refused with "not supported yet" for now.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 01:15:21 -04:00
jyvikoandClaude Opus 5.5 45d0cb3797 brep: a seam from pole to pole gets pcurves a period apart
A whole sphere bounded only by its seam (SMLib's sphere: one meridian
used twice) came out with both uses on the same u line, a loop that
encloses nothing. Two causes in the per-loop closure:

- The pole-junction search took any positive signed area as the right
  turn. With the two uses on one line the area is rounding, and in most
  frames that rounding is a tiny positive number, so "no shift" won over
  the period shift. A turn now needs more than 1e-9 of the loop's
  period box.
- Junctions counted as poles only where the surface collapses exactly.
  Ends within the tolerance of a pole (as a kernel's records have them)
  were closed to the nearest period instead. A junction is now free
  where moving its periodic parameter by half a period stays within the
  tolerance, and fit samples within a quarter of it take their free
  parameter from a neighbour, so the pcurve runs straight into the pole.

Tests: the sphere bounded by its seam in four frames, three meridian
angles, circle and NURBS meridians, both loop orders, ends at or a tenth
of the tolerance off the poles; and a torus bounded by its two seams.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
2026-10-21 01:08:28 -04:00
jyvikoandClaude Opus 5.5 1993b8e72b AGENTS.md: unsafe in the SMLib FFI module and its child modules
The C API's areas (history, check, measure) each have their FFI in
crates/smlib/src/ffi/<area>.rs, children of ffi.rs; the rule named only
ffi.rs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
2026-10-21 00:58:57 -04:00
bherbruckandClaude Opus 5.5 2d3e7e6b9c solidcraft-smlib: exact mass properties, Brep::mass_properties and Brep::area
Area, volume, centroid, and inertia and products about the centroid (with inertia_tensor()),
integrated by SMLib on the exact surfaces, through the fork's smlib_brep_mass_properties and
smlib_brep_area. MEASURE_ACCURACY = 1e-8, the finest SMLib allows. At that accuracy the fork's
own test puts boxes, cylinders, spheres, cones and tori within 2e-7 of their closed forms.

Tests: tests/oracle/01-box against its expected.json (to 1e-12), a box 2e5 mm out keeping its
inertia, and accuracy arguments. SMLIB_REV moves to the fork's measure commit (3e95b79).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 00:55:06 -04:00
bherbruckandClaude Opus 5.5 12d3a4b297 solidcraft-smlib: SMLib's own validity check, Brep::check
ValidatePointers, then AssertValid over the whole topology graph (the fork's
smlib_brep_check), at CheckLevel::Basic, Geometry or All. A body that fails is still Ok, with
the failed tests counted and one line each in the CheckReport; Err means the check could not
run. Tests run it on every SMLib result and import.

SMLIB_REV moves to the fork's check commit (39f398e), which also fixes a seam-curve leak that
AssertValid hit on every periodic face.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 00:55:06 -04:00
jyvikoandClaude Opus 5.5 884b4221e2 brep: document check_geometry in the validation section
What it checks, against which tolerance, its bounded cost, that it is a
spot check rather than a certificate, and that the truck adapter runs it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
2026-10-21 00:48:03 -04:00
jyvikoandClaude Opus 5.5 a4eb6b6951 brep: the truck adapter checks a record's geometry before decoding it
decode builds topology with Edge::new_unchecked and Face::new_unchecked,
so a record whose curves miss their vertices or whose pcurves miss their
edges loaded and failed later inside truck. It now runs check_geometry
after validate and refuses such a record (a cache miss at the IO
boundary). Only our own cache feeds it today; STEP and SMLib exports will.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
2026-10-21 00:48:03 -04:00
jyvikoandClaude Opus 5.5 755cc95dcf brep: check_geometry, the geometric agreement of a record
validate() is structural only, and a kernel adapter that builds topology
from the records without its own checks (truck's new_unchecked) would take
an edge whose curve misses its vertices and fail later inside the kernel.
check_geometry spot-checks what it assumes, each against the record's own
tolerance: every edge's curve meets its vertices at its interval's ends;
every oriented edge's pcurve, lifted through its face's surface, lies on
the edge's curve at the interval's ends and middle and continues the use
before it on the same period; every vertex loop's vertex lies on its
surface. A fixed number of evaluations per record, so linear in the item
budget; a point that cannot be evaluated is an error (Mismatch, naming the
record), never a panic.

The schema fixtures now carry real planes and pcurves (from
pcurve::pcurves), so every form passes; one-defect fixtures and hostile
records cover the refusals.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
2026-10-21 00:48:03 -04:00
Brennen HerbruckandClaude Opus 5.5 ef45ff80bc solidcraft-smlib: blend faces come from the edge they replace
SMLib makes a fillet or chamfer face with no tag, so history::blends gives
each Generated face FaceOrigin::Edge for every blended edge whose two faces
both lie next to it and no longer meet directly. For the fillet shim's
history once it lands; a corner patch between blends keeps no origin.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 00:45:05 -04:00
Brennen HerbruckandClaude Opus 5.5 ea01b689d2 kernel: a side-by-side runner for truck and SMLib booleans
examples/smlib_booleans runs truck and SMLib on the same cases (named pairs
whose results are known by hand, then fuzz::boolean_shapes for N seeds),
each as union, intersection and cut, and compares volume, face and edge
counts and the shape of the history (how many faces Kept, Modified, Split,
Merged, Generated; edges from an operand edge, new, or without origin). It
writes a JSON and a Markdown report and never changes the default kernel.

SMLib runs in a child process per case, so a crash inside it is reported as
that case's result. Its primitives and booleans arrive with the operation
shims; until a call exists the case is reported as not run on SMLib.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 00:40:07 -04:00
Brennen HerbruckandClaude Opus 5.5 c6b80f72a1 solidcraft-smlib: face and edge history out of SMLib operations
Brep::tagged gives a copy whose faces and edges are tagged as one operand's;
after an operation on tagged copies, Brep::history reads back each result
face's origins and change (Kept, Modified, Split, Merged, Generated) and each
edge's faces and origin edges, as SMLib itself carried them through the
operation's splits, merges, copies and coincidences. Raw::history turns that
into solidcraft_geom's History, renumbered into canonical order by each
body's Order, with a new edge recorded as where its two faces meet.

The FFI declarations are in src/ffi/history.rs, beside ffi.rs. Tests cover
the C layout, hostile records, the meeting edges, renumbering and bad
orders, and (with SMLib built) a tagged box.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-21 00:40:07 -04:00