Commit Graph

137 Commits

Author SHA1 Message Date
anntnzrb 55b8b9a896
shfmt formatting & if-else shortened (minor) (#33)
* Applied shfmt formatting

* Minor optimizations

Some if-else flows only contained 1 statement, in shell, a shorter
version of those can be achieved by using the conditional operators,
among other tiny edits.

* Extra safety for multiple conditions

This is probably unnecessary, but just for extra safety, braces can be
added.
2020-08-05 22:42:58 -07:00
Bryan Jenks 81ca45379b
fix last merge conflict 2020-07-19 19:05:43 -07:00
Bryan Jenks f7293945b0
fix merge issue
cli can be a pain sometimes
2020-07-19 19:01:25 -07:00
bryan jenks 4813d37150 Merge branch 'master' of https://github.com/tallguyjenks/fla.sh 2020-07-19 18:59:30 -07:00
bryan jenks 1444e989bb fix date for mac in .review 2020-07-19 18:51:11 -07:00
Gustavo 96762bab04
Fix bug: review log (#32)
* Make the cards look more like cards.

* travis

* travis

* travis 2

* Fix bug: review log

* travis 3

Co-authored-by: Bryan Jenks <bryanjenks@protonmail.com>
2020-07-19 18:12:21 -07:00
bryan jenks e087cefecd increase portability for mac 2020-07-19 18:06:03 -07:00
Gustavo 748b79e8d4
Make the cards look more like cards. (#31)
* Make the cards look more like cards.

* travis

* travis

* travis 2
2020-07-17 12:19:48 -07:00
Bryan Jenks e2384023d0 prevent word splitting 2020-07-16 08:22:16 -07:00
Bryan Jenks 929c8e3bbc resolves #30 thanks @gnstaxo 2020-07-16 08:13:47 -07:00
Bryan Jenks 19ce0564bc move function higher for no hoisting 2020-05-25 21:28:15 -07:00
Bryan Jenks 511e721456 resolves #24 2020-05-25 21:27:12 -07:00
Bryan Jenks 33171e44fc fully resolves #27 and extention to it 2020-05-25 21:21:02 -07:00
Bryan Jenks f8da7b93df resolves 27 2020-05-25 21:15:12 -07:00
Bryan Jenks ae3158e30e add exit code numbers 2020-05-25 21:07:40 -07:00
Bryan Jenks 58e6c296ad update documentation 2020-05-15 14:41:19 -07:00
Bryan Jenks 99ff56fa07 formatting help text 2020-05-15 14:36:54 -07:00
Bryan Jenks eb8d41e7f3 colorize more output and linebreak on quit 2020-05-15 14:34:21 -07:00
Bryan Jenks 9b8abbe476
Merge pull request #28 from jsnal/master
Add the ability to change the FZF previewer.
2020-05-15 14:30:20 -07:00
jsnal 51ab50d081 refactor(pull request): update quotes and new line
Add quotes around variables so the script is more POSIX compliant. Also
add new line for styling.
2020-05-15 17:11:19 -04:00
jsnal 8a87104009 fix(shellcheck): fix mangled backslashes with read
Fixes SC2162

https://github.com/koalaman/shellcheck/wiki/SC2162
2020-05-15 15:00:24 -04:00
jsnal 8683c4d974 refactor(pull request): update usage and sleep command per pull request
Add a list of supported binaries for the `-p` flag and use read instead
of sleep when falling back onto the bat.
2020-05-15 14:57:20 -04:00
jsnal 0c11309a4d fix(shellcheck): fix oneline if-then-else shellcheck
Fixes SC2015 and SC2086

https://github.com/koalaman/shellcheck/wiki/SC2015
https://github.com/koalaman/shellcheck/wiki/SC2086
2020-05-14 20:17:32 -04:00
Bryan Jenks 12815c487a update shellcheck to allow bashishms since its a bash script anyhow 2020-05-14 17:16:44 -07:00
jsnal 864d0149ce feat(usage): update usage for new previewer feature
Add the documentation for changing the FZF previewer binary. The help
page kind of looks weird now that the alignment is off. That is
something that might need to be refactored in the future.
2020-05-14 19:47:08 -04:00
jsnal 5f50b2e042 feat(flash): allow the use of previewers other than bat
This commit adds a way of changing the FZF previewer by using the `-p`
flag. An example of this might look like:

$ flash -p cat

This will use cat has the FZF previewer instead of bat. However, it keeps bat as
the default program in all cases unless specifically changed by the `-p`
parameter. There are also checks to see if the provided binary actually
exists on the system. If it exists on the system, it checks if it
supported by flash. If it isn't supported by flash, it falls back onto
bat as the default previewer. For now, only bat and cat are supported but it.
can easily be expanded.
2020-05-14 19:41:11 -04:00
Bryan Jenks c746f2545b update for real, last overwritten by git pull 2020-05-14 12:39:36 -07:00
Bryan Jenks b5351f7826 Merge branch 'master' of github.com:tallguyjenks/fla.sh 2020-05-14 12:37:04 -07:00
Bryan Jenks d13b0b5cbe updated examples screen shot 2020-05-14 12:36:44 -07:00
Bryan Jenks 73e4ea3f3e
update README after #11 resolution 2020-05-14 11:43:34 -07:00
Bryan Jenks 922484fbe5
Merge pull request #26 from jsnal/master
Fix macOS installation function
2020-05-14 11:38:52 -07:00
jsnal 18c3e510f2 fix(setup): fix setup on macOS
Fix the setup function on macOS by removing the `eval` in the `touch`
statement. This fix worked for me on macOS 10.14.6, however, this hasn't
been tested with other versions of macOS. I checked that the script still works in
Linux as well.
2020-05-14 14:31:34 -04:00
Bryan Jenks e81305222b
downloads tag doesnt function
kill it
2020-05-10 08:26:40 -07:00
Bryan Jenks d73faea243 less echo cmd calls, same output 2020-05-09 05:31:26 -07:00
Bryan Jenks 1ba3b21993 resolves #23 2020-05-07 20:12:58 -07:00
Bryan Jenks b879ece0ac add troubeshoot sect. fill out with issues, when stable 2020-05-07 19:09:52 -07:00
Bryan Jenks a1e17bad9d fix function close brace 2020-05-07 14:05:14 -07:00
Bryan Jenks 15e8648e4b when mac install coreutils, alias gshuf to shuf 2020-05-07 13:59:20 -07:00
Bryan Jenks e239411053 messed up mac home variable creation 2020-05-07 13:57:18 -07:00
Bryan Jenks 448648ca84 fix final shell checks 2020-05-05 20:55:57 -07:00
Bryan Jenks 3530948c4a new help/info system resolves #14 2020-05-05 20:54:02 -07:00
Bryan Jenks a37873cf0c version number aesthetics completed 2020-05-05 20:15:36 -07:00
Bryan Jenks a0b1582aaa building opts capturing for version and help msg 2020-05-05 20:11:40 -07:00
Bryan Jenks d68ba42e4d Merge branch 'master' of github.com:tallguyjenks/fla.sh 2020-05-05 19:43:18 -07:00
Bryan Jenks 5273ba6410 shell checks completed and functionality retained 2020-05-05 19:42:55 -07:00
Bryan Jenks 516cd4016c shell check cleanup and clear on answer screen exit 2020-05-05 19:33:33 -07:00
Bryan Jenks dcace35df8
fix travis badge 2020-05-05 19:23:39 -07:00
Bryan Jenks d05da35ba8 resolve #22 2020-05-05 19:16:55 -07:00
Bryan Jenks e30be22339 prefer XDG over hard coded paths, resolves #17 2020-05-04 13:07:23 -07:00
Bryan Jenks 2f6e8b6c11 Add opt to quit at question screen & clear output 2020-05-04 13:05:45 -07:00