Validate comment offsets

src/parser/ValidationError.ts

@@ -0,0 +1,5 @@
+export class ValidationError extends Error {
+  constructor(msg: string) {
+    super(msg);
+  }
+}

src/parser/index.ts

@@ -1,5 +1,6 @@
 import { Workout } from "../ast";
 import { parseTokens } from "./parser";
 import { tokenize } from "./tokenizer";
+import { validate } from "./validate";
 
-export const parse = (source: string): Workout => parseTokens(tokenize(source));
+export const parse = (source: string): Workout => validate(parseTokens(tokenize(source)));

src/parser/parser.test.ts

@@ -526,4 +526,17 @@ Rest: 5:00 50%
       }
     `);
   });
+
+  it("throws error when comment offset is outside of interval length", () => {
+    expect(() =>
+      parse(`
+Name: My Workout
+Interval: 2:00 90%
+  @ 0:00 Find your rythm.
+  @ 3:10 Try to settle in for the effort
+`),
+    ).toThrowErrorMatchingInlineSnapshot(
+      `"Comment \\"@ 190 Try to settle in for the effort\\" has offset outside of interval"`,
+    );
+  });
 });

src/parser/validate.ts

@@ -0,0 +1,19 @@
+import { Workout, Interval, Comment } from "../ast";
+import { ValidationError } from "./ValidationError";
+
+const isCommentWithinInterval = (comment: Comment, interval: Interval): boolean => {
+  return comment.offset.seconds < interval.duration.seconds;
+};
+
+const validateCommentOffsets = (interval: Interval) => {
+  for (const comment of interval.comments) {
+    if (!isCommentWithinInterval(comment, interval)) {
+      throw new ValidationError(`Comment "@ ${comment.offset.seconds} ${comment.text}" has offset outside of interval`);
+    }
+  }
+};
+
+export const validate = (workout: Workout): Workout => {
+  workout.intervals.forEach(validateCommentOffsets);
+  return workout;
+};