* Split the schema contracts into one module per command file `schema/commands.rs` becomes `schema/features.rs` (solid.box, solid.extrude, FeatureResult) and `schema/inspect.rs` (engine.describe), each with its own tests file holding its `schemas_and_the_key_check_agree` key lists and its `strict_keeps_todays_errors` cases, so conversions of different command files touch different files. The shared loops become helpers in `schema/tests.rs`; the assertions are unchanged. `engine.describe` gains a key-list test, and `schema_defaults_are_valid` now covers every command with a contract. No behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Add shared schema field types for the next conversions For the feature commands to be converted next, each deciding acceptance with the reader the handlers already use: - `FaceRef` and `FaceRefs` (`face::face_ref`, `features::face_points`) - `EdgeRef` and `EdgeRefs` (`features::edge_points`) - `SketchRef` (`features::sketch_id`) - `FeatureCommon`: `name`, `body_name`, `body_names` and `participants`, which `add_feature` reads for every feature, flattened into a contract with `deserialize_with = "feature_common"`, which keeps the key in the message and the issue's path. The shape checks of `face_ref`, `edge_points` and `sketch_id` (and `feature_sketch`) move into pure helpers (`face_ref_form`, `edge_ref_form`, `sketch_key`) that the handlers and the types share; the handlers behave as before. Tests check that each type and its schema accept what the reader accepts (apart from a face name's byte cap and an index written `1.0`), that the contract's messages match the handlers' errors, and that the handlers still look picks up one at a time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
37 lines
1.6 KiB
Rust
37 lines
1.6 KiB
Rust
use serde_json::json;
|
|
|
|
use super::DescribeParams;
|
|
use crate::Session;
|
|
use crate::schema::input_schema_for;
|
|
use crate::schema::tests::{assert_keys, assert_strict_keeps_todays_errors};
|
|
|
|
#[test]
|
|
fn schemas_and_the_key_check_agree() {
|
|
assert_keys(input_schema_for::<DescribeParams>(), &["command"]);
|
|
}
|
|
|
|
#[test]
|
|
fn strict_keeps_todays_errors() {
|
|
assert_strict_keeps_todays_errors(&[
|
|
("engine.describe", json!({"command": 5})),
|
|
("engine.describe", json!({"command": null})),
|
|
("engine.describe", json!({"command": "solid.extrud"})),
|
|
]);
|
|
}
|
|
|
|
#[test]
|
|
fn describe_returns_both_schemas() {
|
|
let mut s = Session::default();
|
|
let d = s.execute("engine.describe", &json!({"command": "solid.box"})).unwrap_or_else(|e| panic!("{e}"));
|
|
assert_eq!(d["id"], "solid.box");
|
|
assert!(d["input"]["properties"].get("length").is_some());
|
|
assert!(d["output"]["properties"].get("created_bodies").is_some());
|
|
// Its own output schema lists the warnings warn mode can add.
|
|
let own = s.execute("engine.describe", &json!({"command": "engine.describe"})).unwrap_or_else(|e| panic!("{e}"));
|
|
assert!(own["output"]["properties"].get("param_warnings").is_some(), "{own}");
|
|
let d = s.execute("engine.describe", &json!({"command": "solid.revolve"})).unwrap_or_else(|e| panic!("{e}"));
|
|
assert!(d["input"].is_null() && d["output"].is_null(), "unconverted commands have no schemas yet");
|
|
let e = s.execute("engine.describe", &json!({"command": "solid.extrud"})).err().map(|e| e.to_string());
|
|
assert!(e.as_deref().is_some_and(|e| e.contains("did you mean `solid.extrude`")), "{e:?}");
|
|
}
|