* Stderr: a closed stderr no longer stops the app, the CLI or the MCP server (#10111) `eprintln!` panics with "failed printing to stderr" when stderr is a pipe its reader has closed. A process another program starts writes into such a pipe: `solidcraft mcp` under an agent, and the app that one starts, which inherits it. #10111 is the app stopping that way while an agent (Codex) connected. `solidcraft_geom::note!` (re-exported as `solidcraft_engine::note!`) writes the same line and ignores a failed write, as the CLI's logger already does; the app, the CLI, the MCP server, the crash hook and the crates they run use it instead of `eprintln!` outside tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Stderr: test that a closed stderr leaves the CLI's exit code as it is (#10111) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Stderr: the old name's alias and the fuzz command don't stop on a closed stderr either (#10111) `solvecraft-cli` writes its deprecation notice before it starts `solidcraft-cli`, so an agent still configured with the old name got the panic before the MCP server started (found in review). It and the fuzz command now write through `note!` too, and the test covers the alias. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
31 lines
1.5 KiB
Rust
31 lines
1.5 KiB
Rust
//! `solvecraft-cli`: the CLI's former name, kept for at least one release so existing scripts
|
|
//! and MCP client setups (`claude mcp add solvecraft -- solvecraft-cli mcp`) keep working.
|
|
//! Compatibility shim: it runs `solidcraft-cli` (next to this executable, else on PATH) with the
|
|
//! same arguments and standard streams, after a one-line deprecation note on stderr (stdout
|
|
//! stays clean for MCP's JSON-RPC), and exits with its status.
|
|
#![deny(clippy::unwrap_used, clippy::expect_used, clippy::panic, clippy::unimplemented, clippy::todo, clippy::unreachable)]
|
|
#![forbid(unsafe_code)]
|
|
|
|
use std::process::{Command, ExitCode};
|
|
|
|
const TARGET: &str = "solidcraft-cli";
|
|
|
|
fn main() -> ExitCode {
|
|
solidcraft_engine::note!("solvecraft-cli is deprecated and will be removed in a later release: use solidcraft-cli");
|
|
let sibling = std::env::current_exe()
|
|
.ok()
|
|
.and_then(|exe| exe.parent().map(|dir| dir.join(format!("{TARGET}{}", std::env::consts::EXE_SUFFIX))))
|
|
.filter(|p| p.is_file());
|
|
let program = sibling.map(|p| p.into_os_string()).unwrap_or_else(|| TARGET.into());
|
|
match Command::new(&program).args(std::env::args_os().skip(1)).status() {
|
|
Ok(status) => match status.code() {
|
|
Some(code) => ExitCode::from(u8::try_from(code).unwrap_or(1)),
|
|
None => ExitCode::FAILURE,
|
|
},
|
|
Err(e) => {
|
|
solidcraft_engine::note!("solvecraft-cli: could not run {}: {e}", program.to_string_lossy());
|
|
ExitCode::FAILURE
|
|
}
|
|
}
|
|
}
|