* Kernel: the B-rep record and the native body file come from solidcore-record SolidCraft's portable B-rep record (`solidcraft_geom::brep`: brep.rs, topology, history, envelope, part, curve2) and the native body file (`solidcraft_kernel::native`: the tagged binary codec and the container) move to solidcore's `solidcore-record` crate: geometry as data, with structural validation and no maths (solidcore's docs/layers.md, stage 1). Every caller uses `solidcore_record::brep` and `solidcore_record::native`; the old copies are deleted. What computes from coordinates stays with the kernel, in geom's `brep`: - `brep::check`: the record's geometric checks (orthonormal frames, non-degenerate planes, unit revolution axes, non-singular placements). `check::validate` and `check::validate_built` are the record's validation and these together, and every caller of `Brep::validate` uses them, so what is accepted is unchanged; - `brep::label`: a surface's natural ranges (a cone's apex), `curve_interval`, `edge_curve_interval` and `form_turns`; - `brep::pcurve::eval`: a pcurve's point; - `geometry::check`, `placement::moved` and `split_edges` become functions on the record. The kernel's native module keeps the conversion between a body and its saved record (metadata.rs) and checks the decoded record's geometry. `native/analytic.rs`, which no module declared, is deleted. solidcore-record is pinned to its rev on solidcore's `layer-record` branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NvoxKMbMFSQU8tzRtoJhtT * Geometry: Vec2, Vec3, Plane and the profile types come from solidcore-record The plain data of vectors and points, sketch planes and planar profiles (`Seg2`, `Loop2`, `Region2`) moves to `solidcore-record`, with its constants and component-wise operators only (owner decision, solidcore layer split). Their geometry stays in geom as traits: `Vec2Geom`, `Vec3Geom`, `PlaneGeom`, `Seg2Geom`, `Loop2Geom`, `Region2Geom`, `Seg2ArcFit`, `Loop2ArcFit` and `Region2ArcFit`, in scope with `use solidcraft_geom::prelude::*`. Every caller names the types from `solidcore_record`; geom no longer defines or re-exports them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NvoxKMbMFSQU8tzRtoJhtT * Kernel: pin solidcore-record to solidcore main f5e8e9a29 solidcore-record is merged on solidcore main (tangency-labs/solidcore#2519); its crate there is identical to the rev pinned before but for its clippy configuration. The lock is regenerated against the merged rev. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NvoxKMbMFSQU8tzRtoJhtT --------- Co-authored-by: jyviko <2501648+jyviko@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
677 lines
31 KiB
Rust
677 lines
31 KiB
Rust
//! Continuity diagnostics across the seams between a body's faces: do the two faces that meet
|
||
//! at an edge share a curve (G0), a tangent plane (G1), a curvature (G2), the way that curvature
|
||
//! changes across the seam (G3) and the way that change changes (G4)?
|
||
//!
|
||
//! The stations are taken on the edge itself — the curve both faces are supposed to share — so
|
||
//! the numbers describe the B-rep and not a tessellation: each station is projected onto each
|
||
//! face's own surface, and the two projections are compared. The gap is the distance between
|
||
//! them (G0); the normal angle is the angle between the faces' outward normals there (G1); the
|
||
//! curvature jump is the difference of their normal curvatures in the normal section square to
|
||
//! the edge, from the second fundamental form of each surface (G2); the curvature-change jump and
|
||
//! its rate's jump compare the first and second arc-length derivatives of those normal sections'
|
||
//! curvatures across the edge (G3, G4). All three come from each surface's exact partial
|
||
//! derivatives ([`solidcraft_geom::brep::normal_section`]), never from samples. Each seam's
|
||
//! [`SeamReport::order`] is the highest order whose test, and every lower one, its worst station
|
||
//! passes. A rolling-ball fillet is
|
||
//! tangent to the faces it joins but is not curvature continuous: where it meets a plane its
|
||
//! seam reads 0° and 1 / radius, which no chord tolerance would reveal.
|
||
//!
|
||
//! [`crate::smooth_edges`] decides whether a join needs a *display* line; this module measures
|
||
//! the join, and backs the engine's `inspect.continuity`.
|
||
|
||
use serde::Serialize;
|
||
use solidcore_record::Vec3;
|
||
use solidcore_record::brep::{self as b};
|
||
use solidcraft_geom::brep::normal_section::{SectionJet, normal_section};
|
||
use solidcraft_geom::brep::{eval::CurveEval, eval::SurfaceEval};
|
||
use solidcraft_geom::prelude::*;
|
||
|
||
use crate::body::Body;
|
||
use crate::continuity_order::Continuity;
|
||
use crate::{KernelError, Result};
|
||
|
||
/// Bodies with more edges than this are refused rather than sampled for minutes.
|
||
const MAX_EDGES: usize = 4096;
|
||
/// Most faces a body may have and still be analysed.
|
||
const MAX_FACES: usize = 50_000;
|
||
/// Stations one call may take over all its edges; edges past the budget are left out and
|
||
/// counted in [`ContinuityReport::skipped`].
|
||
const MAX_STATIONS: usize = 200_000;
|
||
/// Most edges one pick list may name (the full list always fits the station budget).
|
||
const MAX_PICKS: usize = 512;
|
||
/// Samples used to find the edge nearest a picked point (as in `surfaces::edge_near`).
|
||
const PICK_SAMPLES: usize = 32;
|
||
|
||
/// Least and most stations along one edge (`inspect.continuity`'s `samples`): three are the two
|
||
/// ends and the middle.
|
||
pub const MIN_SAMPLES: usize = 3;
|
||
pub const MAX_SAMPLES: usize = 257;
|
||
/// Stations along one edge where a measurement does not say (`inspect.continuity`'s default).
|
||
pub const DEFAULT_SAMPLES: usize = 33;
|
||
|
||
/// How an edge is picked: a point on (or near) it, or its index in the display mesh's edge
|
||
/// order ([`Body::edges`]), which is what a viewport pick carries.
|
||
#[derive(Clone, Copy, Debug, PartialEq)]
|
||
pub enum EdgePick {
|
||
Point(Vec3),
|
||
Index(usize),
|
||
}
|
||
|
||
/// What counts as continuous across a seam.
|
||
#[derive(Clone, Copy, Debug, PartialEq)]
|
||
pub struct ContinuityTolerances {
|
||
/// Largest position gap that still counts as coincident (G0), mm.
|
||
pub gap_mm: f64,
|
||
/// Largest angle between the faces' normals that still counts as tangent (G1), degrees.
|
||
pub angle_deg: f64,
|
||
/// Largest curvature jump that still counts as curvature continuous (G2), 1/mm.
|
||
pub curvature_per_mm: f64,
|
||
/// Largest jump of the curvature's change across the seam that still counts as G3, 1/mm².
|
||
pub curvature_change_per_mm2: f64,
|
||
/// Largest jump of that change's rate that still counts as G4, 1/mm³.
|
||
pub curvature_change_rate_per_mm3: f64,
|
||
}
|
||
|
||
impl Default for ContinuityTolerances {
|
||
/// A micron of gap, a degree of normal angle, a curvature jump of 1/100 mm, and a change of
|
||
/// curvature (and its rate) a tenth as large again per millimetre.
|
||
fn default() -> Self {
|
||
ContinuityTolerances {
|
||
gap_mm: 1e-3,
|
||
angle_deg: 1.0,
|
||
curvature_per_mm: 1e-2,
|
||
curvature_change_per_mm2: 1e-3,
|
||
curvature_change_rate_per_mm3: 1e-4,
|
||
}
|
||
}
|
||
}
|
||
|
||
impl ContinuityTolerances {
|
||
/// The tolerance of each metric, in [`Metrics`] order (G0 … G4).
|
||
fn by_order(&self) -> Metrics {
|
||
[self.gap_mm, self.angle_deg, self.curvature_per_mm, self.curvature_change_per_mm2, self.curvature_change_rate_per_mm3]
|
||
}
|
||
}
|
||
|
||
/// One value per order a seam is tested for, G0 … G4: the gap, the normal angle, and the jumps of
|
||
/// the curvature, of its change, and of that change's rate.
|
||
type Metrics = [f64; 5];
|
||
|
||
/// The worst value of one metric along an edge, with where it was found.
|
||
#[derive(Clone, Copy, Debug, Serialize)]
|
||
pub struct SeamWorst {
|
||
pub value: f64,
|
||
/// The station that gave the worst value, in the body's coordinates.
|
||
pub at: Vec3,
|
||
/// How far along the edge it is: 0 at the edge's start, 1 at its end.
|
||
pub edge_fraction: f64,
|
||
}
|
||
|
||
/// Which test a seam fails, from the best continuity to the worst: [`SeamVerdict::Smooth`] is
|
||
/// curvature continuous (G2 or better: [`SeamReport::order`] says how much better), then a
|
||
/// tangent seam whose curvature jumps (G1), then a visible crease (G0 only), and finally faces
|
||
/// that do not meet at all.
|
||
#[derive(Clone, Copy, Debug, PartialEq, Eq, PartialOrd, Ord, Serialize)]
|
||
#[serde(rename_all = "snake_case")]
|
||
pub enum SeamVerdict {
|
||
Smooth,
|
||
CurvatureJump,
|
||
Sharp,
|
||
Gap,
|
||
}
|
||
|
||
impl SeamVerdict {
|
||
/// The verdict of a seam whose highest order met is `order` (`None`: not even G0).
|
||
pub fn of(order: Option<Continuity>) -> SeamVerdict {
|
||
match order {
|
||
None => SeamVerdict::Gap,
|
||
Some(Continuity::G0) => SeamVerdict::Sharp,
|
||
Some(Continuity::G1) => SeamVerdict::CurvatureJump,
|
||
Some(_) => SeamVerdict::Smooth,
|
||
}
|
||
}
|
||
}
|
||
|
||
/// One edge's diagnostics: the worst of each metric along it, and where.
|
||
#[derive(Clone, Debug, Serialize)]
|
||
pub struct SeamReport {
|
||
/// Index in the display mesh's edge order ([`Body::edges`]).
|
||
pub edge: usize,
|
||
/// Length of the edge, mm.
|
||
pub length: f64,
|
||
/// Stations the values were taken at.
|
||
pub samples: usize,
|
||
pub gap_mm: SeamWorst,
|
||
pub normal_angle_deg: SeamWorst,
|
||
pub curvature_jump_per_mm: SeamWorst,
|
||
/// The worst jump of the curvature's arc-length derivative across the seam (G3), 1/mm².
|
||
pub curvature_change_jump_per_mm2: SeamWorst,
|
||
/// The worst jump of its second derivative (G4), 1/mm³.
|
||
pub curvature_change_rate_jump_per_mm3: SeamWorst,
|
||
/// The highest order every station meets within the tolerances (`None`: the faces do not
|
||
/// meet).
|
||
pub order: Option<Continuity>,
|
||
/// What the tolerances make of the seam ([`SeamVerdict::of`] its order).
|
||
pub verdict: SeamVerdict,
|
||
/// The stations in order: what a viewport shades.
|
||
pub points: Vec<Vec3>,
|
||
/// What each of `points` measured, in the same order.
|
||
pub stations: Vec<SeamStation>,
|
||
}
|
||
|
||
/// One station of a seam: how far along the edge, and the five metrics there.
|
||
#[derive(Clone, Copy, Debug, Serialize)]
|
||
pub struct SeamStation {
|
||
/// 0 at the edge's start, 1 at its end.
|
||
pub edge_fraction: f64,
|
||
pub gap_mm: f64,
|
||
pub normal_angle_deg: f64,
|
||
pub curvature_jump_per_mm: f64,
|
||
pub curvature_change_jump_per_mm2: f64,
|
||
pub curvature_change_rate_jump_per_mm3: f64,
|
||
}
|
||
|
||
impl SeamStation {
|
||
fn new(edge_fraction: f64, m: Metrics) -> SeamStation {
|
||
let [gap_mm, normal_angle_deg, curvature_jump_per_mm, curvature_change_jump_per_mm2, curvature_change_rate_jump_per_mm3] = m;
|
||
SeamStation {
|
||
edge_fraction,
|
||
gap_mm,
|
||
normal_angle_deg,
|
||
curvature_jump_per_mm,
|
||
curvature_change_jump_per_mm2,
|
||
curvature_change_rate_jump_per_mm3,
|
||
}
|
||
}
|
||
}
|
||
|
||
/// The highest order whose metric, and every lower one, is within its tolerance.
|
||
fn highest_met(worst: Metrics, tolerances: Metrics) -> Option<Continuity> {
|
||
let met = worst.iter().zip(tolerances).take_while(|(w, t)| **w <= *t).count();
|
||
met.checked_sub(1).and_then(Continuity::from_order)
|
||
}
|
||
|
||
/// The seam diagnostics of one body.
|
||
#[derive(Clone, Debug, Serialize)]
|
||
pub struct ContinuityReport {
|
||
pub seams: Vec<SeamReport>,
|
||
/// Edges left out: not a seam between two faces (an open boundary, or a periodic face's own
|
||
/// seam, which is one face meeting itself), or past the station budget.
|
||
pub skipped: usize,
|
||
/// Edges that could not be sampled at all: no station of theirs projected onto both faces.
|
||
pub unmeasured: usize,
|
||
}
|
||
|
||
/// The edge indices `picks` mean, in display-mesh order and without repeats. A point pick takes
|
||
/// the edge nearest it (within the distance the kernel re-finds an edge from); an index pick
|
||
/// must be an existing index. An empty list means every two-sided seam of the body, and a pick
|
||
/// of an edge that is not a seam between two faces is refused, not guessed at.
|
||
pub fn pick_edges(body: &Body, picks: &[EdgePick]) -> Result<Vec<usize>> {
|
||
body.require_brep("continuity")?;
|
||
if picks.len() > MAX_PICKS {
|
||
return Err(KernelError::Invalid(format!("pick at most {MAX_PICKS} edges")));
|
||
}
|
||
crate::guard("continuity picks", || {
|
||
let Topology { record, adjacent, .. } = topology(body)?;
|
||
if picks.is_empty() {
|
||
return Ok((0..record.edges.len()).filter(|i| two_sided(&adjacent, *i)).collect());
|
||
}
|
||
let reach = body.size() * 0.05 + 1e-6;
|
||
let mut out: Vec<usize> = Vec::new();
|
||
for pick in picks {
|
||
let index = match *pick {
|
||
EdgePick::Index(index) => index,
|
||
EdgePick::Point(p) => nearest_edge(&record.edges, p, reach)?,
|
||
};
|
||
if !two_sided(&adjacent, index) {
|
||
return Err(KernelError::Invalid(format!("edge {index} of this body is not a seam between two faces")));
|
||
}
|
||
if !out.contains(&index) {
|
||
out.push(index);
|
||
}
|
||
}
|
||
out.sort_unstable();
|
||
Ok(out)
|
||
})
|
||
}
|
||
|
||
/// Sample the two-sided seams `edges` of `body` (indices in display-mesh order; empty: every
|
||
/// one of them) at `samples` stations along each edge's own parameter, the ends included, with
|
||
/// the tolerances the seams are judged against.
|
||
pub fn seam_diagnostics(body: &Body, edges: &[usize], samples: usize, tolerances: ContinuityTolerances) -> Result<ContinuityReport> {
|
||
body.require_brep("continuity")?;
|
||
if !(MIN_SAMPLES..=MAX_SAMPLES).contains(&samples) {
|
||
return Err(KernelError::Invalid(format!("`samples` must be {MIN_SAMPLES}…{MAX_SAMPLES}")));
|
||
}
|
||
let names = ["gap", "angle", "curvature", "curvature change", "curvature change rate"];
|
||
for (name, value) in names.into_iter().zip(tolerances.by_order()) {
|
||
// A range test also throws out NaN (both comparisons are false).
|
||
if !(0.0..1e9).contains(&value) {
|
||
return Err(KernelError::Invalid(format!("the {name} tolerance must be a finite number, 0 or more")));
|
||
}
|
||
}
|
||
crate::guard("continuity", || measure(body, edges, samples, tolerances))
|
||
}
|
||
|
||
/// The body's record with, per edge, the faces it bounds (each once: a periodic face's own seam
|
||
/// bounds one), and per face whether its surface's natural normal points out of the material;
|
||
/// refused past the caps.
|
||
struct Topology {
|
||
record: b::Brep,
|
||
adjacent: Vec<Vec<usize>>,
|
||
outward: Vec<bool>,
|
||
}
|
||
|
||
fn topology(body: &Body) -> Result<Topology> {
|
||
let record = crate::native::brep_record(body)?;
|
||
if record.faces.len() > MAX_FACES {
|
||
return Err(KernelError::TooLarge(format!("the body has more than {MAX_FACES} faces")));
|
||
}
|
||
if record.edges.len() > MAX_EDGES {
|
||
return Err(KernelError::TooLarge(format!("the body has more than {MAX_EDGES} edges")));
|
||
}
|
||
let adjacent = record
|
||
.edges
|
||
.iter()
|
||
.map(|e| {
|
||
let mut faces: Vec<usize> = e.uses.iter().map(|u| u.face as usize).collect();
|
||
faces.sort_unstable();
|
||
faces.dedup();
|
||
faces
|
||
})
|
||
.collect();
|
||
// A face's side in the first shell that uses it (canonical order walks faces that way).
|
||
let mut outward: Vec<Option<bool>> = vec![None; record.faces.len()];
|
||
for shell in &record.shells {
|
||
if let b::Shell::Faces { faces, .. } = shell {
|
||
for f in faces {
|
||
if let Some(slot) = outward.get_mut(f.face as usize) {
|
||
slot.get_or_insert(f.forward);
|
||
}
|
||
}
|
||
}
|
||
}
|
||
let outward = outward.into_iter().map(|o| o.unwrap_or(true)).collect();
|
||
Ok(Topology { record, adjacent, outward })
|
||
}
|
||
|
||
/// Is the edge at `index` shared by (exactly) two faces of the body?
|
||
fn two_sided(adjacent: &[Vec<usize>], index: usize) -> bool {
|
||
adjacent.get(index).is_some_and(|faces| faces.len() == 2)
|
||
}
|
||
|
||
/// The index of the edge whose curve comes nearest `p`, within `reach`.
|
||
fn nearest_edge(edges: &[b::Edge], p: Vec3, reach: f64) -> Result<usize> {
|
||
let mut best: Option<(f64, usize)> = None;
|
||
for (index, edge) in edges.iter().enumerate() {
|
||
let Ok(curve) = CurveEval::new(edge.parameters()) else { continue };
|
||
let [t0, t1] = edge.interval;
|
||
for k in 0..=PICK_SAMPLES {
|
||
let Some(q) = curve.point(t0 + (t1 - t0) * k as f64 / PICK_SAMPLES as f64) else { continue };
|
||
let d = q.dist(p);
|
||
if d.is_finite() && best.is_none_or(|(bd, _)| d < bd) {
|
||
best = Some((d, index));
|
||
}
|
||
}
|
||
}
|
||
match best {
|
||
Some((d, index)) if d <= reach => Ok(index),
|
||
_ => Err(KernelError::Invalid(format!("no edge of the body is within {reach:.3} mm of ({}, {}, {})", p.x, p.y, p.z))),
|
||
}
|
||
}
|
||
|
||
fn measure(body: &Body, edges: &[usize], samples: usize, tolerances: ContinuityTolerances) -> Result<ContinuityReport> {
|
||
let Topology { record, adjacent, outward } = topology(body)?;
|
||
let mut selected: Vec<usize> = Vec::new();
|
||
let mut skipped = 0usize;
|
||
if edges.is_empty() {
|
||
for index in 0..record.edges.len() {
|
||
if two_sided(&adjacent, index) {
|
||
selected.push(index);
|
||
} else {
|
||
skipped += 1;
|
||
}
|
||
}
|
||
} else {
|
||
selected.extend(edges.iter().copied());
|
||
selected.sort_unstable();
|
||
selected.dedup();
|
||
for &index in &selected {
|
||
if index >= record.edges.len() {
|
||
return Err(KernelError::Invalid(format!("the body has no edge {index}")));
|
||
}
|
||
if !two_sided(&adjacent, index) {
|
||
return Err(KernelError::Invalid(format!("edge {index} of this body is not a seam between two faces")));
|
||
}
|
||
}
|
||
}
|
||
let face = |i: usize| -> Option<FaceSurface> {
|
||
let f = record.faces.get(i)?;
|
||
FaceSurface::new(f.parameters(), outward.get(i).copied().unwrap_or(true))
|
||
};
|
||
let mut seams = Vec::new();
|
||
let mut unmeasured = 0usize;
|
||
let mut budget = MAX_STATIONS;
|
||
for index in selected {
|
||
let Some([first, second]) = adjacent.get(index).and_then(|f| <[usize; 2]>::try_from(f.as_slice()).ok()) else { continue };
|
||
let Some(edge) = record.edges.get(index) else { continue };
|
||
// Every edge costs `samples` stations; a run out of budget stops cleanly.
|
||
if budget < samples {
|
||
skipped += 1;
|
||
continue;
|
||
}
|
||
budget -= samples;
|
||
let report = match (face(first), face(second), CurveEval::new(edge.parameters())) {
|
||
(Some(a), Some(b), Ok(curve)) => seam(index, &curve, edge.interval, a, b, samples, tolerances),
|
||
_ => None,
|
||
};
|
||
match report {
|
||
Some(report) => seams.push(report),
|
||
None => unmeasured += 1,
|
||
}
|
||
}
|
||
Ok(ContinuityReport { seams, skipped, unmeasured })
|
||
}
|
||
|
||
/// One edge's worst gap, normal angle and jumps of curvature, its change and that change's rate.
|
||
fn seam(
|
||
index: usize,
|
||
curve: &CurveEval,
|
||
[t0, t1]: [f64; 2],
|
||
mut on_a: FaceSurface,
|
||
mut on_b: FaceSurface,
|
||
samples: usize,
|
||
tolerances: ContinuityTolerances,
|
||
) -> Option<SeamReport> {
|
||
// The station fractions: 0 at the edge's start, 1 at its end.
|
||
let steps = samples.checked_sub(1)?;
|
||
let mut worst: [Option<SeamWorst>; 5] = [None; 5];
|
||
let mut points = Vec::with_capacity(samples);
|
||
let mut stations = Vec::with_capacity(samples);
|
||
for k in 0..samples {
|
||
let f = k as f64 / steps as f64;
|
||
let Some((at, tangent)) = curve.derivs(t0 + (t1 - t0) * f) else { continue };
|
||
let Some(metrics) = station(at, tangent, &mut on_a, &mut on_b) else { continue };
|
||
points.push(at);
|
||
stations.push(SeamStation::new(f, metrics));
|
||
for (w, value) in worst.iter_mut().zip(metrics) {
|
||
keep(w, value, at, f);
|
||
}
|
||
}
|
||
let [gap, angle, jump, change, rate] = worst;
|
||
let [gap, angle, jump, change, rate] = [gap?, angle?, jump?, change?, rate?];
|
||
let order = highest_met([gap.value, angle.value, jump.value, change.value, rate.value], tolerances.by_order());
|
||
let length = points.windows(2).map(|w| w.first().zip(w.get(1)).map_or(0.0, |(a, b)| a.dist(*b))).sum();
|
||
Some(SeamReport {
|
||
edge: index,
|
||
length,
|
||
samples: points.len(),
|
||
gap_mm: gap,
|
||
normal_angle_deg: angle,
|
||
curvature_jump_per_mm: jump,
|
||
curvature_change_jump_per_mm2: change,
|
||
curvature_change_rate_jump_per_mm3: rate,
|
||
order,
|
||
verdict: SeamVerdict::of(order),
|
||
points,
|
||
stations,
|
||
})
|
||
}
|
||
|
||
/// The five metrics at the seam point `at` (edge tangent `tangent`): both projections and both
|
||
/// faces' normal sections square to the seam, or the station says nothing.
|
||
fn station(at: Vec3, tangent: Vec3, on_a: &mut FaceSurface, on_b: &mut FaceSurface) -> Option<Metrics> {
|
||
if !at.is_finite() {
|
||
return None;
|
||
}
|
||
let ((qa, na, uv_a), (qb, nb, uv_b)) = (on_a.project(at)?, on_b.project(at)?);
|
||
let tangent = tangent.normalized()?;
|
||
let ja = on_a.section(uv_a, na, across(na, tangent))?;
|
||
let jb = on_b.section(uv_b, nb, across(nb, tangent))?;
|
||
// The faces' outward normals agree on a smooth seam; where they are opposed (a knife edge)
|
||
// the sections are compared in one frame: face b's normal and its across direction both turn
|
||
// round, so its k-th derivative of curvature reads (−1)^(k+1) times as much in face a's.
|
||
let opposed = na.dot(nb) < 0.0;
|
||
let jump = |k: usize, a: f64, b: f64| {
|
||
let flip = if opposed && k.is_multiple_of(2) { -1.0 } else { 1.0 };
|
||
(a - flip * b).abs()
|
||
};
|
||
let [ka, ca, ra] = ja.values();
|
||
let [kb, cb, rb] = jb.values();
|
||
Some([qa.dist(qb), na.dot(nb).clamp(-1.0, 1.0).acos().to_degrees(), jump(0, ka, kb), jump(1, ca, cb), jump(2, ra, rb)])
|
||
}
|
||
|
||
/// The direction in which a face's curvature is read at a seam: across the edge, square to it,
|
||
/// inside the face's tangent plane (a zero vector where the edge runs along the normal, which
|
||
/// leaves that station unmeasured).
|
||
fn across(normal: Vec3, tangent: Vec3) -> Vec3 {
|
||
normal.cross(tangent)
|
||
}
|
||
|
||
/// Keep the largest value seen, with where it was found.
|
||
fn keep(worst: &mut Option<SeamWorst>, value: f64, at: Vec3, edge_fraction: f64) {
|
||
if value.is_finite() && worst.is_none_or(|w| value > w.value) {
|
||
*worst = Some(SeamWorst { value, at, edge_fraction });
|
||
}
|
||
}
|
||
|
||
/// A face's surface, kept over the stations of one edge so each search can start at the last
|
||
/// answer (stations run along the edge, so the parameters move smoothly).
|
||
struct FaceSurface {
|
||
surface: SurfaceEval,
|
||
/// +1 where the natural normal points out of the material, −1 where it points in.
|
||
side: f64,
|
||
hint: Option<[f64; 2]>,
|
||
}
|
||
|
||
impl FaceSurface {
|
||
fn new(surface: &b::Surface, outward: bool) -> Option<Self> {
|
||
Some(Self { surface: SurfaceEval::new(surface).ok()?, side: if outward { 1.0 } else { -1.0 }, hint: None })
|
||
}
|
||
|
||
/// The nearest point of the surface to `p`, the outward unit normal there and the
|
||
/// parameters. `None` where the search or the normal is unusable.
|
||
fn project(&mut self, p: Vec3) -> Option<(Vec3, Vec3, [f64; 2])> {
|
||
let uv = self.surface.project(p, self.hint, f64::INFINITY).or_else(|| self.surface.project(p, None, f64::INFINITY))?;
|
||
let (q, su, sv) = self.surface.derivs(uv[0], uv[1])?;
|
||
if !q.is_finite() {
|
||
return None;
|
||
}
|
||
let normal = (su.cross(sv) * self.side).normalized()?;
|
||
self.hint = Some(uv);
|
||
Some((q, normal, uv))
|
||
}
|
||
|
||
/// The face's normal section at `uv` along `direction` (a unit vector of its tangent plane):
|
||
/// its curvature `κ = n · r″` and κ's first two arc-length derivatives, from the surface's
|
||
/// exact partials. A plane reads 0 and a cylinder of radius `R`, across its axis, −1 / R
|
||
/// (bending towards its axis). `None` at a degenerate parameter point (a cone's apex).
|
||
fn section(&self, uv: [f64; 2], normal: Vec3, direction: Vec3) -> Option<SectionJet> {
|
||
normal_section(&self.surface.partials(uv[0], uv[1])?, normal, direction)
|
||
}
|
||
}
|
||
|
||
#[cfg(test)]
|
||
#[allow(clippy::unwrap_used)]
|
||
mod tests {
|
||
use super::*;
|
||
use solidcore_record::{Plane, Seg2};
|
||
|
||
fn tolerances() -> ContinuityTolerances {
|
||
ContinuityTolerances::default()
|
||
}
|
||
|
||
fn box_body() -> Body {
|
||
crate::box_solid(Vec3::new(0.0, 0.0, 0.0), Vec3::new(10.0, 10.0, 10.0)).unwrap()
|
||
}
|
||
|
||
fn report(body: &Body) -> ContinuityReport {
|
||
seam_diagnostics(body, &[], 33, tolerances()).unwrap()
|
||
}
|
||
|
||
#[test]
|
||
fn a_box_edge_is_a_gap_free_right_angle() {
|
||
let body = box_body();
|
||
let r = report(&body);
|
||
assert_eq!(r.seams.len(), 12, "a box has twelve edges");
|
||
assert_eq!(r.skipped, 0);
|
||
for seam in &r.seams {
|
||
assert!(seam.gap_mm.value < 1e-6, "gap {}", seam.gap_mm.value);
|
||
assert!((seam.normal_angle_deg.value - 90.0).abs() < 1e-9, "angle {}", seam.normal_angle_deg.value);
|
||
assert!(seam.curvature_jump_per_mm.value < 1e-9, "jump {}", seam.curvature_jump_per_mm.value);
|
||
assert_eq!(seam.verdict, SeamVerdict::Sharp);
|
||
assert_eq!(seam.order, Some(Continuity::G0));
|
||
assert_eq!(seam.samples, 33);
|
||
assert!((seam.length - 10.0).abs() < 1e-9);
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
fn a_fillet_seam_is_tangent_with_the_fillets_curvature_jump() {
|
||
let body = box_body();
|
||
let rounded = crate::fillet(&body, &[Vec3::new(10.0, 10.0, 5.0)], 4.0).unwrap();
|
||
let r = report(&rounded);
|
||
// The rounded edge is replaced by the blend face: two tangent seams along it, the two
|
||
// arcs where the blend meets the ends of the edge, and the box's other eleven edges.
|
||
assert_eq!(r.seams.len(), 15);
|
||
let tangent: Vec<&SeamReport> = r.seams.iter().filter(|s| s.normal_angle_deg.value < 0.01).collect();
|
||
assert_eq!(tangent.len(), 2, "the fillet meets its two neighbours tangentially");
|
||
for seam in &tangent {
|
||
assert!(seam.gap_mm.value < 1e-6);
|
||
assert!(seam.curvature_jump_per_mm.value.is_finite());
|
||
assert!((seam.curvature_jump_per_mm.value - 0.25).abs() < 1e-6, "1 / radius, got {}", seam.curvature_jump_per_mm.value);
|
||
assert_eq!(seam.verdict, SeamVerdict::CurvatureJump);
|
||
// A plane tangent to a cylinder: G1, not G2. Neither section's curvature changes.
|
||
assert_eq!(seam.order, Some(Continuity::G1));
|
||
assert!(seam.curvature_change_jump_per_mm2.value < 1e-9 && seam.curvature_change_rate_jump_per_mm3.value < 1e-9);
|
||
}
|
||
assert_eq!(r.seams.iter().filter(|s| s.verdict == SeamVerdict::Sharp).count(), 13);
|
||
}
|
||
|
||
#[test]
|
||
fn a_line_tangent_into_an_arc_reports_one_over_its_radius() {
|
||
use solidcore_record::{Loop2, Region2, Seg2, Vec2};
|
||
let v = |x: f64, y: f64| Vec2::new(x, y);
|
||
let outer = Loop2 {
|
||
segs: vec![
|
||
Seg2::Arc { center: v(10.0, 0.0), radius: 5.0, start: -std::f64::consts::FRAC_PI_2, sweep: std::f64::consts::PI },
|
||
Seg2::Line { a: v(10.0, 5.0), b: v(-10.0, 5.0) },
|
||
Seg2::Arc { center: v(-10.0, 0.0), radius: 5.0, start: std::f64::consts::FRAC_PI_2, sweep: std::f64::consts::PI },
|
||
Seg2::Line { a: v(-10.0, -5.0), b: v(10.0, -5.0) },
|
||
],
|
||
};
|
||
let body = crate::extrude(&Plane::XY, &[Region2 { outer, holes: vec![] }], 0.0, 3.0).unwrap().remove(0);
|
||
let r = report(&body);
|
||
let joins: Vec<&SeamReport> = r.seams.iter().filter(|s| s.normal_angle_deg.value < 0.01).collect();
|
||
assert_eq!(joins.len(), 4, "a slot has four line-to-arc joins");
|
||
for seam in joins {
|
||
assert!(
|
||
seam.curvature_jump_per_mm.value > 0.19 && seam.curvature_jump_per_mm.value < 0.21,
|
||
"1 / 5, got {}",
|
||
seam.curvature_jump_per_mm.value
|
||
);
|
||
}
|
||
}
|
||
|
||
/// A 3 mm tall prism over a profile that runs along a line from (-20, 0) to the origin, on
|
||
/// into `transition` (starting at the origin, leaving along +x), and back straight to
|
||
/// (-20, 20): its one tangent wall seam is the line meeting the transition.
|
||
fn line_into(transition: Seg2) -> Body {
|
||
use solidcore_record::{Loop2, Region2, Vec2};
|
||
let end = match transition {
|
||
Seg2::Cubic { p3, .. } => p3,
|
||
Seg2::Bezier { n, p } => p[usize::from(n)],
|
||
_ => Vec2::new(0.0, 0.0),
|
||
};
|
||
let outer = Loop2 {
|
||
segs: vec![
|
||
Seg2::Line { a: Vec2::new(-20.0, 0.0), b: Vec2::new(0.0, 0.0) },
|
||
transition,
|
||
Seg2::Line { a: end, b: Vec2::new(-20.0, 20.0) },
|
||
Seg2::Line { a: Vec2::new(-20.0, 20.0), b: Vec2::new(-20.0, 0.0) },
|
||
],
|
||
};
|
||
crate::extrude(&Plane::XY, &[Region2 { outer, holes: vec![] }], 0.0, 3.0).unwrap().remove(0)
|
||
}
|
||
|
||
/// The one seam of `body` where the faces are tangent.
|
||
fn tangent_seam(body: &Body) -> SeamReport {
|
||
let r = report(body);
|
||
let mut tangent: Vec<SeamReport> = r.seams.into_iter().filter(|s| s.normal_angle_deg.value < 0.01).collect();
|
||
assert_eq!(tangent.len(), 1, "{tangent:?}");
|
||
tangent.remove(0)
|
||
}
|
||
|
||
/// A plane into a cubic whose first three control points lie on the plane's line: the cubic
|
||
/// starts with zero curvature (G2), but its curvature changes there. For control points
|
||
/// (0,0), (L,0), (2L,0), (3L,H): B′ = (3L, 0), B″ = 0 and B‴ = (0, 6H) at the start, so
|
||
/// dκ/dt = (x′y‴ − y′x‴) / |B′|³ = 2H / (3L²) and, at ds/dt = 3L, dκ/ds = 2H / (9L³): with
|
||
/// L = H = 10, 2 / 900 per mm².
|
||
#[test]
|
||
fn a_plane_into_a_g2_transition_is_curvature_continuous_but_not_g3() {
|
||
use solidcore_record::Vec2;
|
||
let v = Vec2::new;
|
||
let body = line_into(Seg2::Cubic { p0: v(0.0, 0.0), p1: v(10.0, 0.0), p2: v(20.0, 0.0), p3: v(30.0, 10.0) });
|
||
let seam = tangent_seam(&body);
|
||
assert!(seam.curvature_jump_per_mm.value < 1e-9, "{}", seam.curvature_jump_per_mm.value);
|
||
let change = seam.curvature_change_jump_per_mm2.value;
|
||
assert!((change - 2.0 / 900.0).abs() < 1e-9, "dκ/ds 2/900, got {change}");
|
||
assert_eq!(seam.order, Some(Continuity::G2));
|
||
assert_eq!(seam.verdict, SeamVerdict::Smooth, "G2 is still smooth to the older verdict");
|
||
}
|
||
|
||
/// A plane into a quartic whose first four control points are evenly spaced on the plane's
|
||
/// line: curvature and its change both start at zero (G3), but the change's rate does not.
|
||
/// For (0,0), (L,0), (2L,0), (3L,0), (4L,H): B′ = (4L, 0), B″ = B‴ = 0 and B⁗ = (0, 24H),
|
||
/// so d²κ/dt² = (x′y⁗ − y′x⁗) / |B′|³ = 3H / (2L²) and, at ds/dt = 4L, d²κ/ds² = 3H / (32L⁴):
|
||
/// with L = 5, H = 10, 3 / 2000 per mm³.
|
||
#[test]
|
||
fn a_plane_into_a_g3_transition_holds_the_change_of_curvature_but_not_g4() {
|
||
use solidcore_record::Vec2;
|
||
let mut p = [Vec2::new(0.0, 0.0); solidcore_record::MAX_BEZIER_CTRL];
|
||
for (k, q) in [(5.0, 0.0), (10.0, 0.0), (15.0, 0.0), (20.0, 10.0)].into_iter().enumerate() {
|
||
p[k + 1] = Vec2::new(q.0, q.1);
|
||
}
|
||
let body = line_into(Seg2::Bezier { n: 4, p });
|
||
let seam = tangent_seam(&body);
|
||
assert!(seam.curvature_jump_per_mm.value < 1e-9 && seam.curvature_change_jump_per_mm2.value < 1e-9, "{seam:?}");
|
||
let rate = seam.curvature_change_rate_jump_per_mm3.value;
|
||
assert!((rate - 3.0 / 2000.0).abs() < 1e-9, "d²κ/ds² 3/2000, got {rate}");
|
||
assert_eq!(seam.order, Some(Continuity::G3));
|
||
// Within a looser rate tolerance the same seam reads G4.
|
||
let loose = ContinuityTolerances { curvature_change_rate_per_mm3: 1e-2, ..tolerances() };
|
||
let r = seam_diagnostics(&body, &[seam.edge], 33, loose).unwrap();
|
||
assert_eq!(r.seams[0].order, Some(Continuity::G4));
|
||
}
|
||
|
||
#[test]
|
||
fn the_highest_order_met_needs_every_order_below_it() {
|
||
let tol = [1.0; 5];
|
||
assert_eq!(highest_met([0.0; 5], tol), Some(Continuity::G4));
|
||
assert_eq!(highest_met([0.0, 0.0, 2.0, 0.0, 0.0], tol), Some(Continuity::G1), "a G2 failure caps the order");
|
||
assert_eq!(highest_met([2.0, 0.0, 0.0, 0.0, 0.0], tol), None, "faces that do not meet have no order");
|
||
assert_eq!(highest_met([0.0, 0.0, 0.0, f64::NAN, 0.0], tol), Some(Continuity::G2), "NaN never passes");
|
||
for (order, verdict) in [(None, SeamVerdict::Gap), (Some(Continuity::G0), SeamVerdict::Sharp), (Some(Continuity::G3), SeamVerdict::Smooth)] {
|
||
assert_eq!(SeamVerdict::of(order), verdict);
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
fn picks_refuse_what_is_not_there() {
|
||
let body = box_body();
|
||
let all = pick_edges(&body, &[]).unwrap();
|
||
assert_eq!(all.len(), 12);
|
||
// The edge up the corner at (0, 0), beside a point in the middle of a face.
|
||
let picked = pick_edges(&body, &[EdgePick::Point(Vec3::new(0.0, 0.0, 5.0)), EdgePick::Index(all[0])]).unwrap();
|
||
assert_eq!(picked.len(), 2);
|
||
assert!(pick_edges(&body, &[EdgePick::Index(999)]).is_err());
|
||
assert!(pick_edges(&body, &[EdgePick::Point(Vec3::new(0.0, 5.0, 5.0))]).is_err(), "a point on a face is not on an edge");
|
||
assert!(pick_edges(&body, &[EdgePick::Point(Vec3::new(500.0, 0.0, 0.0))]).is_err());
|
||
assert!(seam_diagnostics(&body, &[], 2, tolerances()).is_err());
|
||
assert!(seam_diagnostics(&body, &[], 258, tolerances()).is_err());
|
||
assert!(seam_diagnostics(&body, &[], 33, ContinuityTolerances { gap_mm: f64::NAN, ..tolerances() }).is_err());
|
||
assert!(seam_diagnostics(&body, &[], 33, ContinuityTolerances { curvature_change_rate_per_mm3: -1.0, ..tolerances() }).is_err());
|
||
assert!(seam_diagnostics(&body, &[999], 33, tolerances()).is_err());
|
||
}
|
||
}
|