Files
solidcraft/crates
Brett LawsonandClaude Opus 5.5 b8c2282090 solidcore: run the body check (smlib_brep_check) on solidcore#1419's check_brep
The check is the capi's call sequence on solidcore's public check API: ValidatePointers, then,
when that fails nothing, AssertValid over the whole body at the requested level. The report
keeps the capi's lines: "<type>::Test #N <name>: <message> [owner <type>]", the line for a
failed status with no report, and "AssertValid skipped". The failure count is the capi's: the
skipped line is not counted.

The check never reports a body valid after running fewer tests than the C++ kernel. A test
solidcore has not ported fails it with "not supported yet". So does a body whose geometry
owners are named by keys the check cannot know: NamingScheme::Unknown, or Caller other than
SolidCraft's own array import. check_brep would check those against arena identities and fail
SmBrep test 61 on every edge. Bodies imported from arrays are checked with the import's key_of.

The primitives' check and check parity tests run again. New tests: a valid box passes level 2
with an empty report on both kernels, and a box with a vertex moved 1 mm off its edges (made
through the arrays) gets the C++ kernel's report, line for line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-29 22:13:42 +01:00
..