Commit Graph
26 Commits
Author SHA1 Message Date
jyvikoandClaude Opus 5.5 80d08659f3 Kernel rig: the booleans, import and threads lists name the 5 cases that fail on the pinned SMLib
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 21:08:31 -04:00
jyvikoandClaude Opus 5.5 acd7bb066d Kernel rig: the boundary-fill crescent ends at the cusps, x = 5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 21:08:31 -04:00
jyvikoandClaude Opus 5.5 815711421e Kernel rig: second cases for draft (two adjacent faces), rib (in plane), press pull (an edge), split face (sketch and tool face) and sketch projection (a face loop and a silhouette)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 21:08:31 -04:00
jyvikoandClaude Opus 5.5 a5513a4e17 Kernel rig: boundary fill cases, the lens and the crescent of two cylinders, and a point outside every tool refused
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 21:08:31 -04:00
jyvikoandClaude Opus 5.5 e1724be629 Kernel rig: pattern on path cases, bosses along a line, bodies turning with an arc's tangent, and instances past the path's end refused
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 21:08:31 -04:00
jyvikoandClaude Opus 5.5 b67e93211d Kernel rig: an area's PATHS names only its own files, never the shared core
The booleans area also reruns on sketch projection from the model. The selection self-test
fails on an area glob that matches a file PATHS-ALL already covers, so a whole-crate glob
cannot creep in.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 21:08:31 -04:00
jyvikoandClaude Opus 5.5 02e1f18412 Kernel rig: each area runs only when the files its PATHS lists change, every area on the shared core
A plan job (scripts/ci/kernel_rig_plan.py, with its self-test) maps a pull request's changed files
to the areas: tests/kernel-cases/<area>/PATHS for each area, tests/kernel-cases/PATHS-ALL for the
shared core, the ladder whenever any area runs. Areas come from the folders, so a new one needs no
workflow edit. Pushes, merge groups, the release gate and runs by hand run every area. The
kernel-rig check counts a skipped build or shard as passed only when the plan selected none.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 21:08:31 -04:00
jyvikoandClaude Opus 5.5 b4fcd59100 Kernel rig: every area and the ladder as a parallel gate on pull requests that touch the kernel
kernel-rig.yml builds solidcraft-cli once (release, SMLib prebuilt; sccache on a sticky disk
that only pushes to main and develop commit) and hands it, with the rig's runner, to a matrix
of eleven shards: the ten areas of tests/kernel-cases/, each against its KNOWN_FAILING, and
the ladder against its golden. One path filter covers the kernel surface; drafts skip; a new
push cancels a pull request's old run; merge groups always run it, and the release gate calls
it. The areas other than fillets get a KNOWN_FAILING with only its header, to be seeded from
develop after the SMLib pin bump.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 21:08:31 -04:00
jyvikoandClaude Opus 5.5 9008d13f31 Surface Extrude: a symmetric distance is the total, as for a solid extrude
A symmetric surface.extrude given no convention now splits its distance
evenly around the start plane (10 mm: 5 mm each side), the way
solid.extrude reads it, instead of going the distance each way. Both
commands take their default from one function, which a session setting
(surface_extrude_symmetric_per_side) can turn back to the per-side
reading for surface extrudes. timeline.edit and timeline.redefine give a
one-sided surface extrude made symmetric the same default.

Saved designs are unchanged: every surface extrude saved its convention
(legacy_per_side), and one saved before the marker existed reads per side
as it always did. The help of both commands says how the distance is
read. The 3830 kernel case, recorded with the per-side reading, now says
so explicitly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 19:09:59 -04:00
jyvikoandClaude Opus 5.5 6e15b96769 engine, kernel-cases: tangent joins out of the corner-pick count; 3383 and 5024 recipes to main's rules
The corner pick (#5173) counts the edges meeting at a picked point; seams already
did not count, and now a tangent join between two spans of one smooth curve does
not either (4332: a chamfer on a spline rim was refused as two edges).

3383: the first occurrence is grounded by default on main, so the recipe
ungrounds it before moving it. 5024: a hole's position must lie on a face, so the
centre is on the box's top edge; the volume is half of the drilled cut, exact.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:53 -04:00
jyvikoandClaude Opus 5.5 bd4e1926a9 kernel-cases: 2928's base extrudes the ring it describes
The case's base is a stadium ring (r 3..5 arcs, centres 20 apart, z 0..2),
as its description and expected volume (2 (80 + 16 pi) for the base) say,
but its extrude picked no profile, and "all profiles" is every drawn region:
the ring and the stadium island inside it. The base came out filled and the
join 1066 mm3. SMLib's union was exact for those operands. The extrude now
picks the ring (the region at (4, 0)).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 4856fd3df1 kernel-cases: #5198–#5463 triaged: 14 cases, 100 skipped
Cases from the issues filed after #4160, each a synthetic recipe with its own answer
(analysis or invariants); every other issue in the range is listed with why it was skipped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 e47c338078 kernel-cases: #4830–#5197 triaged: 21 cases, 110 skipped
Cases from the issues filed after #4160, each a synthetic recipe with its own answer
(analysis or invariants); every other issue in the range is listed with why it was skipped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 173000b44b kernel-cases: #4432–#4829 triaged: 21 cases, 175 skipped
Cases from the issues filed after #4160, each a synthetic recipe with its own answer
(analysis or invariants); every other issue in the range is listed with why it was skipped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 5bc0dc6883 kernel-cases: #4161–#4431 triaged: 19 cases, 93 skipped
Cases from the issues filed after #4160, each a synthetic recipe with its own answer
(analysis or invariants); every other issue in the range is listed with why it was skipped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 810f0d66d9 doc: a join groups pieces that touch nothing; only edge and point contacts are kept apart
With touching: separate (the default) a join groups the joined body's
pieces by face contact. The groups that hold the material of the body
before the feature stay in it (each unless it touches one already kept;
the first group where the lineage doesn't say), and so do the groups that
touch nothing: a virtual grouping later operations take as one body. Every
other group that touches another along an edge or at a point becomes a
body of its own, and the feature's notice says so. The joined body keeps
its name and never holds an edge or point contact. A join that only
grouped pieces apart gives no notice, so KeptSeparate::Apart is gone.
one_body still keeps every piece in one body.

SMLib's export copies an edge or vertex that touching solids share once
per solid, so the record never listed those contacts:
Brep::region_contacts now takes such copies (the same curve and interval
between vertices at the same points, a vertex at the same point) as the
edge or vertex they share. A contact SMLib leaves out of the topology (the
3612 spoke tangent to its hub) is found on the exact geometry, the least
distance within the record tolerance, and reported as KeptSeparate::
Touching ("along a line or at a point").

The pending format change join-touching-bodies stays: older designs kept
pieces touching along an edge or at a point in one body too. Its notes say
so, and the reopened legacy emboss still expects touching: one_body.

Tests restored to their form before cc49081df and 733d3bd19: kernel-cases
2896-join-arm-end-near-ring-wall-gap (one body of two shells), 3379, 3455
and 3526 (no touching: one_body); the engine tests of posts joined while
apart (twice), two cubes for interference, a ring with a cylinder, the
buried tab and a_join_adds_only_its_sketch's 0.1 mm gap.
join_meeting_nothing_keeps_the_first_body expects one body and no notice.
The #3378 spoke stays 1 mm inside the hub.

New tests: blocks touching along an edge are split with the along-an-edge
notice; blocks apart stay one body without one; a ring with an arm on its
corner edge and a hub apart gives ring and hub in one body and the arm on
its own (doc); the engine's notice for an edge contact; the record's
contacts of cubes sharing an edge or a vertex (kernel).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:52 -04:00
jyviko 94ee28d5ce doc: a join keeps solids that only touch as separate bodies
A feature's touching parameter says what a join makes of solids that
share no volume and no area: separate (the default) splits the joined
body's pieces that share no face into bodies of their own, named, with
history and lineage, as a cut's pieces are; one_body keeps one body of
several pieces. The state records how the kept-apart pieces met
(KeptSeparate: along an edge, at a point, apart) for the feature's
notice.

Older builds kept every join's pieces in one body: the pending format
change join-touching-bodies gives each joining feature of an older design
touching: one_body, so existing designs keep their bodies.

kernel-cases 2896-join-arm-end-near-ring-wall-gap: the arm meets nothing,
so it now stays a body of its own (body_count 2, one shell each).

kernel-cases that join solids apart to make the body they test ask for
it with touching: one_body: 3379 (the hub joined to the ring before the
spokes reach it), 3455 (64 pegs in one body) and 3526 (a two-lump target
for an intersect).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
(cherry picked from commit 2c2aaed86f4be60f7f88e40bc24b60de60085148)
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 2d3d0a081b kernel-cases: a join that meets nothing keeps the tool as a lump (#2896)
The case expected two bodies for a combine join of an arm 0.01 mm clear of a
ring. A join's tool that meets no target goes into the target as a separate
lump and the tool body is consumed (doc eval Operation::Join; the engine test
join_meeting_nothing_keeps_the_first_body): one body, Ring, of two shells,
with the volumes' sum. The case's point, nothing fuses, is kept: shells 2 and
the summed volume.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:48 -04:00
bherbruckandClaude Opus 5.5 c24b066d25 kernel-cases: an outcome for geometry with no single manifold answer
`"outcome": "solid_or_refused"` takes a clean refusal, or else grades the result as usual. Two
bodies that touch along a circle only (#168, #3841) have no one-solid union: a refusal or the two
bodies left apart are both right; fusing them is wrong. The two cases said opposite things
(two bodies, a refusal) and now agree.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:45 -04:00
bherbruckandClaude Opus 5.5 678a70da2c kernel-cases: shells as a graded count, no SMLib verdict where it can't take the record, $OUT
- `"shells": N` in expected.json grades the total number of shells: a body with a sealed void
  holds two, and some joins keep several lumps in one body. Those cases (#3175, #3455, #3526,
  #3730) are graded on validity again instead of being marked not valid.
- When SMLib's record conversion says "not supported yet" (revolved surfaces, traced intersection
  curves), its check gives no verdict. That's shown but not graded, since it isn't a fault of the
  body. solidcraft_kernel::SmlibCheck carries the three outcomes.
- `$OUT` in a recipe is a scratch directory outside the repository, for files a case writes. The
  two STEP-export crash cases write there instead of /tmp.
- cargo xtask kernel-cases --results FILE keeps every result as JSON.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:45 -04:00
bherbruckandClaude Opus 5.5 ec154f5421 kernel-cases: booleans cases from items another area had skipped (#451, #1107, #1140, #2928, #3850/#3741, #1984, #3573)
Added: 451 (block inside / crossing a hollow spherical-shell tool), 1107 (hollow hub joined
with nine blades), 1140 (spiral hollow lofted tube cut in half and joined), 2928 (cap-touching
lips with 0.0001 mm offset walls), 3850 with 3741 (cross cut touching a round side, and the
hole after it), 1984 (near-coaxial pin and rivet overlaps). #3573 is now a source of
shell/3576. Their lines are gone from the skipped files; #2259, #3518 and #3602 stay skipped
with corrected reasons.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:45 -04:00
bherbruckandClaude Opus 5.5 6a9b8fd740 kernel-cases: booleans from #3404-#4124 (28 cases, 76 skipped)
Cases: mirror of a cut under a wall (#4011), coplanar intersect (#3671), multi-lump
intersect (#3526), split along a face plane (#3447), 64-peg join (#3455), boss on a rod
(#3485), collinear cylinders and pin in a bore (#3497), swept G2 cut (#3604), spokes
tangent to a hub (#3612), sphere and pyramid (#3633), column in a channel (#3665),
extrude to a point on an edge (#3729), emboss on a cylinder (#3782), circle-only join
(#3841), ring on a perforated plate (#3887), symmetric revolve cut (#4008), walls round a
floor (#4058), slab beside a bore (#4095), and others. The rest are skipped with a reason
in skipped-c.json.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:45 -04:00
bherbruckandClaude Opus 5.5 611567c63c kernel-cases: booleans from #2896-#3383 (11 cases) and the skipped list
Cases for the near-contact gap join, a countersunk hole beside a distant
body, a perforated plate under a ring, a sealed void, a rim and tooth join,
a frustum cut, a line-to-line pin, a flush notch, spoke patterns and a join
into a rotated occurrence. The rest of the bundle is in skipped-b.json with
one line each.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:45 -04:00
bherbruckandClaude Opus 5.5 6cf966bd50 kernel-cases: booleans from #2564-#2896 (11 cases)
Hand-derived cases for tapered and collinear extrudes, pattern and mirror
copies keeping their targets, a cut up to a face, a prism joined to a
round-cornered slab, a clip round a small hole, and near-contact joins.

2564, 2583, 2601, 2754, 2755 (pattern, mirror), 2801, 2810, 2826, 2580,
2896 (overlap)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:45 -04:00
bherbruckandClaude Opus 5.5 48db4fa2cf kernel-cases: booleans from #13-#2534, first half (30 cases, 73 skipped)
Spheres cut twice (#1717), box/cylinder intersect (#1647), crossing cylinders
moved far (#1649), coaxial cut from a thin disc (#500), coincident cylinder
walls (#114, #2008, #1910, #1865), rim touching a coin (#168), holes along
walls and beside rounds (#559, #562, #1279, #1355, #2055), tangent holes
(#307), blind cut in a cylinder (#308), through-all cut (#423), shallow cuts
(#1858), skin left by a short cut (#1730), delete face (#1927), collinear
extrude sides (#1949), hidden bodies (#2464), mirror and patterns (#2003,
#2524, #2076), tapered extrudes (#831), text cut (#1195), split (#13).
Every other item in the bundle is in skipped-a.json with its reason.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:45 -04:00
bherbruckandClaude Opus 5.5 c3a0b09519 kernel-cases: the no-keyword kernel items, #25-#4148 (4 cases, 98 skipped)
Cases: #3702 (a board in the cavity of a case with a filleted rim, cut leaves the case
unchanged) and #258 (STEP cone to a point, with and without an apex vertex, and the 0.5 mm
pin). Everything else in the bundle is skipped with a reason in skipped-other.json.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:45 -04:00