The portable record's 4,000,000-item budget refused a real result: the join of a level-4
Menger sponge's level-3 sponges ended with "SMLib export: the mapped B-rep does not validate:
portable B-rep: item budget". The budget guards records from outside the kernel, and a body
the kernel built in memory from inputs already bounded where they came in isn't hostile.
Brep::validate keeps the budget for records read from outside: native design caches
(decode_native_body, behind its own 256 MiB, 1M-per-array and 20M-value caps) and STEP import.
The new Brep::validate_built runs every other check, without the cap, on what the kernel
builds: SMLib's export of an operation's result, a body's record (Body::from_record, after
the decoder has checked a file's), a part of a validated record, the record handed back to
SMLib, and the validity check. Its checks are linear in a record already in memory.
SMLib's export bounded its counts by the same budget; a count is now bounded by SMLib's own
longest array (flat::MAX_LEN, checked on entry), which keeps every offset worked out from
the counts from overflowing, and the redundant topology-length cap goes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- #58: a fillet's tangent-point step no longer depends on the blends before it (solidcore #1173).
- #59: the fillet clean-up keeps the target's edges and faces by a mark, not by address (#1176).
- #60: capi test, a line projected through a sphere's poles meets itself smoothly at each pole.
- #61: offset faces removes a step wall the move closes to nothing and merges the two tops, so
shell/cov-replace-face-step-onto-the-higher-face builds.
- #62: thicken puts a flat side wall on its plane (solidcore #1599), so a cylinder sheet's end
rings are planes: surfaces/cov-thicken-cylinder-sheet-symmetric-tube passes.
Both cases leave KNOWN_FAILING.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tangency-labs/smlib#57 on top of 60b1c6a. It fixes the two engine tests the earlier pin broke:
press_pull_on_curved_faces and a_shell_fillet_does_not_follow_a_gone_edge_onto_a_smooth_seam,
with their expectations unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
From 7e917f0 to 60b1c6a on tangency-labs/smlib replay/1.0.1, 45 commits in 43
pull requests:
- Booleans (#28, #29, #34, #39, #45, #47, #55, #56): a coincident edge split with
its edge, a plane grown to cover a face however far, a seam point classified to
its face, intersection loops closed only along edges that lie on each other,
curves inside one ProtoVertex split at its vertices, an intersection along a
face's own edge taken as that edge, a plane a hair into a cylinder touching it
along one line (and crossing it in two), faces and loops apart not intersected.
- Transforms (#48, #49, #50): a mirrored cylinder read back from its NURBS turns
the right way, a rotation or reflection keeps every tolerance and a scale
scales them, a scaled body's model size is measured from its geometry.
- Fillets and chamfers (#24, #30, #51): a chamfer round an arc is a cone, a gentle
corner in a variable radius splits the round, a seam round's corner ball sits
where the cylinders' axes meet.
- Shell and offset (#17, #22, #23, #25, #26, #32, #38): closed faces and closed
sheets offset, exact lines and conics between analytic faces, cones and
cylinders extended as themselves, a cone's apex offset as a sphere, a wall
that would turn a face inside out refused, neighbours extended to reach a
face moved past the body's size, an open edge's trim point on a closed curve.
- Draft (#27, #53): a cylinder along the pull drafts to a cone, a cone about the
pull to the cone its turned generators make.
- Sweeps (#14, #31, #36, #37, #40, #43, #44): a whole turn of a holed profile
leaves the void, a curve near a circle swept as itself (text outlines' Béziers
pass the check), an arc centred across the axis revolves to an exact B-spline
surface of revolution, a minor circle on the axis and a horn torus, line and
arc paths swept exactly piece by piece.
- Surfaces (#18, #19, #20, #21): a B-spline starter in Bezier form, extend by the
distance across the surface and as the same cone or cylinder, untrim in place.
- Intersections (#35, #46, #52): a curve into a pole keeps its tangent, a periodic
value just past the top wraps a period down, a curve from a singular point
starts inside.
- Checks, history, measure (#15, #16, #33, #41, #42, #54): a face whose edges
moved is Modified, SMLib's warnings are no failed test, sheet faces count in
the area, internal poles sought in the knot's row, a collapsed seam not
classified, a small loop oriented on the surface's scale.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- An SMLib circle edge's `interval` is on its NURBS form (`Edge::parameters`), and an analytic
face's `domain` on the form's (u, v). edges_are_on_smlibs_curves evaluated `curve` at the
form's interval and took the domain for angles; it checks the side's whole turn and height
on the form and a rim's turn by `curve_interval`. The tangent hole test's edge middles were
read the same way (the copy seemed to join faces on opposite sides of the line).
- kernel::chamfer blends the edges it is given; a feature's pick is extended by
kernel::tangent_chain first (doc eval). The chamfer tests do the same:
one_chamfer_pick_follows_the_tangent_chain_at_any_part_size removes its 54.66 mm³ again.
- Since the section hatch per part (#8529) a cut is tinted with the hatch colour its body's
name picks (Body1: steel); the GPU cap test turns the part hatch off, as the CPU one does
(2885f101b on devgreen-engine-builds).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib can give a NURBS edge an interval that starts or ends a rounding past its
curve's knots: the end of the variable round r1 -> r5 run on into a box corner's
R5 round (ladder 07-fillets/012), trimmed by the R5 cylinder, started 7e-15 before
the first knot, and the record failed validation ("parameter interval outside
the natural domain"). Such an interval is moved onto the knots, as a face's
domain side is onto its surface's natural range (`onto`); farther past them is
still an error. SMLib 7e917f0 (c0d74ee..6e77631: the trace's reach set before
the corners) moved these ends by 1e-11, which is how the case regressed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
At the 7e917f0 pin SMLib builds the r50 round of a 20 cube's edge that
hostile_inputs_are_errors expected to fail: a convex blend that overflows its
faces' far edges is built by subtraction (blend on the faces extended, then cut),
as the chamfer past the faces two lines below already is. The body is exact: the
two ends, the two far faces and the round (5 faces, 9 edges, 6 vertices), volume
20 (F(40) - F(30) - 300) = 1094.85273 with F(u) = (u sqrt(2500 - u^2) +
2500 asin(u / 50)) / 2, the cube's section inside the r50 circle about
y = z = -30. The test checks that answer instead of an error.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A smooth edge (its faces meet tangentially) has nothing to round, and an edge
that runs on tangentially into one left out has no end SMLib can blend (it
rounds a tangent chain as one sequence and failed building the face there,
status 1001): both are refused before SMLib with that reason. SMLib's new
SMLIB_ERR_CORNER_UNSUPPORTED (a vertex no blend corner handles) is
Error::CornerUnsupported and says so instead of a bare status.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tangency-labs/smlib#11 (the Coons corner patch is tangent to its sides' surfaces), #12
(SMLIB_ERR_CORNER_UNSUPPORTED for a vertex no blend corner handles) and #13 (a torus found in a
NURBS has its major radius from its origin and a whole turn of its tube). Prebuilt hashes written
by scripts/fetch-smlib.sh --pin.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A new undoable feature (`repair`, one pending format file) and command with input and
output schemas. In order:
- A cylinder, cone, sphere or torus face SMLib refuses on its own is rebuilt on a NURBS
form of its surface laid on arcs from where the face starts
(`form::surface_on_own_arcs`), with SMLib's own trims: the import's quarter-grid form of
a face round most of a turn closes on itself, which SmTorus::IsNurbSurfaceTorus does not
recognise. Geometry unchanged.
- Free edges that pair up within `gap` are sewn by SMLib's stitch; GlueEdgesGeneral gives
each glued edge its own tolerance (at least twice its gap), the body's and the other
edges' stay. The result is checked against the input's own SMLib check, the
tolerance-bound tests (#5, #6, #59, #82) exempt.
- Loops of free edges left are holes: offered as surface.patch, and with patch_holes made
(flat only when the loop is planar and every face around it is a plane, else G1) and
sewn in.
The reply reports what changed face by face; nothing to do is refused with why.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A torus face covering most of its tube off the tube's quarter lines (an
exhaust collector's bend: 326° of the tube from −113.8°) needed a fifth
quarter along the tube, which STEP counts from the outer equator: its form
ran past a full turn of the tube and SMLib refused the solid. #8496 turns
frames about the axis only, and the torus label had no tube reference.
The torus label gets a tube start (`tube_start`, radians; 0 and left out
of the record by default, so older records mean what they did): v counts
from there, in every evaluator, form, pcurve, iso curve, tessellation,
placement, SSI and SMLib transfer. A spilling torus face's tube start moves
to where its tube begins, or a turn before where it ends, whichever puts
its tube circles on the grid of a round face they are about the axis of
(a pipe's cylinder meeting the bend); circles round the tube are labelled
from the tube start (brep::form::on_tube), so their forms and pcurves lie
on the face's quarter grid exactly. The saved-format change is one file,
crates/doc/src/format/pending/torus-tube-start.rs.
Engine assembly: COLLECTOR_EXHAUST_VER_1 now comes in as a closed solid
(refused 3 -> 2); Poppy Humanoid unchanged (4).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An edge that lies off its face's surface has its tolerance raised to cover the
gap before SMLib makes its trims (cover_gaps). Where such an edge runs out of
its patch, SMLib ends it where its drop onto the patch ends when that is within
the edge's cross-section tolerance of its vertex (SmEdgeuse::CreateUVTrimCurve),
and moves the edge's interval there. The moved end was checked against the
edge's tolerance before it was raised (1e-5 mm), so two faces of Poppy
Humanoid's left thigh, whose edges SMLib ended 0.08-0.1 um short with a held
tolerance of 0.77 um, were refused ("SMLib moved an edge's interval"). The end
is now checked against the tolerance SMLib held the edge at.
Poppy Humanoid: thigh_left comes in as a closed solid (refused 4 -> 3).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An edge whose curve runs a few um past its vertex and its spline face's
patch was trimmed back by SMLib when it made the trim, and the face was
refused ("SMLib moved an edge's interval"). Our own measure never saw the
gap: STEP measures an edge against its surface only where the nearest point
is in closed form, and a spline face's gaps only on the pcurves the kernel
returns, after SMLib has trimmed the edge. Each bare use's edge is now
measured by SMLib (smlib_brep_edge_face_distance, over the patch) after the
sheet's import, its tolerance raised to cover the gap with
SURFACE_GAP_MARGIN and the sheet imported again: SMLib keeps the edge whole.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An edge raised to cover its pcurves' gap could get past SMLib's limit
(Congé19: 0.98 mm off, tolerance 1.47 mm) and its whole solid then failed
as "SMLib rejected the input". The tolerance an edge or vertex would get,
not only its gap, is now held to that 1 mm: farther off is refused with
how far. The record mapping refuses a tolerance past it with a message
rather than handing SMLib what it rejects.
The margin over a surface gap moves to solidcraft_geom::brep::pcurve
(SURFACE_GAP_MARGIN) for SMLib's pcurves to use too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Binds smlib_brep_edge_face_distance: how far an edge lies from a face's
surface over the surface's own domain, the gap SMLib sizes an edge's
tolerance by.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tangency-labs/smlib e51c3f2: a drop that comes back in pieces is joined
where they meet, never stretched onto its edge (solidcore#1383), and
smlib_brep_edge_face_distance.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pins tangency-labs/smlib 56f6e81 (release prebuilt-56f6e811bc84…): smlib_blend_setback_eased
and smlib_blend_setback_open_eased, an ease length before each set-back corner over which a
round's section blends from its circle to the curvature-continuous section (solidcore#1376).
New calls only; existing ones are unchanged (ease 0 is today's body).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib may end an edge at a parameter of its own: a knot its vertex lies at (-1.0 where the
vertex's angle gives -0.99999998, a 2e-8 step on the edge's quarter arc, far under 1e-6 mm).
We refused any change beyond 1e-9 of the parameter, a bound with no geometric meaning:
"SMLib moved an edge's interval" on 8 of Poppy Humanoid's faces. The ends SMLib chose are now
measured on the edge's curve: within the edge's tolerance, its pcurve is mapped onto our
interval by the affine change of parameter (exact for a B-spline: its knots move), and the
record's check measures it as any pcurve; farther is SMLib trimming the edge, refused with
how far.
Poppy: 227 → 232 bodies, 17 → 15 solids not imported, no interval refusals left.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
Pins tangency-labs/smlib 1072d1b (release prebuilt-1072d1b857de…): an N-sided corner
patch now meets each round on the round's own exact section edge instead of its polynomial
approximation, which the stitch kept on a near tie at some corners (solidcore#1377).
SMLIB_PREBUILT rewritten by scripts/fetch-smlib.sh --pin.
The kernel's tess, display_mesh, step, corner and fillet tests fail the same 63 as with the
previous pin, none new.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A revolved circle whose centre is as far from the axis as its radius (a horn torus, its
tube touching the axis) measured its major radius a few ulps above its minor from the
profile's control points, became SMLib's ring torus, and SMLib refused it
(SM_ERR_INVALID_INPUT: no ring torus of that NURBS). A ring torus now needs its tube
clear of the axis by more than rounding (1e-9 of the radius, the slack the same test
already takes for the circle's plane); a horn torus goes as its rational B-spline.
Test: a revolved unit circle 1.5 from the axis is a ring torus; at 1, 1 + 4 ulp and 0.5
it stays a revolution (develop calls the first two ring tori).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
A face on a placed revolution that carries its NURBS form (every STEP surface of
revolution, read since b6a3b31ff) was written as two NURBS blocks: the revolution's own
net, then the form, flagged FACE_NURBS_FORM on a NURBS face. SMLib reads one block per
face, so the flat arrays did not add up and it refused the body (SM_ERR_INVALID_INPUT),
in the main import and in the one-face sheets SMLib makes pcurves on. SMLib has no class
for a revolution: the form is the face, its range and trims already in its parameters,
so it now goes as that NURBS face with no form flag. A revolution the analytic pass
recognises (a plane, cylinder, cone, sphere, ring torus) is unchanged.
Test: surface_of_revolution_sense_follows_iso, which develop fails with the refusal,
passes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
SMLib's out_failed_corner reaches Rust as Error::CornerRefused { corner }, and the
kernel names the corner by its point: a G2 fillet at a corner of mixed convexity
says where it is and that SMLib sets back only corners whose rounds are all
convex or all concave. Engine test checks the message through solid.fillet.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
smlib_blend_setback_open's binding: the sheet, and per corner a Hole, its
edges in order (each starting where the one before ends), each with the face
beside it and whether that face runs it forwards. The holes' buffer starts at
64 edges a corner and grows once to the length a first call names. Tested on
the r5 box corner set back 8: 9/30/22, a sheet SMLib's check passes, one hole
of twelve edges chained end to start; an unrounded edge at the corner is
Unsupported.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Session::execute is a command span; Model::evaluate and each feature computed
(by its type) are spans; io's import, export and design read/write too; the
STEP reader's topology, pcurves and solid record.
- diagnostics.profile (contract + output schema): report, start/stop, reset,
Chrome trace file.
- A STEP/IGES import's reply carries its own profile while recording.
- Every app compiles the profiler in by default (feature `profile`);
SOLIDCRAFT_PROFILE=1 starts it.
- solidcraft-cli run/eval/bench-open --profile print the table on stderr,
--profile-out writes the trace; run --profile works on designs and STEP files.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The C API logs each call with its steady_clock time; the log sink records
that as an smlib span (child of whatever runs on the calling thread).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tangency-labs/smlib's prebuilt workflow builds the C API once per commit for every Rust target
SolidCraft builds (Linux x86_64 and aarch64, macOS arm64 and x86_64, Windows x64, x86 and ARM64,
wasm32 with wasi-sdk's C++ runtime) and releases it as prebuilt-<commit>. SMLIB_PREBUILT pins each
archive's SHA-256. scripts/fetch-smlib.sh now downloads the host's archive (or the named
targets'), checks its hash and the commit it was built from, and falls back to the sources for a
target with no archive; --source fetches the sources, --pin writes SMLIB_PREBUILT from the
release. build.rs links a fetched archive whose hash matches the pin, else compiles as before,
now with -ffp-contract=off like the archives: every platform does the same arithmetic. No
network access in build.rs.
SMLIB_REV moves to 8b57e7e: the workflow, and fixes for MSVC (no directive inside a macro
argument, SM_PI for M_PI), the no-fused-multiply-add build and a test that needed a POSIX shell.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HoZgkCdAVrscuw2kjQTWDs
On the web target the smlib build compiles SMLib for wasm32-wasip1 with wasi-sdk's clang
(WASI_SDK_PATH), with wasm exceptions in the exnref encoding that wasi-sdk's libc++ and Rust
use, and links wasi-sdk's libc++, libc++abi, libunwind and libc. The WASI calls libc makes are
defined in ffi.rs: stdout and stderr go to the log, the clocks are the page's (the C API times
every call), and there is no file system or environment. solidcraft-web gets an smlib
feature, off until CI has wasi-sdk.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HoZgkCdAVrscuw2kjQTWDs
Ladder 06/009 had no way to ask for one: "solid.thread has no runout (vanishing thread)
length". With SMLib's smlib_screw_sweep_radial (replay e7acea1):
- smlib: the FFI binding and Brep::screw_sweep_radial, the profile moved off the axis by a
piecewise linear law of the turn; crate test: a tooth moved out 1 mm over three turns has
A 2π (c turns + ∫ offset dt).
- kernel: sweep_helix_radial, sharing sweep_helix's checks (helix_profile).
- doc: `ease_in`, `ease_out` (a length, or ISO 3508's standard 2.5 P or short 1.25 P) fade the
groove over that length, its section moving out of the material as it turns (outward for a
shaft, inward for a nut). ease_in is at the end the thread starts from. The runout lies past
the full-form length: beyond a square stop, before a shoulder up to its clearance; at a free
end inside the face. Runouts longer than the thread are refused. No end gets one by default,
so saved threads keep their geometry.
The cut is the integral over the turn of the clipped section's 2π∫ r dA: engine test (2.5 P
and 1.25 P between two collars) within the sweep's wall tolerance times the runouts' wall area
(0.029 against a 0.036 mm³ bound), ladder 06/009 (004's shaft, a 2 P runout before the
shoulder) graded in closed form (measured 1.7e-6 off).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The record's torus label is a ring torus (major > minor; the validator
refuses any other). SMLib keeps horn and spindle tori: a half disc revolved
about a line through its rim's end is a horn torus, its major radius a
rounding below its minor, and the export wrote it as a torus label the
record then refused (rig sweeps/4007, "ring torus radii"). Such a face is
now its NURBS form, unlabelled, which is its geometry in any case.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rig case shell/4711 (a 60 x 40 x 10 block, an r3 through hole at (22.5, 7), a 10 x 10 notch on
the front edge, shelled 2 open at the bottom) failed with "SMLib shell: operation: SMLib failed
(status 1027)". The hole is 4 = 2 x 2 from the front face: the hole wall's offset (r5) is tangent
to the front's at (22.5, 2), the walls meet along a line and the cavity would pinch to zero
thickness there, which is no solid. Refusing it is right; the refusal did not say why.
SMLib now refuses an offset whose walls would meet with its own status, SMLIB_ERR_WALLS_TOUCH
(-1110). The smlib crate reads it as Error::WallsTouch; the kernel's offset backend turns it into
a sentence with the wall, as blends turn NoRoom into one: "shell: the 2 mm walls would meet along
a line (between a hole and the side, for example), which leaves no solid there; use a thinner or
thicker wall, or move the feature". Thicker builds too (SMLib shells 4711 at 2.5, the walls
crossing and merging between the hole and the front), so the sentence offers both.
4711 expects that refusal and its message ("outcome": "refused", "refusal"), its "what" and
"method" saying why: the wall is 4 = 2 x 2, the walls meet along a line. Tests: the smlib crate
shells 4711 built from primitives (2 refused as WallsTouch, 1.5 and 2.5 valid), the kernel a
plate whose hole is 3 from its side at 1.5 (refused, with "the 1.5 mm walls would meet along a
line").
Results (run-sc.sh against SMLib a759622's code, which differs from the tree run only in
comments and docs; baseline 858f381fc-5448b9a): rig 410/447 (409
before; 4711 fail -> pass as the refusal, nothing else changed), ladder 109/116 (unchanged),
kernel lib 535 passed / 202 failed (one new test; the same failing set), smlib crate 53 / 2
(one new test; the same failing set).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0113gDVmStT5tCGKW9Fxgc5K
SMLib now builds a round or chamfer whose rail runs off its face across a cliff (an opening's
rim, the body's outline): the blend is made as if its faces continued and what it removes is
subtracted, so it never bridges an opening (owner decision for rig 5158/5181; fork commit
"SMLib, capi: a convex blend overflowing a cliff is subtracted from the body"). The tests that
expected a refusal for such blends now expect the body, each answer from the geometry:
- variable_radius_on_a_box_edge: 2 -> 50 on the 10x20x30 box's top edge builds at
3546.18767939 (circular sections in y = const, the r x r square less the quarter disc,
clipped to the box; rel 1e-4).
- variable_radius_from_a_spline: the "big" law builds at 6000 - 726.5334566720 (de Boor law,
split at the knot and where r crosses 10).
- a_chamfer_meets_sloped_end_planes: chamfer 25 removes 11500 - 4625 * slope
(integral of 40 - 2 * slope * y over z >= y - 5).
- g2_fillet_refuses_invalid_geometry: G2 at 25 builds at 6138.1606889 (the quintic section
with control points at thirds, clipped to 20x20, along 20).
- fillet_max_each_reduces_only_where_the_radius_does_not_fit: both edges take 4, 24438.7317761.
- hostile_inputs_are_errors: chamfer 30 on the cube builds at 1000 (y + z <= 10 along 20);
R50 still fails.
- kernel-cases fillets/1080: the 9 mm chamfer into the openings builds at 3350
(method in expected.json).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0113gDVmStT5tCGKW9Fxgc5K
A loft cut from a block's whole outline (flush with its sides) down to a pad cuts the slab
above it loose: the slab and the rest touch along the outline's four edges, round the pocket
the loft leaves. SMLib keeps the pocket as a void region of its own (its check finds the body
valid): its one runtime shell is the slab's underside and the loft's faces, so the slab's
material shell faces two empty runtime shells, the infinite region's and the pocket's, and so
does the rest's. The export made one record shell per pair of empty and material runtime
shells, so each solid's closed boundary came out as two open shells ("an open, wire or vertex
shell lies in one region").
A record shell is now one material runtime shell, whatever empty shells its faces face. Empty
regions one solid's boundary faces together are one record region: the infinite region where
it is among them, else the void whose outer shell bounds it alone. The pocket, which no record
shell bounds once the solids' shared edges are split, is part of the empty space round them.
Fixes rig sweeps/96-loft-cut-box-sections-pad-first and -top-first.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 796920968265c57c59f11dd908ec022d53f5c647)
A degree-1 patch of four control points on a parallelogram (a plane as an IGES
or STEP B-spline writes it) is that plane at every parameter, so its pcurves
take the plane's closed forms instead of going to SMLib (which drew the rim
circle of 3806's base as a 385-point spline).
SMLib may run a one-face sheet's loop against ours. A use's pcurve is the same
either way, so the loop's way round is read from an edge the face uses once and
every use is matched with it (3806 failed with 'a use SMLib did not keep').
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
A use with no closed-form pcurve (an approximated intersection curve on a cone,
a spline edge on a spline surface) no longer refuses its solid. Its face goes to
SMLib alone, an open sheet with the trims it has and without the others, and
SMLib makes those as it makes every trim it needs (GetOrCreateUVTrimCurve on
export); they come back on the record's parameters and the face is closed and
checked as before. The STEP reader takes the trim maker from the kernel
(read_solids_with, read_solid_with); read_solids stays exact-only.
Kernel lib tests: 490 pass, 239 fail (were 468 / 261; pushed head 475 / 254),
none newly failing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
SMLib holds every ellipse as an exact rational NURBS; the fork now sends ellipse edges with that
form and takes them back with it. The export reads an ellipse with its form as it reads a circle
with one (its frame turned so its angle grows along the form, its trims carried over as they are);
the import writes an ellipse on its form as its conic entry plus the NURBS.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
No floor of ours on tolerances (1e-6 of the body's size, 30 times SMLib's 1e-5 default): the
record's tolerances go back into SMLib, which approximates to them, so the floor coarsened every
later operation. No recognition of NURBS edges as lines or circles: an edge is a circle where
SMLib holds an SmCircle (with its NURBS form), and a NURBS edge keeps SMLib's trims on its own
parameter. crashes/2992 and sweeps/1853 pass.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Edge::curve_interval (and brep::curve_interval for assemble's edges) gives the interval on the
edge's curve itself: a form circle's angles of its ends, its frame turned by the SMLib conversion
so the angle grows along the NURBS. lip and the ruled surfaces read arcs by it; the hull, the
blend tangents, the patch pcurves, point paths, IGES output and the prism runs evaluate on
Edge::parameters. assemble carries an edge's form through.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The SMLib conversion reads and writes EDGE_NURBS_FORM: a circle edge's record keeps the circle
as what it is and the NURBS SMLib holds it as as its parameter, so the trims on it carry over
exactly (TrimMap identity).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>