fbe778a1e89afd49e1cd5145dc4eacdbbfd1f0ae
506
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
87c9a37663 | Cut and Intersect say which component holds the body they missed (#4639) (#4641) | ||
|
|
e9b9c8f697 |
Joints: apply a joint solve through indexes instead of searches (#6392) (#6393)
* claim: #6392 * perf: apply a joint solve with indexed joints and occurrences Every change to a design re-solves its joints and applies the solution. Applying it searched the joints for each value and, for each occurrence the solve places, searched the occurrences for it and walked its parents' first occurrences by searching again. Joints and occurrences are now indexed once, keeping the first of each id as the searches found it, and the parents' transform is read through the index as the loop leaves it (component_transform shares the walk, transform_through). Synthetic design, headless (2000 components at the root with one component inside each, 4000 joints, a solution placing every occurrence): apply 14.1 -> 2.2 ms (median of 12). The new test applies a solution that moves a component and the components inside it, and checks each lands where the solution put it, read through its parent as the loop has just moved it. |
||
|
|
aa8e8cf69c |
Update Links: show which linked design it reads, off the window thread (#5329) (#5512)
* claim: #5329 * Update Links: show which linked design it reads, off the window thread (#5329) Update Links read and rebuilt every linked design on the window thread, so the window froze, with nothing on screen, until it finished. From the toolbar it now runs as a file operation: off the window thread, with the overlay naming the linked design being read (cover (2 of 3)), its rebuild step and progress, and Cancel. The assembly stays as it was until the update is in, and it lands as one undo step. The command reports each design through doc::progress::item. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
0f90fb7e8d |
Edge flange: material outside and tangent bend positions (#5941) (#6060)
* claim: #5938 * Edge flange: height measured from the outer sharp, the inner sharp or the bend tangent (#5938) An edge flange feature takes height_from (outer, inner or tangent) in sheet.flange and Height From in the Flange dialog, saved only when it is not the outer sharp. A height shorter than the bend takes is refused with the smallest height that fits. * Edge flange: material outside and tangent bend positions (#5941) An edge flange's position can now be material_outside (the inner virtual sharp on the edge) or tangent (the bend's outer face tangent to the edge's face), in sheet.flange and the Flange dialog. The bend starting at the edge was already the outside position, which now also answers to bend_outside. |
||
|
|
52e5bc114e |
Display cosmetic internal and external threads (#2367) (#2868)
* claim: #2367 * feat: distinguish cosmetic threads in shaded views * test: keep cosmetic thread coverage compatible with current sections and assemblies |
||
|
|
2cf05388f1 |
Release 0.22.1: version bump, design format 36 (#6628)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
699f526429 |
Show imported mesh edges in shaded and wireframe views (#5662) (#5740)
* claim: #5662 * Show imported mesh outlines in viewport (#5662) * test: update mesh regression origin visibility setup |
||
|
|
e5613ebfdf |
Placing and meshing: no threads started for bodies that are done already (#6406)
Every command in a design with placed components places their bodies again on up to 16 threads, though nearly all of them are taken as they were placed before (the same body by the same matrix). Those are now taken on the calling thread and only the rest are placed on threads. Warming the meshes (and display plans) of a state likewise starts threads only for the bodies that have none yet. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
5a5a98ee80 |
Sheet metal: Path Flange, a chain of bends on an existing sheet edge (#4094) (#4096)
* claim: #4094 * Sheet metal: Path Flange, a chain of bends on an existing sheet edge (#4094) Path Flange (`sheet.path_flange`): sketch an open chain of lines across a sheet edge, pick the edge and one line; each line becomes a flange as long as the line and each corner a bend, one feature and one body. The edge flange takes further bends (`then`), each on the far edge of the one before, and the Flange dialog shows them as rows with a bin each. |
||
|
|
bbc3aa4301 |
Offset Plane: through a point (#3765)
* claim: Offset Plane through a point * Offset Plane: through a point instead of at a distance |
||
|
|
919f54a23e |
Sheet metal: bend angles as the included (press-brake) angle, set per rule (#4968) (#6040)
* claim: #4968 * Sheet metal rules: bend angles as the included angle (#4968) A sheet metal rule's angle_display (bend, the default, or included) sets how the DXF bend notes read each bend: a 58° bend is B1 UP 122° R1 under an included rule. The bend table always gives included_angle_deg beside angle_deg (CSV and JSON). Set in sheet.manage_rules and the Sheet Metal Rules dialog, listed by sheet.rules; the flange angle stays the bend angle. * Bend table: the included angle as the CSV's last column, so the columns before it keep their places (#4968) A test also covers a body whose base flange names its rule, which keeps that rule's notes whichever rule is active, and a bend down. * Sheet Metal Rules: Angle Display reads Bend or Included, so the choice fits its box (#4968) The rule editor's row contract lists the new row and the key the dialog sends. --------- Co-authored-by: begsaquib <saquibbeg4444@gmail.com> |
||
|
|
157c0d68d0 |
Sketch Dimension: point/circle to circle or arc edge (#4064) (#4065)
* Sketch Dimension: point or circle to the edge of a circle or arc (#4064) Adds PointCircleDistance and CircleCircleDistance (edge-based, like #1863): solver, constructive seed, drawing, command wiring, tests, UI scenarios and docs. Saved designs gain two constraint kinds, in one pending format file. Fixes #4064. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * Sketch Dimension scenario: pick the circle at its top edge (#4064) The bottom edge sits under the Dimension tool's status hint in the scenario window, so the second click never reached the tool. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
face5e2d31 |
Hole: independent tapping depth and recessed drill points (#4486)
* feat(hole): checkpoint independent tapped thread depth * test(hole): cover independent tapped thread depth boundaries * fix(doc): bind tapped depth to the useful cylindrical wall * feat(hole): dimension independent thread depth in the section editor * fix(hole): preserve custom tapping controls after main integration * feat: add recessed-hole drill points and order depth dimensions * fix(hole): match the current preferences and UI kit * fix(hole): verify reference placement with independent tapping depth |
||
|
|
74004841b4 |
Sketch text: a text on a path follows the path in the same evaluation (#6215)
* Test: a text on a path follows the path when a parameter moves it A construction line placed by a dimension that reads a parameter, and a text laid along it: after the parameter changes the line has moved and the text has not. It follows one evaluation late. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PsiqyXWBFGTCX9J51bhysc * Sketch text: a text on a path follows the path in the same evaluation Problem: texts are laid out with the sketch's links, before the sketch is solved. A solve that moves the curve a text runs along (a path placed by a parameter) left the text where the path had been before the change, so it followed one evaluation late. Solution: after a solve that keeps the sketch's orientation, every text that runs along a curve of its sketch is laid out again along that curve as the solve left it; a text that no longer lays out adds its warning. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PsiqyXWBFGTCX9J51bhysc --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
be08517de2 |
Construction: a plane on a sheet's flat face follows the face (#6217)
* Test: an offset plane on a sheet flange's face follows the flange An offset plane on the inner face of an edge flange, picked by body and index as model.faces lists it. When the base gets wider the flange moves along x and the plane stays where the face was picked; a sketch on the same face follows it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PsiqyXWBFGTCX9J51bhysc * Construction: a plane on a sheet's flat face follows the face Problem: a construction plane on a flat face of a sheet body resolved the stored plane, which is only where the face was when it was picked. When the sheet changed the plane stayed behind, while a sketch on the same face follows it by its sheet face name. Solution: a construction plane on a sheet's flat face resolves that face's plane as it is now, as a sketch on the face does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PsiqyXWBFGTCX9J51bhysc --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
24ed21998b |
Configurations: a design keeps up to 2048 rules (#6221)
* Test: a design keeps several hundred configuration rules An assembly that switches a few hundred parts on and off, by two rules each, needs hundreds of rules; the saved-rule budget refused more than 128. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PsiqyXWBFGTCX9J51bhysc * Configurations: a design keeps up to 2048 rules Problem: a configuration table kept at most 128 rules. A rule drives one feature's suppression, so an assembly that switches a few hundred parts on and off (by two rules each) could not keep its rules. Copying rules for an independent component copy looked up each new id by scanning all rules, which a larger table makes slow. Solution: MAX_RULES is 2048; a copy looks its new ids up in a set of the ids taken. The docs say the new limit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PsiqyXWBFGTCX9J51bhysc --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
3592031d5e |
fix: joints on an imported part's hole or face stay on that part (#6368)
The parts of one STEP assembly import share their face names, and each part's body stays where the file has it, placed in its component by an offset. A joint origin on a named face (a hole's centre, a face's centre, an x reference by face, the end a round origin takes) looked the name up on every body of the design and compared the pick, in the joint's component coordinates, with each body as it lies. Another part's face of that name could lie nearer, and the joint resolved on that part's face: a pin jointed into one plate's hole landed where the other plate's hole is relative to its plate. named_face now looks only at the bodies of the joint's component, each in its own coordinates, a face the name finds exactly before a piece of it or a face it was merged into, then the nearest. The design-wide lookup stays for a face whose body has gone to another component. named_round, x_axis, pin_end and end_faces take the component, as face_name_at and round_end_at already do. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
b8d9db7440 |
fix: a face-centre joint origin stays put when a hole in its face moves or goes (#6370)
A joint origin at a face's centre (`joint.origin {face}`, `Snap::FaceCenter`) was the face's
area centroid, holes included. A hole cut into that face, moved or suppressed therefore moved
every part held at the face's centre, though the face's outline stayed where it was: on a
200 x 100 plate with a 20 mm hole, 0.31 mm for each 20 mm the hole moves and 0.62 mm when the
hole, 40 mm off the middle, is suppressed.
On a planar face with holes the origin is now the middle of the area the face's outer boundary
encloses (`outline_centre`: the face's triangle sides that no other triangle of the face runs
back along, corners matched by place, chained into loops in the face's plane; the centroid of
the loop enclosing the most area). A named face (`NamedFace::plane`) and the planar face
nearest a point (`nearest_plane`) both use it. A face without holes, or one whose mesh gives no
clean outline, keeps its centroid as before.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
||
|
|
a5b6408587 |
fix: an edge joint origin on a body placed by an offset lands on that edge (#6374)
An edge joint origin looked its edge and face up in the body's own coordinates with the pick in the component's,
and returned the frame in body coordinates. On a body placed by an offset (an imported part's bodies are) a pick on
the edge where it is shown found no edge ("joint origin: no edge there"), or the origin sat away from its edge by
the offset. Edge origins now take the picks into the body's coordinates through the inverse of its offset and place
the frame back by it, as named faces and round origins already do. A body without an offset is unchanged.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
||
|
|
c242c484a8 |
Construction: the root's constructions are found once the design has a component (#6219)
* Test: a plane through a construction axis follows it in a design with a component Two offset planes, the axis where they meet and a plane through that axis. Once the design has a component, a parameter change fails the last plane with "unknown construction `Ax`". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PsiqyXWBFGTCX9J51bhysc * Construction: the root's constructions are found once the design has a component Problem: once a design has a component, the root's construction features are built in the model placed in the world. That state carried each component's bodies, sketches and threads, but not its construction planes, axes and points, so a construction built on another one failed on every evaluation with "unknown construction". Solution: the world state carries each component's constructions where the component is placed (moved by its occurrence's placement, as the bodies are). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PsiqyXWBFGTCX9J51bhysc --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
6f340ade69 |
Sheet metal: a refolded sheet's faces keep the names of the faces they were (#6268)
* Sheet metal: test that an unfolded sheet's flat face is named after its base at every size An unfold keeps the base in place and lays the flanges out beside it; the flat face spanning them and the bend strips is the base's face. It was named after the unfold whenever few of its sample points fell on the base (the bend strips are many small triangles, the base two big ones), and that changed with the sizes: a size change renamed every top and bottom face the refold made of it, and joints and sketches on them lost their faces (40 of 85 joint ends of a real part after one change). The test unfolds and refolds a base with three flanges at two flange heights and wants the flat face and every refolded panel face named after the base. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PsiqyXWBFGTCX9J51bhysc * Sheet metal: the panel an unfold or refold keeps in place names the face it is part of A face a sheet feature made is named by where its sample points lie on the input's faces: in place, else taken back through the folds. Only nine points per face are sampled, triangle centroids picked by index. An unfolded sheet's flat face spans the base, the flanges laid out beside it and the bend strips between them; its bend strips are many small triangles, so most samples fell on them. Those lie on no panel, and one of them made the fold fallback give up for the whole face. The face was named after the unfold, and the refold passed that name to every top and bottom face; which way it went changed with the part's sizes. For a sheet feature that moved panels, a face the plain vote leaves unnamed is now looked at closer (up to 256 points): if a part of it lies in place on the body's own face before (the panel the feature kept), that face names it. Else the fold fallback votes over the points that can be taken back, when at least half can, instead of none when one cannot. Other features, and faces the plain vote names, are named as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PsiqyXWBFGTCX9J51bhysc --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
e260437846 |
Names: a pattern copy's piece names match as the original's do (#6270)
* Test: a pattern copy's piece names match as the original's do A copy's faces carry the instance after the name, after any piece qualifier (`top#[left,slot:a]@F9.1`). A stored piece name of a copy whose bounding faces have changed since finds no face of the copy at all (None at the first assertion), where the original's identical name matches by its stem. On a real part: the joint ends on a patterned copy fall back to their picks after a size change, the original's resolve by name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PsiqyXWBFGTCX9J51bhysc * Names: a pattern copy's piece names match as the original's do Problem: a pattern's copy names its faces after the original's with the instance appended after any piece qualifier (`top#[left,slot:a]@F9.1`). The piece parser expects a qualified name to end with its qualifier, so a copy's name was its own stem: when the faces around a piece changed, a stored name of a copy matched no face of the copy at all, where the original's identical name still matched by its stem. Joint ends on a patterned part fell back to their picks after a size change and flipped to the other end of their holes. Solution: `history_names::matches` takes the pattern instances off the end of both names first and compares the rest as before, within the same copy only (equal instances; an original's name never matches a copy's face, nor one copy's another's). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PsiqyXWBFGTCX9J51bhysc --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
f54ad0f12f |
Configurations: a parameter edit runs the suppression rules whose condition reads what changed (#6303)
* Test: a switch parameter alone switches the features its rules suppress Configuration rules that switch features' suppression from a parameter (drive_suppression when `on` = 0) ran only on config.activate: a plain parameters.change of the switch left the features as they were, so a script had to activate a row for every change. Red until the fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PsiqyXWBFGTCX9J51bhysc * Configurations: a parameter edit runs the suppression rules whose condition reads what changed Problem: configuration rules ran only when a row was activated or a configuration edited. A design that switches features on and off by a parameter (a rule that suppresses a feature when the parameter is 0) did not follow a parameters.change of that parameter. Solution: parameters.change (one parameter or several) runs, before the rebuild, the enabled rules that switch a feature's suppression and whose condition reads a parameter whose value changed (or a feature switched earlier in the same pass), in their order as activation applies them, and lists them as `switched`. Driven parameters and restrictions still wait for a configuration edit or activation; a rule whose condition reads nothing that changed leaves a hand-set suppression alone; a rule that cannot be evaluated is skipped and never blocks the edit. One undo step with the edit. docs/configurations.md says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PsiqyXWBFGTCX9J51bhysc --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
3e1f1a89f8 |
Assemblies: owners of bodies looked up once per placement pass, body frames only when picked (#6356)
Placing a design's bodies asked each body's owning component once per placement, and each answer searched the features for the one that made the body: placements x bodies x features on every command, twice (the world state and the frames that map a command's picks into components). Document::model_body_components answers for all bodies at once, and world_state_reusing and body_frames_with_source use it. The engine's frames now work out the per-body table only when a command picks a body or names one; most commands pick none. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
82253c6f35 |
Expressions: remember what an expression names and a constant parameter's value (#6360)
Every evaluation fingerprints every feature by the parameters its expressions name, and works out every parameter, and most of them (named feature inputs) are literal values such as "10 mm". In a design built command by command both were lexed and parsed again on every command. references() now keeps its answers per thread (bounded), eval_params keeps its last few results for identical definitions (compared in full), and a parameter that names no other is evaluated once per expression, unit and design length unit. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
75fb613e25 |
Names: a new feature's and input's number found without searching the design per number (#6377)
A new feature is named after the first free number of its stem (Cylinder1, Cylinder2 …), and every number tried searched all features' names: the thousandth cylinder of a design tried a thousand names against a thousand features. A new input's dN name likewise wrote out every d1, d2 … it tried. Both now gather the numbers taken after their stem once (params::numbers_after, which counts only names written as the number is) and take the first number not among them. The names are the same. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
ce614044a7 |
Evaluation: a feature's fingerprint text is written only when the feature changed (#6397)
Every evaluation fingerprints every feature by its JSON, so a design built command by command wrote all of its features out as JSON on every command. The text is now kept (per thread, by feature id) with the feature it was written from, and written again only when the feature differs; the text hashed is the same, so the fingerprints are too. Imports, whose text depends on their STEP digest, are written each time as before. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
91549d29fb |
Inspect: bodies measured on all cores, and once while they stay the same (#6412)
document.inspect with measure (what inspect_design and the solidcraft://design resource ask for) measured every body one after the other, and again on every call: on a 1,280-body design each call took 25 to 60 s. It now measures them on all cores, as inspect.measure does, and each body keeps its measurement in a cell shared by its clones (with the body it was measured on, as the outline box is kept), so a design inspected again measures only the bodies that changed. Placements taken as before keep their placed body's cell too. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
b6a5a9166a |
perf: a pass over the joints evaluates the design's parameters once (#6418)
Every joint whose offset, angle or values are expressions is worked out again on each solve, twice per solve (re-expressing the joints, then the check that leaves out one whose expression no longer works out), and each expression that names a parameter evaluated every parameter of the design anew (`Document::eval`). The cost grows with the joints with expressions times the design's parameters: on 40 parts jointed to a plate, each joint lifted by an expression and each part carrying 13 parameters (522 in all), a joint solve took 0.55 s on main and takes 0.41 s now, a change of the lifts' parameter 1.06 s and 0.81 s (CLI, medians of 5 runs). `joints::Params` keeps the design's parameter values once the first expression names one, and `joints::expressed` takes it, so one pass evaluates the parameters once. Values and error messages are those of `Document::eval`. Test: `kept_parameters_evaluate_as_the_design_does` compares values and errors with `Document::eval`. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
0063954286 |
Sketch: a sketch whose links moved far is walked there and keeps the stored sides and turns (#6420)
* Test: a label on a path follows its source far
A rectangle of construction lines placed on three points projected from another sketch, with a
centred text on its far side: moved 270 away by the parameters that place the source, its solve
from the stored sketch failed ("the sketch constraints conflict").
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PsiqyXWBFGTCX9J51bhysc
* Sketch: a sketch whose links moved far is walked there and keeps the stored sides and turns
Problem: a change upstream moves what a sketch projects (or the points its parameters place)
while its own values stay. The solve from the stored state then either failed ("the sketch
constraints conflict") or landed on the mirror image of a side or turn and reported it solved,
because a solve after a link move checks no orientation when no value changed: a line tangent to
a moving circle hopped a diameter to the circle's other side. And a sketch moved so was stored
only when its own values changed, so every later evaluation solved it from its first stored state
again.
Solution:
- flips_from_stored: the orientations of the stored sketch (unsigned offsets, distance
triangles, and a line's side of a circle it is tangent to) that a solved sketch turned over,
each read where the stored sketch has its points.
- solve_after_link_move: the new values solved where the links were stored, then the moved
points walked to where they are now (predictor-corrector: each step starts from the last two
solutions carried along their secant; steps halve on a failure or a flip and grow while they
solve).
- Document::solve_sketch: when a linked or fixed point moved and the jump fails or flips, the
walk; a flip the walk cannot avoid either is reported as one.
- Model::edited_sketches: a sketch whose linked points a value edit moved is stored as solved, so
the next evaluation starts where this one ended.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PsiqyXWBFGTCX9J51bhysc
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
||
|
|
19e2800472 |
Sketch on the sides of a thin extrude (#2722) (#5781)
* claim: #2722 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * Sketch on the sides of a thin extrude (#2722) A thin wall's sides lie off the sketch curves (half the thickness either side, say), so no curve was under them: its side faces had no role, no exact history name, and Create Sketch refused them as "can't keep an attachment". The roles of a thin wall's sides are now `wall:<curve>:left|right` (the side of the curve it runs beside, in the direction the curve is drawn), and its open ends `wall:<curve>:start|end`. They follow the thickness and side settings and survive a save. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
cdde7d62b2 |
Persistent names read by one parser; four misreadings fixed (#5814) (#5966)
* doc: persistent names read as their structure; joint.inspect splits an edge with a blend face first
`persistent_name::{FaceName, EdgeName}` parse a face or edge name once (blends, inner walls,
copies, pieces, numbered pieces, `~k`) and write it back as the same text, bounded against
hostile input. A suffix after a blend's edge naming a later feature belongs to the blend face.
joint.inspect split an edge at its first `|`, so an edge whose first face is a blend
(`F4:blend:F3:+x|F3:+z#[…]|F5:-y`) came back as a cut-off blend name and a string that is no
face. It now uses `EdgeName::parse`.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* doc: persistent names as typed values: features, roles, suffixes, a lexer and errors that say where
`FaceName` is a base (made by a feature in a role, a blend and the edge it rounds, an inner
wall, a body's face by index, other text) and its suffixes (copy, piece, numbered piece).
Roles are typed where the vocabulary is known (top, side:<curve>, +x, face:<k>, …) and kept as
written otherwise. The text form is lexed into tokens and read by the grammar in the module's
doc; a name that doesn't read says where and what was expected.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* names: read what made a face, its kind and its feature ids through persistent_name
The places that took a name apart by hand to find the feature that made a face, whether it is
a blend, a copy, a numbered piece or a wall, or to remap feature ids on copy, now ask the typed
name (`made_by`, `split_feature`, `is_blend`, `is_copy`, `is_numbered_piece`, `is_wall`,
`features`, `map`). A name that doesn't read falls back to the old text check.
- An offset of a face that only names a blend inside it (`F2:top#[F5:blend:…]`) is no longer
taken for a fillet's.
- Copying a component remaps feature ids inside a piece's `#[…]` too.
- A shell's inner wall split by a later cut keeps the qualifier on the wall.
- joint.inspect finds the sketch curve of a copied side (`side:l1@F7.2`).
Finding a face by name (strip_piece, parent_piece) is unchanged: it reads a trailing
qualifier as the whole name's and moves once the text form says where it belongs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* engine: regression tests for press-pull on a wall that only names a fillet and joint.inspect on a copied side
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* names: an edge holds one face or more; made_by reads only the leading token
An open boundary's edge has one face and an edge several faces meet at has more, so an edge name
is a list of faces (a blend's own edge still takes two at most, as before). `made_by` reads just
the leading `F<n>:`, which every name a feature made starts with, so asking it of every face
each frame stays cheap. Names are read up to 1 MiB: a face engraved with text has piece names
past 4 KiB.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* persistent_name: split into lexer, parser, write, text and tests
No code changed; callers' paths stay the same (`pub use text::*`).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
||
|
|
b4acd83c78 |
A count from a length says how to get a count (#5901) (#6011)
A pattern count such as (L-2*Post)/210 is a length when the 210 is unit-less, and was refused with only "expected a unit-less number, got a length". The message now says to divide by a length, e.g. floor(L / (210 mm)). Co-authored-by: Nathalie Schönwetter <nathalie@cfw-ag.ch> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
b88673f366 |
Model cache: each sheet body is written once, not with every state (#6152)
* Test: a saved model keeps each sheet body once A sheet-metal design wrote its sheet bodies again with every later feature's state in the saved model: each feature that leaves the sheet alone (a box beside it) adds more than the whole sheet to the records. A design of many features after its sheet metal passed the cache's 32 MiB manifest limit that way and kept only some of its states (#3220). The test also opens the saved file and wants the sheets taken from it as evaluated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PsiqyXWBFGTCX9J51bhysc * Model cache: each sheet body is written once, not with every state Problem: a saved model writes every feature's state, and each state wrote its sheet bodies in full; most features leave the sheets as they were, so a sheet-metal design of many features repeated them over and over (a 280-feature part: 30.5 MB of manifest, 29.6 MB of it 69 distinct sheet records written 243 times). Past the manifest's 32 MiB limit the save thinned the cache (#3220) and opening evaluated the left-out features again, although the distinct data was small. Solution: the records keep a list of sheet bodies, each written once; a state names its sheets by their place in it, as it already does for bodies and sketches. A thinned model keeps the whole list and counts it once against its budget; the reader counts sheets with the bodies and sketches a state holds; the cache format is now /4 (an older cache is a miss). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PsiqyXWBFGTCX9J51bhysc --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
bba1953623 |
Fillet/chamfer: find each edge on its own body (#6378)
* Fillet/chamfer: find each edge on its own body A blend picked over edges of several bodies was evaluated on one body, the one nearest the first pick, and every edge was named on that body when the feature was made. Picks on the other bodies were named after that body's nearest edge and rounded it instead (or moved to it by position once an upstream edit moved them). With two stacked boxes, a height change put the upper box's picks on the lower box's rounded corners: the upper box's fillet resolved there and its own edges lost their rounds. Now each edge is named on the body it was picked on, and evaluation finds each edge's body by its stored name (a gone name stays on the feature's other bodies), groups the edges by body and blends each body. A name an older build recorded on the wrong body (the pick lies outside the box its reference recorded) is not used; the pick finds the edge. A pick an upstream edit left at an end of its named edge goes to the edge's middle, so the kernel cannot take the neighbouring edge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fillet/chamfer: skip the per-body lookup when there is one body; name each body's picks in one pass Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
dbdeeec2e9 |
Undo restores what a hide put away (#2219) (#4780)
* Undo: what is hidden lives in the snapshot, so hiding is a step (#2219) `Session::execute` records a step only when the document `Arc` changes, and what is hidden lives in `Session::visibility` — saved with the design, but outside the document. `browser.visibility` was also declared `.noundo()`, and `Snapshot` had no field for it, so even a recorded step could not put a hidden body back: undo went to the command before the hide and left it hidden (#2219). `Snapshot` and `Checkpoint` now carry the `Visibility`, `go_to` restores it, and `Session::execute` treats a visibility change as a change of its own. That change is display-only, so it refreshes the view with a revision bump (`refresh_display`) instead of evaluating a model a hide does not touch. The command also takes `folder: "all"` (every body, sketch, construction item, origin item and joint, plus the browser folders and occurrence hides) so Show All can be one step, and asking for the state an item already has no longer reorders the hidden lists: a redundant hide is not a step and leaves no unsaved changes. * Show/Hide: the menus run browser.visibility, so the history has it (#2219) The hide and show actions wrote `session.visibility` directly instead of running the command: the body and face menus (`ui.hide` / `ui.show`), the `V` key (`context_menu::toggle_visibility`), the browser rows' eyes, the Origin rows and `ui.originAll` / `ui.originPart`. The engine could record a step and there was nothing to record — which is why the release still answered "nothing to undo" after hiding from the Browser. They all run `browser.visibility` now (the repo rule that the UI acts through commands), and `ui.showAll` is that one `folder: "all"` call, so Show All is one undo step rather than three. `docs/occurrence-workflows.md` says what visibility does in the history. |
||
|
|
f7b08ab8c4 |
Dimension values: #name = value defines a parameter too (#2371) (#4212)
* claim: #2371 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SBN24y2TcqRcm2zn8Gkj27 * Dimension values: `#name = value` defines a parameter too (#2371) `#width = 40` in a dimension's value now works like `width = 40` (#2916): it adds the user parameter `width` and dimensions with it. On `main` the `#` made it an ordinary expression that failed to parse. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SBN24y2TcqRcm2zn8Gkj27 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
ae0b1edeac |
Coil: a section from a sketch profile (#4236) (#4239)
* claim: #4236 Co-Authored-By: Claude Code <noreply@anthropic.com> * Coil: store an optional sketch and profile selection Co-Authored-By: Claude Code <noreply@anthropic.com> * Coil: sweep a sketch profile along the helix Co-Authored-By: Claude Code <noreply@anthropic.com> * Coil: accept a sketch and profile selection Co-Authored-By: Claude Code <noreply@anthropic.com> * Coil dialog: pick a sketch profile for the section Co-Authored-By: Claude Code <noreply@anthropic.com> * Coil: cargo fmt Co-Authored-By: Claude Code <noreply@anthropic.com> * Coil: refuse a loaded sketch coil that also sets the primitive section A saved design could add section, section_position or start_angle to a coil that already has a sketch; eval ignored them instead of refusing the contradiction as the command does. Co-Authored-By: Claude Code <noreply@anthropic.com> * Coil: assert the kernel refusal and exercise hostile profile selections Co-Authored-By: Claude Code <noreply@anthropic.com> * Coil dialog: keep the sketch-profile check after rebase Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Format Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Code <noreply@anthropic.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com> |
||
|
|
60105172b2 |
Sketch on a turned occurrence: reuse moved bodies across edits (#4853) (#4863)
* claim: #4853 * Sketch on a turned occurrence: reuse moved bodies across edits (#4853) A sketch with a face anchor is evaluated in its component's frame. state_in_frame_at moved every body placed differently from that frame with a fresh transform on every evaluation, and the face-anchor frame moved the anchored body again, so each sketch edit on a turned or moved part transformed and re-meshed it. The model now keeps the bodies it moved into a feature's frame, keyed on the source body and the exact matrix (and checked against the source's mesh, geometry, colour, paint and split lines, as world placement does). An unchanged body under an unchanged placement is moved and meshed once. Each evaluation starts a new generation and drops entries that neither it nor the one before used, so the cache holds only placements in use. Model states hold a weak reference, so the cache never keeps earlier states alive. Fixes #4853 |
||
|
|
e2b8bf5a05 |
fix: copy a pattern's features in timeline order, not in the order they were picked (#4873)
A circular or rectangular pattern of a hole and the chamfers on its edges failed with "no edge near ..." when a chamfer was picked before the hole: the chamfer was copied first, onto a body that had no hole there yet. Co-authored-by: Nathalie Schönwetter <nathalie@cfw-ag.ch> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
2a0096fe4a |
Release 0.22.0 (#6344)
* Release 0.22.0: version bump, design format 35 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Release 0.22.0: tests no longer expect the folded render and material changes to be pending Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
cc9d76cd86 |
Tapered cut: run on less, then start on the face, when the run on closes a small corner (#4825) (#4858)
A cut starting on a face of its target runs its tool on behind the start plane with the tool's slope. A taper that widens the pocket narrows the tool there, and a corner arc smaller than the run on times tan(taper) closed: "the taper closes the profile", though the pocket itself only grows. The run on is halved, quartered, then dropped (the tool starts on the face with its straight foot) until the tool builds. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
ad8b2f91bb |
File: a saved model whose booleans retried is taken on opening (#5286) (#5334)
A design file keeps its evaluated model so that it opens without
evaluating the timeline. A feature whose boolean needed a retry records
it, and the kernel's BooleanDiagnostics leaves `rejected` out when it is
empty but has no default for it when read, so reading those records
failed ("saved model: diagnostics"), the saved model was refused, and
the design was evaluated on every open (17.6 s for the reporter's
17-feature design, 1.2 ms with this).
The reading side now takes an absent list as an empty one, without a
change to the kernel crate.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
||
|
|
46f24f2394 |
Save the browser's view with the design, and an option to hide the origin by default (#1849)
The Origin folder's eye, a finished sketch's Show Profile and Show Dimensions, and body locks move from UiState into the design's saved visibility (origin_hidden, hidden_profiles, shown_dimensions, locked_bodies), so each tab keeps its own and they survive closing the design. The Sketches folder uses the saved browser folder (c0/sketches in hidden_folders); ui.set/ui.inspect keep showOrigin, showSketches, hiddenProfiles, shownDims and lockedBodies. Preferences > Design > "Hide origin by default": a design that never toggled its Origin eye follows the preference. New fields are a pending format change (format/pending/browser-view-state.rs). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
9e6e0b8df1 |
Render workspace: complete experimental ribbon, resources and effects integration (#5493) (#5494)
* wip(render): reconcile completed material and image pipeline source with 0.20 (#5493) Source-only integration reference for staged review, not a merge-ready aggregate. Donor: 0xlillith/solidcraft@aea20b0115. Upstream: |
||
|
+33 |
b7b25f9e2b |
Render workspace: first basic delivery to main (#6050)
* Normalize UI container violation paths across platforms (#5599) Report repository-relative paths with forward slashes so diagnostics and the existing nested-package regression assertions agree on Windows and Unix. Keep the container detection rules unchanged. Validation: official ui-containers gate and all seven focused xtask tests passed; rustfmt and diff checks passed. Only xtask/dependencies were compiled; no application build or heavy tests. (cherry picked from commit |
||
|
|
19db763899 |
Tapped Hole: verified metric fine, UNC/UNF and parallel G/Rp catalogues (#4178)
* feat: expand tapped-hole catalogue with metric fine and Unified sizes * docs: distinguish metric designations from expanded tapped catalogue * feat: add internal pipe catalogue and checked Rc profile data * Connect parallel G and Rp catalogues to cylindrical tapped holes * fix(i18n): register tapped thread catalogue labels * fix(i18n): complete thread labels in required locales |
||
|
|
9a737bd63c |
Linked components: joints keep their face after Update Links (#3330) (#4874)
* claim: #3330 * Linked components: joints keep their face after Update Links (#3330) A linked design comes in as STEP text, which keeps no face names, so the faces of its bodies were named by their place in the file (`face:<k>`). An edit of the part that adds a face earlier in the file (a second hole of the same size) gave that place to another face, and a joint on the linked part moved there silently. When a link is made or updated, each imported face is matched to the part face it was written from (the same geometry), and the Import feature keeps that face's name in the part (`Feature::link_faces`, a new pending format change). The linked face is named `F<import>🔗<digest of that name>`, pieces keeping their qualifiers, so references follow the part's own history through Update Links as they do inside the part, and a face the part no longer has is reported. Linked faces still answer to `face:<k>`, so older references keep resolving; Update Links warns about joints that use them and reports joints that no longer solve. * Linked faces: a solid's twin keeps its own names; renamed faces count as an update Two solids of a part alike in one place each take the names of the solid the file names them after. Update Links reports a link whose part named its faces differently since as updated (a joint may follow that name to another face), not as unchanged; only a link getting its first names stays unchanged. * Linked faces: Extract to File carries the design's face names too Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: MateuszSychXpl <151755914+MateuszSychXpl@users.noreply.github.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
4dc30c092d |
Mirror and pattern: a pattern or mirror feature as the source (#395) (#3998)
* claim: #395 * Mirror and pattern: a pattern or mirror feature as the source (#395) A pattern or mirror of features refused another pattern or mirror as a source ("Pat cannot be patterned or mirrored yet"). Such a source now stands for what it copied: its own sources are replayed at each of its transforms moved by each of ours, to any depth up to eight. Copies of a feature picked directly keep the instance numbers they had, so existing designs keep their face names; copies made through a nested pattern or mirror are numbered after them, so one feature reached two ways never names two copies alike. A pattern or mirror of bodies as the source is still refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
e67ae66f3e |
Renaming a parameter follows it into sheet-metal and plastic rules and canvases (#4420) (#4423)
* claim: #4420 * Renaming a parameter follows it into sheet-metal and plastic rules and canvases (#4420) Document::rename_param rewrote other parameters, feature inputs, dimensions, configurations and joints, but not the expressions of sheet metal and plastic rules or the plane a canvas lies on, so after a rename the sheet metal and plastic features using them failed with "unknown parameter" and the canvas left the view. It renames them there now, and param_users lists them (a rule's field, a canvas's input), so a parameter they use can't be deleted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Parameters: rules' features in drives and the graph; shared rule field lists (#4420) A sheet metal or plastic rule that uses a parameter makes the sheet metal (or plastic) features rebuild when it changes, so parameters.users lists them in drives and parameters.graph links them. SheetRule::fields/fields_mut and PlasticRule::fields_mut replace the hand-written copies of the rules' fields in params.rs, eval.rs and sheet.manage_rules. Suggested by @CamWight. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fmt (#4420) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |