e50e7e1bf646dbbf4c8a26e2fbf5567af6fad280
716
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
d506dd6552 |
A parts list's rows as a table reads them (#3874 P7b) (#12839)
PartsList::rows gives each row of a bill of materials with its values formatted, each followed by the rows listed under it. The item comes from the rule a balloon reads, so the two can't disagree. A mass follows the list's unit and decimals and a length the drawing's units; a value a row hasn't got is left out, for the table to mark. A nested row's quantity is how many are in one of its parent, and `count` has them all. A row's key names each member, so one part listed in two places keeps two keys, and the limit is now 2048 bytes to fit the 65 members of the deepest list. The plan's "item with its padding" has nothing to do: no padding exists. The text measure goes with its first caller, the sheet's tables (P8b). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
2a2544956a |
Drawings: sheet text in a script the drawing's font lacks no longer holds up the window while a font is found (#12778)
* Paper scene: what a font adds to a table, a run's reach, and text in the sheet reply's schema (#4890)
One rule for everything that puts text on a sheet: `Scene::font_records_beyond`
counts only what a scene's font table doesn't hold yet, `TextRun::reach` says
how far a run's glyphs go along its baseline, and `drawing.scene`'s schema has
text runs and fonts, never a font's bytes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Paper scene: a font's records are found by its id, not by its place in the table
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Drawing dimensions: their numbers on the sheet, in the drawing's font (#4896 W19h)
A dimension on a sheet now carries its text: each value is set in the
drawing's font and language, measured, and placed along the dimension's
text direction, reading from the bottom or the right. Arrows flip by the
measured text width. A text the font can't set leaves the lines and says
why. The scene adds each dimension's fonts to its table once, counting their
records against the scene's limit, and measures text by its outlines for an
object's bounds. A dimension is read again when the drawing's units,
language or font change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Drawing sheets: a title block's labels and values set on paper (#4890 B3, #3875)
Each label is set as one line at its place, and each text cell's value in its
value box by the cell text rule, broken between words to the box's width when
its fit wraps, in the drawing's font and language. What doesn't fit is shown
whole and noted; a text no font can set is left off the sheet and noted with
why, so the sheet and its export never fail over one cell. drawing.inspect
lists each cell's notes; the sheet scene sets what was measured.
What a cell shows is worked out in one place for drawing.inspect and the scene.
The block's fonts count toward the scene's records with the border, so no view
takes them, and the scene is drawn again when the design or a cell's text
changes.
Ported from the personal PC's 1951bc696 onto today's drawings.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Sheet scene: a title block's text set once while its sheet fills in, and its faces in the key (#4890 F5)
The sheet scene read its title block's fields and set their text again on
every extract that missed its last answer, and views are drawn one a tick,
so a sheet filling in weighed the documented component and laid out the
block once for each view drawn. The text is now kept with the last scene
and set again only for another sheet, drawing, design, model or lettering.
A scene is reused only for the same faces too: one family name can mean
another face once a font is installed or removed, and that face is another
scene. A family with no face is set in the built-in font, so it stays the
same scene until it's found.
Ported from the personal PC's d82fd03e7 onto today's title block text.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Sheet text never waits on the window's thread: a title block's and a dimension's text wait for no font search, and inspect names the fonts fallen back to (#4890 F7)
A text in a script the drawing's font lacks needs a search of the installed
fonts. The window's sheet (`drawing_scene::extract`, `step` and the view's
job, on the UI's tick) now asks the search's thread instead of waiting for it:
- sketch: `paper_lines_now` beside `paper_lines_in`, as `paper_text_now` is
beside `paper_text_in` (FontPending until the search answers).
- title block: `title_block_text::lay(.., wait)`. A text whose font is still
being looked for is off the sheet and marks the `Laid` as `pending`, never as
refused. While the last scene's block is pending, the fast path and the
text's reuse both miss, so `extract` sets the block again until the search
has answered.
- dimensions: the same rule for a dimension's number (`paper_group(.., wait)`,
a `wait` flag on `draw_dimensions`). The step, its dimension step and the
view's job (#11126) all ask; a dimension whose text is pending is kept as
pending, and `extract` reads those dimensions alone again
(`set_waiting_dimensions`), keeping each one only once its text is set.
- `SheetView::waiting_for_fonts` says when text is still waiting. `step` does
not: pending text has no lines to draw again, so a `true` from it would spin
on no work.
- `build` (export, `drawing.scene`) and `drawing.inspect` wait, so their
answers are whole. `drawing.inspect` adds `font_fallbacks`: which font set
each script of the title blocks' text that the drawing's font lacks
("Kana set in BIZ UDPGothic").
The scene tests' `settled` asks as the window does (extract, then steps,
until neither has more to do), with a time bound.
Ported from the personal PC's cae4a2969 onto F5; the dimensions' half is new
(one rule for every text the window's sheet sets). On `drawings`
|
||
|
|
67a325808f |
Drawings: a balloon, dimension or note attaches only to a part its view draws (#4896) (#12394)
Adding one on a part the view's saved settings leave out (its hide, or a source that doesn't
choose it) is refused, naming the view and the setting, and the parent view when it set it. One
added before a later view edit stays, and its inspect reply warns until the edit is undone.
The rule stays the view's own (`chosen`): `left_out` asks it about one occurrence path and says
why; `check_drawn`, `not_drawn` and `drawn_warning` beside the view commands use it for the three
annotations. `DimensionKind::paths` and `Anchor::path` list what each points at, so every kind of
dimension is checked. No model is evaluated.
On drawings
|
||
|
|
ecf75d9088 |
Drawings: a drawing, a sheet or a view saves the line group its lines are drawn in (#4890 D2d) (#12516)
A drawing saves the ISO 128 line group its views and dimensions are drawn in; a sheet or a view may save its own. A view's group is resolved like its other inherited settings: its chain, then its sheet, then the drawing, and inspect says which gave it. The group joins the display settings a projected view follows. drawing.create and drawing.set take it; the sheet commands and drawing.view.edit take it or null to follow. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
855ce28fda |
Drawings: a deferred drawing keeps its lines until it is updated (#4892 U2) (#12449)
A drawing's views follow the model automatically, or, when deferred, only on drawing.update, which lets them draw from the model as it is now, for this session only. The next model change holds again, and a close drops the update, so a reopened deferred drawing waits. While it waits, its views show their last lines, out of date. drawing.set and drawing.inspect take and say `updates`, saved only when deferred (a drawing-format pending note). drawing.scene, its hit and line commands and drawing.export read what the page shows and list what is out of date; drawing.status says held. The ribbon's Update Drawing button stays planned as drawing.update.planned with its art awaiting review, as Export does; the command itself takes the existing update icon. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
5792393fb2 |
What a saved view shows: source and hide, following its parent (#4816) (#11873)
A saved view now keeps the occurrences it draws and the ones it leaves out,
as the snapshot takes them. drawing.view.base, edit and inspect take them; each
follows the parent until a view sets its own, and a copy made alone keeps what
it showed. Boundaries, fitted scales and lines all read them through one rule.
A path whose occurrence was deleted never refuses the file: a hide path goes
quiet, and a view with nothing left is a placeholder that says why.
Replayed onto drawings
|
||
|
|
188192cb8b |
Drawings: a lost reference lists what it may now be, and a repair points it there (#4892 B5) (#12170)
A dimension or balloon whose edge, corner or face is lost now lists up to 16 leads, offered and never taken: the
blend face named after a filleted edge, that face's edges, then the faces the same feature made. Lookup still never
writes the record, so undo brings a lost reference back.
drawing.dimension.repair {dimension, slot, pick} and drawing.balloon.repair {balloon, pick} point a lost or
ambiguous reference at a pick of the same kind, on the reference's own occurrence path: same id and paper place, one
undo step, through one shared helper. Only a reference that no longer finds the one thing it names is repaired, so a
dimension's other, still-found reference is kept, and silhouettes repaired onto one cylinder are refused as add
refuses them. A pick takes the forms add takes, so a lead of the slot's kind from inspect passes back as it stands.
The saved format is unchanged.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
||
|
|
da576824b2 |
Drawing views: a view's look is its visual_style, the viewport's name for it (#5307) (#11579)
A drawing view's setting for how it is drawn (visible lines, with hidden lines, shaded) was display_style while the viewport calls the same idea its visual style. The field, its command parameters, its schemas and its replies are now visual_style, on a view's settings and on its own overrides. display_style is refused as an unknown field, as drawings haven't shipped and no saved design holds it. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
f2b0b39393 |
A parts list's ballooned column, for its editor only (#3874) (#11964)
A table's column can be left off paper (printed: false, saved only then): the layout places the printed columns only, while filters and overrides still read every column. No printed column may read the ballooned row field, and a table prints at least one column. A new parts list gets a seventh column, ballooned, not printed. Drawing::balloons_by_list works out once which list each balloon reads, and balloons_by_row counts one list's balloons row by row, every row listed, 0 included; drawing.inspect gives parts_lists with each list's counts. Worked out on each read and never saved. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
b3af8346cf |
Drawings: a part's drawing starts on A3 and an assembly's on A2, each with its tolerances note (#3875) (#12000)
* Drawing templates: the built-ins carry SolidCraft's title block again, so a new drawing starts with it (#3875) Every built-in template, ISO A4 to A0, is one sheet with the ISO border and the built-in title block, so drawing.create with no template (iso-a3) gives a drawing with the block. #7208 made them the border only; the decision since is that a drawing starts with SolidCraft's block, and a user replaces or changes the default template. - A drawing saved as a template is the user's own: a copy of the built-in with a company's name in the block and its tolerances typed in starts drawings that keep both (tested through drawing.template.save and drawing.create). - The built-in block by name stays, for a sheet without one. - The general tolerances stay empty, and the five names (iso-a4 to iso-a0) and the one drawing_template setting stay: the part and assembly versions would be the same. - The tests that gave a new drawing the block first no longer do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing templates by kind: a part starts on A3, an assembly on A2, each with its tolerances note (#3875) Ten built-ins, iso-a4-part and iso-a4-assembly up to iso-a0-part and iso-a0-assembly, each with its kind's general tolerances note typed over the title block cell. template::default_for(assembly) is the one rule for the default, and template::is_assembly says a design that places components is an assembly. drawing.create with no template uses it, and drawing.template.list marks the design's default and says whether each built-in is an assembly's. The older names iso-a4 to iso-a0 still read as that size's part template. Preferences gets one setting per kind in place of the one; a saved name of the other kind reads as the kind's default, and the old drawing_template key is ignored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
96bb41c480 |
Drawings: notes on a drawing, the record and commands (#4896) (#11898)
* Issue a revision: drawing.revise (#3874 R1) drawing.revise appends a copy of a row to the issued history: an existing row as it reads, or a new revision with the texts given, in one undo step. A row is issued once. The copy keeps what it read through an edit, a hide or a delete, and nothing is filled in: no date, checker or approval. Issuing used to make a drawing unreadable, as a copy has its row's id and the drawing's check refused any id seen twice. Each id now counts once, and issued ids are unique among themselves. model_version becomes {path, change}, on issued copies only. One function on the session answers it, and answers nothing until version control exists. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing revisions: numbered 1, 2, 3 (#3874) A drawing's new revisions are numbered 1, 2, 3, never lettered (@CamWight, 3 Nov). drawing.set's revision_numbering is {start: 0 or 1}, the first number. A revision typed by hand is kept as typed; the next one follows the highest number, and drawing.inspect says where numbering starts. A record in letters is refused (drawings haven't shipped). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Revision tags on a sheet: add, edit and delete (#3874 R3) A tag gains the sheet it sits on and its place there. drawing.revision.tag.add, .edit and .delete keep them, inspect and every revision reply list them with what each shows, and a sheet's delete counts and takes the tags on it. A deleted row still leaves its tags showing the revision they had. Tags draw on paper once scene text lands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Saved tables on a sheet: drawing.table.add, .edit and .delete (#3874) A drawing saves its parts lists and revision tables, each on a sheet with its definition and place. Rows are never saved. A parts list starts at the top right listing what its sheet documents, else the design; a revision table at the bottom left; headings on top, QTY, rows of 7 mm. Placing a list saves the numbers its view shows, once per view, so what is printed doesn't move. Numbers are the design's: undoing the placing puts back only the drawing, as every drawing step does, and the numbers stay. That one command changes both, and the proof that nothing needs evaluating now allows it. The tables are a ById list, as the balloons and images are, and keep its rules: at most 1000, listed by id. Revision tags take their own id type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * A balloon reads its row in a parts list (#3874 L1) A balloon can name the parts list it reads; else it reads its sheet's only list, else the drawing's only one, else none, with the choices listed. Its row's item is worked out on each read and never saved: drawing.balloon.inspect gives item and row_status (ok, no_list, reference, no_row or not_found). A lost row never removes the balloon. A list's delete reports the balloons that named it and clears their links. Bom::item_of cuts a path from the top of the design to start below the assembly listed, and row_of is no longer test-only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Notes on a drawing: the record and commands (W19e, #4896) A note sits on a sheet, a view, or an edge or corner of a view's model, saved by name as a dimension's is, with the title block's text and fields, its place and its text height. drawing.note.add, .edit and .inspect, one undo step each, no model evaluated. Its one leader is worked out, never saved: a lost reference keeps the note and its text, with no leader. Anchor is one type so other symbols placed on a sheet can use it. A view's notes go with its copy and delete; a sheet's with the sheet. The plan left delete for later, but selection.delete now handles a drawing's objects, so notes join it. Balloons and notes share Lookup::middle. Drawing them waits for text in the paper scene (slice 12). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
b841eb939f |
Merge main into drawings (Nov 4)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
49eedf122c |
Drawings: a reference to a suppressed or failed feature says so (#4892) (#11823)
* Labelled measurements on a view's snapshot (#5866) measure: linear, aligned, angle from model points, radius from an edge, with units and decimals for the labels. No new maths: drawing_measure's rules, and a dimension's radial rule through one Lookup::whole_arc. Labels go through one function, reading_label, which dimensions' text now uses too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Pieces on one circle are that circle, and one piece is that edge (#4892) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * A dimension between two flat faces (#4892) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * A suppressed or failed feature's references say so, not lost (#4892) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
669aaa7744 |
Drawings: a dimension finds its circle again after the edge is split (#4892) (#11869)
* Labelled measurements on a view's snapshot (#5866) measure: linear, aligned, angle from model points, radius from an edge, with units and decimals for the labels. No new maths: drawing_measure's rules, and a dimension's radial rule through one Lookup::whole_arc. Labels go through one function, reading_label, which dimensions' text now uses too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Pieces on one circle are that circle, and one piece is that edge (#4892) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
a301359652 |
Dimensions on the sheet: lines and arrowheads in paper millimetres (#4896) (#11867)
Each dimension of a view on the sheet is one group, ObjectKind::Dimension, after the views: extension and dimension lines and filled arrowheads (Terminator::place, #9466), laid out by dim_layout_sized in paper millimetres, so it is the same size at any view scale. All seven kinds draw; a chain is one line of frames at one offset with each extension line once, an angle sits where its lines meet on the view, and a cylinder's line runs across its silhouettes at the end on its offset's side. drawing.scene and drawing.export list each dimension: its status, whether it is drawn, and why not. A lost one, or one on a view that isn't drawn, has no lines and leaves the sheet and the file written. The provider keeps each dimension's group by its record, world state, view drawing and units: a moved view moves them unread, and an edit reads that dimension alone, in one short step after the views. Text joins with B1. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
d25f8198fa |
Pieces of a cut keep their names when the design is evaluated again (#11658)
A cut that leaves a body in pieces names them after their faces (`order_lumps`): the piece whose least face name sorts first takes the first name, and so on. It moved the names but left the pieces where the kernel put them. The session then pinned the feature's body names in that state order, and the next full evaluation (opening the design, or editing a parameter upstream) handed them out again in a different order: two pieces swapped names, and a later feature that named one met the other. Found by a local model fuzzer. The pieces now also take the family's places in name order, so the names pinned are the order the next evaluation hands them out in. A design saved before keeps the names a fresh evaluation gave it. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
3a23d21795 |
Lip: clearer guidance when the face is not a shelled rim (#10437) (#10871)
* claim: #10437 Co-authored-by: Cursor <cursoragent@cursor.com> * Lip: say Shell first when the face is not a rim (#10437) A solid box top left OK disabled with a vague shelled-body hint. Name Shell and the rim-around-an-opening requirement in the refusal, the dialog tip, and the command help. Co-authored-by: Cursor <cursoragent@cursor.com> * Lip: keep the dialog hint as it was, match the new refusal text in the test Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
481687fff3 |
Modeled threads: the thread runs down to a flat face with no uncut block, so a nut can bottom out (#11782)
* Modeled threads: run down to a flat shoulder so a nut can bottom out An external thread running the whole face stopped with its groove clear of a shoulder, leaving up to a turn uncut above it. The groove now runs on past the plane of the face's end and is trimmed there, so its root reaches the shoulder at every angle and nothing past the plane is cut. A shoulder rising back along the face keeps the square stop, as do internal threads, tapers, runouts and lengths stopping short. Where the kernel refuses the trimmed cut, the groove also keeps the square stop and the feature warns. Closes #11610 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel ladder: record the thread cases that now reach their shoulder Six cases gain the faces of the trimmed last turn; every other case is unchanged apart from its timing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Thread at a shoulder: review fixes, and a test of the fallback The shoulder check starts just off the face, as the free-end check does, so a slope rising from the face counts. A groove the trim leaves nothing of now falls back to the square stop too. A test forces the fallback and reads its warning. The ladder's order and report go back to main's, changed only for the cases this moved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Thread at a shoulder: check all the radii the groove cuts The check for a shoulder rising along the face looked a fixed distance out, which falls short of the groove on an undersized shaft. It now covers the groove's reach. A test reads how each kind of shoulder is classified. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Thread at a shoulder: test the trim that leaves nothing of the groove The test now reaches the path where the half-space keeps nothing, which is the one that must fall back to the square stop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Thread at a shoulder: say so when the shoulder can't be checked If the kernel can't make the rising-shoulder check, the groove keeps the square stop as before, and the feature now warns that its last turn is left uncut. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
f74c6605c4 |
Fillet: Mitre or Swept corners where two rounds meet (#11498)
* SMLib wrapper: a swept or mitred turn for constant rounds (Turn) Brep::blend_dropping takes a Turn: Mitre (the default, as before) or Swept, which sets solidcore's FilletSession::set_swept_turns before the corners are made. A swept turn solidcore refuses at CreateFilletCorners comes back as Error::TurnRefused with its reason and place (NoRoom at a concave side edge, else CornerUnsupported). Swept is for Blend::Round only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel: fillet rounds turn in a mitre or swept (FilletTurn) fillet_removing, fillet_max, fillet_max_each and fillet_each take a FilletTurn and hand it to SMLib, through the reblend of earlier rounds at a later corner too. A swept corner solidcore does not build is refused as invalid input with its reason and place: no smaller radius builds it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Design: a fillet saves its turn, mitre (default) or swept FeatureKind::Fillet gets `turn` (FilletTurn: mitre, the default and not saved, or swept), one pending format file. Evaluation hands it to the kernel, pattern copies included, and refuses a swept turn with a style, fit, corner or setbacks the kernel's swept corner does not take (SWEPT_TAKES). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * solid.fillet: the turn parameter, and the command's input and output schemas `turn: mitre|swept` on solid.fillet, refused when unknown or with options a swept corner does not take. solid.fillet now has its contract (FilletParams) and reply type (FilletResult), registered with checked!, and leaves schema/unconverted.txt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Fillet dialog: a Turns choice, Mitre or Swept A Constant radius fillet's Turns row sends `turn: swept`; choosing a narrowed radius or a curvature corner puts it back to Mitre, and Swept puts those back. Its tooltip says what each does where two rounds turn round a corner edge. New strings in a pending locale file (en, de, ja, ko, zh); glossary entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Fillet turn: the schema tests' fixes and the complete catalogs' strings The no-contract example in the schema tests is solid.chamfer now that solid.fillet has one; the reply test checks the mid-radii form against the contract (solidcore refuses that law's corner yet, #430) instead of building it; Arabic, Hebrew and Vietnamese, complete catalogs, get the new strings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Fillet schema test: variable and spline forms checked against the contract solidcore fails a variable round on a box edge at this pin (status 1001, as variable_radius_on_a_box_edge), so the reply test checks those forms against the contract instead of building them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Fillet turn: the swept rig cases pass; the MCP no-contract example is solid.chamfer cov-fillet-turn-swept-boss-base-r1 and cov-fillet-turn-swept-pocket-sharp-corner-refused-r1 pass now that solid.fillet takes `turn`: off the rig's known-failing list. The MCP bridge test's example of a command without a contract was solid.fillet, which has one now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ --------- Co-authored-by: jyviko <2501648+jyviko@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
e12afd11cc |
Ellipse and spline extrudes make one wall; coplanar faces never lose their names to a budget (#11687)
* Planar sources: decide coplanar faces by support group, no budgets that drop sources map_planar_sources kept two budgets, `metadata` (2 MB) and `identity_bytes` (16 MB), charged by each face's source descriptor and by every extra candidate on its plane. When one ran out, faces silently lost their source and with it their persistent name: a 300-hole plate whose top a comb of grooves cuts into 62 strips lost the cap source from strip ~47 on. The budgets bounded the real cost: each result face looked at every candidate on its plane, faces x candidates when many faces are coplanar. The candidates are now grouped by support once (`same_support` against each group's first plane, through the existing PlaneIndex), each group's chosen source, ambiguity and inner flag decided once, and the faces without a role together with the competing tool faces grouped the same way. Each result face then looks up its plane's few groups. The decision is the old one: blocked by an unknown or competing support, else the first candidate on the plane unless another candidate there has a different plane, source or role. Work: grouping looks at each candidate's index window once per group (each candidate is assigned on its group's first look), and each face looks at the group representatives near its plane, so the planes looked at grow with faces + candidates. A counter (`looked`) checks it: n pieces of one cap and n faces on its plane take exactly 2n looks (n*n before), 3n with n blocking supports. Tests: the holed plate keeps the cap source on all 62 strips and the bottom (fails on the old code: face 352 lost its source); the existing planar source tests pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Extrude: an ellipse or a spline sketch curve sweeps one wall An extruded ellipse had four side faces (`F2:side:e1#1` to `#4`), one per conic quarter, and a spline one per span: the profile holds such a curve as several exact segments and SMLib got each as its own curve. The Extrude feature's builder (`extrude_whole_sides`) now takes a `one_curve` test from the caller. Each run of free-form segments of one degree that it says are one curve goes to SMLib as one B-spline: the Béziers' control points in a row, knots repeated the degree times at each joint, each span as long as keeps the speed through the joint the same (so the curve is C1 there and SMLib makes one face over it, as it would not over a C0 parametrisation), weights scaled to meet. Exact: the same curve, reparametrised. A loop starts at a run's start, so no run wraps round it. The wall's history lists every piece, and its construction source is its first piece's (as joined collinear lines). The document says which segments are one curve: ExactSketchCurves now also holds each free-form sketch curve's exact segments (`find_free_form`: a segment that is one of them, either way round), and the profile roles use it, so the wall is named `side:<curve>` from its history rather than by the curve nearest its mesh centre. Saved designs rebuild with these walls renamed (`F2:side:e1#k` -> `F2:side:e1`); accepted, no alias kept. Tests: kernel `pieces_of_one_curve_extrude_into_one_wall` (an ellipse in four conics is 3 faces, its volume pi a b h to 1e-6, the wall generated by all four pieces; a 3-span spline closed by lines is one wall; the same solid as a face per piece); doc `an_extruded_ellipse_or_spline_is_one_wall_named_by_its_curve` (one `F2:side:e1`, no piece names, the same names on a second build and after reopening). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Tests: a tray's far rim name is checked on the exact B-rep face The tray test took the point `sheet:...:rim.far` finds as right when it lay within 1e-3 mm of the strip z = 30, 199 <= y <= 200: a slack sized to the mesh. It now asserts on the face the name finds, on exact geometry: the point's distance to that face's surface (FaceSurface::nearest) is within rounding at the part's scale (1e-12 x its size), and the point is inside the face's boundary, counted by crossings of its record edges (each asserted to be a line, the rim being planar). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Tests: delete tests/naming/, the records no test reads since the naming corpus stopped comparing against them Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Viewport test: smooth wall joins drawn from eight G2 spline walls The PR extrudes each spline or ellipse sketch curve as one wall, so the offset-ellipse ring the test built has no joins between faces any more. The test now extrudes a circle drawn as eight cubic splines: eight walls meeting with one curvature along eight upright edges (24 edges in all). It still checks that those joins are left out of the shaded view, drawn in the wireframe and selectable as edges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel ladder: 009 and 012 record the one-wall extrude (an extruded spline or ellipse sweeps one wall) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ --------- Co-authored-by: jyviko <2501648+jyviko@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
1e0bfca819 |
Release 0.40.0-rc.2 (#11751)
Bumps the version to 0.40.0-rc.2 and folds the pending format changes into format 50. A published pre-release no longer reaches the Flatpak feed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
fd4b7a7bc0 |
Seg2: one rule for an arc under a shape-keeping map (#4816) (#7316)
`Seg2::mapped(f, arc)` is a segment under a map of the plane that keeps shapes. Points go
through `f` itself (an arc's centre, every control point). `ArcMap { angle, mirrored, scale }`
says how the map moves an arc: it turns it by `angle`, after a mirror across the x axis when
`mirrored` (start `angle - start`, sweep reversed), and scales its radius by `scale`.
`ArcMap::turn(angle, mirrored)` keeps lengths; `ArcMap::rigid(f)` measures a map of points that
keeps lengths, from where it puts the origin and the unit axes, with a scale of exactly 1.
`Seg2::similar` and the three arc maps written out by hand use it:
- a sheet-metal region onto a panel's flat (`region_to_flat`, which measured its map by hand and
now asks `ArcMap::rigid`);
- the mirrored flat (`flip_x_loop`);
- a sketch region mirrored in its x axis (`mirror_y`).
The points go through the same functions as before, so every result is the same, bit for bit.
This comes from the architecture review of the drawing work (2026-10-25): four places wrote the
arc rule out, each its own way, and one measured its map by hand.
`map_controls` is private to geom now: on its own it hands an arc back unmapped, which is what the
three hand-written arms were there to avoid.
Tests: every kind of segment under a mirrored map with a turn, a scale and a shift, point by point,
its length scaled and an arc's sweep reversed; the three old formulas, bit for bit (the sketch
mirror keeps a +0.0 start's -0.0); a rigid map's turn and mirror measured whatever its shift, and
the identity; the sheet-metal and mirror tests unchanged.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
||
|
|
c019e2555c |
Threads: a 12 mm hole now takes an M12 thread, and a modelled M12 builds in it (#11651)
* Threads: a 12 mm hole takes M12, and a modelled thread narrows a bore that is too wide (#11609) Automatic sizing of a hole now takes the size whose nominal diameter the hole has (a 12 mm hole is M12, not M14, the size whose tap drill is 12 mm); a hole near no nominal diameter is still matched by tap drill. A modelled internal thread in a hole as wide as the thread or wider no longer refuses with "too wide": the bore is filled in to the thread's minor diameter over the threaded length and the groove cut there, and the feature's warning says so. A size that does not fit the hole names the size that does. A saved thread with no designation keeps the old rule through a pending format step, so an existing design rebuilds with the size it had. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Threads: keep an old automatic size through edits; kernel-rig cases expect the narrowed bore (#11609) Editing a saved automatic thread keeps `old_auto_size`, so it does not change size. The five kernel-rig cases that expected a modelled thread in a hole as wide as the thread to be refused now expect the narrowed bore, with the volume worked out analytically in each case. The thread dialog's reopen pattern names the new field. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Thread dialog test: a 5 mm hole is suggested M5, its nominal size (#11609) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
08cd8d6442 |
Drawings: title blocks on sheets, and a drawing can start from or be restyled by a template (#3875) (#7208)
* Drawing sheets: a copy of a title block on the drawing border, saved with the sheet (#3875) `Sheet.title_block` holds a copy of its definition, as `border` does. Each sheet's check lays it out on the drawing border, so a sheet without a border, a block wider or taller than the border, or a change of paper that leaves no room is refused. `drawing.sheet.add` and `drawing.sheet.set` take `title_block` (a definition, or null for none), a new sheet takes the block of the sheet it follows, and `drawing.inspect` lists it. A sheet without a block saves no `title_block`, so an older drawing reads as having none (pending format file `sheet-title-block.rs`). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing sheets: the built-in title block, on every new drawing (#3875) `title_block::default_block()` is the 180 x 54 mm block of twelve cells approved on #3875, with the legal owner read from the drawing's `organization` and the general tolerances as text to change. `drawing.create` starts its sheet with it. The geometry tests read the built-in block instead of their own copy of it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing sheets: a title block's lines on paper, drawn after the views (#3875) `TitleBlockLayout::paper` draws the outline, then every cell edge inside it, each once: neighbours' shared edges, and edges that meet along one line, are one stroke. The sheet scene paints the block after the views, and counts its records with the border's, so no view takes its room. The view tests' drawing leaves the block off, so their scene is still the border and the views. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing sheets: the title block's projection symbol, in the drawing's projection (#3875) ISO 5456-2 (Annex A): a truncated cone and its end view, h across the cone's small end from table A.1's sizes (3.5 to 20 mm), the largest that fits the cell, lines h/10 wide. The end view is on the right in first angle and on the left in third. The block only says a cell holds the symbol; the angle comes from drawing.projection, and the sheet scene redraws when it changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing sheets: a title block's fields, and text typed over its cells (#3875) A title block cell reads its fields from the component the sheet documents (its name, part properties, material and mass from the bill of materials), the drawing, the sheet (number and count among the counted sheets) and the newest revision row; a field with no value shows "-". A key its source doesn't have is refused when a block is given or read. Sheets save text typed over their cells by cell name; drawing.inspect lists each text cell with its value beside an override. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing templates as data: a drawing with no model, and ISO built-ins (#3875) A template is a drawing with no sources, views, dimensions, balloons, revision rows or documented components, so it is saved and read as a drawing is. A new drawing is a copy with ids of its own. The built-ins, ISO A4 to A0 for parts and for assemblies, are made in code when asked for and differ only in their general tolerances. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing templates: drawing.create from a template, and the preferred ones (#3875) drawing.create takes template? (default ISO A3, for a part or, for a design with components, an assembly) and projection? over the template's. The new drawing.template.list lists the built-ins and marks the one a new drawing starts from. Preferences add a template for part drawings and one for assembly drawings; the app fills in the preferred template and projection before drawing.create runs, so a template named keeps its own projection, instead of changing the projection after the drawing is made. A saved template this version doesn't know reads as the default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing templates: apply one to the drawing open, moving nothing (#3875) drawing.template.apply {template, dry_run?} gives each sheet the paper, drawing border and title block of the template's sheet in its place (its last for the sheets past its own). Text typed over a cell stays while the new block has a text cell of that name; the cells whose text is dropped are listed. Nothing moves: the views a new paper leaves outside the drawing space are listed. A dry run answers the same and changes nothing; applying is one undo step, none when nothing changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing sheets: views a title block covers are listed, never moved (#3875) A view lying over its sheet's title block is listed with the ones the drawing space leaves out, after a change of paper or block (drawing.sheet.set) and when a template restyles a sheet. Where a block sits is one rule, the one a sheet is checked by (Sheet::title_block_outline), and the overlap of two boxes is one rule in Aabb2::overlaps, which the title block's own cell check now uses too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing templates: save one as a file, and start or restyle drawings from it (#3875) drawing.template.save {path} writes the drawing open as a template: its format, and nothing it draws or documents. drawing.create and drawing.template.apply take a .json template file as well as a built-in's name. A file is read as a drawing is, then held to the template rules; files are read and written through the same file check and atomic write as the sheet export. A drawing made from a file keeps its own copy, so a later save changes no drawing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing sheets: the built-in title block is 180 x 49 mm (#3875) The top row is 15 mm, Sheet is 30 mm wide, lined up with Mass, and Date of issue is 32 mm. The top row now holds one line of the legal owner, two of the general tolerances and the 3.5 mm projection symbol. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing sheets: one operation sets a sheet's title block, and drawing.sheet.set names the typed text it drops (#3875) A sheet's block was set in two places: drawing.sheet.set kept the typed text of the text cells the new block still has, and drawing.template.apply did the same and listed what it dropped. Sheet::set_title_block is now the one rule both use. drawing.sheet.set's reply gains `lost`, the cells whose typed text a new block drops, as drawing.template.apply's reply has it, and its help says that a view over the title block is listed too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing templates: the built-ins and a new drawing start with the border only; the built-in title block is added by name (#3875) A template now holds only the ISO border by default. A title block, tables, references and text are added to a drawing, and a template saved from it keeps them. - The ten built-ins (iso-a4-part ... iso-a0-assembly) become five, iso-a4 to iso-a0: one sheet with the ISO border. Without the block, the part and assembly versions were the same. - drawing.create with no template starts from iso-a3. The two preferences for parts and assemblies become one, drawing_template, "Template for new drawings". - drawing.sheet.add and drawing.sheet.set take title_block: "built-in". The built-in block's general tolerances are a part's or, for a design with components, an assembly's, through Sheet::set_title_block. - An old name such as iso-a3-part is refused with the list of names; drawings haven't shipped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing title blocks: a drawing with no number of its own is numbered by the component its sheet documents (#3875) The identification number cell read the drawing's part number property, and showed "-" for a drawing that has none, which is every new one. Now such a drawing shows the name of the component the sheet documents, so a new drawing of a part is numbered by the part until it is given a number. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing templates: a template saved from a drawing keeps typed text only over plain text cells (#3875) A template saved from a drawing kept all the text typed over its title block's cells, including text over a cell that shows a field, such as the material or the title, which belongs to the design the drawing documents. Now it keeps the text typed over cells of plain text, such as the general tolerances, and leaves the rest behind. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing title blocks and tables: a field without a value shows nothing (#3875) A title block cell or a table row whose field has no value (a property nobody gave, a row field its row doesn't have, an uncounted sheet's number) now shows nothing instead of "-". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing title blocks: the built-in block's general tolerances start empty (#3875) The general tolerances cell of the built-in title block now starts empty for parts and assemblies alike, rather than ISO 2768-m in the block and a part's or an assembly's text added by drawing.sheet.set. A shop types its own, or its template carries them, and an empty cell shows nothing. - template::PART_TOLERANCES, ASSEMBLY_TOLERANCES, for_assembly and built_in_block go: "built-in" is title_block::default_block. - drawing.template.list's help no longer speaks of part and assembly built-ins. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
bfb32cd6e1 |
Align: move bodies by frames that follow sketch and model geometry (#6257) (#7123)
* claim: #6257 * Align: move bodies by frames that follow sketch and model geometry (#6257) solid.align takes from_frame and to_frame: a joint origin on the model (a face's or round end's centre, an edge's middle, a corner, found again by name) or a sketch point or a sketch circle's, arc's or ellipse's centre. Both are resolved on every evaluation, so the bodies follow their target when it changes. An optional angle turns the bodies about the target's direction after the move. The Align dialog takes sketch points and curves as From and To, offers the Joint Origin snap and an Angle row. * Align frames: box the joint origin (clippy large_enum_variant) * Align frames: every moved body on the frame's component, placed once * Align frames: a sketch id's length in characters * Align frames: the dialog test's sketch curve hit carries its point * Align frames: the dialog test takes Vec2 from solidcore-record --------- Co-authored-by: MateuszSychXpl <151755914+MateuszSychXpl@users.noreply.github.com> |
||
|
|
cca77b176f |
Drawings: a shaded view is drawn on the sheet as a picture under its lines (#5624) (#10926)
* A drawing's list of one kind of record: ById, with balloons first (#5426) Each kind on a sheet writes out the same add, find by halves, cap, order and check loop. ById holds those, so a kind's own file holds only its own rules, and the file's bytes don't change: it saves as the plain list. Views and dimensions stay on their own lists for now, since other work is on them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * A drawing keeps an image's file once, however many places it sits (#5426 W38e-1) images holds the files and sheet_images each place one sits, so a logo on every sheet costs what one does. drawing.image.add reads the file (bytes and pixels checked from its header before anything decodes it), reuses a file with the same bytes, and saves the bytes without the path. A file goes with the last thing that uses it, which Drawing::images_in_use alone says, and reading a drawing refuses a file nothing uses or a record its file disagrees with. A sheet's list and delete take the placements on it. Deleting one placement waits for selection.delete to take a drawing's objects. Its pixels on paper are W38e-2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sheet images: an image file's pixels on any paper grid (#5425, W38e-2) A PNG or JPEG decoded once, then stretched over its paper rectangle onto the pixel grid a writer asks for: a box filter in linear light with alpha premultiplied, so a shrunk logo keeps its edges and gains no dark fringe. The size is read from the header and refused over 64 megapixels before anything is decoded. An EXIF orientation is applied; colour profiles are not read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sheet images: a placement in the sheet's scene and its SVG (#5425, W38e-2) Each image placed on a sheet is a group of the new kind `sheet_image`, between the drawing border and the views, so a view's lines draw over a photo. `drawing_pictures` holds both that group and the provider a writer asks for its pixels, so the two read the same placement. The provider holds what one sheet uses, decodes a file when it is first asked, once however many placements show it, and refuses a sheet whose files hold more than 64 million pixels, from their headers, before anything decodes. `drawing.export` passes it to the SVG writer in place of `NoPictures`, and a file that won't decode refuses its sheet by name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Render: pin the product image's output before it is drawn in tiles (#5624, W17b S1) The decoded rows of five product renders (orthographic on a transparent background, perspective on a solid one, a PBR surface, two glass layers sorted back to front, triangles crossing every edge of the picture), taken on this tree. The next change reshapes ImageTask into a prepare stage, tiles and a PNG sink; they must not move. The PNG bytes are not pinned: their compression depends on the deflate backend the build unifies (flate2's zlib-rs when the UI crate is built alongside, miniz_oxide without), not on this code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Render: pictures drawn tile by tile into any pixel window (#5624, W17b S1) The CPU product renderer, reshaped so drawings can use it: one rasteriser (`Raster`) prepares a scene once (appearances, projected triangles, glass sorted back to front), then draws each tile of the picture on a canvas of its own. A sample's position comes from its whole-picture index, so tiles put side by side are the picture drawn whole, to the byte. - `ImageTask` (render.image) is that rasteriser over one whole-picture tile from the product camera, then its PNG: the same output, pinned by the previous commit's rows. - `PictureTask` draws a `PictureRequest`: a `Projection` (the product camera, or an `OrthoFrame`, W17a's view frame as plain data: a `Plane` basis, a scale and a paper shift, on a `geom::pixel_grid::PixelGrid`), any list of `PixelWindow` tiles, `Supersample::One` (pixel centres) or `Two` (i + 1/4 and i + 3/4), a `BodyRole` per body (`DepthOnly` hides what lies behind it and draws nothing itself) and an optional background (none: transparent). Each tile comes back as straight-alpha sRGB RGBA rows, blended in linear light. - The orthographic map is the frame's paper map, onto the grid, so lines drawn from the same frame register with the pixels (to 1e-9 mm in the test). - Limits: 65,536 px a side, no total cap; each tile under the resolver's `RenderLimits`, as the product image is; at most 65,536 tiles; the prepared lists as a product image's; pixel tests up to 8 per sample of the picture (128 M for a product image, as before), counted at admission by the one projection the raster uses, as main counts a product image's. Not here: the drawing light, stored per-tile bins (S2, measured), the paper scene's picture item (S3), 4x sampling, and `raster::render`, the snapshot rasteriser, which stays as it is. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Render: time the tile renderer (#5624, W17b S2) An ignored timing test, as `simplify_timing` is: a 65,548-triangle front view drawn as the product image, as one 300 dpi picture, and in 64-row strips at 300 and 1200 dpi, each the median of three runs. It is the measure S2's speed-ups are judged by. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Render: a tile passes over a triangle outside it before painting it (#5624, W17b S2) Each tile placed and painted every triangle of the picture, then dropped those outside it: the appearance lookup, the PBR normals and the colour decode ran for every triangle in every tile. A triangle's work is now three steps, `corners`, `look` and `place`. Preparation runs them in today's order, so its checks and errors are the same. A tile places a triangle first and paints only those inside it. What is drawn doesn't change: the pin and the tile tests stay as they were. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Render: one light per picture (#5624, W17b S2) `raster::shade` normalised its key light and highlight directions again for every sample, although both depend only on the view. `raster::Light` works them out once per view and shades with them. The tile renderer and the snapshot rasteriser (`raster::render`) both use it, so the product light is written in one place. The arithmetic is the same, so every pixel is too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Render: sRGB codes from tables (#5624, W17b S2) Each shaded sample was stored as sRGB through a power (three per sample), and each output pixel was averaged from its samples through twelve more and written back through three: the powers were most of a sample's arithmetic. Decoding is now a 256-entry table of `geom::srgb`'s own values (#7162), which also ends this file's own copy of the formula. Encoding counts the code starts (the linear values halfway, in sRGB, between two codes) at or below the value. Within a billionth of a start, where the formula's rounding could fall either way, `srgb::encode8` decides, so every code is the one it gives. A test checks both against `geom::srgb` at every start, the numbers around it, the band's edges and a million values in and outside 0 to 1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Render: a tile's passes run in loops (#5624, W17b S2) The raster went back through its step loop for every sample: the cancel check, the stage match, the tile's window and its canvas bounds, once per sample cleared, tested or averaged. Clearing, the opaque and glass passes and the downsample now each loop on their own up to the step's budget, counting a unit as before; preparation and the glass sort still take one unit a call. A step still checks for cancellation before each stage's run and still does at most 16384 units, so the host's slices and the progress counts are the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Render: tests for a picture's light, glass order and test budget (#5624, W17b S2) Three planted faults went through the image tests; each now has one that fails: - an orthographic picture lit from another direction than its eye: a face square-on to the view is the colour the product image gives it; - glass placed by a triangle's first corner, not its middle: a tilted square whose first corners lie in front of the near one, its middles behind; - a picture held to the product image's pixel-test budget: a face across most of an A0 sheet at 1200 dpi is prepared. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing sheets: a shaded view's picture on paper (#5624, W17 V9b) A saved view in a shaded style draws on its sheet and in drawing.export: draw puts one picture per entry of the view's parts under its lines, and ViewPictures renders each on the writer's grid through the frame that placed the lines. SheetPictures answers for a sheet's images and views. The styles with lines stay refused until W06's exact lines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Render: a picture's count of its tiles and its fixed limit, as #6483 has them (#5624) A triangle counts only where it meets the tiles asked for, and a picture has a fixed 400 M pixel tests, as #6483 at bf93e890e. V9b's stack holds an older copy of that slice; this drops away when drawings takes main. PictureTask says what admission counted, for the view's running sum. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing views: a shaded view's pictures add up to one limit (#5624, W17 V9b) A writer asks for a picture a band at a time, and each request is limited on its own, so ViewPictures keeps what each view's requests have counted and refuses the next one past the limit, by name, before it paints. That makes 400 M a bound on a whole view. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
dc38349cbf |
Layer split stage 1: the B-rep record, native body file and Vec/Plane come from solidcore-record (#11496)
* Kernel: the B-rep record and the native body file come from solidcore-record SolidCraft's portable B-rep record (`solidcraft_geom::brep`: brep.rs, topology, history, envelope, part, curve2) and the native body file (`solidcraft_kernel::native`: the tagged binary codec and the container) move to solidcore's `solidcore-record` crate: geometry as data, with structural validation and no maths (solidcore's docs/layers.md, stage 1). Every caller uses `solidcore_record::brep` and `solidcore_record::native`; the old copies are deleted. What computes from coordinates stays with the kernel, in geom's `brep`: - `brep::check`: the record's geometric checks (orthonormal frames, non-degenerate planes, unit revolution axes, non-singular placements). `check::validate` and `check::validate_built` are the record's validation and these together, and every caller of `Brep::validate` uses them, so what is accepted is unchanged; - `brep::label`: a surface's natural ranges (a cone's apex), `curve_interval`, `edge_curve_interval` and `form_turns`; - `brep::pcurve::eval`: a pcurve's point; - `geometry::check`, `placement::moved` and `split_edges` become functions on the record. The kernel's native module keeps the conversion between a body and its saved record (metadata.rs) and checks the decoded record's geometry. `native/analytic.rs`, which no module declared, is deleted. solidcore-record is pinned to its rev on solidcore's `layer-record` branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NvoxKMbMFSQU8tzRtoJhtT * Geometry: Vec2, Vec3, Plane and the profile types come from solidcore-record The plain data of vectors and points, sketch planes and planar profiles (`Seg2`, `Loop2`, `Region2`) moves to `solidcore-record`, with its constants and component-wise operators only (owner decision, solidcore layer split). Their geometry stays in geom as traits: `Vec2Geom`, `Vec3Geom`, `PlaneGeom`, `Seg2Geom`, `Loop2Geom`, `Region2Geom`, `Seg2ArcFit`, `Loop2ArcFit` and `Region2ArcFit`, in scope with `use solidcraft_geom::prelude::*`. Every caller names the types from `solidcore_record`; geom no longer defines or re-exports them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NvoxKMbMFSQU8tzRtoJhtT * Kernel: pin solidcore-record to solidcore main f5e8e9a29 solidcore-record is merged on solidcore main (tangency-labs/solidcore#2519); its crate there is identical to the rev pinned before but for its clippy configuration. The lock is regenerated against the merged rev. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NvoxKMbMFSQU8tzRtoJhtT --------- Co-authored-by: jyviko <2501648+jyviko@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
2aa7e3e51c |
Release 0.40.0-rc.1 (#11457)
Bumps the version to 0.40.0-rc.1 and folds the pending format changes into format 49. The default-layout header test now expects the room the version really takes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
ba69e5488c |
Drawings WE1: Inspect Drawing lists each sheet's views, with their names, dimensions and balloons (#4894) (#11350)
* Where a sheet's objects sit: bounds beside the scene (#4894 WE3) The sheet scene now says where its border and each view sit on paper: the box round what each draws, and a view's boundary, so one that can't be drawn can still be picked. It is worked out once per assembly, beside the scene rather than in it, so no writer sees it and the page needn't inspect each view. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Selected drawing objects: a view, dimension or balloon in the selection (#4894 WE4) select.set takes {type: drawing, drawing, object} for the drawing open. It adds no undo step and changes nothing saved, and a selected object leaves the selection when an undo takes it or its drawing closes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Delete on a sheet: views, dimensions and balloons in one step (#4894 WE5) selection.delete now works with a drawing open: a view goes with its dimensions and balloons as one undo step, and one with views projected from it is refused, naming them, unless they are selected too or contents: delete takes them. A sheet's delete and this one share the record's one removal rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Tests: a view's box holds what it draws, and what's chosen goes in any order (#4894 WE3, WE5) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * What's on each sheet: drawing.inspect lists its views (#4894 WE1) Each sheet in drawing.inspect now lists its views: each base view by id, followed by those projected from it, with what it is called and its dimensions and balloons. It is one pass over the record with no model read, so the Browser can read it once per revision. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
ac3e6e0105 |
A panic solidcore's guard catches reaches the engine as EngineError::Internal
smlib's run() catches a solidcore panic and replaces the kernel (kept: the app does not die natively), returning Error::Internal; the kernel turned it into KernelError::Failed and the engine into Other, so hostile_params_never_panic and the fuzzer no longer saw kernel panics. Now the kernel's wrapper errors go through KernelError::smlib, which keeps Internal; a body the wrapper could not take because of a panic is Internal too. A feature whose evaluation hit it records the result as internal (not cached: the kernel was replaced), and the command that made it, or any command whose kernel call returns it, fails with EngineError::Internal under its own id. Crash reports mark a panic inside a solidcore call recovered (kernel::guarded), and the crash test's kernel mode panics inside a solidcore call. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ |
||
|
|
440fdaed13 |
Kernel work runs on threads with solidcore's 8 MiB stack
solidcore's algorithms recurse (subdivision, intersection, filleting) and its README asks for 8 MiB, a native main thread's stack; Rust starts other threads with 2 MiB, and only the web build set more. kernel::KERNEL_STACK is 8 MiB and kernel::kernel_thread a thread builder with it. The kernel's parallel map runs on a pool of its own with that stack (on a worker of a pool already, as in map_with_local_pools, it stays on that pool as before), the one-thread mesh pools and map_on_threads' helpers have it, and so do the engine's interference worker and the evaluator's plan-mesh thread. A test recurses 5 MiB deep on each. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ |
||
|
|
2f483a00c0 |
Drawing text F4: a character missing from the chosen font is drawn with another installed font (#4890) (#10515)
* Drawings: the font a drawing's text is set in, by family (#4890 F1) A drawing names the font family its text is set in (`font`, saved only when set; a pending drawing-format file). `drawing.create` and `drawing.set` take it, and `drawing.inspect` reports it, with `font_note` when this computer sets the text in the built-in font instead ("Futura isn't on this computer: set in Liberation Sans"). Drawings name fonts by family, so they travel: a font file is refused. Paper text finds the family among the installed fonts as sketch text does (`paper_text_in` for given folders), admits each face once a process, and sets a family that is missing or can't be set on paper in the built-in font. Bold takes the family's bold face; the serif flag comes from the face's OS/2 family class. The fixed list of drawing fonts is gone. New drawings made in the app take the interface font when it is a family. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Paper text: any face with outlines is set, and says how a PDF may carry it (#4890 F2) A face is admitted for paper whatever its tables lack: - a variable face is set at its default instance, which is what a PDF draws; - its cap height is the one sketch text scales it by (OS/2, else the top of its `H`, else 70 % of the em); - its PostScript name is what a PDF name can hold of its own, else of its family and style, else `Font-` and the start of its id; - without a `post` table it has no italic angle, and a fixed pitch when every glyph advances alike; - its stem width is measured across its `l`, else taken from its weight. A bitmap or colour-only face, with no outlines to fill, is refused by name. `Font.embed` says how a PDF may carry the face, from its embedding permissions: a subset, the whole face (no subsetting), or not at all (restricted, bitmap embedding only, or CFF2 outlines), when the PDF draws the runs' outlines with their text beside them. Which characters a PDF name may hold is now one rule, `is_postscript_char`, that the record's check and sketch share. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Paper text: a font's family, for readers that pick fonts by family (#4890 F2) `Font.family` is the face's own family name: its typographic family (name ID 16), else its family (ID 1), read from the face itself (in a collection, not the first face), without control characters and at most 255 characters; empty when it has neither. A DXF text style picks a font by it; `Font.id` stays the identity, so two faces of one family are still two fonts (@0xlillith on #4890). The name lookup PostScript names use is one function now, shared by both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fonts: one list of fallback fonts per script, in sketch (#4890 F3) The interface's lists of fonts to try for a script move down to `sketch::fonts::fallback`, so drawings can use the same ones. Each row is a family and the files it's known to be in. The interface reads the files in the order it always did, so what it finds is unchanged. - `CRAFT_FONTS_DIR` joins `font_dirs`, as the interface already has it: `SOLIDCRAFT_FONT_DIRS`, else the pack, then the system's folders. - `font_files` sorts the files within each folder, so a search doesn't depend on how the system lists a folder. - The Windows folder search takes its names from the Japanese list instead of its own copy of them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Paper text: a character its font lacks falls back to a font that has it (#4890 F4) A text on paper was refused for any character its font lacks. Now each such character falls back to an installed font that has it: the script's list in `sketch::fonts::fallback` first, Han by the drawing's language, then the first face in sorted order with outlines and the character. - Runs split by direction, then by font. Every font takes the same em size, on the line's baseline and pitch. A space, a digit or punctuation stays with the run it follows when that font has it; a mark stays with its letter. A font fallen back to is shaped, with the drawing's language. Its nearest style is used: bold or italic isn't refused. - A line its own font has all of is set as it was. - A character no font has is still refused by name. - The last-resort search reads each file's character map alone, stays within `MAX_FONT_FILES`, and keeps its answers, misses too, for the process. - `paper_text_now` is for the window's thread: the search runs on a thread of its own (`font-search`) and it refuses with `FontPending` until the answers are in. `paper_text` searches where it's called. - `paper_fallback_notes` names what fell back, for a drawing's status, from the answers so far: it looks for no font. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
8a730c6273 |
Fillets on solidcore: the largest size that fits is still the one the search builds; the kernel's names the edge
solidcore's fit is the largest size less a margin (34.99 where the L bracket's bend builds 35, 4.29 where #3435's ring builds 4.3), so the feature's search keeps naming the size, and solidcore's is the answer only where the search finds none. The refusal keeps its words, "larger than the faces beside its edges allow", with the edge after them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz |
||
|
|
881899bee1 |
Fillets on solidcore: a blend too large names the largest size that fits and its edge, from the kernel; the crossing-rails mixed corner is not supported (solidcore#2256)
solidcore sizes a blend it refuses as too large (the session's fit, SolidError::FilletRefused under fillet_gn_section_generator). The smlib crate gives it as Error::TooLarge with the size, what it sizes and a point halfway along its edge (an equal chamfer's ball radius turned back into its distance); the kernel words it as the fillet feature's search does (largest_fit_note), and the feature runs no search when the refusal names it. The 3x2 mixed corner whose rails cross, which solidcore refuses (fillet_refuse_mixed_corner_crossing_rails), is not supported yet, citing solidcore#2256. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz |
||
|
|
85be50df0d |
Reference parts: a view shows them by percent, not by a margin (#5866 V5c) (#10713)
reference_margin_mm becomes reference_shown_percent, 0 to 100. At 0 the boundary is the model's box, as before, and no reference part is measured. At 100 it holds the model and all the view's reference parts. Between, each side moves on its own, so a part on one side grows only that side. The model's middle now places a view, not the middle of what it shows, so a view stays lined up with its projected views as its box grows. With nothing grown the two are the same point and the picture is the same. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
21888e8000 |
Drawing views: reference parts in a view's lines and thin on paper (#5866, V5) (#10520)
* Reference parts in a drawing view's lines (V5a, #5866) A body placed through an occurrence that counts as reference is a reference part: one rule, Document::reference_occurrences. Its lines say so in replies. With reference_hides_model off (the default) the model's lines skip reference parts at the one occlusion test, and reference lines test against everything. The two roles merge apart, so a reference line never takes a model line's place on one stretch. Extents come from the model parts when there are any. A sketch curve is the model's: a reference part hides it only as it hides the model. One thing the plan didn't name: reference lines stop at the view's boundary (extents and reference margin) when model parts are there too, which is what the margin is for; a part much bigger than the model would otherwise run off the sheet. Hidden reference lines in a scene are refused until dashed lines (V7b), as the model's are. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Reference parts on paper: thin, under the model's lines (V5b, #5866) Saved views and the snapshot's scene alike, 0.25 mm until the drawing styles slice sets widths by kind of line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Reference parts: tests the planted faults asked for (#5866 V5) A reference line against a model line on one stretch, and against another reference part; one part placed through a reference assembly and on its own; a dimension on a reference part's edge; undoing and redoing a change of type, set on the occurrence or its component; and a saved view's setting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * A test reads any other paper item as no stroke (#5866 V5) Naming Fill alone would stop compiling when #7590 adds a kind of item, with no conflict for git to show. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
9b73ec8d9d |
Display units: every length unit of the expression table shows its own numbers (#4896) (#7809)
A drawing's fixed unit may be any length unit of the expression unit table (expr::UNITS: um, inch, yd, mil and the rest besides a design's five), but the display functions knew only the five and showed the others' measurements as millimetres. unit_scale now reads the same table, so the two can't drift apart again; the five keep exactly the scales they had (1 over 10, 1000, 25.4 and 304.8). The inch rule (a fourth digit when it means something) follows an inch's size, so `inch` reads as `in` does. A design's own units are only the five, so nothing it shows changes. The test that pinned `inch` to millimetres becomes one that checks every length unit of the table shows its own numbers; angle names (`deg`, `rad`) and other text keep the millimetre fallback. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
0d4739fffb |
Drawing dimensions: between two cylinders' silhouettes (#4896, W20b) (#9251)
* Drawing dimensions: a hole's or an arc's centre as a point to measure from (#4896, W20c) A linear dimension's point can be the centre of a circle or an arc, saved as its one edge's name with `centre`. It is found again as construction geometry finds a round edge's centre (`construct::as_circle`), in 3D, so any view can measure it; a split edge is ambiguous, and an edge that is no longer round can't be measured. `drawing.dimension.add` takes `{centre: edge}` wherever a corner goes, and refuses a straight edge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing dimensions: a chain of distances along one line (#4896, W20c) A chain dimension runs through 3 to 64 points in order (corners or hole centres) and reads the distance from each to the next along one line as the view shows it: horizontal, vertical, along a direction, or aligned from the first point to the last. The line runs the way the first point to the last goes, and a point out of order is refused, never moved, so the members add up to the overall from the first point to the last (`drawing_measure::chain`). It reads projected only (true lengths of points off one line don't add up) and shows its members' numbers, never a text instead. `drawing.dimension.add` takes `{chain: {points, direction?}}` and counts the points before looking any up; `drawing.dimension.edit` changes its direction; inspect lists its members, its value being the overall. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing dimensions: a whole cylinder's diameter between its silhouettes (#4896, W20b) A cylinder dimension saves a face by name (ModelFace, as ModelEdge names an edge) and reads Ø between the cylinder's two silhouettes, which any view but one along its axis shows 2r apart (`drawing_measure::silhouette_side`). The face, or the pieces it was cut into, must lie on one cylinder (the kernel's own condition for faces on a common cylinder); every face of the body on it counts, since the kernel builds a whole cylinder as two half faces; and both silhouettes must lie on those faces, so a fillet's quarter round is refused. `Document::face_reference` picks a face by a point on it or by its index; `drawing.dimension.add` takes `{cylinder: {face}}`, edit refuses its settings, and inspect can list face candidates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing dimensions: between two cylinders' silhouettes (#4896, W20b) A dimension between a silhouette of one cylinder and a silhouette of another, as the view shows them. Each is named by a face of its cylinder and by its side: the one nearer the other cylinder on the view, or the one farther (SilhouetteSide). So it keeps to them whichever way round the view shows the cylinders. - geom: drawing_measure::between_silhouettes takes the two cylinders (Cylinder, now geom's: the type doc kept privately), their sides and a direction as a linear dimension takes it (aligned: square to the silhouettes). The silhouettes must be parallel on the view and the axes apart there. Foreshortened when the axes aren't parallel in the model, or the silhouettes lie at different depths. - doc: DimensionKind::Silhouettes { a, b: Silhouette { face, side }, direction }, read as the view shows it. Each silhouette must lie on its cylinder's faces (Lookup::on_cylinder, now shared with the cylinder kind). Document::silhouettes_kind makes two silhouettes of one cylinder of one body that cylinder's diameter (which takes no direction), else the distance between them. - engine: drawing.dimension.add takes {silhouettes: {a, b: {face, side}, direction?}}; drawing.dimension.edit changes its direction only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
693cf911f1 |
Recovery: unsaved drawing work survives a crash (#3890, K9′) (#9289)
* Recovery: a change to a drawing alone is autosaved and recovered (#3890, K9') A design's drawings are part of its document (K3b), so the autosave already sees a drawing's change as unsaved work and writes it with the design, and recovery reads it back. This test holds that: with the model saved, a change to a drawing's properties alone is autosaved, and the recovered design has the drawing as changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Recovery: a drawing that breaks a rule is left out of the autosave and the crash copy, named (#3890) Reading a design refuses it whole for one drawing that breaks a rule of the record, so an autosave or a crash report's design holding one never opened again: all the unsaved work was lost. Both copies now keep the rest of the design (drawing::openable) and name each drawing left out and the rule: the autosave as its error, the crash report in its notes. A design's save error names the drawing it couldn't save too (Drawing::label). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Recovery: a copy that must open keeps a design's drawing rules too (#3890) drawing::openable now leaves out what a read refuses at the design's level as well: the later of two drawings with one id, and the drawings past MAX_DRAWINGS, each named with its rule. So an autosave never keeps a stale copy over a drawing problem. The id rule is take_id, which check_in_design uses too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Recovery: a drawing too large to save is left out too, and the status line names it (#3890) The autosave and the crash copy already leave out a drawing that breaks a rule of the record. A drawing too large to save failed the whole autosave instead; `openable` now leaves it out the same way, before its id, so the rest of the design is kept. Nothing is skipped silently: the autosave's error names each drawing left out, and the status line shows it. Tests: a drawing left out takes no id from a later one; an autosave leaves out one too large to save; an autosave keeps what is hidden; the status line names a drawing the autosave left out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
b21c377296 |
A lost dimension keeps its last value after the design is reopened (#4896 W19d) (#9764)
Dimension::last_good saves the value the session last read, written only when there is one, and a save takes it from the session's reads as it takes what is hidden: no read touches the document, makes an undo step or asks to be saved. drawing.dimension.inspect answers this session's read first, else the file's. resolve_dimensions never sees it, so a lost dimension stays lost. A value past the drawing format's limit is left out of the save, not written into a file that then can't open. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
878bc1b421 |
A point on a curved edge finds it, between the edge's chords (#4896) (#9765)
An edge given as a point looked along the edge's mesh lines, within a point's tolerance, so a point on a circle or an arc that fell between two chords found no edge: a radial dimension on most points of a rim said "no edge at". A point off every chord now takes the edge whose chords are within what its body was meshed to, and only when no edge passes through the point itself, so a point on a straight edge beside a curve is still that edge. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
d01de87552 |
Merge main into drawings (Oct 30)
Brings the 1,270 commits on main since the drawings branch last met it,
including the first drawings landing (#8249), into drawings.
Merged with the drawings snapshot that #8249 landed (
|
||
|
|
bd1525dcfb |
Expressions: hyperbolic functions sinh, cosh, tanh and their inverses (#9332) (#9334)
* claim: #9332 * Expressions: hyperbolic functions sinh, cosh, tanh and their inverses (#9332) `sinh`, `cosh`, `tanh` and `asinh` take a unit-less number and give one, as `exp` does; `acosh` refuses x < 1 and `atanh` refuses |x| >= 1, worded as `asin` and `ln` refuse what lies outside their domain. They are in the expression help (`FUNCTIONS`, the parameter autocomplete), the hostile-expression fuzz tokens, the parameters and equation-curve guides, and the checking skill's list of functions. Horn flares (Salmon's hypex `cosh h + T sinh h`), catenaries and the tractrix can now be written as they are stated instead of expanded into `exp`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
1e5eb1e3b8 |
Sketch: find profiles island by island, so dragging in a large imported logo stays smooth (#6896) (#9313)
* claim: #6896 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013WUFq6QFBqmZjxwaKy2J1M * Sketch: find profiles island by island and say when the search is cut short (#6896) Every live drag frame ran the profile search over the whole sketch: every spline piece of a large imported logo was sampled, checked for crossings and traced again, about 100 ms per frame at 6,000 degrees of freedom. Profile curves are now split into islands whose enlarged piece boxes do not touch (the margin exceeds every tolerance the search uses), each island's loops are found on their own and cached by a fingerprint of its geometry, and the loops are nested into profiles over the whole sketch in the order a single search finds them, so profiles, ids, holes and whole-boundary certificates stay the same. The end-near-crossing lookup covers its whole reach, independent of the grid's cell size. The 50,000-piece limit now holds per island, and a sketch that still exceeds it gets a warning instead of silently missing profiles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013WUFq6QFBqmZjxwaKy2J1M --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
966b10e731 |
Sketch: a feature on a failed sketch names that sketch (#9075) (#9276)
A sketch that failed (a dimension set negative by a parameter) left every feature built on it with "unknown sketch 1 (it must come earlier in the timeline)", which points at the timeline order. The evaluation now notes the features that failed earlier in the pass, and a feature whose input sketch is one of them fails with "sketch `Sketch1` failed: <its error>". That result is never cached, since the cache key holds neither the sketch's name nor its error: a second failing value or a rename shows up at once. |
||
|
|
3d744cc8a2 | A formula that is a bare number gets the design unit (#9261) | ||
|
|
991082fbaf |
Typed contracts for the construction axes, points and planes (#2829) (#7750)
* claim: #2829 (construct.* contracts) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Typed contracts for the construction axes, points and planes The 19 construct.* commands get input contracts and FeatureResult as their output, with shared types for references, planes, a plane or face base, an axis line and a construction plane's name, each calling the reader its handler uses (split out of geo, plane_param, the face capture and named_axis_line). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
6a2bdbf144 |
Bill of materials: virtual components and a typed quantity (#3874, P6) (#9226)
`bom_quantity` is a part property of any component: what one placement of it means, an expression evaluated with the design's parameters (pieces without a unit, else a length). A row's `quantity` is what its placements add up to, with `quantity_unit`; pieces beside a length, or a quantity that no longer evaluates, give none and say why. A quantity is a parameter user: a rename follows it, and a parameter it uses can't be deleted. The CSV gains a `quantity` column at the end. `virtual` marks a component with no geometry (grease, paint, a label): listed with its quantity, weighing nothing. It can't be the active component, and one check after each undoable outermost command refuses any change that puts a body, a sketch or a placed component into one, whichever command made it. A file a damaged virtual component already fills opens, and other changes go on. Mass, volume and area quantities wait for the expression units of #4811. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
413c145c56 |
Bill of materials: stable item numbers, saved with the design (#3874) (#7779)
* Bill of materials types on one occurrence (#3874) An occurrence can count in the bill of materials as another type than its component, for that occurrence only: `bom_type` on the occurrence, set with occurrence.bom_type (one undo step; it changes no geometry, so nothing is evaluated). An occurrence without it counts as its component, so older designs need no step; the format change is one pending file (occurrence-bom-type.rs). assembly.bom counts each placement by its own type: a purchased placement of a kit part is one row without the kit's contents, a phantom placement lists what it holds where it sits, and one component placed as two types gives a row for each. Paste New keeps the types; Paste Instance counts as the component. The compact list and the locales (en, de, ja, ko, zh) carry it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials rows: material, and mass when asked (#3874) Every row of assembly.bom (and every part folded into a row) names the physical materials of its definitions' own bodies, each once, with "; " between several. An unassigned body's is Default. A subassembly or an empty component has none of its own. With mass: true each row also carries mass_g, what one of its parts weighs as the row stands for it, so the rows of any list add up to the assembly once: - at the top level, all it holds; - in parts only, its own bodies, because what it holds is listed beside it; but a folded part's row is the kit (all it holds), a purchased part is all it holds, and an inseparable one all but its purchased parts; - a reference placement adds nothing, nor does anything inside it. It is null when nothing in the part has a body, a body can't be measured or measures a negative volume (inside out, such as an open mesh facing the origin), or the definitions sharing the row's part number weigh differently. Measuring runs the kernel, so it is asked for: the Bill of Materials window re-runs assembly.bom after every change and doesn't ask (0.2 ms without mass, 135 ms with it on a bolted bracket). Placements are rigid, so each definition is weighed once however often it is placed, and each body is measured once with measure_mass (the same volume as measure, without the topology counts' tessellation). A body's material and its density now follow one rule: Document::body_material (new, beside Document::density) is the material its mass is worked out with, named as the library or the design spells it: the assigned one when it is known and has a usable density, else DEFAULT_MATERIAL (new, beside DEFAULT_DENSITY). Document::density is that material's density, with the same values as before. So a damaged file's unknown or broken material reads as Default, as it weighs, and a hand-edited "steel" reads as Steel. The bill of materials uses both; the other places that read a body's material or spell "Default" (component.properties, inspect and others) move to them in a separate cleanup PR for #4783, which brings the same two functions to main. Document::body_owners returns each body's owner in order, so the rows find their bodies in one pass. It no longer repeats the owner rule: model_body_component, legacy_body_component and body_owners go through the rule written once, given how to find a feature's component (the timeline for one body; body_owners still builds its map once). The CSV columns are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Physical properties: a reference placement adds nothing (#3874) component.properties and occurrence.properties now leave out a placement that counts as a reference in the bill of materials (its occurrence's bom_type, else its component's: a fixture shown for context), and everything inside it: no body entry, mass, volume, area, centre of mass or bounding box, and it isn't in placement_count. That is the bill of materials' rule, so a reference part is in neither the parts list nor the assembly's mass, and every bill of materials list still adds up to the assembly's Properties. The placement asked for counts whatever its type: a reference fixture's own Properties still measure it and what it holds, as a component's own bill of materials lists what it holds. Only the totals change. The placements walk that face picking, sketches on placed faces and the occurrence path lookup use stays complete, so a reference fixture's faces can still be picked. The type an occurrence counts as is now written once: Document::occurrence_bom_types (new, beside BomType) gives each occurrence's type in their order, looking each component up once. The bill of materials, occurrence.bom_type's reply and the physical properties use it, in place of the two copies in the bill of materials. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: one module of typed rows in doc (#3874) The bill of materials now lives in solidcraft_doc::bom as the typed rows of a bill of materials view. assembly.bom's JSON and CSV and the Bill of Materials window present those rows; parts lists, item numbers and balloons are to read them too. - list(tree, request) walks the placements below the assembly once. One rule (classify) decides for each placement whether it is counted in a row, how what it holds is walked and what its row stands for when weighed, from the type it counts as, the view and the component's shape. "An inseparable part's purchased parts are listed beside it" is written there once, and the mass walk reads it. - A row carries its identity (RowKey: the rows it is listed under and its lowest member, a component and the type it counts as), its item, count, each, the placements it counts by occurrence path, what it stands for (Holds), its part properties, materials, mass and children. - Mass is a Mass: not asked, grams, or unknown with the reason (nothing to weigh, unmeasurable, the definitions differ). Each definition is weighed once for each kind of row and kept in the Tree. The assembly's total is weighed from the design the same way, not added up from rows, so it is known even when a row's definitions weigh differently. - Bom::row_of(tree, path) finds the row a placement is counted in (a nut inside a purchased bolt is in the bolt's), or says why there is none: no such placement, a reference, or no row of its own. - rows_deep() lists each row followed by its children (1, 1.1, 1.2, 2); Request::default() is assembly.bom {}; View and Group carry the commands' words. What changes, beside that the output is otherwise the same: - One placement budget (100,000) and one depth limit (64 levels) cover the whole list. A folded part's contents used to be walked under a budget of their own, so a design past the limit was listed with group_children; it is refused now, as it already was without it. - Kits are compared by what they hold (part, type and count), not as text: a part without a part number whose id is 12 no longer reads as a part numbered "#12", nor a part numbered "P×1\nQ" as a P and a Q. Kits holding the same parts through different definitions (two bolt definitions, each with its own nut definition of one part number) are one row, and its children count every bolt's placements, where they showed the first bolt's definitions only. - A folded part's row always stands for all it holds. It used to stand for its own bodies when nothing inside it was listed, which differs only for a phantom with bodies of its own inside it. - An inseparable part's row in parts only names the material of what it stands for (its steel blocks read Steel) where it was blank, and a subassembly whose parts share one material names it at the top level. - A damaged file's component placed inside itself is refused at the first level too, since naming a row's material walks inside it, as weighing it already did. - A row's body count saturates, so a compact assembly with more placed bodies than a count holds (a block placed 2^64 times) is weighed instead of overflowing. Materials follow Cameron's rule for a row that stands for an assembly (C3, 2026-10-23): a part's row lists its own bodies' materials, as before; a row that weighs what is placed inside it (a subassembly at the top level, a purchased or inseparable part with parts inside it, a folded part) names a material only when everything it stands for shares it, else none. A frame of steel and aluminium parts reads blank, and a bought bearing of steel parts reads steel. One walk (adding) decides what is placed inside a row's part for both its mass and its materials, and each definition's materials are read once. Components are looked up by id once per list; they were searched for each row and each kit. The window reads the rows directly instead of running assembly.bom after every change, so it no longer adds an entry to the crash journal each time it refreshes. The engine keeps the command, its parameters and the files. Tests check rows. The module's own: an empty assembly, one part, a row named by its lowest member through part-number edits, one part number of two types, a phantom in a phantom, a reference at the root and its own list, the 64-level limit, the budget hit exactly with and without folding, kits told apart by what they hold and the types they hold it as, a folded part's contents not folded again, row_of for every type, every placement in one row or none, a damaged file's missing component and cycle, the mass agreement rule (moved from the engine with row_mass) and what adds to a row. In the engine: the material rule for every kind of row, the JSON against the rows for every option, why a mass is unknown, the total against component.properties in every view, what a row stands for and its placements, and the overflow. The assembly.bom tests from #1888 on pass unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: structured, all levels (#3874) P4: `assembly.bom {levels: "all"}` lists the assembly's direct contents, each subassembly a row with its own rows listed under it, to any depth (items 1, 1.1, 1.1.1), each child counted `each` per one of its parent and `count` in all. - `doc::bom::View::AllLevels` goes through the one rule (`classify`) the other views use: a normal subassembly is a row holding what it holds, listed under it as all levels again; a phantom has no row and what it holds joins the level it sits in, merged with the same parts there; a purchased part is a row with nothing under it unless `show_purchased_contents` (Request::purchased_contents) asks for its contents; an inseparable part is a row with nothing under it; a reference counts nowhere. - The rows under a row are the folded-part rows already built (kits), so subassemblies with one part number and different contents are different rows, and no second nested builder is written. All levels gathers every level as it gathers the first; a folded part's contents are still gathered by part number in the other views. - The JSON and CSV already nest to any depth; `show_purchased_contents` is echoed with the other options. Each row's mass still adds up to the assembly at the top. Tests, worked by hand: four bolts and a two-bolt subassembly placed twice (8 bolts in parts only; in all levels the subassembly twice with 2 bolts each, 4 in all, beside the top's 4); three levels deep (2 x 3 x 2: counts 2, 6, 12, items 1, 1.1, 1.1.1, the CSV in that order); each type (a phantom's bolt merged into its subassembly's, purchased with and without its contents, inseparable, reference); two subassemblies of one part number with different contents as two rows; `levels: "deep"`, a flag that isn't one, and an assembly over 100,000 placements refused. D's test that a folded part's contents are listed as parts only lists them now names the two views it holds for, and checks all levels' nested rows (the subassembly inside the folded part a row with its own rows). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: parts with one part number are one row only when they hold the same to any depth (#3874) The kit compare looked one level down: two parts with one part number whose contents differed two levels below merged into one row, and the children that only one of them held came out at each 0. Each placement now has a kit, a number interned from what it holds (each child's part, type and own kit), built in one pass from the last entry back: an entry's children come after it in the walk, so their kits are known first. Rows are told apart by that number. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: a phantom's own bodies are a row of their own (#3874) A phantom had no row, and its own bodies were weighed in the assembly's total but in no row, so the rows didn't add up. Its own bodies, when it has any, are now a row of the phantom's type that stands for them alone, as a subassembly's own bodies are in parts only; what it holds still counts where it is placed. Inside an inseparable part in parts only, nothing changes: the part's row weighs them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: the assembly's total mass in assembly.bom (#3874) `list` weighed the assembly as a whole (from the design, not added up from rows) and the command dropped it. `assembly.bom` now gives it as `total_mass_g`, and so does a JSON file it writes, only when `mass: true` (null when it isn't known). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: all levels as JSON lists its rows one after another (#3874) All levels nested each level's rows in the row above it: two JSON containers a level, so the 64 levels a list may hold came to 129, past the 128 that serde_json (and so the MCP server and the control channel) reads. In all levels `assembly.bom` now gives the rows one after another, each followed by the rows under it (items 1, 1.1, 1.1.1), as its CSV does; a row listed under another still reads its item as text and gives `each`. A folded part's contents, one level, stay inside its row as `children`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: a row whose definitions weigh something and nothing differs (#3874) A row gathering a definition with bodies and one with none (one part number on a steel block and on an empty assembly) said there was nothing to weigh. Their masses differ, so it says so; only a row where none of them has a body has nothing to weigh. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: definitions agree on a mass within the measurement accuracy (#3874) A row's definitions had to weigh the same to 1e-9, but the kernel measures a volume from tessellations, and one part modelled another way is tessellated differently: a pin made as a cylinder and as a revolved rectangle measured 1.05e-5 apart, so it read as two masses. The bill of materials now has its own `bom::MEASURE_ACCURACY` (1e-4: ten times that gap, with its doc on what it follows: the kernel's `measure` gives one solid's volume to about that, relative, however the solid was modelled), and a row's definitions agree within it. A pin 0.1% wider (0.2% heavier) still differs. The kernel is unchanged: its work is paused while it is being replaced. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials guide: all levels, purchased contents and this round's changes (#3874) The guide had no `levels: "all"` or `show_purchased_contents`. It now has both, with how all levels tells subassemblies apart and lists its rows as JSON, a phantom's own bodies as a row, the assembly's `total_mass_g`, and definitions that agree on a mass within the measurement. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: materials are bodies', as the code says (#3874) The rule stays as built (a row that stands for an assembly names a material only when everything in it shares one), but its comment and the guide said a material set on a component is set on all its bodies. `material.assign` takes bodies only: a component has no material of its own yet. The module notes now say so, and where component materials will join the rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: a body's volume measured once with the evaluated model (#3874) `assembly.bom` measured each definition's bodies anew for every list, and `component.properties` measured each placed body again. A body's measure depends on nothing but the body, so the evaluated model keeps its volume (`ModelBody::volume`, shared by clones, as its outline box is), and both commands weigh that one measurement: the same grams to the bit. A body offset scales it by the size of its determinant (`mat_volume_scale`) instead of copying the B-rep to measure it. The physical properties still measure the placed body for its area, centre, box and counts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: row keys, what rows stand for, members and row_of stay in doc (#3874) Nothing outside `doc` reads them yet: `RowKey`, `Unlisted`, `Holds`, a row's `key`, `stands_for` and `members`, and `Bom::row_of` are crate-private until item numbers and balloons need them, so they can still change without breaking another crate. The engine test that read them is covered by doc's own (`row_of_finds_the_row_a_placement_is_counted_in`, `every_placement_is_in_one_row_or_none`). `Unknown` stays public: `Mass::Unknown` carries it, and a public enum can't carry a private type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Assemblies: one fallible placement walk for totals that cover the whole assembly (#3874) The physical properties walked the placements twice in their own code, with the 64 levels and 100,000 placements written as literals, and the bill of materials gave the same refusal in words of its own. `Document::placements_below` is that walk once, from any placement, refusing what is past `MAX_PLACEMENT_DEPTH` or `MAX_PLACEMENTS` (never walking it in part), and both use its refusal: "the assembly is deeper than 64 levels or has more than 100000 placements". The physical properties now allow 100,000 placements below the start, as the bill of materials does (they stopped at 99,999). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: the same rows for less work (#3874) - Part numbers are borrowed from their definitions (`Part<'a>::Number(&'a str)`) instead of copied for every placement grouped and every kit. - A row's members, the placements' paths, are built only when the list is asked for them (`list_with`, for item numbers, balloons and `row_of`): the walk then keeps paths and moves each into its one row instead of copying it. A list made for its rows alone builds no paths at all. - `row_of` reads an index of member paths, built once with the list, instead of scanning every row's members for each placement asked about. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * occurrence.bom_type: input and output schemas (#3874, #4035) `OccurrenceBomTypeParams` takes the occurrence (an id or a name), its path when given and the type (one of the five, `same_as_component` or null), each read by the handler's own reader: the path through `cmd::path_ids`, split out of `occurrence_path`, the type through `cmd::occurrence_bom_type`, split out of the handler. The handler builds its reply from `OccurrenceBomTypeResult` ({occurrence, bom_type, effective, changed}). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials tests: all levels presented at every depth, and its caps (#3874) - `assembly_bom_presents_the_typed_rows` now covers all levels (with mass, purchased contents and by definition) and the total mass, on a three-level design with a purchased gearbox holding a gear, comparing every field of every row down to 1.1.1.1. - All levels lists 100,000 placements and 64 levels, and refuses 100,001 and 65. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: static materials, typed in for a component (#3874) A value the bill of materials works out can now be typed in by hand for a component (a static value, Cameron's choice of word). Material comes first: `component.metadata.set {component, material}` takes any text up to MAX_TEXT_BYTES, and `component.metadata` reads it back as `material`. It is shown wherever the component is listed, at every level and in every view, over the materials worked out from its own bodies or an assembly's blank, and the row carries `static: ["material"]`. Clearing it (empty text or null) brings the worked-out material back. It is kept the way `bom_type` is: a part property in the component's metadata (`material`), so there is no format change and older releases keep it. `PART_ONLY` names both keys in one place: Design Properties doesn't list them and `document.metadata.set` refuses them. Another tool's non-text value is kept and reads as no static material. The bill of materials says one thing about the part everywhere: a static material also stands for the part in the one material an assembly around it shares (two parts typed in as S355 make their frame read S355; S355 beside plain steel reads blank). A phantom's row is its own bodies, so its static material names those only, and what it holds keeps its own. A row gathering several definitions takes the first one's that has a static material, as its description does. It only names: mass still comes from the bodies. The CSV gets a `material` column at the end, so the other columns keep their places: what the row shows, the static material or the worked-out ones joined with "; ". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: stable item numbers, saved with the design (#3874, P5a) A numbered parts list keeps each row's item number under the row's key in `assembly.item_numbers`, so a row keeps its number when others are added, removed or reordered. New rows take the next number after the highest at their level; Renumber restarts a view in list or item order and leaves locked rows alone; duplicates are marked; numbers change no geometry and are part properties in the undo history. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
8679063629 |
Drawing revisions: rows added, edited and deleted by command, and listed by drawing.inspect (#3874) (#9150)
* cell: rules both kinds of table share (#3874) Sheet tables (parts lists first) use the title blocks' cell content, so the rules both read live in cell.rs: - Source::Row: the row of a sheet table a cell is on. A title block has no rows, so its validation refuses a cell that reads one. - Warning::Width: a word wider than its value box, shown whole, never cut: the width warning that measured text brings. - is_snake_case moves here from title_block.rs: table columns are named by the same rule as cells. check_text is shared the same way. Tests: a title block cell reading a row is refused, beside other parts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 640cc3e0f5e6b03366b9e231e62cd0b0229f32c6) * Sheet tables: the parts-list table model and layout (#3874, P7a) A Table is a sheet table's definition: its columns, the side its heading is on (top, or at the bottom with the first row just above it, ISO 7573), its row height (7 mm by default), text height, line widths, a filter and overrides. A column's cells are the title blocks' cell content read against each row: row fields and text. Rows are input, in their listed order, with their values worked out and formatted, so a filter (parts, assemblies, purchased, text per column ignoring case) hides rows and never changes a count or a quantity. Table::layout places it with a text measurer, from the right end of the heading's outer edge: - a column without a set width is as wide as its widest line, padding and line insets added; a set width is kept; - every cell in a set-width column breaks between words to fit, and its row grows to hold its lines, 10/7 cap heights apart (ISO 3098-0); a word wider than its column is shown whole with Warning::Width; - a row field the row doesn't have shows "-"; an override shows its text and keeps the value it replaces, an empty one is a blank cell, and one for a row that has gone is kept; - cells sit inside their lines as a title block's do. Limits, refused and never truncated: 10,000 rows and overrides, 64 columns, 1 MiB of text in all (each cell's text counted before it is built), 256-byte keys, a measured width that isn't finite and at least 0, a table off the paper's coordinates. Nothing is saved or drawn yet: the real measurer, DXF and CSV output and the command come with P7b. Tests: hand-worked cell corners and text anchors with a fixed-width measurer, the heading at the top and at the bottom; wrapping and the row it grows; a word too wide; overrides, blanks, "-"; each filter leaving every shown value as given; JSON round trip, defaults and unknown fields; every limit and one past it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 0c5180267d0cd53b06ef13c91d4be43173f2e6d7) * Revision record and table (#3874, W31, P14a) A drawing's revisions as data (geom::revision): one RevisionRecord for the whole drawing, or per sheet with each sheet numbered apart. - A row holds what people type: revision, description, designer, checker and date. Adding a row fills in only the next revision; nothing fills in a date, a checker or an approval. - Numbers run from 1, or 0; letters run A to Y without I, O, Q, S, X and Z, then AA, AB. The next revision follows the highest in its scope among the rows and the issued history, so an issued revision is never given out again. A typed revision is kept as typed; in letters one with a skipped letter is accepted with a SkippedLetter warning. - Rows are added, hidden and deleted; issue() appends a copy of a row to the issued history, which nothing removes or changes (private, read through issued()). Row and tag ids come from the caller (the design's random ids), never from a counter, so two people adding rows never take the same id; an id in use is refused. - Triangular tags bind to a row id and show its revision or their own text; deleting a row reports its tags, which keep the revision they showed, marked lost. - The revision table is the sheet table (table()): Revision, Description, Designer, Checker, Date, heading at the top; hidden rows are left out. The table's rows and a title block's revision fields (newest(), hidden rows included) read RevisionRow::field, one path. This is the drawing's revision only: the model's revision and the export time are kept apart. Release, approval and frozen snapshots (G16/G22) are not in this slice. Nothing is placed or saved on a sheet yet (W12, W15). Tests: numbering both ways with the skips and past Y and YY, typed revisions and the warning, the next after issued and deleted rows, per sheet; add fills in nothing else; history kept through hide and delete; tags reported and lost; the title block's fields and the table rows from one function, laid out by the sheet table; JSON round trip, unknown fields and damaged records refused; the caps; an id in use refused. - An issued copy keeps the model version it was issued against (model_version, given to issue(); none until version control gives versions, #2869), so the release step has its field here. It is read by the label rule, like the revision. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit fa7849ada783c91f2ca52fb4a11687cf1a71de77) * Drawing revisions: rows added, edited, deleted and listed by command (#3874, W31) A drawing saves one revision record for all its sheets (Drawing::revisions, behind an Arc as the sheets are, so an undo step shares it; validated with the drawing; its ids among the drawing's ids in use), in the order its rows were added, the newest last. Pending drawing format: revisions. - drawing.revision.add {set?}: a row with the next revision, after the highest the drawing has given, and any texts given: one undo step. - drawing.revision.edit {row, set: {revision?, description?, designer?, checker?, date?, hidden?}}: the texts as typed (a revision is one line) and what changed; a revision in letters with a letter the lettering skips is kept and warned about. - drawing.revision.delete {row}: the row, and the tags it leaves showing the revision they had. - drawing.revision.list: every row, the oldest first, and the revision a new row gets. An id's text form (13 characters of lowercase Crockford base32) moves down to solidcraft_geom::ids, with an option helper, so the revision record (geom) writes its row and tag ids as every drawing id is written; solidcraft_doc::ids gives them on, beside IdSource. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing revisions: listed by drawing.inspect, a table row keyed by its id's text, and a record per sheet tested (#3874, W31) The rows show in drawing.inspect beside the sheets, as `revisions: {rows, next}`, from the same function the revision commands answer with; drawing.revision.list goes, so a drawing's rows have one place to be read. A revision table's row is keyed by its id as a file writes it, the one spelling every drawing id has (a table's cell overrides name a row by its key). A record kept per sheet whose rows keep its own rules is refused by the drawing, so that rule has a test of its own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |