e4844753cb9a836cda170d2a416412b3ca875ff1
615
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
cc9d76cd86 |
Tapered cut: run on less, then start on the face, when the run on closes a small corner (#4825) (#4858)
A cut starting on a face of its target runs its tool on behind the start plane with the tool's slope. A taper that widens the pocket narrows the tool there, and a corner arc smaller than the run on times tan(taper) closed: "the taper closes the profile", though the pocket itself only grows. The run on is halved, quartered, then dropped (the tool starts on the face with its straight foot) until the tool builds. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
ad8b2f91bb |
File: a saved model whose booleans retried is taken on opening (#5286) (#5334)
A design file keeps its evaluated model so that it opens without
evaluating the timeline. A feature whose boolean needed a retry records
it, and the kernel's BooleanDiagnostics leaves `rejected` out when it is
empty but has no default for it when read, so reading those records
failed ("saved model: diagnostics"), the saved model was refused, and
the design was evaluated on every open (17.6 s for the reporter's
17-feature design, 1.2 ms with this).
The reading side now takes an absent list as an empty one, without a
change to the kernel crate.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
||
|
|
46f24f2394 |
Save the browser's view with the design, and an option to hide the origin by default (#1849)
The Origin folder's eye, a finished sketch's Show Profile and Show Dimensions, and body locks move from UiState into the design's saved visibility (origin_hidden, hidden_profiles, shown_dimensions, locked_bodies), so each tab keeps its own and they survive closing the design. The Sketches folder uses the saved browser folder (c0/sketches in hidden_folders); ui.set/ui.inspect keep showOrigin, showSketches, hiddenProfiles, shownDims and lockedBodies. Preferences > Design > "Hide origin by default": a design that never toggled its Origin eye follows the preference. New fields are a pending format change (format/pending/browser-view-state.rs). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
9e6e0b8df1 |
Render workspace: complete experimental ribbon, resources and effects integration (#5493) (#5494)
* wip(render): reconcile completed material and image pipeline source with 0.20 (#5493) Source-only integration reference for staged review, not a merge-ready aggregate. Donor: 0xlillith/solidcraft@aea20b0115. Upstream: |
||
|
+33 |
b7b25f9e2b |
Render workspace: first basic delivery to main (#6050)
* Normalize UI container violation paths across platforms (#5599) Report repository-relative paths with forward slashes so diagnostics and the existing nested-package regression assertions agree on Windows and Unix. Keep the container detection rules unchanged. Validation: official ui-containers gate and all seven focused xtask tests passed; rustfmt and diff checks passed. Only xtask/dependencies were compiled; no application build or heavy tests. (cherry picked from commit |
||
|
|
19db763899 |
Tapped Hole: verified metric fine, UNC/UNF and parallel G/Rp catalogues (#4178)
* feat: expand tapped-hole catalogue with metric fine and Unified sizes * docs: distinguish metric designations from expanded tapped catalogue * feat: add internal pipe catalogue and checked Rc profile data * Connect parallel G and Rp catalogues to cylindrical tapped holes * fix(i18n): register tapped thread catalogue labels * fix(i18n): complete thread labels in required locales |
||
|
|
9a737bd63c |
Linked components: joints keep their face after Update Links (#3330) (#4874)
* claim: #3330 * Linked components: joints keep their face after Update Links (#3330) A linked design comes in as STEP text, which keeps no face names, so the faces of its bodies were named by their place in the file (`face:<k>`). An edit of the part that adds a face earlier in the file (a second hole of the same size) gave that place to another face, and a joint on the linked part moved there silently. When a link is made or updated, each imported face is matched to the part face it was written from (the same geometry), and the Import feature keeps that face's name in the part (`Feature::link_faces`, a new pending format change). The linked face is named `F<import>🔗<digest of that name>`, pieces keeping their qualifiers, so references follow the part's own history through Update Links as they do inside the part, and a face the part no longer has is reported. Linked faces still answer to `face:<k>`, so older references keep resolving; Update Links warns about joints that use them and reports joints that no longer solve. * Linked faces: a solid's twin keeps its own names; renamed faces count as an update Two solids of a part alike in one place each take the names of the solid the file names them after. Update Links reports a link whose part named its faces differently since as updated (a joint may follow that name to another face), not as unchanged; only a link getting its first names stays unchanged. * Linked faces: Extract to File carries the design's face names too Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: MateuszSychXpl <151755914+MateuszSychXpl@users.noreply.github.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
4dc30c092d |
Mirror and pattern: a pattern or mirror feature as the source (#395) (#3998)
* claim: #395 * Mirror and pattern: a pattern or mirror feature as the source (#395) A pattern or mirror of features refused another pattern or mirror as a source ("Pat cannot be patterned or mirrored yet"). Such a source now stands for what it copied: its own sources are replayed at each of its transforms moved by each of ours, to any depth up to eight. Copies of a feature picked directly keep the instance numbers they had, so existing designs keep their face names; copies made through a nested pattern or mirror are numbered after them, so one feature reached two ways never names two copies alike. A pattern or mirror of bodies as the source is still refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
e67ae66f3e |
Renaming a parameter follows it into sheet-metal and plastic rules and canvases (#4420) (#4423)
* claim: #4420 * Renaming a parameter follows it into sheet-metal and plastic rules and canvases (#4420) Document::rename_param rewrote other parameters, feature inputs, dimensions, configurations and joints, but not the expressions of sheet metal and plastic rules or the plane a canvas lies on, so after a rename the sheet metal and plastic features using them failed with "unknown parameter" and the canvas left the view. It renames them there now, and param_users lists them (a rule's field, a canvas's input), so a parameter they use can't be deleted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Parameters: rules' features in drives and the graph; shared rule field lists (#4420) A sheet metal or plastic rule that uses a parameter makes the sheet metal (or plastic) features rebuild when it changes, so parameters.users lists them in drives and parameters.graph links them. SheetRule::fields/fields_mut and PlasticRule::fields_mut replace the hand-written copies of the rules' fields in params.rs, eval.rs and sheet.manage_rules. Suggested by @CamWight. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fmt (#4420) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
807e367bdb |
Hole: place a Single hole by distances from reference edges (#37) (#2931)
A Single hole can take up to two straight edges of its face as references,
each with the distance of the hole's centre from that edge's line, measured
in the face's plane. `solid.hole` takes them as `references: [{edge, distance}]`;
the edges are found again by their persistent names, else their points, so
the hole follows them when the part changes, and each distance is a
parameter. A bad reference (no edge there, a curved edge, one square to the
face, parallel edges, a negative distance, a centre off the face) is refused.
In the Hole dialog, Reference 1 and 2 follow the face, each with its Distance
row; the canvas shows each distance as a dimension from its edge to the hole,
with a box just past the edge to type it in. Picking an edge measures its
distance (and its box takes the keyboard), typing one moves the hole, and
moving the hole measures them again. Edit Feature picks the edges again with
their distances.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
||
|
|
fc3e3b6c8d |
Join: say so when the joined piece doesn't touch the body (#4434) (#4436)
* claim: #4434 * Join: say so when the joined piece doesn't touch the body (#4434) A Join (extrude, revolve, sweep, loft, pipe, coil, primitives, thicken, boundary fill, surface network) whose material meets none of its targets still joins it to the first target as a separate piece. The result stays as it was; the feature now warns: "the joined piece doesn't touch `Body1`, so `Body1` is now in 2 separate pieces (New Body makes it a body of its own)". History marks it and the command reply carries it. The check compares pieces (outer shells, not voids) of the bodies the feature changed or absorbed before and after it, so it holds for the batched multi-profile path too, stays quiet for a join that bridges pieces or closes a cavity, and leaves Combine (which joins the bodies it is given) alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
d2eb8cf639 |
Timeline: suppressing a feature keeps later features' body names (#4302) (#4311)
* claim: #4302 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Timeline: suppressing a feature keeps later features' body names (#4302) Bodies numbered by the counter (`BodyN`) take the next free number on every recompute, so suppressing a feature that made one moved every later counted body down one (`Body2` became `Body1`) and broke what named it, such as a Move of `Body2`. timeline.suppress now stores the current names of later features' counted bodies in their `body_names` first, as body.rename already does for a renamed counted body (#1109). Engine only: no evaluation or design-format change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Timeline: a body made while a feature is suppressed keeps its name (#4302) Suppressing a feature freed its counted name (`Body1`), so a body made meanwhile took it and became `Body3` once the feature was back. Suppress now also stores the suppressed feature's own counted names, and the evaluator adds the names stored on earlier suppressed features to the state's `reserved_body_names` (the names a rename freed, #4957), which the `BodyN` counter passes by. They are taken from the design before each feature is computed and are part of the state digest, so a cached result is only reused when they match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
2e5924ed5e |
Preserve construction references when axes and points are renamed (#4419) (#4449)
* claim: #4419 * fix: preserve renamed construction references (#4419) |
||
|
|
0dffb206b1 |
Assembly: ground the first part; drag free joint chains (#2804) (#2805)
* assembly(feat): ground first parts and drag free joint chains Ground the first top-level part when it is created and let face dragging reposition free occurrences or any member of a floating joint chain in one undo step. Preserve exact repeated-placement frames, joint values, modifier selection and Escape cancellation. Keep the accumulated fixture, viewport layout and documentation integration fixes from the existing PR. Signed-off-by: Karl Von Richter<karl@embeint.com> * assembly(fix): update movable fixtures for first-part grounding Accept the documented grounded override in component creation, explicitly free movement fixtures, and keep linked clipboard pastes movable even in an empty document. Cover first and reused linked pastes, default insertion grounding, and single-step undo in the existing link tests. Signed-off-by: Karl Von Richter<karl@embeint.com> * assembly(test): keep the motion-cost crank free Unground the first component in the document-level joint-face measurement fixture so its motion samples can rotate after first-part grounding. Preserve the rotation and shared-measurement assertions that caught the Linux CI failure. Signed-off-by: Karl Von Richter<karl@embeint.com> * assembly(test): free the frame placement fixture Create the frame-member placement fixture ungrounded before moving it above its root sketch. Keep its world-space member assertions while respecting first-part grounding in the frame tests added on main. Signed-off-by: Karl Von Richter<karl@embeint.com> --------- Signed-off-by: Karl Von Richter<karl@embeint.com> |
||
|
|
bb155d446a |
Tests: moving an occurrence recomputes only the cuts and joins it touches (#4965) (#4982)
* claim: #4965 * Joins and cuts follow only the placements they depend on (#4965) Tests that turning a joint between parts cuts no hole again, and that a tool cutting another part cuts again when that part moves relative to it, while an unrelated part moving keeps the result. Booleans and Combine now hash only the placements of the bodies they take as inputs, relative to the frame that evaluates them (#3397), so these pin that behaviour for joins and cuts with named targets across parts. |
||
|
|
e1bf784014 |
Deleting an inserted file removes its components, placements and joints (#4100) (#4113)
* claim: #4100 * Deleting an inserted file removes its components, placements and joints (#4100) A STEP or mesh file inserted into a design makes a component tree. Deleting its feature left that tree behind: the components, their occurrences, the rigid joints that hold them and the bodies' component assignments. A later body that took an imported body's name was then placed in the stale component. Document::remove_component_tree removes a component subtree and everything that refers to it: the features made inside it, its occurrences, the joints on them with their motion links, joint origins, contact set members, motion study keys and exploded moves, body component and offset entries, standard part and link records, and configuration columns. Deleting an inserted file's feature and component.delete both use it; component.delete now also removes joints left pointing at a deleted occurrence. The body transfer refusal moves with it, unchanged. * Only an inserted file's feature takes its component tree when deleted Mark the feature a STEP, IGES or mesh insert makes (`inserted`), and remove the component tree on delete only for those and for a linked design's feature. Deleting a copied component's independent base deletes just that feature, as before. Older designs get the mark as they open (pending format change), except copied components' independent bases. |
||
|
|
3093ce1d87 |
Renaming a body keeps the evaluated timeline, off the window thread (#2467) (#2468)
* Renaming a body that later features change evaluates nothing (#2467) Model::rename_body now keeps the results when later features change the body (a pattern, a chamfer, a join). It still evaluates when a body of that name comes and goes or isn't the same body throughout, when a later body's name is worked out from it (X (2)), or when a message quotes it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Rename box: rename off the window thread, and locked bodies follow a rename (#2467) The rename box commits body.rename through run_heavy, so a rename that still evaluates later features (one names the body in its targets) computes beside the window instead of freezing it. Locked bodies now follow a body.rename from anywhere (the rename box, the control channel, scripts), not only the rename box. --------- Co-authored-by: bherbruck <brennen.herbruck@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
426f8ddd18 |
Rectangular and circular pattern: copies that miss the body are reported (#3042) (#3919)
* claim: #3042 * Warn when cut pattern copies remove no material A rectangular or circular pattern whose copies miss the body succeeded silently and those copies did nothing. The pattern now reports how many of its cut copies removed no material, and keeps the copies that land. |
||
|
|
27d2fe6ec0 |
Frames: profile library, members along frame sketch lines, and the Frame Member dialog (#4003) (#4004)
* claim: #4003 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Frames: the profile library (#4003) The first slice of frames and weldments: the cross-sections structural members will be made of, each SolidCraft's own parametric definition built in code (no vendor or standard size tables are shipped). - solidcraft_doc::frame: bar, round bar, rectangular and round tube, angle, channel, I-beam and a generic T-slot extrusion as exact line/arc regions, with defaults worked out from the profile's size, refusals that name the dimension that does not fit, anchors and placement, and exact section properties (area, centroid, Ixx/Iyy/Ixy by Green's theorem). - frame.profile.list, frame.profile.properties (with mass per metre for a density) and frame.profile.insert (draws a profile into a sketch, locked by default, at a point, anchor and angle). - Tests against hand-computed values (rectangles, circles, composite rectangles by the parallel-axis theorem, fillet spandrels), hostile input, extrusion volume, undo; catalog entries in every locale; docs/frames.md; ROADMAP M15. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Frames: drop the built-in T-slot profile (#4003) Aluminium extrusions and other vendor sections come from the user's own sketch (drawn or inserted from the vendor's DXF), so the library keeps the plain steel shapes only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Frames: members along frame sketch lines (#4003) frame.member lays one body per straight line of a frame sketch (2D lines or 3D sketch lines), its cross-section square to the line from end to end: - profile: a built-in profile, or profile_sketch, a sketch whose material (nested loops alternating, so two circles make a tube) is the section in its own x and y around its origin; profiles picks override it. - anchor (origin, centre, centroid or a bounding-box corner or edge middle), angle (an angle expression, so a parameter), mirror. - Orientation: the profile's y as near world up as the line allows, x square to both; a vertical member's x is world X (frame::member_axes). - Members follow sketch and parameter edits, undo as one step, save and reopen (format: pending/frame-members.rs), and are named after the profile (Rect Tube 40x40x3, (2)…), numbering on past names already taken. Tests against hand-computed volumes and bounding boxes (rectangle, 3D tower lines, parameter edit, sketch tube profile and picks, anchor/angle/ mirror), refusals, undo/redo and reopen; walk fixtures and goldens; docs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Frames: fixes from the adversarial review (#4003) - Default member lines are what was drawn: projected and other linked curves and 3D wires (a face sketch's edges) and lines of no length are left out. - A profile sketch's material starts from its drawn profiles, as solid.extrude's "all" does, so a section sketched on a face works; the even-odd test uses outlines and boxes worked out once, capped at 256. - Member names are pinned to their lines (`names`, by line id; `body_name` is the base): deleting or adding a line, or deleting another feature, no longer renames other members, and frame.member stores every name it gives. body.rename renames a member on its line (also for later member features); a copy whose body_names were set still names its members by position. - Built-in profile dimensions are expressions (ProfileSpec): they follow parameters, bare numbers take the design's units, and they are feature inputs. frame.profile.properties/insert read them the same way. - Default root/toe radii shrink to the room a thick section leaves; radii given are checked by name; a radius must be 0 or at least 0.01 mm; error messages report the wall or flange value given, not twice it. - A line within 1e-6 rad of vertical orients as vertical, so rounding never turns a post a quarter turn. - A 2D frame sketch in a differently placed component is mapped into the member's frame, and member features recompute when placements change. - Caps before lookups for a design's `lines`; a line listed twice is refused; a 3D wire that runs back on itself is not a line. Regression tests for each, from the review's scenarios. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Frames: the Frame Member dialog on the ribbon (#4003) - Frame Member (MODEL > Create) opens a dialog: the frame sketch's lines picked in the view (or All Lines), a built-in profile and its dimensions or a section picked in another sketch, anchor, angle, mirror and name, with a live preview. Edit Feature reopens it filled in. - Lines picked in the view keep their sketch (a SKETCH_LINES input picks ExternalSketchCurve): line ids are each sketch's own, so two 3D sketches both have a `w2`, and the members went on the newer sketch's lines. - timeline.redefine takes frame.member. Members keep their names through an edit unless it gives them a new body_name; frame.member takes `names`. - A member whose section is a whole profile sketch keeps it when edited (the dialog shows the sketch instead of picking every region, which would fill a tube's hole). - An original frame_member icon, open for review, on the ribbon, timeline and browser. - The angle profile is listed as L-Angle, and web and flange as Web/Flange thickness, so they translate apart from the existing Angle, Web and Flange; the dialog's labels are in en, ja and zh. en-GB no longer repeats the frame command labels it spells the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
5d92ad1e23 |
Renaming a plane keeps its projections, canvases and hidden state (#4353) (#4354)
* claim: #4353 * Renaming a plane keeps its projections, canvases and hidden state (#4353) timeline.rename only renamed the feature in other features' references. A sketch's projection of a construction plane, a canvas placed on it and the hidden list keep it by name too, so they lost it: the sketch warned that the plane no longer exists, the canvas left the view and a hidden plane showed again. Document::rename_feature_keys renames it in sketch links and canvases, as rename_body_keys does for bodies; the selection follows in the command, and the hidden list in Session::refresh_from, so a hidden plane stays hidden through undo and redo too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
a51dfc9e1f |
Release 0.21.0-rc.2 (#5691)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
17bac141c8 |
An intersect that would leave nothing is refused instead of deleting the body (#5295) (#5303)
* claim: #5295 * An empty intersect is refused instead of deleting the body (#5295) An intersect whose boolean came out empty removed the target body and reported success. The shared evaluator now refuses it when nothing of a named target would remain, when nothing of any target would remain, or when the tools meet a target and the result is still empty. An unnamed target the tools miss altogether is still removed, as an intersect with every body does (#5160). Sheet metal flat machining follows the same rule. * Sheet metal: an intersect with already removed material is refused (#5295) |
||
|
|
3ed1829cc7 | fix: retain circular sketch pattern Quantity expressions (#4435) (#4607) | ||
|
|
61360c3b0d |
Convert to Sheet Metal: a bend picked on its tangent edge connects, on rotated parts too (#4328) (#4630)
* claim: #4328 * Fix sheet conversion picks on tangent bend edges (#4328) Resolve cylindrical bends through the nearest edge's incident faces when a pick on a tangent boundary resolves to its planar panel. This keeps valid remote bends connected, including picks on the other skin of a shell. Keep conversion geometry and picks in the body's local frame, and format conversion diagnostics through its world placement. Cover rotated bend picks and disconnected-pick coordinates with synthetic regressions. |
||
|
|
96ce31153c |
Pattern and mirror: a rib as the source (#4593) (#4667)
* claim: #4593 * Pattern and mirror: a rib as the source (#4593) A pattern or mirror of features refused a rib as a source ("Rib1 cannot be patterned or mirrored yet"). A rib's walls run until they meet the body, so each copy is built again where it is: the rib's sketch is moved by the copy's transform and the walls are run against the bodies there, as a hole is drilled again at each copy. The copies join the body, as the rib does. The rib's own tool building moves into rib_tools, which the rib feature calls unmoved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
a9c3c8bb8a |
Accept a leading = in expressions, so a fillet radius can be =d3 (#4681) (#4686)
* Sketch fillet radius: accept a leading = in an expression (#4681) * A second = after a name is still not a definition |
||
|
|
9559ad398a |
Physical material: one rule for a body's material and its density (#4783) (#4785)
* claim: #4783 * Physical material: one rule for a body's material and its density (#4783) inspect.measure, component.properties, occurrence.properties and the Properties window took a body's material name from the raw assignment, but its density from Document::density, which falls back to the default material when the assigned one is unknown or has an unusable density. So a damaged or hand-edited design read one material and weighed another: a design material "Broken" at -3 g/cm³ read "Broken" at 1.29 g/cm³. One rule, in one place: - DEFAULT_MATERIAL (new, beside DEFAULT_DENSITY in the material library) is the default material's name. The library's first row uses it. - Document::body_material (new, beside Document::density) is the material a body's mass is computed with, as the library or the design spells it: the assigned one when it is known and has a usable density, else DEFAULT_MATERIAL. Document::density is that material's density, with the same value as before for every input. inspect.measure and the physical properties name body_material. inspect.measure now names every body's material, measured or not, since naming it takes no measuring; the density stays with the mass, on the bodies measured. So the Properties window shows the engine's name without a fallback of its own. The places that keep the assignment as stored (configuration cells, material.assign, material.edit, material.delete and the dialogs) only use the constant, so a configuration still keeps a damaged assignment as it is. The visible change: a body whose material is unknown, or has an unusable density, reads "Default", the material it weighs, and a miscased name reads as the library or the design spells it. A body inspect.measure can't measure now has its material too. Masses and densities don't change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
e33c371e99 |
Model cache: thin the checkpoints of a design too big for its file instead of leaving the cache out (#3220) (#4882)
* claim: #3220 * Model cache: keep fewer states of a design too big for its file instead of none (#3220) A model cache over the container's budget keeps the final state, then the slowest features' states while the bodies they add fit (a body several states hold counts once), and is left out only when not even the final state fits. Opening evaluates just the features whose state the file left out, each from the state before it, so the model is whole afterwards. * Model cache: keep each encoded body apart, copy only what a cache stores Encoding a model too big for its file no longer copies every distinct body into one buffer before thinning: the payload is copied from the encodings once its size fits, so saving holds no more than before. * Model cache tests: canonical runs in the timeline fixture; rustfmt * Model cache: count the records a thinned cache keeps; always try the final state Thinning counted only the bodies, so a model of many copies of one part (records, not bodies, filling the room) shrank its budget to nothing and saved no cache although its final state fitted. The choice now counts the records of what it keeps, always keeps the final state, and says what it counted, so each retry keeps less and the final state alone is always tried. * docs: a thinned model cache counts its records and always tries the final state * Model cache test: the slowest feature's state holds bodies 16 to 23 * Model cache: thinned opens with fingerprints that read the state before a feature Since #3397 a feature's fingerprint reads where the bodies before it lie. After a state the file left out, adopt takes the saved fingerprint and the evaluation that works the state out checks it. A result evaluated ahead is never taken as one the file left out. The thinned round trips include the placed components' design, whose cut reads those placements. --------- Co-authored-by: MateuszSychXpl <151755914+MateuszSychXpl@users.noreply.github.com> |
||
|
|
f120285c96 |
Fix design format 33 for 0.21.0-rc.1 (#5610)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
c3d1ce8237 |
Opening a design: range-check integer-valued coordinates too (#5021) (#5026)
* claim: #5021 * Opening a design: range-check integer-valued coordinates too (#5021) The file-level number check skips every integer-valued number so that ids and counters may be large, which let a coordinate such as 9223372036854775808 through. The typed design is now checked as well: float fields (coordinates, sizes) are serialized as floats and must be within the same +-1e9 limit, while integer fields stay integers and are not limited. |
||
|
|
567bc50723 |
Snap fit: refuse sizes too small to build (#5022) (#5027)
* claim: #5022 * Plastic features: refuse sizes under 0.01 mm (#5022) A snap fit with a near-zero thickness (1e-9 mm) got past the size checks, which only asked for a positive number, and panicked in the kernel's intersection code. The boss, lip, groove and rest had the same gap. Every length of a plastic feature that becomes geometry (snap fit length, thickness, width, catch_depth and catch_length; boss diameter, height, hole_diameter, hole_depth and rib sizes; lip and groove width and height; rest width, length, height and thickness) must now be at least 0.01 mm. The check sits where the feature is evaluated, so a parameter changed later is refused the same way, and the message names the parameter. |
||
|
|
1a5fcd05d6 |
Extrude and loft: refuse duplicate profile indexes (#5023) (#5028)
* claim: #5023 * Extrude and loft: refuse repeated profile indexes (#5023) `profiles: [0, 0, ...]` with 10 000 copies built 10 000 identical bodies in about 35 s, and a loft section listing one profile 10 000 times took 25 s before it was refused. A list of profile indexes now refuses a repeated index while it is parsed ("profile 0 is listed twice"), as offset association ids already were. Before the profiles are resolved, a selection naming more profiles than its sketch has, an index the sketch doesn't have, or two points in the same profile is refused too. A design file that repeats an index still opens, using the profile once. |
||
|
|
2bf3d4e11f |
Release 0.21.0-rc.1 (#5566)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
92d1331978 |
A renamed body keeps its number: the next body does not take the freed name (#4957) (#5053)
* A renamed body keeps its number (#4957) The design's body counter starts over at every evaluation, so a body renamed after a join (the join changed it, so the rename cannot be followed without evaluating the design again) gave its number back: the next body took the name the rename freed, and a script that names a body found another one. The design now saves the names a rename freed, and the counter skips them. * A renamed body keeps its number (#4957) The design's body counter starts over at every evaluation, so a body renamed after a join (the join changed it, so the rename cannot be followed without evaluating the design again) gave its number back: the next body took the name the rename freed, and a script that names a body found another one. The design now saves the names a rename freed, and the counter skips them. * Format |
||
|
|
4256775274 |
Joint: avoid redundant analysis and residual placement work (#5185) (#5186)
* claim: #5185 * Joint: reuse residual placements and skip discarded mobility reports (#5185) |
||
|
|
63d81cc096 |
Motion Trace: regenerate kept curves only when inputs change (#5248) (#5270)
* claim: #5248 * feat(motion): regenerate kept traces when source inputs change * feat(motion): add a parametric Chebyshev trace demo * perf(joints): reuse face measurements across motion samples Face-centred joint origins called Body::faces on every solve, bypassing the reference-mesh reuse used for rigid placements. Share face measurements with unchanged model geometry at the existing tolerance, while guarding replaced bodies and applying offsets after the cached measurements. Cover repeated named/nearest-face solves, shape edits, retained snapshots and direct replacement with deterministic work counts. The 145-point Chebyshev dimension and range updates retain identical sampled and interpolated curves. * perf(naming): skip preparation for cached face names Both face lookup paths spawned fresh workers over every body even when their name cells were ready. Prepare only cold cells, with direct handling of zero or one cold body. Preserve the existing parallel naming path and all face selection semantics. Deterministic regressions cover repeated picked and unique-name lookups, misses, partial warmup, renames, snapshots and moved copies. Release Chebyshev medians fall from 859 to 50 ms for a dimension edit and 871 to 34 ms for a sweep edit; all 145 samples and interpolated points remain identical. Full cargo xtask ci passes with RUST_TEST_THREADS=4 and the existing local Windows validation overlays. |
||
|
|
b0048a6104 |
Mesh bodies: measure their size once, when made (#4662) (#4663)
`Body::size` walked a mesh body's vertices on every call, and it is asked for every frame. A mesh body's triangles never change after `mesh_body` or `mesh_transformed` makes it, so both now measure it then (`TriMesh::span`) and `size` returns it like a B-rep body's. `ModelBody::mesh` returns a mesh it already has before working out the display tolerance. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> |
||
|
|
030187452a |
Release 0.20.0 (#5118)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
3b982ca371 |
Prevent deleted item IDs from being reused (#1016) (#3641)
* claim: #1016 * Prevent deleted design item IDs from being reused |
||
|
|
aaa110218b |
Edit Offset Plane: keep a face base, refuse a plane on itself (#3567) (#3889)
* claim: #3567 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019Yz6dHZiXcgTgrxjVNC6hx * Edit Offset Plane: keep a face base, refuse a plane on itself (#3567) Reopening an Offset Plane built on a face looked the face up at the plane's origin, which can lie off the face, so the Plane input came up empty. Look it up at the point picked on the face. A redefine that builds a feature on itself is refused with a plain message instead of failing with "plane offsets nested too deeply". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019Yz6dHZiXcgTgrxjVNC6hx --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
26ca82735b |
Circular Pattern and Revolve: a construction axis can be the axis (#2885, #4506) (#3796)
* claim: #2885 * Circular Pattern and Revolve: a construction axis can be the axis (#2885) The dialogs send a picked axis by its name, but solid.pattern.circular only knew X, Y and Z, and solid.revolve / surface.revolve read any other name as a sketch line id. Picking a construction axis therefore failed. - solid.pattern.circular takes a construction axis name, saves it as `axis_feature` and turns about the axis as evaluated, so the copies follow it when it is edited. - AxisRef::Construction { name } for revolve and surface revolve, resolved at evaluation and checked to lie in the sketch plane. - construct.plane.at_angle accepts a construction axis name (its fixed axis line is taken from the axis as it is now). - Reopening these features shows the construction axis as the pick. - Design format: pending/construction-axis-refs.rs. * Construction axis references follow the axis in the feature's component frame (#4506) - Revolve, Surface Revolve and Circular Pattern resolve a construction axis where it is evaluated, mapped into the feature's component frame. - A line of the revolved sketch with the same id as a construction axis still wins, so existing scripts keep their meaning. - Tests: the revolve keeps the reference through save and reopen and follows an edited axis (60π to 80π mm³); perpendicular, offset and profile-crossing axes are refused without changing the design. |
||
|
|
408d30ea56 |
Joint drive moves parts without evaluating them (#3391) (#3397)
* Joint drive moves parts without evaluating them A joint drive (also the Drive dialog and motion steps) changes only occurrence transforms, yet it re-evaluated nearly the whole timeline: every feature that might read another component's geometry (a sketch with any link, even to its own axis) hashed every occurrence's transform into its fingerprint, so any motion invalidated it and everything after it, and no new pose was ever in the cache. - Placement digest: a feature now hashes only where the geometry it actually reads lies relative to its own frame (link sources, anchors, profiles and paths from other components, mirror placements; To Object and face/edge-picked planes read every component, relatively). Moving parts that keep those relative placements leaves every result in place: nothing is evaluated or re-meshed. In-context features whose referenced part really moved still rebuild. - Evaluated ahead, applied once: `Ahead::evaluate` returns what it evaluated and `Session::prime` lets the window-thread pass take it (history commands and dialog OK), so an off-thread command no longer costs twice on designs past the cache's budget. - Contact meshes are kept per body geometry across drives. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Joint drive: booleans read only their input bodies' placements A join, cut or intersect with named targets, and a Combine, read every placement, so a joined part transferred to a component re-ran its boolean at each new joint pose. Each now hashes only the placements of the bodies it actually takes as inputs, resolved in its timeline input state (before any later BodyTransfer), relative to the frame that evaluates it; Combine reads its tools relative to its target. Unresolved and legacy component or path reads keep the conservative dependency. 24 new joint_pose_ tests cover new angles, transfers, targets, save/reopen, undo and real relative motion (900 -> 800 mm3). Supplement offered on #3397 by takuto-NA. Co-Authored-By: takuto-NA <183465875+takuto-NA@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Creating a component recomputes nothing A new, empty component changes nothing a feature reads, yet it changed the placement fingerprint of every targeted boolean, Combine and To Object feature, so `component.create` evaluated the timeline again: - the first component of a design: `placement_digest` returned 0 while the design had no placements and a nonzero value once it had one; - To / From Object and legacy face- or edge-picked planes hashed every component, not just those holding the bodies, sketches and construction geometry the feature can reach. Co-Authored-By: Tyler Chiriboga <18270301+Tyler-Chiriboga@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Test: creating a component after a legacy face sketch recomputes nothing A face extruded after its construction certificate is gone (a patterned cut, a pad joined flush with it, then one more cut) is sketched on a legacy face plane, which reads every placed body. A new, empty component must not change what it reads either (reported by Tyler Chiriboga). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: takuto-NA <183465875+takuto-NA@users.noreply.github.com> Co-authored-by: Tyler Chiriboga <18270301+Tyler-Chiriboga@users.noreply.github.com> |
||
|
|
4dc1828138 |
Imported meshes: share their triangles between document copies (#4673) (#4675)
Every edit clones the document for undo, and `MeshData`'s positions and triangles (plain `Vec`s) were copied with it: ~165 MB a command for a 2 M- triangle STL. They are now `Arc<[f64]>` and `Arc<[u32]>`, shared by clones; the few places that rewrite them build new arrays. Saved designs are unchanged (an `Arc<[T]>` serializes as the array). Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> |
||
|
|
3d3dd27439 |
Viewport: leave out placements of an instanced mesh that are out of view (#4646) (#4647)
* claim: #4616 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Viewport: draw a part placed many times from one copy of its triangles (#4616) A part placed by many occurrences was drawn, framed and picked from a moved copy of its mesh per placement: on the CPU (the moved mesh and its scene bytes) and on the GPU (its vertices uploaded once per placement). - The model scene draws bodies that share a mesh as GPU instances: the shared triangles once, a rigid move and colour per placement (`InstancedMesh`, `vs_tri_inst`), in the solid, section and AO passes. `GpuScene::merged` expands them, so scene tests see world triangles. - `ModelBody::mesh_in_place`, `plan_mesh_in_place_at`, `mesh_bounds` and `display_identity` give the shared mesh, its placement, the exact box and an identity without making the moved copy. - Display refinement's body ids, Fit/Home bounds, the viewport's body boxes, the background mesher and picking use them (picking moves the ray into the part's frame and shares one pick index). 25 placements of a 2 M-triangle STL on an M2 Max: orbit 45 -> 37 ms a frame, footprint 41 -> 16 GB, 24 copies 39 -> 18 s. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Viewport: draw large meshes from shared, indexed vertices (#4637) An instanced mesh's vertices are shared between its triangles and drawn indexed (`SharedTris`). A flat-faceted mesh (an STL's facets) shares them by position alone and lights each fragment with its triangle's own plane (`vs_tri_inst_flat`, `fs_*_flat`), taken from the fragment's position relative to the eye so it stays exact at any zoom; its vertex outputs are kept few, since a tiled GPU stores every vertex's outputs. A body alone is drawn this way from 50 k triangles. A mesh too large for one buffer falls back to unshared vertices. `instanced_scene_gpu_benchmark` (manual, ignored): 25 placements of a 2 M- triangle STL at 3600 x 2190 px, 4x MSAA, M2 Max: 21.3 ms a frame for the placements' own triangles, 16.1 ms shared and indexed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Viewport: leave out placements of an instanced mesh that are out of view (#4646) Each frame `Batches::cull` keeps the placements whose box may be seen (`placed_box_in_view`: all eight corners past one side of the view in clip space, so it holds behind the eye too) and writes them again only when that set changes. The manual benchmark gains `SOLIDCRAFT_BENCH_CLOSE=1`: close up on the middle of 25 placements of a 2 M-triangle STL (13 in view), 3600 x 2190 px, 4x MSAA, M2 Max: 28.2 ms a frame for the placements' own triangles, 17.2 ms instanced and culled. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> |
||
|
|
5899e5b6c5 |
Release 0.19.0 (#4603)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
b289dc2421 |
Sketch Dimension: name = value defines a user parameter (#2916) (#3638)
* Sketch Dimension: `name = value` defines a user parameter (#2916) In a dimension's value (the D tool's box, and `sketch.dimension`'s `value` from scripts, the CLI, MCP and the control channel), `name = expression` adds the user parameter `name` with that expression and dimensions with `name`: typing `width = 40` on a line gives a 40 mm user parameter `width` and a dimension whose expression is `width`. A bare number is read in the design's unit, as a bare dimension value is; an angle's parameter is in degrees. The expression may be anything the parameter editor takes. It is one command: one undo removes the parameter and the dimension together, and a dimension the sketch refuses leaves no parameter behind. A taken name is refused with a hint (type the name to use it, or change it in Parameters), a reserved name with the parameter editor's message, and a left side that is not a name (`2 = 3`) still fails to parse as before. A driven dimension defines nothing. The reply carries `defined`, and the status line names the parameter. The splitter lives in the doc crate (`expr::definition`) so other value inputs can take the same form later; editing an existing dimension, the inline shape boxes and feature dialogs are follow-ups. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * Sketch Dimension: say why a name is refused, in the command's own words (#2916) The dimension editor showed a refused definition raw, in the box and the status line: "invalid parameters for `sketch.dimension`: value: `mm` is a unit, constant or function name". It now reads "Sketch Dimension: `mm` is a unit name, so it cannot be a parameter name": the editor passes the command's errors through `friendly_error` like every other command, and drops the `value:` field tag, since the box is the value. The taken-name hint reads the same way: "Sketch Dimension: there is already a parameter `w`: type `w` to use it, or change it in Parameters". A reserved name says what kind of word it is and what that means (`param_name_problem`, shared with the Parameters dialog): a unit name, a function name, or a constant, "so it cannot be a parameter name"; `expr::reserved_kind` tells them apart. `friendly_error` translates the command label with the interface language (the engine's sentence stays English), so the prefix reads "Wymiar szkicu:" in Polish. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * Sketch Dimension test: keep the third line off the ribbon (#2916) On current `main` the ribbon floats over the top of the canvas, and the test's third line at sketch y = 50 projected under it: the click opened Parameters instead of picking the line. The line now goes below the first one. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com> |
||
|
|
50313d147f |
solid.mirror: copies join their source's component; follow the saved placement (#1938)
* solid.mirror: copies join their source's component; follow the saved placement Three follow-ups to mirroring bodies of placed components: - A copy joins the component of the body it mirrors (or, when that component is placed more than once and a copy there would show at every placement, the innermost component around it placed once), so checks that group bodies by component see it beside its source. - The saved placement path, not the body's name, says which component a mirrored body is in: inserting the same file again reuses the body names, and the copies of the first insert vanished. - The mirror is evaluated again only when its own placements or its component's frame change, not on every occurrence move: each later command paid for one more mirror evaluation. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * solid.mirror: a saved placement must still lead to the body's component A stale or edited placement path that leads to another component's occurrence mirrored the body silently where that other component is placed. The mirror now reports that the placement no longer exists. The body's component comes from the evaluated body where a transfer recorded it, else from the component its name is recorded in or its feature's. When a later insert of the same file has taken over the name (the recorded component lies outside the components the body's own feature made), the placement has to lie inside those components instead, so mirrors of the first insert keep working. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * solid.mirror: the copies' component change is a pending format change v26 shipped in 0.15.0, so its mirror-placements note stays as released; the change of where a Mirror with placements puts its copies is noted in a new pending file instead. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> |
||
|
|
034aa60d47 |
Release 0.18.3 (#4270)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
971b223246 |
Thread: turn a shaft thicker than a modelled thread down to its major diameter (#4256)
* Thread: turn a shaft thicker than a modelled thread down to its major diameter A modelled external thread on a shaft thicker than the thread no longer refuses: the shaft is turned down to the major diameter over the threaded length (run past a free end of the face), then the thread is cut as before. The turned face is named F<n>:turned and the step it leaves F<n>:shoulder:start/end. A shaft the part goes on around is refused rather than cut into, shafts under the minor diameter and cosmetic threads on thicker shafts are still refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Thread preview test: an 8 mm shaft is turned down for M6; M10 still refused Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
8c861f9f46 |
Face names: pieces of a split face keep their numbers across evaluations (#3902) (#3991)
* Face names: pieces of a split face keep their numbers across evaluations (#3902) Pieces sharing a name were numbered in the kernel's order, or by the index of the operand face they came from. A boolean can list its result's faces in another order on the next evaluation, and an operand made by one (a closed sweep tool) carries that order into the indices, so the #1/#2 of a split face could swap between two evaluations of the same design. Pieces that nothing else tells apart are now numbered along the spread of their centres (as edge pieces already were), and pieces from different faces of one operand by kind, then by place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Face names: older designs keep the piece numbers they were saved with Numbering pieces by place renumbers split faces in many existing designs, and a stored name matched exactly would then land on the other piece. Features of a design saved before this change are marked `kernel_piece_order` by a pending format step and number their pieces as before; features added afterwards number by place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |