Commit Graph
22 Commits
Author SHA1 Message Date
jyvikoandClaude Opus 5.5 cfe1b8b929 step: a loop through its surface's pole has its seam
A cone face bounded by its base circle and its seam out to the apex and back
turns once round the axis and closes at the apex. add_seams counted the turn
as a loop without a seam and added another, out and back from the same
vertex: the drill point of a turned pin read back from STEP had a sliver
whose boundary crossed itself, and the body would not tessellate (#5193). A
winding loop with a vertex on a pole is left as it is.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0113gDVmStT5tCGKW9Fxgc5K
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 1bf2062590 STEP and IGES import: SMLib makes the pcurves that have no closed form
A use with no closed-form pcurve (an approximated intersection curve on a cone,
a spline edge on a spline surface) no longer refuses its solid. Its face goes to
SMLib alone, an open sheet with the trims it has and without the others, and
SMLib makes those as it makes every trim it needs (GetOrCreateUVTrimCurve on
export); they come back on the record's parameters and the face is closed and
checked as before. The STEP reader takes the trim maker from the kernel
(read_solids_with, read_solid_with); read_solids stays exact-only.

Kernel lib tests: 490 pass, 239 fail (were 468 / 261; pushed head 475 / 254),
none newly failing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 6c385c8439 sew, step: face forms from the boundary's extent; trimmed profiles exact
sew and the STEP reader build a revolved face's NURBS form over `form::extent` (its boundary on
its label) instead of a pass of pcurves on the label, and compute its pcurves within the form's
box. The STEP reader gives revolutions their form too, and a trimmed swept profile its file's
trim range exactly (points on the axis fit either side of it). The STEP seam tests read edge
angles through `Edge::curve_interval`, intervals and domains being in the forms' parameters.
step 37/37.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 6cc0401fa7 brep, step: the pcurve fit is gone
`On::fit` and everything it used (samples, least squares, breaks, filled poles) are deleted, and
the STEP reader no longer retries a face at ten times its tolerance. A pcurve is exact (closed
form, an affine image, or a straight line along a form's parameters) or the face is refused:
"not supported yet: no exact pcurve of <curve> on <surface>".

The rig and ladder are as with the fit (333/372, 101/116; none lost; 3806, already failing, now
refused on import). 16 unit tests that build sphere meridians, torus seams, closed spline
bands, intersection curves and surfaces of revolution on their labels now refuse: those paths
need meridians labelled on their face's meridian plane and revolutions on the quarter grid.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 819928205a step: a swept surface's circle or ellipse profile is its NURBS form
A surface of linear extrusion or of revolution over a circle or ellipse built its profile with the
reader's own conic spline, on a parameter of its own; the profile is now `form::curve`, the form
its edges carry, so the surface's parameter along the profile is theirs and their pcurves are
straight. The reader's conic spline is gone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
2026-10-27 02:28:51 -04:00
jyvikoandClaude Opus 5.5 c376e84034 step: imported faces and edges on their NURBS forms
`form::edge` is the one rule sew and the STEP reader share: a circle about a revolved face's
axis is labelled on that face's frame, and a circle or ellipse edge gets its form. The STEP
reader now gives every imported edge its label and form before any pcurve, and every
cylinder, cone, sphere and torus face its form over the extent its label's pcurves give; the
pcurves, the outer-loop choice and the turn-over test then run on the forms, and the record
carries them.

With the pcurve fit turned off, the STEP and IGES circle cases pass (8 of the 9 import cases
that needed it; 3208's ellipse on an extruded spline surface remains).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
2026-10-27 02:28:51 -04:00
jyvikoandClaude Opus 5.5 b1326e48d6 brep: an edge on a line, circle or ellipse carries the NURBS form SMLib holds it as
The edge mirror of a face's NURBS form: Edge::nurbs keeps the NURBS SMLib holds a conic as, and
the edge's interval and its pcurves' parameter are its. Edge::parameters is the curve every
evaluation at a parameter uses; curve says what the edge is. Nothing writes the form yet.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:51 -04:00
jyvikoandClaude Opus 5.5 b6a3b31ff9 brep: a face on a cylinder, cone, sphere or torus carries the NURBS form SMLib holds it as
Every SMLib analytic surface is a B-spline surface, and its trims are in that NURBS's
parameters. Face::nurbs keeps that NURBS: the face's domain and pcurves are its (u, v), and
`surface` says what the face is. Face::parameters is the surface every (u, v) evaluation uses.
The SMLib conversion reads and writes it (fork FACE_NURBS_FORM, SMLIB_REV c4483f6); the STEP
writer writes the analytic surface and the face's edges without pcurves.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 2ffbbc74d9 step: a cone within the file's uncertainty of its limit plane over the face is read as that plane
Exporters write a plane as a CONICAL_SURFACE whose semi-angle falls a whisker
short of 90 degrees (#4006: pi/2 - 7e-12): its height over the face spans
4e-11, a parameterisation ill-conditioned for everything downstream. The
reader now measures the cone's deviation from its limit plane (the plane
through the placement across the axis) over the face's boundary points and,
should the face hold the axis, the apex; within the file's distance
uncertainty the face's surface is that plane, oriented as STEP's normal.
One criterion, the deviation over the extent against the tolerance; no
semi-angle threshold.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 7d9eb68e40 solidcraft-step: a record's layout (solids, voids, sheets) and outer loops for every writer
write::topology::layout says which shells make each solid (a material region's outer shell
and its voids) and which are sheets, and outer_loop which loop of a face is its outer one;
the STEP writer uses both, and the IGES writer can too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 d59bb0084c solidcraft-step: revolutions under axis-keeping placements; void shells as the record has them; Reader::frame
A placed revolution is written exactly whenever its placement maps revolutions about the
axis onto revolutions (one scale across the axis, another along it, then a rotation or
reflection), its profile placed with it; a conic profile stays a conic under a similarity.
A void's CLOSED_SHELL keeps the record's sides (normals out of the material, into the void)
through an ORIENTED_CLOSED_SHELL .T., as SolidCraft has written voids. Reader::frame reads an
assembly placement (AXIS2_PLACEMENT_3D, or _2D in the XY plane).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 30ddda3064 solidcraft-step: write a schema 4 record as ISO 10303-42 topology
write::topology writes each material region as a MANIFOLD_SOLID_BREP (BREP_WITH_VOIDS
with its voids as ORIENTED_CLOSED_SHELLs), open shells as a SHELL_BASED_SURFACE_MODEL,
faces as ADVANCED_FACEs on their exact surface with FACE_OUTER_BOUND/FACE_BOUND of
EDGE_LOOPs and VERTEX_LOOPs, edges as EDGE_CURVEs on their exact curve over the record's
interval, and the record's exact pcurves as PCURVEs of SURFACE_CURVE/SEAM_CURVE. A record
surface's (u, v) map linearly onto STEP's (planes on their orthonormal frame, narrowing
cones turned over, revolutions angle first), and pcurves go through the same map.
Writer::add_distinct writes topology entities unshared. topology::Solid lists the faces
the reader turned over (their loops disagree with their same_sense).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 667cd33560 solidcraft-smlib: pcurves on B-spline faces are SMLib's own UV trims
On a B-spline face the export now takes each edgeuse's UV trim exactly as
SMLib holds it (EDGEUSE_NURBS_*): the face's parameters are SMLib's, so the
trim is the pcurve, reversed exactly (knots t -> a + b - t) where the
edgeuse runs against its edge, its knots mapped onto the edge record's
parameter where that is an affine image of SMLib's (identity for spline
edges, as_line's map for NURBS lines, the C side's map for lines), and its
end knots set to the edge interval where they differ by rounding (within
the schema's 1e-9 slack, else an error). Changed: export.rs `curves`
(per-edge TrimMap), new `trims`, `mapped`, `Face::given`,
`Edge::trim_map`, the face loop in `native_ordered`, `pcurves`,
`outer_area`.

Analytic faces and circle/ellipse edges keep brep::pcurve: SMLib keeps an
analytic face's trims on its internal rational B-spline (SmCylinder.h:
"the map from one to the other is not linear") and a circle's on its NURBS
parameter, neither an exact B-spline in the record's angle parameters.

brep::pcurve::EdgeUse gains `given`, a producer's exact pcurve taken as it
is (structure and interval checked, moved by whole periods with its loop,
never refitted). Existing construction sites (STEP reader, tests, truck
adapter) pass `given: None`; the existing tests change only for the new
field.

Built, clippy-clean and tested on 4b2c0eaf before the rebase onto
kernel-smlib/no-truck (not built: base in progress).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:47 -04:00
Brennen HerbruckandClaude Opus 5.5 a89c67adf9 solidcraft-step: faces around a spline closed on itself get a seam
A face on a B-spline surface whose first and last control columns are the
same (closed around u), bounded by loops that go once around without a seam
edge, was refused ("a loop across a closed spline surface's seam"). It now
gets a seam as cylinders and cones do, along the surface's own boundary
column (u at the start of its knots, an exact iso-curve of the net), each
loop split where it crosses that column when it has no vertex on it; the
period is the knots' width. At a pole a loop may jump across u, where the
seam's two uses meet a period apart.

The step-conformance NURBS cylinder, dome and torus ring now read. With
SOLIDCRAFT_KERNEL=smlib all 17 parts import into SMLib with their exact
volumes and face counts. A spline closed in v only, or both ways, is still
refused.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:47 -04:00
Brennen HerbruckandClaude Opus 5.5 7e208529cd solidcraft-step: each record face names its face in the file
Solid::face_origin lists the ADVANCED_FACE or FACE_SURFACE entity of each
of the record's faces, in the record's face order, so a body made from the
record (in another kernel) can trace its faces to the file, as the truck
import's face_origin does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:47 -04:00
jyvikoandClaude Opus 5.5 1d8299aedf kernel: an SMLib body keeps each edge's and vertex's tolerance through its record
SolidCraft's own record of a body SMLib made (the rig's record check, the saved body, the next
SMLib import) re-fitted every pcurve at the kernel's working tolerance, 1e-5 mm. SMLib's fillet
and chamfer surfaces lie some 2e-5 to 2e-4 mm off their faces, so 15 fillet and chamfer cases
failed that check although SMLib's own passed. And SMLib reported one tolerance for a whole body,
the largest any part of it needed, so one loose edge (a pocket cut left one at 0.23 mm) made the
whole body loose on its way back into SMLib.

Now the tolerances go per edge and per vertex, both ways:
- solidcraft-smlib reads and writes the fork's new SMLIB_FLAT_EDGE_TOLERANCE and
  VERTEX_TOLERANCE arrays. Export gives each edge and vertex record its own (never below the
  floor, which becomes the body's). Where those understate what an approximated edge needs on
  its face (SMLib holds a blend's end curve 2.3e-5 mm off its plane at 2e-5), the export falls
  back to SMLib's largest everywhere, as before. Import writes each record edge's and vertex's
  tolerance.
- `geom::brep::pcurve::EdgeUse` carries its edge record's tolerance, and a pcurve is fitted to
  it where it is larger than the face's.
- The kernel's decoded body keeps its record's edge and vertex tolerances
  (`Body::tolerances`, in its edge and vertex order) after an SMLib operation and a saved body's
  decode, and keeps them through a rigid placement. Its record writes them again; anything that
  builds a new solid drops them.

SMLIB_REV moves to the fork commit that adds the arrays (smlib-blends-abi2 4a67471, ABI 2).

Rig and ladder fillet and chamfer cases on SMLib: 43 pass before, 60 now, none lost. Tests: a
pcurve fitted to its use's own tolerance, and the ladder's 08/006 cylinder rim chamfer whose
record, saved body and placed copy all stay valid and SMLib's check takes back.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
2026-10-27 02:28:47 -04:00
Brennen HerbruckandClaude Opus 5.5 d41ae85125 solidcraft-step: surfaces of revolution and extrusion, offset surfaces, hyperbola and parabola edges
SURFACE_OF_REVOLUTION reads as a placed revolution (u the angle, v the profile's parameter,
STEP's normal); SURFACE_OF_LINEAR_EXTRUSION as an exact spline surface, the profile as a
(rational) B-spline times degree 1 along the vector; a circle extruded along its axis or
revolved in a plane through the axis as the cylinder or ring torus it is. Line, conic and
open-conic profiles are bounded by the face (a closed conic's seam outside it, a revolved
profile stopped at the axis). OFFSET_SURFACE of the analytic kinds reads as the moved
surface, checked at each level. Hyperbola and parabola edges read as exact rational
quadratic pieces and a Bezier on STEP's parameter. Faces winding around a revolution get
seams along its profile. Every mapping is checked point by point and normal by normal
against STEP's own surface.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:44 -04:00
Brennen HerbruckandClaude Opus 5.5 91e482fc8a solidcraft-step: refuse loops across a closed spline surface's seam; conformance parts and truck volumes
A face winding around a closed (non-periodic) spline surface without a seam edge has loops
that jump across the surface's domain; it is refused for now instead of making a record whose
loops do not close. The step-conformance parts are read in a test, and the kernel's ignored
corpus comparison builds each record back into a truck solid to compare volumes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:44 -04:00
Brennen HerbruckandClaude Opus 5.5 3d7e465b16 solidcraft-step: seams for STEP faces that wind around their surface, looser pcurve fits
A face on a cylinder, cone or sphere bounded by loops that go round the axis (a band
between two circles, a dome on its equator, a cone on its base and apex) gets a seam:
a ruling or meridian from one loop to the other (split where it has no vertex at that
angle) or to the pole it covers, so every loop closes in (u, v) as schema 4 requires.
Pcurves may be fitted up to 1 mm off for edges that lie off their surfaces. The kernel
gets an ignored corpus test comparing truck's face and edge counts with schema 4's.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:44 -04:00
Brennen HerbruckandClaude Opus 5.5 54b10b9a32 solidcraft-step: STEP topology into schema 4 B-rep records
read_solids walks MANIFOLD_SOLID_BREP, BREP_WITH_VOIDS and SHELL_BASED_SURFACE_MODEL
into solidcraft_geom::brep records: lines, conics, B-splines and polylines; planes, the
analytic surfaces and B-spline surfaces; edge intervals from the vertices' parameters;
loops relative to the surface's natural normal; outer loops, regions, voids and sheets;
pcurves from the 3D edges; the canonical order. Unsupported geometry refuses its solid
with a reason and the rest of the file is still read.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:44 -04:00
Brennen HerbruckandClaude Opus 5.5 acff340a04 solidcraft-step: representation context units and uncertainty, shared with the kernel's STEP reader
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:44 -04:00
Brennen HerbruckandClaude Opus 5.5 f06581ca50 STEP geometry as plain data: read and write ISO 10303-42 curves and surfaces without truck
A new crate, solidcraft-step (L1, no modelling backend), holds the Part 21
parser (moved from the kernel, which now reads through it) and STEP geometry
as plain data: lines, conics, B-splines (rational and implied knots),
polylines, trimmed curves, surface curves with their pcurves, 3D offset
curves; planes, cylinders, cones, spheres, tori (degenerate too), B-spline
surfaces, revolutions, linear extrusions, offset and rectangular trimmed
surfaces. Each keeps STEP's own definition and parameterisation, in mm and
radians, with pcurves scaled by their surface's parameter units. Shared
entities stay shared. A writer emits the same entities back, deduplicated.

Tests per entity check values against analytic points, units, round trips
and hostile input; an ignored test reads and round-trips every edge curve
and face surface of the tangency-labs/models STEP files.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:44 -04:00