Commit Graph
10 Commits
Author SHA1 Message Date
jyvikoandClaude Opus 5.5 7d300984b2 kernel, kernel-cases: a shell whose walls would meet is refused, saying so
Rig case shell/4711 (a 60 x 40 x 10 block, an r3 through hole at (22.5, 7), a 10 x 10 notch on
the front edge, shelled 2 open at the bottom) failed with "SMLib shell: operation: SMLib failed
(status 1027)". The hole is 4 = 2 x 2 from the front face: the hole wall's offset (r5) is tangent
to the front's at (22.5, 2), the walls meet along a line and the cavity would pinch to zero
thickness there, which is no solid. Refusing it is right; the refusal did not say why.

SMLib now refuses an offset whose walls would meet with its own status, SMLIB_ERR_WALLS_TOUCH
(-1110). The smlib crate reads it as Error::WallsTouch; the kernel's offset backend turns it into
a sentence with the wall, as blends turn NoRoom into one: "shell: the 2 mm walls would meet along
a line (between a hole and the side, for example), which leaves no solid there; use a thinner or
thicker wall, or move the feature". Thicker builds too (SMLib shells 4711 at 2.5, the walls
crossing and merging between the hole and the front), so the sentence offers both.

4711 expects that refusal and its message ("outcome": "refused", "refusal"), its "what" and
"method" saying why: the wall is 4 = 2 x 2, the walls meet along a line. Tests: the smlib crate
shells 4711 built from primitives (2 refused as WallsTouch, 1.5 and 2.5 valid), the kernel a
plate whose hole is 3 from its side at 1.5 (refused, with "the 1.5 mm walls would meet along a
line").

Results (run-sc.sh against SMLib a759622's code, which differs from the tree run only in
comments and docs; baseline 858f381fc-5448b9a): rig 410/447 (409
before; 4711 fail -> pass as the refusal, nothing else changed), ladder 109/116 (unchanged),
kernel lib 535 passed / 202 failed (one new test; the same failing set), smlib crate 53 / 2
(one new test; the same failing set).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0113gDVmStT5tCGKW9Fxgc5K
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 237f0ae745 kernel, kernel-cases: a convex blend overflowing a cliff is built, with its analytic answer
SMLib now builds a round or chamfer whose rail runs off its face across a cliff (an opening's
rim, the body's outline): the blend is made as if its faces continued and what it removes is
subtracted, so it never bridges an opening (owner decision for rig 5158/5181; fork commit
"SMLib, capi: a convex blend overflowing a cliff is subtracted from the body"). The tests that
expected a refusal for such blends now expect the body, each answer from the geometry:

- variable_radius_on_a_box_edge: 2 -> 50 on the 10x20x30 box's top edge builds at
  3546.18767939 (circular sections in y = const, the r x r square less the quarter disc,
  clipped to the box; rel 1e-4).
- variable_radius_from_a_spline: the "big" law builds at 6000 - 726.5334566720 (de Boor law,
  split at the knot and where r crosses 10).
- a_chamfer_meets_sloped_end_planes: chamfer 25 removes 11500 - 4625 * slope
  (integral of 40 - 2 * slope * y over z >= y - 5).
- g2_fillet_refuses_invalid_geometry: G2 at 25 builds at 6138.1606889 (the quintic section
  with control points at thirds, clipped to 20x20, along 20).
- fillet_max_each_reduces_only_where_the_radius_does_not_fit: both edges take 4, 24438.7317761.
- hostile_inputs_are_errors: chamfer 30 on the cube builds at 1000 (y + z <= 10 along 20);
  R50 still fails.
- kernel-cases fillets/1080: the 9 mm chamfer into the openings builds at 3350
  (method in expected.json).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0113gDVmStT5tCGKW9Fxgc5K
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 bcbb990051 kernel, smlib: a blend larger than its faces is SMLib's refusal; blends take exactly the given edges
SMLib (fork 68e3086) refuses a blend whose rails leave the faces they roll on with
SMLIB_ERR_NO_ROOM, which the kernel reports as KernelError::TooLarge. The kernel's own
pre-checks go: blend_fit's fit check and the 256-station band check of the variable fillet.
The shim no longer follows tangent chains; the Fillet/Chamfer dialog already expands a pick
to its chain (its Tangent Chain option) and stores every edge in the feature.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 1336352a43 solidcraft-smlib: pin the fork at 2d7c7ed, the second round of SMLib C++ fixes
SMLIB_REV moves from 276b509 to capi-solidcraft 2d7c7ed: a fillet crash at an
unsupported corner (#453), rounds ending on a tangent seam (#418), radius laws
with a corner (#430) or that cannot be evaluated (#458), a round over a hole
(#422), a sphere's own patches kept apart (#423), offset surfaces extended the
same way whatever was evaluated first (#419), swept walls sharing their planes
(#434), the internal thread's last vertex gap (#410), shells across rounds
thinner than the wall (#397), nested shells imported in any order (#388) and
the tessellator held to its chord tolerance (#390).

Three tests follow: a radius law with a corner is now built, so the SMLib
tests check its volume (8000 - (1 - pi/4) 20 28/3) and that a law pinching to
zero inside the edge is refused; the split coil's halves now measure within
1e-5 of the closed form, so they are held to it rather than to the whole
coil's mesh, which is only within 3e-3.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:47 -04:00
bherbruckandClaude Opus 5.5 523270fe5e solidcraft-smlib: Brep::draft, and SMLIB_REV at the fork's smlib_draft
Flat faces tilted by an angle about the line where each meets a neutral plane, leaning in along
the pull, and the faces around them extended or trimmed to meet them
(tangency-labs/smlib@e1ac3c3, SMLib's local operation). A face that isn't flat or isn't parallel
to the pull is Error::Unsupported. The test drafts a cube side by +-5 degrees, removing or adding
the analytic wedge to 1e-6.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:47 -04:00
bherbruckandClaude Opus 5.5 07c36cfd01 solidcraft-smlib: Brep::chamfer_sides, and Error::Unsupported for a radius law with a corner
Brep::chamfer_sides reaches the fork's smlib_chamfer_sides: `distance` back along the face
whose outward normal leans most along a given direction, the other side by a second distance
(ChamferSecond::Distance) or at an angle to the first face (ChamferSecond::Angle). The fork's
smlib_fillet_variable refuses a radius law with a corner with SMLIB_ERR_UNSUPPORTED, which the
crate reads as Error::Unsupported ("not supported yet"): SMLib's section fit ran smoothly
across the corner and missed the law (4 -> 2 -> 4 on a 20 mm edge took 35.1 mm3 for 40.1;
tangency-labs/solidcore#430). Both are in the fork at the pinned bf7c272.

Tests (ops_tests.rs), against analytic values: 5 and 2 either way round (the centroid tells
which face took the 5), 5 at 30 degrees, rejected arguments; a quadratic law 4, 1, 4 and a law
down to zero (1e-5), the corner law refused and the same points joined C1 built.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:47 -04:00
Brennen HerbruckandClaude Opus 5.5 82fe0e59e5 solidcraft-smlib: Brep::imprint
Imprint cuts each face of a body where a tool body meets it (the fork's
smlib_imprint, SMLib's imprinting boolean) and gives None where the tool
crosses no face. Trim builds on it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:47 -04:00
jyvikoandClaude Opus 5.5 3fcb3ea5c6 solidcraft-smlib: Brep::blend (per-edge sizes; round, G2, chord, chamfer) and Brep::fillet_variable
The Rust side of the fork's smlib_blend and smlib_fillet_variable, which the kernel's fillets and
chamfers need on SMLib: `Brep::blend` takes a size per picked edge and a `Blend` (circular round,
curvature-continuous round between the round's contacts, constant-chord round, equal-distance
chamfer); `Brep::fillet_variable` rounds one edge with a clamped B-spline radius law from the end
nearest a start point. Selection errors map as for the other picking operations.

SMLIB_REV moves to the fork commit that adds them (smlib-blends, on capi-solidcraft ffcf56d).

Tests: per-edge rounds and chamfers and the chord round against analytic volumes, the linear law
from either end, and refused laws and picks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
2026-10-27 02:28:47 -04:00
jyvikoandClaude Opus 5.5 51211ad1fe solidcraft-smlib: offset faces, thicken, and NoRoom for walls with no room
Brep::offset_faces and Brep::thicken reach the fork's new smlib_offset_faces and
smlib_thicken; SMLIB_REV moves to the fork commit that adds them. The shim now refuses an
inward wall that leaves no room inside the body with its own status, Error::NoRoom, instead of
an argument error, so callers can say what is wrong; the test that a wall thicker than the box
fails now expects exactly that.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
2026-10-27 02:28:47 -04:00
jyvikoandClaude Opus 5.5 734883bdb5 solidcraft-smlib: booleans, fillet, chamfer and shell through SMLib
Brep::boolean (union, subtract, intersect; Ok(None) for an empty result), Brep::solid_count,
Brep::fillet, Brep::chamfer and Brep::shell, over the fork's smlib_ops.cpp shims (ffi/ops.rs).
Edges and faces are chosen by points, each the nearest within a tolerance; a point that
selects nothing or cannot decide is Error::NoMatch / Error::Ambiguous with its index, and a
solid input that gives anything but a closed solid is Error::NotSolid. Fillets and chamfers
take whole tangent chains; a chamfer distance is the setback along each face; a shell's
thickness is negative inward.

The C API with these shims is version 2 (the fork's capi-flat line), so ABI_VERSION is 2.

Tests (ops_tests.rs) against analytic volumes and counts, SMLib's own check at every level on
each result, and history through a tagged box minus box: union 9000 mm3 [11, 24, 16]; slot
6000 [10, 24, 16]; intersection 1000; empty results; a split body (2 solids); a cube with all
12 edges rounded r = 2 against the Minkowski formula; one chamfer (7910, [7, 15, 10]); shells
open at the top inward (3392), outward (4672) and closed; a tangent chain from one pick equal
to picking all three edges; hostile sizes, tolerances, points and counts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
2026-10-27 02:28:44 -04:00