Ladder 06/009 had no way to ask for one: "solid.thread has no runout (vanishing thread)
length". With SMLib's smlib_screw_sweep_radial (replay e7acea1):
- smlib: the FFI binding and Brep::screw_sweep_radial, the profile moved off the axis by a
piecewise linear law of the turn; crate test: a tooth moved out 1 mm over three turns has
A 2π (c turns + ∫ offset dt).
- kernel: sweep_helix_radial, sharing sweep_helix's checks (helix_profile).
- doc: `ease_in`, `ease_out` (a length, or ISO 3508's standard 2.5 P or short 1.25 P) fade the
groove over that length, its section moving out of the material as it turns (outward for a
shaft, inward for a nut). ease_in is at the end the thread starts from. The runout lies past
the full-form length: beyond a square stop, before a shoulder up to its clearance; at a free
end inside the face. Runouts longer than the thread are refused. No end gets one by default,
so saved threads keep their geometry.
The cut is the integral over the turn of the clipped section's 2π∫ r dA: engine test (2.5 P
and 1.25 P between two collars) within the sweep's wall tolerance times the runouts' wall area
(0.029 against a 0.036 mm³ bound), ladder 06/009 (004's shaft, a 2 P runout before the
shoulder) graded in closed form (measured 1.7e-6 off).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The record's torus label is a ring torus (major > minor; the validator
refuses any other). SMLib keeps horn and spindle tori: a half disc revolved
about a line through its rim's end is a horn torus, its major radius a
rounding below its minor, and the export wrote it as a torus label the
record then refused (rig sweeps/4007, "ring torus radii"). Such a face is
now its NURBS form, unlabelled, which is its geometry in any case.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rig case shell/4711 (a 60 x 40 x 10 block, an r3 through hole at (22.5, 7), a 10 x 10 notch on
the front edge, shelled 2 open at the bottom) failed with "SMLib shell: operation: SMLib failed
(status 1027)". The hole is 4 = 2 x 2 from the front face: the hole wall's offset (r5) is tangent
to the front's at (22.5, 2), the walls meet along a line and the cavity would pinch to zero
thickness there, which is no solid. Refusing it is right; the refusal did not say why.
SMLib now refuses an offset whose walls would meet with its own status, SMLIB_ERR_WALLS_TOUCH
(-1110). The smlib crate reads it as Error::WallsTouch; the kernel's offset backend turns it into
a sentence with the wall, as blends turn NoRoom into one: "shell: the 2 mm walls would meet along
a line (between a hole and the side, for example), which leaves no solid there; use a thinner or
thicker wall, or move the feature". Thicker builds too (SMLib shells 4711 at 2.5, the walls
crossing and merging between the hole and the front), so the sentence offers both.
4711 expects that refusal and its message ("outcome": "refused", "refusal"), its "what" and
"method" saying why: the wall is 4 = 2 x 2, the walls meet along a line. Tests: the smlib crate
shells 4711 built from primitives (2 refused as WallsTouch, 1.5 and 2.5 valid), the kernel a
plate whose hole is 3 from its side at 1.5 (refused, with "the 1.5 mm walls would meet along a
line").
Results (run-sc.sh against SMLib a759622's code, which differs from the tree run only in
comments and docs; baseline 858f381fc-5448b9a): rig 410/447 (409
before; 4711 fail -> pass as the refusal, nothing else changed), ladder 109/116 (unchanged),
kernel lib 535 passed / 202 failed (one new test; the same failing set), smlib crate 53 / 2
(one new test; the same failing set).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0113gDVmStT5tCGKW9Fxgc5K
SMLib now builds a round or chamfer whose rail runs off its face across a cliff (an opening's
rim, the body's outline): the blend is made as if its faces continued and what it removes is
subtracted, so it never bridges an opening (owner decision for rig 5158/5181; fork commit
"SMLib, capi: a convex blend overflowing a cliff is subtracted from the body"). The tests that
expected a refusal for such blends now expect the body, each answer from the geometry:
- variable_radius_on_a_box_edge: 2 -> 50 on the 10x20x30 box's top edge builds at
3546.18767939 (circular sections in y = const, the r x r square less the quarter disc,
clipped to the box; rel 1e-4).
- variable_radius_from_a_spline: the "big" law builds at 6000 - 726.5334566720 (de Boor law,
split at the knot and where r crosses 10).
- a_chamfer_meets_sloped_end_planes: chamfer 25 removes 11500 - 4625 * slope
(integral of 40 - 2 * slope * y over z >= y - 5).
- g2_fillet_refuses_invalid_geometry: G2 at 25 builds at 6138.1606889 (the quintic section
with control points at thirds, clipped to 20x20, along 20).
- fillet_max_each_reduces_only_where_the_radius_does_not_fit: both edges take 4, 24438.7317761.
- hostile_inputs_are_errors: chamfer 30 on the cube builds at 1000 (y + z <= 10 along 20);
R50 still fails.
- kernel-cases fillets/1080: the 9 mm chamfer into the openings builds at 3350
(method in expected.json).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0113gDVmStT5tCGKW9Fxgc5K
A loft cut from a block's whole outline (flush with its sides) down to a pad cuts the slab
above it loose: the slab and the rest touch along the outline's four edges, round the pocket
the loft leaves. SMLib keeps the pocket as a void region of its own (its check finds the body
valid): its one runtime shell is the slab's underside and the loft's faces, so the slab's
material shell faces two empty runtime shells, the infinite region's and the pocket's, and so
does the rest's. The export made one record shell per pair of empty and material runtime
shells, so each solid's closed boundary came out as two open shells ("an open, wire or vertex
shell lies in one region").
A record shell is now one material runtime shell, whatever empty shells its faces face. Empty
regions one solid's boundary faces together are one record region: the infinite region where
it is among them, else the void whose outer shell bounds it alone. The pocket, which no record
shell bounds once the solids' shared edges are split, is part of the empty space round them.
Fixes rig sweeps/96-loft-cut-box-sections-pad-first and -top-first.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 796920968265c57c59f11dd908ec022d53f5c647)
A degree-1 patch of four control points on a parallelogram (a plane as an IGES
or STEP B-spline writes it) is that plane at every parameter, so its pcurves
take the plane's closed forms instead of going to SMLib (which drew the rim
circle of 3806's base as a 385-point spline).
SMLib may run a one-face sheet's loop against ours. A use's pcurve is the same
either way, so the loop's way round is read from an edge the face uses once and
every use is matched with it (3806 failed with 'a use SMLib did not keep').
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
A use with no closed-form pcurve (an approximated intersection curve on a cone,
a spline edge on a spline surface) no longer refuses its solid. Its face goes to
SMLib alone, an open sheet with the trims it has and without the others, and
SMLib makes those as it makes every trim it needs (GetOrCreateUVTrimCurve on
export); they come back on the record's parameters and the face is closed and
checked as before. The STEP reader takes the trim maker from the kernel
(read_solids_with, read_solid_with); read_solids stays exact-only.
Kernel lib tests: 490 pass, 239 fail (were 468 / 261; pushed head 475 / 254),
none newly failing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
SMLib holds every ellipse as an exact rational NURBS; the fork now sends ellipse edges with that
form and takes them back with it. The export reads an ellipse with its form as it reads a circle
with one (its frame turned so its angle grows along the form, its trims carried over as they are);
the import writes an ellipse on its form as its conic entry plus the NURBS.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
No floor of ours on tolerances (1e-6 of the body's size, 30 times SMLib's 1e-5 default): the
record's tolerances go back into SMLib, which approximates to them, so the floor coarsened every
later operation. No recognition of NURBS edges as lines or circles: an edge is a circle where
SMLib holds an SmCircle (with its NURBS form), and a NURBS edge keeps SMLib's trims on its own
parameter. crashes/2992 and sweeps/1853 pass.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Edge::curve_interval (and brep::curve_interval for assemble's edges) gives the interval on the
edge's curve itself: a form circle's angles of its ends, its frame turned by the SMLib conversion
so the angle grows along the NURBS. lip and the ruled surfaces read arcs by it; the hull, the
blend tangents, the patch pcurves, point paths, IGES output and the prism runs evaluate on
Edge::parameters. assemble carries an edge's form through.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The SMLib conversion reads and writes EDGE_NURBS_FORM: a circle edge's record keeps the circle
as what it is and the NURBS SMLib holds it as as its parameter, so the trims on it carry over
exactly (TrimMap identity).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The edge mirror of a face's NURBS form: Edge::nurbs keeps the NURBS SMLib holds a conic as, and
the edge's interval and its pcurves' parameter are its. Edge::parameters is the curve every
evaluation at a parameter uses; curve says what the edge is. Nothing writes the form yet.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every SMLib analytic surface is a B-spline surface, and its trims are in that NURBS's
parameters. Face::nurbs keeps that NURBS: the face's domain and pcurves are its (u, v), and
`surface` says what the face is. Face::parameters is the surface every (u, v) evaluation uses.
The SMLib conversion reads and writes it (fork FACE_NURBS_FORM, SMLIB_REV c4483f6); the STEP
writer writes the analytic surface and the face's edges without pcurves.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
SMLib (fork 68e3086) refuses a blend whose rails leave the faces they roll on with
SMLIB_ERR_NO_ROOM, which the kernel reports as KernelError::TooLarge. The kernel's own
pre-checks go: blend_fit's fit check and the 256-station band check of the variable fillet.
The shim no longer follows tangent chains; the Fillet/Chamfer dialog already expands a pick
to its chain (its Tangent Chain option) and stores every edge in the feature.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Pinned at the fork's draft-corners head: a drafted rectangle (or any
line-line corner) has its walls meet at a corner edge under the tangent
rule as well, 6 faces rather than 14. A curvature refusal for a curve
that is neither a line nor an arc names that curve's start.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
extrude_tapered(_between) take a DraftCorner: PreserveCurvature (each wall
continues as itself, a line's plane or an arc's cone, until it meets its
neighbour; SMLib's SM_OC_CURVE_EXTENSION), Tangent (the offsets continued
along their end tangents) or Round (an arc about the corner). A corner
the rule cannot close is refused with its point and why
(solidcraft_smlib::Error::Corner). draft_corners reports, per sharp
corner of a profile, what each rule gives: how far each offset curve runs
on or is trimmed, whether the corner cuts inside the exact offset, or why
the rule refuses it. SMLib pinned at the fork's draft-corners head.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
SMLib's mass properties no longer refuse bodies that are not one manifold
solid: several lumps and lumps touching along edges or points are the sum
over their material regions, and a sheet is its faces' area and centre with
volume 0. Docs of Brep::mass_properties and kernel::measure say so.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The ruled surface's far-curve solve kept its own copy of NURBS Book A2.3. The
geom crate now exposes bspline::basis_derivatives (the basis functions alive at
a parameter and their derivatives up to an order, each from its local knots via
local_basis, on the span tess::span_of picks); tess's second-derivative surface
evaluation and the ruled surface both use it, and the copy is gone. smlib's
mod list back in order.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Brep::face_section (smlib_face_section: one face cut by a plane) hands back
the NURBS SMLib made with their intervals, through one reader of smlib_curves
(take_curves) shared with project_curves. The face-pick errors map to
NoMatch/Ambiguous in one place (picked). SMLIB_REV at fork eedfa51.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The FFI for smlib_project_curves and the smlib_curves result (fork 5f9af50),
and the safe call: a curve list projected along a direction onto the picked
face, back as Curve::Nurbs with each curve's interval. SMLIB_REV at 5f9af50
(fork integration head 1934b57 + the untrim status fix + the projection shim).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
ssi::intersect took a sample count and gave each intersection curve as
samples: its 3D points, its UV points on each surface and the surfaces at
them. The fork's 947eedc hands out the curves SMLib's intersectors return,
exactly (smlib_ssi_curve_nurbs: degree, knots, control points, weights), and
drops the samples; SMLIB_ABI_VERSION 4.
SsiCurve now holds the 3D curve as a schema 4 Curve::Spline or
Curve::RationalSpline (rational where a weight is not 1) and each UV curve
the method returned as a Curve2, with SMLib's type, deviation estimate and
the 3D curve's natural interval; ssi::intersect loses its sample count. A
curve SMLib does not hold as a B-spline is Error::Unsupported (it is never
approximated); a B-spline whose knot count is not points + degree + 1 is an
argument error.
The SSI corpus scorer (tests/ssi_corpus.rs) samples the exact curves itself
where the corpus runner samples them: 4001 parameters spread evenly over the
3D curve's natural interval and over each UV curve's interval, the surfaces
evaluated at the UV samples, samples that cannot be evaluated dropped. The
unit test plane_through_sphere_is_a_circle evaluates the exact curve.
Nothing else used the samples. SMLIB_REV: the fork at 947eedc.
clippy -p solidcraft-smlib --all-targets, with and without native: clean.
The corpus gate (smlib_global_intersect_at_1e_6) is not run here.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The safe wrappers of the fork's smlib_stitch (a body's faces sewn at a tolerance,
oriented, with whether it closed) and smlib_offset_sheet (a sheet's faces onto
their offsets), for the kernel's Stitch and Offset Surface.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Each face's point from SmFace::CalculateAnInternalPoint, in SMLib's face
order; the fork at 89a1933 (also: smlib_extend_sheet extends every surface
as SMLib's B-spline, its analytic kind given back).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A tool is now a set of schema 4 record surfaces, each over a parameter box,
unbounded where the tool is: a plane; a face's surface over its own box; a
sketch curve as one patch per segment swept along the direction (a line a plane
strip, an arc swept square to its sketch a cylinder strip, any other segment its
exact rational Bezier extruded), an open curve continued along its end tangents
past the body. SMLib cuts the faces where the patches meet them
(Brep::split_faces: its intersection curves trimmed to each face by
MergeCurvesOnSurface) and slices a body with one patch (Brep::split_body); the
history is SMLib's own tags. Nothing is traced on a mesh, sampled or fitted.
Which side of the tool a point is on is its offset along the normal of the
nearest patch, each patch's surface prepared once with its projection grid
(ToolSide), never per point. ToolSide::of and side_of_point take the body the
tool must reach past; face_side becomes face_sides (every face of a body, one
mesh); analytic_field becomes analytic_face (a face of a body, on its record);
split_any returns the face map instead of the truck imprint. split_edges_at and
fit (a Catmull-Rom fit through samples) are deleted with the truck code.
ssi::Surface::from_record turns a record surface over a box into SMLib's.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
split_faces cuts faces (SMLib face order) where ssi::Surface tools meet them and
says per face how many faces it became; split_body cuts a solid in two by a
surface, the part behind it and the part in front. SMLIB_REV moves to the fork
commit that adds smlib_split_faces and smlib_split_body.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Wrappers of the fork's smlib_planar_faces (a sheet of planar faces from closed curve loops in
one plane, nested by SMLib) and smlib_boolean2d (two such sheets combined as regions of the
plane by SM_API's 2D boolean, the inputs' own curves split where they cross; an empty result
is None). SMLIB_REV moves to the fork commit that adds them (78617dd).
clippy -p solidcraft-smlib --features native --all-targets -D warnings: clean.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A boolean is SMLib's boolean, its history SMLib's tags: the jittered retries, tool nudges, prism
and coaxial routes, the retry result guard and their diagnostics are gone. A rigid placement moves
the record; any other matrix goes through SMLib's transform (new Brep::transformed over
smlib_brep_transform). Bodies apart join as their records side by side (brep part::compound),
with each piece's faces, sources and history; apart means their exact boxes do not meet. A split
is the intersection with a half-space box, with no faces pushed off the plane.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
extend_surface keeps its signature, options and error messages. One model:
SMLib extends the surface past a side of the face's parameter box
(smlib_extend_sheet, CreateExtendedSurface: natural continues the end spans,
tangent G1, curvature G2) and the face stays one face on it, tagged so the
face is Modified and its sides keep their edges. Several picked sides grow
the box on each. Up to a target, the face is extended 50 body sizes past
its edge and trimmed back with trim_keep (SMLib's exact intersection),
keeping the piece the face lies in. Back to the bounds is untrim of the
picked edge's face, in place, with its holes; one already there is
refused. A plane's straight edges with neighbours lengthened still go
through surfaces::extend. Edges are picked on the schema 4 record (samples
of each edge's curve), an edge two faces share or of a hole refused as before.
Not ported (every far edge there was a cubic fitted through marched
samples, which the exact-B-splines rule forbids): an edge that is not a
whole side of its surface's box (trimmed edges, curved planar edges such as
a disc's, a notch), mitred corners on such faces, sides run square to the
edge on a non-box face, and bodies of more than one face. These now answer
"not supported yet: ...". Tangent and curvature no longer add a separate
run-off face: SMLib's G1/G2 extension is one face (the engine's
surface.extend description says so).
Tests ported keeping their assertions: the planar extension, the cylinder
strip along its axis, around and both (now an extruded arc, not a truck
revolution), the extruded strip, the parabola extended naturally (now a
conic extruded), back to bounds (the saddle from loft_sheet and trim),
hostile requests. Deleted, as what they test no longer exists:
neighbours_lengthened_or_square, self_intersecting_extensions_are_refused,
a_disc_grows_by_its_curved_edges, neighbouring_faces_extend_together, the
tangent/curvature run-off half of the B-spline test, and
a_continued_bspline_is_unchanged_on_its_range (the deleted continue_span).
SMLIB_REV: fork 9531966 (tags carried through untrim and extend).
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
untrim keeps its signature and messages. The face is picked in SMLib by a
point inside it (the centre of its largest mesh triangle), holes by their
points; SMLib deletes the holes or rebuilds the face over its surface's
parameter box with the holes kept (fork c6c7fb4). The body goes tagged as
operand 0, so faces and edges come back with their origins; the untrimmed
face is Modified. A face whose span goes all the way round its surface now
closes on the seam instead of being refused.
solidcraft-smlib: Brep::untrim_face (ffi/trim.rs, trim.rs) and
Error::NotExact for SMLIB_ERR_NOT_EXACT.
Tests: ported to the record (loops counted on brep_record; the saddle made by
loft_sheet and trim instead of truck types; the torus face copied out by a
point). Deleted: the_outer_loop_is_found_whatever_order_the_loops_are_in: it
built a truck face listing its hole first; SMLib's import always puts the
outer loop first, so the case no longer exists.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The wrapper of the fork's smlib_merge_faces (SmBrep::RemoveTopologicalEdgesAndVertices): faces
on one surface meeting along an edge become one, edges on one curve meeting at a vertex nothing
else uses become one, and the edges under the given points stay. SMLIB_REV moves to the fork
commit that adds it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The fork's shims now hold an operation SMLib reports done to having done
something (SMLIB_ERR_NO_EFFECT, -1107: a blend that made no face, a face
move or draft that moved no face). It maps to Error::NoEffect, and the
kernel says "SMLib made no change: ..." for blends and for offset, shell
and draft. Case 1080 (chamfer over openings) returned an unchanged body
as success.
The fork pin moves to 6bb2938: the chamfer side fix of the piecewise
merge, the no-effect contract, and SmStatus marked must-use with the
dropped statuses of the shims and of the fillet, boolean, offset and sweep code passed on.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Brep::sweep_placed (smlib_sweep_placed, fork f6f428b) returns the rigid motions
carrying the profile onto the sweep's first, middle and last sections. Each run
of a path with corners now takes its end pose from the last motion (less the
straight lead-out along the end tangent) and its inside seeds from the middle
one, for every path segment kind: the 3D sketch spline next to a corner is no
longer refused. Deleted: the predicted carry along a run (carried) and
point_path::cubic_split, which only it used. SMLIB_REV at f6f428b.
Fork: build + ctest, only smlib_flat_roundtrip's known incline failure.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
On a B-spline face the export now takes each edgeuse's UV trim exactly as
SMLib holds it (EDGEUSE_NURBS_*): the face's parameters are SMLib's, so the
trim is the pcurve, reversed exactly (knots t -> a + b - t) where the
edgeuse runs against its edge, its knots mapped onto the edge record's
parameter where that is an affine image of SMLib's (identity for spline
edges, as_line's map for NURBS lines, the C side's map for lines), and its
end knots set to the edge interval where they differ by rounding (within
the schema's 1e-9 slack, else an error). Changed: export.rs `curves`
(per-edge TrimMap), new `trims`, `mapped`, `Face::given`,
`Edge::trim_map`, the face loop in `native_ordered`, `pcurves`,
`outer_area`.
Analytic faces and circle/ellipse edges keep brep::pcurve: SMLib keeps an
analytic face's trims on its internal rational B-spline (SmCylinder.h:
"the map from one to the other is not linear") and a circle's on its NURBS
parameter, neither an exact B-spline in the record's angle parameters.
brep::pcurve::EdgeUse gains `given`, a producer's exact pcurve taken as it
is (structure and interval checked, moved by whole periods with its loop,
never refitted). Existing construction sites (STEP reader, tests, truck
adapter) pass `given: None`; the existing tests change only for the new
field.
Built, clippy-clean and tested on 4b2c0eaf before the rebase onto
kernel-smlib/no-truck (not built: base in progress).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Over the fork's new smlib_brep_bounds (SmBrep::CalculateTightBoundingBox): the box of a body
from its exact curves and surfaces, for measuring without a mesh on the SMLib kernel.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Through SMLib, in place of "not supported yet":
- A sweep along a path with corners: each smooth run swept on its own and
the runs joined at each corner in a mitre (each run swept on straight past
the corner and cut back to the plane halving it, where the next meets it
face to face), including the corner where a closed path closes; only
moving along the path, the runs meet on the profile. History: walls from
their segments (found half-way along each run), caps where the path ends.
- A free-form path curve (a spline's Bézier pieces, conics) reaches the
kernel as PathSeg::Curve, its exact piece, instead of the sketch's
polyline of lines: SMLib sweeps along the curve itself; truck's sweeps
flatten it as before (now the piece's own polyline within 0.01 mm, which
turns ladder 04/004 into a pass for truck too). Patterns along a path
flatten it and measure as before. A sweep that twists, scales or follows
rails places its stations by length along the curve.
(Such a controlled sweep still refuses a path with corners.)
- A loft through sections with holes: each section's outline and holes are
one SMLib profile, the holes matched as for truck.
- A loft to a point: SMLib's pyramid (smlib_loft_to_point).
- A draft extrusion with a straight foot: the foot's prism and the drafted
part (sloping from the foot's top to the far end the taper gives) joined
face to face; each segment names its foot and its sloping wall.
Cases now passing on SMLib: booleans/3633, sweeps/1184, 2435, 3111, 3006,
3505, 561, 96, ladder 04/003 and 004.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The fork's new smlib_loft_to_point (a pyramid from a planar section of lines
to an apex) as Brep::loft_to_point. The pin brings the sweeps' other
changes: a loft's section may hold holes (loops lofted loop to loop), a
sweep along a straight path is an extrusion and one turning with arcs about
one axis a revolution (exact walls), and a sweep round a closed path closes
its walls on each other, without caps.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The wrapper of the fork's new shim (61ee7f5): a planar profile placed
by an affine map at each station, the walls skinned through the
sections, the ends capped, open, or joined round a closed path
(Ends). Tests: a twisted square (V = A L), a scaled disc (frustum), a
square carried round a circle with its ends joined (Pappus), and
singular or too few stations refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
SMLIB_REV moves from 276b509 to capi-solidcraft 2d7c7ed: a fillet crash at an
unsupported corner (#453), rounds ending on a tangent seam (#418), radius laws
with a corner (#430) or that cannot be evaluated (#458), a round over a hole
(#422), a sphere's own patches kept apart (#423), offset surfaces extended the
same way whatever was evaluated first (#419), swept walls sharing their planes
(#434), the internal thread's last vertex gap (#410), shells across rounds
thinner than the wall (#397), nested shells imported in any order (#388) and
the tessellator held to its chord tolerance (#390).
Three tests follow: a radius law with a corner is now built, so the SMLib
tests check its volume (8000 - (1 - pi/4) 20 28/3) and that a law pinching to
zero inside the edge is refused; the split coil's halves now measure within
1e-5 of the closed form, so they are held to it rather than to the whole
coil's mesh, which is only within 3e-3.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Without the native feature nothing reads a sweep's curve list, and clippy -D warnings
refused its two fields as dead code. The list is built through List::new in both builds;
only the native build keeps the slices the C API reads.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
An SMLib result where one shell uses an edge four or more times (a hole tangent to the outline,
touching holes, stepped cuts touching along a line) was refused as "not supported yet: a solid
touching itself along an edge". The export now reads SMLib's radial order round each edge
(EDGEUSE_NEXT_RADIAL, EDGEUSE_RADIAL_ENTRY) and the side of each face its material is on, and
gives each pair of faces across one sector its own copy of the edge: the pairs across material,
so the surface is cut apart round each wedge of material, unless one face would get two copies
(a face on both sides of the line), which SMLib's check refuses as coincident edges (tests 33,
34); then the pairs across the empty sectors, so that face keeps one edge on both sides, as
SMLib's crack edges do. The vertices at the ends stay shared: copies would give a face passing
the point twice two coincident vertices, which SMLib refuses too (test 32). Geometry unchanged;
each copy keeps its edge's tolerance and history (Order.pieces). The radial arrays are checked
as hostile input (in range, cycles on their own edge).
Tests: a hole tangent to a block's outline exports with the line copied once per wedge (each
copy joining faces on one side of it), every edge two uses, and goes back into SMLib valid at
the same volume; a blind hole tangent to a side leaves the side a crack; through SMLib both come
back as one solid with verified history and empty validity.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Flat faces tilted by an angle about the line where each meets a neutral plane, leaning in along
the pull, and the faces around them extended or trimmed to meet them
(tangency-labs/smlib@e1ac3c3, SMLib's local operation). A face that isn't flat or isn't parallel
to the pull is Error::Unsupported. The test drafts a cube side by +-5 degrees, removing or adding
the analytic wedge to 1e-6.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brep::chamfer_sides reaches the fork's smlib_chamfer_sides: `distance` back along the face
whose outward normal leans most along a given direction, the other side by a second distance
(ChamferSecond::Distance) or at an angle to the first face (ChamferSecond::Angle). The fork's
smlib_fillet_variable refuses a radius law with a corner with SMLIB_ERR_UNSUPPORTED, which the
crate reads as Error::Unsupported ("not supported yet"): SMLib's section fit ran smoothly
across the corner and missed the law (4 -> 2 -> 4 on a 20 mm edge took 35.1 mm3 for 40.1;
tangency-labs/solidcore#430). Both are in the fork at the pinned bf7c272.
Tests (ops_tests.rs), against analytic values: 5 and 2 either way round (the centroid tells
which face took the 5), 5 at 30 degrees, rejected arguments; a quadratic law 4, 1, 4 and a law
down to zero (1e-5), the corner law refused and the same points joined C1 built.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Where two edge uses of a loop meet at a pole (meridians of a sphere), the periodic parameter's
jump there is free, and the pcurves took whichever jump made the loop counter-clockwise. Two
meridians a three-quarter turn apart bound a quarter of the sphere or three quarters of it, and
the loop alone can't tell which: a half disc revolved 270 degrees on SMLib came back as a quarter
ball turned inside out (sweeps/2667, V = -226 against 678.6).
pcurve::pcurves_within takes the face's parameter box, as SMLib gives it, and picks the jumps
whose extent in that parameter is nearest the box's; pcurves is unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Schema 4 lets a circle or ellipse edge run up to one turn past its seam
(a quarter arc after the seam is [2π, 2.5π]); SMLib's circles take angles
within [-2π, 2π], and the flat import refused the whole body as invalid
input. The mapping now gives SMLib the same arc a whole turn back, and moves
the edge's pcurves on B-spline faces by the same amount, since their
parameter is the edge's. step-conformance's plate_100_holes now imports.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Imprint cuts each face of a body where a tool body meets it (the fork's
smlib_imprint, SMLib's imprinting boolean) and gives None where the tool
crosses no face. Trim builds on it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>