Commit Graph
6 Commits
Author SHA1 Message Date
jyvikoandClaude Opus 5.5 9da160892a Tessellation: two corners of a face a hair apart, within their tolerance, are one point of it
A planar boolean leaves a cut-out's corner that touches another loop's corner as two vertices
a hair apart: in the sheet refold tests (doc sheet a_cut_out_on_one_side_of_a_bend_line... and
a_cut_out_with_a_corner_on_a_bend_line...), a triangle's corner 1e-8 to 5e-8 mm from the base's
corner on the bend line, both vertices of tolerance 1.05e-4. Their loops then cross by 1e-8 in
(u, v), which no constrained triangulation can keep, and the face was left to the lenient fill.

The boundary build already makes a vertex the face passes twice one point of its (u, v). Now a
vertex within the tolerance of another of the face's vertices (the larger of the two, at most
the chord tolerance) takes that one's parameters too, so the loops touch at one point, a pinch,
as at a shared vertex. Not for two vertices an edge of the face joins: the edge says they are
two points, however near (a_ledge_beside_an_edge_as_tall_as_the_setback_goes_with_the_strip
has a 1e-4 mm step, within the vertices' 1.18e-4 tolerance), nor at a pole.

Test changed, with the reason: thread_display_mesh_stays_on_its_surfaces checked every triangle
whose three corners lie at the core radius rc as one of the core cylinder, and wanted its centre
within 2 tol of rc. The flat end disc of the M10x1.5 thread (z = 12) has its corners a hair
apart too; joined, it is meshed strictly from its boundary (a plane, e39fbdebb), and one of its
triangles has its three corners on the rim, centre at r = 3.956, on the disc. The end-disc
exemption the test already makes for its radius check now covers this check as well.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 07:32:44 -04:00
jyvikoandClaude Opus 5.5 eb40e161de Tests: the thread whose display is checked is made as the thread feature makes one, with exact helices
thread_display_tests sewed its M10 and M12 threads from cubic Bezier pieces approximating
helices, which lie about 1e-5 mm off the core and crest cylinders. No exact (same-parameter)
pcurve exists on the cylinder for such an edge, and SolidCraft's pcurves are exact B-splines
only. Sewing refused the core face ("no exact pcurve of a B-spline on a spline surface"). Truck
had fitted one. The thread feature makes its helices exactly, with SMLib's screw sweep, so the
test now does the same: the ISO ridge's section is screw-swept and joined to the core cylinder.
The section reaches a tenth of a pitch into the core along its flanks. ridge_volume is still the
thread's exact volume, and both display tests run unchanged, from the body as made and after a
STEP round trip. Imported edges that lie off their surfaces stay refused; they are Repair Part's
job.

The quality check's sag is now measured at the surface point nearest each triangle's centre.
Before, it was read at the mean of the corners' parameters. A closed surface's parameters are
kept within one period, so a triangle across the core's seam had corners a period apart, and
their mean read 6.27 mm off a triangle that lies on the surface.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:07:50 -04:00
jyvikoandClaude Opus 5.5 a0e17daa5f kernel: cargo fmt
Formatting only, so the kernel passes cargo fmt --check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 42997a62ed WIP kernel: Body::mesh(&MeshTolerance) as the one mesher (does not build yet)
Body::mesh / mesh_plan / mesh_of and MeshTolerance (chord, display, display_of, export_of)
replace tessellate, tessellate_with, display_mesh*, display_plan*, reference_display_mesh_angular;
every caller in kernel, doc, engine, io, ui-egui, gpu and the CLI renamed mechanically; the
truck-mesher fallback, mesh_shells*, refined* removed; Body::new orients from the planner;
truck-meshalgo dropped from Cargo.toml with the tests of its hooks. Still to fix: trait imports
in tess/*, splitface/lumps/preview/step_in/boolean_record meshalgo uses, measure.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:47 -04:00
NOWN-DEV c7bb64dd74 feat: a slanted or curved edge across a sheet metal bend folds to a smooth curve of few pieces (#1799)
Thanks @NOWN-DEV.
2026-10-16 16:26:15 -04:00
bherbruckandClaude Opus 5.5 8535d229ff Display helical-trimmed faces from imported threads correctly (#1289) (#1300)
A modelled thread as other CAD systems write it to STEP has cylinder faces trimmed by helices
that turn several times around the shaft, and cylinder faces bounded by two circles with no
seam edge. The display planner refused any face whose boundary winds around its surface, so
the whole body fell back to the reference mesher, which drew those faces with triangles across
the solid.

The planner now cuts such a face along a parameter line into one period: every loop and its
copies a period apart are clipped to the strip, and the parts of the cut line inside the face
join the pieces into closed loops, with the seam nodes made once for both sides. The cut face
is meshed by Delaunay with sag refinement, and the sag check runs once more after shaping.
Bodies with a face trimmed by more than one turn take their reference mesh (picking, measuring,
the CPU viewport) from the plan too.

Tests: an ISO M10x1.5 and M12x1.75 thread built from helices, as made and after a STEP round
trip: the display mesh stays within the tolerance of its surfaces and the thread's volume, and
has no degenerate, sliver or flipped triangles.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-15 00:51:30 -04:00