The Design preference surface_extrude_symmetric_per_side, which gave new
symmetric surface extrudes their distance on each side, is removed with
its Surfaces section, its session field and its labels. A symmetric
surface.extrude given no convention splits the total around the start
plane, as solid.extrude does; timeline.edit and timeline.redefine give a
one-sided extrude made symmetric the same. default_extrude_convention,
which only existed to read the preference, goes too.
An explicit `convention: legacy_per_side` and the marker saved designs
carry are unchanged. A saved preferences file that carries the key loads
as before (the prefs test now covers both removed keys).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Design preference metric_tap_drill_major_less_pitch, which gave new
metric tapped holes the major diameter less the pitch (M8: 6.75 mm), is
removed with its Holes section, its session field and its labels. A new
tapped hole given no diameter drills the tap maker's drill (M8: 6.8 mm);
a custom metric size the table lacks still takes the major less the pitch.
A saved preferences file that carries the key loads as before: serde
ignores keys Prefs doesn't have, and the key is not written back.
The preference's UI test becomes an engine test of the default drill
(M8, 1/4-20 UNC, a given diameter) and a prefs test that a saved file
with the removed key still loads.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Face and edge names stored before format 14 were worked out from geometry and
open marked `?`. They were found among the names geometry gives today, as the
builds that saved them found them, pieces by the one nearest the pick. They
find nothing now: the feature holding one fails, asking for its reference to be
picked again, which stores its exact name. The legacy face and edge names a
body worked out for them are gone.
The tests that found such names as saved now assert the request to reselect:
a saved strip projection, a version 9 emboss on an annulus, a format 10 face
sketch and the corpus design named with numbered pieces.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face or edge name a feature stored finds only the face or edge it names: the
very name (or a synonym of that face), or the named piece told apart by the
faces around it. A face split into several pieces, merged into another face,
or left only as a face of the same stem is not the face that was picked, and a
name found on several bodies is told apart only by the body the reference's
point lies on. The fallbacks are gone: no piece nearest the pick, no merged
face, no edge at the picked point, no lost link that keeps its last geometry.
A feature whose stored reference finds nothing fails with DocError::Reselect:
blends, face points, sketch planes, sketch projection links, construction
references, hole reference edges, sheet bend edges and cylinder emboss.
The tests that asserted a fallback now assert the request to reselect: split
and removed fillet edges, a merged or rejoined face, a projected edge that was
split or is gone, a projection whose body went, saved strip projections after
wall coalescence, a fillet saved on a piece of a tapered side that is whole
now, a cut that starts from a piece that is no longer that piece, and a fillet
named on the lower of two stacked boxes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With input and output schemas. The mode is the session's user setting:
kept when another design is opened, started, recovered or imported (each
evaluated under it), and by timeline.compute_all. Linked and extracted
designs are evaluated under it too.
A joint drive with contact on tested each sample and each of 14 bisection
steps with a brute-force mesh-against-mesh overlap check, its cost the product
of the two display meshes' triangle counts under a fixed budget. Since the
display mesh puts nodes inside planar faces, a cam and its tappet or a block and
a sphere exceed that budget ("motion exceeds contact sweep collision budget"),
and whether a motion may run depended on display tessellation.
Now, at each sample, bodies whose exact boxes meet are intersected exactly
(SMLib boolean, exact volume); a shared volume is a contact, a touch (a cam and
its follower) is none. Between the last clear sample and the first overlapping
one the drive closes in by conservative advancement: from a clear placement it
moves no point of the pair further than the pair's exact gap (body_distance),
until the gap is within 1e-9 of the bodies' size. Only clear placements are
measured, so no intersection is asked to tell touching from overlapping within
its tolerance (SMLib's boolean fails there, status 1001, on two cubes 1e-4
into each other). The budget is 2048 intersections per drive.
Fixes cmd::joints::tests::cam::a_cam_drives_a_closed_loop_and_stops_at_a_contact
and contact_sweep ordinary_curved_bodies_stop_at_their_contact_within_the_sampling_budget,
and the other contact, cam, motion, interference and clearance tests pass.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The test it replaces probed for a polyline by placing a 0.2 um square in the
gap between the rim and a 1 um polyline: a micro feature in a millimetre part.
This one asserts the property itself, in millimetres: every rim segment of the
flat pattern is an arc of radius 10, the DXF draws one circle of radius 10, and
a 1 mm cut 0.5 mm inside the rim stays one hole.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
patch_continuity_and_points_cap_a_tube listed "g3" among the values surface.patch must refuse,
from #1521 when a patch built G0 to G2. Since cb8712aa0 Construction::Patch builds G0 to G4
(continuity_order.rs: `Construction::Patch => (G0, G4)`), so g3 is accepted, as it must be;
the order above what a patch builds is g5.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tiny_cut_inside_exact_circle_survives_unfold_refold_and_dxf cut a 50 nm square 0.2 um inside
the disc's rim. SMLib models at a zone tolerance of 1e-4 mm: its check refuses the cut's 50 nm
walls as planes "degenerated to a point (tolerance=0.0001)", so the extrude was refused. A
feature below the kernel's resolution is not one it can keep, on any path.
The test's point is that the exact circle, not its display polyline, bounds the flat pattern:
a cut between the two must survive unfold, refold and the DXF. The polyline at 1e-3 has 224
chords (sagitta 10 (1 - cos(pi/224)) = 0.98 um), so the square is now 0.2 um across, centred
0.4 um inside the circle on the first chord's bisector: outside the polyline, inside the
circle, its walls and its 0.3 um gap to the rim above 0.1 um. Its hole's area is
(2e-4)^2 = 4e-8 (was 2.5e-9 for the 50 nm square).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Zebra, Draft, Curvature Map, Environment Map, Accessibility, Continuity,
Isocurve and Curvature Comb are one group: turning one on turns the one on
before off (Session::analyses_off), and the session says which is on
(Session::active_analysis). The new inspect.analysis names it and off: true
turns it off (typed contract and reply). The toolbar shows the active one's
button pressed, its tool running or not. Curvature Comb's button toggles:
on, the tool combs the edges clicked; again, off and the combs go; Esc or a
right click in the tool turns it off; opening another dialog leaves it on.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
inspect.curvature_comb keeps what it shows in the session (Session::comb):
add: true combs the new picks together with those shown, so every comb
shares one scale and tooth lengths compare across curves (a curvature jump
where two edges meet shows); with nothing picked it draws those shown again
with new options; clear: true ends it. Each sketch curve keeps its own
sketch. The tool runs it once per pick and per Comb length / Teeth change,
and the viewport draws the session's combs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A curvature-continuous fillet (type curvature, equivalent radius 2) of the three edges at a top
corner of the owner's bar built, but its corner was SMLib's own patch, which is only tangent to
the rounds: Continuity Analysis measures a 35.8 / mm curvature jump across its seams (with the
rounds G2 to the faces everywhere else), and it shows as a dome sitting on the corner, the
vertical round's shading lost under it. All three edges were rounded; the corner was not
curvature-continuous, and nothing said so.
Such a corner, where three or more rounded edges meet, is now set back (1.5 r unless a setback
names it) and left open by SMLib with the curvature sections (smlib_blend_setback_open with
SMLIB_BLEND_CURVATURE), and filled with the G2 patch fillet_g2_corners already uses for circular
rounds (fillet_g2_with_g2_corners). The `corner` option no longer leaves a curvature fillet with
SMLib's patch: its corners are always G2, and setbacks on it set back the curvature rounds (they
were circular rounds before). Where SMLib or the patch cannot build it, it is refused.
On the reported geometry every seam of the rounds and the patch is G2 (rig
report-fillet-curvature-three-edges-at-bar-corner-solver-residues), and the rounds outside the
setback cube measure exactly: V0 - 27 - (the quintic section, A2 = 0.597884, along the front edge
from 3 to the wall and along 7 and 13) = 9541.116961 (...-outside-setback). With round coordinates
SMLib's open sheet fails its own check (a 2D curve cusp, SmBSplineCurve test 13): the fillet is
refused, listed as known failing (report-fillet-curvature-three-edges-at-bar-corner).
Test: corner_g2_tests::curvature_rounds_meet_at_a_g2_corner (box corner, r5: the patch's jump
under CURVATURE_SHARE / r clear of the hole's corners, SMLib's own patch over ten times that).
Changes a default: a saved curvature fillet with such a corner rebuilds with the G2 patch; there
is no preference or fallback to SMLib's patch.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A colliding pair past the 16 pairs whose volumes are worked out, or past
the check's 256 body intersections, or whose intersection could not be
made, fell back to the sampled mesh depth for its deepest step. That
changed what deepest_step means without saying so. Such a collision now
answers deepest_step and volume_mm3 null and not_measured naming the
budget it ran past (or the intersection that failed), as compare does
since #9132; first_step, last_step and steps are exact and stay.
B pushed through A at 1000 samples overlaps it at about 330 samples, past
the 256 intersections: not measured, "the check's 256 body intersections
ran out". At the study's 16 samples it is measured, deepest at step 15.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
motion.interference picked a collision's deepest step by the depth sampled
on the contact meshes (vertices, edge midpoints, triangle centres), and
worked out the exact shared volume only there. That depth depends on where
the mesh puts its points: since planes mesh as their boundary's triangles,
the arm turning into a block (rig case
assemblies/cov-motion-interference-arm-into-the-block) sampled 4.64 mm at 60
degrees and 2.0 mm at 90, and the check answered step 6 with 536 mm3. The
exact depth is 5 mm at every step from 60 to 90 degrees (both slabs are
10 mm thick), so depth cannot tell those steps apart.
The exact shared volume is now worked out at each sample a pair overlaps,
and the deepest step is the first with the most (a tie keeps the earlier
sample). The arm and block share 536, 807, 952 and 1000 mm3 at 60 to 90
degrees, so it is step 9 with 1000 mm3, at 10 samples or 19. depth_mm is
reported as before and documented as an estimate from the contact meshes.
volume_mm3 is null, and the step falls back to the sampled depth, when the
volume was not worked out at every sample (more than 16 pairs, or past the
boolean budget, raised from 64 to 256 now that it covers every sample).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`inspect.curvature_comb` read the display mesh for model geometry: an
edge's comb fitted a circle through every three points of the nearest
mesh polyline, a face's did the same on its iso lines' chord points. The
comb was jagged, changed with the mesh tolerance and ignored `density`.
- geom: `CurveEval::jet`, a curve's point, unit tangent and curvature
vector kN from its first two derivatives (lines and conics in closed
form, B-splines and NURBS from the basis functions' derivatives, a
traced intersection from both surfaces' normal curvatures along its
tangent, by Meusnier: kN lies in the plane of the two normals and its
component along each is that surface's normal curvature).
- kernel (curvature_comb.rs): the edge nearest a pick by the exact
distance to its curve (a periodic face's seam and poles left out),
`density` teeth at even steps of the edge's parameter; along an iso
line, the surface's normal curvature n.S_tt / |S_t|^2 along its normal.
`IsoLine` carries the running surface parameter's span.
- engine: edges and faces use them (and `inspect.minimum_radius` on
edges); new optional `length` multiplies the automatic scale. The reply
keeps its shape.
Tests: a circle edge reads 1/R to 1e-9 at Coarse and Ultra display
quality alike, with `density` teeth; an extruded ellipse's edge matches
ab/(b^2 cos^2 t + a^2 sin^2 t)^(3/2) at every tooth, a/b^2 and b/a^2 at
the vertices; a cylinder face's rings read 1/R and its lines 0; `scale`
and `length` set the teeth's length; curve jets on every record kind.
The existing cylinder-edge check tightens from 0.5 mm to 1e-9.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ordinary_curved_bodies_keep_a_practical_sampling_step asserted
ContactGeometry.step > 1.0, an internal sampling step derived from the
bodies' display meshes. What a user gets is the drive: it either stops at the
contact or is refused for running out of the sampling budget. The test,
renamed ordinary_curved_bodies_stop_at_their_contact_within_the_sampling_budget,
keeps that: the slide drives to -30 without a budget error and stops in
(-5.02, -4.9) (the sphere r 5 about x = 20 and the box from x = 15 meet the
block's x = 10 side after 5).
It still fails on develop with "motion exceeds contact sweep collision
budget": the planar faces meshed as grids, which the planar-tessellation fix
(#9307) addresses.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
free_form_profiles_extrude_exactly asked for an ellipse extrusion of exactly
3 faces and a spline-and-line extrusion of at most 5: how many pieces the
kernel cuts a closed side into. It now checks that the sides are exact.
Ellipse a = 10, b = 4, extruded 5: area = 2 pi a b + 5 P, P = 4a E(e),
e^2 = 1 - b^2/a^2. By the Gauss-Kummer series, P = pi (a + b) sum_k
(binom(1/2, k))^2 h^k, h = ((a - b)/(a + b))^2 = 9/49: P = 46.026225191330
(a 200000-point midpoint integral of sqrt(a^2 sin^2 + b^2 cos^2) agrees to
1e-13). A = 80 pi + 230.131126 = 481.458538 mm^2, asserted to 1e-4; a faceted
side would be short of it. Only the top and bottom are planes
(face_types.plane = 2, merged pieces counted once).
The fit spline closed by a line: the planes are its top, bottom and the line's
side (face_types.plane = 3); its volume stays checked against the profile
area.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_mirrored_or_patterned_sheet_body_is_sheet_metal_with_its_flat_pattern
(1171c4c2a) expected the mirrored copy's model turned over: the same outline,
its bend down and its pocket on top. That describes a SheetBody::moved that
never landed. The code on develop is SheetBody::copied (d9d6af51c, #3354): a
mirror moves the frame and mirrors the flat x -> -x with the same thickness
side, the opposite hand's blank with each bend turning the same way, which
a_mirrored_sheet_copy_is_the_opposite_hand_with_the_mirror_image_flat_pattern
asserts on an asymmetric bracket. The YZ mirror keeps z, so a pocket cut from
below stays below and the flange on y = 0 still turns up: the flat pattern
reads blank x 0..100 -> -100..0, pocket x 20..30 -> -30..-20, side bottom,
bend up.
The test now asserts that: the same flat size, the outline and the pocket
outline equal to the source's with x negated (to 1e-6), pocket side bottom and
bend up on both. The volume doubling, the bend table and the flange rebuilt
on the copy (point containment) stay.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_trays_faces_have_readable_sheet_names_that_follow_its_size asked for
exactly two unnamed faces (the hole's wall in two halves) and for the back
rim's named point at y = 199.5, the strip's centre line. The first is how many
faces the kernel makes a cylinder of; the second is where the face's roomiest
display triangle lies (naming::face_spot), any point on the face.
Now: there is an unnamed face and every one is the hole's wall (r 3.3), and
the back flange's far rim point lies on that rim: z = 30 and 199 <= y <= 200
(the flange 1 thick, its outside at y = 200), 0 <= x <= 400, to the 1e-3 the
test had. The right flange's top (the plane x = w - 1) keeps x = 319 and 399.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fillet_the_knife_edge_at_the_tip (features_more_tests.rs) and
blend_a_knife_edge_where_a_curved_wall_runs_out (tests/robustness.rs) build
the same #851 part with the same script, round the same knife edge at
(62 1/6, 0, 5) with R2 and measure the removed volume through the same display
plan. The first integrated the removed area on a grid (5e-4); the second has
it in closed form. Drop the first and keep its tolerance on the second.
The ball 2 from the back face y = 0 and from the r 21 wall about (62 1/6, -21)
is centred at (62 1/6 - sqrt(168), -2). The removed section is the trapezoid
wall centre, tip, (kx, 0), ball centre (sqrt(168) wide, 21 and 2 high) less the
wall's sector theta = acos(19/23) and the ball's sector pi - theta:
10 (11.5 sqrt(168) - 220.5 theta - 2 (pi - theta)) = 119.648812 mm^3
the constant the kept test has; the dropped test's grid gives 119.6487 at a
0.004 x 0.001 step. The kept test's fillet bound goes from 0.5 to 5e-4 of
that (0.0598), the dropped test's. Its chamfer row (159.236451, the chord
triangle less the wall's segment) already says the chamfer takes more.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Stale since 84bd2daad, which gave solid.fillet each pick's tangent chain by default. After the
long top front edge is rounded, the front-left upright meets the round's end (the quarter circle
on the left face) along its tangent, and that circle meets the top-left edge along its tangent:
the second fillet rounds the upright and the top-left edge. The "together" fillet picks the
three edges ([20, -21, 10], [0, -21, 5], [0, -10, 10]); one by one and together remove the same
volume within the display meshes' 2e-4 (it read 60.649 vs 43.185 with two picks).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The test offset the sphere's top patch to get a fitted B-spline sheet. That held on truck,
whose sphere came in several patches and whose sphere offset was fitted. On SMLib the
sphere is one face: offsetting it closes up, so it is a solid by design (surface_offset.rs,
"Faces that close up make a solid", and its test a_sphere_is_fitted_and_refused_past_its_centre
asserts exactly that), and SMLib's offset is exact, a sphere of radius 22 with no control
points, which surface.fair refuses. Body::is_surface was right: the record lists the offset's
closed shell as the outer shell of a material region (Parts::canonical), so it is a solid
whether read from edge uses or from regions.
The test now fairs the patch on the non-planar rim of a box cut by a sideways cylinder (the
cover in patch_trim_thicken_and_stitch), a one-face B-spline sheet: energy 0.7185 → 0.6938 in one
step, edges unmoved bit for bit, undo/redo/reopen and the refusals as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The refusal "capture the source occurrence position before generating a
legacy face profile across components" lost its test when Offset Face got
an exact history name (b6c3bf3c5). A half of a box's top that Split Face
divided still has neither a construction certificate nor an exact history
name, so Extrude from that face, in a component whose occurrence has an
uncaptured move, takes the legacy path and is refused there; the document
and the pending moves stay as they were.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The kernel switch broke these tests only through their counts, which record how a kernel splits
faces rather than whether the result is right. Each now checks its intent:
- a fitted circle is the exact circle (centre, radius, a full turn), not "one segment";
- the tight bend sweeps a valid solid of Pappus' volume, πr²(40 + 5π/2), not a count of faces,
edges and vertices;
- the Pi case keeps each outer side one face, stays valid after every feature and rebuilds the
same topology at 32 whether built there or edited there, without a hard-coded table of totals;
- a certified paint stays on the wall's radius and covers as many faces after an edit, a copy
and reopening as when it was painted;
- the offset sleeve and the extended strip are checked by their exact areas only.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fillets_on_tapered_bosses_saved_before_still_find_their_edges compared the part with
69454.885209 mm³, what the truck build that saved it measured. In closed form: the 80 × 40 × 20
block (64000); the 20 × 20 boss 10 high tapered 5° in, a frustum to a 20 − 20 tan 5° square
(3660.251034); the Ø16 boss tapered alike, a cone frustum to radius 8 − 10 tan 5° (1798.751833);
less the R1 round on a sloping corner, the corner's section r²(cot φ/2 − (π − φ)/2) at its
dihedral angle φ = 90.435° times its length between z = 20 and 30 (2.124401), and the R0.5
round all round the cone's top, the section at the rim's 95° turned about the axis by Pappus
(1.928463): 69454.950004. SMLib's part measures 69454.950004.
The test still fails before that check: Fillet2's saved edge `F4:side:c1#1|F4:top#[F4:side:c1]`
names a half of the cone wall truck built, which SMLib builds whole, so it is found with a
"was split" warning (a persistent-name question, see the PR).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since 0a216d692 tangent and curvature extensions are SMLib's G1 and G2 extension of the surface
(smlib_extend_sheet, CreateExtendedSurface), and the face stays one face on it, as
surface_extend's docs say; extend_a_cylinder_strip_every_way still counted truck's separate
run-off face (2). It counts 1.
The test still fails after this, on the curvature run-off's area (see the PR): SMLib's G2
extension of the quarter cylinder by 5 gives 413.882 (a section 4.986 long), where the test
works out the parabola's 418.182.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since 09c979a4b a circle is one closed arc, so an extruded circle's wall, a hole's wall and a
cylinder's side are one face each, closed along a seam. Tests that counted truck's two halves:
- certified_annulus_side_rows_follow_radius_edits_and_clone and
certified_side_transfer_preserves_geometry_and_unsupported_taper_refuses_atomically: the
painted outer wall is 1 face (every vertex of it still at the painted radius), not 2;
- offset_surface_of_a_cylinder_and_a_box_top: the offset sleeve is 1 face (its area 2π·12·20
unchanged);
- press_pull_then_curved_face_offsets_it: a click on the hole's wall offsets its 1 face;
- pi_case_faces_per_step_at_both_heights: each standoff (a ring, Ø6 round a Ø2.5 hole) adds 4
faces, not 6: its outer and inner wall, its top, the floor inside its hole. So 23 after the
first and 35 after the pattern of four; the port openings (3 × 4), the end cut-out (4) and the
five vents (5 × 4) are planar and add what they did: 47, 51, 55, 71.
- the_round_sides_of_a_thin_ring_are_named_by_the_circle_they_run_beside: a thin ring 2 thick
about the R10 circle has two walls, `F2:wall:c1:left` (radius 9: the counter-clockwise
circle's left is inside) and `F2:wall:c1:right` (radius 11), with no numbers; each name is
found again by a point on its own wall.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two expectations encoded truck-era output:
- a_flange_bent_inside_keeps_the_base_sketchs_arcs_in_the_flat_pattern_and_the_dxf: the
DXF has 7 LINEs, 4 ARCs, 11 shapes (was 9, 4, 13). The flat outline is SMLib's exact 2D
union of the plate, the bend zone and the flange panel; a zone's side and its panel's side
meet in line, and a region's boundary has no vertex in the middle of a straight run, so
each flange side is one line: 6 outline lines (plate top, left, right; flange sides and
end) and the bend's centre line. The same reason as 5d25684a1 gave for
a_base_trimmed_for_a_flange_keeps_its_arcs (12 to 10 edges). Areas, the bend length and
the volumes are checked as before and hold.
- hole_beside_two_adjacent_edge_flanges_cuts_and_bends_stay_guarded: the folded volume was
14057.2 +- 0.1, a faceted measure; since 32ae0cd9c the measure is SMLib's exact integral,
14057.3837123. Exactly, a folded sheet holds its flat area A times t, less each bend's flat
strip L·t·(R + K·t)·π/2, plus its sector L·t·(R + t/2)·π/2: t·A + t²·(½ − K)·(π/2)·L. With
t = R = 2.5, K = 0.44, A = 5597.0353454 (the flat pattern) and L = 75 + 35, that is
13992.5883635 + 64.7953485 = 14057.3837120, within 2e-11 relative of the measure. The
test now checks that identity to 1e-9.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When the kernel's room pre-check went (bcbb99005), a fillet or chamfer refused as
too large stopped saying what would fit: only SMLib's NO_ROOM words were left. The
rig expects the refusal to name it (fillets/4782-fillet-two-end-verticals-past-a-full-round:
"the largest radius that fits is 7.5 mm", fillet_max for the exact fit).
A constant fillet with the exact fit, and an equal-distance chamfer, refused as too
large now add "; the largest radius (distance) that fits is X mm", found by the same
bisection fillet_max runs (up to 16 blends, three significant digits), now shared with
a new kernel::chamfer_max. Where the search itself fails (a candidate failing for
another reason), the refusal is left as it was. The reduce and taper fits and the
kernel's own searches call the kernel blends directly and do not pay for it.
Tests: the 14 x 6 x 10 post's R3.5 names 3 mm; a 4 mm rib's crossing chamfers and
rounds at 3 name 2 mm.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
legacy_internal_capture_refuses_an_uncaptured_source_in_another_component
picked the top Offset Face raised as a face with neither a construction
certificate nor an exact history name (#494), to reach the legacy path
that refuses a profile across components while the source occurrence's
move is uncaptured. Offset Face has SMLib's history since 0f3d6f177 (shell,
offset faces and thicken through SMLib), so that top is now named exactly
(F3:+z#[F3:-x], verified) and capture_face_anchor gives it a lineage
anchor; the legacy path is not taken, and the capture is right to
succeed: an anchored attachment captures its path's pending positions
when it is made (capture_positions).
The test, renamed to what it now checks
(internal_capture_in_another_component_anchors_an_offset_face_by_its_history_name),
asserts the face still has no construction certificate, the capture is a
Lineage anchor on the occurrence's path, and capturing changes neither the
document nor the pending moves.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
explode.show put the view's placements in the uncaptured moves, so occurrence.properties reported
the exploded placement and Capture Position (and reparenting, moving bodies between components,
copying or pasting in place, URDF export) wrote the view's offsets into the design. The session
now records which uncaptured moves are the view's (Session::exploded); what reports the design's
placements or works a new placement out from them uses the design's own moves
(uncaptured_moves, design_document), while the viewport and picks still show the view.
New case cov-explode-show-keeps-the-placements: the arm's properties are the same before, while
and after the view is shown, and Capture Position keeps nothing. The two explode cases that read
occurrence.properties while exploded now expect the design's placement, centre (20, 0, 5), as the
command says ("shown only; the design keeps its placements").
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When a − b or b − a cannot be made (a kernel error, or a body that encloses no volume), the
region's volume and centre are null, measured_by is "not measured" and not_measured gives the
cut's error; its deviation, area, faces and box are still given, the side's total is null and
the verdict says the volume is not measured. The integrated-along-lines estimate is no longer
reported as a volume.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
inspect.compare integrated a region's volume along sampling lines: the
40 x 30 x 5 slab between a box and one 5 mm taller came out at 5976.49 mm3
against 6000. The regions are still found from the two surfaces; each one's
volume, centre and box now come from the pieces of the exact cut a - b (or
b - a) that lie there, measured as inspect.measure measures a body
(measured_by: boolean). Where a cut cannot be made the region keeps the line
integral, marked measured_by: lines, with a warning. The rig case
cov-compare-taller-box passes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
inspect.center_of_mass measured each body's display mesh, so a cylinder r 5,
h 10 came out at 784.13 mm3 against 250 pi = 785.40, and the answer moved with
display quality. It now takes the exact mass properties inspect.measure uses
(ModelBody::measure), skips bodies that enclose no volume as Measure does, and
lists what it skipped. The rig case cov-center-of-mass-box-and-cylinder passes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib's parallel projection (CreateParallelProjectionCurves) gives every curve where the
projecting lines cross the face: a line projected down onto a ball came back as its top and its
bottom, each split at the pole, and the link's first wire was half the bottom. A projection onto
a surface is where those lines first hit it (owner's decision, as mainstream CAD does): a curve
is now kept only when the first hit on the body's mesh along the line through its middle is the
curve itself (within 4 chord tolerances), and the pieces that meet end to end are joined in
whatever order and direction they come, a piece run the other way exactly (its knots and
control points reversed; a line's, circle's or ellipse's parameter mirrored). The ball's top
is then one wire from x = -10 to 10.
three_d_sketch_curves now expects that exact curve: one wire, its ends at (±10, 0, √300), every
point of its exact curves on the sphere of radius 20 in y = 0 over the top, to the projection's
own tolerance (a millionth of the body's size), and sweeps_and_pipes_follow_3d_sketch_curves
pipes along the whole joined top. Both pass on the pinned SMLib (90aabff): the pieces lie 9.1e-6
off the sphere against a 4e-5 tolerance and meet at the pole within 4.7e-8 rad, since the fork's
8d95600 keeps the pole's exact tangent in StepBackFromSingularity.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A symmetric surface.extrude given no convention now splits its distance
evenly around the start plane (10 mm: 5 mm each side), the way
solid.extrude reads it, instead of going the distance each way. Both
commands take their default from one function, which a session setting
(surface_extrude_symmetric_per_side) can turn back to the per-side
reading for surface extrudes. timeline.edit and timeline.redefine give a
one-sided surface extrude made symmetric the same default.
Saved designs are unchanged: every surface extrude saved its convention
(legacy_per_side), and one saved before the marker existed reads per side
as it always did. The help of both commands says how the distance is
read. The 3830 kernel case, recorded with the per-side reading, now says
so explicitly.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
picked_edges_give_the_sketch_s_table picked [E + R, 0, 5]: on SMLib's extruded circle that is the
vertex where the side's seam meets the top rim, a pick either edge answers, and it took the
seam. The pick is now a quarter turn round the rim, [E, R, 5]; the product's pick rule is
unchanged (owner's call).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_face_picked_by_point_on_a_block_with_a_modelled_thread_is_found guarded #6720 (the face search
charged the whole mesh once per face) with a modelled thread's 5 000 facets. On SMLib a modelled
thread is a few exact helical faces, so the block had nowhere near the 1000 faces the test
asserts, and the case no longer reached the old charge. A block drilled with 16 x 16 holes does:
the test now asserts its faces times its mesh's triangles is past the search's 2 000 000 budget
(the old charge) while their sum is well inside it (the new), then picks its top by point.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
intersect_keeps_its_exact_cuts pinned the tilted cylinder's section to 21 segments and one
segment's ends to 1e-4: the crossings of truck's mesh. The cut is the mesh's segments, as many
as the tessellation crosses (20 on SMLib's), each end within the section's reach of the surface,
the display tolerance (a thousandth of the mesh's size, doc::project::fit_segments; SMLib's ends
lie 6e-4 off at most, the test's limit is 0.051). The test now checks that every curve is a
line, at least 16 of them, and every end lies that close to the cylinder of radius 5.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ids_names_suppression_marker_and_failures_survive needs a feature that a parameter change makes
fail, to see the failure survive the script's replay. It made a 1 mm round 50 mm, which truck
refused as too big; SMLib builds a convex round wider than its faces by subtraction (the owner's
overflow decision), so that round now succeeds. A radius of -1 mm fails on any kernel, and the
replay still has to keep the failing feature, its id and its marker.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_face_engraved_with_text_projects_its_letters_exactly_and_extrudes counted the letters' pieces
as control-point splines. A TrueType outline's curves are quadratic Béziers, which are parabolic
arcs, and the cut made on SMLib keeps them exact: the projection gives 222 conics and 154 lines,
no splines. The count now takes conics with the splines. (The cut itself needs SMLib 1a1bebc;
with it the test passes.)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
loft_cut_through_a_shelled_basin_in_either_order asserted one body. The loft's top section is
the basin's full 100 x 60 outline at z = 10, so the cut takes the walls' whole cross-section
there and leaves the walls above (z 10 to 30) touching the rest only along their outer rim, an
edge: two pieces, which a cut makes two bodies (eval's lumps rule). SMLib gives exactly that;
truck kept them as one. The test now expects two bodies, the upper one the walls' exact
924 mm² ring times 20 = 18480 mm³, and the total as before (41582.028).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_face_sketch_saved_with_fitted_letters_reopens_and_builds_the_same compared the part with the
5916.018831 mm³ its saving build measured, to 1e-3. The part is the 30 x 20 x 10 block less the
"S" 1 deep and an r 2 circle 3 deep clear of it: 6000 - 46.290121 (the letter's exact profile
area, Sketch2's smaller region) - 12 pi = 5916.010767. SMLib measures 5916.010768 (1.2e-6 off);
the saved figure was 8e-3 off. The test now checks that closed form to SMLib's 1e-8, and counts
the letter's exact pieces as conics or splines (its quadratic Béziers come in as conics).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
unsupported_face_has_explicit_fixed_alternative_and_no_live_projection needs a planar face with
neither a construction certificate nor an exact history name, so a sketch on it must be fixed.
Its face, a split top face offset up, now keeps its history through SMLib's offset and gets a
name. A rib reports no roles for the faces it builds (Traced::unnamed, eval_more), so a rib's
wall has neither: the test now picks the wall at y = 12 of a rib in a bracket's corner.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
interference_lists_a_pair_it_could_not_check needed a pair interference cannot check. Its
pair, an arc revolved up to a post's wall, was one truck could not intersect ("not verified");
SMLib intersects it exactly, and that reason is gone from the code. The pairs left unchecked
are a kernel failure, the time budget, and a mesh body: an imported mesh has no exact surfaces
to intersect (owner's call). The ring is now brought in as an STL beside the post, and the pair
is listed with "mesh body: not checked" instead of passing as clear.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
freezing_rebuilt_arc_borders_keeps_authored_dimension_entity_indices needs the projected
border of the sketch's face to come back with a different number of curves. Truck split the
sector's arc into pieces that changed with its sweep (270 to 300 degrees); SMLib keeps one arc
whatever the sweep, so the count stayed 3. A notch, clear of the sector until a parameter moves
it across the arc at 90 degrees, now splits the arc border into two arcs and the notch's sides.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- A section's chains are walked from either end, whichever segment the mesh's triangle order
puts first at a node (doc::project::fit_segments), so a line's direction says nothing about
the cut. SMLib's box tessellates in another order and the outline came out clockwise: the
same four lines. The two box-outline tests now compare each line with its lower end first.
- The base rim of SMLib's cylinder is one closed circle edge (truck's was two seam halves), so
projecting it gives one exact ellipse. Checked against the closed form: a radius-5 circle in
a plane tilted 45° projects to semi-axes 5 and 5·cos 45° = 3.5355339 (the reported minor
radius), and every sampled point lies on x²/(5/√2)² + y²/5² = 1 within 1e-9, as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Linking a reference (sketch.include_3d, project, intersect) stored the link's wires as points
only: add_link_unless_present called add_link_with_wires and dropped the resolution's exact
curves, which only the next refresh of the sketch filled in (doc::project, since 7952516eb).
So an included box edge had no exact line until any edit refreshed it, and the wire changed
under an unrelated sketch edit. The exact curves are now set with the wires when the link is
made, as a refresh sets them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The thread forms (b4549d270) parse designations in thread_forms, whose refusal for a plain
M28 said "give it: M28x1" and, for M0 or M1e9, still offered a pitch. The hint the hole
command gave (the two coarsest ISO fine pitches that suit the diameter: M28x2 or M28x1.5) is
now thread_forms::no_coarse_pitch, used by both; a diameter no metric thread has is an
unknown metric thread. The test's "unknown thread" follows the forms' wording ("unknown
metric thread").
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>