Commit Graph
264 Commits
Author SHA1 Message Date
brett19 fe98ad07d2 Merge remote-tracking branch 'origin/develop' into ws/next-pin 2026-10-30 23:13:25 -07:00
jyvikoandClaude Opus 5.5 48a7578270 kernel: Split Body by a face of a smooth sheet cuts with the whole sheet
A face tool cut with that face's surface alone, so a face of a surface body made of spans joined
tangent (a fit-point spline extruded, #3830) cut nothing where its span ends inside the body.
Split Body by a face of a surface body now takes the faces joined to it tangentially (the exact
check Extend uses, within the one angle for smooth) and slices with them as they are, through
SMLib's slice by a sheet (smlib_split_body_by_sheet, tangency-labs/smlib 7a01f1b), its sides those
of the picked face. A sheet that only nicks the body cuts nothing, as before; a lone face, or a
face of a solid, still cuts with its surface extended.

3830 comes off the booleans list. Its answer counted the two halves of the cup and not the surface
that cut it, which stays as a body of its own (4879 removes its surface for that reason): three
bodies, the volume unchanged.

Needs SMLib 7a01f1b pinned (SMLIB_REV, prebuilt; its SMLIB_ABI_VERSION 6, which crates/smlib now expects) to link.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 01:19:26 -04:00
jyvikoandClaude Opus 5.5 dd88674140 kernel: Extend grows a surface of several faces face by face
A surface body of more than one face (a fit-point spline's spans extruded, #3830) was refused.
Each face with a picked edge is now extended alone by SMLib's extension of its surface, and the
faces are sewn back together, each the face it was. A side that lengthens onto a face meeting it
tangent takes that face along, past its edge continuing the picked one; across a crease the
neighbour grows only when its edge is picked too, otherwise the extension is refused. Faces whose
lengthened sides no longer meet are refused. Up to a target keeps the pieces every grown face
lies in.

3830's extensions now build; its split still fails (the tool point picks one span, and a face
tool cuts with that face's surface alone), so it stays on the list with that reason.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 01:19:26 -04:00
brett19 cb31c0d4bf Merge origin/develop e18fb40d8 into ws/develop-e18fb40 2026-10-31 04:47:55 +01:00
jyvikoandClaude Opus 5.5 7953944175 Fillet rig: 1668's R7 past the inside corner is refused at 4 + 2 sqrt2
The round's centre (32 - r, 42 - r) leaves the hollow's corner (30, 40)
outside its circle, opening the wall, where sqrt2 (r - 2) = r: the case
expects the refusal naming 6.828. 2852's R30, refused naming 25.24, now
passes too: both come off the known-failing list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 22:19:55 -04:00
jyvikoandClaude Opus 5.5 62fe29dbdb Fillet rig: the cases SMLib 737c392 builds come off the known-failing list
The gate on aarch64 Linux reports 16 fillet cases FIXED with the pinned SMLib: the sloped and
equal-slope basin rim chamfers and rounds past their rims (1080-*, 5835-*), the pocket rim
chamfer past the floor, and the three pocket rim rounds now mitred at the pocket's corners
(every-pocket-*). No other area's gate reports a case fixed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 20c0c2ffcc Kernel rig: a sloped basin's mitred rim rounds are checked tangent along their contact lines
1080-fillet-sloped-basin-1-mm-rim-r0-5-4-edges asked G1 at every blend seam. Its front wall
leans 19 over 20 and the others 10 over 20, so at each rim corner the two mitred rounds meet the
sloped corner edge at different heights (0.155625 and 0.276393 below the top): the deeper round
runs on past the corner edge and is cut by the plane of the other's wall, a crease by
construction, the gap below the shallower round filled on that plane. The check now measures
the rounds' contact seams, on the top and on each wall, where the rounds are tangent. The
volume is unchanged.

With SMLib smlib-batch-4-mitre (1c15364): the case passes (V 144530.427946 against
144530.427909, 15 faces, sound); before it, only the four corner creases failed the check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 9308224ef5 Fillet rig: the knife edge's 0.5 chamfer builds
SMLib's trim took a fillet meeting its face at more than 78 degrees for one with no side
(smlib-batch-4-rulings 971e567); the chord of the knife edge's 0.5 chamfer meets the flat face at
81 degrees. The case comes off the known-failing list.

Needs SMLIB_REV at that SMLib once it is pushed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 3772a6e972 kernel, doc: an overflowing round goes first; an edge it removes is gone, and the fillet says so
SMLib (smlib-batch-4-rulings 0e83cca, SMLIB_ABI_VERSION 5) rounds the edges whose rounds overflow
their faces first and then what is left of the others; smlib_blend_dropping says which picks'
edges the overflow removed whole. The smlib crate binds it (Brep::blend_dropping), the kernel
returns those picks (fillet_removing), and a fillet notes them as its warning: "the edge at
(0, 0, 10) was removed by the larger round, so it is not rounded" (a 50 x 50 x 20 block, R21 on
its bottom front edge with the front left upright: the block is R21's alone, in closed form).

Ruling d8: [21, 5, 5] on a 20 cube builds as R21 alone (6107.529370); the test is no longer
ignored. R25 with R2 at a corner (blend_corner) builds the same way, R25's alone in closed form,
where it was refused. The rig's 1080 notched block outline at R8 builds now and comes off the
known-failing list.

Needs SMLIB_REV at that SMLib once it is pushed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 6f0bf0dea5 Tests: a 1 degree crease rounds, and the knife edge's chamfers build, on SMLib smlib-batch-4-rulings
With SMLib's smooth limit at half a degree (422e6f1) the 1 degree crease rounds R2 and R20
(the test is no longer ignored), and with a cusp's chamfer the ball of radius d (d231547) the
The 0.5 one stays, for its own cause (the chamfer face left apart from the body). Two corner
cases the same SMLib (replay/1.0.1 and those commits) builds come off too.

Needs SMLIB_REV at that SMLib once it is pushed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 21:55:53 -04:00
jyvikoandClaude Opus 5.5 c23ef9d93a Fillet rig: the knife-edge chamfers name SMLib's cause, a cusp's ball radius of 0
smlib_chamfer turns the distance into a ball radius d sqrt((1 - c)/(1 + c)), c the faces'
binormals' dot (capi chamfer_radius); at #851's cusp the binormals agree, the radius is 0 and
the call is SM_ERR_INVALID_INPUT before the fillet executive runs (gdb: chamfer_edges sees
radius 0; the dump's why is empty). SolidCraft hands every chamfer to SMLib, so the
ball-contact chord (the ball of radius d: 3.822 wide at d = 2, 159.2365 removed) is SMLib's to
build.

Ruling d4 (2026-10-30).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 21:55:53 -04:00
Brett Lawson a2deba2690 Merge develop 6d8e002f into solidcore
# Conflicts:
#	crates/ui-egui/src/prefs.rs
2026-10-30 22:47:56 +01:00
jyvikoandClaude Opus 5.5 a71450aebd Preferences: symmetric surface extrudes read only the total distance
The Design preference surface_extrude_symmetric_per_side, which gave new
symmetric surface extrudes their distance on each side, is removed with
its Surfaces section, its session field and its labels. A symmetric
surface.extrude given no convention splits the total around the start
plane, as solid.extrude does; timeline.edit and timeline.redefine give a
one-sided extrude made symmetric the same. default_extrude_convention,
which only existed to read the preference, goes too.

An explicit `convention: legacy_per_side` and the marker saved designs
carry are unchanged. A saved preferences file that carries the key loads
as before (the prefs test now covers both removed keys).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 16:19:33 -04:00
Brett LawsonandClaude Opus 5.5 bb4ff018e5 Merge develop 6700e6ef into solidcore
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-30 20:48:25 +01:00
jyvikoandClaude Opus 5.5 45823002c0 SMLib: pin 68fb916 (tangency-labs/smlib#67)
The owner's bar running tangent into a cylinder rounds its concave arc and
its top edge both together and one after the other in either order, at
r 1 to 7. Two more peg cases come off the fillets known-failing list.

The ladder's shelled dome ring now has 9 edges, not 7: each of its two
cylinder walls is one full-turn face with its seam edge (one wall face per
extruded circle), where it was two halves. Faces, vertices, area and volume
are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvoxKQ2rEZvcXNQnhE3Sgs
2026-10-30 15:19:29 -04:00
jyvikoandClaude Opus 5.5 e43fe1ab04 Kernel rig: diagnostics.validation is a setting, exempt from cases
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvoxKQ2rEZvcXNQnhE3Sgs
2026-10-30 13:52:54 -04:00
jyviko 1a93a39770 CLI: run and kernel-cases take the validation mode
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

solidcraft-cli run --validation MODE, kernel-cases --validation=MODE and
cargo xtask kernel-cases --validation MODE (with --ladder too), so the rig
runs under each mode.
2026-10-30 13:52:54 -04:00
jyvikoandClaude Opus 5.5 292ec65c8e Fillet rig: the chamfer running into the openings is named for what it does
fillets/1080-chamfer-runs-into-openings-refused already expects the
9 mm chamfer built and cut by the openings (V = 3350); its id said it is
refused. It becomes 1080-chamfer-runs-into-openings-cut-by-them, and
blend_fit's chamfer_through_the_openings_is_cut_by_them names it so.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 13:52:26 -04:00
jyvikoandClaude Opus 5.5 1878274cb7 Kernel tests, fillet rig: a chamfer past its rim builds, cut by what lies past it
The owner's ruling of 2026-10-30 (d7): a chamfer that reaches or runs
past a rim builds, everywhere, as SMLib's cliff overflow builds a convex
blend: on its faces' continuations, then cut by what the cliff cuts
away. The earlier rule refused a chamfer whose leg runs off its face.
SolidCraft has no such refusal of its own; SMLib refuses these, so the
cases fail on SMLib 985faaee and are listed with its reasons (traced in
gdb at SmFilletErrorInfo::NoteError):

- the sloped basin's single front edge past its rim (1 mm rim 2 and 3,
  0.5 mm rim 4): CloseRemovalRegion, "a cliff overflow's fillet boundary
  lies on the surfaces of two faces": the sheet's boundary along the end
  wall's top edge line from the edge's vertex to the top's contact
  (x = 20, y from -1 to 1, z = 30) lies on the top's plane and the end
  wall's both.
- the equal-slope basin's rim loop 2 and the 5 mm pocket's rim 5.5:
  CloseRemovalRegion, "a cliff overflow's fillet boundary closes on one
  face" (every edge of the loop blended).
- the sloped basin's front and right edges 2: status 1001,
  SmFilletNx2Corner, CalcFilletIntSideFace.
- the cylinder's rim 2 across the top and 25 down its 20 mm wall: status
  1001, SmFilletNx1ClosedCorner cannot compute its geometry.

Expectations, each from a closed form or an exact quadrature:

- chamfer_wider_than_sloped_basin_rim_is_refused becomes
  chamfer_wider_than_sloped_basin_rim_builds, ignored until SMLib builds
  it: the triangle clipped to y >= 0, times 30 + z (shoelace):
  73.450475, 142.112912, 184.526613; the rig's 1080-chamfer-sloped-
  basin-*-past-the-rim cases: V = 144459.882858, 144391.220421,
  144082.140054.
- blend_corner's a_rim_loop_chamfer_running_off_its_rim_is_refused
  becomes ..._builds, ignored likewise: sliced at depth t the mitred loop
  takes the pocket's rectangle grown by w(t) = d (1 - t / delta) on each
  side, clipped to y >= 0, less the rectangle, Simpson exact on each
  quadratic piece: 375.673069, V = 139957.660264 (the rig's
  1080-chamfer-equal-slope-basin-1-mm-rim-loop-2 too).
- 5835-chamfer-sloped-basin-1-mm-rim-2-two-edges: the same slicing with
  the front and right sides grown, 161.279149, V = 144372.054184.
- every-chamfer-pocket-rim-5-5-past-the-floor: 50 d^2 + (4/3) d^3 at
  5.5, the groove 0.5 deep round the floor included, V = 19265.666667,
  15 faces.
- 2893-chamfer-two-distances-past-the-bottom: the frustum r 8 to 9.6
  over 20, pi 20 (64 + 76.8 + 92.16) / 3 = 4879.102831, 3 faces.

Each drops "-refused" from its id (the 5.5 pocket's says past the floor).
The same slicing reproduces the existing 5835-...-4-mm-rim-2-2-edges
(176.006388), equal-slope loop 0.5 (24.455545) and half-width
(5.426545) values.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 13:52:26 -04:00
jyvikoandClaude Opus 5.5 3a2fac31a1 Kernel tests, fillet rig: a chamfer as wide as its rim builds
The owner's ruling of 2026-10-30 (d7): a chamfer that reaches or runs
past a rim builds, everywhere. The earlier rule refused a full-width
chamfer, naming the largest size that fits. SolidCraft has no such
refusal of its own (a blend's TooLarge is SMLib's SMLIB_ERR_NO_ROOM,
and the doc layer only names the largest fit), and SMLib already builds
these, so only the expectations change, each from a closed form or an
exact quadrature:

- chamfer_wider_than_sloped_basin_rim_is_refused's full widths become
  chamfer_as_wide_as_sloped_basin_rim_builds: the whole triangle,
  d drop / 2 (60 - drop / 3), drop = 20 d / sqrt((20 - margin)^2 + 400)
  (shoelace over the section, its length 30 + z between the sloped end
  walls): 21.662379 (1 on 1 mm), 5.359321 (0.5 on 0.5 mm). The basin and
  the removal move into sloped_basin and sloped_basin_rim_chamfer_removed.
- fillets/1080-chamfer-sloped-basin-{1,0-5}-mm-rim-as-wide-as-the-rim:
  V = 144511.670954, 144261.307346.
- fillets/every-chamfer-pocket-rim-5-full-depth: 50 d^2 + (4/3) d^3 at
  d = 5, V = 19583.333333, 11 faces (the walls used up).
- fillets/every-hole-top-rim-chamfer-10-full-depth: the triangle 10^2/2
  revolved at rho = 5 + 10/3 (Pappus), V = 16000 - 3250 pi / 3 =
  12596.607959, 7 faces.
- fillets/1113-chamfer-arc-top-edge-full-wall-height: the 9.5 case's
  Int rho asin(21/rho) h(rho) drho at s = 10, by Gauss-Legendre in
  u = asin(21/rho), 1303.400331, V = 8287.993768.

Each drops "-refused" from its id and its KNOWN_FAILING line goes: all
five pass on SMLib 985faaee.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 13:52:26 -04:00
Brett Lawson 512cf5bd48 Merge develop f1199f89 into solidcore 2026-10-30 18:47:47 +01:00
jyvikoandClaude Opus 5.5 b4af45dd07 Kernel rig: the horn torus and the circle revolved touching its axis build
SMLib's revolve now splits a curve where it touches the axis inside itself
(tangency-labs/smlib#66), so both cases come off their known-failing lists.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvoxKQ2rEZvcXNQnhE3Sgs
2026-10-30 12:14:18 -04:00
jyvikoandClaude Opus 5.5 7fe880a7bf SMLib: pin f8fd83e (tangency-labs/smlib#66)
The batch brings history Kept for a face only cut by a vertex, revolve of a
curve touching its axis, loops touching at a vertex, a torus rail on its axis,
and the fillet causes behind the owner's bar running into a cylinder: a
tangent edge past a tangent side edge is the corner's edge, the rails of a
round collapsing at its end end at one point, and a trace from a tangent point
starts along the curve.

The two peg cases with the sketch's solver residues come off the fillets
known-failing list: both build.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvoxKQ2rEZvcXNQnhE3Sgs
2026-10-30 12:14:18 -04:00
Brett Lawson 76cdc727e9 Merge develop e46359ff into solidcore 2026-10-30 14:47:33 +01:00
jyvikoandClaude Opus 5.5 e46359ff04 Kernel rig: the patch cases the fill now builds come off the known-failing lists
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 09:17:35 -04:00
jyvikoandClaude Opus 5.5 9a45d42484 Kernel rig: inspect.analysis is a display analysis switch, exempt like the others
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 08:48:54 -04:00
jyvikoandClaude Opus 5.5 9b35727976 Fillet rig: the known-failing list names the report- cases, not their old ids
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 08:02:50 -04:00
jyvikoandClaude Opus 5.5 6cc7597502 SMLib import: an extruded circle is a cylinder over the face's trimmed range
This replaces the spline fallback of 64efbe7f6. A face SMLib holds as a rational spline that is
an extruded circle was recognised as a cylinder over the spline's whole parameter range: for the
upper half of the peg's wall after the front top round that range runs 393 degrees round (u in
[-15, 40.18], SMLib's support surface extended past the face), and SMLib refuses a cylinder past
one turn. The face itself, its loops' box, spans u in [0, 8 pi]: half a turn. The cylinder now
takes the face's trimmed range, the least and greatest u and v of its uses' pcurves over their
edges' intervals, found to rounding on each Bezier span (the values at the pieces' ends bound the
extreme from below, the control points from above; pieces that cannot beat the best are dropped,
the others halved). A face whose trims run more than one turn round is no face of a cylinder: it
is refused as an invalid record, never kept as a spline.

The peg (40 x 16 x 10 bar, R8 end, a disc R8 extruded 10 up on its top, joined), front top edge
rounded r2: the body measures to 1e-7 of its closed form, the three r2 corner rounds after it
build and measure, and the upper wall comes back from SMLib a cylinder of radius 8 (engine test).

The rig case of the round of the edge where that round meets the wall (tangent at one end) still
fails, for another reason: on the wall as its exact cylinder SMLib refuses the round as larger
than the faces beside its edges allow (it fades to nothing at the tangent end) instead of
returning a body its own check refuses. Its KNOWN_FAILING line says so.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 08:02:50 -04:00
jyvikoandClaude Opus 5.5 ccc690c535 Fillets: a curvature-continuous fillet's corners are G2 patches
A curvature-continuous fillet (type curvature, equivalent radius 2) of the three edges at a top
corner of the owner's bar built, but its corner was SMLib's own patch, which is only tangent to
the rounds: Continuity Analysis measures a 35.8 / mm curvature jump across its seams (with the
rounds G2 to the faces everywhere else), and it shows as a dome sitting on the corner, the
vertical round's shading lost under it. All three edges were rounded; the corner was not
curvature-continuous, and nothing said so.

Such a corner, where three or more rounded edges meet, is now set back (1.5 r unless a setback
names it) and left open by SMLib with the curvature sections (smlib_blend_setback_open with
SMLIB_BLEND_CURVATURE), and filled with the G2 patch fillet_g2_corners already uses for circular
rounds (fillet_g2_with_g2_corners). The `corner` option no longer leaves a curvature fillet with
SMLib's patch: its corners are always G2, and setbacks on it set back the curvature rounds (they
were circular rounds before). Where SMLib or the patch cannot build it, it is refused.

On the reported geometry every seam of the rounds and the patch is G2 (rig
report-fillet-curvature-three-edges-at-bar-corner-solver-residues), and the rounds outside the
setback cube measure exactly: V0 - 27 - (the quintic section, A2 = 0.597884, along the front edge
from 3 to the wall and along 7 and 13) = 9541.116961 (...-outside-setback). With round coordinates
SMLib's open sheet fails its own check (a 2D curve cusp, SmBSplineCurve test 13): the fillet is
refused, listed as known failing (report-fillet-curvature-three-edges-at-bar-corner).

Test: corner_g2_tests::curvature_rounds_meet_at_a_g2_corner (box corner, r5: the patch's jump
under CURVATURE_SHARE / r clear of the hole's corners, SMLib's own patch over ten times that).

Changes a default: a saved curvature fillet with such a corner rebuilds with the G2 patch; there
is no preference or fallback to SMLib's patch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 08:02:50 -04:00
jyvikoandClaude Opus 5.5 a9755bdd23 Fillet rig: the owner's reports are report- cases; the G2 corner graded at its seams
The cases from the owner's reports in the app (no issue) were named and cited after issues they
only resemble (#9, #896, #1207). They are report-<name> now and list no sources; their `what`
says where they were reported. The README gives the convention (report- for a report with no
issue or pull request, cov- for a command with no source).

report-fillet-g2-corner-of-bar-running-into-cylinder was graded by a 3^3 volume band and a face
count, which say little about a G2 corner. It keeps the band (provable: the patch differs from the
rolling ball only within the setback cube) and adds the corner seams' curvature jump, as
fillets/9-fillet-corner-r1-curvature-default-setback scaled by r = 2 (at most 0.0025 / mm, clear
of the hole's corners by 0.48 mm, within 4.4 mm of the corner). A new
...-outside-setback case cuts the setback cube [-1, 3] x [-1, 3] x [7, 11] away and grades the
three rounds outside it exactly: V0 - 27 - (front spandrel from x = 3 to the wall + (1 - pi/4) r^2
over 7 and 13) = 9342.029541. The bare face counts are dropped.

The -solver-residues recipes now take the reported sketch's points exactly (the arc's end
x = 41.649711830726524); they fail as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 08:02:50 -04:00
jyvikoandClaude Opus 5.5 de9c005f2b Blends: a blend face is named by its picked edge, not an edge it took up
A 220 x 11 two-distance chamfer of a tapered plate's bottom front edge (rig fillets/5181) runs up
the front face past its straight side edges, l2|start and l6|start, and takes them up: no result
edge comes from them. SMLib leaves the blend face untagged, and it was given every blended edge
whose two faces lie next to it: the picked edge l1|start and both taken-up side edges. Its name
came from the first in edge order, F3:blend:F2:side:l6|F2:start, an edge the user never picked.
A blend face now comes from the picked edges it lies between; only a face that lies between no
picked edge's faces (a corner's piece over a short edge the corner took up) comes from the
taken-up edges it lies between. The chamfer is F3:blend:F2:side:l1|F2:start everywhere on it.

Persistent names: a blend face that also lay between the faces of an edge the blend ran over is
now named by its picked edge only. There is no alias for the old name (5181's
F3:blend:F2:side:l6|F2:start): a saved reference to it is reported lost.

Also corrects 5181's "what": the chamfer builds (335399.749), it is not refused.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 08:02:50 -04:00
jyvikoandClaude Opus 5.5 1e6c91a108 Fillet rig: the concave arc where a bar's top meets a cylinder its sides run tangent into
An r2 round of the arc adds the spandrel ring clipped by the bar's sides, integral over rho in
[8, 10] of [2 - sqrt(4 - (10 - rho)^2)] rho 2 asin(8 / rho) = 18.455363. With round coordinates
it builds to that; with the reported design's sketch residues (~1e-10 mm) SMLib's blend fails,
status 1001 (SmFilletNx1Corner: unable to make topology at the arc's end), listed as known
failing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 08:02:50 -04:00
jyvikoandClaude Opus 5.5 c9bf97ce49 Blends: an edge is smooth only where its faces are tangent all along it
The edge where a round runs into a cylinder's wall it is tangent to at one end (the bar's front
top round meeting the wall at (40, 0, 8), where the round's contact with the front face meets the
wall's tangent line with it) was refused as smooth, "nothing to round": the faces' normals were
compared at the edge's start alone, which was that tangent end. They are now compared at five
stations from end to end, and an edge is smooth only where its faces meet tangentially at every
one: this edge is a crease everywhere but its end. The wall's seam with the front face, tangent
all along, is still refused as smooth.

The round of that edge with its tangent chain (the top's concave arc) now reaches SMLib, whose
result fails its own check (internal poles, coincident control points, cusps where the round
fades out): its rig case in fillets is listed as known failing for that SMLib defect.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 08:02:50 -04:00
jyvikoandClaude Opus 5.5 977949819e SMLib import: an extruded circle past a turn stays its exact spline
A round of a bar's top edge, where the bar's side runs tangent into a cylinder standing on its
round end, seemed to build: SMLib's result holds the cylinder's wall as a rational spline whose
parameter range runs 393° round (u in [-15, 40.18]). Going back into SMLib (to measure the body
or change it again) the record's extruded circles become SMLib cylinders with the face's range on
them, and that range was 6.866 rad: SMLib refuses a cylinder past one turn
(SM_ERR_INVALID_INPUT from BrepFromFlat's face range check). The body could not be measured, a
second round on it failed, and the app said one of its freeform faces can't be used. An extruded
circle whose range runs more than one turn round now stays the exact spline it is.

The bar of the reported design (40 x 16 x 10 with a R8 end, a disc R8 sketched on its top and
extruded 10 up, joined): the front top round removes the spandrel up to the cylinder's wall,
integral over y in [0, 2] of (2 - sqrt(4 - (2 - y)^2)) (40 - sqrt(64 - (8 - y)^2)) = 32.306475;
the three rounds at the other top corner after it remove 53.285832 in all (spandrels outside the
corner cube, the cube less the rolling ball's eighth). Both now build and measure to 1e-7; the
curvature corner of the three edges at once (setback 3) builds too.

Rig cases (fillets) for the three reports: the curvature corner of the three edges, the front
top round, and the three corner rounds after it pass; the same corner rounds with the design's
~1e-10 mm sketch residues fail in SMLib (its corner's surface of revolution is close to singular
at its boundary) and are listed as known failing. (Their ids take the report- convention in the
rig commit later on this branch.)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 08:02:50 -04:00
Brett Lawson 51c474efbc Merge develop 739e47b9 into solidcore 2026-10-30 12:47:46 +01:00
jyvikoandClaude Opus 5.5 bf85e0a6cf Fillet rig: the knife edge's R2 round builds on the new SMLib pin
fillets/851-fillet-knife-edge-tip-r2 passes on develop's SMLib (985faae): its line
leaves KNOWN_FAILING. The chamfers of the same edge still fail.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 07:37:21 -04:00
jyvikoandClaude Opus 5.5 30dce7fbaf Fillet rig: the sloped basin's rim loops with their mitred corners' exact volumes
The owner ruled on 2026-10-30 that rounds meeting at a concave corner beside an
unpicked sharp edge are mitred, which fixes the basin loops' re-entrant corners.
Each loop case now grades its exact volume (rel 1e-6): each blend takes
Int width(z) length(z) dz, its section's width from its wall to its arc or chamfer
line (the front one clipped at the slab's face where it runs past the rim), its
length between its neighbours' walls extended; each corner of two picked edges adds
the overlap of their section prisms in the quadrant beyond both walls,
Int width_1(z) width_2(z) dz (r^3 (5/3 - pi/2) for vertical walls, as
every-pocket-rim-edges-r2). One edge alone reproduces the single-edge closed forms to
3e-7 of the removal. The equal-slope chamfer loop 0.5 passes; the others stay on
KNOWN_FAILING with the causes they had (SMLib status 1001, the surface-of-revolution
check, rounds past the rim not built by subtraction).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 07:37:21 -04:00
jyvikoandClaude Opus 5.5 ecbca1f747 Fillet rig: grade the 851 rows' rounds G1 at their own tangent seams
The 851 table rows grade continuity again, on each round's seams to the faces it
rolls on, picked by points at the middle of its edge (the top front round's at
z = 8 on the front and y = -19 on the top, the arc's at rho 23 and rho 21, the
uprights' at their contacts). The default `blend` selection read G0 there because
it pairs a blend face with the contact faces of every edge in the feature, so where
a round ends square on another edge's contact face (a crease by construction) it was
graded as a tangent seam: a gap in the grader's seam selection, worked around here
by naming the seams. All seven rows pass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 07:37:21 -04:00
jyvikoandClaude Opus 5.5 191fa98395 Fillet rig: the R7 round past a thin wall's inside corner held to its exact volume
fillets/1668-fillet-outer-top-edge-of-thin-wall-r7-past-inside-corner (and the
both-sides R7 case) now grade the volume at rel 1e-6 (0.04 mm^3), not the rig's
1e-3. The closed form is exact: V0 = 104 64 42 - 100 60 40 less the round's
section (1-pi/4) 49 along 104 plus its part over the hollow, the square
[25,30] x [35,40] outside the circle about (25,35), Int_sqrt24^5 (5 - sqrt(49-u^2)) du
= 0.0050679 mm^2 (a 0.0005 grid gives the same to 1e-9), along 100: 38458.896.
SMLib gives 38458.389, 0.507 mm^3 less: exactly that part over the hollow, which is
not material, taken anyway where the round opens its slit. The unit test's bound
was right; the case goes on KNOWN_FAILING with that cause. The both-sides case
passes at the tighter tolerance.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 07:37:21 -04:00
jyvikoandClaude Opus 5.5 94938b3b54 Kernel rig sources: the kinds of the four sources the new cases cite first
316 and 5835 are merged PRs, 545 and 616 closed issues.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 07:37:21 -04:00
jyvikoandClaude Opus 5.5 51316b7ec7 Import rig: the horn torus quarter written to STEP and read back, as a case
The round trip's volume moves from the STEP unit test to an import rig case
(616.850, Pappus); the unit test keeps the writer's logic, the degenerate torus
written as one B-spline face and no toroidal surface or surface of revolution. The
case fails today where the revolve does (KNOWN_FAILING).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 07:37:21 -04:00
jyvikoandClaude Opus 5.5 24a58066cf Sweeps rig: a circle touching its axis revolved a quarter turn, as a case
The horn torus quarter (a circle r5 touching the Z axis, revolved 90 deg) is a
sweeps rig case with its Pappus volume, pi 25 x 2 pi 5 / 4 = 616.850. SMLib's
revolve refuses the profile today (status 1001), so it is on KNOWN_FAILING.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 07:37:21 -04:00
jyvikoandClaude Opus 5.5 8b9e0e0c00 Continuity rig: an opened tube end capped G1 and G2, as cases
A cylinder r10 x 30 with its top face deleted, the rim patched G1 and G2 and
stitched, becomes two continuity rig cases: one valid solid whose rim seam reaches
the order asked (the dome's shape is the fill's own, so no volume). They fail
today as the unit test did (the general fill refuses the cap: it folds) and are on
KNOWN_FAILING; the unit test and its helpers are removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 07:37:21 -04:00
jyvikoandClaude Opus 5.5 10fe62a2b0 Surfaces rig: the cylinder and torus windows the general fill patches, as cases
A 240 deg window through a cylinder's wall and a saddle window in a torus's inner
wall, their cut faces deleted, patched G0 and G1 and stitched, become surfaces rig
cases: the G1 cylinder seals to the whole cylinder's volume within 0.5 % with G1
seams on the window's edges, the G1 torus reaches G1 on its rim, the G0 fills are
one valid solid. They fail today as the unit tests did (the general fill refuses:
it folds) and are on KNOWN_FAILING; the unit tests are removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 07:37:21 -04:00
jyvikoandClaude Opus 5.5 06f7fa501a Shell rig: the drain floors, the rounded opening and the arc-sided plate as cases
The shell unit tests that checked geometry become shell rig cases built through
commands: the trough and the pocket whose floors fall 1 deg to a central drain
(the pyramid made as two triangular prisms intersected, in place of
convex_polyhedron; the cavity integrated exactly over the cells where each moved
facet is highest, sharp inner corners as the ladder's tier 09), the box opened at
a bottom rounded R2 and R2.4 (refused: the rim would have no thickness) and R1.5
(built, exact volume), and the plate with a hole through its arc side. Four
action-matrix shells that regressed (issue-616's lid, the ring-cut frame, the
filleted shelled box shelled again, the up-down join) get small cases too. The
ones that fail today are on KNOWN_FAILING with their cause, and the unit tests are
removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 07:37:21 -04:00
jyvikoandClaude Opus 5.5 ebd1b15098 Fillet rig: the geometry of the failing fillet and chamfer unit tests, as cases
The fillet and chamfer unit tests that checked geometry become fillets rig cases,
built through commands with answers derived by hand (each method field gives the
derivation): a plate outline and a disc rim as tall as or past their wall, a
notched block's outline at R7 and R8, a cube corner as wide as its faces (refused,
and reduced), the 1668 wall at R7 alone and both sides, the 2852 U shell at R30
(refused, naming 25.24), the 851 knife edge (R2, chamfers 0.5/2/5 on three
constructions), the arc top edge at the full wall height and at 9.5, the 851
table of selections, the 556 top edge ending on the boss wall, the 2893
cylinder-rim chamfer refusals and the elliptical rim, seed 33's full round, the
sloped basin rim blends (single edges with exact volumes, loops with the slab's
box), and three action-matrix chamfers and fillets. fillets/851's three-edge
corner gets its volume (67.051 removed, re-derived on a grid; the engine test had
67.05). Chamfers whose leg runs off the face beside the edge are refused and rounds
past a face on its tangent side build, as the owner ruled on 2026-10-30. The cases
that fail today are on KNOWN_FAILING with their cause.

The unit tests are removed, except two cut to what no command can express: the
per-edge-radius refusal at a cube corner and the chamfer of a cylinder's seam.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 07:37:21 -04:00
jyvikoandClaude Opus 5.5 e9963439b1 Kernel tests: the round into a hole moves to the rig, with the hole cut the test's way
a_round_into_a_hole_is_cut_by_it (issue_324_tests.rs) built rig case
fillets/324-fillet-over-hole-overlap's body, but cut its hole with a cylinder
longer than the block (z -1 to 11) where the rig extrudes a sketch circle
flush. The new case fillets/324-fillet-over-hole-cut-by-overlong-cylinder
builds it that way (solid.cylinder, base z -1, height 12, cut) and holds it to
the same hand-derived answer: block 40x20x10 less the r3 hole at (20, 14.5)
(282.74) less the R4 round on the top edge at y = 20, 40 (16 - 4 pi) = 137.35,
plus what both remove, the integral over y in [16, 17.5] of
(4 - sqrt(16 - (y - 16)^2)) * 2 sqrt(9 - (y - 14.5)^2) = 0.375830 (re-derived
with the substitution y = 17.5 - s^2, 200000 steps):
V = 8000 - 90 pi - 40 (16 - 4 pi) + 0.375830 = 7580.287315, and G1 on the
blend. It passes today (aarch64, SMLib), as the flush case does, so it needs no
KNOWN_FAILING line; the unit test, a duplicate of the two cases, is dropped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 07:12:24 -04:00
jyvikoandClaude Opus 5.5 2f88ca2f62 Kernel rig: everyday chamfers of box edges and pocket rims
A box edge chamfered 2 and by two distances (3 and 1, and flipped, told apart by the
centre of mass); a pocket's rim chamfered 1, by two distances, 4.9 (fits), and 5 and
5.5 (refused by the owner's rule on full-width chamfers: built at 5 today).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 07:07:31 -04:00
jyvikoandClaude Opus 5.5 fd571d076a Kernel rig: everyday fillets after fillets
A box edge rounded, then the edge meeting it at the corner, in both orders (both the
three-edge rolling-ball corner); r3 then r2 (the r2 round's torus about the r3 round's
axis, by Pappus); an L-bracket's front inner outline after its bend round; a block's
top edge after the arc round at the cylinder (fails today: G0 at the round's end on the
crease); a curvature round after a curvature round with Tangent chain off.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 07:07:31 -04:00
jyvikoandClaude Opus 5.5 06e802ffee Kernel rig: everyday rounds of an L-bracket's bend
Inside bend r3, outside r5, both concentric (r3 and r8), the inside r35 using up both
inside faces, r36 refused naming 35, and the inside bend Type: Curvature.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 07:07:31 -04:00